- 29 Nov, 2018 40 commits
-
-
Carlos Caballero authored
Use ScopedTaskEnvironment instead of MessageLoop in favicon_service_impl_unittest.cc MessageLoop will go away, eventually. BUG=891670 Change-Id: I05f9b446058cdfe5e649e821fc8d87ac3e6ec764 Reviewed-on: https://chromium-review.googlesource.com/c/1352365Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#612441}
-
Tom Anderson authored
Changelog https://chromium.googlesource.com/external/github.com/cisco/openh264/+log/3b51f16a4a41df729f8d647f03e48c5f272911ff..6f26bce0b1c4e8ce0e13332f7c0083788def5fdf BUG=893594 TBR=mflodman,hbos Change-Id: I15409f2d1671f23fb785d63f1d3b2f1b0d4b5316 Reviewed-on: https://chromium-review.googlesource.com/c/1355253Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#612440}
-
Sam Maier authored
Bug: 908988 Change-Id: Iaaee8124c56945a8769e6d4ff2a0859ef39c1aea Reviewed-on: https://chromium-review.googlesource.com/c/1355424Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#612439}
-
Alexei Filippov authored
Do not assign zero distance to all GC root objects. Instead assign zero to the global root and follow strong roots only from there. BUG=906847 Change-Id: Iee22162ac11a6700e019276daee1357ef33e61b9 Reviewed-on: https://chromium-review.googlesource.com/c/1353995 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#612438}
-
Nigel Tao authored
Change-Id: I6972a8214f1402f21efe8f7afa35c8f135c996d0 Reviewed-on: https://chromium-review.googlesource.com/c/1351976Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#612437}
-
mrefaat authored
With voice search bar removal and the tab cleanup this method is not used anymore deleted it and updated unittests. Bug: 778416 Change-Id: Ia6a130f50eafb01b0eef265e98ca412071ba7b95 Reviewed-on: https://chromium-review.googlesource.com/c/1355765Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#612436}
-
Tom Sepez authored
Otherwise setting pdf_enable_v8=false breaks chrome build. Change-Id: I86c3d369b4142ad05a986363839cbc6961772bc9 Reviewed-on: https://chromium-review.googlesource.com/c/1356010 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#612435}
-
Troy Hildebrandt authored
Adds the ability to check for corruption via an IsCorrupt() function that's pure virtual on the ProtoDatabase. IsCorrupt() is also introduced in the ProtoLevelDBWrapper, and the corruption flag gets set on the Init callback after checking status. Unit tests changed slightly because the init callback needed to be put into ProtoLevelDBWrapper instead of outside so it could modify is_corrupt_, and the new use of the WeakPtr caused a race condition that meant the test always failed to trigger the callback if we don't wait for init to complete. Bug: 870813 Change-Id: Ib00435dae8cdac490053fbfc6befb95094b1edec Reviewed-on: https://chromium-review.googlesource.com/c/1355521 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#612434}
-
Gary Kacmarcik authored
Change-Id: Icd07e1501d11914209048081496ca414d58a1f71 Reviewed-on: https://chromium-review.googlesource.com/c/1356023Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#612433}
-
Renjie authored
Add total_length() and NumSlices() methods to QuicMemSliceSpan so that length of HTTP/3 data frame can be computed in QuicSpdyStream::WriteBodySlices(). no behavior change. Merge internal change: 222285071 Change-Id: Ie3e2a120fc072a9d8329e33fe5cef778aa454c39 Reviewed-on: https://chromium-review.googlesource.com/c/1351584Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#612432}
-
Charlie Andrews authored
Change-Id: I84983d2fe371ffbf0d6bdbbbf116de532fa741c7 Reviewed-on: https://chromium-review.googlesource.com/c/1340599 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#612431}
-
Jazz Xu authored
Change-Id: I390ffca8cb3273fc6e475695a3eeceb6324f741d Reviewed-on: https://chromium-review.googlesource.com/c/1354649 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#612430}
-
Mitsuru Oshima authored
This also increased the timeout for test because it can take longer on asan. TBR=hiroshige@chromium.org, xiyuan@chromium.org Bug: 910303, 910105 Test: OcclustionTest is skipped in single process mash Change-Id: I669d7343255980dd540c98aa645e5f14c641c371 Reviewed-on: https://chromium-review.googlesource.com/c/1355883Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#612429}
-
Scott Violet authored
This moves the majority of the MultiUserWindowManagerDelegate functions into the mojom. For classic mode, a mojo::Binding is created so that notification happens async (just as it will in multi-process mdoe). MultiUserWindowManagerWindowDelegate has been removed. MultiUserWindowManagerDelegate has been removed. Adds MultiUserWindowManagerDelegateClassic. Here's the comment for it: // Delegate used in classic and single-process mash mode. This delegate is // notified when the state of a window changes. In classic mode, this delegate // is called for all windows, in single-process mash mode, this delegate is // called for Windows created in ash's window hierarchy (more specifically, // Windows whose aura::Env has a mode of aura::Mode::LOCAL). For example, Arc // creates Windows that are parented directly to Ash's window hierarchy, changes // to such windows are called through this delegate. Ideally MultiUserWindowManagerDelegateClassic wouldn't be necessary, but that would require assigning unique ids for local windows, which would be rather error prone. The biggest change here is that MultiUserWindowManagerChromeOS is now notified async of the functions that were in MultiUserWindowManagerDelegate, even in classic. BUG=875111 TEST=covered by tests Change-Id: I51e8a89ae3c4e6096d0cf04dc91133781b8cb4cf Reviewed-on: https://chromium-review.googlesource.com/c/1354558 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#612428}
-
Per Åhgren authored
Bug: webrtc:8671 Change-Id: Ie1d02c21a5c9d1e53b17f929750bd0ed43785dfa Reviewed-on: https://chromium-review.googlesource.com/c/1355166Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Per Åhgren <peah@chromium.org> Cr-Commit-Position: refs/heads/master@{#612427}
-
Luciano Pacheco authored
MyFiles is being changed to allow users to create files/folders, this CL changes Wallpaper to be able to scan images in MyFiles instead of Downloads. The function |MyFilesFolderForProfile| takes care of returning Downloads path if the flag MyFilesVolume is disabled. Tested manually by loading in a device with MyFilesVolume flag enabled. Bug: 873539 Change-Id: If0e40cd1d2961ec5ca380a799c5a272823c0cede Reviewed-on: https://chromium-review.googlesource.com/c/1353031Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#612426}
-
Harley Li authored
The original palce of that link is in service worker cache table, but it makes more sense to have that link in the 'clear cache' view, since the user is probably looking at the latter when they got an exception about cache quota exceeding, which is probably caused by caching an opaque response (UI meeting 11/07). Bug: 847462 Change-Id: I99b039fc5b9617c1d0f4493dc3accce32d0385b3 Reviewed-on: https://chromium-review.googlesource.com/c/1325083Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Cr-Commit-Position: refs/heads/master@{#612425}
-
Olga Sharonova authored
(Could not use crash_reporter due to deps restrictions) Bug: 866830 Change-Id: Ia3cc17720d0d375c4a8536412df2cafb426167b1 Reviewed-on: https://chromium-review.googlesource.com/c/1355099 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#612424}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/97b903782cf5..74c126845dcd git log 97b903782cf5..74c126845dcd --date=short --no-merges --format='%ad %ae %s' 2018-11-29 dgarrett@google.com chromeos_config: Readd smaug firmware branch. 2018-11-29 achuith@chromium.org cros_vm: Wait for SSH port to free upon exit. Created with: gclient setdep -r src/third_party/chromite@74c126845dcd The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6572d22e178928abaf80556d9f6ee22ea92499b4 Reviewed-on: https://chromium-review.googlesource.com/c/1355746Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612423}
-
danakj authored
It doesn't override to arbitrary things, so let the RenderViewImpl have a better idea what is going on by only asking for a bool to use kPrerender visibility instead of shown/hidden. This will help us allow the RenderViewImpl to control the visibility of the RenderWidgets. R=dcheng@chromium.org Change-Id: I8b4bc4a8fd969c1c2e6a4c90f1269a5d41b41ba6 Bug: 908582 Reviewed-on: https://chromium-review.googlesource.com/c/1355773 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#612422}
-
Henrique Nakashima authored
This removes the dependency ChromeDataUseMeasurement has on g_browser_process (when kNetworkService is enabled) and fixes a crash when starting in service-manager-only mode. Bug: 902791 Change-Id: I0ed11f4735f4494247a7c17767b53aab695d0f14 Reviewed-on: https://chromium-review.googlesource.com/c/1334334Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#612421}
-
Quinten Yearsley authored
Change-Id: I0959c592ba6e9ec9021b665bac221625021d7df1 Reviewed-on: https://chromium-review.googlesource.com/c/1355132 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#612420}
-
danakj authored
ChromeVoxLiveRegionsUnitTest.RevealAlertLiveRegion ChromeVoxLiveRegionsUnitTest.ProgressBarLiveRegionEvents R=dmazzoni@chromium.org TBR=dmazzoni NOTRY=true Change-Id: If0e8d93719f448f8b014a7d9de33d3d764734954 Bug: 498881 Reviewed-on: https://chromium-review.googlesource.com/c/1355990 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#612419}
-
Peter Boström authored
Bug: chromium:909818 Change-Id: I0c0df3d6aa2e01a3107f6ed0e4920437d38a6f95 Reviewed-on: https://chromium-review.googlesource.com/c/1355611Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#612418}
-
Akihiro Ota authored
TalkBack does not explain how to open a new tab in Chrome when focusing the tabs button in the toolbar. Updated the content description for this button to communicate how to open new tabs Bug: 851175 Change-Id: I6dc16d09fe0a2a2902401e9e3060eaef91913e35 Reviewed-on: https://chromium-review.googlesource.com/c/1330759 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#612417}
-
Greg Kerr authored
This removes all of the obsolete unit testing code from the V1 sandbox. Bug: 902597 Change-Id: I426e3b815e0bf23036815750aab350adbb22e068 Reviewed-on: https://chromium-review.googlesource.com/c/1327527 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#612416}
-
Sebastien Seguin-Gagnon authored
This reverts commit 81b9c8b4. Reason for revert: Owner landed a fix at the same time. Original change's description: > [Sheriff] Update expecations for worklet-animation-currentTime.html > > Tbr: yigu@chromium.org > Bug: 910295 > Change-Id: If17745e818bad3224122ab99c6c63e2a1c084290 > Reviewed-on: https://chromium-review.googlesource.com/c/1355255 > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612406} TBR=sebsg@chromium.org Change-Id: I003b62c838453c6ce1a7df9787ace6bc372f1988 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910295 Reviewed-on: https://chromium-review.googlesource.com/c/1355987Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#612415}
-
Zhongyi Shi authored
- Net.QuicStreamFactory.AttemptMigrationBeforeHandshake.FailedConnectionType tracks the connection type of the default network when the original connection fails with handshake not confirmed. - Net.QuicStreamFactory.MigrationBeforeHandshake.NewConnectionType tracks the connection type of the altenate network when the original connection fails with handshake not confirmed and a new connection is about to be retried on the alternate network. These histograms may give us hints why the altenate network is not availabe when the connection on the default network fails. Current theory is that the default network is on Cellular, and there is no alternate network. Bug: 790547 Change-Id: Ibfd63efed9a1b72b7d6de95453af55feacd9cef6 Reviewed-on: https://chromium-review.googlesource.com/c/1354320Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#612414}
-
Dave Tapuska authored
BUG=879657 Change-Id: Ifc3ba15e517c79286158e77a8bb83c3c30ea1a75 Reviewed-on: https://chromium-review.googlesource.com/c/1355881Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#612413}
-
Andrew Comminos authored
Verfies that the UA measures the time before the end of header parsing in responseStart by simulating a delay after writing the status line and flushing to the client. Chrome fails this test for now, but Firefox passes. Bug: 568024 Change-Id: I61569c6a5b0d8ea2f3a06cb37a3d1ed36c06d40f Reviewed-on: https://chromium-review.googlesource.com/c/1354645 Commit-Queue: Andrew Comminos <acomminos@fb.com> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#612412}
-
Alice Boxhall authored
Original reviews: https://chromium-review.googlesource.com/c/chromium/src/+/1206050 https://chromium-review.googlesource.com/c/chromium/src/+/1242572 https://chromium-review.googlesource.com/c/chromium/src/+/1345714 TBR=dmazzoni@chromium.org Bug: 906310, 908916 Change-Id: Ie56e5030db4bb3039816c5d5d9576279435835e6 Reviewed-on: https://chromium-review.googlesource.com/c/1353062Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#612411}
-
Yusuke Sato authored
cmtm@ primarily uses the other account. BUG=None TEST=None Change-Id: I12ec23590fa3a8744d7717b63a7cda94b5ef2c52 Reviewed-on: https://chromium-review.googlesource.com/c/1355922Reviewed-by:
Christopher Morin <cmtm@google.com> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#612410}
-
Joe Mason authored
The logo now has a title attr in it for screen readers. But when its set as the background of a <span>, or as an <img> src, screen readers don't look at the tags inside. For the screen reader to view the tag, it seems the <svg> element must be part of the DOM tree, such as when it's added with <embed>. Bug: 767130 Change-Id: I5d28030fc90c269aa6a13a605f24c698915f6c5d Reviewed-on: https://chromium-review.googlesource.com/c/1352822Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#612409}
-
Jered Gray authored
This is a reland of 1b420fdb The flakiness in the original CL with ResourceLoadingHintsBrowserTest and PreviewsNoScriptBrowserTest has been fixed. RetryForHistogramUntilCountReached() now flushes the task scheduler and keeps trying until the test times out. Original change's description: > Eliminate unnecessary proto::Configuration copies > > The previous logic in OptimizationGuideService created an > optimization_guide::proto::Configuration object on a background thread > and then used task posting to send it on to > PreviewsHints::CreateFromConfig(), where it was used to create a > PreviewsHints object on another background thread. In all, there were > two tasks posted that included the config object as a parameter, one on > the background thread and one on the UI thread. Including it as a > parameter in a task requires a full copy of the protobuffer. This means > that a full copy of the config protobuf, which can be as large as 1.8MB > (the size of the current Brazil one on Canary), was occurring on the UI > thread. > > In local performance measurements, making a single copy of a 600KB > version of the protobuf took several milliseconds (it amounted to > roughly 60% of the time taken by the initial component string parsing > and 60% of the time taken by PreviewHints::CreateFromConfig()). Given > that we were incurring the cost of two copies, one of which was on an > extremely high priority thread, it makes sense to change the logic to > eliminate the need for the copies. > > The logic has been altered so that OptimizationGuideService no longer > immediately processes the component, but instead notifies the > observers that it is available and allows them to trigger the > processing. This eliminates both copies of the configuration protobuf, > as it is now created where it is used. > > Additionally, OptimizationGuideServiceObservers are now immediately > notified of the hints component when they register if one is already > available. This will enable the PreviewsOptimizationGuide to wait until > the HintCacheLevelDBStore is fully initialized before registering for > the component, and in the future will potentially allow it to avoid > processing the configuration altogether when the store already has the > latest version cached. > > New unittests have been added and older ones have been updated to > accommodate the new logic. > > The related browser tests have also been modified to be more robust, > where they now wait for a signal from a local histogram indicating > that hint processing is complete. Bug: 908985, 910251 Change-Id: I90407db4c19dac29e10f756a6de87294a9ab683b Reviewed-on: https://chromium-review.googlesource.com/c/1355256 Commit-Queue: Jered Gray <jegray@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#612408}
-
Vincent Boisselle authored
Change-Id: Ic84e3b2fc4126937a4227d20f0acf03a2f8bcfba Reviewed-on: https://chromium-review.googlesource.com/c/1355425Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Vincent Boisselle <vincb@chromium.org> Cr-Commit-Position: refs/heads/master@{#612407}
-
sebsg authored
Tbr: yigu@chromium.org Bug: 910295 Change-Id: If17745e818bad3224122ab99c6c63e2a1c084290 Reviewed-on: https://chromium-review.googlesource.com/c/1355255Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#612406}
-
Gary Kacmarcik authored
Currently, this just sends a message with the desktop display configuration so that it can be added to the client logs. The display information must be gathered in the Desktop Process (DesktopSessionAgent) and then IPC'ed over to the Network Process. A temp hook from the DesktopSessionProxy to the ClientSession is added since there is no webrtc path for this message (so it can't follow the normal path from DesktopSessionProxy -> VideoFrameCapturer -> VideoStream -> ClientSession). Change-Id: I0a6b620b3b21aa16e6d978a92ece94f8440dc02c Reviewed-on: https://chromium-review.googlesource.com/c/1352730Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#612405}
-
Devlin Cronin authored
Update the permissions API documentation to note that: - "origins" contains origins associated with content scripts - The API can be used to request permission that were withheld by the user. Bug: 889654 Change-Id: I63cbc3f4e80e6cc26532e9714dd8de7a8086b97c Reviewed-on: https://chromium-review.googlesource.com/c/1347039 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#612404}
-
Emil A Eklund authored
When shaping the content of an inline node in NGInlineNode::ShapeText we assume that the number of runs is small and iterate over all of the runs for each inline item. This assumption holds true for most content, there are certain cases where the assumption is incorrect however, such as the euckr-decode-ksc_5601.html WPT test where each CJK glyph is wrapped in a span and separated by space characters of a different glyph. This causes each of the 10k+ items to iterate over 10+ runs which is very expensive. This patch adds an optional context argument to ShapeResult::SubRange so that context (the relevant run) may be maintained across invocations and thereby avoids an extra loop over all of the runs for each SubRange call. Change-Id: I2ee610a60e33fe4389277fc275a9b8d670453a31 Reviewed-on: https://chromium-review.googlesource.com/c/1354561Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#612403}
-
Yi Gu authored
In crrev.com/c/1343558 I incorrectly marked an innocent test as flaky. TBR=hiroshige@chromium.org Bug: 910297 Change-Id: Ide4bd6e50c4a4a89f577367d640939efedbb30df Reviewed-on: https://chromium-review.googlesource.com/c/1355776Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#612402}
-