- 22 Aug, 2018 40 commits
-
-
Joe Mason authored
R=wfh Bug: 830892 Change-Id: I0a4b25b2ba04b65a80e2c03e9151b5ef55912432 Reviewed-on: https://chromium-review.googlesource.com/1171737 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#585025}
-
Joe Mason authored
Launch chrome_cleaner unit tests without using job objects on win7 to make sure SpawnSandboxTarget works. Bug: 871924 Change-Id: Ie9b80894851cc2f7420a79e4fe3fffaf8e849a4a Reviewed-on: https://chromium-review.googlesource.com/1171659 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Cr-Commit-Position: refs/heads/master@{#585024}
-
dalyk authored
This URI template parser will be used by the DoH implementation to interpret DoH servers and to construct requests. The URI template parsing code is derived from the public Google API C++ Client code with significant modifications. Bug: 872987 Change-Id: Ia9a1c761a16607911034c1d8419fed82b7e918dd Reviewed-on: https://chromium-review.googlesource.com/1170591 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#585023}
-
Lindsay Pasricha authored
Bug: 856622 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I250a7899963fa1d43aabb6419e7044677b61b975 Reviewed-on: https://chromium-review.googlesource.com/1114918 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585022}
-
Jeremy Roman authored
This matches the API of base::Lock, which we intend to eventually switch to, better, and doing a DCHECK is the only reasonable thing to do with the result of Locked anyhow. Bug: 856641 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibd31cb7d1c0982929b6aa09135c7b331cadec984 Reviewed-on: https://chromium-review.googlesource.com/1183633Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#585021}
-
Sahel Sharify authored
Please find the intent ot implement here: https://groups.google.com/a/chromium.org/forum/?hl=en#!topic/blink-dev/53q-wRk5QkA Bug: 626196 Change-Id: Id77ceb7352629a6a9417617602d330919904ed44 Reviewed-on: https://chromium-review.googlesource.com/1183538Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#585020}
-
Sahel Sharify authored
TBR=jonross@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874162 Change-Id: Ic8dcdd70cdd5dc5c606d58195121251783a744d4 Reviewed-on: https://chromium-review.googlesource.com/1184219Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#585019}
-
Yao Xiao authored
if ad script is in stack. Bug: 864160 Change-Id: I6ccac6ae44cfbb0d8bb98d8502b7f85da00479b3 Reviewed-on: https://chromium-review.googlesource.com/1176266 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#585018}
-
Nicolas Ouellet-payeur authored
s/v4_update/g4_update/ Change-Id: I7e49423763afddaaebad5b326dfd4f447398d531 Reviewed-on: https://chromium-review.googlesource.com/1184110Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#585017}
-
Tommy Martino authored
Per UX request (see bug). See also screenshots (Googlers only): https://docs.google.com/presentation/d/1IeyKg22nSbt8aDkvCGrHx1SBg7UBQIqymWDj2sLJ9JQ/edit#slide=id.g3fd38cc212_0_5 Bug: 876291 Change-Id: I8c782d42a5901286ee2c657b7625fbdab4dd62a2 Reviewed-on: https://chromium-review.googlesource.com/1184057Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#585016}
-
Martin Robinson authored
Bug: 866337 Change-Id: I316fa8be8ce10f638f67fbc7e1eb28d05f1c0ab3 Reviewed-on: https://chromium-review.googlesource.com/1183321 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#585015}
-
David Bokan authored
Update visual viewport unit tests for blink gen property trees. BGPT still creates layers in the compositor so the changes are fairly limited. In places where we check layer properties, this patch also adds checks for the equivalent paint properties. Bug: 836915 Change-Id: I3d821cea1021b28d87ceff188931eaae3fa3b7c4 Reviewed-on: https://chromium-review.googlesource.com/1184963Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#585014}
-
Guido Urdaneta authored
This reverts commit ba40c8a2. Reason for revert: Causing failure on Linux Tests (dbg) bot. See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/52253 Sample logs: [ RUN ] AXPlatformNodeAuraLinuxTest.TestAtkText ../../ui/accessibility/platform/ax_platform_node_auralinux_unittest.cc:871: Failure Value of: ATK_IS_TEXT(root_atk_object) Actual: false Expected: true Stack trace: #0 0x000008299a59 StackTraceGetter::CurrentStackTrace() #1 0x0000082be414 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #2 0x0000082bd86e testing::internal::AssertHelper::operator=() #3 0x00000821fe0c ui::AXPlatformNodeAuraLinuxTest_TestAtkText_Test::TestBody() #4 0x0000082f91eb testing::internal::HandleSehExceptionsInMethodIfSupported<>() [ FAILED ] AXPlatformNodeAuraLinuxTest.TestAtkText (2 ms) Original change's description: > Expose the basic AtkText interface for text elements > > AtkText is the proper way to expose static text to accessibility agents. > This change adds initial support for the interface, but there is quite a > bit of work left to properly expose hypertext as well as implement the > rest of the required interface functionality. > > Bug: 866337 > Change-Id: Iab121b1b18bc00bcbdd35bfa310e7a1a2b141e18 > Reviewed-on: https://chromium-review.googlesource.com/1179752 > Commit-Queue: Martin Robinson <mrobinson@igalia.com> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584989} TBR=dmazzoni@chromium.org,mrobinson@igalia.com Change-Id: Idb25bb0c8bd494b10f6eed2fd213552178a5f62b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 866337 Reviewed-on: https://chromium-review.googlesource.com/1184924Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#585013}
-
Ehsan Chiniforooshan authored
I changed the metric name in https://chromium-review.googlesource.com/c/catapult/+/1181702. This CL comments out the test for that metric so that the Catapult roller is unblocked. After Catapult is rolled to after the renaming CL the test should be re-enabled. Bug: 876276 Change-Id: Ie83b3cd86c6324ea00cdad0da5f9b1c082fd558a NOTRY=true # CQ flake Change-Id: Ie83b3cd86c6324ea00cdad0da5f9b1c082fd558a Reviewed-on: https://chromium-review.googlesource.com/1183694Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#585012}
-
Guido Urdaneta authored
Bug: 875544 Change-Id: I8d2b81e6131df537fbea872753e08cf8f638783f TBR: huayinz@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1184910Reviewed-by:
-
Gauthier Ambard authored
This CL makes sure that it is possible to exit fullscreen by tapping the collapsed toolbar. For now, it is possible to exit it by tapping the steady view. Bug: 862557 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I31667dd679d1b38f41d819197aedc54c76024ab4 Reviewed-on: https://chromium-review.googlesource.com/1184912Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#585010}
-
Javier Ernesto Flores Robles authored
Adds the new icon for addresses and for keyboard. Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I775b06b39a8f797c16669511ab8aa057bdd14133 Reviewed-on: https://chromium-review.googlesource.com/1183223Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#585009}
-
Takuto Ikuta authored
Currently there are some more people actively working on determinism things. Derived from https://chromium-review.googlesource.com/c/chromium/src/+/1183999#message-173c888fec19d325b8f1c8b4a1e8d835b82b52aa Change-Id: I0306ad04dc0e7cb71592daa5a5005eb423ea4236 Reviewed-on: https://chromium-review.googlesource.com/1184124 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#585008}
-
Ehsan Karamad authored
The method CreateMimeHandlerViewGuestIfNecessary() has an implementation in mime_handler_view_container_base.cc. It is marked as abstract by mistake. TBR=wjmaclean@chromium.org Bug: 659750 Change-Id: If4751752f05ff120f47c7d65a5a6c3189aa08ac3 Reviewed-on: https://chromium-review.googlesource.com/1184119Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#585007}
-
Joe Mason authored
If the sandbox target process is very short-lived (as in some multiprocess tests), and also takes long enough to spawn that the first TimedWait on the init done notifier times out, then there's a race between the target process exiting and the parent process calling TimedWait again. Instead of polling in a loop, use WaitForMultipleObjects to wait for both the init done notifier and process exit. TBR=csharp TBR_REASON=Already reviewed in internal repo. Bug: 874387 Change-Id: I86af661bbe43f3fc044fb5afd6bcbd9f9d7b297c Reviewed-on: https://chromium-review.googlesource.com/1184214Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#585006}
-
Robert Phillips authored
Skia's mask-filter occlusion rect feature has been defunct since the Skia CL: https://skia-review.googlesource.com/c/skia/+/147561 (Remove occluder feature from blur mask filter) Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iaa5656f0ff9e4b99500389651789f549f4352846 Reviewed-on: https://chromium-review.googlesource.com/1183623Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#585005}
-
Juan Antonio Navarro Perez authored
Add a function to conver the data returned by test-results server about known masters, builders, and test_types into a DataFrame for more convenient querying of the data on it. Also add a corresponding unit test. NOTRY=true Bug: 875251 Change-Id: Ifa03250669fe3b661f093ff0e1ca172db85fade6 Reviewed-on: https://chromium-review.googlesource.com/1179888 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
-
Alexander Hendrich authored
This CL adds a python schema validator that can validate JSON schemas. The schema validator is used in a presubmit to validate all the schemas in policy_templates.json. The schema validator itself supports the minimal set of features needed for our current policies. Bug: 873641, 856903, 856901 Change-Id: Ie577e825807e4438eca6921722b88af7c8d1781c Reviewed-on: https://chromium-review.googlesource.com/1172433 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#585003}
-
Guido Urdaneta authored
Bug: 876623 Change-Id: I086440a188e915894393805a9973d1419efc3d06 TBR: tapted@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1185010Reviewed-by:
-
Leonard Grey authored
This is a temporary patch to merge back to 69 while we figure out the root cause. Bug: 876201 Change-Id: Id87ac81f16b1cd3102c8605691421e8bc53dc401 Reviewed-on: https://chromium-review.googlesource.com/1183991Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#585001}
-
Guido Urdaneta authored
Bug: 8766133 Change-Id: I8e6656d381de3db9add7fc99b0ac091db816d59f TBR: ccameron@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1185005Reviewed-by:
-
Noel Gordon authored
Document all steps. Use ArrowDown key to select a file list item (Ctrl is not needed) and check its fakeKeyDown return value. Also rename the helper to selectFirstFileListItem, and use class and id selectors when querying for file list row item selection. Test: browser_tests --gtest_filter="CreateNewFolder/FilesApp*" Bug: 876267 Change-Id: I230ca4a54069c79169eac7a44003d81cd57d3c64 Reviewed-on: https://chromium-review.googlesource.com/1183271 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#584999}
-
Philip Jägenstedt authored
https://chromium-review.googlesource.com/c/chromium/src/+/1184510 is the most recent failure to import due to this test. This test fails passes on try bots but fails in CQ for Linux and Win. Include timeout in expectations too since that is the current state. TBR=robertma Bug: 875622 Change-Id: I24662da5bf918941e59bd331a7871050c798d177 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1184904Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#584998}
-
Guido Urdaneta authored
This test is flaky on Linux TSAN. Bug: 876561 Change-Id: Ie389a8cf31a40513057d32d6ce89e44765e7c0ee TBR: erikchen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1184908Reviewed-by:
-
Tatsuhisa Yamaguchi authored
Before this change the button was OFF when the window appears and then updated with animation after that. Test: manual Bug: 868307 Change-Id: Iac019198518415ae5c98cc716d85c90f014d8fae Reviewed-on: https://chromium-review.googlesource.com/1177220Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#584996}
-
Tatsuhisa Yamaguchi authored
We have hidden the lock icon badge in the status tray to avoid visual clutter, but the logic was not applied on dark color icons in OOBE. Test: manual test by connecting to an encrypted wifi access point at OOBE Bug: 874012 Change-Id: I529591faeba8febfce918dd400cc3d230da58658 Reviewed-on: https://chromium-review.googlesource.com/1177081Reviewed-by:
-
Guido Urdaneta authored
Bug: 876362 Change-Id: I0365a4e466c49b8cb05eec5b808a81ce83f9c58c TBR: alemate@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1185004Reviewed-by:
-
Tatsuhisa Yamaguchi authored
The color of disabled icons are different from the inactive ones. Disabled means the function is not available, whereas inactive means the toggle state is turned to OFF. Bug: 853695,875459 Change-Id: I0f4115483f5477720e65b7a0d25c7f5f79a184e5 Reviewed-on: https://chromium-review.googlesource.com/1181015Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 385952ee. With Chromium commits locally applied on WPT: 2160c22c "Modify source path for wpt test of Accept-CH" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23128 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ericwilligers@chromium.org: external/wpt/css/motion kojii@chromium.org: external/wpt/css/css-scoping meade@chromium.org: external/wpt/web-animations rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I9740569ef2c1edab2be41615fe7ad625cb052abd Reviewed-on: https://chromium-review.googlesource.com/1184961 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#584992}
-
kylechar authored
OwnedMailbox is ref counted and can outlive the GLES2Interface* it holds. This is because the callback has a scoped_refptr<OwnedMailbox> which prevents destroyed the OwnedMailbox. The ownership model for OwnedMailbox should probably be reworked, but the class will be replaced fairly soon anyways. Change callback to hold a WeakPtr instead of scoped_refptr so that OwnedMailbox gets destroyed at the correct time. OwnedMailbox is also no longer used with GLHelper and the shared main thread context, so it doesn't need to be a ContextFactoryObserver to find out about losing the shared main thread context. Delete ImageTransportFactoryTearDownBrowserTest.LoseOnTearDown which tested the now deleted functionality. Bug: 874616 Change-Id: Iab95a906c4006427e0a0046c56fe20f75d9788a6 Reviewed-on: https://chromium-review.googlesource.com/1178221 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#584991}
-
W. James MacLean authored
kGestureDoubleTap is used by Android only, and page scale animations should only be iniitated in the main frame renderer. WebViewImpl has special handling logic that avoids sending this event to EventHandler, but the current (incomplete) implementation for OOPIFs in WebFrameWidgetImpl does forward it to EventHandler, hitting a variety of NOTREACHED points along the way. This CL modifies WebFrameWidgetImpl to drop this event without sending it to EventHandler, and return the same status as WebViewImpl does. Bug: 734209 Change-Id: I900111df370a70b1db418660135e7e00e0f2508e Reviewed-on: https://chromium-review.googlesource.com/1183942 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#584990}
-
Martin Robinson authored
AtkText is the proper way to expose static text to accessibility agents. This change adds initial support for the interface, but there is quite a bit of work left to properly expose hypertext as well as implement the rest of the required interface functionality. Bug: 866337 Change-Id: Iab121b1b18bc00bcbdd35bfa310e7a1a2b141e18 Reviewed-on: https://chromium-review.googlesource.com/1179752 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
-
François Beaufort authored
This makes sure close button is always visible when Picture-in-Picture window is focused or hovered (even when video ends). Bug: 875736 Change-Id: I4c9a35d1e985eee4c7e869d2559032d303e51307 Reviewed-on: https://chromium-review.googlesource.com/1181133 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#584988}
-
Denis Kuznetsov authored
Fake implementation still reads configuration provided via command line. Bug: 854101 Change-Id: I88cb4466cbc5118218251e14b20c92f2806acf30 Reviewed-on: https://chromium-review.googlesource.com/1183497 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#584987}
-
Guido Urdaneta authored
This test is flaky on Linux TSAN. TBR: enne@chromium.org Bug: 707711 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I88e4510fd3fc151de8f69b5b9632e6d5709ccd81 Reviewed-on: https://chromium-review.googlesource.com/1184845Reviewed-by:
-
