- 04 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5a42da564fbe..6b60dfd80e3d git log 5a42da564fbe..6b60dfd80e3d --date=short --no-merges --format='%ad %ae %s' 2019-10-04 cnorthrop@google.com Vulkan: Remove image views forced to one mip level 2019-10-04 geofflang@chromium.org GL: Update RenderbufferGL to use ANGLE_GL_TRY. 2019-10-04 geofflang@chromium.org GL: Fix support for glCopyTextureCHROMIUM with source rectangle textures. Created with: gclient setdep -r src/third_party/angle@6b60dfd80e3d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: chromium:990368 Change-Id: Icb5a13f09e5db77d285c5fd38776e766131b2b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841714Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702961}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/666d4144..35874570 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8191957d965c659258d5e398cd90fe2c1270d6cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841533Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702960}
-
Ioana Pandele authored
This is a reland of 3dd37620/ The previous CL was reverted since it was thought to have broken http/tests/credentialmanager/credentialscontainer-get-with-virtual-authenticator.html on Win10 Tests x64. Relanding since it's an iOS-only CL, which couldn't have broken windows layout tests. TBR=vasilii@chromium.org Original change's description: > Reland "[iOS] Make the leak detection backend available on iOS" > > This is a reland of 74640a89 > > TBR=vasilii@chromium.org > > Original change's description: > > [iOS] Make the leak detection backend available on iOS > > > > Bug: 986317 > > > > Change-Id: I9d799cd24551f13bc58eac91c843d2da19aa7851 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832267 > > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > > Commit-Queue: Ioana Pandele <ioanap@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#702059} > > Bug: 986317 > Change-Id: I490b8d96074e1786b74905a083f0554fe914b4c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840771 > Reviewed-by: Ioana Pandele <ioanap@chromium.org> > Commit-Queue: Ioana Pandele <ioanap@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702835} Bug: 986317 Change-Id: I4d48f378e44677d02c4f316cc406209195dabc6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841553Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#702959}
-
Gabriel Marin authored
BUG=b:142130923 Change-Id: I2401c97b6e00b849a41c6cfe71007d7ab31fe3a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842119Reviewed-by:
Gabriel Marin <gmx@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#702958}
-
Avery Musbach authored
When you are dragging from overview in split view and you rotate the screen while a snap preview is shown, the bounds of the snap preview shall update for the new screen orientation. Test: manual Bug: 1011391 Change-Id: I21f6946d7e31bd19551a69b28126e9af2f443c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842171Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#702957}
-
Daniel Rubery authored
The BrowserURLLoaderThrottle now checks the current BrowserContext to determine whether real-time checks are enabled at all, then passes that information to the SafeBrowsingUrlCheckerImpl. Bug: 991394, 963165, 1001566 Change-Id: I5dbff848a4ea5a6ae3ac5c76e5d5624596ee3616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825482Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#702956}
-
chrome://sandboxAlex Gough authored
There should be no functional changes. Existing js will now have its types checked by the closure_compile target on builds. Bug: 997273 Change-Id: Ieb9d06b4260238b72381863d5efae49840b61122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836136 Auto-Submit: Alex Gough <ajgo@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#702955}
-
Josh Karlin authored
Change-Id: I7b724df7fcd92ee7cb0f400cc03937987241e0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717909Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#702954}
-
John Emau authored
This will be useful if the progress bar does not start at 0 or if the value set is not 0-100 such as a text value. Bug: 963183 Change-Id: Idc00352a2663629041d1ea30b0bebf27cbf31085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701633Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: John Emau <John.Emau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#702953}
-
Eric Stevenson authored
Hit this in crbug.com/1011149: moving a file without changing its contents doesn't cause it target to appear stale, so an incremental build could pass even if there are issues (ex. didn't update package to match the new file path). Bug: 1011149 Change-Id: I280f27deaf2d5e4f8cebe464d7f3afb6965cdbbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841814Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#702952}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f77a4786a334..f0d7ef8e4fe6 git log f77a4786a334..f0d7ef8e4fe6 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 primiano@google.com gen_android_bp: use gn_utils Created with: gclient setdep -r src/third_party/perfetto@f0d7ef8e4fe6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:132880619,chromium:115873049 Change-Id: I9698d66535e61d56f2dd8f50c85ba1d7d809c64c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841653Reviewed-by:
-
Alex Chau authored
- Wire up SharingSyncPreference and LocalDeviceInfoProvider - Added RefreshLocalDeviceInfo to update SharingInfo in sync Bug: 991971 Change-Id: Ic03a9d3f276b37eebe1eebd4d3afb52b5d5644ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816503Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#702950}
-
Jesse McKenna authored
This change enables PWAs registered as file handlers to appear in the "Open With..." menu with a custom icon on Windows 8 and later. On Windows 8 and later versions, when an application is registered as a handler for a file type, the icon that is displayed in the "Open With..." menu next to the application's name is controlled by registry value HKCR/<application ProgID>/Application::ApplicationIcon. This value can be a reference to an executable or .ICO file, and has the syntax ".../my_icon.ico,0". This change extends ShellUtil::AddFileAssociations(), which will soon be used to register Progressive Web Apps (PWAs) as file handlers on Windows, to set ApplicationIcon. Bug: 960245 Change-Id: If9ef55d21d71b00b47ce3246b333efa38c2965cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832464Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#702949}
-
Dmitry Gozman authored
This moves the call up from DocumentLoader to FrameLoader, so that we can combine it with other client calls (like DidStartProvisionalLoad). DocumentLoader::InstallNewDocument has been split into two parts (InstallNewDocument and CreateParserPostCommit) - before and after DidCommitLoad. Old call hierarchy: - DocumentLoader::StartLoading - DocumentLoader::StartLoadingResponse - DocumentLoader::FinishNavigationCommit - DocumentLoader::InstallNewDocument part1 - DocumentLoader::DidCommitNavigation - Client::DispatchDidCommitLoad - DocumentLoader::InstallNewDocument part2 ... loading response New call hierarchy (note that order is the same): - DocumentLoader::StartLoading - DocumentLoader::FinishNavigationCommit - DocumentLoader::InstallNewDocument part 1 - DocumentLoader::DidCommitNavigation - Client::DispatchDidCommitLoad - DocumentLoader::StartLoadingResponse - DocumentLoader::CreateParserPostCommit equals InstallNewDocument part2 ... loading response This corresponds to the step 7.d from the doc linked to the bug. Bug: 855189 Change-Id: Ifb6fb8f732f4f4250c2879268c2c3c083101aec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818292Reviewed-by:Camille Lamy <clamy@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#702948}
-
Francois Doray authored
content::LockObserver is notified when a frame starts/stops holding lock, i.e. when the number of locks it holds switches between zero and non-zero. The observer interface will be used by Chrome to avoid freezing tabs that hold Web Locks. See discussion for context: https://groups.google.com/a/google.com/d/msg/chrome-catan/kwOKhvrMGfU/gEUTPUtUAwAJ Bug: 980533 Change-Id: Ie94929f739200d7afaca6b25e5db9bed0625b40c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815729Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#702947}
-
kylechar authored
SkiaOutputSurfaceImpl did not handle the color space changing after it was created previously. The SkSurfaceCharacterization color space was only set during the first time Reshape() ran when the charactization is returned from the GPU thread. If the color space was changed later the SkSurface and SkDDL color spaces no longer matched and draw failed. Bug: 1009452 Change-Id: Ib6d2083efc7e7eb6f94782342e92a809b69d6fdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841811Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#702946}
-
Ryan Sturm authored
We experimented with this feature on Android only, and determined it is worth launching. We will explore this space more in the future (especially Desktop experiments). The launching arm is slightly different than what was in fieldtrial_testing_config.json as HTML+CSS+SyncScript performed best in Stable. Bug: 934466 Change-Id: Id5d4e5ea9558133704639a5cc902e520a2bf6370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838756Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Auto-Submit: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#702945}
-
David Benjamin authored
See https://boringssl-review.googlesource.com/c/boringssl/+/37944 for the rationale. Bug: 950706, 958638 Change-Id: I221b0e7f6f626968fc38e0bce84260e4141c5e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838456Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#702944}
-
Toni Barzic authored
Test fixes: AppListPresenterDelegateZeroStateTest.ClickSearchBoxInTabletMode * test was incorrectly calculating search box bounds in midst of an animation - fixed by making animations non zero length after initial test state was set up AppListModelFolderTest.FolderItem * tests behavior expected when the feature is off AppListViewTest.AppsGridViewVisibilityOnReopening * with the new feature, apps grid is shown faded in the background on search results page - updated the expectation BUG=976947,976954 Change-Id: Ia571dc6026b5d0c0dd512e6dc69e2d22492343ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838928 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#702943}
-
Koji Ishii authored
This patch eliminates the call to |HandleOverflow| when the |NGLineBreaker| state is 'overflow'. r701601 (crrev.com/c/1826063) added the 'overflow' state to |NGLineBreaker|. This state makes the `trailing' state more efficient, but when multiple text runs appear without any break opportunities in the 'overflow' state, the change added a call to |HandleOverflow| on each text run. Bug: 1010487 Change-Id: I608b704a9b65f905e6b57c245ea8f5dac7194c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838791Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#702942}
-
Mario Sanchez Prada authored
This CL eliminates the need for having those versions of these templated methods available by migrating the few references to the old Mojo types in those places that interact with them, so we can remove them along with such migrations, all in one go. Bug: 955171, 978694, 936482 Change-Id: I42925b0fc504c00a9ce419f9b7d7298c7a33766a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832810Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#702941}
-
Mikhail Khokhlov authored
Skipped stories may have traces and metrics defined but it doesn't make sense to run metrics computation on them. Bug: 981349 Change-Id: Id1453a9d00a83c12975ccacb45f2c8ffcd9815d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841334 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#702940}
-
Jacob DeWitt authored
Make boxes stop moving when the viewer pose has emulatedPosition = true This gives a way to see if the emulatedPosition value is properly set without having to take off the headset or look at console logs. This is useful when testing how things behave during tracking loss. Bug: 1011103 Change-Id: Icebe492fd291b394674b12fc50181d48778ffbe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838479Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#702939}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/bd522862a0b4c84a0ed8e37096d1c361dc6beaa9..6a2609dae219e4300dfc62b2a37f10b5c845547b The following commits have Chromium bugs associated: 0e7dbd579 Add an option for explicit renegotiations. Bug: 950706, 958638 Change-Id: I40db860b754ccafb281e8a6b89d5a5a36c818290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838623 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c4c5d7998d6e..d6f6e364665a git log c4c5d7998d6e..d6f6e364665a --date=short --no-merges --format='%ad %ae %s' 2019-10-04 wbbradley@chromium.org build api metrics: update metrics proto buf to add gauge support Created with: gclient setdep -r src/third_party/chromite@d6f6e364665a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I7fefc163dfd296459967baf94b01f9e6d650d9bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841817Reviewed-by:
-
John Emau authored
The private class member _anchorElement was previously not Initialized in the constructor, besides improving the code style this also changes the _anchorElement from an inferred type to a declared type in the closure compiler typing system which improves type checking [1]. [1]: https://github.com/google/closure-compiler/wiki/Types-in-the-Closure-Type-System#differences-between-inferred-and-declared-types Test: Click the source link on a console message and ensure the source is revealed. Change-Id: I17587d9504128c0c08926c4521a0106e584508ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816963Reviewed-by:
-
John Budorick authored
rather than tools/. follow-up to crrev.com/c/1827248. going to relocate tools/android/avd/ in another follow-up CL, but doing this to unblock webrtc. Bug: 922145 Change-Id: I1a3579321fb1f67e429d8cc113abed0301da909a Tbr: agrieve@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841774Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Abigail Klein authored
Ensure that strings received by accessibility_ui message handlers are not longer than 5000 characters. This ensures that a bad actor cannot send a long string as a filter and overwhelm the buffer. Bug: 785493,959368 Change-Id: Idbf9cb5ce137fdc782370cba12ead9a542574854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829954 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#702934}
-
John Lee authored
This CL only adds the UI as the data is not available yet. https://imgur.com/a/VQoMieT Bug: 1011064 Change-Id: I4f41ccf66dbbc9d7f0f7b38a0dc11313dbda9929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835690 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
-
Marina Ciocea authored
When sharing a tab that does not have a URL, host or tab title, the tab sharing infobar should simple display "Sharing a tab". Add message resource for this case. Bug: 1011379 Change-Id: Ibe67b32f3eb55695067c534552559cec8b0f19e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841851Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#702932}
-
Jarryd authored
Change-Id: Ic6af52c690e436769a42ea1d24a0ace4337d8296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841871 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#702931}
-
Maxim Smirnov authored
The feature is enabled by default for some time now, so it is suggested to removed it from code. R=avi@chromium.org Bug: 603 Change-Id: I7a25ff9ae7c93a01ad536a29eafa10165749482e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800408Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I2ea9c3f9e18e01dcb3be772c59d7f8daadfb3a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837526Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#702929}
-
Andrew Xu authored
Mainly two modifications in this CL: (1) When no arrow button shows, ensures that the shelf view's bounds are not changed by adding/removing a shelf item. It helps the correct bounds animation for shelf items. (2) Only notify scrollable shelf of shelf view's changed preferred size when adding/removing shelf items. Bug: 1009392 Change-Id: I60dc640ee19abc51eddc66a658d14b2ea2af5b0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838993 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
-
Vladimir Levin authored
This patch uses intersection observer to activate display locked elements on viewport intersections. R=chrishtr@chromium.org, szager@chromium.org Change-Id: I0c28920ccf8322f11c56c3104bb4b7d9b40e344c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835683 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#702927}
-
Samuel Huang authored
This reverts commit 8f0dc968. Reason for revert: Suspected of causing webkit_layout_tests to fail in http/tests/misc/frame-detached-in-animationstart-event.html on WebKit Linux ASAN. Original change's description: > Don't PostTask the RenderWidget::Close() call. > > The post task in RenderWidget was in order to keep IPC receipt of > destruction of a frame-based RenderWidget (ie a RenderView in the past) > from happening while the RenderWidget was already closing due to the > renderer-side detaching, but running a nested message loop. > > The RenderView destruction now already does a PostTask hop in > RenderThreadImpl before starting destruction of the RenderViewImpl > and its frame tree and RenderWidgets. A RenderWidget for a frame closes > when the frame detaches, and that is built to be consistent even if > it occurs inside of unload. The RenderWidget does not need to be kept > around after the blink frame and RenderFrame and WebWidget associated > with it are all gone. > > Popups and pepper RenderWidgets can close during a frame unload without > a consistency problem. > > R=dcheng@chromium.org > > Bug: 419087 > Change-Id: Ia5f7ca07395f8a5bd2c60a974a0fb4fb5092d872 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832612 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702868} TBR=avi@chromium.org,danakj@chromium.org,dcheng@chromium.org Change-Id: I6edf67e9d004c7f2fb4f3edd36b2a86f4cb5f27a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 419087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841941Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#702926}
-
Lei Zhang authored
The HTML file lives inside chrome/, which iOS does not use at all. Change-Id: I0dfdcf240a8030dd69c8ca4804522e7f3990a87e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839635 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#702925}
-
chrome://conflictsEric Lawrence authored
- Enable hover highlighting for rows of the conflicts page. - Allow filtering module list by hosting process type. - Remove dead CSS classes. Bug: 1010574 Change-Id: Ib02da5a17931ebfff963cff5cc0718f0f1e03b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834947 Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#702924}
-
Lucas Furukawa Gadani authored
Bug: 984550 Change-Id: Icd4079ef0296a73c864adf7e765690cbb2682829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833316Reviewed-by:
-
Sergio Villar Senin authored
There are several includes of that header because code in chrome/browser uses WebPluginAction::Type enum. In order to remove the dependency, the web_plugin_action.h file was moved to third_party/blink/public/common/plugin. Since the file is no longer in the public/platform/ directory we are also renaming it to PluginAction. Bug: 1008303 Change-Id: If0b370d23ca211cd3e5a85a845c86ac9821271e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837622 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#702922}
-
