- 03 Jan, 2019 40 commits
-
-
Justin Cohen authored
Nobody appears to use this and it will be removed in the future. Change-Id: I3caadee3e4f4cec2a2f0d9e4d8717f9b1a16afe6 Reviewed-on: https://chromium-review.googlesource.com/c/1394704 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#619720}
-
Charlie Andrews authored
TBR=nyquist@chromium.org Bug: 918874 Change-Id: I45eaab1c4f4ba92d6a90f2826b92fa3c3eb37774 Reviewed-on: https://chromium-review.googlesource.com/c/1394823Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#619719}
-
Steven Bennetts authored
For header file moves in src/chrome: TBR=sky@chromium.org Bug: 918682 Change-Id: I2cc795ada277560503aa4183075a94825d876c54 Reviewed-on: https://chromium-review.googlesource.com/c/1394003Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#619718}
-
John Chen authored
This is a reland of 70ffd447 Original change was reverted due to test flakiness on Mac, caused by: * Pause time often goes above the upper limit of 300 ms, sometime more than double the limit. * Occasionally the first event is missing. The following changes are made to improve test reliability: * Remove the check of an upper limit for the pause time. With the wide range of actual pause time, there appears to be no feasible upper limit to use. * The first significant event is now pointer down instead of key down, to ensure that the target element receives focus. The previous dependence on autofocus attribute appears to be unreliable. * Change mouse button from 1 (middle) to 0 (left), as the middle mouse button triggers paste on some platforms. (It was a typo.) Original change's description: > [ChromeDriver] Handle pauses in Perform Actions > > W3C spec allows the app to specify pauses within Perform Actions command > (https://w3c.github.io/webdriver/#dfn-dispatch-actions). Updating > ChromeDriver to handle these pauses. > > Bug: chromedriver:1897 > Change-Id: I533179f4a9f2216bfacf0f4fdb539c8f898bed07 > Reviewed-on: https://chromium-review.googlesource.com/c/1392281 > Commit-Queue: John Chen <johnchen@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619506} Bug: chromedriver:1897 Change-Id: I38122bdc01965345421429b1d2f45374395b0cc7 Reviewed-on: https://chromium-review.googlesource.com/c/1394786Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619717}
-
Paul Irish authored
Change-Id: I8005904bdc042ad4ac709edcc371256a075cde1b Reviewed-on: https://chromium-review.googlesource.com/c/1393427Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#619716}
-
Sergey Ulanov authored
zircon.ethernet was renamed to fuchsia.hardware.ethernet last week, but zircon/ethernet/cpp/fidl.h was still included in network_interfaces_fuchsia.cc. TBR=wez@chromium.org Bug: 918797 Change-Id: I83409d7b5aeb06599a5b89f6400a09704b498fd6 Reviewed-on: https://chromium-review.googlesource.com/c/1394169Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#619715}
-
Max Moroz authored
TEST=tools/code_coverage/coverage_test.py Bug: 869451 Change-Id: I29423a45d6542e358e7157bc6af7f9208969a436 Reviewed-on: https://chromium-review.googlesource.com/c/1394594 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#619714}
-
Rayan Kanso authored
Use consistent annotation style in content/browser/background_fetch/... Style guide: https://google.github.io/styleguide/cppguide.html#Function_Argument_Comments Style used: /* param_name= */ $prvalue Done using the following regex swap + some manual fixes for outliers: - ([^\s{\(]+)\s/\*\s([\w\_]+)\s\*/ - /* $2= */ $1 Change-Id: Id68329cad6ae520f84e9f3ecb6c31f4a39480e36 Reviewed-on: https://chromium-review.googlesource.com/c/1388149 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#619713}
-
Matt Simmons authored
R=asvitkine@chromium.org, yusufo@chromium.org Bug: 916818 Change-Id: Ie703332daf193dec69b3bff5c0686f84886422dc Reviewed-on: https://chromium-review.googlesource.com/c/1393453 Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#619712}
-
Joshua Peraza authored
Overview: This CL disables Breakpad for Chrome, Content Shell, WebView, and Chromecast on Android and replaces it with Crashpad. When a crash signal is received, the browser forks+execs a Crashpad handler process either for itself or on behalf of a crashing child to create a crash dump. components/crash/ - Remove CrashDumpManager. Minidump creation is handled entirely by Crashpad. - Remove OnChildStart from ChildExitObserver as it is no longer necessary. - ChildExitObserver observers CrashHandlerHost to be notified when child processes receive crash signals. - De-duplicate calls to ChildExitObserver::Client::OnChildExit when NOTIFICATION_RENDER_PROCESS_{CLOSED, TERMINATED} are both sent. components/minidump_uploader/ - Uploaders expect crash reports to already be MIME encoded since Breakpad was doing that in a signal handler call-back. CrashFileManager now automatically calls into native code to do the encoding and write to a directory of crash reports whenever it checks for reports without logcats. chrome/app/*.{cc,h} chrome/browser/*.cc content/shell/app/*.{cc,h} content/shell/browser/*.cc - Initialize Crashpad instead of Breakpad, with minor cleanup and adjustment for changes to CrashDumpObserver. chrome/browser/metrics/oom/out_of_memory_reporter_unittest.cc - Simulate crashes/exits with NOTIFICATION_RENDER_PROCESS_{CREATED, CLOSED} and signals sent to ChildExitObserver instead of a crash dump. android_webview/ - AwBrowserTerminator now observes child process crashes via ChildExitObserver rather than its own pipe. - Crashpad always produces minidumps, and not microdumps. - Disabling Crashpad is not yet supported. chromecast/ - There are now two directories that crash report uploaders should be aware of: "Crashpad" contains a database of raw minidumps produced by Crashpad, and "Crash Reports" contains MIME encoded minidumps. MIME encoding is performed by a CrashReportMimeWriter in CastCrashUploader.java:checkForCrashDumps(). TBR=yfriedman@chromium.org,peter@chromium.org,isherman@chromium.org,jam@chromium.org,wnwen@chromium.org,torne@chromium.org,halliwell@chromium.org,tobiasjs@chromium.org,rsesek@chromium.org,sanfin@chromium.org,jperaza@chromium.org,mark@chromium.org Bug: crashpad:30 Change-Id: Ib1b0fe085272a7e1e4a91462add50e41eecad746 Cq-Include-Trybots: master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg Reviewed-on: https://chromium-review.googlesource.com/c/1388654 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:Mark Mentovai <mark@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#619711}
-
Steven Valdez authored
https://boringssl.googlesource.com/boringssl/+log/4cce955d1487b5bd2b3c03ead986558649cdaadf..8e8f250422663106d478f6927beefba289a95b37 Bug: none Change-Id: Ifa87db808efd939abfb388c32f544e7510b70a63 Reviewed-on: https://chromium-review.googlesource.com/c/1393016Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#619710}
-
Tom Anderson authored
These should no longer be necessary now that Desktop Linux uses ChromeOS-styled frame buttons. BUG=911770 R=sky Change-Id: I79ae8a5173e7be7e050ba84220700c47ea6515cc Reviewed-on: https://chromium-review.googlesource.com/c/1394303Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#619709}
-
Juan Antonio Navarro Perez authored
TBR=sullivan@chromium.org Bug: 914390 Change-Id: I2cfe83fef58ea0f6c7a123c662ccfd5dd875aa5e Reviewed-on: https://chromium-review.googlesource.com/c/1394393Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#619708}
-
Cathy Li authored
Bug: 918436 Change-Id: I5311199b6dff15400d36308c35dbf7aa9469be98 Reviewed-on: https://chromium-review.googlesource.com/c/1392501 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#619707}
-
Tom McKee authored
The 'newtab' and 'omnibox' stories aren't run against Android_Webview because they don't make sense in that context. Since those stories don't run against Android_Webview we don't need entries in expectations.config to disable those stories on that platform. Bug: 867568 Change-Id: Ifcd38f0bc5ace5fddc0d883e24b89b06d1f84ef6 Reviewed-on: https://chromium-review.googlesource.com/c/1392734 Commit-Queue: Tom McKee <tommckee@chromium.org> Reviewed-by:
-
Alexei Svitkine authored
This is triggered by the cloned install detector here: https://cs.chromium.org/chromium/src/components/metrics/cloned_install_detector.cc?rcl=4c806b8b802c5bcd93831229bedd8164d8a68a26&l=82 Bug: 866722 Change-Id: Ic0c99bdceee10413949f71f965d1b4edb9006466 Reviewed-on: https://chromium-review.googlesource.com/c/1392348Reviewed-by:
Paul Miller <paulmiller@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#619705}
-
Hector Carmona authored
Having URLs in GRD files can be error-prone. Bug: NONE Change-Id: I5d9bb6cb768fdad2bcea3cb1998ad636b83a072a Reviewed-on: https://chromium-review.googlesource.com/c/1391426Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#619704}
-
Troy Hildebrandt authored
The metadata database is primarily for storing corruption information at the moment. Adds the creation/loading of entries from the metadata DB on shared database init, and causes the database load to fail if metadata can't be loaded, since that would be potentially dangerous. Adds an async check for corruption information during SharedProtoDatabaseClient init, and sets the corruption flag accordingly so IsCorrupt() is correct. Bug: 870813 Change-Id: Id24cd2c5c2aeed21d0e8bb108cc4126c3acb3049 Reviewed-on: https://chromium-review.googlesource.com/c/1356224 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
-
Sam Maier authored
This is a reland of 09f15bdb Original change's description: > Android: Turning on R8 instead of Proguard for public targets > > We are in the process of migrating to R8 to replace Proguard. This is > the first step - move all usages of Proguard in public targets to R8. > > Some refactorings were natural with the few forced changes this caused. > > TBR=smaier > > Bug: 908988, 913554 > Change-Id: I2139919598fba1643d7560dc5557d5efb9a5887c > Reviewed-on: https://chromium-review.googlesource.com/c/1357306 > Reviewed-by: Sam Maier <smaier@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619471} TBR=proguard.flags(smaier) Bug: 908988, 913554 Change-Id: I93690ad2a6838025221b7fab4b0bee1b06c920c9 Reviewed-on: https://chromium-review.googlesource.com/c/1394387 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#619702}
-
Mitsuru Oshima authored
* Don't use root window as transient parent in test. * Don't create WindowState before adding to parent intest. Instead set the window show type to specify the maximized state. These are preparations to limit WindowState to specific containers. Bug: 912191 Test: no functional change. all tests should pass. Change-Id: Ic4587153395552eb140f06d440c5df7afb5b689a Reviewed-on: https://chromium-review.googlesource.com/c/1387839 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#619701}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4627b3705d59..9fa54eab2590 git log 4627b3705d59..9fa54eab2590 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 jmadill@chromium.org Optimize and inline more validation. Created with: gclient setdep -r src/third_party/angle@9fa54eab2590 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I92262e57f5edc7ff4f7f4dcc296d90fd1ec2c483 Reviewed-on: https://chromium-review.googlesource.com/c/1394685Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619700}
-
Xiaocheng Hu authored
At the end of bidi adjustment, it maps (box, offset) pair back to a DOM position but doesn't shift the offset for first-letter, causing, e.g., a shifted selection when creating a range selection. This patch fixes that. Bug: 918349 Change-Id: I71dde2dfece3fd110e3e4c3e6580b3144a3195a8 Reviewed-on: https://chromium-review.googlesource.com/c/1394163 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#619699}
-
John Lee authored
This is more inline with other parts of our code where we have a title, description, and a button. See examples [1] and [2]. [1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/site_settings_page/site_settings_page.html?type=cs&q=site_settings_page.html&sq=package:chromium&g=0&l=50-53 [2] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/a11y_page/manage_a11y_page.html?q=manage_a11y_page.html&sq=package:chromium&dr&l=86-89 After this change, Chromevox will read "(label) Button (sublabel)" as opposed to "(label) (sublabel) Button" Change-Id: I5c1afbbd88eee846e208eb424aa658a5c2ddc74e Reviewed-on: https://chromium-review.googlesource.com/c/1391471 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
-
Lan Wei authored
Use test_driver Actions class in the web platform tests with mouse inputs in "pinterevents/" to simulate mouse inputs to make the tests pass on wpt serve. Bug: 606367 Change-Id: I2f00c3195fafb8bc600250631106cd9eabe79b90 Reviewed-on: https://chromium-review.googlesource.com/c/1383330 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619697}
-
Mike Reed authored
Change-Id: Ib6f73ceed8efec413ae657e5f3a69bb7c9d0c5fa Reviewed-on: https://chromium-review.googlesource.com/c/1394009Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#619696}
-
Steven Bennetts authored
For trivial file moves in policy browser tests: TBR=emaxx@chromium.org Bug: 918682 Change-Id: Ie46d17b4d1fb5ff6f106f7662a192eb580888d84 Reviewed-on: https://chromium-review.googlesource.com/c/1392605 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Fabrice de Gans-Riberi authored
Fuchsia integration tests have been flaking on the waterfall. Disable them until the underlying issue is fixed. This also separates castrunner unit tests and integration tests in two different test suites. Bug: 917192, 918586 Change-Id: Idd3ad424559b7d68679d16d6a2e56929c33e029a Reviewed-on: https://chromium-review.googlesource.com/c/1393887Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
-
François Beaufort authored
This CL removes window.IsActive() DCHECK in PiP window controller as this result is no longer always true anymore in Chrome OS due to https://chromium-review.googlesource.com/c/chromium/src/+/1357819. Bug: 916370 Change-Id: I1b1ff742baa76a4147f162aa620cfc5657fb8783 Reviewed-on: https://chromium-review.googlesource.com/c/1392344Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#619693}
-
Takumi Fujimoto authored
Re-enable the following tests using test UI API / Views Cast dialog: MediaRouterIntegrationBrowserTest.OpenLocalMediaFileInCurrentTab MediaRouterIntegrationBrowserTest.OpenLocalMediaFileInNewTab MediaRouterIntegrationBrowserTest.OpenLocalMediaFileCastFailNoFullscreen DISABLED_OpenLocalMediaFileFailsAndShowsIssue cannot be enabled yet because the Views dialog doesn't support showing an issue not associated with a sink. DISABLED_OpenLocalMediaFileFullscreen cannot be enabled yet due to a known flake in which the local media doesn't go fullscreen on its own. Bug: 900248 Change-Id: I0e95df58d3e2f92394e5f4b3e25a942a2b514eb9 Reviewed-on: https://chromium-review.googlesource.com/c/1351896 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#619692}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2b9d702c09f1..74ec15010f8a git log 2b9d702c09f1..74ec15010f8a --date=short --no-merges --format='%ad %ae %s' 2019-01-03 yunchao.he@intel.com Assigning nullptr to descriptor's nextInChain in C++ is unneeded Created with: gclient setdep -r src/third_party/dawn@74ec15010f8a The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I2b192885a4b5d54aed96278aa502473f06c3e808 Reviewed-on: https://chromium-review.googlesource.com/c/1394201Reviewed-by:
-
Thomas Guilbert authored
RemoteMediaPlayer.seek() is broken in some versions of GMS Core. This CL works around the issue by sending a manual seek message. This CL also updates getApproximateCurrentTime() to return the seek time when there is a seek in flight. This prevents a regression with MediaTime never being updated when seeking backwards. Bug: 914072 Change-Id: I35943b1201fa2e4f32efe440f4def689c955d9ec Reviewed-on: https://chromium-review.googlesource.com/c/1393666Reviewed-by:
-
Dominik Röttsches authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/59345cdef38c..26c5b54fb09f $ git log 59345cdef..26c5b54fb --date=short --no-merges --format='%ad %ae %s' 2018-12-31 cclauss CircleCI: Test for Python 3 syntax errors and undefined names (#1522) 2018-12-30 behdad Fix automake warnings 2018-12-30 cclauss print() is a function in Python 3 (#1520) 2018-12-30 cclauss Python 3 fixes to gen-os2-unicode-ranges.py (#1521) 2018-12-30 ebrahim [cmake] Enable C++11 on CMake (#1519) 2018-12-30 behdad Ouch! Fix build on C++<11 2018-12-30 behdad Fix ubsan with passing nullptr to qsort() 2018-12-27 behdad Fix build on C++ < 11 2018-12-27 behdad [vector] Fix warning 2018-12-27 behdad [aat] Minor 2018-12-27 behdad [vector] Remove use of arrayZ() by using casts 2018-12-27 behdad [vector] Remove static_array 2018-12-27 behdad [vector] Use allocated = -1 to signify failure 2018-12-27 ariza fix lealk with cff2::accelerator_templ_t::topDict (#1517) 2018-12-24 behdad [vector] Change pre-alloced count from 8 to 2 2018-12-23 behdad Fix a few warnings 2018-12-22 behdad [iter] Fix warning 2018-12-22 behdad [set] Add iter_t as alias to const_iter_t 2018-12-22 behdad [set] Change to const_iter 2018-12-22 behdad [set] Cache length in iterator 2018-12-22 ebrahim Minor, remove redundant inline 2018-12-22 ebrahim Minor, tweak spaces 2018-12-22 ariza CFF renaming (#1507) 2018-12-21 behdad [set] Actually derive iterator from hb_sorted_iter_t<> 2018-12-21 behdad [set] Implement unified iterator 2018-12-21 behdad [set] Mark some internals protected 2018-12-21 behdad [iter] Add hb_sorted_iter_t<> 2018-12-21 behdad [iter] Change operator[] operand to be signed 2018-12-21 behdad [array] Port to hb_iter_t<> 2018-12-21 behdad [iter] Change __more__ to fallback to __len__ 2018-12-21 behdad [array/vector] Rename len to length 2018-12-21 behdad [iter] Split hb_iter_t<> into hb_iter_t<> and hb_iter_mixin_t<> 2018-12-21 behdad Adjust internal header dependencies 2018-12-21 behdad [Makefile.am] Minor 2018-12-21 behdad [iter] Include from hb.hh 2018-12-21 behdad [iter] Move hb_fill() and hb_copy() to hb-iter.hh 2018-12-21 behdad [iter] Disallow copy-construction or assignment of hb_iter_t<> 2018-12-21 behdad [iter] Fix hb_copy() return value 2018-12-21 behdad [iter] Add const_iter_t / const_iter() 2018-12-21 behdad [iter] Make hb_fill() take collection type, not iter 2018-12-21 behdad [array] Add more hb_array() / hb_sorted_array() variants 2018-12-21 behdad [serialize] Use component_list by reference, as a supplier 2018-12-21 behdad [iter] Add .random_access() 2018-12-21 behdad [iter] Fix __end__() 2018-12-21 behdad [array] Remove copy constructor 2018-12-21 behdad Fix bot 2018-12-21 behdad Minor 2018-12-21 behdad [iter] Fix test again 2018-12-21 behdad Minor 2018-12-21 behdad [iter] More prototyping 2018-12-21 behdad [iter] Make hb_fill() and hb_copy() take iterators 2018-12-21 behdad [iter] Add hb_fill() 2018-12-21 behdad [iter] Start prototyping hb_copy() 2018-12-21 behdad [iter] Showcase implicit casts 2018-12-21 behdad Rename 2018-12-21 behdad [iter] Rename 2018-12-21 behdad [iter] First sample use 2018-12-21 behdad [iter] Add bidirectionality 2018-12-21 behdad [iter] Sketch new iterator design 2018-12-21 behdad [iter] Add empty test 2018-12-21 behdad Revert "Remove unused hb-iter.hh" 2018-12-20 behdad [vector] Add operator bool 2018-12-20 behdad Rename 2018-12-20 behdad Remove unused typedef 2018-12-20 behdad 2.3.0 2018-12-20 behdad [serializer] Add operator << 2018-12-20 behdad Add hb_assign(obj, value) 2018-12-20 behdad [serialize] Adjust ClassDef 2018-12-20 behdad Fix code on big-endian gcc / clang 2018-12-19 behdad Minor [skip ci] 2018-12-19 behdad [saitnize] Minor 2018-12-20 fanc999 Fix build on older Visual Studio versions (#1499) 2018-12-19 behdad [sanitize] Use hb_static_size instead of ::static_size 2018-12-19 ebrahim [test] Fix test-name-table.cc leak issue 2018-12-18 behdad [arrays] Add hb_ubytes_t for unsigned char 2018-12-18 behdad [arrays] Remove hb_supplier_t<> 2018-12-18 behdad [serialize] Propagate error from hb-face 2018-12-18 behdad [serialize] Streamline error propagation 2018-12-17 behdad Remove unused hb-iter.hh 2018-12-17 behdad [arrays] Minor tweaks to hb_supplier_t 2018-12-17 behdad [arrays] Rename Supplier to hb_supplier_t 2018-12-17 behdad Hide hb_addressof() 2018-12-17 behdad Enable __builtin_* on clang 2018-12-17 behdad Add hb_addressof() and use it to fix bug after hb_bytes_t merge 2018-12-17 behdad Enable system extensions in hb.hh 2018-12-17 philip.race Fix Solaris use after free (#1495) 2018-12-17 behdad Remove define GNU_SOURCE 2018-12-17 behdad Fix more warnings 2018-12-17 philip.race Fix Solaris Trailing comma in enum warnings (#1490) 2018-12-17 ebrahim Lower coretext_aat shaper priority (#1488) 2018-12-17 ebrahim Remove redundant void from C++ sources (#1486) 2018-12-17 ebrahim Minor, fix two more ArrayOf incorrect operator logic 2018-12-17 behdad [arrays] Minor fix 2018-12-17 behdad [array] Add cast operator to add const to Type 2018-12-17 behdad [array] Remove problematic constructor 2018-12-17 behdad [array] Add arithmetic operators 2018-12-17 behdad [array] Return Crap instead of Null if Type is not const 2018-12-17 behdad [array] Add operator * 2018-12-17 behdad [array] Add constructor from fixed-size array 2018-12-16 behdad [array] Organize (...) Created with: roll-dep src/third_party/harfbuzz-ng/src R=bashi@chromium.org,behdad@chromium.org,behdad@google.com,drott@chromium.org,eae@chromium.org,jshin@chromium.org Change-Id: I5c849e836fdb002678ac0ce5bd9016d5169e26e4 Reviewed-on: https://chromium-review.googlesource.com/c/1394312 Commit-Queue: Dominik Röttsches <drott@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
edchin authored
SnapshotCallback has an image parameter that was being passed by value. This CL converts it to pass by reference to be more efficient. Change-Id: I020192a7d6886e81ce317f3789516adff69dba03 Reviewed-on: https://chromium-review.googlesource.com/c/1394008Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619688}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5efb17b5..eb333167 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I81c2fcdae6f32df8fc38956c280cb8700894b024 Reviewed-on: https://chromium-review.googlesource.com/c/1394388Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619687}
-
Nico Weber authored
Remove a redundant entry, and add a dedicated bug line for nacl_helper_bootstrap now that I understand what's going on there. Bug: 918882 Change-Id: Id5c12c9096783dda98b9c80c4de0a9db860d1aa7 Reviewed-on: https://chromium-review.googlesource.com/c/1394707Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#619686}
-
Michael Lippautz authored
Setting a property to undefined that has not been set before can lead to V8 transitioning that wrapper object. This can lead to allocation which in turn can trigger garbage collection. Bug: 916022 Change-Id: I01bfb4af4514138c81a507acbb462b024dc89025 Reviewed-on: https://chromium-review.googlesource.com/c/1394587 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#619685}
-
Tibor Goldschwendt authored
This toast is shown if the VR module is not installed yet when launching Chrome on standalone VR headsets. Bug: 914498 Change-Id: Iaac05f06e20a40d62dca52916bb158914edb4320 Reviewed-on: https://chromium-review.googlesource.com/c/1393556Reviewed-by:
-
Joshua Pawlicki authored
Split from https://chromium-review.googlesource.com/c/chromium/src/+/1344880 Bug: 907219 Change-Id: Ia855b6ad41bf1a4465233cfd857fae3c1a759c54 Reviewed-on: https://chromium-review.googlesource.com/c/1393403 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#619683}
-
Avi Drissman authored
This is purely a mechanical change; there is no intended behavior change. BUG=837308 Change-Id: I85c15d42228d0e1c88f366af263d86dca15ba44e Reviewed-on: https://chromium-review.googlesource.com/c/1390424Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#619682}
-
Evan Stade authored
Test is SwitchAccessPredicateTest.IsActionableFocusableElements TBR=jamescook@chromium.org Bug: 918876 Change-Id: I8f3de7f4f089d1d9fc9e67a7012baa6c1dfca9f1 Reviewed-on: https://chromium-review.googlesource.com/c/1394396Reviewed-by:
-
