- 27 Feb, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c11ee67062ce..951d1b78a6e5 git log c11ee67062ce..951d1b78a6e5 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 sigurds@chromium.org [e2etest] Port layout test to e2e test 2020-02-27 szuend@chromium.org Prepare DebuggerPlugin.js for asynchronous source mapping Created with: gclient setdep -r src/third_party/devtools-frontend/src@951d1b78a6e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032016,chromium:1044632 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I59682e71c8c7e039d9544a0fa1db5ed5ae19fd40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077822Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745006}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f58705e5..5ba8c6c1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibd0ee555d83cf56d7449d35c0c249dbab2124a59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077398Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745005}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e9368975a2f5..61b1c84d5157 Created with: gclient setdep -r src-internal@61b1c84d5157 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I5f11a85a90ef24fce308c2dbde777f8076239565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077817Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745004}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cb7f5f4a2acc..201bb086c442 git log cb7f5f4a2acc..201bb086c442 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader da659b374113..4b34ee3de531 (3 commits) 2020-02-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 3f4d08da8897..38f68cce445b (1 commits) Created with: gclient setdep -r src/third_party/angle@201bb086c442 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: I81311a7fc1001a2ff868c6338f9ed15f6c3a244f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077579Reviewed-by:
-
Joel Hockey authored
Change-Id: I05efe3b380f8f5fe425ce8a07ed2a0d7315b0f59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077317Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#745002}
-
Armando Miraglia authored
Delete comment in the IDL for RTCRtpSender which references a bug which is now closed, making the comment now outdated. Bug: 700916 Change-Id: I0a1e943a09ea1af6b25e4824979939c234167467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077678Reviewed-by:
Armando Miraglia <armax@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#745001}
-
Maria Kazinova authored
Iframes with empty "src" property can be cross-origin iframes, which causes DOMException on some websites when the parsing is done. Added a check for accessing frame's window.location.href parameter which is a more trustworthy indicator. Bug: 850388 Change-Id: Id644df4f3790e5ea5e3659964ccd96b378cd70d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066904 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#745000}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 82-4044.15-1582543985-benchmark-82.0.4065.0-r1 to 82-4044.15-1582543985-benchmark-82.0.4070.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ic5c7bbc21ddb6b113bdc5bf7010ba22269572649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078051Reviewed-by:
-
Michael van Ouwerkerk authored
Bug: 1020124 Change-Id: I0fef980bede485b214754c21c562f92e8fa688e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073882Reviewed-by:
Anna Malova <amalova@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#744998}
-
Felipe Erias authored
Update W3CImportExpectations to import the suite of tests for css-page from WPT, skipping the manual ones. R=rego@igalia.com Change-Id: I4292b1ebaa87c2c056c195c3dcc362b0d26ecd1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074817Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#744997}
-
Jan Wilken Doerrie authored
This change modifies base's implementation of C++20's uniform container erasure API to reflect the latest changes from the committee meeting in Prague. In particular, these functions now return the number of erased elements, rather than having no return value. Differences from the standard [1]: - For simplicity, base::Erase and base::EraseIf return size_t, rather than typename Container::size_type. - Since std::forward_list::remove_if only returns size_type starting from C++20, the respective overloads need to perform two extra O(n) operations to calculate the number of removed elements. [1] https://wg21.link/p1115 Bug: 697235 Change-Id: I30ad6ce08f3a37eddd1483e4fdc4f1cd8d155d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072038Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#744996}
-
Rainhard Findling authored
* Adds the safety check updates child element * On an update state change, adapts the child icon, icon color, secondary label, and user action UI components accordingly Bug: 1015841 Change-Id: I7c0901a82304c38baa0fd87c3b82171ee8c9e9b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066909 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#744995}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3caf4532c490..1412b3e47c6f git log 3caf4532c490..1412b3e47c6f --date=short --first-parent --format='%ad %ae %s' 2020-02-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@1412b3e47c6f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I8ee5a13815c01d67998658da3199fea0339753ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077586Reviewed-by:
-
Jose Lopes authored
This is similar to: https://chromium-review.googlesource.com/c/chromium/src/+/2050501 in that the callback is used as part of a factory and as such it can be called multiple times. This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I0faa5a16e5889bbb6d26eaba26fb7e2a5fa1dbce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056909 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#744993}
-
chromium-autoroll authored
Roll airmont AFDO profile from 82-4044.25-1582540590-benchmark-82.0.4065.0-r1 to 82-4044.25-1582540590-benchmark-82.0.4070.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I9603fa812fafdaf26126b66646d245aff819726f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077821Reviewed-by:
-
Rohit Agarwal authored
Bug: 1023759 Change-Id: I33aec2a344314ad1576776a494d97f1a9cef38e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039511 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#744991}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/005269a51304..29d5cf85ac28 git log 005269a51304..29d5cf85ac28 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 gregorynisbet@google.com fix git cl presubmit Created with: gclient setdep -r src/third_party/depot_tools@29d5cf85ac28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1056534 Tbr: agable@chromium.org Change-Id: I2f2d2ec62d34b8127145c005f526832bec1b54bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077578Reviewed-by:
-
Michael Lippautz authored
Convert to idiomatic tracing on the way. Bug: 1056170 Change-Id: I6158eac8746953abc1a451a2785e4aa921f057f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075657Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#744989}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d8e762cd820b..c11ee67062ce git log d8e762cd820b..c11ee67062ce --date=short --first-parent --format='%ad %ae %s' 2020-02-27 gabriel.luong@gmail.com Typecheck common/AppProvider.js, common/Runnable.js and common/StringOutputStream.js with TypeScript Created with: gclient setdep -r src/third_party/devtools-frontend/src@c11ee67062ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7e203a73d8167d379f60a3e5e0f99077687e5b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077581Reviewed-by:
-
Miyoung Shin authored
This reverts commit d5df8b85. Reason for revert: Memory Regression Original change's description: > Replace blink::TextDirection with base::i18n::TextDirection > > This is a precursor CL to replace ExternalPopupMenu class by a > mojo connection, and replace blink::TextDirection with > base::i18n::TextDirection. > > Bug: 1044268 > Change-Id: I0b6802201b05c48abaf19de78e81a848d5dc94b3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061985 > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743450} TBR=haraken@chromium.org,myid.shin@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1044268, 1055696 Change-Id: I4b7d7073ffaf729e23272c83573a957fc3c03a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076755 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
-
Henrique Ferreiro authored
This is a precursor CL to allow Blink to depend on ui::Cursor. To do that, ui::Cursor and ui::CursorSize are moved to a new target //ui/base/cursor that does not depend on //ui/base. Bug: 1040499 Change-Id: I26c0349f9c98fb269bdb474e9dcf3a280d268365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054087 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#744986}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I497155445308b7731b904d138f8bc0ff03cdbe11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077279Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744985}
-
Matthias Körber authored
The feature is launched and the experiment can be removed. Note that the feature was enabled by default and is already removed from the fieldtrial config. Change-Id: I8d60a8ba24e2df71cf1f34db6b0ecbc1b0f80d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077477 Auto-Submit: Matthias Körber <koerber@google.com> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/50148dbfcb7b..65dd8440ec78 git log 50148dbfcb7b..65dd8440ec78 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 fancl@chromium.org Using Match result for monitored status Created with: gclient setdep -r src/third_party/catapult@65dd8440ec78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1052720 Tbr: sadrul@google.com Change-Id: I9f9ded8bff4f1f8da1a2366e6d8ec27766624fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2077580Reviewed-by:
-
Frédéric Wang authored
A platform API for the OpenType MATH table has been added in [1] but the code is not verified by blink_platform_unittests. This CL adds a few tests for fonts with or without a MATH table as well as constants related to script scale down, fractions and radicals. This is not exhaustive but at least cover all the return statements of OpenTypeMathSupport::HasMathData and OpenTypeMathSupport::MathConstant. This also modifies the result of OpenTypeMathSupport::MathConstant for fonts without a MATH table: Instead of returning HarfBuzz's zero value, the function returns a null optional so that callers can decide the default value to use. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2041485 Bug: 6606, 1050596 Change-Id: I4e7f329bbabb1759f6a1adeaa74b49912812ba8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073721 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#744982}
-
Mohamed Amir Yosef authored
As per the linked bug, tests in PasswordSaveUpdateWithAccountStoreViewTest falkily timeout. They have been however doing well for like 2 weeks before getting flaky. I am considering enabling one of the simple test again to see if the problem still exists or not. Change-Id: I1452e7ee7e70ec7b3d63289527b4ae2134d4e81a Bug: 1054629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073881Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#744981}
-
Side Yilmaz authored
This CL update the profile passing to TrackerFactory from ToolbarPhone. Currently, it is always regular profile, however it is not safe because of possible data leakage from incognito to regular profile. Therefore, this CL uses |isIncognito| function at ToolbarLayout class to get correct profile object(i.e., regular or off-the-record profile). Bug: 1041781 Change-Id: I12324730ed6183ba7019138e5064b8fd98d1b45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074677Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#744980}
-
Jose Lopes authored
The callback is used in multiple locations, e.g., the destructor: * https://cs.chromium.org/chromium/src/media/mojo/clients/mojo_video_decoder.cc?rcl=867cd77410eaf2030f9a4f2071e75266626a110d&l=129 and IPC handler: * https://cs.chromium.org/chromium/src/media/mojo/clients/mojo_video_decoder.cc?rcl=867cd77410eaf2030f9a4f2071e75266626a110d&l=400 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: Ia5956521c43f6783f3767697bbca2cf8c4c705d1 TBR=thakis@chromium.org,jam@chromium.org Change-Id: Ia5956521c43f6783f3767697bbca2cf8c4c705d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056476 Commit-Queue: Jose Lopes <jabolopes@google.com> Auto-Submit: Jose Lopes <jabolopes@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8d1f44cb67cc..e9368975a2f5 Created with: gclient setdep -r src-internal@e9368975a2f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I3ac9495a7534a15b80b29dd1529aba20fd079748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076804Reviewed-by:
-
Jose Lopes authored
This callback is used in 2 places but in different ways. The service uses this callback as a once callback (explained below). And the provider uses it as a repeating callback because the provider works like a factory class. So this CL splits the callback definition into 2 separate callbacks. A detailed explanation of why the service behaves like a once callback. This callback is executed in an IPC handler: * https://cs.chromium.org/chromium/src/media/mojo/services/mojo_video_encode_accelerator_service.cc?rcl=389b555af3ca96ce205c8e231429119a59aab50b&l=47 This callback is used to create an encoder, and once the class holds a valid encoder the Initialize method can no longer be called because of the check in: * https://cs.chromium.org/chromium/src/media/mojo/services/mojo_video_encode_accelerator_service.cc?rcl=389b555af3ca96ce205c8e231429119a59aab50b&l=53 In theory, if the method fails it could be called repeatedly until it succeeds. But looking at the callers it seems this doesn't happen. The only mojo caller is in: * https://cs.chromium.org/chromium/src/media/mojo/clients/mojo_video_encode_accelerator.cc?g=0&l=123 And that method is documented that it can only be called once: * https://cs.chromium.org/chromium/src/media/video/video_encode_accelerator.h?g=0&l=237 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I1f51ff76b679c891740d2848e9d4c573ef315db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069329Reviewed-by:
-
Jack Franklin authored
`String.prototype.toBase64` is being removed from the DevTools frontend [1] and this test has been moved into unit tests in frontend. Bug: 1032561 Change-Id: I8b6d75d2751404c9a012fe8a9fda63a4b2039052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061757 Commit-Queue: Jack Franklin <jacktfranklin@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#744976}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3f0406a3..f58705e5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4a3f76d357a584332d18d24e9cd3f0d955f986cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075241Reviewed-by:
-
Gauthier Ambard authored
UseWKWebViewLoading is launched and the code has been removed. The field trial config can now be removed. Bug: none Change-Id: Ia41383a4c6016c8bce57c1f31ec01b04bafae691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074879Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#744974}
-
Hiroki Nakagawa authored
This CL adds tests for dedicated/shared worker creation in data URL contexts (iframe and dedicated worker) whose origins are opaque. For dedicated worker creation: 1. Creating a dedicated worker in a data URL iframe 2. Creating a dedicated worker in a data URL dedicated worker 3. Creating a data URL dedicated worker in a data URL iframe 4. Creating a data URL dedicated worker in a data URL dedicated worker Expected behavior: - For 1 and 2, they are expected to asynchronously fail worker construction because the same-origin policy is supposed to be checked during the fetch algorithm based on request's "same-origin" mode. - For 3 and 4, they are expected to succeed in worker construction because fetching a data URL from a data URL context is allowed. Chrome behavior - For 1 and 2, Chrome synchronously fails the cases because the same-origin policy is checked in the Worker constructor (i.e., SecurityOrigin::CanReadContent() call in AbstractWorker::ResolveURL()). See issue 1055697. For shared workers: 5. Creating a shared worker in a data URL iframe 6. Creating a data URL shared worker in a data URL iframe Expected behavior: - For 5, this is expected to asynchronously fail worker construction because the same-origin policy is supposed to be checked during the fetch algorithm based on request's "same-origin" mode. - For 6, this is expected to succeed in worker construction because fetching a data URL from a data URL context is allowed. Chrome behavior - For 5, Chrome synchronously fails worker construction because the same-origin policy is checked in the SharedWorker constructor. This is the same as 1 and 2. See Chrome behavior for 1 and 2. - For 6, Chrome synchronously fails worker construction because of issue 1055693. Chrome doesn't support creating shared workers in dedicated workers and vice versa, so this CL doesn't contain those cases. Note that these are allowed in the HTML spec, so it would be nice to have WPTs for the cases, but it's out of the scope of this CL. Bug: 1053382, 1055693, 1055697 Change-Id: I8480b6079d4fb271855656cedcffc86e6e6c0fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043533 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Eriko Kurimoto <elkurin@chromium.org> Cr-Commit-Position: refs/heads/master@{#744973}
-
Luciano Pacheco authored
This CL removes the animation when updating the thumbnail image. This animation is very quick and hardly noticed and some code paths weren't even using the animation. This fixes 2 issues: 1. Old images weren't removed when there animation wasn't used. 2. The event listener for 'animationend' wasn't removed. No change in functionality for the user, so no new tests added. Test: Manually checked that file list and grid display and update their thumbnails. Bug: 1056443 Change-Id: I8a6bd050c2bbb358387934ff9371c075a6703508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076749 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#744972}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c3a0d11aff58..d8e762cd820b git log c3a0d11aff58..d8e762cd820b --date=short --first-parent --format='%ad %ae %s' 2020-02-27 yangguo@chromium.org Add Jack to OWNERS Created with: gclient setdep -r src/third_party/devtools-frontend/src@d8e762cd820b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I49bac170b9a14b46b19f921651eaf3853152b1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076809Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e763c61a2c3b..3caf4532c490 git log e763c61a2c3b..3caf4532c490 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-02-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 04383ff2..b53f5caa (392 commits) Created with: gclient setdep -r src/third_party/skia@3caf4532c490 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I4257574dce0b918c648e87f1739792dae48d2bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076806Reviewed-by:
-
Matthew Mourgos authored
Bug: 976949 Change-Id: Iceabe5a61f3ced8bc6a4c03dd05c460a35552dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068007Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#744969}
-
Eriko Kurimoto authored
This CL adds util::PassKey<ModuleScriptLoader> to the arguments of ModuleScriptFetcher constructor. ModuleScriptFetcher is allowed to be called only from ModuleScriptLoader but currently it can be called from elsewhere as an implementation. To prohibit accessing from other classes, we use PassKey. PassKey value must be private, but we allow accessing this value from outside only for testing via ModuleScriptLoader::CreatePassKeyForTest(). Also, ModuleScriptFetcher::Fetch() must be called only once and this change clarifies this restriction as the comments. Change-Id: If284f4d5ff4ab21fe7f672ac98017d3835497889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071336Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#744968}
-
Gauthier Ambard authored
This CL removes the code that was doing the switch for the feature to use the WKWebView loading property. The property is enabled to 100%. Bug: 1006012,767092 Change-Id: Id4a4ca3ad18b24cb97e79c32aece943470d9d0a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074641 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#744967}
-
