- 17 Jan, 2020 40 commits
-
-
jongdeok.kim authored
This CL adds a border color to views::Border, and remove a color memeber in subclasses. Bug: None Change-Id: I5598325d4baac305c145b933889fea96de6d3bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985635Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#732957}
-
Avi Drissman authored
Collect basic information as to whether the Mac is joined to a domain, or if it is controlled by MDM. Tbr: pastarmovj@chromium.org, asvitkine@chromium.org, mark@chromium.org Bug: 1040630 Change-Id: Idcc3fbeca66b9b5278965d5219851e51a20f3da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007511Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#732956}
-
Kyle Horimoto authored
Fixed: 1042316 Change-Id: Id013c917732d00c65b4f2533a697ffbd1c4ccb67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006422Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#732955}
-
Joe DeBlasio authored
This CL changes the mixed content download blocking code to return an enum indicating what type of blocking should be used (silent, or two types of blocking UI). Previously, this function returned a boolean that indicated silent blocking. The CL then propagates that result through the DownloadTargetDeterminer into the DownloadItem. That state is needed later to trigger the existing download shelf warning UI. This CL also renames callbacks in/around the DownloadTargetDeterminer from "ShouldBlock"-type names to "GetMixedContentStatus"-type names. This CL causes no functional change to Chrome. Follow-up CLs will add support for, then trigger, user-visible warnings. This is part of go/downloads-as-mixed-content . Bug: 960819 Change-Id: Ic0c3f41caf7e623050d4b75be364f410a46e296d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982680Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#732954}
-
Darwin Huang authored
Bug: 1042145, 1042578, 1042700 Change-Id: If611c01b0b4e507376d187292809d50b9c786932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006427Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#732953}
-
Ahmed Mehfooz authored
Bug: 1035361 Change-Id: Ib39b48c2798262c98ded9a2beb796d8f359da925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006370 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#732952}
-
Brian Sheedy authored
Fixes Telemetry's tombstone and logcat stack symbolizing not working on the bots due to missing data dependencies. Instead of including the files in the Telemetry group, they have now been moved to //build/android:stack_tools. Bug: 1041902 Change-Id: I14d614199a7e54bc4dd03a6a2b7379cf229fb8d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006390 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#732951}
-
Michael Thiessen authored
This is a necessary pre-cursor to cleaning up scheme initialization. No GURLs should be created before schemes are modified/added and GURL is ready to use. Enforcement of this will come in a followup CL. See the bug for additional context. Replacing static initalizers with functions ensures the GURLs are only initialized when used, which happens after test setup. Bug: 783819 Change-Id: Ifafe4a45b69eac0df10ac2125a328d24de130bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918828 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#732950}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/93e3c76a6543..e1b7afc8f3a1 git log 93e3c76a6543..e1b7afc8f3a1 --date=short --first-parent --format='%ad %ae %s' 2020-01-17 reed@google.com add guard to move to explicit matrix conversions 2020-01-17 fmalita@chromium.org [skottie] Cleanup: convert more effects to new animator pattern 2020-01-17 bsalomon@google.com Reland "Make SkGpuBlurUtils take SkTileMode"" 2020-01-17 brianosman@google.com Switch coord transforms in gradient layouts to 3x3 (SkMatrix) Created with: gclient setdep -r src/third_party/skia@e1b7afc8f3a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: If4318a0d238d6e82f3be59dae1064b5d6b29e31e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007925Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732949}
-
Harald Alvestrand authored
Delete juberti@ as non-committer Add people currently working on webrtc Bug: none Change-Id: I5828538aedec8d507947fbfcbbe6801ff6f81be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005990Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#732948}
-
Maksim Ivanov authored
Fix the error font and position according to the latest UX feedback: * increase the font size to 12; * remove the bold weight from the font; * move the error label up, so that the distance from the input field to it is only 4px. Bug: 1024251 Test: use DevTools to check the font, take a screenshot to check the margins Change-Id: I631f2fab46270251d0e980480c21b4d37fb479e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002874Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#732947}
-
Michael Lippautz authored
This reverts commit f0776695. Reason for revert: Failures should be fixed. Original change's description: > Test suppression for deqp/functional/gles3/sync.html failure > > deqp/functional/gles3/sync.html is failing intermittently on Win. > Suppress. > > TBR=kbr@chromium.org > > Bug: 1033662 > Change-Id: Ib4721835bb5cbf2d500dbeb1a411548244a89a05 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966087 > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Robert Kroeger <rjkroege@chromium.org> > Cr-Commit-Position: refs/heads/master@{#724414} TBR=rjkroege@chromium.org,kbr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1033662 Change-Id: I211cba88f49165522a5083240476dad4ae5a0d51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007109Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#732946}
-
Kristi Park authored
Implement a basic dialog and insert the Ink canvas. Downstream component for https://crrev.com/i/2415665. Bug: 1024586 Change-Id: Iff5d0d9be76e0c4fb9a7a6c03691f068013e3de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999265Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#732945}
-
danakj authored
The UpdateBrowserControlsState IPC requires a main frame to be present and only makes sense for a (local) main frame since that is the single place that has browser controls. This DCHECKs instead of ignoring the IPC to catch and point out logic errors if they exist in the browser. All callers clearly check or are calling the IPC for the main frame already except BFCache which is difficult to tell. The BFCache bot will inform us if there are any tested misuses already, and this DCHECK will prevent future mistakes. R=avi@chromium.org Bug: 419087 Change-Id: Ic91453ab8cbf5d0d575983a82a2cf3a3855e3d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005814 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
They are replaced with the new setters. Bug: 1011446 Change-Id: I1c4bcb1853e4ae43d043135bc7f3fbf534aca66f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007649Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#732943}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d092437b81ea..2e5c7edf368f git log d092437b81ea..2e5c7edf368f --date=short --first-parent --format='%ad %ae %s' 2020-01-17 lalitm@google.com Merge "trace_processor: allow selecting rowmaps with smaller rowmaps" 2020-01-17 buss@google.com Merge "Fix compilation on Windows/VSC." 2020-01-17 hjd@google.com Merge "ui: Remove small gap in pinned track container" Created with: gclient setdep -r src/third_party/perfetto@2e5c7edf368f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib8ceb5de792d61f42929d30e6f411fb3435d8238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008168Reviewed-by:
-
Akihiro Ota authored
This change modifies data in ja_phonetic_data.js so disambiguations for characters reflect the character set they originate from, if it is ambiguous. Bug: 1034152 Change-Id: Ife07a64d8bc0e57d1cf30575150c969401ce1926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994524Reviewed-by:
Zachary Kuznia <zork@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#732941}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/cb3f04f584a53844546aaa32e949534c453185aa..89730072b81077cc3e3a973963015b2494d36b1a The following commits have Chromium bugs associated: f22e5fbab Try again to deal with expensive tests. The following commits have update notes: 0df6edff4 Split BN_prime_checks into two constants for generation and validation. Bug: 1042657 Change-Id: I40133ee19fe61595e658fc9adb757ceb61d25ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007512 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#732940}
-
Sylvain Defresne authored
In preparation of moving ios::ChromeBrowserState to the global namespace, add a header to forward declare ChromeBrowserState. This can be used to change the forward declaration atomically when moving the class without having to change all the clients. Bug: 1042208 Change-Id: I9273f83989390b569b74db771d3b1fc00fe9525a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007415Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#732939}
-
Himanshu Jaju authored
Add Discovery request/response and WebRtcSignalingFrame to SharingMessage protos. Bug: 1043149 Change-Id: I025365006d96c188308b85cc62064d48a6617f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007575Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#732938}
-
Liquan (Max) Gu authored
This CL is to add a test for Expandable Payment Handler UI. Main Change: * add 1 test * add maxpay.com payment app Flag enabled: ScrollToExpandPaymentHandler. With this flag, Payment Request will open the Expandable PH UI instead of the CCT PH UI. Test Steps: 1. install payment app - maxpay.com 2. launch the app 3. when the app is on load, invoke a callback to respond "success" to the PaymentRequest. Bug: 1042892 Change-Id: I8a64a6f892eff8c9ae3c6c98acd948938b7eb173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980187 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#732937}
-
David Black authored
As this is the last usage of Content Service by Assistant, the Content Service-related APIs on AssistantController/AssistantViewDelegate are also cleaned up in this CL. Bug: b:146351046 Change-Id: I852a17630e3d9e3b17b8dfac025648d693004dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006228Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#732936}
-
Steven Bingler authored
In preparation for an upcoming change refactor the warning status to be a bit vector similar to the exclusion reason field. Previously the warning field was an enum which explicitly stated "DO_NOT_WARN", the lack of a warning is now indicated by an empty bit field. All other warnings are indicated by the position of each set bit in the field. Change-Id: I5ffcdbe7bb5c2e558af8e73e22465e1bb6e44e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003223Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#732935}
-
Mathew King authored
If XkbLookup fails and there is no DOM|code|->DOM|key| mapping. This will happen in cases where a DOM|code| exists without a W3C standard DOM|key|. BUG=952051 TBR=wez Change-Id: I63af869118e15c99bcb7cd4cbcb3e58def610334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008049Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Auto-Submit: Mathew King <mathewk@chromium.org> Cr-Commit-Position: refs/heads/master@{#732934}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9293af72309e..a067a830b31a git log 9293af72309e..a067a830b31a --date=short --first-parent --format='%ad %ae %s' 2020-01-17 obrufau@igalia.com [css-pseudo] Handle nested pseudo-elements in devtools tree (front end) Created with: gclient setdep -r src/third_party/devtools-frontend/src@a067a830b31a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:457718 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7153b9b040be3b46c86fdf4eba93dd76f7fb4ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007920Reviewed-by:
-
Mark Pearson authored
Change-Id: I838126917cbd2301ae4609fbc23528ccdb41fb2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006077 Auto-Submit: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#732932}
-
Victor Fei authored
This is a reland of 9612f58a The change was reverted because of failure on linux-trusty-rel due to a mismatch in dump test result for "checkable" state. In this reland, I added a filter @AURALINUX-DENY:checkable to fix this test mismatch. This filter seems to accompany all other radio button dump tests for linux platform. Original change's description: > A11y:Expose labels of radio & checkbox when focused. > > Currently, when a label is referenced by a control of type radio or > checkbox, we set the label as ignored in the AXTree thereby excluding > it from being perceived by ATs. > However, for the case when the control (radio/checkbox) is a > descendant of the label and label is focusable (tabindex="0") but > control is to be omitted from focus (tabindex="-1"), ATs perceive > neither the label nor the control when tabbing through the content: > > <label style="display:block" tabindex="0"> > radio button 1 > <input type="radio" id="radio1" tabindex="-1"> > </label> > > <label style="display:block" for="radio2" tabindex="0"> > radio button 2 > <input type="radio" id="radio2" tabindex="-1"> > </label> > > <label style="display:block" for="checkbox1" tabindex="0"> > checkbox 1 > <input type="checkbox" id="checkbox1" tabindex="-1"> > </label> > > <label style="display:block" for="checkbox2" tabindex="0"> > checkbox 2 > <input type="checkbox" id="checkbox2" tabindex="-1"> > </label> > > This change fixes the above scenario by exposing labels (referenced by > radio or checkbox) when they are focusable. For all other cases when > labels are referenced by radio or checkbox, we keep the existing > behavior of ignoring the label. > > Note: Neither Firefox nor Edge legacy hides a label from AT when the > label is referenced by a control. On Firefox and Edge legacy, label > content will be read twice (focus on label and focus on control > respectively). > WAI-ARIA spec does not specify label should be ignored when associated > with a radio/checkbox control. > > Bug: 1040210 > Change-Id: Ie7df5144dd2f0d285d97e6556adb46dcf2338f25 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992017 > Commit-Queue: Victor Fei <vicfei@microsoft.com> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731820} Bug: 1040210 Change-Id: I09243796ec3affe648d46ec64d7dd20e20c5893f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002892Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
-
Chase Phillips authored
Bug: 1039869 Change-Id: I4398a8c95cf3c8a818d8655fe037078fe183e0d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003797 Auto-Submit: Chase Phillips <cmp@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#732930}
-
Mustaq Ahmed authored
Bug: 687724 Change-Id: Ib4f2d12d0e6a40b482dddafe0346f9852df6e7ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004504Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#732929}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id995913e624d185645f7316669c4410405f82a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007918Reviewed-by:
-
Yi Gu authored
Currently we unconditionally iterate all the snap containers to check whether a snap container needs update its data. On a page with lots of snap containers, e.g. youtube.com, this introduces big regression: it adds ~0.2ms to Document::UpdateStyleAndLayout() and LocalFrameView::RunStyleAndLayoutLifecyclePhases() which accounts for ~90% of the total time. Bug: 1042396 Change-Id: I0ef268bd0d5a2f448766059814c6b14bf34ba73a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005822Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#732927}
-
Dominic Battre authored
Unfillable form fields should not label a form as an "Address form". Bug: 1043150 Change-Id: I47916142f32eb36df0c08d6897f2d36de3b86df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007811 Commit-Queue: Dominic Battré <battre@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#732926}
-
Xinghui Lu authored
Bug: 1042984 Change-Id: I12c1287f42f39dfab883c2976b7c7ae39441cf7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005906Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#732925}
-
Nasko Oskov authored
The negative wording of IsInvalid makes it harder to read, especially when trying to test the inverse - !IsInvalid. It is easier to read a positively worded method name, so I'm renaming it to IsValid. Change-Id: I50718a2a903138ebe33c36c0afec3d379941f7b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005810Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#732924}
-
Ted Choc authored
CCTs that have been pre-warmed create a Tab prior to the ShareDelegate being available. This switches to passing a Supplier around for late binding access. BUG=1034460 Change-Id: I8127b2928cd8de523683b8fa1a2f1e4bd3f50374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006259 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
llin@chromium.org authored
First usage of this API is Quick Answers in browser process. This CL also added "Quick Answers" as a query source. Bug: 146020947 Test: Manual Change-Id: I0d0b5186471cea3550bce5519e0f9014a8aaa14a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961151 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#732922}
-
Ioana Pandele authored
Bug: 1041374 Change-Id: I64e410eb11f1841ab48dfc142dcee8361089541a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002911 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#732921}
-
Mason Freed authored
The [1] CL enabled the FormControlsRefresh feature by default for Windows, Linux, and ChromeOS. In the process, many layout tests were disabled, because the form controls have a different appearance with the feature enabled. This is one of several patches rebaselining those disabled tests. [1] http://crrev.com/c/1967608 Bug: 1035582 Change-Id: I30e8a7fa14ced59b7e918c86b2acf0dae1aef439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997977 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#732920}
-
Wez authored
The FIDL/JS generator is unused and would likely be re-implemented for integration into the V8 repo, so remove it from Chromium. We can of course refer to the removed implementation thanks to source control! Bug: 1043093, fuchsia:44191 Change-Id: I93db91acef1a31e0e54ec1b9c4348963bd9e5f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007393 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#732919}
-
Eugene But authored
This CL adds Identity Disk to toolbar view instead of header view. Pull To Action UI uses toolbar view screenshot for fade in and fade out animations, which creates smoother transition experience. Bug: 1022441 Change-Id: Ib6aeecdb04143c362041246897f78eac2e741ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986242Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#732918}
-
