- 08 Jan, 2021 40 commits
-
-
Xing Liu authored
Add "New" text through IPH system to provide FRE for reading list. Bug: 1151567 Change-Id: I62534a77be3b3ac931c2e5cdf53028480dd1795f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597814Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841316}
-
mlcui authored
Like the V1 settings page, every disabled IME can be tab-selected to enable it. However, the outline showing that the IME was selected was hidden, which made it unclear what the currently tab-selected item was without using ChromeVox. This CL unhides the outline, making it clear that the IME item is selected. Fixed: 1163872 Change-Id: I708f2e2d666da0dfe6e4a6f3a831f8e5a92b0bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616640Reviewed-by:
My Nguyen <myy@chromium.org> Commit-Queue: Michael Cui <mlcui@google.com> Cr-Commit-Position: refs/heads/master@{#841315}
-
Sammie Quon authored
Some functions mostly for testing that are no longer used. Bug: none Test: compiles Change-Id: I7f6c6cdc51595668109923c3c199a9a1d969af0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616758Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#841314}
-
Harvey Yang authored
This commit adds OnECLidAngleDriverStatusChanged in AccelerometerReader::Observer, which simplifies implementations of AccelerometerProviderInterface by removing the one-time-read. This commit also implements AddObserver, RemoveObserver, StartListenToTabletModeController, and StopListenToTabletModeController in AccelerometerProviderInterface instead of the derived classes. BUG=b:171446270, b:172414227 TEST=unit tests and run on kohaku(with iioservice) and helios(without iioservice) Change-Id: Ic0d37edc8df22cbd6facf54fe5fb0d11425be2b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538855 Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#841313}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5e4ae54dec3d..cdb3bc3b93da 2021-01-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a66f367f..aff08690 (841068:841210) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2a504654a37c2a0c23a3f2947b3ad6edf22b7f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617027Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841312}
-
Jeffrey Kardatzke authored
This adds a parameter to CreateCdm so we can pass the origin to the CdmFactoryDaemon so it can use proper per-site identifiers in provisioning requests. BUG=b:153111783 TEST=Verified with corresponding ChromeOS change that origin is sent Change-Id: Ic2cfbdf54feb173969bee7377acdc244422eccff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613944 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#841311}
-
Nancy Wang authored
Add the restore_id to AppLaunchParams and browser::CreateParams, to set the id from the restore data as the window's property: kRestoreWindowIdKey, for the full restore to restore browser windows. Modify the web app interface CreateWebApplicationWindow to pass the restore id to the browser class. BUG=1146900 Change-Id: Ia9c88a7f3eddcd0d984d555c6cd15a9351fa5248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599650 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Clark DuVall authored
The supports_isolated_split arg is no longer needed since all DFMs support isolated splits. Bug: 1126301 Change-Id: Idf1ef64bec372f21efd68cb9d05933690cf8b1c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617118 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#841309}
-
Leonid Baraz authored
The declaration in proto would now match code and TIN. Bug: b:170054326 Change-Id: I1204ec91bf592ba31d592abb4461f9b83c81ae7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615102 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Auto-Submit: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#841308}
-
Aaron Leventhal authored
Help determine causes of flakiness for Hyperlink issues, as well as flaky tests for aria-hidden iframes. Use @WAIT-FOR done with 50ms timeout in order to give iframe sub documents a chance to load. The timeout is not ideal, but there currently is no better way unless the iframe has some actual contents to wait for. Bug: 1158699,1157731 Change-Id: If6526616f6f9ceeac59a80c8ee8c2cb6b4d6e83a Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611284 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#841307}
-
Ken MacKay authored
The mixer ensures this in actual operation, and some postprocessors assume that the frame count is divisible by 8. Change-Id: I8fb5cd808c0e481f9a19e77c96595023e1320112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616867Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#841306}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fc4d8fb1. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-sizing domenic@chromium.org, hiroshige@chromium.org: external/wpt/import-maps eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer rego@igalia.com: external/wpt/css/css-grid external/wpt/css/selectors NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I0f399ae6788eaf391e9423a24d82b45a50ecfa13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616341Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841305}
-
Victor Costan authored
The MediaCodecVideoDecoderAV1Test test suite is currently not instantiated, so it does not run at all. Also, the MediaCodecVideoDecoderTest suite is not currently run for the AV1 codec. This CL fixes both problems. The first problem was discovered by attempting to roll googletest past CL 315255779, which causes test binaries to fail when they include test suites / parametrized tests that are not instantiated, and when they include empty test suites. Bug: 1163396 Change-Id: Id2a070cfeed6d37b920b5d28f947037ac5699fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616486 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#841304}
-
Tommy Nyquist authored
This reverts commit 8ce519f2. Reason for revert: FeedProcessScopeDependencyProviderTest fails to initialize on internal buildbot. Original change's description: > Feedv2: Add a persistent key value store > > This is provided for use by xsurface. It is backed by Chrome's > shared ProtoDatabase. Data is automatically wiped on the same > events that wipe other feed data. > > Bug: 1158468 > Change-Id: Id215ec00311883acc65c7f3d6b87570c4b255278 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590649 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Justin DeWitt <dewittj@chromium.org> > Reviewed-by: ssid <ssid@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Commit-Queue: Dan H <harringtond@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841148} TBR=sky@chromium.org,thakis@chromium.org,isherman@chromium.org,dewittj@chromium.org,ssid@chromium.org,freedjm@chromium.org,harringtond@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: If83ab5a8f427a2cd269d89c4957e475dd861545e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1158468, 1164102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617198Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#841303}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a0e863bd2219..8e33046d8bd5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC qjw@google.com,cmumford@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1064651,chromium:1117773,chromium:1139098,chromium:1145728,chromium:1150925,chromium:1150928,chromium:1158906,chromium:1161396 Tbr: qjw@google.com,cmumford@google.com Change-Id: I3be09ddc63cfcf38221922b9ba1e8fcf88efe9bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616918Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841302}
-
Hirokazu Honda authored
https://chromium.googlesource.com/codecs/libgav1.git/+log/a9449e612bc2..a5ee0e00923c $ git log a9449e612..a5ee0e009 --date=short --no-merges --format='%ad %ae %s' 2020-12-28 jayashri.murugan x86: Add OverlapBlendVertical SSE4.1 intrinsic for 10-bit 2020-12-22 jayashri.murugan x86: Add OverlapBlendHorizontal SSE4.1 intrinsic for 10-bit 2020-12-21 hamsalekha.s x86: Add CflIntraPredictor SSE4.1 intrinsic for 10 bit 2020-12-16 jayashri.murugan x86: Add AverageBlend10bpp_SSE4_1 for 10-bit 2020-12-16 vishnu.teja x86: Add DistanceWeightedBlend_10bpp_SSE4_1 2020-12-12 jayashri.murugan x86: Add MaskBlend10bpp_SSE4_1 for 10-bit 2020-12-11 cherma.rajan x86: Add WeightMask SSE4.1 intrinsic for 10-bit 2020-12-21 wtc Document Round2() is OK in FilterIntraPredictor_C 2020-12-21 jzern dsp.cc: rm unnecessary weight_mask_neon.h include 2020-12-21 jzern average_blend.cc: fix 10-bit init (...) 2020-08-24 linfengz dsp: update WienerFilter_SSE4_1() 2020-08-24 slavarnway Reduce size of direction_y[] 2020-08-21 jzern cpu.h: disable AVX2 w/LIBGAV1_ENABLE_SSE4_1=0 2020-08-21 linfengz increase kMaxAlignment 2020-08-21 jzern inverse_transform_neon: make some loops do/while 2020-08-21 jzern inverse_transform_{sse4,neon},cosmetics: s/&(dst|src)\[0\]/\1/ 2020-08-20 linfengz dsp: add AVX2 support 2020-08-20 jzern move GetNumRows to reconstruction.cc 2020-08-19 linfengz trivial: update WienerFilter_SSE4_1() 2020-08-19 jzern inverse_transform_neon,cosmetics: use vqrdmulhq_n_s16 Created with: roll-dep src/third_party/libgav1/src Bug: b:175886969 Test: None Change-Id: Ifb9a8666c9f39a385d494e34d44652bbba7727c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612547Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#841301}
-
David Tseng authored
[97932:775:0107/075158.384149:FATAL:automation_event_router.cc(184)] Check failed: desktop || ax_tree_id != ui::AXTreeIDUnknown(). 0 libbase.dylib 0x0000000104b0d23f base::debug::CollectStackTrace(void**, unsigned long) + 31 1 libbase.dylib 0x0000000104819ca8 base::debug::StackTrace::StackTrace(unsigned long) + 72 2 libbase.dylib 0x0000000104819d2d base::debug::StackTrace::StackTrace(unsigned long) + 29 3 libbase.dylib 0x0000000104819d05 base::debug::StackTrace::StackTrace() + 37 4 libbase.dylib 0x0000000104872433 logging::LogMessage::~LogMessage() + 179 5 libbase.dylib 0x00000001048733b5 logging::LogMessage::~LogMessage() + 21 6 libbase.dylib 0x00000001048733d9 logging::LogMessage::~LogMessage() + 25 7 libbase.dylib 0x00000001047d730b logging::CheckError::~CheckError() + 43 8 libbase.dylib 0x00000001047d6dc5 logging::CheckError::~CheckError() + 21 9 libchrome_dll.dylib 0x0000000109cdc3bb extensions::AutomationEventRouter::Register(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int, ui::AXTreeID, bool) + 219 10 libchrome_dll.dylib 0x0000000109cdc2b2 extensions::AutomationEventRouter::RegisterListenerForOneTree(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int, ui::AXTreeID) + 98 11 libchrome_dll.dylib 0x0000000109ce3efb extensions::AutomationInternalEnableTabFunction::Run() + 1579 12 libchrome_dll.dylib 0x0000000109889e8b ExtensionFunction::RunWithValidation() + 539 13 libchrome_dll.dylib 0x0000000109894d1d extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal(ExtensionHostMsg_Request_Params const&, content::RenderFrameHost*, int, base::RepeatingCallback<void (ExtensionFunction::ResponseType, base::ListValue const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)> const&) + 1741 14 libchrome_dll.dylib 0x0000000109893f4d extensions::ExtensionFunctionDispatcher::Dispatch(ExtensionHostMsg_Request_Params const&, content::RenderFrameHost*, int) + 637 15 libchrome_dll.dylib 0x0000000109921bd3 extensions::ExtensionWebContentsObserver::OnRequest(content::RenderFrameHost*, ExtensionHostMsg_Request_Params const&) + 211 16 libchrome_dll.dylib 0x0000000109923827 void IPC::DispatchToMethodImpl<extensions::ExtensionWebContentsObserver, void (extensions::ExtensionWebContentsObserver::*)(content::RenderFrameHost*, ExtensionHostMsg_Request_Params const&), content::RenderFrameHost, std::__1::tuple<ExtensionHostMsg_Request_Params>, 0ul>(extensions::ExtensionWebContentsObserver*, void (extensions::ExtensionWebContentsObserver::*)(content::RenderFrameHost*, ExtensionHostMsg_Request_Params const&), content::RenderFrameHost*, std::__1::tuple<ExtensionHostMsg_Request_Params>&&, std::__1::integer_sequence<unsigned long, 0ul>) + 167 17 libchrome_dll.dylib 0x00000001099236d8 std::__1::enable_if<(sizeof...(ExtensionHostMsg_Request_Params const&)) == (std::tuple_size<std::__1::decay<std::__1::tuple<ExtensionHostMsg_Request_Params> >::type>::value), void>::type IPC::DispatchToMethod<extensions::ExtensionWebContentsObserver, content::RenderFrameHost, ExtensionHostMsg_Request_Params const&, std::__1::tuple<ExtensionHostMsg_Request_Params> >(extensions::ExtensionWebContentsObserver*, void (extensions::ExtensionWebContentsObserver::*)(content::RenderFrameHost*, ExtensionHostMsg_Request_Params const&), content::RenderFrameHost*, std::__1::tuple<ExtensionHostMsg_Request_Params>&&) + 136 18 libchrome_dll.dylib 0x0000000109921a7f bool IPC::MessageT<ExtensionHostMsg_Request_Meta, std::__1::tuple<ExtensionHostMsg_Request_Params>, void>::Dispatch<extensions::ExtensionWebContentsObserver, extensions::ExtensionWebContentsObserver, content::RenderFrameHost, void (extensions::ExtensionWebContentsObserver::*)(content::RenderFrameHost*, ExtensionHostMsg_Request_Params const&)>(IPC::Message const*, extensions::ExtensionWebContentsObserver*, extensions::ExtensionWebContentsObserver*, content::RenderFrameHost*, void (extensions::ExtensionWebContentsObserver::*)(content::RenderFrameHost*, ExtensionHostMsg_Request_Params const&)) + 575 19 libchrome_dll.dylib 0x00000001099217e7 extensions::ExtensionWebContentsObserver::OnMessageReceived(IPC::Message const&, content::RenderFrameHost*) + 295 20 libchrome_dll.dylib 0x000000010f2a0216 extensions::ChromeExtensionWebContentsObserver::OnMessageReceived(IPC::Message const&, content::RenderFrameHost*) + 166 21 libcontent.dylib 0x00000001486eba12 content::WebContentsImpl::OnMessageReceived(content::RenderFrameHostImpl*, IPC::Message const&) + 706 22 libcontent.dylib 0x0000000147fcaa32 content::RenderFrameHostImpl::OnMessageReceived(IPC::Message const&) + 114 23 libcontent.dylib 0x00000001480cb8b4 content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const&) + 228 24 libipc.dylib 0x000000013b853700 IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&) + 160 25 libipc.dylib 0x000000013b859cb7 void base::internal::FunctorTraits<void (IPC::ChannelProxy::Context::*)(IPC::Message const&), void>::Invoke<void (IPC::ChannelProxy::Context::*)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context>, IPC::Message>(void (IPC::ChannelProxy::Context::*)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context>&&, IPC::Message&&) + 151 26 libipc.dylib 0x000000013b859b66 void base::internal::InvokeHelper<false, void>::MakeItSo<void (IPC::ChannelProxy::Context::*)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context>, IPC::Message>(void (IPC::ChannelProxy::Context::*&&)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context>&&, IPC::Message&&) + 102 27 libipc.dylib 0x000000013b859ad3 void base::internal::Invoker<base::internal::BindState<void (IPC::ChannelProxy::Context::*)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context>, IPC::Message>, void ()>::RunImpl<void (IPC::ChannelProxy::Context::*)(IPC::Message const&), std::__1::tuple<scoped_refptr<IPC::ChannelProxy::Context>, IPC::Message>, 0ul, 1ul>(void (IPC::ChannelProxy::Context::*&&)(IPC::Message const&), std::__1::tuple<scoped_refptr<IPC::ChannelProxy::Context>, IPC::Message>&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul>) + 99 28 libipc.dylib 0x000000013b859a5c base::internal::Invoker<base::internal::BindState<void (IPC::ChannelProxy::Context::*)(IPC::Message const&), scoped_refptr<IPC::ChannelProxy::Context>, IPC::Message>, void ()>::RunOnce(base::internal::BindStateBase*) + 76 29 libbase.dylib 0x00000001047cba2f base::OnceCallback<void ()>::Run() && + 111 30 libbase.dylib 0x00000001049e2fd2 base::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 1394 31 libbase.dylib 0x0000000104a36bc1 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::sequence_manager::LazyNow*) + 1569 32 libbase.dylib 0x0000000104a36343 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() + 147 R=dmazzoni@chromium.org Change-Id: I1dbef11639111a1c5723ad7f8636c0dc39c0f8eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614842Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#841300}
-
Evan Stade authored
Bug: 1147268 Change-Id: Ib4b7cf44f01dc2a4f232e5628be4757f26b30a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612367Reviewed-by:
-
Ryan Hansberry authored
This NOTREACHED() will be restored after correctly preventing it from being called. This prevention mechanism will take non-trivial effort and is not urgent. Bug: 1152491 Change-Id: I952640c42e10e25fa9bdba6dd543f3593d06f923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617026Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#841298}
-
Xida Chen authored
This was left as a TODO item in here: https://chromium-review.googlesource.com/c/chromium/src/+/2549530/12/cc/animation/keyframe_model.h Specifically, we have |target_property_id_|, |custom_property_name_|, and |native_property_type_| that should be bundled together to identify a property in that KeyframeModel. This CL does bundle them. This is a code health change, no behavior change should be introduced. Bug: 1156631 Change-Id: I480275aafd263bd8c6cb11781d701a51621f96b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588369Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#841297}
-
Kevin McNee authored
The webview loadcommit event's url property is documented as being "the URL that committed," however we are currently setting it to whatever the webview's src attribute is set to. We now set the event's url property correctly. See https://developer.chrome.com/apps/tags/webview#event-loadcommit Bug: 1149615 Change-Id: I7e00bc78a503141893b0414ee1c8a4f7e2eecde2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545264 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#841296}
-
Joel Hockey authored
Allow lacros to get, set, and be notified for changes in ash prefs. Bug: 1161413 Bug: 1163288 Change-Id: Ie086018acf4d7fa8378a968415f76792543a2f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607983 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#841295}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e856b6bba826..4c392afda300 2021-01-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: I67ed116b69d6d7fd3d6363dfb7f4b35d24aae15e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616359Reviewed-by:
-
chinsenj authored
With browsers, users can access the Assign to Desk menu through the context menu. For PWAs, users can only access the Assign to Desk menu through the triple dot menu. Users should be able to access this menu through the context menu for PWAs as well. This CL exposes the Assign to Desk menu in PWA's context menu. Test: manual Bug: 1164003e Change-Id: I1d0b4c2463aa1e4d56e75ecc7122d231c4acd25f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616343Reviewed-by:
-
Max Curran authored
This CL adds logging of proposed Translate proto to UKM. This proto captures a summary of the user's interaction with Translate from the beginning of the page load to when the proto is logged. In the event that the user backgrounds Chrome and later returns, there may be more than one proto logged per page load. In this case the sequence number of each proto can be used distinguish the order that the protos were logged. Full design doc: https://docs.google.com/document/d/1dyWh1Xw5VgUA00VA-5PTgKQ6ItziPBnSyeDR8saJ9vM/edit?usp=sharing UKM collection review: https://docs.google.com/document/d/1UNVJ2HC35Cy2C6zCb6DdwKFhafURGeV9gDzY5Jm5id8/edit?usp=sharing Bug: 1114868 Change-Id: If970d2b656c7355e6a05fa06729978265d9ecb64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590754 Commit-Queue: Max Curran <curranmax@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#841292}
-
Xing Liu authored
This reverts commit 68ff3a4c. Reason for revert: BookmarkBridgeTest is batched running on official bot with @Batch annotation, suspect batched tests don't load feature flag correctly, which make us to load EmptyReadingListManager in cc. Original change's description: > Read later: Fix crash and check URL scheme when adding a reading list. > > We should expect ReadingListManager::Add to return nullptr when the > title can't be parsed as UTF strings, or the URL scheme is not http or > https. > > Bug: 1157808,1163225 > Change-Id: I1d4e9ceb74f2821bda19907936d43919c8cc9dbd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611628 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840779} TBR=dtrainor@chromium.org,shaktisahu@chromium.org,wylieb@chromium.org,xingliu@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1157808 Bug: 1163225 Change-Id: I02e68dd57ccd1fa5d8edec4a0799c80c182b29b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616960Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841291}
-
Emily Stark authored
We use these fairly regularly for various experiments. Change-Id: I7571a3219a93ff40ba074bbc08d763d5b13d6248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601110 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#841290}
-
David Black authored
Addresses two problems: 1. Rendered thumbnails may not have opaque backgrounds which can make them look a bit untidy when shown in holding space chip item views. 2. Generic file type icons lack sufficient contrast in some contexts in which they are shown (e.g. bubble, shelf preview, etc.). UX solution: 1. Add white background to holding space images in item chip views. 2. Darken generic file type icons. 3. Revisit later w/ dark/light mode effort. Bug: 1163702 Change-Id: I32ffea29014073e2e0eac74d3db7635e9071b3c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616752Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#841289}
-
Joey Arhar authored
When modifying the src property of an embed element, the contents are not currently changed unless there is also a type property/attribute on the embed element. crbug.com/1035330 suggests that embed elements should load the new src when it is changed regardless of the type attribute, and this UseCounter will be used to determine the impact of this change in behavior. Bug: 1035330 Change-Id: I011abbf5e2aa8e9a7f5065d6c401c95a3c0b12fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616722Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#841288}
-
Jao-ke Chin-Lee authored
Add --loop to loop decoding indefinitely. This will help in gathering benchmarking values during which we control how long the video is played. BUG=chromium:1062407,b:175909299 TEST=./decode_test --video=resolution_change_500frames-vp9.ivf --loop --out-prefix=res_change/frame on nautilus Change-Id: I50f4828f2c5cae05403fff8af307b4f54fcaf5a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610630Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#841287}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610042255-9fb87833d682e7ab89f65b59b49fe1c3c9960d61.profdata to chrome-win64-master-1610052964-a33bb7f09ef1aa4be028cda8573fe902d004ec4a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie0e7c09c2c48521880a18b3b9fe045cbd7e4e847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616539Reviewed-by:
-
Yuwei Huang authored
This CL adds a HostSettings class and provides an implementation for Mac for reading simple key-value pairs, and add a new host setting, `capture_audio_for_device_uid` to specify which UID the Mac host should capture the audio from. This code is still very preliminary. It only loads the file once, and it doesn't create the file for the user. The user will need to manually create a file at: /Library/PrivilegedHelperTools/org.chromium.chromoting.settings.json, make it readable by both root and the current $USER, and add the capture_audio_for_device_uid mapping. Bug: 1161363 Change-Id: I8ee5269908a9a775d003b6349e3c7567d88380b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612400 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#841285}
-
Reilly Grant authored
This reverts commit bc8b035e. Reason for revert: Updated not-webview-exposed.txt. Original change's description: > Revert "serial: Mark the API stable" > > This reverts commit e2029732. > > Reason for revert: WebViewLayoutTest#testWebViewIncludedStableInterfaces is failing because the new API doesn't set up whether it should be exposed in WebView. Interfaces which are intentionally not exposed in WebView need to be added to not-webview-exposed.txt > > Original change's description: > > serial: Mark the API stable > > > > Updates runtime_enabled_features.json5 and the stable webexposed tests > > to mark the Web Serial API stable on desktop platforms. > > > > Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/RCtZPCQLLOQ > > > > Bug: 884928 > > Change-Id: Ifefaa045a239d3b482287016c98e72c0d8c1da15 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579840 > > Commit-Queue: Reilly Grant <reillyg@chromium.org> > > Auto-Submit: Reilly Grant <reillyg@chromium.org> > > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#840355} > > TBR=reillyg@chromium.org,chrishtr@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 884928, 1163922 > Change-Id: Ib6cc7c3e2d5c323abf4d135da576a87d178653ab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611260 > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Reviewed-by: Alice Wang <aliceywang@chromium.org> > Auto-Submit: Alex Ilin <alexilin@chromium.org> > Commit-Queue: Alex Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841158} TBR=reillyg@chromium.org,chrishtr@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,aliceywang@chromium.org # Not skipping CQ checks because this is a reland. Bug: 884928 Bug: 1163922 Change-Id: I4d1c73b082e65f89abc45645bac8c47ae4036f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615741Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#841284}
-
Thomas Guilbert authored
This CL converts deprecated AudioBus methods into explicit static methods that behave the same way under the hood. Bug: 619623 Change-Id: I54a8a61727b69a361ce1c789e572b829a99f32b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603422Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#841283}
-
Nancy Wang authored
This CL adds the AppLaunchHandler class to call FullRestoreReadHandler to read the full restore data from the full restore data file on a background task runner, and restore apps and web pages based on the user preference or the user's choice. The apps can be re-launched for the restoration when: 1. There is the restore data for the app. 2. The user preference sets always restore or the user selects 'Restore' from the notification dialog. 3. The app is ready. If one of the above 3 conditions is not ready, wait until all of them are ready. BUG=1146900 Change-Id: I0ac76e856458d762cbda1606432e26f8bf08447d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599646Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#841282}
-
Mitsuru Oshima authored
* I give up using mock time because it still doesn't drive begin frame correctly. * Factor out the TestReporter as a ThroughputReporterTesterBase template. * Changed animation_throughput_reporter_unittest to use it. Bug: 1157649 Change-Id: I876167808bc6c11872de64bfc9bc6e4263592f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581519Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
-
Xing Liu authored
Change the app menu IPH string. Bug: 1139076 Change-Id: If15af359610cdd1ea9138d8f95555c5c2aec0950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615303Reviewed-by:
-
Phillis Tang authored
Add instruction to PWA install In-Product Help bubble about how to install the app with text "by clicking the install button". This is important for users who use screenreader, as they can't see the install button is highlighted. Bug: 1164050 Change-Id: Ia0a96c13433f385be557dc96c856d60737abdbb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616484Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#841279}
-
Thomas Lukaszewicz authored
This CL fixes MediaDialogView to use the SetPaintClientToLayer() API. Bug: None Change-Id: I849f96a4e205f4b056b216ca97ca14e0af332d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597807Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#841278}
-
Sophie Chang authored
This moves the prediction model fetcher and some adjacent pieces into components/optimization_guide/core. This is low-hanging fruit in that I don't need to rework the code to move it into components. Follow-up CLs will move additional pieces of the prediction code (i.e. prediction manager and downloading pieces) Bug: 1154790 Change-Id: I8d3a914ea223b17a61e4ef70fd89e8b2630b9828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615502Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#841277}
-
