- 14 Aug, 2020 3 commits
-
-
chrome://flagsYicheng Li authored
The ChromeOS Authenticator for WebAuthn is hidden behind a feature flag "base::Feature kWebAuthCrosPlatformAuthenticator". This change exposes the flag in chrome://flags so that developers can test it without entering dev mode. when the flag is "default", and shows up if the flag is "enabled" Bug: b:156258540, b:144861739 Test: Tested on Nami device, ChromeOS Authenticator doen't show up Change-Id: I1fc5e8d24fc25004aaba413968295fb1843070a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354676 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#797922}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 33d245c7. With Chromium commits locally applied on WPT: e074b42b "Delay restarting inline rAF loop until page is notified of session end" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ice190734b83f7a4ef0faf2d8b5ac9f3530a3e036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353293Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797921}
-
Peter Kasting authored
Bug: 1104532 Change-Id: I39b9cd3b82b80bcdca324f4ee798c3c280fa6aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354901 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#797920}
-
- 13 Aug, 2020 37 commits
-
-
Zhaoliang Ma authored
This CL enable the vp9 profile2 encoding in VpxVideoEncoder. Bug: 897297, 1045248 Change-Id: I34dd9ddb3fc49a37136ee864a264e3bb257ded31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351623Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#797919}
-
Carlos Frias authored
This CL adds the mode state value to WebApp class and persists the value using the WebAppDatabase. Adding GetAppRunOnOsLoginMode() to AppRegistrar (implemented in WebAppRegistrar). Adding SetAppRunOnOsLoginMode() to AppRegistryController (implemented in WebAppSyncBridge). Run on OS Login methods were moved from AppShortcutManager to OsIntegrationManager. The Run on OS Login state default value is "kUndefined" for all web apps in the registry. The value for Run on OS Login mode, if enabled, is set at WebAppInstallFinalizer. Bug: 1092569 Change-Id: If9b97a685fabb94039125b6c85d2af84056fe9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236453 Commit-Queue: Carlos Frias <carlos.frias@microsoft.com> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#797918}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/409802afddc8..7497bb4edd42 2020-08-13 Han) Zhang Modified git cl format for distributed histograms If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I856b7351347546d9c42c3c53911112782150ee8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354897Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797917}
-
Donn Denman authored
BUG=1116202 Change-Id: I10738961da81ad153b770210e3d969210b0bcd0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354557 Commit-Queue: Donn Denman <donnd@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#797916}
-
Hui Yingst authored
With PPCompletionCallbackFromResultCallback() wraps base::OnceCallback as a pp::CompletionCallback, direct references to pp::CompletionCallbackFactory in pdf/ now can be removed. Bug: 1101169 Change-Id: If8249b1d995221f9f7fb765dee8509368c7a21bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347978 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#797915}
-
phillis authored
This adds a one liner for policy and system web apps to explain what they are and used for. Bug: none Change-Id: I3d656b91789e013b7535aa58ed541dda43023675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353524 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#797914}
-
Sammie Quon authored
Regression from crrev.com/c/2335794. Which simplify placement logics but forgot to add margin between rows. Test: manual Change-Id: Iebeec0c7c729fb171f2e980a6d5a2f70f206b682 Fixed: 1115917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354921Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#797913}
-
Sophie Chang authored
Change-Id: I9d49e60dc62ec3e289a187da197fcdb699574e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354462Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#797912}
-
Daniel Hosseinian authored
Add a deprecation warning icon for Cloud and Privet printers in the destinations dialog. Screenshot of change: https://imgur.com/I2CPiqj Bug: 1112581 Change-Id: I61eb58920eb16bf9b3f6f0db389ee3db80a7d9dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350118 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#797911}
-
Haiyang Pan authored
This reverts commit d7f6a170. Reason for revert: PortalBrowserTest.CallActivateOnTwoPortals fails consistently since the following builds on emulator builders: * https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/1834 * https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-fyi-rel/1685 Original change's description: > Portals: Make breakpoints inside portalactivate event handlers work > > Currently, we reset the DevTools session before portal activation and > create a new session with the activated portal's WebContents. We dispatch > the portalactivate event and run any event handlers in the interim while > there are no agents active, and as a result, existing breakpoints do not > work. > > This CL waits for DevTools to point at the portal WebContents before > actually swapping the WebContents, thus making sure that the > portalactivate is dispatched after the main target has been reattached. > > Bug: 1025761 > Change-Id: I930d5f7ec361cd594c60bcece0bd9450a94994e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295080 > Reviewed-by: Peter Boström <pbos@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Lucas Gadani <lfg@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797727} TBR=dgozman@chromium.org,pbos@chromium.org,petermarshall@chromium.org,adithyas@chromium.org,lfg@chromium.org Change-Id: I70719f59f2c6c39d9dd9a0e0f57fef920ae76682 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1025761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355135Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#797910}
-
Robert Ogden authored
Previous CL didn't improve browser startup latency, trying this. Bug: 1113691 Change-Id: I0264cf566faf3b8a1ec118217ec16582cee5a020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354918 Commit-Queue: Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Auto-Submit: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#797909}
-
Mohammad Refaat authored
Right now sessions data on disk are never deleted. Instead delete them whenever the app receives a signal that this session can no longer be brought back via "didDiscardSceneSessions" appdelegate. This is done by adding a new method to BrowsingDataCommands protocol and allowing the mainController to conform to it. Bug: 1114847 Change-Id: I767f75c996fa8554943c09f84c9c637851beee32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347248 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#797908}
-
Alexander Cooper authored
Some tests were currently failing on code that (seemed to be) trying to call XrDestroySession, which was not defined by the FakeOpenXrImpl API. This change defines that method, so the tests that were disabled should be passing again. If the flakes still occur, some logging will need to be upgraded to DLOG(ERROR), so that we can get a better idea of what's going on, since there is some amount of distrust of the callstacks. Fixed: 1115721 Change-Id: Ibeb8fdeb38c84da83be886cf6a02b53289d76b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354523Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#797907}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/78d7b4b8250e..8fa7957ea438 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia236e2aff83fb829dce850d3cd2f4122f943681e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353172Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797906}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. Bug: 1110266 Change-Id: I5a906f5fd11894d2a618daced64235e8af558cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354835Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#797905}
-
Moe Ahmadi authored
- Enables zero-prefix suggestion in Desktop NTP (Omnibox and Realbox) and modifies the tests according to the new expectation. - Removes already enabled features and related fieldtrial params from fieldtrial_testing_config.json Bug: 1075724 Change-Id: I7e63dc5d6532fe8baf83fe358f47c00fa61729d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2175138 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#797904}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/326b98981e78..5b27846491d0 2020-08-13 senorblanco@chromium.org Dawn: rewrite of uniform uploads. 2020-08-13 robertphillips@google.com Update more example code to GrDirectContext/GrRecordingContext pair 2020-08-13 mtklein@google.com more careful SkColorSpace hash collision detection 2020-08-13 johnstiles@google.com Refuse to inline SkSL with returns inside breakable constructs. 2020-08-13 adlai@google.com Prohibit gpu to raster in SkSpecialImage 2020-08-13 senorblanco@chromium.org Dawn: remove access to deprecated fields in BufferCopyView. 2020-08-13 robertphillips@google.com Handle invalid DDLRecorder case 2020-08-13 brianosman@google.com Properly clean up va_list in SkSL::OutputStream 2020-08-13 fmalita@chromium.org [skottie] Add audio track support to viewer 2020-08-13 johnstiles@google.com Add missing static qualifier to enforce internal linkage. 2020-08-13 johnstiles@google.com Add missing IR headers to the .gn file. 2020-08-13 bungeman@google.com Better abort in SkBitmap::allocPixels 2020-08-13 johnstiles@google.com Move non-gencode `onDumpInfo` methods to private section. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1105903,chromium:1113865 Tbr: fmalita@google.com Change-Id: Ia61783f5638bb10619f9a00f4d01527b48e984f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354582Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797903}
-
Avi Drissman authored
Followup to https://crrev.com/c/2285339; the new constant kOsMacBigSur should be considered valid. Bug: 1101436 Change-Id: Ifa5872d186ffd9d4886d941485ef3538b090d200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354459 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#797902}
-
Jesse Schettler authored
Create the LorgnetteScannerManager to manage all available scanners in Chrome OS. Clients can request the names of available scanners and use them to perform scans. The manager obtains available scanners using a ZeroconfScannerDetector and the lorgnette D-Bus service. It deduplicates the scanners before giving their names to clients and then uses the lorgnette D-Bus service to perform scans. Bug: b:153541027 Change-Id: I4e93ee7a97e3c06ec8b6390db79997c1441eac7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318310Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#797901}
-
Ken Rockot authored
This was landed with logic to log the wrong histogram name. It should be NQE.ConnectivityMonitor.NetworkChangeEvent, not ...NetworkChangeType, which is the name of the *enum* used by the histogram. Bug: 1079396 Change-Id: I26a0510a061c65e9ea7ddd5b23e19c99f58c4513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354899 Commit-Queue: Ken Rockot <rockot@google.com> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#797900}
-
Jonathan Freed authored
This is a reland of 7be16f97 Original change's description: > Adding network fetcher for fetching images. > > Change-Id: If4d19d6ba2367f7770c4e77c8f885767171bebe3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350148 > Commit-Queue: Jonathan Freed <freedjm@chromium.org> > Reviewed-by: Dan H <harringtond@chromium.org> > Reviewed-by: Ian Wells <iwells@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797494} Bug: 1115855 Change-Id: I6376cf4fb830147a093bf5a8ff301b2939c9367f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354452 Commit-Queue: Jonathan Freed <freedjm@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Auto-Submit: Jonathan Freed <freedjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#797899}
-
Aaron Colwell authored
Removing method and updating tests that use it so that the mock behaves more like the production code. - Removed setter method. - Added is_for_guest_only constructor param similar to RenderProcessHostImpl. - Updated MockRenderProcessHostFactory to provide the is_for_guest_only parameter based on the SiteInstance::IsGuest() method just like RenderProcessHostImpl::CreateRenderProcessHost() does. - Updated NavigationControllerTest.ReloadWithGuest to actually use a guest WebContents so that it doesn't need to change the flag on the process to achieve a guest reload. Bug: 1085275 Change-Id: I23c3db1a810ea6d1f0d7ce9e554585e1caf6b297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354832 Commit-Queue: Nasko Oskov <nasko@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#797898}
-
Gil Dekel authored
This CL fixes a potential race/bug in PrivacyScreenController where the cached display snapshots in the display configurator (from which we derive the internal display's id) may become invalidated while SetPrivacyScreen() tasks are awaiting execution. For example, this may happen when rapid display configuration events are triggered when a device wakes up and is connected to one or more external displays. In addition, this CL instrument drm_util.cc to help investigating https://crbug.com/1105919. Also see: http://crash/browse?q=product_name%3D%27Chrome_ChromeOS%27+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27ui%3A%3ADrmNativeDisplayDelegate%3A%3ASetPrivacyScreen%27#productname:1000,productversion:30,magicsignature:50,magicsignature2:50,stablesignature:50,operatingsystemfamily:30,+devicemodel:40,magicsignaturesorted:50 Bug: 1105919 Change-Id: Ic3b6b86bc9a6f50a115e5ec563b4595ab5c24975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330891 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#797897}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e1360ddcec9e..78d7b4b8250e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic4805e47d2d610ab03a81c638a318b097ded053d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354207Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797896}
-
Sammie Quon authored
Without this, we can get some cases where a non-remove display change can get some persistent bounds stored and won't get overwritten when a remove display change happens. Introduce a mechanism where persistent bounds are calculated when a display change signal is received, but not written to the window state unless a remove signal is received. Test: manual, added tests Bug: 1115675 Change-Id: Id3b642d5912510c451e78a0f9227437d1ce2de1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353065Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#797895}
-
Lan Wei authored
org.chromium.chrome.browser.omnibox.suggestions. SwitchToTabTest#testSwitchToTabInSearchActivity fails on Android, https://analysis.chromium.org/p/chromium/flake-portal/flakes/ occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyigELEgVGbGFrZSJ_Y2hyb21pdW1AY2hy b21lX3B1YmxpY190ZXN0X2Fwa0BvcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIub21uaWJv eC5zdWdnZXN0aW9ucy5Td2l0Y2hUb1RhYlRlc3QjdGVzdFN3aXRjaFRvVGFiSW5TZWFyY2hB Y3Rpdml0eQw disable it for now until it is fixed. TBR= gangwu@chromium.org Bug: 1114938 Change-Id: I9325cbd5a6b8bb75fb53b44e9d96cc6ca74e79a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354919Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#797894}
-
Mohamed Heikal authored
Adds a suppressions file for the Dependency Check gradle plugin. Also improves our error message to make it clearer in the noisy gradle output. Bug: 1114909 Change-Id: Iabed86d80c9a68b2e021940eb948074b09161046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354893 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Adrian Taylor <adetaylor@chromium.org> Cr-Commit-Position: refs/heads/master@{#797893}
-
Peter Kasting authored
Bug: 1104532 Change-Id: I5a1ba068f5ed6bbf16e98339d534f5f083c5d058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355010 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#797892}
-
Henrique Nakashima authored
Pass it as a parameter into constructors where possible. This is a step to modularize TabWindowManager. Next step is to split AsyncTabParamsManager into interface/impl and modularize it. Bug: 1112920 Change-Id: I3461a539177daba5b42e1f1ec422350a84dca8c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347381Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#797891}
-
David Grogan authored
They don't seem to flake anymore. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=blink_web_tests&tests=external%2Fwpt%2Fcss%2Fvendor-imports%2Fmozilla%2Fmozilla-central-reftests%2Fflexbox%2Fflexbox-intrinsic-ratio-003v.html%2C%20external%2Fwpt%2Fcss%2Fvendor-imports%2Fmozilla%2Fmozilla-central-reftests%2Fflexbox%2Fflexbox-baseline-align-self-baseline-vert-001.html%2C%20external%2Fwpt%2Fcss%2Fvendor-imports%2Fmozilla%2Fmozilla-central-reftests%2Fflexbox%2Fflexbox-baseline-multi-item-vert-001a.html 898186 is not mentioned anywhere else in TestExpectations, so I think we can close it. Fixed: 898186 Change-Id: Iaacb252ee2836796aa85833d6dc7ecd8da682ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347967 Auto-Submit: David Grogan <dgrogan@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#797890}
-
Wenhan (Han) Zhang authored
Continuing the change to the new histogram naming system. Added support for out-of-line variants in the model and extract_histograms.py. Change-Id: I98e78031ddef98ef581d8218baf9c31a2f9a3fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346059 Commit-Queue: Wenhan (Han) Zhang <zwenhan@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#797889}
-
Raphael Kubo da Costa authored
yasm is no longer used in Chromium, remove a lingering reference to it. Bug: 766721 Change-Id: I8043e1e089af09e740d4db7ea7119e47d1f8f198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352938Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#797888}
-
Lan Wei authored
AutofillAssistantChromeTabIntegrationTest. startingNewAutofillAssistantCloseTabResumesRunOnPreviousTab fails on Android, https://analysis.chromium.org/p/chromium/flake-portal/flakes/ occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVywAELEgVGbGFrZSK0AWNocm9taXVtQGNo cm9tZV9wdWJsaWNfdGVzdF9hcGtAb3JnLmNocm9taXVtLmNocm9tZS5icm93c2VyLmF1dG9m aWxsX2Fzc2lzdGFudC5BdXRvZmlsbEFzc2lzdGFudENocm9tZVRhYkludGVncmF0aW9uVGVz dCNzdGFydGluZ05ld0F1dG9maWxsQXNzaXN0YW50Q2xvc2VUYWJSZXN1bWVzUnVuT25QcmV2 aW91c1RhYgw, disable it for now until it is fixed. TBR= sandromaggi@google.com Bug: 1115681 Change-Id: If3119c4682c8665cb39c1dea66492bb96dc24864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354620Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#797887}
-
Sergey Ulanov authored
Some Vulkan implementations, particularly swiftshader and i915 drivers use memdfd_create() to implement vkGetSemaphoreFdKHR() API. That syscall was previously enabled only on ChromeOS, which was breaking swiftshader tests when trying to enable synchronization for some images (see http://crrev.com/c/2353413 ) Bug: 1115692 Change-Id: Id0898d6d77ad8aa5140ffe34aa7dafbc3fe19249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354205 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#797886}
-
Kalvin Lee authored
This change implements ParseUsbIndex(). Bug: chromium:888189 Test: chromeos_unittests --gtest_filter='PpdMetadataParserTest.*' Change-Id: Ieec6f0f1a8d68d7ebf09b3d7ce971512896a5dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335410 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#797885}
-
Koji Ishii authored
Bug: 267056 Change-Id: Id3a9d65ec0dab6558f3b8504592648f91bbf1316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351101 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#797884}
-
Rouslan Solomakhin authored
Before this patch, Android payment app implementation lived exclusively in Java, so sharing any of its logic across platforms was difficult. This patch adds a cross-platform way for Web Payment feature to query a list of installed Android apps. As a first step, only information about Trusted Web Activities installed in the Android subsystem of Chrome OS would be returned. After this patch, it's possible to start creating a cross-platform implementation of an Android payment app. Bug: 1061503 Change-Id: Ic8320a902eec537d5aa37b3a6cf9b79b8c579c55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242639 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#797883}
-