- 17 Oct, 2019 40 commits
-
-
zhaoyangli authored
This is the major change for autofill automation EG2 migration. - Separated test and app side code in former automation_egtest.mm by creating private helper function and app interface for app side calls. |NSString*| and |NSError*| are communicated between test and app. App interface code is mostly migrated from automation_egtest.mm with minor changes: - |GREYAssert|s are changed to |NSError*| to be sent back to test. - Moved some instance variable and methods to static variable and functions. - Overrode |launchAppForTestMethod| in |AutofillAutomationTestCase| to start app with needed features. - Created eg2test target and eg_app_support+eg2 target in automation BUILD.gn. Created new eg2tests_module and included new eg2test target in earlgrey2 BUILD.gn. - Removed unused headers in code and unused deps from build file. Bug: 987646, 1003605 Change-Id: I22ae675848bd1b08df9cdb375a6dcfb2f42b8c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850739 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#706954}
-
Cathy Li authored
[ExploreSites]: Do not set height in the dense tile views to allow text to overflow when text size increases Bug: 1009093 Change-Id: Ia4cf81bf699f4fd392ff98e3212d62b77bf7b134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830170 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#706953}
-
Nicolás Peña Moreno authored
This CL adds a test where FCP must be equal to LCP for a website that has a single contentful element: a <p>. It is currently flaky in Chrome. Bug: 1015130 Change-Id: I0da2d7b15ac72fe2f0964043f01c49b089d201a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865540 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#706952}
-
Lan Wei authored
Browser tests ProfileMenuClickTest_WithUnconsentedPrimaryAccount is keeping failing on Mac 10.12. Disable it. Builder: Mac10.12 Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests TBR=tangltom@chromium.org Bug: 1015429 Change-Id: Ib617d534d2ea7eb3b294b456837a5025ecc6698d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865145Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#706951}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0544d1e26010..45f9f6cebc3a git log 0544d1e26010..45f9f6cebc3a --date=short --no-merges --format='%ad %ae %s' 2019-10-17 treehugger-gerrit@google.com Merge "processor: Add foundations for modularization of proto trace parsing" 2019-10-17 primiano@google.com Merge changes I24d0f3b6,I0e78257d 2019-10-17 treehugger-gerrit@google.com Merge "protos: Update comments on TrackEvent protos" Created with: gclient setdep -r src/third_party/perfetto@45f9f6cebc3a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I5e3c8dc8e0ecf2a28c476e281bb522b9034bb1ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866733Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706950}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5f01bf6c8b78..c06aef2ad1b3 git log 5f01bf6c8b78..c06aef2ad1b3 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 sprang@webrtc.org Reland "Use just a lookup map of RTP modules in PacketRouter" 2019-10-17 mbonadei@webrtc.org Update DEPS to download the checked-in JDK. 2019-10-17 mbonadei@webrtc.org Use symbol_level=1 also for MSVC dbg bots. 2019-10-17 sprang@webrtc.org Revert "Use just a lookup map of RTP modules in PacketRouter" 2019-10-17 sprang@webrtc.org Use just a lookup map of RTP modules in PacketRouter 2019-10-17 henrik.lundin@webrtc.org Avoid reading outside of memory in WebRtcVad_FindMinimum 2019-10-17 gustaf@webrtc.org Avoid running NullAudioPoller without receiving streams Created with: gclient setdep -r src/third_party/webrtc@c06aef2ad1b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:b/142775365 Change-Id: I00413a82f84457d4efea64837516eae8619aa05d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866735Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e62dfe9064db..1b3fb455bf18 git log e62dfe9064db..1b3fb455bf18 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 perezju@chromium.org [Telemetry] Remove some dead code in story_run_unittest Created with: gclient setdep -r src/third_party/catapult@1b3fb455bf18 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:921000 Change-Id: Id41221d7be64891f834043ba7957a32373b51542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866734Reviewed-by:
-
Bailey Berro authored
This change switches to calling sync's ReportUnrecoverableError function rather that DumpWithoutCrash. This reduces the number of crash reports that are uploaded with this signature. Change-Id: I46cf634bbfa4dcd460dae89dd4b91a412678fa7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862246 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#706947}
-
Miyoung Shin authored
This CL converts MediaControllerManager{Ptr, Request} in chromeos, content and services to the new Mojo type. Bug: 955171 Change-Id: Ic346dcdeac6e2dc59dc99a953345abd61f9d2c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849735 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#706946}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 60f3e975. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" f2b0f018 "Revert "[Trusted Types] Remove TrustedURL."" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ib1c9ad76b650f97c9f8cb2cdd3a56563d00bc805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866691Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706945}
-
Cliff Smolinsky authored
If we patch a function in a delayloaded dll, __HrLoadAllImportsForDll is called to load everything before the patch. If we then patch another method in the same dll, __HrLoadAllImportsForDll is called again and this will overwrite the original patch. This change adds tracking to ensure the load only occurs once per dll. Bug: 1012424 Change-Id: Ib20fe38461a7eab3735f851bdfd53f9cf99fc5d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848362Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706944}
-
Scott Violet authored
java_observer_ -> java_delegate_ BUG=none TEST=none Change-Id: Ic11f77dfc5110188e6dc658b0fdcd49975e48e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866067 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#706943}
-
Scott Violet authored
This is a good basic set. I would like more, but they require js injection. BUG=none TEST=test*Fullscreen* Change-Id: I0a605e4aefe3b0be6b9a754e437aa496f1e059bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866271Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#706942}
-
Alex Chau authored
- SharedClipboard sender names are embedded in SharingMessage or determined in SharedClipboardMessageHandler - SharingService::GetDeviceByGuid now changes client_name returned - sender_guid is no longer embeded in AckMessage as it's only used for sending acks - Removed dependency of LocalDeviceInfoProvider in SharingFCMSender, instead sender_device_info is passed in and constructed by SharingService with updated client_name Bug: 1013565 Change-Id: If901fe96ba140b804a87fcd8d2565512d76fa167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865318Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#706941}
-
Kurt Catti-Schmidt authored
This CL is aimed at resolving differences in the platform-neutral accessibility tree depending on whether or not UIA is enabled. The goal is to make it possible to enable both IA2 and UIA simultaneously. The differences arise due to the presence of extra nodes to implement IRawElementProviderFragmentRoot for UIA. These extra nodes exist because, for a given web content accessibility tree coming from the renderer, we cannot identify whether that tree corresponds to a root frame, and thus whether that tree's root would be the node we would otherwise expose as the fragment root attached to the legacy HWND. IRawElementProviderFragmentRoot is obtained via QueryInterface, and COM rules require that the set of interfaces available via QI be static over the lifetime of a given object instance. To deal with this, we have separate nodes that act as fragment roots for each HWND, and each fragment root's sole child is the root of the associated accessibility tree. This CL takes these fragment roots out of the platform-neutral accessibility tree. Instead, we re-wire UIA tree navigation to account for fragment roots. The next steps would be to modify the places we check for UIA enabled to not assume that IA2 and UIA are mutually exclusive, and then to implement a feature flag to allow switching between IA2 only, UIA only, and both APIs enabled simultaneously. Bug: 928811 Change-Id: I7a0e6f1b12bc1a8b44fd7c08541703b1277bf9eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823822Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706940}
-
Vladislav Kaznacheev authored
Force-enable kShelfScrollable feature in ScrollableShelfViewTest to make sure they do not regress regardless of the default state of this feature. Bug: 1015426 Test: ash_unittests with and without --shelf-scrollable flag Change-Id: I2c07aaefaff2ba9785884e1959ebdd2a72a3398b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866871 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#706939}
-
Maksim Moskvitin authored
From processor perspective, we always choose remote update in case of conflict. This should work, because bridge aware of not-commited local changes. Pending local commits reapplied on top of incoming changes after processing conflicting remote update as regular update. Bug: 922900 Change-Id: I7673822b4c8b4bd21965d5b2401c9dd3d62f0e6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865333 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#706938}
-
Anatoliy Potapchuk authored
This one just created some code duplication of LoginStatus::KIOSK_APP Bug: 1015383 Change-Id: Id03e4813199dd38b29ca46845182b7f82b04382c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864799 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
-
Jazz Xu authored
Bug: 1015133 Change-Id: I515a115a14febce67c41566cee4a266e6c9386a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865262Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/42ac78d2d012..9b925bcdd2c1 Created with: gclient setdep -r src-internal@9b925bcdd2c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I889f73b8394cc35559983faed7a49602457518ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866732Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706935}
-
Nico Weber authored
headless_shell_child_lib transitively includes something from webrtc (via content/browser) and it gets the include dir for that transitively via a dep on blink if is_multi_dll is true. So things only work by accident there. As a workaround, since we only depend on headless_shell_child_lib if is_multi_dll is true, make the whole target conditionaly. This remains questionable deps-wise (since we pull in the webrtc header via content/browser headers but get the include flag for it via the blink dep), but since multi dll hopefully goes away soon it'll fix itself. Bug: 726150 Change-Id: I23908e640a8ba61ace00ca5189f80d88c1537f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866849 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#706934}
-
Eric Willigers authored
Instead of defining a static constant equal to SkColorSetARGB(0, 0, 0, 0), use the constant defined in SkColor.h Change-Id: I193fe569569cd9698a0463da9d23f9f9bcff64a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865909 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#706933}
-
Austin Eng authored
Projects which depend on third_party/jsoncpp that are not built in a Chromium checkout may not have the //testing/libfuzzer dependencies needed to build jsoncpp_fuzzer. TBR=chromium-third-party@google.com Bug: dawn:208 Change-Id: I4664cca2a975fe52013ad7874db8e098ccbb6098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861014 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#706932}
-
Sorin Jianu authored
It fails an assert in component updater service when the recovery component is registered. https://chromium-review.googlesource.com/1787402 introduced Omaha-style app ids. However, the recovery component code was not modify to use appids, and the it fails to register because the member update_client::CrxComponent::app_id is not set. TBR=waffles BUG=1015073,1001126 Change-Id: If5f0c1a7ba2778b5183156d64fd57d745dc099ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865552Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706931}
-
Raymond Toy authored
If the first event in the timeline starts after the current render quantum and the event is a setTarget, setValue, or setValueCurve, we don't need to do sample-accurate processing because they haven't started yet. Bug: 1013539 Change-Id: If62c6c0e12b8f76c5f3d6db6216c929c775c39ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856874Reviewed-by:
Andrew MacPherson <andrew.macpherson@soundtrap.com> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#706930}
-
Andrey Kosyakov authored
This re-lands https://chromium-review.googlesource.com/c/chromium/src/+/1856929 while fixing unpausing of virtual time during same-document navigation. Change-Id: Ie51a92b2385ff055f0bf86b938349720489bde19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865619Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#706929}
-
John Budorick authored
This reverts commit f4bc92d6. Reason for revert: did not resolve flakes. Original change's description: > Revert "Resubmit: Lower priority of processes hosting exclusively ads." > > This reverts commit 4ba7eb3a. > > Reason for revert: spec revert for > crbug.com/1014952 > crbug.com/1015014 > crbug.com/1015013 > crbug.com/1014951 > > Original change's description: > > Resubmit: Lower priority of processes hosting exclusively ads. > > > > This change adds a variable to ChildProcessPriorityLauncher to > > indicate whether the associated process is only used to run tasks for > > ad frames (low priority frames). That variable is then used by the > > RenderProcessHost to background the frame in those cases. Notification > > happens in the RenderProcessHost via new UpdateFrameWithPriority. > > > > Note: Identification of ad frames is done as per the AdTagging project. > > Frames that have been marked as ads remain ads, and thus the > > RenderProcessHost will remain low priority if the frame is navigated > > to any other non-ad URL within the same process (same domain). > > > > Currently this is behind a feature which is off by default. > > We will be experimenting with this to determine its impact on > > both ads and in the browser as a whole. > > > > TBR=dcheng@chromium.org,gab@chromium.org,pbos@chromium.org,jkarlin@chromium.org > > > > Bug: 979234 > > Change-Id: I1acd1b8de7e66f8b2c47564df5e708f9b41f72a6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855680 > > Commit-Queue: Eric Robinson <ericrobinson@chromium.org> > > Reviewed-by: Alexander Timin <altimin@chromium.org> > > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#706049} > > TBR=alexmos@chromium.org,altimin@chromium.org,ericrobinson@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 979234,1014951,1014952,1015013,1015014 > Change-Id: Ib719e3f70371b7941d0b27f9bc171594149dd24e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864618 > Commit-Queue: John Budorick <jbudorick@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706625} TBR=alexmos@chromium.org,altimin@chromium.org,jbudorick@chromium.org,ericrobinson@chromium.org Bug: 979234, 1014951, 1014952, 1015013, 1015014 Change-Id: I6625c321b9f7a384ed3407b862d3c04b45dfb735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865562Reviewed-by:
-
Joe DeBlasio authored
This CL allows us to disable topsites-based lookalike matching in Safety Tips via a "disable_topsites" feature parameter. This feature param is inverted from the other feature params (it disables instead of enables) to ensure that the default no-param state is consistent before and after this change. Bug: 1015003 Change-Id: I2e7e94622dd20b8879e8157d588d39cf9383e790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865415Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#706927}
-
Henrique Nakashima authored
Move some methods from ColorUtils to it: - getTextBoxColorForToolbarBackground() - getToolbarSceneLayerBackground() - getTextBoxAlphaForToolbarBackground() - isUsingDefaultToolbarColor() - getThemedToolbarIconTintRes() - getThemedToolbarIconTint() This breaks the dependency from ColorUtils to Tab and NewTabPage. Bug: 995916 Change-Id: Ifa4dad973877f6bf764cc8fb3e5c5bdad048cdd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815281Reviewed-by:
-
Michael van Ouwerkerk authored
Bug: 1006264 Change-Id: I0b9d02f8bde14958b7ba3b54215ec330af09a9bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866630Reviewed-by:
-
John Budorick authored
Bug: 1014951 Change-Id: I0212752e770b5d995b81e1c98447f3ff4a9d116c Tbr: achuith@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866789Reviewed-by:
-
Vadym Doroshenko authored
This table contains field identifiers and autofill types that corresponds that were leaned from user actions. In the subsequent CLs this will be used for storing information whether particular form is username form for username first flow. Bug: 959776 Change-Id: If13482fa719638f6552f0e942a65c4731cccf3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865150 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#706923}
-
Jonathan Backer authored
With this CL, SkiaRenderer will receive a signal from GpuServiceImpl::LoseAllContexts and mark the shared context_state_ as lost. This will cause us to abandon all future draws and no-op the releases. Unfortunately, we cannot delete fulfilled promise images after GrContext::abandonContext is called. So an explicit leak in ImageContextImpl::OnContextLost was added. TBR=boliu@chromium.org Bug: 1011420 Change-Id: I5f5e178b6a51d770534c2260274f0b9c75c21831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864413 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#706922}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I5bca7f4f02d72bf7915dcc51ae6b377df869b9e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866405Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706921}
-
khmel@chromium.org authored
These apps exist on system image and available for all users. This also moves custom Play Store case handled separately before to system app. TEST=unit test BUG=1013730 Change-Id: Iaf63d52c38c376b6b07930bc8ec88e5b9de4bb58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865472Reviewed-by:
Josh Horwich <jhorwich@chromium.org> Reviewed-by:
-
Min Qin authored
DownloadFilter is used by non-UI code and should be moved out. BackendProvider is not needed and can be removed. BUG=1013759 Change-Id: I88d346e9035171fff4d371c77df3812e93a857b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865537Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706919}
-
Owen Min authored
Similar to ExtensionManagement::IsInstallationExplicitlyAllowed, IsInstallationExplicitlyBlocked return true only if an extension's installation is blocked by its id but not wildcard. This function is going to be used by extension request feature. With it, user can send extension install request to admin. Only extensions that are not explicily blocked can be requested. Bug: 1006899 Change-Id: I6160fee3ab25f4da095b51bd727fe53fb3b8760c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863635 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#706918}
-
Eric Stevenson authored
This is a reland of 987ed6b5. Fixed the package name in UkmUtilsForTest in the reland. Also moved the test file to be part of the same directory. Original change's description: > Android: Move UkmUtilsForTest.java. > > Moved to a subdirectory of the build target using it. The old location > was confusing because it's in the same directory as non test code. > > Bug: 1010218 > Change-Id: I1de7cd4ec72c7967506ebd8451fcf2b9378a9fe3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838522 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Auto-Submit: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702581} Bug: 1010218 Change-Id: I153ea9f421b1a714350e852060571a3c52814073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841651 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#706917}
-
Nico Weber authored
Instead, use -imsvc and the hermetic toolchain for the preprocessor, and don't look in system include dirs for resources. This means we can't include resources from the system include dirs, but we don't want to do that anyways. For now, keep using tool_wrapper to set the env so that we can find MS rc.exe on %PATH%. Bug: none Change-Id: I1065be2513659c6eb5b4de440299fa86cfb58736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863149Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#706916}
-
Julian Pastarmov authored
I would guess this policy was marked Chrome OS only because at the time Chrome OS was the only platfrom that had cloud management. It technically works on all platfroms as it maps to a pref existing on all platforms. The comment that when invalidation is available and operation the policy is reset is also true and visible on chrome://policy. BUG=1011855 TEST=Existing tests already cover all code paths. Change-Id: I3ebf105345ca71e0508a7170d6f829fae819354c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864797Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#706915}
-
