- 27 Mar, 2018 13 commits
-
-
Aaron Leventhal authored
Use ChromeViewsDelegate/WidgetObserver combination to ensure that all widgets are tested for accessibility as they become hidden or visible in a browsertest. The test goes through the View entire subtree and ensure any focusable View has an accessible name. Bug: 819350 Change-Id: I213e02bcfb1ec64aefc528cbda6a8a2a1d7bd0d0 Reviewed-on: https://chromium-review.googlesource.com/951933Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#545904}
-
sangwoo.ko authored
We manually calculated bounds for tabs duing mouse-based tab closure in order to persist tabs' bounds. But as |available_width_for_tabs_| is shrunk, we can simplify this using GenerateIdealBounds(). TBR=pkasting@chromium.org Bug: None Change-Id: Ice3f965b1224c2952ec0523591d9d3106ff0c5c7 Reviewed-on: https://chromium-review.googlesource.com/979372 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#545903}
-
Bence Béky authored
This reverts commit 1a47d5d6. Reason for revert: https://crbug.com/825804 Original change's description: > Add WebSocket-related CHECKs to HttpStreamFactoryImpl::Job. > > The primary reason for these CHECKs is to better document expectations > in code. Also, they are CHECKs instead of DCHECKs to help track down > crashes in case these expectations do not hold. > > Bug: 819101 > Change-Id: Ia309bbff2f4e048926930cd9a15fbc107994895d > Reviewed-on: https://chromium-review.googlesource.com/975621 > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Commit-Queue: Bence Béky <bnc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545196} TBR=pauljensen@chromium.org,bnc@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Skipping CQ (even though original CL landed more than 24 hours ago) because this is the top crasher in the browser process on Mac, so this should go in before next Canary cut, and definitely before next Dev cut, but ios-simulator bot fails with exception on multiple tries (and also with other CLs). Bug: 819101 Change-Id: Ib998f6b92dd70df943cfb25b1418e1070cb839aa Reviewed-on: https://chromium-review.googlesource.com/980632 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#545902}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7ab45c02..5d39e8a4 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I2791959767664d44fbfcc9bcebc2e2b6f9806d4f Reviewed-on: https://chromium-review.googlesource.com/980776Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#545901}
-
Patti authored
Optimize the LocationBarView and friends for touch by making it taller and enlarging its decorations. This patch will make the circular inkdrops flush with the edges of the Omnibox as well. Icons are also enlarged. Screenshots - https://drive.google.com/open?id=1nzMYsrofnubyZFWT7GQb9KCyV30Wz13p Bug: 801583 Change-Id: Ifa5ae0e86842970add17b1b23a4f708c7a81a1d7 Reviewed-on: https://chromium-review.googlesource.com/915483Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
Sunny Sachanandani authored
Similar to the IPC command buffer proxy unit tests. R=piman BUG=824510 Change-Id: I14ecfc448e12d4f143b645cc9290c476fdbf5d0d Reviewed-on: https://chromium-review.googlesource.com/978959 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#545899}
-
Devlin Cronin authored
In manifest version 1, all extension resources were considered accessible by the web (i.e., could be embedded within or requested by a web page). In manifest v2, only resources explicitly specified in the web_accessible_resources key are accessible. Remove support for manifest v1, and always check the web accessible resources. Update unit tests to migrate relevant tests and remove tests for manifest v1-specific behavior. Bug: 816677, 816679 Change-Id: Id0dd3ef75cd5d49e3f87e45ac3a8b19a00391146 Reviewed-on: https://chromium-review.googlesource.com/953177 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#545898}
-
Mike Klein authored
This reverts commit 670c4688. Reason for revert: Mysteriously, this has caused some regressions on a bunch of bots that do not support the Haswell instruction set. Reverting just to see if that's real (and because this wasn't really a noticeable win anywhere when landing the first time). Bug: 825647, 825586, 825646, 825104 Original change's description: > Allow HSW stages to detect FMAs opportunistically. > > We used to build the .S files with -ffp-contract=fast for this, and > adding it here to the HSW opts will have the equivalent effect. None of > the other x86 targets support FMAs. > > In many key places we do call _mm256_fmadd_ps explicitly, but in several > other stages we have been relying on Clang to sniff out opportunities, > especially for fused-multiply-subtracts, which we're just not very good > at seeing in our heads. > > Bug: 821012 > Change-Id: I2767cbdb7151d60ea7553e83f51b28ff9340eb94 > Reviewed-on: https://chromium-review.googlesource.com/963141 > Reviewed-by: Florin Malita <fmalita@chromium.org> > Commit-Queue: Mike Klein <mtklein@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543262} TBR=fmalita@chromium.org,herb@chromium.org,mtklein@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 821012 Change-Id: I61c0627270853b8acdcf6b20fca17ba0fd8bba55 Reviewed-on: https://chromium-review.googlesource.com/980293 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#545897}
-
Rune Lillesveen authored
Bug: 820299 Change-Id: I596113eeea7d4c13cf689364744bff7c261f93d3 Reviewed-on: https://chromium-review.googlesource.com/978247 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#545896}
-
Hector Carmona authored
https://crrev.com/c/938623 removed #chromeCleanupSecondary, but there was an aria reference to it. This CL removes the dangling aria-describedby. R=ftirelo@chromium.org Bug: 824494 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I32e69b37a911f9586e658bae2b9d4b415b7b2008 Reviewed-on: https://chromium-review.googlesource.com/974379Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#545895}
-
Dan Harrington authored
We've encountered a DCHECK crash here. I've fixed one potential cause, where a fetch fails and another call to FetchImageAndData is made before the image decoding returns. Added unittest to capture this case. Bug: 823925 Change-Id: I99fc94e90d9032dd1bc196319238f6f2e60c68dd Reviewed-on: https://chromium-review.googlesource.com/972440Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#545894}
-
Ken Rockot authored
The interface was moved from chrome:: to content:: namespace, but this manifest was not updated accordingly. Fix that. Bug: 826024 Change-Id: I8024c983f808001411e05fc52469ff7956f9c258 Reviewed-on: https://chromium-review.googlesource.com/981296Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#545893}
-
Weiyong Yao authored
This is a relanding of https://chromium-review.googlesource.com/c/chromium/src/+/651147. After several small issues have been fixed, we can reenable this again. Bug: webrtc:7950 Change-Id: If7d1e2a5b713eaaa6dfbece73a4006df6187c687 Reviewed-on: https://chromium-review.googlesource.com/980668Reviewed-by:
Zijie He <zijiehe@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#545892}
-
- 26 Mar, 2018 27 commits
-
-
Stephen Martinis authored
This reverts commit f8d41208. Reason for revert: crbug.com/826035, this seems to have broken LARNG. Original change's description: > Android: Enable vertical class merging ProGuard optimization > > Shrinks monochrome_apk dex by 53kb uncompressed, 17kb compressed. > Shrinks method_count by 1400. > > Bug: 620323 > Change-Id: Ie9f7c37a20895ecd1d3f1f17357a663252a1be36 > Reviewed-on: https://chromium-review.googlesource.com/981052 > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > Commit-Queue: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545857} TBR=agrieve@chromium.org,estevenson@chromium.org Change-Id: Ib468e971a716c695903be026cfa9ee82eac6b84a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 620323, 825995, 826035 Reviewed-on: https://chromium-review.googlesource.com/981463 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#545891}
-
Kevin McNee authored
When bubbling scroll events to ancestor views, we adjust the event's position by applying the parent's offset. This is incorrect if an OOPIF is subject to CSS scaling, since the point in the child is scaled. We now use a transformation function which accounts for scaling. We were also assuming that the event was being resent to the parent. This is true for GestureScrollBegin events, but for the remaining events in the sequence, we may bubble directly to an ancestor, so those events have the coordinates for the wrong view. We now defer the transformation of the coordinates to the target view's coordinate space to the RenderWidgetHostInputEventRouter which knows which view is the target. Bug: 626020, 817392 Change-Id: I86331f7bfc5fe7dd9e9032beb16ebb75b579f5b1 Reviewed-on: https://chromium-review.googlesource.com/978647Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#545890}
-
Andrew Grieve authored
In cronet, initApplicationContext() is not guaranteed to be called from the UI thread. NOTRY=true # time sensitive. bot timeout unrelated. Bug: 825920 Change-Id: I85a8a9560fee726268637ac96d87d7637407f50a Reviewed-on: https://chromium-review.googlesource.com/980586 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#545889}
-
Will Harris authored
BUG=None Change-Id: Ibbb8fad812554417b90b154ea99cf9e7db624320 Reviewed-on: https://chromium-review.googlesource.com/981200Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#545888}
-
Quinten Yearsley authored
Bug: 790123, 731426 Change-Id: I1ada7316ab4148f9bdacd730738b56ca4baca2e4 Reviewed-on: https://chromium-review.googlesource.com/980734Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#545887}
-
Zhiling Huang authored
Bug: 790142 Change-Id: I7769813cfabb36c6f7c9dfbe00d30c473c21e059 Reviewed-on: https://chromium-review.googlesource.com/980745 Commit-Queue: Zhiling Huang <hzl@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#545886}
-
Alexander Dunaev authored
Also fixed null pointer dereference in BookmarkAppHelper::FinishInstallation. Change-Id: I9e6105e2f20cac3ac7b29035ccb4baa6aafbc308 Reviewed-on: https://chromium-review.googlesource.com/968254Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#545885}
-
Weidong Guo authored
Background: AssistantContainerView is designed to be fullscreen, so it does not fit in HorizontalPageContainer. Also, it will use its own search box to handle text query. Change: 1. Make HorizontalPageContainer and its parent view ContentView fullscreen to accomodate AssistantContainerView. 2. Fade out the search box while switching to AssistantContainerView. A demo video with white background: https://drive.google.com/a/google.com/file/d/1Y5FyrvRli0ExfVOPwVDejqw2bVvCD9Vb/view?usp=drive_web BUG=824994 Change-Id: Ic323fa1033758bde7858418f8b1a0afbc2e60027 Reviewed-on: https://chromium-review.googlesource.com/978513 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#545884}
-
Sergey Berezin authored
This is to mitigate the immediate fire (see the bug). PLEASE REVERT once the bug is fixed. BUG=825843 R=justincohen@chromium.org,maruel@chromium.org Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I87f20f1eff838fa535970da1e2271c0dbffe939f Reviewed-on: https://chromium-review.googlesource.com/981448Reviewed-by:
-
Tien-Ren Chen authored
A previous CL https://chromium.googlesource.com/chromium/src/+/0d2f4351ca12d64119d1aed52faf538a852a12c0 embedded the structure to PaintLayer itself, in order to avoid the cost of heap allocation. However that regressed transform animation with lots of layers on a number of Android devices. It is speculated that the increase in PaintLayer size put more pressure on L2 cache. This CL changes the structure back to external again. Note that this is not equivalent to reverting the previous CL. Before the regressed CL, the structure is reallocated everytime we updated it. With this CL applied, it will become a lazy rare data that will be allocated on first use, but then reused throughout PaintLayer's lifetime. BUG=821773 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia65b8dba8c4d07eed22aed9903a57472ad06960f Reviewed-on: https://chromium-review.googlesource.com/974282Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#545882}
-
Qiang Xu authored
changes: Decouples `show notification` from OnAccessibilityStatusChanged. Callers decide to whether to show notification by explicitly notifying observer themselves. Bug: none Test: tested on emulator, everything looks fine Change-Id: If5cfbeaabea2583f7fe558cf098b69446a63bb14 Reviewed-on: https://chromium-review.googlesource.com/976091 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#545881}
-
Vladimir Levin authored
Before this patch: - We issue a CaptureDump callback from the main frame that has finished a test. If a secondary renderer issues a test finished, this routes via a browser and goes back to the main frame anyway. - We issue several IPCs to the browser for each type of dump requested. - After everything is done, we issue a test done IPC to the browser. With this patch: - We capture local dumps (temporarily*) - We request that a browser initiates a CaptureDump via IPC. - We get a mojo call to capture the dump with an output struct containing all the relevant fields, which the renderer populates from local dumps. - When it finishes populating everything, it issues a callback with that struct. - The browser then records all of the results from the struct and finishes. The new approach seems to be a bit better in that we can move more logic to the browser part and make the renderer part more synchronous. For example, if the browser needs to initiate a layout dump, we can just do that from the browser instead of requiring that the renderer sends an IPC to the browser with that request. Furthermore, because the end goal of this is to have OOPIF pixel dumps, we need those to be initiated from the browser at some point. This also aligns with the pattern where the browser is the part that initiates a capture dump. * - We would like to capture as little as possible locally and instead move things that capture things by asking the browser to the browser directly. R=lukasza@chromium.org, mkwst@chromium.org Bug: 667551 Change-Id: I07d2b16da687b679f6b3020732706e6bd7a77cd4 Reviewed-on: https://chromium-review.googlesource.com/972578 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:Mike West <mkwst@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#545880}
-
Eric Karl authored
We drop GL contexts on low-end devices when we go to the background. This is currently initiated by the GPU process, which kills all GPU channels, eventually causing context-loss in the various clients. While the current approach works, it makes it difficult to avoid rendering artifacts on app resume. As context-loss is lazily identified, it's possible for the browser and renderer to be notified at very different times. This can lead to races where the browser will attempt to draw with invalid renderer resources. To avoid these issues, this CL causes the context-dropping to be triggered from the browser itself. This allows the browser to drop renderer resources at the same time, greatly reducing (but unfortunately not eliminating) the possibility of a race. If we still see these issues with any frequency, further follow-up work, leveraging Surface Synchronization, will likely be able to fully eliminate these cases. Bug: 792120 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1c0f2c6000fc9c1f4171952b09484101a220654c Reviewed-on: https://chromium-review.googlesource.com/959605Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#545879}
-
chaopeng authored
This issue is caused by Direct Manipulation pan transform already scale for DPI, Chromium also scale the scroll event for DPI, so it scale twice. In this patch, we read the device scale factor at the beginning (DM_POINTERHITTEST) of the sequence then divide transform by device scale factor. Bug: 779372 Change-Id: I849d37704fbc17b9abe07d1f9e6e5e2465fbffff Reviewed-on: https://chromium-review.googlesource.com/976951Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Conley Owens authored
This change adds a string `mime_type` to the list of fields in SubresourceLoadInfo. Notably, this is important for recording page load metrics when the Network Service is enabled. BUG=816684 Change-Id: Ie95bd46074f2a0f915eb8378800afa0f5ed46ecd Reviewed-on: https://chromium-review.googlesource.com/963312Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#545877}
-
Jiaquan He authored
Boolean flags |is_tablet_mode_| and |search_engine_is_google_| are used by SearchBoxModel, so let's move them there. This commit also notifies SearchBoxView to change when the search engine changes. Bug: 825301 Bug: 733662 Change-Id: I7f32a96ceb274d2f3740191b23a07a67c2a08c79 Reviewed-on: https://chromium-review.googlesource.com/979711Reviewed-by:
-
Conley Owens authored
This change does 2 things to disable the Physical Web: 1. It makes the feature disabled by default. 2. It removes the relevant entry from about:flags. BUG=internal b/73944725, b/74450333 Change-Id: I126d88c72b97a7b00490453bef78cf3d230e5bfb Reviewed-on: https://chromium-review.googlesource.com/981108Reviewed-by:
Michal Mocny <mmocny@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#545875}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7dbc81628d41ecaf5c1a162f4b564245aa6aeafe Reviewed-on: https://chromium-review.googlesource.com/981412Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#545874}
-
Trent Apted authored
WidgetDelegates must outlive their Widget. Crashes suggest situations where they may not, but can't pinpoint the actual client code. The crash is instead attributed to a UAF on the widget delegate either in a layout call (during an animation), or when Widget::OnNativeWidgetDestroyed() tries to delete the delegate (again). This CL adds a CHECK() in ~WidgetDelegate which should track down the misbehaving code. Bug: 825091, 814821, 808318 Change-Id: I9490ff1682ee236436edf075f7c237ccf910c44c Reviewed-on: https://chromium-review.googlesource.com/977244Reviewed-by:
-
Xunran Ding authored
As GURL is still used in content/public/browser/appcache_service.h, and there are uses outside content/browser that needs updating, Convertion is still needed for AppCacheInfoCollection::infos_by_origin. Convertion is also needed for quota api(storage/browser/quota). Bug: 598424 Change-Id: I51e8f308a5c12ed61168f68c0f94f1a1bfb8f48a Reviewed-on: https://chromium-review.googlesource.com/977846Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
-
Dominic Battré authored
This reverts commit a5dfe3d8. Reason for revert: Fails on Mac builders (instead of crashing). Original change's description: > Update expectations for video-rotation.html to Failure Pass > > Because propriety codecs are not supported on some test > configurations, video-rotation.html is updated to be > Failure Pass instead of just Skipped, as it gives us better > code coverage. > > Bug: 750313 > Change-Id: Ia26c4cc0fdab21adb308b228a95c234577060af8 > Reviewed-on: https://chromium-review.googlesource.com/958262 > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545859} TBR=wez@chromium.org,ccameron@chromium.org,mlamouri@chromium.org,liberato@chromium.org,lethalantidote@chromium.org Change-Id: I2dd1a6ee472a215c7139510c0ec08f0aef1bd4fc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 750313 Reviewed-on: https://chromium-review.googlesource.com/980755Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#545871}
-
Daniel Bratell authored
Half the code used the SDK_VERSION_* constants when checking Android version, half the code used hard coded numbers 19, 21, 22, .... This changes the code to use SDK_VERSION_ everywhere. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.android:android_arm64_dbg_recipe;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icb4e3183f0490b00d16039681548ccf469e9d236 Reviewed-on: https://chromium-review.googlesource.com/975841 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#545870}
-
Eric Holk authored
In msan builds, V8 generates ARM code and runs it in a simulator. This means we cannot support trap handlers in that configuration. TBR=jam@chromium.org Bug: chromium:824645 Change-Id: If0971148262297d5688efd559a1526295a869e07 Reviewed-on: https://chromium-review.googlesource.com/979033Reviewed-by:
-
Theresa authored
Replace sending motion events to perform a long click with a direct call to View#performLongClick. Locally this fixes the weird blue highlighting after sending motion events. BUG=813589 Change-Id: I36ebfa69eedbd169bab2a1625963e14cf822b99b Reviewed-on: https://chromium-review.googlesource.com/976051Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#545868}
-
Rune Lillesveen authored
To prepare for immutable ComputedStyle objects. Bug: 813068 Change-Id: Id5b4a57940712adfc9d353634856bc32e4ef2a0d Reviewed-on: https://chromium-review.googlesource.com/979810Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#545867}
-
Andrew Grieve authored
* Fixes recently introduced -keep rule for @MainDex on methods: * <methods> works, whereas * sometimes doesn't * Teach jni_generator.py about @MainDex on methods * Removes @MainDex from browser-process-only AnimationFrameTimeHistogram * Removes @MainDex from browser-process-only MediaServerCrashListener * Adds a missing @MainDex needed to play <video> (SurfaceTexturePlatformWrapper, MediaCodecBridgeBuilder) * Outputs a new artifact from main_dex_list.py for seeing which classes are kept by ProGuard vs MainDexListBuilder * Adds assertions for a few classes that should not appear in the main dex. With this change, main dex method counts: chrome_public_apk=7623 chrome_apk=11333 monochrome_apk=22086 NOTRY=true # ios-simulator is unhappy. Bug: 820570 Change-Id: I4ea925ed985a0daa5a4db54a9cf72744fa92aeca Reviewed-on: https://chromium-review.googlesource.com/972641 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
-
Francois Doray authored
For correctness, set the TabStripModel of a TabLifeycleUnit to nullptr when it is detached. Bug: 775644 Change-Id: Icf7ad8d1be8c130ae934f74f2855eab40d21207d Reviewed-on: https://chromium-review.googlesource.com/980777 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#545865}
-
