- 01 Mar, 2019 40 commits
-
-
Xianzhu Wang authored
This avoids unnecessary visual rect recalculation when ancestor clip changes when we called SetSubtreeShouldCheckForPaintInvalidation() in the case. Bug: 927903 Change-Id: Id55440689e9208b2c7b9590a0c2b06e70ae78160 Reviewed-on: https://chromium-review.googlesource.com/c/1484150Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#636697}
-
Luciano Pacheco authored
These lines were submitted in CL:1490352. Reported the bug to lebab project: https://github.com/lebab/lebab/issues/287 Bug: 778674 Change-Id: I09b8b6acbde72f4e0af36c5dd4f8084ac3aef27c Reviewed-on: https://chromium-review.googlesource.com/c/1493638 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#636696}
-
Robert Ogden authored
This CL is 1 of 4 to move the DataSaver "Chrome saved you XX data" from a snackbar to an IPH. This CL moves the snackbar controller class to a class in preferences.datareduction and renames everything from "snackbar promo" to a more generic "milestone promo". All of the prefs and variation params were kept to allow the configurations we already have to keep working as is, although this does lead to some stale naming. UMA is removed in this CL, and will be re-added in the final CL. Bug: 878337 Change-Id: Ia7924cd741db2b6b37180d6fb93735636fbaf00d Reviewed-on: https://chromium-review.googlesource.com/c/1487196Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#636695}
-
Hector Carmona authored
Bug: 937030 Change-Id: I44721aafb7e778f8887411b7c46e3d786bccd59d Reviewed-on: https://chromium-review.googlesource.com/c/1496315Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#636694}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9950df105a7c..520d06f4107a git log 9950df105a7c..520d06f4107a --date=short --no-merges --format='%ad %ae %s' 2019-02-28 benjhayden@chromium.org Deserialize a new HistogramSet JSON format. Created with: gclient setdep -r src/third_party/catapult@520d06f4107a The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918208 TBR=sullivan@chromium.org Change-Id: I29d237008fffd8ea1706bcd5a80288ec285cbc36 Reviewed-on: https://chromium-review.googlesource.com/c/1496375Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636693}
-
Wei-Yin Chen (陳威尹) authored
Add a TabModelSelectorTabObserver for IPH_TabGroupsQuicklyComparePages and plumb SearchableFormURL to Java NavigationHandle. TBR=michaelbai@chromium.org Bug: 930970 Change-Id: I857d0119ebc7ffc0bdcf09373696d8970556815f Reviewed-on: https://chromium-review.googlesource.com/c/1492933 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#636692}
-
Dan Beam authored
Screenshots: https://imgur.com/a/qzkvIKH R=rbpotter@chromium.org BUG=923224 Change-Id: I4856655f42a88ccc7bf635b71b931f9a99aaea49 Reviewed-on: https://chromium-review.googlesource.com/c/1496099 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#636691}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5546fb4fdd85..ffa277a12fcd git log 5546fb4fdd85..ffa277a12fcd --date=short --no-merges --format='%ad %ae %s' 2019-03-01 brucedawson@chromium.org Fix logic for warningsAsErrors Created with: gclient setdep -r src/third_party/angle@ffa277a12fcd The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:920704 TBR=ynovikov@chromium.org Change-Id: Id2eb245e3b146c57194da9415eb4d867682f9a5a Reviewed-on: https://chromium-review.googlesource.com/c/1495779Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636690}
-
Victor Costan authored
https://crrev.com/c/1488952 changed the data collection logic for Sqlite.Stats, so it should have renamed the histogram. Bug: 935824 Change-Id: I2ef7cc7409afcdf7033e8f542b0cd57c4a9a8ab4 Reviewed-on: https://chromium-review.googlesource.com/c/1492780 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#636689}
-
Julie Jeongeun Kim authored
This CL moves unhandled_tap_notifier.mojom, site_engagement.mojom, ukm.mojom and reporting.mojom in public/platform to public/mojom. Bug: 919393 Change-Id: I430cc84b586bf989ed201cbe78f4b72fd2765cda Reviewed-on: https://chromium-review.googlesource.com/c/1485694 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#636688}
-
Chris Hall authored
BUG=889370 R=dmazzoni,aboxhall Change-Id: Icdd7604a497530503864f61a30a85e6f3a3ac75b Reviewed-on: https://chromium-review.googlesource.com/c/1493633 Auto-Submit: Chris Hall <chrishall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#636687}
-
Sunny Sachanandani authored
Use selenium so that it's easy to run the script on different browsers such as Edge. As a result add support for fullscreen video by double clicking on the video element which works for common sites. Bug: 848093 Change-Id: Iacf0b7bca2c7a162643e2bb08deb8638b297c121 Reviewed-on: https://chromium-review.googlesource.com/c/1487452 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#636686}
-
Yusuf Ozuysal authored
This moves away from a constant margin at top to read values from the fullscreen manager. This way we fix Duet+Grid and also leave any other users of TabList on their own to set the margins as needed. (The strip mode for example won't use any margins at all). BUG=934070 Change-Id: I810ced611eb0358757ed0f706f1c67a845b669f2 Reviewed-on: https://chromium-review.googlesource.com/c/1496436Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#636685}
-
Nicholas Hollingum authored
Due to the way that the crostini terminal works, the shelf_id was being overwritten because it was: - On a technicality being "DidFinishNavigation"'d when it loads. - Assumed to be a browser window (because we run crosh in a window) - Failed to be associated with an extension (because crostini isn't) - Failed to be associated with an app app_id - Therefore: defaulted to the browser's shelf id. This fix catches the special case for crostini apps, which is to set the app_name of the browser on creation. We also propose a unit test to maintain this behaviour. Note that all of these measures are temporary, pending a better implementation of the crostini terminal. Bug: 839676 Change-Id: I46a43960cbc3820968fbb9872c142923d753039e Reviewed-on: https://chromium-review.googlesource.com/c/1491876Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#636684}
-
Aga Wronska authored
Define two PIN keyboard styles and update view layout accordingly: * Alphanumeric Keys display digit and a part of the alphabet below. This is the exact style of existing LoginPinView. * Numeric Keys only display digit, therefore keys height is different. This is the new style. Use Alphanumeric PIN style for login PIN input and Numeric PIN style for parent access code input. Bug: 911326 Test: LoginPinViewTest Change-Id: Id164d8580cd64db6891348b5de4638be52ab5c0d Reviewed-on: https://chromium-review.googlesource.com/c/1483675Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#636683}
-
chrome://flagsTim Song authored
BUG=921250 Change-Id: I09ebc0d4d3acc931d5d3ad28152f5040c83bfca6 Reviewed-on: https://chromium-review.googlesource.com/c/1492834 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#636682}
-
Rachel Wong authored
This is because we should retrieve the oldest requests from the end of the queue. Bug: 916420 Change-Id: I0232eb73d2c922297833a93adb22da39c91047e2 Reviewed-on: https://chromium-review.googlesource.com/c/1493339Reviewed-by:
Michael Martis <martis@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#636681}
-
Tao Bai authored
- Moves the session related code to TaskSession. - TaskSession categorizes the captured content and the detached nodes into DocumentSession. - ContentCaptureTask uses the DocumentSession to send the data though the LocalFrame's WebContentCaptureClient. Bug: 924681 Change-Id: I8cd5c96c1ab183e7a567a70fef813881c8b2ab4a Reviewed-on: https://chromium-review.googlesource.com/c/1493400Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#636680}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fe5a160336aa..5c212bf59cf6 Created with: gclient setdep -r src-internal@5c212bf59cf6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I624bcbc47c0c4660f22acf34d45afb1de4f05d6a Reviewed-on: https://chromium-review.googlesource.com/c/1495778Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636679}
-
Keishi Hattori authored
The code calculated the deltas with uint64_t, causing negative values to be reported incorrectly. This CL fixes the subtraction. And also clamps the samples to 1000 buckets (-500MB to 500MB). Bug: 917293 Change-Id: Ie2b48ddbf1a47577692c4c2013c7a9d365c786ea Reviewed-on: https://chromium-review.googlesource.com/c/1488475Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#636678}
-
Christian Biesinger authored
R=eae@chromium.org Change-Id: Iedcf3f24205beea7a0de08f0544f745eb434404f Reviewed-on: https://chromium-review.googlesource.com/c/1496439 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#636677}
-
Dan Beam authored
Screenshots: https://imgur.com/a/EwqTzly R=hcarmona@chromium.org BUG=936524 Change-Id: I5ed3a43dc4273c1179eddca56a8138cf394c10a6 Reviewed-on: https://chromium-review.googlesource.com/c/1496246Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#636676}
-
Fergus Dall authored
Currently, starting up crostini apps while switching profiles causes two issues. First, windows other then the terminal are owned by whichever profile is active when they become visible, not the profile that owns crostini. Second, if a window becomes visible while it's owning profile is inactive, then its icon will still be added to the shelf. On switching to the correct profile, the icon is added again. If the app is then closed, only one of these shelf entries is removed, causing crash if the other is used. As we don't currently support using crostini from non-primary profiles, this CL fixes the first issue by associating all crostini app windows with the primary profile, and prevents app icons from being added to the shelf unless the primary profile is active. Bug: 846213, 896996, 909590 Change-Id: Ibc888d22eb9567d822ce3e7d1af3603afb02a98e Reviewed-on: https://chromium-review.googlesource.com/c/1491873Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#636675}
-
Miyoung Shin authored
Add a PRESUBMIT check to ensure new |unsigned short| use don't come in. Bug: 929986 Change-Id: Ib4031362495ceedd94bc7e33fcbb913aea1e6ee2 Reviewed-on: https://chromium-review.googlesource.com/c/1493642Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#636674}
-
Stephen McGruer authored
Before this CL, we always treated endScrollOffset as inclusive, against the spec. The spec was recently updated to treat endScrollOffset as inclusive but only when it is equal to max-offset: https://github.com/WICG/scroll-animations/pull/37 Bug: 934989 Change-Id: I7cd9cf4619e804a54cef33ef8d3ec7395166bace Reviewed-on: https://chromium-review.googlesource.com/c/1483682 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#636673}
-
Eric Karl authored
We've found visual corruption on this GPU / driver combination. Blacklisting very restrictively for now. If we find this issue in future drivers we can change the blacklist to >=. Bug: 890688 Change-Id: I996fb8b9c7f83230aa9cd0f5fd39038d3f686eb2 Reviewed-on: https://chromium-review.googlesource.com/c/1496536 Commit-Queue: Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#636672}
-
Marijn Kruisselbrink authored
Bug: 937069 Change-Id: Ic00c4ea761b16c685ca200df03e0c856765d450f Reviewed-on: https://chromium-review.googlesource.com/c/1496276Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#636671}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b2565b18d03e..906430d4b40c git log b2565b18d03e..906430d4b40c --date=short --no-merges --format='%ad %ae %s' 2019-02-28 csmartdalton@google.com Make GrMesh compatible with instanced draws that have no attribs 2019-02-28 reed@google.com Move responsibility to onMakeContext for device colorspace decision 2019-02-28 kjlubick@google.com [canvaskit] Add support for external fonts 2019-02-28 csmartdalton@google.com Revert "Drop unused shader support for sample variables" 2019-02-28 brianosman@google.com Particles: Removed emitters, added more full-featured position affectors 2019-02-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader c6eb41bebc27..a1924739029e (2 commits) 2019-02-28 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader bc63cf9c511b..c6eb41bebc27 (3 commits) 2019-02-28 jvanverth@google.com Fix a couple of Mac windowing issues. 2019-02-28 bsalomon@google.com Remove support for SkDeferredDisplayListRecorder::DelayReleaseCallback::kNo. 2019-02-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 201f136c9907..bc63cf9c511b (1 commits) 2019-02-28 thakis@chromium.org skia: Fix -Wextra-semi warnings in non-dcheck builds. 2019-02-28 michaelludwig@google.com Reland "Add general quad API to SkGpuDevice" 2019-02-28 brianosman@google.com Fix scaling error in SkLights::makeColorSpace 2019-02-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 61d99852..1dc32aec (2053 commits) 2019-02-28 benjaminwagner@google.com Remove OS condition from isolate files 2019-02-28 kjlubick@google.com [canvaskit][pathkit] Remove flaky/low-utility Debug tests Created with: gclient setdep -r src/third_party/skia@906430d4b40c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:926235 TBR=scroggo@chromium.org Change-Id: I2a0c17a6302d2c30f78292305307e689af7541d0 Reviewed-on: https://chromium-review.googlesource.com/c/1495896Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636670}
-
Ryan Hansberry authored
Bug: 935683 Change-Id: Ie8c77f6a896810eb8e04032857570dd449dce02e Reviewed-on: https://chromium-review.googlesource.com/c/1490952Reviewed-by:
Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#636669}
-
Kelvin Jiang authored
Summary of changes: - Move the clear activities button under the history/stream tabs - Add extension name and icon to activity log page - Add headings above activity log items Refactoring of styles may be done in a follow up CL Screenshots included in: https://bugs.chromium.org/p/chromium/issues/detail?id=932768#c5 Bug: 932768 Change-Id: I249cee13e1b5c7e4bd319b5b788a0c05718ba8da Reviewed-on: https://chromium-review.googlesource.com/c/1483738Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#636668}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/96fc7ac1..16c76cb9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie7c9ac6c88ad2abc84a83c97f8666563c79bc8b1 Reviewed-on: https://chromium-review.googlesource.com/c/1496247Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636667}
-
Krishna Govind authored
R=cmasso@chromium.org Change-Id: I2e90056db5b017b34eeba901904371854bd41ff4 Reviewed-on: https://chromium-review.googlesource.com/c/1496241Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#636666}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5117888302cf..a6d41e2396bd git log 5117888302cf..a6d41e2396bd --date=short --no-merges --format='%ad %ae %s' 2019-03-01 vadimsh@chromium.org [cipd] Update to 2.2.18. Created with: gclient setdep -r src/third_party/depot_tools@a6d41e2396bd The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:936911 TBR=agable@chromium.org Change-Id: Ib0ef96a5be975415f0ced01df4bae638f4d815d9 Reviewed-on: https://chromium-review.googlesource.com/c/1496161Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636665}
-
Charlie Andrews authored
The story is already disabled on other version of system health and is causing the shard to hang indefinitely. NOTRY=true TBR=crouleau@chromium.org CC=perezju@chromium.org Bug: 934270 Change-Id: Ia5b6328fa1311009cb8da0c6267a3585df5ad46b Reviewed-on: https://chromium-review.googlesource.com/c/1496540Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#636664}
-
Karan Bhatia authored
RulesetMatcher is a class in the extensions layer but it is unit-tested at the chrome layer. Fix this by moving the tests to the extensions layer by removing dependencies to chrome's extension loading code. This also means we don't check the extension loading in these tests, but that is taken care of in the browser tests. BUG=930961 Change-Id: Ic971bce981a65cda8928a8e3d9e3b49f960b4aef Reviewed-on: https://chromium-review.googlesource.com/c/1496314Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#636663}
-
Robert Liao authored
This is a mechanical execution of tools/git/mass-rename.py. BUG=937018 Change-Id: Idf6f45d4507106e17137c577496e909b3aafc765 Reviewed-on: https://chromium-review.googlesource.com/c/1496234Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#636662}
-
Julie Jeongeun Kim authored
This CL moves web_feature.mojom in public/platform to public/mojom/web_feature and updates paths for web_feature.mojom. It also moves PRESUBMIT.py for web_feature.mojom to public/mojom/web_feature. Bug: 919393 Change-Id: I1d22645fdd081a81bf18a85511d208c2e7b0bf7a Reviewed-on: https://chromium-review.googlesource.com/c/1488487 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#636661}
-
Yutaka Hirano authored
Remove FetchContext::DidLoadResource and move the operations in it to DispatchDidFinishLoading and DispatchDidFail. This leads to code duplication but I think this change is overall a good change because: - DidLoadResource is called only twice. Repeating yourself twice is not that bad. - DidLoadResource is confusing; Whether that precedes or succeeds DispatchDidFinishLoading, whether it should be called in DispatchDidFail, etc. Previously FetchContext::DispatchDidFinishLoading and DispatchDidFail were called before Resource::Finish, but now they are called after Resource::Finish. That affected a few devtools tests because some tests finished as soon as resource loading finishes and some error messages got missing with the new semantics. This CL delays test completion a bit in order to keep the expectations. Bug: 914739 Change-Id: I5245dca240ebc7496d1de51909d458a6ed5a61d2 Reviewed-on: https://chromium-review.googlesource.com/c/1474887 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#636660}
-
Gyuyoung Kim authored
According to the plan to replace |const LocalFrame*| arguement with |const Document&|, |ExecutionContext*|, or |DocumentLoader*| in UseCounter::Count(), this CL replaces all uses of UseCounter::Count(const LocalFrame*) with UseCounter::Count(const Document&) in frame directory. Bug: 936187 Change-Id: I41f03b9908258881d4a1d932defb7e42e2deae9a Reviewed-on: https://chromium-review.googlesource.com/c/1491060Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#636659}
-
Anne Lim authored
Adds and removes strikes under the following conditions: User closes LocalCardMigrationDialog: Add 3 strikes User closes LocalCardMigrationBubble: Add 2 strikes User adds new local card: Remove up to 2 strikes (keep strike count > 0) User de-selected some local cards during migration: Add 3 strikes And don't offer local card migration if strike limit has been reached. Bug: 884817 Change-Id: I9853e2b5d1a1692fd47650aa6598f4d6df27a27c Reviewed-on: https://chromium-review.googlesource.com/c/1474689Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#636658}
-