- 14 Jan, 2021 40 commits
-
-
Antia Puentes authored
This CL migrates the legacy IPC message out of extension_messages.h to Renderer mojo interface from extensions.mojom. Bug: 1165812 Change-Id: Id53cdd68da19509682067a067ff544ff04128c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627410Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Antia Puentes <apuentes@igalia.com> Cr-Commit-Position: refs/heads/master@{#843443}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610582310-1de40dcfb71a8181da946117c9e834cf9a0c7d77.profdata to chrome-mac-master-1610603782-b98b7b7ae127903b90c7f2c46875a9e8f16b9cec.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib28e160c363ea83599ac16897735172b41a6947b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628853Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843442}
-
Colin Blundell authored
This CL separates separates the mechanism via which SafeBrowsingPrimaryAccountTokenFetcher fetches access tokens and the mechanisms via which it tracks and responds to ongoing token fetches, moving the latter into a new SafeBrowsingTokenFetchTracker helper class for reuse by WebLayer. This class includes the following: - Tracking of ongoing access token fetch requests coming from the client of SafeBrowsingTokenFetcher, responding to these requests when notified that a given access token has been fetched, and gating these requests on a given time threshold (responding with an empty access token if a request times out) - Responding to all active token requests with an empty access token on destruction This CL also adds unittests of SafeBrowsingTokenFetchTracker. Via this helper class, WebLayer will be able to share the key functionality of gating safe browsing access token fetches on a timeout rather than duplicating this functionality and risking divergence over time. The only subtlety is the behavior on token fetch timeout: SafeBrowsingPrimaryAccountTokenFetcher needs to be notified in addition to its client so that the former can destroy the corresponding AccessTokenFetcher. To facilitate this, SafeBrowsingTokenFetchTracker::StartTrackingTokenFetch() takes in both the SafeBrowsingTokenFetcher::Callback that the client passed in and a callback to be invoked on timeout, via which its owner can clean up any state associated with the request. Bug: 1080748 Change-Id: I79bb83096cc2094c7cf9916eccf382271a5f46a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624630 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843441}
-
Ulan Degenbaev authored
Intent to ship: http://bit.ly/memory-i2s Bug: 1085129,1048745 Change-Id: I4391fae4374c5bd1b126d996cebd6c63adb30407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624547Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843440}
-
Jordan Demeulenaere authored
This CL fixes the placeholder animation which was not correctly supporting multiple details. Now, all details with placeholders subscribe to the placeholder animation, which is stopped each time we change the details. This CL also fixes the wrong type of ShowDetailsProto.delay_ms, which should be an int32 and not a bool. Bug: b/174652960 Change-Id: Ib37479337bfc732d57c2b60ff168c28444e2575f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625885 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Auto-Submit: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#843439}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8a9d4fceede9..8a42f3312f5e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yutak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yutak@google.com Change-Id: I86621c453a15ad169158b32ef0453fd30ab2458d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628693Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843438}
-
Kenichi Ishibashi authored
The method previously used a template function but the template function was used only from the method. Merge them so that stack traces are easy to analyze for crashes which contain the method. Note that this CL doesn't address the crash. Bug: 1161800 Change-Id: I59898a39b880b6c31e84f96878f898c57f9eefdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626992Reviewed-by:
Asami Doi <asamidoi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#843437}
-
rbpotter authored
These are no longer needed since cloud print deprecation is already ocurring on the server side. Handle only privet related deprecation flag in Print Preview. Bug: 1144931 Change-Id: I6ff77f87fda23d33e25f49d6310e41757a3be530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618682 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#843436}
-
Abhijeet Kandalkar authored
Send wayland request only if WindowState changes otherwise it 1. triggers IPC between server & client for a state management 2. calls the wl_display_flush. It is observed that during an initial launch of lacros-browser `maximize` request is sent twice from DesktopWindowTreeHostPlatform adding IPC overhead. This change will also handle minimize, fullscreen and restore operations. Bug: 1138978 Change-Id: Ia532c14ec0fa51f2a9e1e4093a0ded17e2610415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626945Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#843435}
-
Daniel Hosseinian authored
The displayed dates and times are localized. Bug: 93619 Change-Id: I116faa499866a828f53142237983bba6645508a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610627 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#843434}
-
Rushan Suleymanov authored
This CL implements DeviceInfoClient interface for iOS platform when invalidations are enabled. Bug: 1102314 Change-Id: I19f6afaa256d127e2d8869123b632088f648c32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605557 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#843433}
-
Joe Mason authored
Currently all unassociated bytes are lumped together into one counter. There are actually two types of unassociated bytes: - bytes of detached V8 contexts (i.e. contexts not attached to the frame tree. - bytes shared between all V8 contexts. Besides splitting the bytes, this CL also adds the corresponding memory types and reports them in the web memory API. Based on this patch by ulan@chromium.org: https://chromium-review.googlesource.com/c/chromium/src/+/2626662 Bug: 1085129 Change-Id: I0097e3b1728f5cbfe72746f0a1fd804215487237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626978 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#843432}
-
rajendrant authored
This is a reland of fd90951e Original change's description: > Move subresource_redirect proto to components > > Moves the robots_rules.proto from chrome/renderer to components/ > > Bug: 1160424 > Change-Id: I0b2af266e3a6de40872bf094195b7f0c21c42096 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623647 > Commit-Queue: rajendrant <rajendrant@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842827} TBR: mcrouse@chromium.org Bug: 1160424 Change-Id: I8ec0a859cdfe204c5216ea1ee23c721352919e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628742Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#843431}
-
Kenichi Ishibashi authored
The core thread is always the UI thread now. Bug: 1138155 Change-Id: Iefda8c1a33303f1ce39d1513f91a36b014d40057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628268Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#843430}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610582310-441e5d44b17635eb24bffd5edcdc41a0f840e530.profdata to chrome-linux-master-1610603782-a901bed343e038af516adf3da71b37fc556670e5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I882d48dc698f1f85a791e0003f9b960991e02e1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625754Reviewed-by:
-
Victor Costan authored
Bug: 1016065 Change-Id: I25f113d45ee642759555b7b08d0f24fc38c0f917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628068 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#843428}
-
Michael Bai authored
Bug: 1151542 Change-Id: I25545f36d588ca926ce1de9514ae919f3f441a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628040 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#843427}
-
Aya ElAttar authored
- Migrated ValidateCompletionCallback & OwnershipStatusCallback from base::Callback to base::OnceCallback as they are only run once. - Moved the callbacks instead of const passing them using constant references. Bug: 714018 Change-Id: I1a92f95c8bd7cf373bd8cdc4d1fc79dd118855af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627156Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#843426}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1169b2e38c9b..b0279c680047 2021-01-14 bmeurer@chromium.org [e2e] Rebaseline test expectations after Chromium roll. 2021-01-14 annabelzhou@google.com Add AccessibilityNode web component and display non-interactive tree If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1165304,chromium:887173 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I313b628d46faddb91eb221bdd1032d1317877fb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628840Reviewed-by:
-
Glen Robertson authored
Sometimes WebAppMetrics is still holding a foreground_web_contents on shutdown, and thus fails to deregister itself as an observer of the associated AppBannerManager, which is already gone. This change adds extra checks to try to prevent getting into this state, and dumps crash reports if in an unexpected state. Bug: 1162123 Change-Id: I142e6cc30395decf7a09ca2c6773de8c65865535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620919 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#843424}
-
Nicholas Verne authored
Added "devlopment environment" to some uses. Fixed: 1166405 Change-Id: I11871d1bf709a4176cbffbcf0a8635e1269c64bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626725 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#843423}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/af9b58e287b5..f435ada424df 2021-01-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 424fd828893e to 6f833b7f78c9 (17 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Change-Id: I4d92af8f66f607a07a80df87cb12e3747200a4d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628585Reviewed-by:
-
rajendrant authored
Bug: 1166280 Change-Id: I9ce5d95e5d0eb68d20753ab2832e78f6af30f874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628187 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#843421}
-
Hirokazu Honda authored
The hardware video decoder outputs color artifacts with av1 10bits streams. We deny av1 10bits so that software decoders are instead used for them. Bug: b:174722425 Test: No artifacts with 10 bits streams (i.e. software decoders are used) on volteer Change-Id: I0280d9e2206366761ca670b123f90e49752d8448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616642 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#843420}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2cc3490759bb..5255c465bbba 2021-01-14 swiftshader.regress@gmail.com Regres: Update test lists @ 2cc34907 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I689225190034a60e229714eb95eeeac5f9a63dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627630Reviewed-by:
-
Rushan Suleymanov authored
Extended histograms: * Sync.BookmarkGUIDSource2 * Sync.DuplicateBookmarkEntityOnRemoteUpdateCondition * Sync.LocalSyncTransportDataStartupState Bug: 1156209, 1153772 Change-Id: If2af4a95d1ab4cece1924362f006416250e99099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627275Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#843418}
-
Eric Willigers authored
We add a browser test that writes to the socket using script. Bug: 905818 Change-Id: Ica84ba877eab844d3f9ae0b4cb76fe18b0046b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624371 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#843417}
-
Jiewei Qian authored
Fix typo in WaylandToplevelWindow::HandleSurfaceConfigure(), widht -> width. Change-Id: Ice9cb872ee721461c5fb5eb24466d3a3d07b4ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628632 Commit-Queue: Jiewei Qian <qjw@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Auto-Submit: Jiewei Qian <qjw@chromium.org> Reviewed-by:
-
Harvey Yang authored
BUG=b:168434557 TEST=unit tests Change-Id: I896495d19cc5c8ebdc3a696e537b18302644d389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624128 Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#843415}
-
Philipp Hancke authored
assert they do not throw and reject all the but first m=-line BUG=799030 Change-Id: I4242eaacc7ae039a32643034eca535acf6cd1f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627321Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#843414}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/da4de1dd41b6..8a9d4fceede9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yutak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yutak@google.com Change-Id: I29f116a1b78d037d13988e15f7d4bdf2a03b7854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628584Reviewed-by:
-
Sammie Quon authored
This reverts commit 11748b2a. Reason for revert: Breaks chromeos-kevin-chrome bot Original change's description: > Add a new Android.ArmCpuPart UMA. > > This will record the ARM CPU's implementer and part number values. > > Bug: 1164549 > Change-Id: I09ea0d852fda6b05c50a16b64bfcde6f4f5f62b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615326 > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843243} TBR=dcheng@chromium.org,thakis@chromium.org,jwd@chromium.org,agrieve@chromium.org,rsesek@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I20c9ea46a720a62d76c72d449ee0d6b31de598f8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1164549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626321Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#843412}
-
rajendrant authored
This is a reland of eacc052e Original change's description: > Add browser test for canceled image request > > When image request is cancelled the robots rules request should be > invalidated correctly. This CL adds a test. > > This CL also creates component for subresource_redirect and moves some > utility functions there. Subsequent CLs could move more independent code > out of chrome/renderer/subresource_redirect to the component. > > Bug: 1160424 > Change-Id: I29b20fe4f7057a1e8778995ea5e1114e36843da8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619421 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Commit-Queue: rajendrant <rajendrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842806} TBR: sky@chromium.org,mcrouse@chromium.org Bug: 1160424 Change-Id: I4c9563032812fc2e843df1a96ccea91550a01e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628650Reviewed-by:
-
Regan Hsu authored
Fixed and ran 100 times with the failing gn args, and they pass. Re-enables the browser test. Fixed: 1146224 Change-Id: I6e53f6c0e6fa0d97dd527a0e16c6ee508c91ed43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628503 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Asami Doi authored
This CL enables a nested blob URL worker to inherit the active service worker from the parent worker host. `creator_worker_token` has the parent worker token when the worker is nested, and the child worker can access the parent's service worker via the parent worker host. Bug: 1017034 Change-Id: If28169fa5cedac158c220d7a5f16c7874e733a3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614526Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#843409}
-
Hirokazu Honda authored
If VaapiWrapper continues executing SubmitBuffer() even after the previous SubmitBuffer() fails, VABuffers stored in a pending list will be submitted to a driver by vaRenderPicture(). Some of the submitted buffers might not be related to the current processing and therefore the processing will fails. We assume VaapiWrapper client stops using the VaapiWrapper and destroys it if SubmitBuffer() fails. Although this should be true, this CL makes sure that the pended VABuffers are not used for the next processing by destroying them within SubmitBuffer_Locked() on failure. Bug: b:175897723 Test: vaapi_wrapper_unittest Change-Id: I24eaa5f94a00f69d18c2a2f1bda707e4ccb21c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612292 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5135af05fe14..1169b2e38c9b 2021-01-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibfd2e927e9575abe7ee0dbfd424b7a6a451a80f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627819Reviewed-by:
-
Oriol Brufau authored
CompositeEditCommand::MoveParagraphs has a start and end positions, and constrains them with Most{Forward,Backward}CaretPosition. The problem was that the resulting positions could end up reversed, triggering a CHECK failure in CreateMarkup. This patch changes CompositeEditCommand::MoveParagraphs so that it only attempts to contrain the positions if they are different, and also changes MostBackwardOrForwardCaretPosition to ensure that the shadow- adjusted candidate is not further from the initial position than the non-adjusted candidate. Bug: 1165325 TEST=CompositeEditCommandTest.MoveParagraphContentsToNewBlockWithUAShadowDOM TEST=SelectionAdjusterTest.AdjustSelectionTypeWithShadow TEST=VisibleSelectionTest.ShadowCrossing TEST=VisibleSelectionTest.ShadowNested Change-Id: Ib52ed472809e15aa551fdfc4ed1fa2323433d4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627368 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843406}
-
Joe DeBlasio authored
This CL updates Chrome to use a newer variant of the report proto. It does not change any logic in Chrome otherwise. In particular, the updated proto supports submitting SCTs for multiple certificates at once. This CL does not change Chrome logic to aggregate across reports. As a result, every report has exactly one certificate report in it. Bug: b/175493719 Change-Id: I3586998f04846509a589b7f09fa65fe949a8e4ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588811Reviewed-by:
Chris Thompson <cthomp@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#843405}
-
Yoshifumi Inoue authored
This patch changes |LayoutBlock::PositionForBox()| to return null position if |LayoutBlock| is anonymous for avoiding call |Position::FirstPositionInOrBeforeNode()| with null position. Note: |LayoutBlock::PositionForBox()| is used only for legacy layout. Note: I don't have the test case to reproduce because ClusterFuzz's test case is too huge (large than 1MB) to reduce. Bug: 1157993 Change-Id: Ief106d22bb6c29620182fbb9a4f5fe84919879c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626820 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843404}
-
