- 17 Aug, 2020 40 commits
-
-
Eric Robinson authored
We had previously found it beneficial to record CPU metrics for a frame only when it was in the foreground because we were concerned with the percent of CPU usage by the frame at it's more impactful time (frames in the background have their task queues slowed/stopped). However, we now instead use a metric that measures the peak windowed usage rather than the percentage of usage overall, so it's no longer critical to distinguish between foreground/background times. In addition, not measuring while in the background leads to us missing potential spiking CPU usage of frames there. This CL removes the foreground/background distinction, ensuring our metrics are recorded for the total time of the frame independent of its background status. Note: This change will affect heavy ad intervention behavior. This is desirable, as ignoring work that an ad does in the background is a potential way to circumvent this intervention, and most frames, while backgrounded, should be doing less anyway. Bug: 1103699 Change-Id: If34be823bb5501574df0f4142db284e6499151e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310130 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#798855}
-
Sven Zheng authored
In order to get interactive_ui_tests run on CI/CQ, we need to disable failing tests first, then run them. Bug: 1111979 Change-Id: If90cf564f5647189b2154ebfbdc2ad6ff570e473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360321Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#798854}
-
Thomas Anderson authored
This reverts commit 30d9990c. Reason for revert: Suspected cause of build failure on ilder Deterministic Linux (dbg) Build 18293: https://ci.chromium.org/p/chromium/builders/ci/Deterministic%20Linux%20%28dbg%29/18293?blamelist=1#blamelist-tab Checking libblink_common.so difference: (10672 deps) obj/third_party/blink/common/common/document_policy_features.o Original change's description: > Add bool constructor with type for PolicyValue > > Previously, boolean PolicyValue is missing a constructor with type > specification on PolicyValue class. It caused some inconvenience > on code generation and testing. With the introduction of enum > PolicyValue, this becomes more obvious because enum type's constructor > also comes with a type parameter. > > In order to simplify the codegen and testing logic, this CL adds a dummy > constructor for boolean type PolicyValue. > > Note: the constructor with type parameter aims to distinguish policy > values that have same C++ type representation but different policy value > type, e.g. IncDouble and DecDouble, Enum and Int. > > Change-Id: I11ba793c73a770d7211e21c6a94d29f5557ac284 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347365 > Commit-Queue: Charlie Hu <chenleihu@google.com> > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > Reviewed-by: Ian Clelland <iclelland@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798714} TBR=iclelland@chromium.org,foolip@chromium.org,chenleihu@google.com Change-Id: I79f53710b14f22a7c81b4c757cbee03160c6addb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360796Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#798853}
-
Yuheng Huang authored
Since WebContentsImpl::DidStartLoading/DidStopLoading is already sending NotifyNavigationStateChanged(INVALIDATE_TYPE_LOAD) by way of LoadingStateChanged, it's no longer necessary to send this out in WebContentsImpl::LoadStateChanged. This change can reduce the number of call of TabStripModelObserver.TabChangedAt with TabChangeType.kAll a lot to increase performance throughout the browser Bug: 1112496 Change-Id: I96d8942d7e1ebd5ffc8b3f3389497936f62848c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357960 Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#798852}
-
Mohamed Heikal authored
These should be the only remaining instances of R.java generated by an android_resources target instead of the android_library target (in src/ there are others in other repos). TBR=What should just be a mechanical change. Bug: 1073476 Change-Id: Ia61ff2985a7db20f11a546bb76194bd796aec00e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357636 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#798851}
-
Owen Min authored
Create the provider and link it to the PolicyConnector. Also make few changes in the Loader class: 1) It no longer inherits from ASyncPolicyLoader as the loader process is sync. 2) Add few debug information in case the JSON input is not valid. The provider is not disabled globally. There will be one last CL to enable the provider on Android. Bug: 1113792 Change-Id: Id32ec74ebfa259777f718bf06b7a4cb307498f2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355134Reviewed-by:
Yann Dago <ydago@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#798850}
-
Fred Mello authored
https://docs.google.com/document/d/108ekdmEDMwpGDQLRnWGZBcq1cxsyPQLXuFl4oj6OIfw Bug: 1112872 Change-Id: Ic92d02154f4a01c5f72a65e1585f4558b84436ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360569 Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#798849}
-
Maks Orlovich authored
Eviction.*: kept as lower traffic, and we just fixed a major issue with eviction heuristics metrics DiskOpenStream2TinyLatency, DiskOpenStream2NonTinyLatency: removed, not interestng with CodeCache being a thing other Disk*Latency: kept, important performance metrics. pretty heavy, though. (Why is there a regression in July?) indicates unusual case HeaderSize: kept as there are deep assumptions on magnitude of this EntryOpenedAndStream2Removed: removed, not very interesting EntryCreationTime: kept, really important for performance EntryCreationResult: removed, can use comparable Disk*Result CreationToIndex: kept, highly relevant for CacheStorage. CheckCRCResult: stream reading state is interesting FileDescriptorLimiterAction: keep, low traffic and Fixed: 1089899, 1089898, 1089897 Fixed: 1089908, 1089907, 1089906 Fixed: 1089911, 1089910, 1089909 Fixed: 1089920, 1089919, 1089918 Fixed: 1089917, 1089916, 1089915 Fixed: 1089519 Change-Id: I6bf6c3a0d037a85afd8ee7cbc7810f1f4f00b615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359556Reviewed-by:Ben Kelly <wanderview@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#798848}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a866c351. With Chromium commits locally applied on WPT: 22d98b41 "Make canvas-createImageBitmap-e_srgb.html run cross-browser" 07bc7b3c "[WPT] Refactor WebBluetooth tests to use test-only-api.js" d2294de0 "Do not create a stacking context for CSS clip" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I9bfd8e8bce32f8a8ab6cec32e9b40e7f8038cfbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358588Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798847}
-
Justin DeWitt authored
This contains information required for new Java 8 desugaring features. The reland was fixed in patchset 2: adding a special case not to check bytecode for this new jar. Tbr: wnwen@chromium.org, agrieve@chromium.org, yfriedman@chromium.org Bug: 105675 Change-Id: Idd381efe4fc017944d3be33a01d5ec9c47b72420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359153 Auto-Submit: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
Change-Id: I1286e8e96bd77b27f6d78d36db7e079972e97fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360120 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#798845}
-
Greg Thompson authored
mini_installer.exe requires a temporary directory in which to write files during processing. Historically, this has been a directory under %TMP%. While mini_installer does its level best to delete this directory before terminating, it cannot always do so (e.g., third-party software may have some files open, or the machine may lose power). mini_installer.exe scans %TMP% at process startup to delete any stale directories from previous runs to prevent unbounded accumulation said directories. In this CL, mini_installer.exe now creates its work directory in the directory containing the executable itself. In the case of installations driven by a variant of Omaha (e.g., Google Chrome), Omaha will eventually clean any files/directories left behind. This CL also results in successful runs sending up either 0x10000 or 0x20000 in ExtraCode1 based on whether or not the fallback to %TMP% was used. This will inform us as to whether or not it's safe to remove that fallback. A note to the authors of other Chromium forks: this change in behavior may impact you. Audit how your variant of mini_installer.exe is run and ensure that any files or directories left in the same directory as it are cleaned up. BUG=516207,1100280 Change-Id: I7a8dd7981b26dbac10553747cfe32a40fb11f37b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351989Reviewed-by:
S. Ganesh <ganesh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#798844}
-
Xianzhu Wang authored
We have enabled transformed rasterization for most layers including composited scrolling contents, which also enables LCD text when possible, so using composited scrolling for transformed layers won't lose LCD text in most cases. Bug: 1095156 Change-Id: I8eef7b7d69edf55aa33e3428a44e5199872af7d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360224Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798843}
-
Joey Arhar authored
Bug: 1114160 Change-Id: I8fea8df370aff14aae81f1bb23f2e4f1a4ececbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354600Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#798842}
-
Siyu An authored
This reverts commit 9183784e. Reason for revert: Per crbug.com/1116874, there is crash in GetOfferDataRequest::RespondToDelegate. Will revert to unblock branch cut and investigate later. Original change's description: > Create AutofillOfferManagerFactory and implement GetOfferDataRequest. > > This change further implements the functionality of AutofillOfferManager. AutofillManager now accesses a singleton AutofillOfferManager via the AutofillOfferManagerFactory. AutofillOfferManager then prepares a request which is sent to the PaymentsClient to retrieve offer data. In further CLs, the data retrieved during these calls will stored and used. > > Change-Id: I384c95f26b9b3094d9b3387d467134ef5998396e > Bug: 1093057 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258154 > Commit-Queue: Ben Blake <fiorito@google.com> > Reviewed-by: Anne Lim <annelim@google.com> > Reviewed-by: Dominic Battré <battre@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Jared Saul <jsaul@google.com> > Reviewed-by: Siyu An <siyua@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798344} TBR=battre@chromium.org,vasilii@chromium.org,jsaul@google.com,siyua@chromium.org,annelim@google.com,fiorito@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1093057 Change-Id: Id441c93ff6b4ac888cfd9e7245e78859448a923b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360334Reviewed-by:
Siyu An <siyua@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#798841}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f926b0866fe4..d2a9f6661597 2020-08-17 aninditaghosh@google.com Add public docs for TP Python API 2020-08-17 lalitm@google.com Merge "trace_processor: Skipping an android log message is info not error" 2020-08-17 fmayer@google.com Strip in update_[traceconv|trace_processor]. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:163311671 Tbr: perfetto-bugs@google.com Change-Id: If9e7da732efc8ce7f33d7684e8d33a58e4a29691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360265Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798840}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/78fa1f578a2c..25f6caceffe6 2020-08-17 joselea@microsoft.com Responding to community feedback. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1076112 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I776b39d4612d334f13ba5d3e68a4df4947910d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360434Reviewed-by:
-
John Lee authored
Change-Id: I43e9f2df360a20f4e1a8641114f897053f47bd60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358600Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#798838}
-
Xiaohui Chen authored
Bug: None Change-Id: I063f5d074dac5d7c02d50cdc3e8975f30f80a214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357422 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#798837}
-
Daniel Libby authored
For elements with will-change:transform or directly composited images the raster scale is not updated in response to transform scale changes. Once the scale gets especially large, the interest rect computed by blink starts to become less than the layer bounds. This ends up setting a recorded_viewport_ on RasterSource that is also less than the layer bounds. If the interest rect gets small enough, it's possible that tiles that are in view are not completely covered by the RasterSource. This means that we won't create tiles (much less assign them GPU memory and schedule them) in PictureLayerTiling::CreateTile. We did not see this with the previous implementation of directly composited images, since the content layer never had an interest rect computed. This change fixes this specifically for directly composited images by always considering its raster source as covering the entire layer. This is the definition of directly composited images (has a DrawImageRectOp that draws into the entire layer). This allows the in view tiles to be created, then rasterized and activated and the image no longer disappears. I looked into fixing the general case (see comments in the bug) but given the regression for the images scenario and the fact that we'd like to get a fix merged for 85, I took an approach to just fix directly composited images. Bug: 1110141 Change-Id: Ice3cf25508585f116edd7317718292ec9ad8a7ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358888Reviewed-by:
-
Evan Stade authored
follow up to 8e26d230 Bug: 1097216 Change-Id: Ic65b788010d84c8d2a0282f0bd3a1e2d9680ab3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359746 Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#798835}
-
Mingjing Zhang authored
This CL adds Graphics.Smoothness.Jank.* histograms in histograms.xml. Bug: 1073216 Change-Id: I955cd30c086f0b517be40fd64e830b82ee65271c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359165Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#798834}
-
Shuran Huang authored
Add use counter to collect UMA metrics of when postMessage is called between top-level windows on a same-site and cross-site basis, and when targetOrigin is not specified. When is called for cross-site, metrics will be measured in UKM as well. These metrics will be used to understand how postMessage is used between sites to come up with future plans for postMessage API changes. Bug: 1112491 Change-Id: I0b023067c289d0a957c28100cf7c591c97030d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337263 Commit-Queue: Shuran Huang <shuuran@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#798833}
-
Dominic Farolino authored
This reverts commit f97fae25. Reason for revert: Fixing the null dereference of Document's loader which caused the crash in the first place. This crash was similar to what we saw in crbug.com/931330 and fixed with crrev.com/c/1470543. Original change's description: > Revert "Add PerfectHeuristics UKM event, and metric for DelayAsyncScriptExecution" > > This reverts commit 647d93e9. > > Reason for revert: crbug/1116821 - causing crashes > TBR=ryansturm@chromium.org,falken@chromium.org,rkaplow@chromium.org > > Original change's description: > > Add PerfectHeuristics UKM event, and metric for DelayAsyncScriptExecution > > > > This CL introduces the PerfectHeuristics UKM event, along with a boolean > > metric for when a blink::ScriptRunner comes across an async script > > before the script element's node document has finished parsing. The > > PerfectHeuristics UKM event is logged in the UkmPageLoadMetricsObserver. > > > > See the Google-internal UKM privacy review: > > https://docs.google.com/document/d/1UqkpGXc4LEh5jzzVR8fCVVTuCuG2mwvhQTuCy36zT3g/edit# > > > > See the Perfect Heuristics [1] project document (currently > > Google-internal). > > > > [1]: https://docs.google.com/document/d/1Y7uF76Gq0VlJZky2j7x-lbD1_awH64eW0WRg1bNLuFs/edit > > > > R=falken@chromium.org, nhiroki@chromium.org, ryansturm@chromium.org, sophiechang@chromium.org > > > > Bug: 1086227 > > Change-Id: I71954491a1a559c2e1244a543092f1b8f38b8136 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340845 > > Commit-Queue: Dominic Farolino <dom@chromium.org> > > Reviewed-by: Sophie Chang <sophiechang@chromium.org> > > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#798393} > > TBR=falken@chromium.org,rkaplow@chromium.org,nhiroki@chromium.org,sophiechang@chromium.org,ryansturm@chromium.org,dom@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1086227,1116821 > Change-Id: I0131884d123e2122fa674097381293174795fecf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359573 > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Reviewed-by: Sophie Chang <sophiechang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798738} TBR=falken@chromium.org,rkaplow@chromium.org,nhiroki@chromium.org,sophiechang@chromium.org,ryansturm@chromium.org,dom@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1086227 Bug: 1116821 Change-Id: I7722da2c17dc34952ea9155d72840708b4eaa5b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359742Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#798832}
-
Cliff Smolinsky authored
This change updates the headers' aria role to be 'heading' instead of 'group', which is a more appropriate role given the definitions from w3. This also improves screen readers' understanding of these text blocks. Bug: 1116623 Change-Id: Iac4fa60c72da8a130bd28841889a3826a755c8e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357461Reviewed-by:
-
Tom Anderson authored
After [1], a rebuild is necessary to pull in the libxkbcommon0 and libwayland-client0 changes. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2352948 BUG=1116999,1116384 R=msisov Change-Id: I69c9233a3a1d8070565adc217a308497de61c2ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360317 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#798830}
-
Peter Boström authored
This also refactors OutdatedUpgradeBubbleView to use DialogModel, which makes use of body text. Bug: 1106422 Change-Id: Ifae91809fc6c71274ac4c0368d427e7b094d8ddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351061Reviewed-by:
-
Peter Kasting authored
The code clearly expects infinity to be possible, but unconditionally multiplies by it (and discards the result in the infinity case). This is UB; avoid the multiplication in this case. Bug: 1116289 Change-Id: I5b1297e92be68e3477b3dcbb17146d4f7a3d4098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355404 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#798828}
-
Daniel Hosseinian authored
Because the field trial testing config is applied to browser_tests, explicitly disable the "PdfHonorJsContentSettings" feature on tests that expect the feature disabled. Bug: 696650 Change-Id: I8b13523b590372230e66c61cf846fca8284112d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350114 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Auto-Submit: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#798827}
-
James Hawkins authored
Also convert the types in NetworkListTypes as well since they are trivial and NetworkListItem depends on them. Bug: 1045266 Test: NetworkNetworkListItem* Change-Id: Iabe3a94bd80a9269215f1298c30e154442014003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359397 Commit-Queue: James Hawkins <jhawkins@chromium.org> Auto-Submit: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#798826}
-
Victor Costan authored
Change-Id: I3673a9a4411c00b72a3e96b405ce726c9632ca4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359235 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#798825}
-
Josh Karlin authored
Change-Id: I35718eeeee57947b54a3e65348af9b1de1ac084c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354305Reviewed-by:
Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
-
Shimi Zhang authored
This CL uses a set::find overload to use the uint32_t type to find the object to avoid construct another object. By following the style guide, added a comparator struct. "For example, if your type doesn't have a natural ordering, but you want to store it in a std::set, use a custom comparator rather than overloading <." https://google.github.io/styleguide/cppguide.html#Operator_Overloading Bug: None Change-Id: Ic8b9f51a3b3a50601b1ecfa1ba8039ecf16a22ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358449Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#798823}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ic0dad7aa12b1e1c1e71e500ecddf2f2ce656fe85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360263Reviewed-by:
-
Brian Geffon authored
Bug=CHROMIUM:973963 Change-Id: Ib2fe85abd4fbe5dee7c6da48f7f1f5c25dd17a70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359740Reviewed-by:
-
Jan Wilken Dörrie authored
In order to make BasicStringPiece API compatible with C++17's std::basic_string_view this change removes the ends_with() API and updates call sites to use base::EndsWith instead. In order to keep this callsites concise, base::EndsWith's case_sensitivity parameter now defaults to CompareCase::SENSITIVE. TBR=dcheng Bug: 1049498 Change-Id: Ie10332e84ae8cc96524c4bf47e5f472a6215eaa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358831 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
-
Jae Hoon Kim authored
Add missing mock for |ObjectProxy::WaitForServiceToBeAvailable| in order to unittest |ObjectProxy| when this method is called. BUG=b:164310699 TEST=unit_tests Change-Id: I0071e6d3987b5881841d3e38432ade6ceaf5eb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358131Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Jae Hoon Kim <kimjae@chromium.org> Cr-Commit-Position: refs/heads/master@{#798819}
-
Owen Min authored
cloud.png and success.png under chrome/browser/policy is not used by any source code. Change-Id: I13e8a5f56b927de7fb455408e088afb162050cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356671Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#798818}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/ffd805115ed6..21b36f736809 2020-08-17 rharrison@google.com Roll 4 dependencies (#1131) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: Ied6c561def4ebc0c16c279da171809877eaa5b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360298Reviewed-by:
-
Fred Mello authored
https://docs.google.com/document/d/1wXOKcgVy5YuGRFWUlBv75bl7j5gNK5bzc-ETr5GVBJw Bug: 1112872 Change-Id: Ie90cfe5dbb4efbb28e6b9407358556f6b1919cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359747 Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
-
