- 15 Apr, 2020 40 commits
-
-
Mark Cogan authored
Change-Id: I24aead570e61d9451372f9b4a0a792c12bbe2ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149455 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#759207}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ed70e67c..b7b5fba5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idfce415f66c6121422437c865078dbfaa45db02a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143838Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759206}
-
Antonio Gomes authored
BUG=767015, 1063749 R=rego@igalia.com Change-Id: Ie7b38d16617059f7170c4e01c70ad7bf22cceec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143834Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#759205}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6e0d718a48d8..5e7ef660be4a git log 6e0d718a48d8..5e7ef660be4a --date=short --first-parent --format='%ad %ae %s' 2020-04-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src f89de66a9bcb..da9102fb013d (3 commits) Created with: gclient setdep -r src/third_party/angle@5e7ef660be4a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I73aa14fc2907aeb3804fc1821e5eda6ad8fdd281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150412Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759204}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ef991621e00a..5ca2a6d45d61 git log ef991621e00a..5ca2a6d45d61 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 sigurds@chromium.org [devtools] Update protocol Created with: gclient setdep -r src/third_party/devtools-frontend/src@5ca2a6d45d61 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8eccbe74fdb32fd5fabd5327198c6bc766ddd9d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150413Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759203}
-
Abhijeet Kandalkar authored
Migrate this test out of t_p/blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. This test verifies that the border, margin and padding works properly combining RTL direction with different writing-modes. Bug: 1063749, 767015 Change-Id: I001aefe3ad2aa7ab5d75b95a0649ebaa8f5ad1c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145525 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#759202}
-
Patrick Rohr authored
Adding support for casting to 4k Android TV devices. use_goma=true target_os="android" target_cpu="x86"' \ && ninja -j500 -C out/Debug media_base_junit_tests \ && out/Debug/bin/run_media_base_junit_tests Test: gn gen out/Debug --args='is_chromecast=true is_debug=true \ Bug: 1064263 Change-Id: Ibd1fed93af30fd38a2ede189641aa5da0e5225ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117733 Commit-Queue: Patrick Rohr <prohr@google.com> Auto-Submit: Patrick Rohr <prohr@google.com> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#759201}
-
Roman Sorokin authored
This should prevent DCHECKs in wizard_controller on multiple button presses. Fixed: 1069240 Change-Id: Iffc71c7bf0f602ce4d3bf84ff5176afc99b49be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144150Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759200}
-
chromium-autoroll authored
fuchsia/third_party/aemu/linux-amd64/+log/vN52w.....b4mdc... Created with: gclient setdep -r src/third_party/aemu-linux-x64@b4mdc... If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: chonggu@google.com Change-Id: I0a2749ecdcb1ca9082dfeb551cf49d5689930a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150408Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759199}
-
Henrique Ferreiro authored
Migrate this test out of third_party/blink/web_tests/fast/css-grid-layout/ into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749, 767015 Change-Id: I0cb225a60fae7ae40746307983a795cdbfdd35f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148779 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#759198}
-
Anders Hartvoll Ruud authored
When animating font-affecting properties (e.g. font-size) while the base style contains font-relative units (e.g. em), we can not use the base computed style optimization, since the font-relative units in the base must respond to the font animation. A has_font_affecting_animation_ flag was recently added to ElementAnimations to assist in disabling the optimization under these circumstances. However, that was added with an insufficient understanding of ElementAnimation's lifetime, and hence this flag doesn't really work properly. For example, if we have an animation that initially doesn't affect the font, but then suddenly affects the font after all via setKeyframes, we would paint one incorrect frame before discovering that the font is now affected, and then (for frame #2 and subsequent) we'd be able to disable the optimization. This CL instead checks if the EffectStack affects the font when we're considering the base computed style for use. Bug: 437689 Change-Id: If07f1e82559673433be0a80d2c3edea1c1a5165a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139662Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#759197}
-
Clemens Arbesser authored
Bug: b/145043394 Change-Id: Ife128befc4c910b89accd97e505c3864fff51452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145888 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#759196}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I07c94fce6e4a9bfcf91439229d23e3a742ef9b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150411Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759195}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e70d25f6fa5d..c018fc6ae667 git log e70d25f6fa5d..c018fc6ae667 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 afdx@google.com spirv-fuzz: Do not outline regions that produce pointer outputs (#3291) 2020-04-14 afdx@google.com spirv-fuzz: Handle OpRuntimeArray when replacing ids with synonyms (#3292) 2020-04-14 afdx@google.com spirv-fuzz: Handle image storage class in donation (#3290) 2020-04-14 afdx@google.com spirv-fuzz: Respect rules for OpSampledImage (#3287) 2020-04-14 afdx@google.com spirv-fuzz: Fix comment. (#3300) 2020-04-14 stevenperron@google.com Sampled images as read-only storage (#3295) 2020-04-14 alanbaker@google.com Remove implicit fallthrough (#3298) 2020-04-14 stevenperron@google.com Add tests for recently added command line option (#3297) 2020-04-14 dneto@google.com If SPIRV-Headers is in our tree, include it as subproject (#3299) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@c018fc6ae667 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,timvp@google.com Change-Id: I682efd148acd3e3f23bb99ca8fd59cb31ca19ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150409Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759194}
-
Yoshifumi Inoue authored
This patch removes |DCHECK(current_drag_data_.IsNull())| to avoid crash when test scripts don't finish mouse drag, e.g. not to call |eventSender.mouseUp()| because of assertion failure in w3c test scripts for ease of writing test scripts. This patch is suggested in another CL[1]. [1] http://crrev.com/c/2148920 Make editing/selection/drag-in-iframe.html not to crash Bug: 707656 Change-Id: I989c1fe8cceb39566e3f8ddda364b4dc9cc060aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150346 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759193}
-
Ye Kuang authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/cc958279ffd6..160b445a44e0 $ git log cc958279f..160b445a4 --date=short --no-merges --format='%ad %ae %s' 2020-04-15 tikuta swarming/client: set client and version in User-Agent 2020-04-15 tikuta net: add set_user_agent 2020-04-14 yekuang [swarming] Add user-agent header to the client requests 2020-04-14 tikuta Revert "client: add filename and line in logging" 2020-04-10 yekuang run_isolated.py: Propagate the exceptions from upload_items() to the main thread 2020-04-09 qyearsley Run spellchecker on luci-py. 2020-04-09 tikuta client: add verify_push flag to archive_files_to_storage 2020-04-09 jwata [swarming-client] evict corrupted files in local cache 2020-04-09 yekuang Send SIGTERM to the isolated download process when it times out 2020-04-08 tikuta client: update isolated client 2020-04-08 tikuta client: include relevant logs only in update_isolated.sh 2020-04-01 tikuta client: update isolated client 2020-04-01 tikuta client: update isolated client 2020-04-01 tikuta client: add script to update isolated in run_isolated.py 2020-03-31 tikuta client: check hash of uploaded file 2020-03-30 tikuta client: add filename and line in logging 2020-03-30 yekuang client: update isolated client 2020-03-27 tikuta client: update isolated client 2020-03-27 leilei Update luci_context.py, otherwise it is failed to get LUCI context in Python3. 2020-03-23 leilei Reland "Update Swarming client code to make it work with Python3." 2020-03-23 tikuta Reland "client: remove --extra-variable flag from isolate.py" 2020-03-19 tikuta client: show exception when failed to run command 2020-03-19 mattkot Re-cache free disk space when _load fails 2020-03-18 tikuta Revert "client: remove --extra-variable flag from isolate.py" 2020-03-17 tikuta Revert "Update Swarming client code to make it work with Python3." 2020-03-17 leilei Update Swarming client code to make it work with Python3. 2020-03-12 tikuta swarming: show account id when failed to get oauth_token Created with: roll-dep src/tools/swarming_client Bug: 1070487 Change-Id: I5892e5bb9256037ef48de29d920969dba9f94372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148898Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Ye Kuang <yekuang@google.com> Cr-Commit-Position: refs/heads/master@{#759192}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bce98d0a1b9f..ef991621e00a git log bce98d0a1b9f..ef991621e00a --date=short --first-parent --format='%ad %ae %s' 2020-04-15 tvanderlippe@chromium.org Update Karma to 5.0.1 Created with: gclient setdep -r src/third_party/devtools-frontend/src@ef991621e00a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1068145 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2490de3c80a1b82ea4a21529ad243cf3dfa85502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150410Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759191}
-
Cynthia Revström authored
Before this fix, autofill would suggest credit card numbers for Swedish and Norwegian personal ID number fields. This fix simply changes a regex to fix this issue. Bug: 1067164 Change-Id: I6af21500f1db85ce8fb8eaf78e0e2671e039f524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144207Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#759190}
-
Maggie Cai authored
This CL parses the base::Value read from JSON file back to preferred apps list. This CL also adds some unit tests. BUG=853604 Change-Id: I8724784f5ab91e19614c1f66f45f1aff4fef0d80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141754 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#759189}
-
Stephen Nusko authored
This allows you to trace with perfetto "producer_name_filter" to scope your system traces to only particular apps (chrome stable/canary/etc). Change-Id: I9a677a8d8edfdf6645eb50d9e77e9ffb025ca94d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144135 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#759188}
-
Colin Blundell authored
After preceding CLs this class has no remaining //chrome dependencies other than resources, which this CL componentizes along with the class itself. As this implementation of InterceptNavigationDelegate is specific to the overall intent launching logic in //components/external_intents, this CL componentizes it into that component. Componentizing this class will enable it to be reused in WebLayer. TBR=jochen@chromium.org Bug: 1031465 Change-Id: Iea7f68ebdee3fc4d766604c46ba5868429c14e65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133984 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#759187}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/422a2f9fece9..3aa998dd83ac Created with: gclient setdep -r src-internal@3aa998dd83ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xhwang@google.com,yutak@google.com,rhalavati@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: xhwang@google.com,yutak@google.com,rhalavati@google.com Change-Id: Ia091e4fc046e5b98048c57d7c5c7971c1a22eb0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150093Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759186}
-
David Van Cleve authored
This CL makes a couple key commitment parsing and storage changes in preparation for receiving JSON-encoded keys (rather than Mojo structs) from the browser: 1. It modifies the NetworkService SetTrustTokenKeyCommitments interface to take a string rather than a map<issuer, key commitment result>; 2. It expands the key commitment parsing logic in the network service with a new method capable of parsing a collection of (issuer -> key commitment result) entries. 3. It adds a new TrustTokenKeyCommitments setter taking a raw string and passing it to the new parsing interface, rather than taking a map. R=csharrison Bug: 1068651 Change-Id: I930e797c39c4adac0da3919cbc462283c89d6f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139416 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#759185}
-
Wei Lee authored
This CL changes the preview resolution sorting order from: 1. Resolution which is slightly larger than the screen size 2. The larger, the better To: (Given |Rc| is the capture resolution and |Rs| is the screen size, and |Rp| means the preview resolution) If |Rc| <= |Rs|: 1. All |Rp| <= |Rc|, and the larger, the better. 2. All |Rp| > |Rc|, and the smaller, the better. If |Rc| > |Rs|: 1. All |Rp| where |Rs| <= |Rp| <= |Rc|, and the smaller, the better. 2. All |Rp| < |Rs|, and the larger, the better. 3. All |Rp| > |Rc|, and the smaller, the better. Bug: 1069440 Test: Manually checks the order in CCA Change-Id: I7a3a9160e4eac560b060da81fe6657467c476af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145375 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#759184}
-
Huanzhong Huang authored
Bug: 1068988 Change-Id: Ia855f636801a9b4ae453791d00e9f6e13548b965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141499Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#759183}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1eaee939..ed70e67c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1df2ec212d8620a0fea2f5dbc065878ede41d15c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147558Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759182}
-
Mario Sanchez Prada authored
Migrate this test out of blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Additionally, migrate this test from being a testRunner-based reftest with plain text expectation into a testharness.js-based test that uses check-layout-th.js instead of the utils from the Chromium-specific check-layout.js file, and drop the expectations file. Last, this renames flex-and-minmax-content-resolution-rows-001.html into flex-content-resolution-rows-002.html, since such test is related to the one being migrated here, and that way it makes things a bit more consistent. Bug: 767015, 1063749 Change-Id: I7326d7af76e04cbb3b5634a8e59bcfd36fcc92d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148597Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#759181}
-
Mario Sanchez Prada authored
Migrate this test out of blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 767015, 1063749 Change-Id: Ia971e3e34dc3835cb03302150edc59e88ee7f82c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148314Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#759180}
-
Mario Sanchez Prada authored
Migrate this test out of blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Additionally, migrate this test from being a testRunner-based reftest with plain text expectation into a testharness.js-based test that uses check-layout-th.js instead of the utils from the Chromium-specific check-layout.js file, and drop the expectations file. Last, this renames flex-and-minmax-content-resolution-columns-001.html into flex-content-resolution-columns-002.html, since such test is related to the one being migrated here, and that way it makes things a bit more consistent. Bug: 767015, 1063749 Change-Id: I06407ef10a9d9a1a7fafa0e405675e3683b23250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146544Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#759179}
-
Mario Sanchez Prada authored
Migrate this test out of blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 767015, 1063749 Change-Id: Id33b94879966a569e82eda331eed52143012de84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149355Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#759178}
-
Mario Sanchez Prada authored
Migrate this test out of blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Also rename it into grid-margins-no-collapse-002.html, as this test is related to the already existing grid-margins-no-collapse-001.html. Bug: 767015, 1063749 Change-Id: Iebd601763748acbe7f08a6216d15a44bfdf41cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145891 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#759177}
-
Mario Sanchez Prada authored
Migrate this test out of blink/web_tests/fast/css-grid-layout and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Also rename it into grid-floats-no-intrude-002.html, as this test is related to the already existing grid-floats-no-intrude-001.html. Bug: 767015, 1063749 Change-Id: If40a67c61b7c47befce5033895be393c7cda0eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148791 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#759176}
-
Ewann authored
This CL updates Cookies option selection, once an option is selected its accessory is set and the previous one is hidden. Bug: 1064961 Change-Id: I4db60f0629b4b308031ef1854ce29ccddb8cc87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130794 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#759175}
-
David Jean authored
Bug: 1045454 Change-Id: I4598f8c15e302a297343fc07eba94fda9980bde1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145887 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#759174}
-
Alan Cutter authored
This CL splits the definition of GLImageBindTest and GLImageZeroInitializeTest out into their own header files so source files that don't use them don't trigger the following warnings in gl_unittests: The following parameterized test case is not instantiated: UninstantiatedTypeParamaterizedTestSuite<GLImageBindTest> The following parameterized test case is not instantiated: UninstantiatedTypeParamaterizedTestSuite<GLImageZeroInitializeTest> Bug: 1045846 Change-Id: If64404d069b60405c6333f8a77abda85a5b11bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143777 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#759173}
-
Mohamed Amir Yosef authored
Bug: 1032992 Change-Id: I37e14d4a6b7fa9747d1509b4c1a5e594ad23ba23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144147Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#759172}
-
Adam Rice authored
A non-ASCII character was introduced into third_party/blink/web_tests/external/wpt/webdriver/tests/support/__init__.py by the wpt roll https://chromium-review.googlesource.com/c/chromium/src/+/2147959. This causes a compilation failure in Python 2. Fix it. TBR=smcgruer Change-Id: I83180eb29b3ee05aedd282b96225745010f74150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149483Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#759171}
-
chrome://media-appTrent Apted authored
Principally, this ensures that the Camera App opens the correct "camera roll" app, depending on whether the "Media App" SWA is enabled. It does this by intercepting the request to executeTask with the Gallery app, but allows the Gallery app to still open RAW image file types. No effect when chrome://flags#media-app is not enabled. Except for RAW files, we will hide the Gallery as a file handler option in the files app in a follow-up so that users are not confused why selecting it also results in the Media App being launched. Bug: 1030935, b/153387960 Change-Id: Ibe63455e8dd247769fabd123edb4925b8bae3739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143417 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#759170}
-
Fredrik Söderqvist authored
When the <use> element moves to a new document, it's both possible that the base URL changes and that the transition is from an inactive to an active document. In the latter case we need to re-resolve the URL and potentially attempt to fetch any external resource again. Do this by calling UpdateTargetReference() in a DidMoveToNewDocument() override. Also add a check for being in an inactive document to avoid the unnecessary work in that case, as well as clearing out the resource reference if the move is from an active to an inactive document. Fixed: 1070076 Change-Id: Ibfcbe5a590d2115eece0d68ed1c03db49ef5f708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149415Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#759169}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/beaaa5a60140..93bea5cb50e3 git log beaaa5a60140..93bea5cb50e3 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 enga@chromium.org Add WireClient::Disconnect to stop serializing commands Created with: gclient setdep -r src/third_party/dawn@93bea5cb50e3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1070392 Tbr: cwallez@google.com Change-Id: Ie6489bfccf35f3d1164898afb6a93546d5723a9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150095Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759168}
-