- 18 Nov, 2020 14 commits
-
-
Tomasz Wiszkowski authored
This change enables the native AutocompleteMatch object to create and retain a copy of its corresponding java counterpart. The change essentially shifts code around, moving logic away from AutocompleteController into AutocompleteMatch (both Java and Native). The change optimizes slightly creation of the Java counterparts by retaining an object if it's already created. This comes in handy for every match that is backfilled on every keystroke (about 3 times every time we call AutocompleteController::Start() to get new matches). Java AutocompleteMatch objects are lazily constructed to reduce penalty when native objects end up thrown away -- see: * AutcompleteController#classify(), * AutocompleteController#qualifyPartialUrlQuery() Bug: 1138587 Change-Id: I8c5437cfb0203d5c7f5e1d79747eee3f15b7b0b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538499 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#828488}
-
Daniel Murphy authored
The previous barrier was difficult to use, as it expected a call on success or error. This barrier only expects to be called on error, and will automatically call the completion callback when all instances and callbacks are destroyed. Change-Id: If5be817c419e0858b348fd75da8385700a02bb88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532906Reviewed-by:
Phillis Tang <phillis@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#828487}
-
Marijn Kruisselbrink authored
This reverts commit 6d681c88. Reason for revert: Causing test failures on MSAN builds: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21346 Original change's description: > ambient: support multiple displays > > Run ambient mode UI on each connected display. > RootWindowController construction handles adding ambient widgets > to new displays while ambient mode is running, and destructing them > on display removed. > > BUG=b:139953389 > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Change-Id: Ic57c33491098b66c7c0e90ef1f3d12c71f1fc303 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516968 > Commit-Queue: Jeffrey Young <cowmoo@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828329} TBR=oshima@chromium.org,xiaohuic@chromium.org,wutao@chromium.org,cowmoo@chromium.org Change-Id: I255333ed722549fdc9d0e945c65cf3f742b1cabc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:139953389 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545752Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#828486}
-
Alex Newcomer authored
UX prefers this string. Bug: 1142473 Change-Id: I0fb5d1ac20b9c0dc8b2e44eb7e87c28307fabf9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544881 Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#828485}
-
Avi Drissman authored
Every so often, the Rosetta installer will call back the provided "installation done" block more than once. Protect against that. Fixed: 1150097 Change-Id: Ib12db225e7c7f5ec7c7fa69dccdd12693575a944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545076Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828484}
-
Phillis Tang authored
Add IPH globally scoped data and add trigger logic for install IPH that doesn't show IPH unless site-engagement score is above 10 and IPH hasn't been shown for this site for 90 days, and hasn't been shown globally for 14 days, and hasn't been ignored by user 3 days in a row for this site and hasn't been ignored by user 4 days in a row globally. Bug: 1149670 Change-Id: Idff12df63673f6e8e1fd63383f7fc57c07eb748a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530197 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#828483}
-
Marijn Kruisselbrink authored
This reverts commit 34ec1547. Reason for revert: Tests are flaky, see linked bugs. Original change's description: > Add title visibility option to Incognito CCT. > > This CL gives ability to Incognito CCT to show title on toolbar. > > For screenshot: > https://drive.google.com/file/d/1WQFhK3yhVsF-OazSSrUh9d8mfpNb1ZeK > > Bug: 1104180 > Change-Id: I195ba2200d0994bb0aea5f06ce017ec81172e2a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537677 > Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> > Reviewed-by: Rohit Agarwal <roagarwal@chromium.org> > Reviewed-by: Peter Conn <peconn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828235} TBR=peconn@chromium.org,roagarwal@chromium.org,sideyilmaz@chromium.org Change-Id: I16ccce7ebb6bd0dc1692e530545f33ed5ccfcfd7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1104180, 1150150, 1150083, 1150056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545258 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
-
Marijn Kruisselbrink authored
This reverts commit 94d2d696. Reason for revert: Reverting the CL that added these tests rather than disabling the test Original change's description: > [Sheriff] Disable flaky CustomTabActivityIncognitoTest#ensureTitleBarIsVisibile > > TBR=roagarwal@chromium.org > > Bug: 1150085 > Change-Id: I698d73ba2ef50883ead5093eb1ba64407bac07b9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545568 > Commit-Queue: Lijin Shen <lazzzis@google.com> > Reviewed-by: Lijin Shen <lazzzis@google.com> > Cr-Commit-Position: refs/heads/master@{#828470} TBR=lazzzis@google.com,sideyilmaz@chromium.org Change-Id: Ie73e3321c84f193b1fa13319f953b257a8a5b434 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1150085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545095Reviewed-by:
-
Matthew Wang authored
Bug: chromium:1149490, chromium:1149491 Change-Id: If21180126089c7a7fe9d714a6a3c0cc09880f27d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542045 Auto-Submit: Matthew Wang <matthewmwang@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Hugo Benichi <hugobenichi@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Matthew Wang <matthewmwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#828480}
-
Darren Shen authored
extra_input_methods is actually all the available input methods; there's nothing "extra" about it. Change-Id: I86e444aed7bec8660351dc9787147ee68341d49b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537452 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#828479}
-
Brian Geffon authored
When we added support for versioned message we accidentally introduced a behavior where messages can be shorter than expected. This is what the behavior should be to allow older messages to be received. However, we know the minimum size is the oldest message version. We should never be allowed to go smaller than that. BUG=chromium:1149805 Change-Id: I3a24dd62b6fafd742cd7ac155f863d33bb5c6de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545207Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#828478}
-
Matt Wolenetz authored
Updates a few WebCodecs IDL dictionary types to use the 'required' attribute where the draft spec indicates. In particular, it updates AudioFrameInit, EncodedAudioChunkInit, and EncodedVideoChunkInit to enforce the required fields are populated. I also looked at making similar change to VideoDecoderConfig, but the codedWidth and codedHeight fields' usage in the implementation already has notes that go deeper (AVCC coherence is TBD, for example). Also includes a change to make EncodedVideoChunkInit.duration _not_ nullable. It is not required, so its absence is sufficient to indicate it is unset. Retains the nullable attribute on the readonly EncodedVideoChunk.duration field. BUG=1149028 Change-Id: If82c495d94ed9532007dfda614ec97bc88e773ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543126Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#828477}
-
edchin authored
Design doc: go/bling-phishguard The PASSWORD_REUSE_DETECTION_ENABLED flag disabled compiling of code in iOS. Previous CLs either 1) removed the compile flag from disabling whole classes or methods, or 2) replaced the compile flag with a runtime flag that is disabled on iOS. This CL will land after all uses of PASSWORD_REUSE_DETECTION_ENABLED have been removed. Bug: 1147962 Change-Id: Ia82ea36bb75cb431dc0b9f42cdc7b7b7118b5373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536842 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#828476}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d8e982264ce5..ed87c16ad00e 2020-11-17 m.maiya@samsung.com Vulkan: Add GL_EXT_separate_shader_objects support 2020-11-17 m.maiya@samsung.com Vulkan: Add EXT_separate_shader_objects entry points 2020-11-17 thakis@chromium.org Stop setting mac_xcode_version in DEPS 2020-11-17 syoussefi@chromium.org Vulkan: 270 degree prerotation deqp expectations 2020-11-17 syoussefi@chromium.org GL: Support OES_shader_image_atomic 2020-11-17 syoussefi@chromium.org Vulkan: Support texture buffers 2020-11-17 syoussefi@chromium.org Use 0 as special value for glTexBuffer instead of UINT_MAX 2020-11-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 9e07e4424cd4 to 4fe17f3425ee (12 revisions) 2020-11-17 syoussefi@chromium.org Vulkan: Reuse GetBoundBufferAvailableSize in ProgramExecutableVk If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Test: Test: ProgramPipelineTest.GenerateProgramPipelineObjectEXT* Change-Id: I30a3a822a05e5045c2df9446b6d9aad5a329e971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544033Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828475}
-
- 17 Nov, 2020 26 commits
-
-
Marijn Kruisselbrink authored
Bug: 1095379 Change-Id: I3a764362a70711cf33e365460594712be235cfd6 Tbr: masonfreed@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545771 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
-
Liquan (Max) Gu authored
* Null-check mPaymentRequestService for its uses in the non-BrowserPRSservice interface implementation methods. This is in case other interfaces might use mPaymentRequestService after its closing. * Removed the unnecessary mPaymentRequestService null-checks when it is not used in the method. Bug: 1025619 Change-Id: Ic4fddfcb7279db09dfbfdc35f89c9c836dfaf420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543375 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#828473}
-
Adam Langley authored
This change causes the user to be prompted to enable Bluetooth (if necessary) after scanning a QR code. It also automatically enables Bluetooth in order to process FCM messages in the background. The user is advised of this when choosing to link with the device. BUG=1002262 Change-Id: I918f12177597a49cd6fb2dc0d06bd2c4ba071c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538159 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#828472}
-
Moe Ahmadi authored
KeyboardEvent.isComposing is a boolean property indicating if the input event is fired within a composition session started by an input method editor (IME). IME is primarily used for inputting CJK (Chinese, Japanese, and Korean) characters. Updating the input text via inline autocompletion when a composition session is active can have undesired effects such as the one described in the bug linked to in this CL. While not an ideal solution, this is a safe one due to its small scope allowing this change to be merged into a previous milestone. An ideal solution would be to use a mechanism other than input text selection for inline autocompletion such as how it is done in the omnibox via a grey label: screenshot/8ougnH9pRAiDfb2 Bug: 1128310, 1149769 Change-Id: Ie6596c9f60da33adaf8b4847d891fc102c5d71c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543546Reviewed-by:
-
Lijin Shen authored
TBR=roagarwal@chromium.org Bug: 1150085 Change-Id: I698d73ba2ef50883ead5093eb1ba64407bac07b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545568 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#828470}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Iad8220ba174d4afd3629112872b93586d47163f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545423Reviewed-by:
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome/browser/ui. Bug: 1113033 Change-Id: Ib54a8a6a3411975497c110037812f088d0b14330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545086 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Jiewei Qian authored
This CL removes two histograms that were used to investigate bookmark app (extension-based) install failures: - Webapp.InstallResultExtensionError.System.Profiles.Other - Webapp.InstallResultExtensionDisabledReason.System.Profiles.Other The relevant code isn't executed after BMO project launch (which moves SWA install to web app install finalizer). Also removes the relevant test code that were solely introduced for testing these two histograms (see https://crrev.com/c/1915651 ). Fixed: 1149526,1149527 Change-Id: I195f531d7c7a8cf106ed00662e3231d2d2b12b08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543531Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Yicheng Li authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/9ec6b6802d3f..50b570a8b17f $ git log 9ec6b6802..50b570a8b --date=short --no-merges --format='%ad %ae %s' 2020-11-17 pbond system_api: extend ArcDataSnapshotd d-bus interface 2020-11-06 yichengli u2fd: Add DBus method to check authenticator availability 2020-11-15 cylai system_api: attestation add public key field 2020-10-22 gerow vm_tools: concierge: allow writable rootfs 2020-11-13 ahassani system_api: Unify AU project's owners 2020-09-09 yichengli u2fd: Support canceling WebAuthn operations Created with: roll-dep src/third_party/cros_system_api Bug: None Change-Id: I0ca854e58e7480967762adac00b4594c10a75219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544786 Commit-Queue: Yicheng Li <yichengli@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Yicheng Li <yichengli@chromium.org> Reviewed-by:
-
Maksim Ivanov authored
Extend the embedded_test_server's HttpRequest struct to additionally contain the SSLInfo structure when it's available. This allows to inspect the SSL state, like the provided client certificate, in net::EmbeddedTestServer's request handlers. Bug: 792204 Change-Id: Ia24acf0c38fadee04c341d3c9192d98272bf5ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545163Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#828465}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d98e8b70bbb1..698385d4e2b4 2020-11-17 cwallez@chromium.org Stop setting mac_xcode_version in DEPS 2020-11-17 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 4ad0019df0f0 to 90f32536458a (17 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1147839 Tbr: kainino@google.com Change-Id: I8274eb9f6c30a63213ccdc83bc7ac54c466bacaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545229Reviewed-by:
-
Marijn Kruisselbrink authored
This reverts commit d4e5f661. Reason for revert: Still failing to build with deps errors: https://ci.chromium.org/p/chrome/builders/ci/win64-chrome/10175 ERROR at //chrome/browser/win/conflicts/incompatible_applications_browsertest.cc:22:11: Can't include this header from here. #include "chrome/browser/win/conflicts/incompatible_applications_updater.h" ^--------------------------------------------------------------- The target: //chrome/browser/win/conflicts:browser_tests is including a file from the target: //chrome/browser:browser It's usually best to depend directly on the destination target. In some cases, the destination target is considered a subcomponent of an intermediate target. In this case, the intermediate target should depend publicly on the destination to forward the ability to include headers. Dependency chain (there may also be others): //chrome/browser/win/conflicts:browser_tests --> //chrome/test:test_support_ui --> //chrome/browser:test_support_ui --[private]--> //chrome/browser:browser Original change's description: > Reland "Extract browser_process.h/cc into own gn target" > > This is a reland of 86556051 > > The original CL missed a dep requirement in the Chrome branded > Windows build. This has been fixed: > https://chromium-review.googlesource.com/c/chromium/src/+/2543873/2/chrome/browser/win/conflicts/BUILD.gn > > Original change's description: > > Extract browser_process.h/cc into own gn target > > > > This CL pulls out browser_process.h and browser_process.cc into their > > own gn target so that other gn targets can depend on it without creating > > cyclic dependencies with //chrome/browser:browser. > > > > This is required for CL: > > https://chromium-review.googlesource.com/c/chromium/src/+/2528519 > > > > Bug: 1147410, 883570, 925153 > > Change-Id: I17ef1f0b1683c4abb7588a6ef24ec89f15647545 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529309 > > Commit-Queue: Alan Cutter <alancutter@chromium.org> > > Reviewed-by: Filip Gorski <fgorski@chromium.org> > > Reviewed-by: Glen Robertson <glenrob@chromium.org> > > Auto-Submit: Alan Cutter <alancutter@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#828077} > > Bug: 1147410 > Bug: 883570 > Bug: 925153 > Change-Id: I18faaddc3850ceafb924bda6d8e197f886e79433 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543873 > Reviewed-by: Glen Robertson <glenrob@chromium.org> > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828442} TBR=fgorski@chromium.org,alancutter@chromium.org,glenrob@chromium.org Change-Id: I6c5dd2e541fc98622a24435610d16de5ac9ec75e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1147410 Bug: 883570 Bug: 925153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545078Reviewed-by:
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome/browser/ui. Bug: 1113033 Change-Id: I9aa946ac87b80044e219ff88b484fa28f1266314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545028 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/15247228..cca2a004 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibf6f5e890dce4a8f6dd4e90f3e5aa2c0b53325b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544932Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828461}
-
Bailey Berro authored
This change adds the Battery Charge and Battery Discharge Routines to the SystemRoutineController interface. Example of routines being called from frontend: https://source.chromium.org/chromium/chromium/src/+/master:chromeos/components/diagnostics_ui/resources/routine_list_executor.js;l=88-118 Bug: 1128204 Change-Id: I1b4589a69b66bd7a62899d40a297ef96b4e8f877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488747 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#828460}
-
Marijn Kruisselbrink authored
This reverts commit ecd22f2f. Reason for revert: SubresourceFilterBrowserTest.DisallowedSubframeURLBlockedOnActivatedURL is flaky Example failures on https://ci.chromium.org/p/chromium/builders/ci/Win%207%20Tests%20x64%20%281%29 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8863356200301577856/+/steps/weblayer_browsertests/0/logs/Deterministic_failure:_SubresourceFilterBrowserTest.DisallowedSubframeURLBlockedOnActivatedURL__status_FAILURE_/0 ../../weblayer/browser/subresource_filter_browsertest.cc(196): error: Value of: WasParsedScriptElementLoaded(web_contents->GetMainFrame()) Actual: true Expected: false Original change's description: > [WebLayer] Initial bringup of ad blocking > > This CL does the initial bringup of ad tagging and blocking > functionality in WebLayer. To do so, we do the following: > - Bring up an implementation of SubresourceFilterClient and attach it > to WebContents instances > - Instantiate subresource filter navigation throttles on navigation > - Instantiates and configures SubresourceFilterAgent instances in the > renderer > > The organization and code added is modeled after that in //chrome. We > have left TODOs for significant pieces of functionality to be added > in followups (e.g., showing of the infobar on Android). One thing to > note is that ad tagging/blocking only triggers on Android in WebLayer, > as it requires having a safe browsing database instance and WebLayer > does not have one on platforms other than Android. > > This CL also adds browsertests of this initial functionality: > - that the subresource filter activation state is computed on page loads > - that ads are blocked on activated pages if they are flagged by the > ruleset > > Bug: 1116095 > Change-Id: I1db0136709014004c221bb0251551eaeac3538e3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526087 > Commit-Queue: Colin Blundell <blundell@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827735} TBR=blundell@chromium.org,csharrison@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1116095 Change-Id: I4b8bbed57ed18666e2155dae7a25186803802267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545763Reviewed-by:
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome/browser/ui. Bug: 1113033 Change-Id: I7b66fc969130543f13445bd86c7a443c0de6b7e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544872 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome/browser/ui. Bug: 1113033 Change-Id: Id893e982a7002c21c46c95f0d4732e638c6e22db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545027 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
Consider ConnectionDetails::connection_medium_ when comparing ConnectionMedium objects. This fixes an issue in which two ConnectionDetails objects with the same device ID but different mediums were compared incorrectly, causing an issue where connection attempts to the same device with different mediums ended up using the same underlying connection instead of two separate connections. Bug: 1150070 Change-Id: I9bb2802676aebf4a0df9a430cc33bff683dcd14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545664 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#828456}
-
Luciano Pacheco authored
All of them aren't working on Files app anymore so can be spared from the occasional code review for it. Thank you all for your time served with us! Change-Id: I58ddb08e6fc49a0ad49500912c67124793764740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536419 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Anand K Mistry <amistry@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#828455}
-
Becca Hughes authored
This will be used for watchtime tracking (in a sep. CL). Change-Id: I4d3c58b307e4f7e2bf76010a81660defca399f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544930 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#828454}
-
Bettina authored
The ResetShortcutsComponent will use the existing sandboxed shortcut parser to retrieve modified shortcuts and then overwrites the existing shortcuts with new ones. The component will be hooked up to the CCT in a future CL. Bug: 1116017,1148930 Change-Id: Ia6c8453af267b98884804eed3b18944afb0506ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520419Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#828453}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605581968-699188875fbc74b98026cce85d5b16d698948c9f.profdata to chrome-win64-master-1605625046-b998d997d9684c194050542ad9b812298a5a0da2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Idbf2f136b9b3b3f0dadf98ad2006ce7728c1f2fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543133Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/04515da400d5..f1223ce969c7 2020-11-17 capn@google.com Switch Android to LLVM ORCv2 JIT and remove ORCv1 support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I4a768ec54ee3dea737278ada208b01f9d4cea492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545084Reviewed-by:
-
Lucas Radaelli authored
This change implements a class that maps between AXNode IDs to unique Fuchsia Node IDs. Bug: fuchsia:63607 Test: AXTreeConverterTest.* Change-Id: I75352da5b310112d07bd353ea4af7e23c52eac06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530981Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Commit-Queue: Lucas Radaelli <lucasradaelli@google.com> Cr-Commit-Position: refs/heads/master@{#828450}
-
Samuel Huang authored
The main analysis file for android-binary-size has been switched to Trichrome (from MonochromePublic) crrev.com/c/2545043, which updated constant.py by changing DEFAULT_SIZE_CONFIG_JSON. Although the file specifies DEFAULT_ANALYZE_TARGETS and DEFAULT_COMPILE_TARGETS that includes Trichrome targets, it turns out that android-binary-size's builder config overrides these values, but does not build Trichrome! This is causing android-binary-size bot to fail, since Trichrome is not built. This CL solves the problem by updating the builder config for android-binary-size. Bug: 1040645, 1150128 Change-Id: I5ba8205d44100288f8770345bfa64aadf785d2d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545486Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#828449}
-
