GitLab

Renaming webview copy of V8 snapshot to be able to differentiate
between snapshots for 32- and 64 bit architectures.
This is done so that snapshots for different architectures can be
repacked into the same APK.

BUG=455699

Review URL: https://codereview.chromium.org/903793002

Cr-Commit-Position: refs/heads/master@{#315314}

Cr-Commit-Position: refs/heads/master@{#315313}

Revert of Suppress data races in blink::Scheduler (patchset #1 id:1 of https://codereview.chromium.org/895753003/)

Reason for revert:
https://crbug.com/456095 has been fixed

Original issue's description:
> Suppress data races in blink::Scheduler
>
> BUG=456095
> TBR=skyostil@chromium.org
>
> Committed: https://crrev.com/1f26d43e2b92f4325b01e7976218ad9a1012674b
> Cr-Commit-Position: refs/heads/master@{#315027}

TBR=skyostil@chromium.org,alexclarke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=456095

Review URL: https://codereview.chromium.org/906323004

Cr-Commit-Position: refs/heads/master@{#315312}

Add ability to query properties of
 - Manager
 - Peer
 - Service
Add Observer to peerd so we are told when things change.

BUG=453873

Review URL: https://codereview.chromium.org/893663002

Cr-Commit-Position: refs/heads/master@{#315311}

This is the last stage of the trace_event directory restructuring.
This is part of a set of 3 CLs which is moving tracing clients to use
the new base::trace_event namespace.
See crrev.com/837303004 and the related bug for motivations.

BUG=451032
TBR=jam@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/892213004

Cr-Commit-Position: refs/heads/master@{#315310}

1) Qualify drive label selector in test_util.js to just elements under the drive tree. And (re-)add the drive icon to the Cloud Import drop down.

2) Don't auto-hide cloud-import buttons when disabled...(fyi, they're disabled when in scanning and importing modes...we want the user to see them).

3) Format values on details panel in a human friendly way.

BUG=420680
TEST=browser_test: *FileManager*

Review URL: https://codereview.chromium.org/902253003

Cr-Commit-Position: refs/heads/master@{#315309}

In SiteIntance::CreateForURL there will certainly create a new SiteInstance
and BrowsingIntance since in this new BrowsingIntance we will not find any
existing SiteIntance. So BrowsingIntance will never be deleted even beyond
the scope of the method.
The original comments will make some confusion.

BUG=11629

Review URL: https://codereview.chromium.org/880303004

Cr-Commit-Position: refs/heads/master@{#315308}

MaximizeModeController::CanEnterMaximizeMode was based on receiving an accelerometer event. AccelerometerReader now sends an event to every observer as it is added, to reduce lag on receiving first event. However on devices without accelerometers this sends an empty event.

Updated MaximizeModeController to not set that accelerometer events have been seen until a valid event is received. One with actual data.

TEST=MaximizeModeControllerTest.CanEnterMaximizeModeRequiresValidAccelerometerUpdate
BUG=454662

Review URL: https://codereview.chromium.org/895993002

Cr-Commit-Position: refs/heads/master@{#315307}

BUG=456102

Review URL: https://codereview.chromium.org/912503002

Cr-Commit-Position: refs/heads/master@{#315306}

Revert of Android: Start up GPU channel early (patchset #1 id:1 of https://codereview.chromium.org/893393004/)

Reason for revert:
Speculative revert to see if this could be the cause of crbug.com/456835.

Original issue's description:
> Android: Start up GPU channel early
>
> This addresses a TODO and reverts
> https://codereview.chromium.org/777303004.
>
> With https://codereview.chromium.org/889083002
> the CrashDumpManager is now initialized earlier so
> things should be fine.
>
> BUG=439322
>
> Committed: https://crrev.com/b8be6ae0e26843eab92ac1527a752278fec65d99
> Cr-Commit-Position: refs/heads/master@{#315170}

TBR=cjhopman@chromium.org,sievers@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=439322

Review URL: https://codereview.chromium.org/910433004

Cr-Commit-Position: refs/heads/master@{#315305}

Each flushVisualState request returns a unique id
that allows callers to match requests with callbacks.
The reasoning behind is to potentially allow clients
to reuse VisualStateFlushCallback objects to avoid
additional java allocations.

BUG=455651

Review URL: https://codereview.chromium.org/900303002

Cr-Commit-Position: refs/heads/master@{#315304}

MidiManagerUsb::DispatchSendMidiData takes |port_index| parameter. As it is
provided by a renderer possibly under the control of an attacker, we must
validate the given index before using it.

BUG=456516

Review URL: https://codereview.chromium.org/907793002

Cr-Commit-Position: refs/heads/master@{#315303}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/e6b1a60..4e534d0

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/913453002

Cr-Commit-Position: refs/heads/master@{#315302}

In addition |prefix| parameter added to constructor. If prefix is given, it is
added to the beginning of every registered key.

BUG=none
TBR=jshin@chromium.org

Review URL: https://codereview.chromium.org/878253002

Cr-Commit-Position: refs/heads/master@{#315301}

BUG=449163

Review URL: https://codereview.chromium.org/854843002

Cr-Commit-Position: refs/heads/master@{#315300}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/465217f..d693046

TBR=dpranke@chromium.org,caseq@chromium.org

Review URL: https://codereview.chromium.org/912483003

Cr-Commit-Position: refs/heads/master@{#315299}

Revert of Add debug information for crbug.com/289715 (patchset #5 id:80001 of https://codereview.chromium.org/810883007/)

Reason for revert:
Remove debugging information that was collected for crbug.com/289715

Original issue's description:
> Add debug information for crbug.com/289715
>
> Add temporary debugging information to determine whether a callback happens
> after the targeted URLRequestHttpJob was already deleted or whether a callback
> happens after its transaction was deleted.
>
> BUG=289715
>
> Committed: https://crrev.com/aec005dce78bc2c2513f4e49343b8baad751a852
> Cr-Commit-Position: refs/heads/master@{#310822}

TBR=mmenke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=289715

Review URL: https://codereview.chromium.org/907033002

Cr-Commit-Position: refs/heads/master@{#315298}

They can already do the same via the new user manager.

Also, allow child users to edit their name via about:settings -> Edit. Same reason.

BUG=456744

Review URL: https://codereview.chromium.org/872263005

Cr-Commit-Position: refs/heads/master@{#315297}

BUG=437566

Review URL: https://codereview.chromium.org/900203003

Cr-Commit-Position: refs/heads/master@{#315296}

BUG=436912

Review URL: https://codereview.chromium.org/770563003

Cr-Commit-Position: refs/heads/master@{#315295}

BUG=453704
TEST=place small image on Drive and Downloads, and check if the thumbnail box/circle
is filled in grid view and list view.

Review URL: https://codereview.chromium.org/904393003

Cr-Commit-Position: refs/heads/master@{#315294}

Move the chrome.documentScan extension API from chrome/ to extensions/.

BUG=455695

Review URL: https://codereview.chromium.org/899523004

Cr-Commit-Position: refs/heads/master@{#315293}

BUG=456547

Review URL: https://codereview.chromium.org/906223003

Cr-Commit-Position: refs/heads/master@{#315292}

BUG=302040
TBR=earthdok@chromium.org

Review URL: https://codereview.chromium.org/899973006

Cr-Commit-Position: refs/heads/master@{#315291}

mojo redefines ArraySizeHelper in the mojo namespace. When arraysize is used
in the mojo namespace, with both version in scope, the compiler, on android, is complaining that the reference is
not unique. To prevent this, qualify the usage of ArraySizeHelper in
base/macros.h

Review URL: https://codereview.chromium.org/804023002

Cr-Commit-Position: refs/heads/master@{#315290}

Design doc: https://docs.google.com/document/d/1Ms5wHyGtVzdH0MOF46olgnTj4k9opQGYzMSrk-LJckM

Based on fhorschig's https://chromereviews.googleplex.com/108977013/

BUG=443606

Review URL: https://codereview.chromium.org/769153007

Cr-Commit-Position: refs/heads/master@{#315289}

Convert webstorePrivate functions from ChromeAsyncExtensionFunction (which is deprecated) to UIThreadExtensionFunction.

Review URL: https://codereview.chromium.org/885443010

Cr-Commit-Position: refs/heads/master@{#315288}

Now that we're setting the 'skip_zero_click' flag in 'notifySignedOut',
we ought to respect it when generating the list of items for 'request()'

BUG=450581
R=vabr@chromium.org, vasilii@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/896803003

Cr-Commit-Position: refs/heads/master@{#315287}

Current implementation causes same multiple listeners wait for an event after we load page several times. E.g. in ChromeOS: add user->cancel->add user. After login we get multiple identical messages.

BUG=426316
TEST=manual

Review URL: https://codereview.chromium.org/905653003

Cr-Commit-Position: refs/heads/master@{#315286}

It should not be necessary to declare this variable at the top of this
gyp file. If it is necessary to declare this variable, this is not the
place to declare it anyway (which also looks pretty random).

BUG=None
TEST=components_unittests
R=blundell@chromium.org

Review URL: https://codereview.chromium.org/866553004

Cr-Commit-Position: refs/heads/master@{#315285}

 * Prefetch metadata before entries are added to file list.
 * Notify the cache of entry changes.

BUG=410766
TEST=None

Review URL: https://codereview.chromium.org/904003002

Cr-Commit-Position: refs/heads/master@{#315284}

BUG=402344
TEST=select some items, drag the separator for navigation list, and check that the 'n files selected' label is synced with the separator's position.

Review URL: https://codereview.chromium.org/904403002

Cr-Commit-Position: refs/heads/master@{#315283}

Revert of Copy the contents of the ASan/Win blacklist to work around http://llvm.org/PR22431 (patchset #2 id:20001 of https://codereview.chromium.org/886073003/)

Reason for revert:
r315281 rolls ASan/Win past LLVM r228156, which includes the fix for PR22431

Original issue's description:
> Copy the contents of the ASan/Win blacklist to work around http://llvm.org/PR22431
>
> BUG=454283
>
> Committed: https://crrev.com/7949a66919a6d288451e3a818a843ea39025bd74
> Cr-Commit-Position: refs/heads/master@{#314139}

TBR=glider@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=454283

Review URL: https://codereview.chromium.org/904413003

Cr-Commit-Position: refs/heads/master@{#315282}

This should fix issue 453209 and give better diagnostics for issue 452788

BUG=453209,452788,345874
TBR=rnk@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/908763003

Cr-Commit-Position: refs/heads/master@{#315281}

R=vabr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/913433002

Cr-Commit-Position: refs/heads/master@{#315280}

Revert of Revert of Roll android_tools f6e2370:2a860d8 (patchset #1 id:1 of https://codereview.chromium.org/890633003/)

Reason for revert:
Builders now updated

Original issue's description:
> Revert of Roll android_tools f6e2370:2a860d8 (patchset #2 id:20001 of https://codereview.chromium.org/900273003/)
>
> Reason for revert:
> Builders now updated
>
> Original issue's description:
> > Roll android_tools f6e2370:2a860d8
> >
> > This rolls in an update to android_tools.gyp that provides targets for
> > Google Play Sevices libraries.
> >
> > BUG=450675
> >
> > Committed: https://crrev.com/f092ee226ac530125fb580485fc45765330f1a1d
> > Cr-Commit-Position: refs/heads/master@{#315037}
>
> TBR=mcilroy@chromium.org,rmcilroy@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=450675

TBR=mcilroy@chromium.org,rmcilroy@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=450675

Review URL: https://codereview.chromium.org/908843002

Cr-Commit-Position: refs/heads/master@{#315279}

BUG=450356
R=blundell@chromium.org, jamesr@chromium.org

Review URL: https://codereview.chromium.org/904443003

Cr-Commit-Position: refs/heads/master@{#315278}

Revert of DumpWithoutCrashing() if URLRequestHttpJob is killed while waiting for callback (patchset #1 id:1 of https://codereview.chromium.org/892413007/)

Reason for revert:
Remove DumpWithoutCrashing() from URLRequestHttpJob again.

See crbug.com/432398 for stacktraces uncovered by this.

Original issue's description:
> DumpWithoutCrashing() if URLRequestHttpJob is killed while waiting for callback
>
> BUG=432398
>
> Committed: https://crrev.com/cb3d31dcc6d70edcf3f53e028fe9ec650f228c64
> Cr-Commit-Position: refs/heads/master@{#315052}

TBR=mmenke@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=432398

Review URL: https://codereview.chromium.org/906223002

Cr-Commit-Position: refs/heads/master@{#315277}

Cr-Commit-Position: refs/heads/master@{#315276}

Since the scores come from an external service, they should be forced
into the [0, 1] range, instead of assuming they are in that range. (We
cannot accept any arbitrary score, because then that would allow the
service to prioritize its results over other services, and would also
break the "known results" prioritization scheme.)

BUG=456641

Review URL: https://codereview.chromium.org/906133003

Cr-Commit-Position: refs/heads/master@{#315275}