- 23 Feb, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/430754bfeef4..95d566bd360a Created with: gclient setdep -r src-internal@95d566bd360a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891734 TBR=mmoss@chromium.org Change-Id: If304064470522be0714fdf1ea0af649e2ed0ee04 Reviewed-on: https://chromium-review.googlesource.com/c/1484932Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634923}
-
Kenneth Russell authored
These are test-only, aren't easily changeable, and violate some strictness rules. Bug: 935033 Tbr: thakis@chromium.org Change-Id: I0c1c18c2a56e3331bc709458109035224b6eb157 Reviewed-on: https://chromium-review.googlesource.com/c/1484820 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#634922}
-
David Black authored
Previously all Assistant notifications were Message Center notifications. Now, we'll support notifications of type: - kInAssistant - kPreferInAssistant - kSystem The |kInAssistant| and |kPreferInAssistant| types are currently only used to support timer notification UX requirements. Still TODO: Entry/exit animations for in-Assistant notifications. Bug: b:118654460 Change-Id: I815789d89008ff55318d7b6e8c9492b07849f2ca Reviewed-on: https://chromium-review.googlesource.com/c/1480549Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#634921}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c08d404a452b..73f6992d3486 git log c08d404a452b..73f6992d3486 --date=short --no-merges --format='%ad %ae %s' 2019-02-23 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@73f6992d3486 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ibe067ea53c6b2d855a8696fa62d8fcde6c2be173 Reviewed-on: https://chromium-review.googlesource.com/c/1484933Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634920}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/36e541ccbf9f..7853b2e32350 git log 36e541ccbf9f..7853b2e32350 --date=short --no-merges --format='%ad %ae %s' 2019-02-23 thestig@chromium.org Improve parameter validation for AFPercent_Format(). Created with: gclient setdep -r src/third_party/pdfium@7853b2e32350 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iebb50407bdcbba8044948d22d218d2384dfb4d4f Reviewed-on: https://chromium-review.googlesource.com/c/1484931Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634919}
-
Ryan Sturm authored
This CL adds the same logic used by HTTPS server previews to the URLLoader implementation. Bug: 921743 Change-Id: If283aafe242e86ebe920a8e8d15979100512eeb6 Reviewed-on: https://chromium-review.googlesource.com/c/1474807Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#634918}
-
Ryan Sturm authored
I've made the callback more in line with the specific update. I suspect that the problem is other hints are being fed in slightly earlier than the update from the tests. This makes sure the callback is tied to the correct update. Bug: 932913 Change-Id: I5f23a5321a555c925e29b9e08d50ab99afdeb5bf Reviewed-on: https://chromium-review.googlesource.com/c/1484087 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#634917}
-
Michael Spang authored
Revert "Wait for synthetic input to be dispatched to child frames before running completion callbacks" This reverts commit a41d6f40. Reason for revert: Client-facing breakage of devtools touch injection API, b/125356100 Original change's description: > Wait for synthetic input to be dispatched to child frames before running completion callbacks > > When the SyntheticGestureController finishes sending events, it checks > whether the main frame has any pending input before running completion > callbacks. However, in the presence of OOPIFs the input events could > still be waiting for an async hit test or being processed in a child > frame. In either case, the SyntheticGestureController considers the > gesture to have completed even though input events are still being > processed. > > We now check whether such pending input events exist before considering > the synthetic gesture complete. > > Also, for tests that were relying on the SyntheticGestureController to > immediately complete a gesture while input is still being processed, we > introduce an explicit mechanism in the SyntheticGestureController to do > this. > > Bug: 931723 > Change-Id: I6615d81d636e13bf9119024e0427b92e53cc32ec > Reviewed-on: https://chromium-review.googlesource.com/c/1471021 > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Auto-Submit: Kevin McNee <mcnee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634425} TBR=avi@chromium.org,bokan@chromium.org,tdresser@chromium.org,mcnee@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 931723 Change-Id: I60f7f0d9bb9583287068b8bb77b5d73779f205ac Reviewed-on: https://chromium-review.googlesource.com/c/1484584Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#634916}
-
Aleks Totic authored
Reland of https://chromium-review.googlesource.com/c/chromium/src/+/1476087 virtual/.../abspos-containing-block-outside-spanner.html would Fail instead of Crash on some bots. Bug: 934972 Change-Id: Ie715c8676e09ab29e89452da1b98a8ec606dc8fd Reviewed-on: https://chromium-review.googlesource.com/c/1484776 Auto-Submit: Aleks Totic <atotic@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#634915}
-
Gayane Petrosyan authored
Light mode ---------- No background - https://screenshot.googleplex.com/DBg230Pi5BA.png No background, hover - https://screenshot.googleplex.com/FqU3UfCbScw.png With background - https://screenshot.googleplex.com/gextKqtM3bY.png With background, hover - https://screenshot.googleplex.com/72NMpGkGtTJ.png Light theme - https://screenshot.googleplex.com/4tNXGME7Wie.png light theme, hover - https://screenshot.googleplex.com/VNYBFvE08Gq.png dark theme - https://screenshot.googleplex.com/8toJiFh1cbg.png dark theme, hover - https://screenshot.googleplex.com/7kY9NyccZMd.png Dark mode ---------- no background - https://screenshot.googleplex.com/akKjHncFGLk.png no background, hover - https://screenshot.googleplex.com/TdZLxLLiuXB.png with background - https://screenshot.googleplex.com/zmjFnx6A4eV.png with background, hover - https://screenshot.googleplex.com/0KBwQ28xfus.png light theme - https://screenshot.googleplex.com/dN0zXD926y7.png light theme, hover - https://screenshot.googleplex.com/j8ENPmWvnzc.png dark theme - https://screenshot.googleplex.com/0qQo9DqbsDf.png dark theme, hover - https://screenshot.googleplex.com/NfknL86evhJ.png rtl - https://screenshot.googleplex.com/0ZkxOFO37UN.png Bug: 867759 Change-Id: Ib01776e6c0af2c8bd56a1f21bd1d4f1e430794f3 Reviewed-on: https://chromium-review.googlesource.com/c/1472254Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#634914}
-
Theresa authored
When the accessibility state is changes, touch exploration state doesn't immediately update. We also need to reset when touch exploration state changes. BUG=934158, 934153 Change-Id: If14cb07fde915395fd15ff7b9cefbb853a8786ca Reviewed-on: https://chromium-review.googlesource.com/c/1484777 Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#634913}
-
Kenneth Russell authored
They're failing for mysterious reasons with no good explanation on the Windows/NVIDIA bots, blocking the win_optional_gpu_tests_rel trybot. Until this can be diagnosed next week, leave them running on the Win/Intel and Win/AMD bots. Bug: 935060 Tbr: jmadill@chromium.org No-Try: True Change-Id: I48b71f7ae3989990862ba15d7e55f97c99a2672f Reviewed-on: https://chromium-review.googlesource.com/c/1484588 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#634912}
-
bsheedy authored
Adds a note to the Android RenderTest documentation requesting that users provide links to the test results that they got the updated goldens from when putting a CL up for review. This is so that reviewers can confirm that the changes to the goldens are acceptable. TBR=peconn@chromium.org Bug: 928379 Change-Id: I250b903408c48349c20f4b8f1adc0bb910bb5ac7 Reviewed-on: https://chromium-review.googlesource.com/c/1484773Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#634911}
-
Kristi Park authored
Bug: 935027 No-try: True No-presubmit: True Change-Id: Ib8df01b072da8083da492538f3ef232a45fed004 Reviewed-on: https://chromium-review.googlesource.com/c/1484858Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#634910}
-
Bruce Dawson authored
Many of the grit presubmits fail on Windows. This fixes one of them by replacing a hard-coded Linux path with os.path.join. Change-Id: I1e2944f617369efa13bc64dc6e4163d38c12e490 Reviewed-on: https://chromium-review.googlesource.com/c/1484812 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#634909}
-
Jenny Zhang authored
Bug: 924776,934565 Change-Id: Icc39b20b0fd819ef0c3551bb82cf230758a6a20b Reviewed-on: https://chromium-review.googlesource.com/c/1481079 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#634908}
-
Kristi Park authored
This reverts commit 5a2d4909. Reason for revert: Suspect for failing unit_tests, https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/20476 Original change's description: > Changes to include fast app reinstall in chrome://flags. > > Bug: 911427 > Change-Id: Ic33fd7507d36d0e847598722067ce64802718f9e > Reviewed-on: https://chromium-review.googlesource.com/c/1484391 > Reviewed-by: Jenny Zhang <jennyz@chromium.org> > Commit-Queue: Rob Schonberger <robsc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634884} TBR=jennyz@chromium.org,robsc@chromium.org Change-Id: I69637a4f4064131eedf57f18f9a27769cf70a4f9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 911427 Reviewed-on: https://chromium-review.googlesource.com/c/1484587Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#634907}
-
Robert Sesek authored
MessagePumpKqueue is a WatchableIOMessagePumpPosix capable of watching FDs, like the MessagePumpLibevent it is replacing (note that Libevent is still used on other POSIX systems). However MessagePumpKqueue can also watch Mach port receive rights for notification of new Mach messages, which libevent cannot do. The underlying wait primitive for both is a kqueue, so the performance characteristics are expected to be similar. MessagePumpLibevent uses a pipe as as the ScheduleWork signal source, while MessagePumpKqueue uses a Mach port, so MessagePumpKqueue will consume two fewer FDs per instance. Bug: 932175 Change-Id: I84765a95865d6c9c74053b0fd291035b0bf6d2e1 Reviewed-on: https://chromium-review.googlesource.com/c/1481621 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#634906}
-
Bruce Dawson authored
This reverts commit b7c41be9 now that we don't need to work around the VC++ bug. Bug: 934323 Change-Id: Id11aeb70bede1144d1ee5f6d354f65239c3e114a Reviewed-on: https://chromium-review.googlesource.com/c/1484355 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#634905}
-
Xianzhu Wang authored
When a chunk's effect escapes the layer's effect, abort SwitchToEffect instead of continuing. This works around the issue and renders correct in some cases. In other rarer cases, we just don't fail DCHECK. CompositeAfterPaint doesn't have the issue. Bug: 932476 Change-Id: I8792f08ccb1f84f70d317f6a560ed6b650ee466e Reviewed-on: https://chromium-review.googlesource.com/c/1484671 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#634904}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/298f2cf820df..d7f7a3eb92a4 git log 298f2cf820df..d7f7a3eb92a4 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 vadimsh@chromium.org [lucicfg] Bump lucicfg version 1.2.0 -> 1.3.2. Created with: gclient setdep -r src/third_party/depot_tools@d7f7a3eb92a4 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I711934823b57ae02ff4b06bc0b7836f7ca776b20 Reviewed-on: https://chromium-review.googlesource.com/c/1484612Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634903}
-
James Cook authored
The <div> wrappers for the icon were inheriting text height properties, which are too tall in Arabic and when "Font Size" is "Very large". Bug: 919059 Change-Id: Ic66d3b3194ed0060f8c1695825a9796195fbf1f6 Reviewed-on: https://chromium-review.googlesource.com/c/1484499 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#634902}
-
Khushal authored
We currently assume that a path will always serialize to a non-zero size, and so we should always get a valid path at deserialization. But SkPath may return a zero size indicating that the given path can not be serialized. Account for that and just bail out serializing this path. R=enne@chromium.org Bug: 924042 Change-Id: I467003ea90efd5915b24b032d079bde2c3c5cacd Reviewed-on: https://chromium-review.googlesource.com/c/1481084 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#634901}
-
Xianzhu Wang authored
They occasionally timeout (1/10 ~ 1/20) on the bots, perhaps because of the multiple synchronized window resizes. Bug: 919789 Change-Id: I748b7362172b0ac407242e8236ae3ef937384f07 Reviewed-on: https://chromium-review.googlesource.com/c/1484732Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#634900}
-
Ryan Sturm authored
Fix here: https://chromium-review.googlesource.com/c/chromium/src/+/1483941 Bug: 934955 Change-Id: Ia5c8723d5fadaae39ab86d871babe17852a9a5b6 Reviewed-on: https://chromium-review.googlesource.com/c/1483875 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#634899}
-
Dan Beam authored
Screenshots: https://imgur.com/a/YU4O6hJ Bug: 871850,926629 Change-Id: I9326518bcaca9206a509b1a8367563f56e3698d2 Reviewed-on: https://chromium-review.googlesource.com/c/1468823 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#634898}
-
rajendrant authored
This CL plumbs OnComplete to DRP url loader throttle to act on the net errors. Bug: 934293 Change-Id: I31bf231c80ab96e712f5a3e0a50314ec22cbb1d6 Reviewed-on: https://chromium-review.googlesource.com/c/1483735 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#634897}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d2b61f7238c1..430754bfeef4 Created with: gclient setdep -r src-internal@430754bfeef4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If11eeb37407b3c8b6a0325674e56463e6138109f Reviewed-on: https://chromium-review.googlesource.com/c/1484571Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634896}
-
Peter Kotwicz authored
This CL fixes a bug introduced by http://crrev.com/95ad83cedf394b9b37a8b3ab151116918b8f64ec where the first run experience would show twice for Maps Go -> the lightweight FRE launched by WebappLauncherActivity and the full FRE launched by AsyncInitializationActivity. This CL is a partial revert of the CL. This CL is simple so that it can be potentially merged back. The "proper" fix is at https://chromium-review.googlesource.com/c/chromium/src/+/1478460 BUG=932505 TEST=FirstRunIntegrationUnitTest.testUserAcceptedLightweightFreLaunch Change-Id: Ic42adfe40eeaf03349ff838d52ee1e99c59f866e Reviewed-on: https://chromium-review.googlesource.com/c/1476321Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#634895}
-
Kenneth Russell authored
Has recently become a bit more flaky (2-3 failures per day) for unexplained reasons. Bug: 934545 No-Try: True Change-Id: I3d185481981c3840459d2d9abb385d8decb16731 Tbr: ericrk@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1483832 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#634894}
-
Sky Malice authored
Both the Feed and the host have redundant tracking of several fields. The scheduler is forced into this because it needs to know some of these outside of when ShouldSessionRequestData() is called. However, when this method is called, we get authoritative versions of them from the Feed library. This change adds synchronization logic to copy the Feed's version of has content to the scheduler. Additionally, the synchronization logic around outstanding requests is updated to go both ways. Previously it only copied the being set state over, and assumed the other direction wouldn't happen. This change was made because we're trying to reduce the number of assumptions we are making and measure things direction. Also added metrics around syncing these two values. Bug: 908963 Change-Id: I47303421d656e5c714e0a4e346e27ee8168bdfb8 Reviewed-on: https://chromium-review.googlesource.com/c/1480650 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#634893}
-
Jarryd authored
This is a reland of d82ad3d0 In the original CL, QuotaManager was modified in two ways: 1. Added SequenceChecker 2. Remove custom deleter and inherit RefCountedDeleteOnSequence In the reland, I split out the latter into a separate CL and this CL only adds SequenceChecker to QuotaManager. This was done to minimize the impact of a potential revert. RefCountedDeleteOnSequence CL: https://crrev.com/c/1481591 Original change's description: > Quota: Add SequenceChecker to QuotaManager > > Change-Id: I7caa60bf82fdcd63469d58afa0e29f893795ae32 > Reviewed-on: https://chromium-review.googlesource.com/c/1457000 > Commit-Queue: Victor Costan <pwnall@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#631891} Change-Id: Ia6076d9076e0e0f646b4286a8533ca0a964e3903 Reviewed-on: https://chromium-review.googlesource.com/c/1479302 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#634892}
-
Kristi Park authored
This reverts commit 12c3b65c. Reason for revert: Suspect for failing PowerPolicy browser_tests, https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/20473 Original change's description: > [Power ML] Change UserActivityPrediction flag to enabled > > Bug: 862461 > Change-Id: I624d39293e50754629b3b30990828af73f57f0b3 > Reviewed-on: https://chromium-review.googlesource.com/c/1482281 > Reviewed-by: Dan Erat <derat@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Jia Meng <jiameng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634856} TBR=derat@chromium.org,holte@chromium.org,jiameng@chromium.org Change-Id: Ic6cee677470af06e5ef5de8d362a2978a37291c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862461, 935044 Reviewed-on: https://chromium-review.googlesource.com/c/1484821Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#634891}
-
Tim Volodine authored
The user agent is not necessarily set in the request headers during InterceptDownload (e.g. because they are not initialized yet). In this patch: - make sure a user agent is set in the case of uninitialized headers. - make sure the user agent override is used when it is set by using WebSetting.setUserAgentString(). - add download related instrumentation tests for the user agent setting. Tests: - AwContentsTest.testDownload - AwContentsTest.testDownloaWithCustomUserAgent BUG=893568,841556 Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: Ifc432fd93dd68ffb7416a25b6d6d1b5d1021e327 Reviewed-on: https://chromium-review.googlesource.com/c/1477606 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#634890}
-
Chris Cunningham authored
Initialize temporary values, check return values. Small tweaks to solution proposed by adtolbar@microsoft.com. Bug: 929962 Change-Id: Iaa7da7534174882d040ec7e4c353ba5cd0da5735 Reviewed-on: https://chromium-review.googlesource.com/c/1481085 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#634889}
-
Bruce Dawson authored
This reverts commit 90aef9d9 now that we don't need to work around the VC++ bug. The structure definition move enough that git couldn't actually do the revert but the four remaining struct members had 'const' manually reapplied. Bug: 934323 Change-Id: I605de24decdf24aae4ccbe7af31a44013f21ae7e Reviewed-on: https://chromium-review.googlesource.com/c/1483949 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#634888}
-
Shakti Sahu authored
Bug: 931135 Change-Id: I0358a80dfd25ef009a93703663f6170160586e51 Reviewed-on: https://chromium-review.googlesource.com/c/1483359Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#634887}
-
Matt Menke authored
This CL makes it so that the events for nested ConnectJobs are nested within their parent ConnectJob. This both reduces the number of top level CONNECT_JOB events in logs, making navigation between top-level events easier, and makes it easier to see all information related to establishing a single connection at once. This didn't used to be possible because there was a socket pool between nested ConnectJob classes, which introduced a layer of late binding. However, most of those intermediary socket pools have been removed, so the events can now be nested directly, for the most part. Bug: 926899 Change-Id: I7d51ae9e164560fdb0396f21b0ac85370c4b7ae7 Reviewed-on: https://chromium-review.googlesource.com/c/1478259Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#634886}
-
Alexei Svitkine authored
The command-line flag would turn off UMA, so as not to bias server- side data. But this had the consequence of changing how all field trials are randomized (causing the low entropy source to be used), which would cause unintended side-effects and in particular make it very hard to effectively debug trial behavior. This change updates the logic so that specifying that flag does not change the state of UMA consent, but instead changes the state of UMA reporting. This way, field trials are still randomized the same way, but UMA data is not reported. Includes a unit test. Bug: 932273 Change-Id: I4216bb23a9784d963f30d0e2516e1e4d31784ab7 Reviewed-on: https://chromium-review.googlesource.com/c/1479632Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#634885}
-
chrome://flagsRob Schonberger authored
Bug: 911427 Change-Id: Ic33fd7507d36d0e847598722067ce64802718f9e Reviewed-on: https://chromium-review.googlesource.com/c/1484391Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#634884}
-