- 16 Nov, 2019 29 commits
-
-
Kenichi Ishibashi authored
These are no longer used. Bug: N/A Change-Id: I94875f7a7145751b8934c36cce8460ed1f36302f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919429 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#715956}
-
Wei-Yin Chen (陳威尹) authored
Run StartSurfaceLayoutTest on more bots to see if the deflaking efforts work. TBR=meiliang@chromium.org Bug: 1023833 Change-Id: I554c82b0c02d90d6cf5770678e1eae47ee779ee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917959Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#715955}
-
Koji Ishii authored
Because we're replacing |NGPaintFragment| by |NGFragmentItem|, this patch moves |is_layout_object_destroyed_| flag to |NGPhysicalFragment| by clearning its |layout_object_| to |nullptr|. Though |NGPhysicalFragment| is immutable, keeping a pointer to a destroyed object isn't good for anything. Note, this is done only for inline |LayoutObject| as it is called through |NGPaintFragment| today. We may revisit this in future. Bug: 982194 Change-Id: If89881cd9493526307106345db0549c0e9c8a6fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914580 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#715954}
-
chrome://downloadsDemetrios Papadopoulos authored
The test was loading chrome://downloads only so that loadTimeData is initialized, but that's unnecessary and causes this test to break when chrome://downloads is ported to Polymer3. Bug: 1022215 Change-Id: Icea9f16913b1e9f9d8154f5cc1242004218cfb2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919569Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#715953}
-
rbpotter authored
Run clang-format on the contents of: chrome/browser/resources/print_preview chrome/test/data/webui/print_preview now that the CL to update Print Preview to Polymer 3 has been landed for a few days. Bug: 1012574 Change-Id: I33259a39047cf20c3fa999b19217f37f96e8d952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918660Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#715952}
-
Matt Wolenetz authored
Expands disablement of these tests from previous win-dbg, to all win, due to new flakiness observed on Win7 (32) Tests builder. BUG=1025411 TBR=yangguo@chromium.org Change-Id: I7f18d369f21a3810abb24993e2772a09f1b8aa44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919950Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#715951}
-
Aran Gilman authored
Bug: 1025299 Change-Id: I4505e1c0c62c85b6a3418044ea913d29f56e683d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918380Reviewed-by:
-
Allen Bauer authored
Bug: 1023840 Change-Id: I2a0cdf65c32ee6e48f0adee37d0f0a214e7d9a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919322 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#715949}
-
Esmael El-Moslimany authored
https://chromium-review.googlesource.com/c/chromium/src/+/1906962 changed the CSS variables in cr-icon-button to not have as many fallbacks. The result was the cr-toolbar CSS that set the focus color for all cr-icon-button's within it no longer worked as before when the --enable-features=WebUIA11yEnhancements flag is set. This CL fixes that. Bug: 1022752 Change-Id: I671e5664c5fcae7f311e409fa54b645e78f20132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916965Reviewed-by:
-
Joe Mason authored
This lets tests mock just the reporter launch step without overriding the reset of the logic in LaunchAndWaitForExit. This will be used in an upcoming unit test to test reporter process termination. Also cleans up some code in the reporter_runner_win.cc file: * Renames LaunchAndWaitForExitOnBackgroundThread to LaunchAndWaitForExit since OnBackgroundThread is confusing, and exposes it for testing. * Renames SwReporterTestingDelegate::LaunchReporter to LaunchReporterProcess and only doubles the launch step. * Adds SwReporterTestingDelegate::WaitForReporterExit that doubles the wait step and returns the process exit code. * Moves test support classes and functions into the "internal" namespace. * Moves ReporterRunner, which is internal to the .cc file, to the "internal" namespace so it doesn't pollute the safe_browsing namespace. R=proberge Bug: 1016939 Change-Id: I4f090f15cc40821b3faa83d820e6703f6de41fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912804 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#715947}
-
Alex Ilin authored
base::SharedMemoryHandle is deprecated and will be removed soon. Bug: 795291 Change-Id: Iacce3af560cacc3baafaf401c6e1273141ae7a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919156 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715946}
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /components/feature_engagement This CL was uploaded by git cl split. R=dtrainor@chromium.org Bug: 1018667 Change-Id: Ic7b64d20d6fd796de890a3a069af4385df8bb28c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917523 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#715945}
-
arthursonzogni authored
delete: third_party/blink/public/mojom/csp/* third_party/blink/public/mojom/csp/OWNERS third_party/blink/public/mojom/csp/README.md third_party/blink/public/mojom/csp/content_security_policy.mojom blink::mojom::ContentSecurityPolicyType is moved to: network::mojom::ContentSecurityPolicyType in: services/network/public/mojom/content_security_policy.mojom This is a prerequisite to step 1.g from UnifyCSP document: https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao/edit# The goal is to mojoify FrameMsg_AddContentSecurityPolicies TBR=fdoray@chromium.org Bug: 1021462 Change-Id: If5a222f3a62659162eb5d1b46fba780f862f160a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906668Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#715944}
-
Victor Hsieh authored
Also removed unused icon files. Test: image looks good Bug: chromium:893332 Change-Id: I7859dfac9086add5c21ccc2e907170d62a727c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918830 Auto-Submit: Victor Hsieh <victorhsieh@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Victor Hsieh <victorhsieh@chromium.org> Cr-Commit-Position: refs/heads/master@{#715943}
-
Koji Ishii authored
This patch supports painting self-painting |LayoutInline| when FragmentItem is enabled. To do this, |NGBoxFragmentPainter| accepts an |NGInilineCursor| that can traverse all descendants to paint. Reveals 20 accidental passes, fixes 25. There should be more fixes, the logic isn't correct for all cases yet. Bug: 982194 Change-Id: I459acf85d38314c1ad6810ccc04dae1e0ce8e628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912379 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Nate Fischer authored
https://crrev.com/c/1900613 implemented logic to wake up the MetricsService in a similar fashion to how Chrome does. However, since this is likely to increase the UMA volume, this CL puts the behavior behind an off-by-default flag for the time being. The intention is to enable this by Finch so we can compare metrics volume with the experiment enabled, and we can enable at 100% if the increase in volume is acceptable. This doesn't add a test for the feature-disabled case, because such a test would need to verify further metrics logs don't happen (which would require waiting indefinitely). Bug: 1003204 Test: run_webview_instrumentation_test_apk -f AwMetricsIntegrationTest.testPageLoadsEnableMultipleUploads Test: Manually verify further logs don't seem to happen with feature off Change-Id: Ifeca0176134224030625d5117da4eaec5103eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919725Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#715941}
-
Daniel Cheng authored
This is a prerequisite for migrating more things over to base::FastHash, to ensure they don't inadverdently have a dependency on a stable mapping of inputs to hash values. Also change the FastHash(const std::string&) overload to FastHash(StringPiece) to avoid potentially constructing unnecessary temporaries. Bug: 1025358 Change-Id: I2e3d67ab74f869437ae2bdf12c9560f1be19688d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919804Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#715940}
-
Boris Sazonov authored
Removes unused Activity param from SigninManager.signIn. The last usage of this param was removed by https://crrev.com/c/1823078. Bug: None Change-Id: Ic43ae1028cb50529224c904a1917ca09dc4540a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913702Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#715939}
-
Lambros Lambrou authored
This updates host code to reference the IT2Me bundle name from branding_Chrome instead of hardcoding it. Bug: 1015201 Change-Id: Ib3738b3716d5457fdc9a6812027ad2b468fbcf4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919905 Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#715938}
-
Miyoung Shin authored
This CL converts TestRunner mojom interface client in chrome to use BrowserInterfaceBroker and introduces WebUITestContentBrowserClient class and overrides ChromeContentBrowserClient::RegisterBrowserInterfaceBindersForFrame to register its binder. This change also updates JS files in closure_compile for Mojo bindInterface and interface_definition.tmpl for WebUI tests. Bug: 1006361, 1002647 Change-Id: Id830ef957eeb8b33ee47ff22918cb98b5c7f6650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900798Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#715937}
-
Xing Liu authored
This preference controls whether to popup download location dialog, should be synced. Bug: 1024400 Change-Id: Ic31c7a338ecded3833022badf7ffb8e03ab7e453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918659Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1496758da42e..c9dcd09f24db git log 1496758da42e..c9dcd09f24db --date=short --no-merges --format='%ad %ae %s' 2019-11-15 herb@google.com Add last() to SkZip 2019-11-15 michaelludwig@google.com Revert "Replace GrTextureDomainEffect with GrDomainEffect." 2019-11-15 michaelludwig@google.com Revert "fix issue introduced in f29caf1433e3185df01b4a286d0fc9715ad32ae2" 2019-11-15 reed@google.com Expose the owning surface to a canvas? 2019-11-15 robertphillips@google.com Make GrProgramInfo take pointers to the GrPipeline and the GrPrimitiveProcessor 2019-11-15 kjlubick@google.com [canvaskit] Fix primitive_shaper build 2019-11-15 reed@google.com trim out unneeded references to SkString 2019-11-15 reed@google.com Ummm, why are we including SkUTF.h? 2019-11-15 robertphillips@google.com Add ClockwiseTestOp::onPrePrepare 2019-11-15 kjlubick@google.com [canvaskit] Expose more SkParagraph methods 2019-11-15 kjlubick@google.com [canvaskit] Add MatrixTransform ImageFilter 2019-11-15 borenet@google.com [infra] Fix bin/try 2019-11-15 bsalomon@google.com fix issue introduced in f29caf1433e3185df01b4a286d0fc9715ad32ae2 2019-11-15 csmartdalton@google.com Reland "Reland "Reland "Reland "Implement sample mask and sample locations support in Vulkan"""" 2019-11-15 robertphillips@google.com Reduce max # of AA Quads that can be merged or chained into a single GrTextureOp (take 2) 2019-11-15 reed@google.com remove unused (by clients) SkMultiPictureDraw 2019-11-15 bsalomon@google.com Replace GrTextureDomainEffect with GrDomainEffect. Created with: gclient setdep -r src/third_party/skia@c9dcd09f24db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: chromium:b/143572065 Change-Id: I09091abe0f876d6dd7e1dde97e7288cfff5bb3e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919919Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715935}
-
Theresa Wellington authored
Change-Id: If6f0907355aee9b1a9f24abef12b5f479ef36471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919899 Commit-Queue: Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#715934}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/46689b09c559..bb45734988bb git log 46689b09c559..bb45734988bb --date=short --no-merges --format='%ad %ae %s' 2019-11-15 apolito@google.com Changed "gclient sync -D" logic to compare against the expected DEPS version Created with: gclient setdep -r src/third_party/depot_tools@bb45734988bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:981149 Change-Id: Ib329df4123c9823d908434bfc2be4884eaf63eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919489Reviewed-by:
-
Stephen Roe authored
This helps to standardize the environment for the Fuchsia VM. In particular, it prevents tests from running on build41-b4 which is not set up to run Fuchsia arm64 KVM tests. Bug: 1000901 Change-Id: I0030cb7dc807829404590f23cdb4a8595f93b1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918312Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#715932}
-
Min Qin authored
BUG=1003904 Change-Id: Ibce58e04c2d0fa21549ebbb060a5bcd43f9b8d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914820Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715931}
-
Jenny Zhang authored
This logs the time delay between a default play store result being activated by user pressing ENTER key and being displayed. Bug: 1016026 Change-Id: I0282e65a5dc3d80d5a848234d720dcf1e25df89a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918113Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#715930}
-
Livvie Lin authored
There was a bug where the error code and button text were incorrect on committed interstitials. The cause was that some SSLInfo fields were being updated later on in the code, so ssl_info shouldn't be set until after this is done. Bug: 987407 Change-Id: If82b15e2243ed1865e5b4d604c6aa6cebf7af9ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910845Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715929}
-
Ken Rockot authored
This reverts commit 85285a99. After further discussion, we would prefer to keep web API mojoms in Blink, per Onion Soup goals. Instead of moving mojoms to the service, we'll modularize Blink mojom targets as needed. Bug: 1000959 Change-Id: I9035be9aa19e06f4a471ec7c302ae0cfbaae26e7 Tbr: dcheng@chromium.org Tbr: dmurph@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918349Reviewed-by:
-
- 15 Nov, 2019 11 commits
-
-
Matt Jones authored
Change-Id: I936f2388c769ccec2d5ed0ae32d893cd3c1670da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917881 Auto-Submit: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#715927}
-
Garrett Beaty authored
Bug: 922150 Change-Id: Id613a8ac7fe40ada45ce589b61eb3eded89c5b5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919498 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#715926}
-
Ahmed Fakhry authored
TBR=alemate@chromium.org BUG=1025396 Change-Id: Ibb84a92a8327a097950746ce1bc9d1744ed9c527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919492Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#715925}
-
Chromium WPT Sync authored
Using wpt-import in Chromium aa63b9ce. With Chromium commits locally applied on WPT: 788a3004 "Fix failing Fetch Metadata WPT" b16db925 "[Trusted Types] Add test for duplicate names in non-enforcing mode." e83dd93c "Limit backtracking on regexp called from blink." 6e3e930c "Change `sec-fetch-mode` from `no-cors` to `navigate` for <embed> / <object>." c8b6e1ce "Chromedriver] Fix PerformAction to support multi touch points cases" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I060ec7549656a215e0f98897ba7c9fb1461efaec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917051Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715924}
-
Carlos Knippschild authored
TBR=harringtond@chromium.org Change-Id: I8204d4f809640d933ae9e0d94e1a9a3921bb01b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919742 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Auto-Submit: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#715923}
-
Martin Kreichgauer authored
Extract enums for the |dialogPage| properties of the various security key related dialogs. No functional changes. Bug: 974046 Change-Id: I3a1634a37a2e24c2a2d2a7fb9c7c17ddc8a36237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912632 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
-
Darin Fisher authored
Change-Id: I06a780bb0f4964601d64ceb27330a6e5fc27de67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919737Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#715921}
-
David Black authored
Previously, the entry point view for the Assistant proactive suggestions feature would be presented to the user as soon as possible. Now, with the addition of |show-on-scroll|, which is |ENABLED_BY_DEFAULT|, the entry point view for the feature will show/ hide in response to the user's vertical scroll activity in the source web contents. This will reduce overall triggering of the feature but hypothetically increase click through as the entry point is now being presented at a more helpful and appropriate time. Bug: b:142144655 Change-Id: I538e618af55d7ed3f0ab0480c300d9529893d03f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918662Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#715920}
-
Adrian Taylor authored
Some changes to the online HTML documentation based on discussions and external feedback. Bug: 955102 Change-Id: Ia9ad3bc0e33db17516eba5f0bd77c94ef067a26f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577845 Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#715919}
-
Robert Iannucci authored
> This is reserved for people that are comfortable with Chromium builders > and understand the implications of changing their configurations. I'm not really any of these things any more :). R=agable@chromium.org, jbudorick@chromium.org Change-Id: Ie38a25240e24a09ca87582a3a81584e3e8ca55b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919999 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
-
Matt Menke authored
It was failing with ERR_ABORTED, but this error code is only intended for user-initiated aborts, and the renderer treats it as a magic error code (cancels the navigation instead of showing an error page). Bug: 941651 Change-Id: I5968e90728994566c83df0a905dbbfbb11f4f088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913876 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#715917}
-
