- 22 Sep, 2018 40 commits
-
-
Lei Zhang authored
Reorganize: - Move NupPdfToPdf() into the anonymous namespace. - Make NupPdfToPdf() return a PDF instead of the PDF data. - Return earlier in PrintPagesAsRasterPDF(). - Make CreateSinglePageRasterPdf() return a ScopedFPDFDocument. - Put |scale_factor| in the smallest possible scope. - Group static methods together in the header. - Use "Pdf" consistently in method names. - Mark some methods const. Nits: Change-Id: I25ac995d2041990eab42391915a6736044ad6b63 Reviewed-on: https://chromium-review.googlesource.com/1238075 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#593432}
-
Ella Ge authored
remove expectations for rebaseline Bug: 737777 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If1ba264a039086ca91a4872519e5f34e1fae9591 Reviewed-on: https://chromium-review.googlesource.com/1234996Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#593431}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dc4ede78306c..de8b7f52c072 Created with: gclient setdep -r src-internal@de8b7f52c072 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia51e7b833c254edc7e4ca5150e2b0097805ed765 Reviewed-on: https://chromium-review.googlesource.com/1239739Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593430}
-
Tao Bai authored
To understand the usage of autocomplete, add metrics for - if the autocomplete is disabled in WebView by application. - if the query is triggered for the field. - if the suggestion exists for the query. Bug: 873795 Change-Id: If58836c02a78a3fe85b5d264f29417d9a7509969 Reviewed-on: https://chromium-review.googlesource.com/1187824Reviewed-by:Steven Holte <holte@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#593429}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/799da6d18c5a..55e57f96fbf8 git log 799da6d18c5a..55e57f96fbf8 --date=short --no-merges --format='%ad %ae %s' 2018-09-22 jmadill@chromium.org Remove some redundant dirty bits notifications. 2018-09-21 bryan.bernhart@intel.com ES31: Support atomic functions on D3D11 - Part III Created with: gclient setdep -r src/third_party/angle@55e57f96fbf8 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ifbb4d1e192b68d3761a69e7cf6632ca04eda7570 Reviewed-on: https://chromium-review.googlesource.com/1239735Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593428}
-
Ella Ge authored
missed Pixel_WebGLTransparentGreenTriangle_NoAlpha_ImplicitClear when rebaselining pixel tests for zoom-for-dsf TBR=kbr@chromium.org Change-Id: I439e2e3d389735e2add7a993a4b5a67df517c1a1 Reviewed-on: https://chromium-review.googlesource.com/1239476Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#593427}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/575af7ecfc21..90a12b3d4d1d git log 575af7ecfc21..90a12b3d4d1d --date=short --no-merges --format='%ad %ae %s' 2018-09-22 alanbaker@google.com Decoration validation for Vulkan memory model 2018-09-22 alanbaker@google.com Validate vulkan mem model capabilty Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@90a12b3d4d1d The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ida46ddd3a867db7a96ad07046f0a9937f34ecca1 Reviewed-on: https://chromium-review.googlesource.com/1238990Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0dc1fa046374..baf09271514c git log 0dc1fa046374..baf09271514c --date=short --no-merges --format='%ad %ae %s' 2018-09-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@baf09271514c The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I21a9cc3df3f0b41b8ca7939e203dd6661fef7ac5 Reviewed-on: https://chromium-review.googlesource.com/1239655Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8994403e..2f22d111 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I33f96a3637ec00461294c67acb3a34a06ef7c3bb Reviewed-on: https://chromium-review.googlesource.com/1239723Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593424}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/80aef02c3e0f..dc4ede78306c Created with: gclient setdep -r src-internal@dc4ede78306c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:888064 TBR=mmoss@chromium.org Change-Id: I90a010aa42ca43fcd267d8ba6aa516e18f2a66da Reviewed-on: https://chromium-review.googlesource.com/1239738Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I5dbd53b4addb170c9971034bb125363e0be6e678 Reviewed-on: https://chromium-review.googlesource.com/1239754Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#593422}
-
Peter Kotwicz authored
This CL: - Makes code in MainActivity.java more modular. - Splits HostBrowserLauncher into: - a part for selecting the host browser - a part for launching the host browser This CL is in preparation for: - Introducing a version of MainActivity.java for NewSplashWebApk.apk - Implementing the logic to determine whether to show the splash screen inside of the WebAPK or inside of Chrome. The host browser must be known in order to make this decision. BUG=817263 Change-Id: I024e390c57b4da09fe0e4e2fcbaf616c6bad2e8b Reviewed-on: https://chromium-review.googlesource.com/1220054 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#593421}
-
David Tseng authored
The Chrome channel was once used by ChromeVox to disable ChromeVox Classic (use ChromeVox Next) when in dev channel. Since ChromeVox/ChromeVox Next now ships by default everywhere, this is no longer necessary. Original change https://codereview.chromium.org/2640503002 TBR=dcheng@chromium.org Change-Id: I0b9b4f844ec5d3b40171027da5e04e0fb248eb49 Reviewed-on: https://chromium-review.googlesource.com/1239439Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#593420}
-
Matt Menke authored
The only previous way to get it was to disable cert verification. Bug: 848078 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ic14d5273a803cb53e92bbc370a16f045c86bdcca Reviewed-on: https://chromium-review.googlesource.com/1235173 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#593419}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/32261ee689fe..218f46686f2f git log 32261ee689fe..218f46686f2f --date=short --no-merges --format='%ad %ae %s' 2018-09-21 benjhayden@chromium.org Fix a bug in v2spa's setImmutable() Created with: gclient setdep -r src/third_party/catapult@218f46686f2f The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia6435354eb716e7ec8d26a3324c9f77d6b33cd87 Reviewed-on: https://chromium-review.googlesource.com/1238872Reviewed-by:
-
Yuki Shiino authored
Crash issue 887661 is happening because an iframe is detached, but the iframe is still invoking FrameRequestCallback without performing wrapper-tracing. In the repro case, callback function's realm = the parent's one, and the incumbent realm = the parent's one, however, the callback is registered on the iframe that will be detached. Thus, any check against callback function's realm and the incumbent realm does not work well in this case. This patch fixes the crash issue by checking the execution context on the call sites. Bug: 887661 Change-Id: I1fa784add95424c9ff2c2b27ed3d2edbb920068e Reviewed-on: https://chromium-review.googlesource.com/1237839Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#593417}
-
Peter Kotwicz authored
This CL changes the manifest_processor GN build rule to treat 'false' as a boolean value instead of as a string literal. This change is needed for the manifest_processor build rule to omit the 'section_name' section for the following input: BUILD.gn: manifest_processor_template(_manifest_target_name) { ... extra_variables = [ "section_name=false" ] } AndroidManifest.xml: {{#section_name}} Never shown! {{/section_name}} BUG=1220054 Change-Id: I9bf0740e0cfb8115788ec3bf8d6d0640d2c495c7 Reviewed-on: https://chromium-review.googlesource.com/1238354 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#593416}
-
Matt Menke authored
Previously it would just fail. Also fix a bug in the ERR_NOT_IMPLEMENTED failure when trying to upgrade accepted client sockets to TLS. Add tests for both cases. Bug: 848078 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ia908a7da077a14c69ae990afe19339dfa440b9a5 Reviewed-on: https://chromium-review.googlesource.com/1234226 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Matt Menke authored
This reverts commit dec72e86. Reason for revert: virtual/threaded/fast/animationworklet/worklet-animation-responsive-to-zoom.html seems to be failing most of the time on all platforms. Sample failures: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/91172 https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/146546 https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/193114 Original change's description: > [animation-worklet] Transfrom related worklet animations should respond to zoom > > Worklet animation compositing state should be updated when a zoom or viewport > resize changes css pixel to dip ratio. > > The fix is to simply match what we already do for regular animations for worklet > animations. > > TEST=virtual/threaded/fast/animationworklet/worklet-animation-responsive-to-zoom.html > > Bug: 879107 > Change-Id: I0b74bd8297e83b18afd087247f09339aedcc618b > Reviewed-on: https://chromium-review.googlesource.com/1237133 > Reviewed-by: Stephen McGruer <smcgruer@chromium.org> > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Commit-Queue: Majid Valipour <majidvp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593171} TBR=majidvp@chromium.org,smcgruer@chromium.org Change-Id: I9eaf621c931ad9003fd7413aeea9f2ec3a7824a4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 879107 Reviewed-on: https://chromium-review.googlesource.com/1239773Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#593414}
-
Dale Curtis authored
Usage is low, WebView now has a policy of unifying with Chrome, and this path represents a security risk since it provides a direct route Android MediaPlayer in the browser process instead of using the renderer sandboxed media player. Removing per discussion with webview-leads@. BUG=881997 TEST=none Change-Id: I244277eb26a7de780b61dd92c945379d800ed514 Reviewed-on: https://chromium-review.googlesource.com/1213968Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#593413}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0d9c87bf4dc0..80aef02c3e0f Created with: gclient setdep -r src-internal@80aef02c3e0f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6adad6e0b4307ae70b231c7b54e94f0f60206c83 Reviewed-on: https://chromium-review.googlesource.com/1239656Reviewed-by:
-
wutao authored
This patch adds UMA to measure assistant container view's animation smoothness. Bug: b/113942916, 887583 Test: see UMA in histograms. Change-Id: I83da71c4c0003061f5ca852a6128534a681646d3 Reviewed-on: https://chromium-review.googlesource.com/1234956Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#593411}
-
Adrienne Walker authored
This doesn't really matter, but for consistency we should set this, so that writing out the PaintShader yields the same PaintShader when reading it back. This fixes a fuzzer bug. Bug: 883217 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I25488ce92fa8259c4be9974d0fdf4422e65b60ac Reviewed-on: https://chromium-review.googlesource.com/1239544 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#593410}
-
Siddhartha authored
TBR=wittman@chromium.org BUG=859260 Change-Id: Ife938d536ca036364b20464055479e949813c75b Reviewed-on: https://chromium-review.googlesource.com/1228785 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f610bae66163..11f4994b84e1 git log f610bae66163..11f4994b84e1 --date=short --no-merges --format='%ad %ae %s' 2018-09-21 brianosman@google.com Revert "Reland "Preserve colorType and alphaType in SkImage::makeColorSpace"" 2018-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9f6c0b899ae6..c5e68abdea9e (1 commits) 2018-09-21 brianosman@google.com Cleanup SkPatchUtils, stop using SkColorSpaceXform 2018-09-21 mtklein@google.com focus exported color apis 2018-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 ab5fb5edb186..9d84ccbaf233 (1 commits) 2018-09-21 caryclark@skia.org move color4f docs to in progress 2018-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 4daedcd8c612..9f6c0b899ae6 (2 commits) 2018-09-21 brianosman@google.com Introduce SkRGBA4f, templated on SkAlphaType 2018-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader c89f75b65555..4daedcd8c612 (1 commits) 2018-09-21 halcanary@google.com Docs: update to docs from a4daf19319 2018-09-21 halcanary@google.com SK_SUPPORT_LEGACY_DOCUMENT_FACTORY: clean up part 1/2 2018-09-21 herb@google.com Regularize path cache lookup with Mask and Fallback 2018-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 2ecc8b712b08..c89f75b65555 (1 commits) 2018-09-21 jvanverth@google.com Optimize SkTriangulateSimplePolygon. 2018-09-21 robertphillips@google.com Fix Chrome iOS builder 2018-09-21 caryclark@skia.org sync color4f with docs 2018-09-21 lsalzman@mozilla.com mark SkCanvas layer device as immutable before compositing it on restore 2018-09-21 brianosman@google.com Reland "Preserve colorType and alphaType in SkImage::makeColorSpace" 2018-09-21 caryclark@skia.org doc change for getAlphaf 2018-09-21 reed@google.com Reland "add getAlphaf() to pixmap/bitmap" 2018-09-21 mtklein@google.com move skpipe to experimental 2018-09-21 kjlubick@google.com [canvaskit] Link demos to fiddles 2018-09-21 kjlubick@google.com Update lottie samples 2018-09-21 mtklein@google.com Reland "have SkConvertPixels use SkColorSpaceXformSteps" 2018-09-21 brianosman@google.com Revert "Preserve colorType and alphaType in SkImage::makeColorSpace" 2018-09-21 brianosman@google.com Work toward removing SkPM4f 2018-09-21 caryclark@skia.org shorten animation to work around fiddlecli bug 2018-09-21 bungeman@google.com Use SkUniqueCFRef in SkImage*CG. 2018-09-21 jvanverth@google.com Fix line distance issue 2018-09-21 brianosman@google.com Preserve colorType and alphaType in SkImage::makeColorSpace 2018-09-21 brianosman@google.com Set window dimensions with GetClientRect, not GetWindowRect 2018-09-21 robertphillips@google.com Add SkImage_Base API to access planar data Created with: gclient setdep -r src/third_party/skia@11f4994b84e1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:886713 TBR=reed@chromium.org Change-Id: I53fd65f7522d77b7cafeaf87380d179511e2502e Reviewed-on: https://chromium-review.googlesource.com/1239654Reviewed-by:
-
Tommy Steimel authored
This CL fixes an issue where we don't keep events in node for the audio panel. Bug: 884108 Change-Id: I039a606005b9be109c36f35a7bf33f4a77f951db Reviewed-on: https://chromium-review.googlesource.com/1239006Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#593407}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/31b2347a..8994403e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7e41650350ba10cf55a60dd111880538cda03dd4 Reviewed-on: https://chromium-review.googlesource.com/1239370Reviewed-by:
-
Stephen McGruer authored
This is an obsolete prefixed alias of AnimationEvent. An intent-to-remove has been sent, and has got LGTM*3. Blink intent thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/EgMUDqySZwE Bug: 695504 Change-Id: Ia86e830fe3f653aa6a7b2f983afb75fd4d088831 Reviewed-on: https://chromium-review.googlesource.com/1238497 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#593405}
-
Dale Curtis authored
Having different base names for the same DecoderStream template class is just confusing. Lets unify on DecoderStream name. I.e., we now have VideoDecoderStream and AudioDecoderStream respectively. Also fixes presubmit warnings around bind usage. BUG=none TEST=cq; compiles. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I660ac0c730a2654e8d6298099fed56957657c1b6 Reviewed-on: https://chromium-review.googlesource.com/1239541Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#593404}
-
rbpotter authored
(1) For cr-input: Do not apply cr row container mixin to inner div. This was done accidentally while adding the prefix slot. (2) Adjust heights/margins so that collate checkbox ripple is not cut off and collate does not cause the copies section to shift when it appears. (3) Ensure collate breaks the word if it is too large, to fix possible issues with large font sizes/languages where "collate" translates to something with a very long word. (4) Reduce checkbox padding - this helps with collate and aligns with UX request to reduce checkbox padding to as little as possible, without cutting off the ripple. (5) Add margin-top: 16 for settings sections, which allows extra padding applied to more-settings when expanded to be removed (fixes animation issue). Bug: 887837, 887839, 887704 Change-Id: I9d3a9bc468ce0ee5b4a2ecfb136233d3a1054902 Reviewed-on: https://chromium-review.googlesource.com/1239333Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#593403}
-
Kevin Marshall authored
This addresses the current crashing bug that takes place whenever popup windows are spawned, due to the fact that no WindowParentingClient exists to handle the newly spawned ui::Window. With this solution, the child windows are never spawned in the first place. * Relocated 'content' overrides to FrameImpl's private declarations. * Misc. IWYU cleanups. Bug: 888131 Change-Id: I735565047bbe4c8ebab5154a57ad323f33ef8e48 Reviewed-on: https://chromium-review.googlesource.com/1239419 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#593402}
-
Tarun Bansal authored
The field trial is enabled for Android only. Change-Id: I6ddddf15369da72b91d1e90a9d02bc9d0d61eb27 Bug: 850624 Reviewed-on: https://chromium-review.googlesource.com/1239034Reviewed-by:
-
Philip Rogers authored
When working on another patch I noticed it is deadcode. Change-Id: I248b12e2f3a5e26af91d2cab89b5b8fd3ace8dd1 Reviewed-on: https://chromium-review.googlesource.com/1239539 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#593400}
-
Pavel Feldman authored
Change-Id: Ie90437511d2eda4a5477abde80c083eeb6448db8 Reviewed-on: https://chromium-review.googlesource.com/1239248Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#593399}
-
Matt Menke authored
TCPBoundSocket now calls into TCPConnectedSocket's connect option, so that they can share connection establishment and socket configuration code. This increases code reuse and reduces code disting to TCPBoundSocket, which is also handy, as it's harder to test than TCPConnectedSocket. Also makes TCPBoundSocket take an AddressList instead of an IPEndPoint. Since it's now using TCPConnectedSocket's connect code, might as well reuse its ability to take a list of addresses to try. Bug: 848078 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I94059f08f649833db89676bde50ec8b11fbbb9b6 Reviewed-on: https://chromium-review.googlesource.com/1231740Reviewed-by:
-
Paul Miller authored
Fold AwFieldTrialCreator::DoSetUpFieldTrials into AwFieldTrialCreator::SetUpFieldTrials. The former is unnecessary since AwFieldTrialCreator no longer requires the client ID, so DoSetUpFieldTrials can no longer return early. BUG=866722 Change-Id: Ibcce988656cabe57ed142abb14efbb163e0b3fb6 Reviewed-on: https://chromium-review.googlesource.com/1238485Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#593397}
-
Andrew Luo authored
Specifics: +674,152 bytes normalized apk size +3 zip entries file count +53,920 bytes main lib size +421,832 bytes main dex size InstallSize: +254,984 bytes APK size +1,959,185.28 bytes Estimated installed size InstallBreakdown (+1,958,241.28 bytes): +2,664 bytes unwind_cfi (dev and canary only) size +1,502 bytes Non-compiled Android resources size +53,920 bytes Native code size +178 bytes Package metadata size +1,885,301.28 bytes Java code size +14,676 bytes Compiled Android resources size Dex: +2,081 entries fields +2,853 entries methods +675 entries types +1,425 entries strings Diff Summary +674152 bytes Monochrome.apk_Specifics normalized apk size for range: b2ce31d0fc200fd29fe9ef96d7e15b10f95ece4b..d9d2b25c8c55dd48b53a78cd84006100a49d0d68 I 26177577 Enter supersize console via: tools/binary_size/supersize console out/binary-size-results/b2ce31d0fc200fd29fe9ef96d7e15b10f95ece4b/Monochrome.apk.size out/binary-size-results/d9d2b25c8c55dd48b53a78cd84006100a49d0d68/Monochrome.apk.size Change-Id: I3bf80e7bc3cab07a66d303af88cbd6060ffe8b18 Reviewed-on: https://chromium-review.googlesource.com/1238899 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:Gang Wu <gangwu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#593396}
-
Ryan Sleevi authored
As captured in https://crbug.com/888133, the CNNIC CT Log has failed to meet the Chromium CT Log Policy requirements, and is disqualified effective 2018-09-18 00:00:00 UTC. Bug: 888133, 583208 Change-Id: I3b13b6df11eb27d1cd6835b95976d1a2fc450397 Reviewed-on: https://chromium-review.googlesource.com/1238786Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#593395}
-
rbpotter authored
Splitting out fixes for bugs from change to dropdown, in case we decide not to keep dropdown change. Addresses some focus issues, and removes use of auto-validate. Auto-validate does not work well for this section as some errors (e.g. out of range) cannot be caught by the auto validation. Having 2 different sets of logic for setting the input invalid (auto-validate + JS validation) causes some bugs. Bug: 887231, 886591, 886542, 885094, 886560 Change-Id: I053899718a735fa8bcc23df27d36b23d2c26e0b0 Reviewed-on: https://chromium-review.googlesource.com/1238868Reviewed-by:
-
Scott Violet authored
In order to support this the window-service gets Attach/UnattachFrameSinkId. BUG=881574 TEST=covered by tests Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I1bbf82170adf0e254eda8ffa7f1804d56495cb2a Reviewed-on: https://chromium-review.googlesource.com/1233174 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
