- 17 Jul, 2018 40 commits
-
-
Kent Tamura authored
We'd like to fix a confusing UI issue, and to know the impact of a possible fix. Bug: 637639 Change-Id: I7af67ac314f61723c7904cf0fee408ac2b60e774 Reviewed-on: https://chromium-review.googlesource.com/1139940 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#575575}
-
Luciano Pacheco authored
Change tests that interact with Drive to expand it when needed. Bug: 864291 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ibd013801c4bb5c1d1f3224707090eaf7ff0009a6 Reviewed-on: https://chromium-review.googlesource.com/1139848 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#575574}
-
Mikel Astiz authored
This reverts commit 6be34509. Reason for revert: suspect for webkit_layout_tests failures on MSAN, complaining about use-of-uninitialized-value, e.g.: https://chromium-swarm.appspot.com/task?id=3ebe376bfe81a410&refresh=10&show_raw=1 Bug: 864399 Original change's description: > Prevents compositor frames from being sent when SurfaceLayer is not visible. > > This CL is 3/3 in effort to fix the regressions caused by sending > unneeded compositor frames. > > This CL provides a signal from the SurfaceLayerImpl to the VideoFrameSubmitter > to prevent compositor frames from being sent at undesired times (occlusion, not > being added into the layer tree). > > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I428860047eaf4c50abc2e662914a643158f1276b > Reviewed-on: https://chromium-review.googlesource.com/1101708 > Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Reviewed-by: Justin Novosad <junov@chromium.org> > Reviewed-by: enne <enne@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575462} TBR=dcheng@chromium.org,enne@chromium.org,fsamuel@chromium.org,junov@chromium.org,mlamouri@chromium.org,liberato@chromium.org,lethalantidote@chromium.org Change-Id: If2870c03ec0f46546d098cb3fae65edee5b3d772 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1139993Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#575573}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8b9b9154. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21474 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-text/overflow-wrap TBR=robertma No-Export: true Change-Id: Ie749854f3c165f68c9301408cbd531e412be840f Reviewed-on: https://chromium-review.googlesource.com/1139899 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#575572}
-
Colin Blundell authored
Part of the porting of //components/gcm_driver to use IdentityManager rather than SigninManager and ProfileOAuth2TokenService. This particular change is completely straightforward, with GCMProfileService's helper class IdentityObserver observing IdentityManager rather than SigninManager. Bug: 809923 Change-Id: I821893895b2b122cec852a5bbe0c62f1a0b52670 Reviewed-on: https://chromium-review.googlesource.com/1113926 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#575571}
-
Haruka Matsumura authored
This CL adds the destructor in order to promptly freed stack-allocated HeapHashCollections, and also added tests to check it work exactly. heap_allocator: We needs to check whether the backing collection is sweep-forbidden when the destructor is called. So, we added this check flag. Bug: 854480 Change-Id: If9fc8324b839714ae978665b6f7540d7f5ea15e4 Reviewed-on: https://chromium-review.googlesource.com/1123969 Commit-Queue: Haruka Matsumura <harukamt@google.com> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#575570}
-
Dean Liao authored
As current VideoFrame cannot represent real buffer layout, I propose to add a new class, VideoFrameLayout, to store size of physical buffers codec needs as well as format and coded_size of a frame. Also, it stores stride (bytesperline) per buffer to calculate each color plane's size. BUG=b:110815424 TEST=pass media_unittests --gtest_filter=VideoFrameLayout.* Change-Id: Idf96adff1a5d28d4b60bfb208bb51e197d3292ae Reviewed-on: https://chromium-review.googlesource.com/1114568 Commit-Queue: Shuo-Peng Liao <deanliao@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#575569}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5f74c8ef3938..0c5d09a8e978 git log 5f74c8ef3938..0c5d09a8e978 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 vapier@chromium.org cros lint: respect pylintrc indent-string setting Created with: gclient setdep -r src/third_party/chromite@0c5d09a8e978 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I13a674ae3858ffe8fa1d15a38766c3dcff8bb3ec Reviewed-on: https://chromium-review.googlesource.com/1139914Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575568}
-
Dominick Ng authored
Currently this is to assist with reviewing cleanup and rename CLs only. BUG=None Change-Id: I4a52b12ba2cac157a8611bcc988dc5887f77e7e3 Reviewed-on: https://chromium-review.googlesource.com/1139936Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#575567}
-
Matt Falkenhagen authored
This will enable us to disable the optimization via a field trial kill switch if needed. Bug: 854905 Change-Id: Ic312cbedd7685761a45fee986061767b14295afa Reviewed-on: https://chromium-review.googlesource.com/1139457Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#575566}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/381ff28a..f1b3e80f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id4dc8d189707c9eac6591cace44b53550db5ce72 Reviewed-on: https://chromium-review.googlesource.com/1139898Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575565}
-
Matt Falkenhagen authored
There is no evidence of the CHECKs failing. Bug: 857005 Change-Id: I8bb1b4372770987409996739f8c6b051e831809e Reviewed-on: https://chromium-review.googlesource.com/1139837Reviewed-by:
-
Xiaocheng Hu authored
MostForwardCaretPosition asserts that, if we have moved to a visible text node different from start node, the caret position can always be found from the beginning of the text node, which is incorrect if the text node contains invisible first letter part. This patch fixes the incorrect assertion as the function already returns correct result in this case. Bug: 858965 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8daa0ef59e06d4e9878c2e2c29bd12bf1825ead0 Reviewed-on: https://chromium-review.googlesource.com/1136944Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#575563}
-
Leo Zhang authored
In order to get rid of NaCl dependency and take advantage of Mojo to provide a better user typing experience, we plan to create an IME service for ChromeOS. See go/mojo-ime-cros-interface for the interface design doc. More about the project, read go/cros-ime-decoders-mojo for an outline Please check out crrev.com/c/1015148 for an prototype of this service. Tested on local by enabling build flags (enable_cros_ime_service and enable_cros_ime_decoder), then build and run chromeos/services:chromeos_services_unittests Bug: 837156 Change-Id: Ib99380ba3fa17f1d93c6ce16da20604afbc24c84 Reviewed-on: https://chromium-review.googlesource.com/1029792Reviewed-by:
Satoru Takabayashi <satorux@google.com> Reviewed-by:
Leo Zhang <googleo@chromium.org> Reviewed-by:
Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#575562}
-
Guido Urdaneta authored
This allows the browser process to set a factory so that the audio service can create audio logs on the browser process. Bug: 812557 Change-Id: Ia88acb6cb911fc0ad4a47f20b3a628c814233c6b Reviewed-on: https://chromium-review.googlesource.com/1128974Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#575561}
-
Rakina Zata Amni authored
frame_ in FindInPage might be null when GetWebPluginForFind is called, causing a crash in crbug.com/848032. This happens when the frame had detached but the pre-finalizer for FindInPage is not called yet, making it possible for FindInPage to still receive mojo calls even though the frame is null. This CL makes FindInPage observe when its document/ execution context is destroyed so that it will close its mojo binding when that happens. Bug: 848032 Change-Id: Ifac00128e4efeb98f73fdcb98a944164d9ca1bf1 Reviewed-on: https://chromium-review.googlesource.com/1107032 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#575560}
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/e6ce828ef60c..aebc9e5205dc git log e6ce828ef60c..aebc9e5205dc --date=short --no-merges --format='%ad %ae %s' 2018-07-17 thomasanderson@chromium.org Reland "Trigger a buildbot cycle on client.nacl.toolchain" Created with: gclient setdep -r src/native_client@aebc9e5205dc The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=mseaborn@chromium.org Change-Id: I6ba0c1392f16e8b734722595dcaebdb9fff2763b Reviewed-on: https://chromium-review.googlesource.com/1139674Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575559}
-
Luciano Pacheco authored
Essentially changing: * My Files => My files. * Linux Files => Linux files. * Play Files => Play files. Bug: 864299 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ic3c614f654ae0a7cfaa5efb67d6f966acfccc721 Reviewed-on: https://chromium-review.googlesource.com/1139456Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#575558}
-
Tim Song authored
BUG=846881 Change-Id: Ib6e12ce1d2e6bbeaf85e6ba6727a1079adc699e9 Reviewed-on: https://chromium-review.googlesource.com/1130012 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Gustavo Sacomoto <sacomoto@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#575557}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9a962fc1e6e5..5f74c8ef3938 git log 9a962fc1e6e5..5f74c8ef3938 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@5f74c8ef3938 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I2b80d6a4c3b39e476ea74611895e23fbfa2258a3 Reviewed-on: https://chromium-review.googlesource.com/1139676Reviewed-by:
-
Timothy Loh authored
This CL adds support in the CiceroneClient for the InstallLinuxPackage function and the InstallLinuxPackageProgress signal. These are then exposed via the CrostiniManager as InstallLinuxPackage and an observer interface InstallLinuxPackageProgressObserver. This CL also tidies up the existing Cicerone D-Bus calls to use the default timeout instead of an infinite timeout. This will be followed up by a CL adding UI for these: https://chromium-review.googlesource.com/c/chromium/src/+/1126812 Bug: 822464 Change-Id: Ia293d8baa7f69c5417924c3492f54353bfeb352e Reviewed-on: https://chromium-review.googlesource.com/1126811Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#575555}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9a149054. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21473 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I771ee3d0a644e4210ec9bfd951982e491754cf2a Reviewed-on: https://chromium-review.googlesource.com/1139580 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/54edfa4e534d..40bacee96a94 git log 54edfa4e534d..40bacee96a94 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 jbudorick@chromium.org Revert "gclient_scm: Use cherry-picking instead of rebasing." Created with: gclient setdep -r src/third_party/depot_tools@40bacee96a94 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:850812 TBR=agable@chromium.org Change-Id: I92f8c9d26defb8aebd679271f50cc2edb74b8768 Reviewed-on: https://chromium-review.googlesource.com/1139675Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575553}
-
Ian Kilpatrick authored
I remember we had a conversation about this at some stage, when a single NGLineBreaker instance was being re-used for multiple lines, (so we could easily reset the state). It doesn't seem like we'll go back to this (reusing for multiple lines) and removing this seems likes it simplifies a few things. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I48248f3bf871fbb3eda6aaebe0786f7a61d3f390 Reviewed-on: https://chromium-review.googlesource.com/1139104Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#575552}
-
Jiajia Qin authored
This patch uses Platform::ContextType instead of unsigned int as the webgl version type. Meanwhile, a new context type kWebGL2ComputeContextType is added to correspond to the webgl2-compute context. Bug: 859249 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6b8a19970c33e3a35ba54c38a0e55acccda567e3 Reviewed-on: https://chromium-review.googlesource.com/1136224Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com> Cr-Commit-Position: refs/heads/master@{#575551}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/056d811b6a04..4597e0c46fc5 git log 056d811b6a04..4597e0c46fc5 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 buildbot@webrtc.org Roll chromium_revision 6a67eff9..c0988740 (575413:575517) 2018-07-16 jtteh@webrtc.org Revert "Remove RTPVideoHeader::h264() accessors." 2018-07-16 buildbot@webrtc.org Roll chromium_revision 36688868..6a67eff9 (575305:575413) 2018-07-16 jtteh@webrtc.org Revert "Move allocation and rtp conversion logic out of payload router." Created with: gclient setdep -r src/third_party/webrtc@4597e0c46fc5 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:none,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia7c71c96135c5c392c1e17d36970ced50144de05 Reviewed-on: https://chromium-review.googlesource.com/1139436Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575550}
-
Lily Houghton authored
NetworkChangeNotifier::IPAddress Observer is being deprecated. This CL migrates DataReductionProxy to use NetworkChangeObserver instead. Bug: 754695 Change-Id: I473ad45e88cff01a9f33a183033a9d86f59aef4e Reviewed-on: https://chromium-review.googlesource.com/1133330Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Cr-Commit-Position: refs/heads/master@{#575549}
-
Hitoshi Yoshida authored
Updates idl-dictionary-unittest to test the change http://crrev.com/574083 Because we can't test IDL dictionary types directly in JS, we use an interface DictionaryTest as a intermediate path. This CL also updates the behavior of DictionaryTest to be consistent with InternalDictionary. Bug: 855968 Change-Id: I0ad4530a0143185bbf859a0e0b5371e5e0aefa26 Reviewed-on: https://chromium-review.googlesource.com/1136331 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#575548}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0c64e52aea82..9fb90f83997a git log 0c64e52aea82..9fb90f83997a --date=short --no-merges --format='%ad %ae %s' 2018-07-17 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@9fb90f83997a The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I41b245545d5c7961fdbfc518009aca08f08491ce Reviewed-on: https://chromium-review.googlesource.com/1139673Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575547}
-
Eric Willigers authored
Intent to implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/gXXMY1grZ-o/b0y3ENIaCQAJ This CL implements parsing and serialization for the full spec grammar auto | [ under || [ left | right ] ] The new values left and right are hidden behind an experimental feature flag, TextUnderlinePositionLeftRight. (Support for auto | under has shipped previously.) This CL does not include painting support for the new values. Bug: 313888 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie1ba7ecb253e8966b0a9d6f0d0b15df310dfa0a1 Reviewed-on: https://chromium-review.googlesource.com/1135109Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#575546}
-
Christian Biesinger authored
This also required adding a check in NGBlockNode::ComputeMinMaxSize for whether we are inside of PerformLayout -- on Mac, we can compute preferred sizes outside of layout; however, we can't do actual layout in that case, so we have to fallback to legacy min/max size in this case (c.f. RenderViewImpl::CheckPreferredSize()) Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0caf0c6c79264074ccaf9f45b83a420950dab715 Reviewed-on: https://chromium-review.googlesource.com/1131562 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#575545}
-
Christian Biesinger authored
The length type enum has changed since this code was written. R=tzik@chromium.org Change-Id: I24a294968d3c4157be41e6a597c78cc731fa868d Reviewed-on: https://chromium-review.googlesource.com/1135907Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e076a2327f0d..6fb8ba4e8660 git log e076a2327f0d..6fb8ba4e8660 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 jmadill@chromium.org DisplayD3D: Don't release bound texture in restoreLostDevice. 2018-07-16 jmadill@chromium.org Surface: Use ref count for bindTexImage. 2018-07-16 theoking@google.com Vulkan: Fixed improperly set env variable Created with: gclient setdep -r src/third_party/angle@6fb8ba4e8660 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I4b2a7e18e53ba7abfbe6c2c3600497e3dfe61548 Reviewed-on: https://chromium-review.googlesource.com/1139434Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575543}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fb734036f4b5..54edfa4e534d git log fb734036f4b5..54edfa4e534d --date=short --no-merges --format='%ad %ae %s' 2018-07-17 ehmaldonado@chromium.org Update metrics.README.md 2018-07-17 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-07-16 ehmaldonado@chromium.org gclient_scm: Use cherry-picking instead of rebasing. Created with: gclient setdep -r src/third_party/depot_tools@54edfa4e534d The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:850812 TBR=agable@chromium.org Change-Id: I25afce41886a2c38c9afb4bcfe6e217829766fc2 Reviewed-on: https://chromium-review.googlesource.com/1139393Reviewed-by:
-
Erik Luo authored
Style sidebar's empty text updates visibility when the filter changes. It should also update when the inspected node changes. Bug: 849208 Change-Id: I1f5e2eeb12deecef312fbc9b50f69afd3317ab06 Reviewed-on: https://chromium-review.googlesource.com/1132348Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#575541}
-
Joel Hockey authored
The css !important is no longer needed since crostini is not using the nassh FSP provided volume type. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I8a2803b934efbe7a1af8bbba0dd897987f28b3b7 Reviewed-on: https://chromium-review.googlesource.com/1139833 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#575540}
-
Shakti Sahu authored
Implemented image list item for the new download home. Bug: 850595 Change-Id: Ie82086b6b619a9a9b17a2fc4a6da9d5341fe74dd Reviewed-on: https://chromium-review.googlesource.com/1123159 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#575539}
-
Ian Clelland authored
This is used immediately for clearing up the logic around allowfullscreen and allowpayment request, and can also be used for more complex container policy logic in the future. Change-Id: I9cc702e0344d86d56a91894dc7a5a25bcdc26424 Reviewed-on: https://chromium-review.googlesource.com/1136909 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#575538}
-
Chih-Yu Huang authored
Time::FromTimeVal() method will add the offset of UNIX epoch, and breaks the timestamp check at video_encode_accelerator_unittest. This CL change it to Time::FromMicroseconds(). BUG=chromium:853185 TEST=pass video_encode_accelerator_unittest at Kevin device Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia13027141062015f904be74b9323a988697fea3a Reviewed-on: https://chromium-review.googlesource.com/1133612 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#575537}
-
Erik Luo authored
UI.Toolbars give 'flex: none' to their shadow :host. In [1], an extra element was placed in between the Toolbar and the flex container, breaking the 'flex: none'. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1080036 Screenshot: https://imgur.com/a/wyacU7H Bug: 860476 Change-Id: If12df76e2bf711c93acee8df5d7f0bbb0a5a868d Reviewed-on: https://chromium-review.googlesource.com/1139049Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#575536}
-
