GitLab

This test is failing after a v8 change, we need to investigate.

R=ahaas@chromium.org
CC=nicohartmann@chromium.org

Bug: chromium:1027131
Change-Id: Ie8968916a477f6e0e802927b76540dcfbba24c2c
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929236
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Auto-Submit: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717646}

Currently, the referrer browsertests check the outgoing request's
headers on subresource requests but just use JS to check the outgoing
referrer on navigation requests. This patch expands the check to
navigation requests, too, in order to cover more of the navigation
logic.

This patch also
- adds a test covering browser-initiated navigations' referrers
- resolves a few linter complaints (reset -> make_unique; default
constructors)

Change-Id: I804ca43632b881878df63cad33ffaf94b5db6741
Bug: 1021277
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924871Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717645}

This reverts commit fa7e8cc7.

Reason for revert: It looks like there was at least one missed instance of transitively including file_util. Sample build log: https://ci.chromium.org/p/chrome/builders/ci/chromeos-kevin-google-rel/4373

Original change's description:
> [base] Remove base::SharedMemory and base::SharedMemoryHandle
> 
> There are no users of the deprecated shared memory left, so its code
> can safely removed.
> 
> To use shared memory in Chrome, please refer to
> base::WritableSharedMemoryRegion and base::ReadOnlySharedMemoryRegion
> classes.
> 
> This CL removes all remaining #includes of
> "base/memory/shared_memory.h" and
> "base/memory/shared_memory_handle.h". They are replaced by new shared
> memory includes when needed.
> 
> It also appears that "base/files/file_util.h" and
> "base/posix/eintr_wrapper.h" were transitively included in many places
> through the removed files. This CL includes them explicitly in all
> those files.
> 
> TBR: wfh@chromium.org
> Bug: 795291
> Change-Id: I97ecac4b529c0ad6498b6e5ccf01515f750448ad
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919152
> Commit-Queue: Alex Ilin <alexilin@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#717588}

TBR=dcheng@chromium.org,jochen@chromium.org,alexilin@chromium.org

Change-Id: I16c6e4c2ada01240d577706478cf739ce1061ee5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 795291
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929252Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717644}

This moves the "animation interface", i.e the methods:

  ResetAnimatedType(),
  ClearAnimatedType(),
  ApplyResultsToTarget(),
  OverwritesUnderlyingAnimationValue() and
  UpdateAnimation()

From SVGSMILElement to SVGAnimationElement.
This means that we can make the SMILAnimationSandwich only care
about SVGAnimationElements which is slightly more logical.
The |attribute_name_| field is also moved to more logical place, namely
SVGAnimateElement.

Bug: 1017723
Change-Id: I870cca66b44d42288b40cb5d09cd06c04160420d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928775Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#717643}

This test currently isn't being built and has bitrotted. This CL adds
it to the build and gets it to build. It also doesn't pass, which this
CL doesn't attempt to fix (see linked bug).

Bug: 1026557
Change-Id: I66ecc1e5344047092d7ed0f30963c44cec796950
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925057
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717642}

Currently the PasswordCSVWriter test uses CSVReader to check
serializations of passwords into CSV, the result of the tested code.

However, CSVReader will be soon removed together with its main client,
the PasswordCSVReader.

This CL replaces CSVReader use in PasswordCSVWriter test with the
replacement of PasswordCSVReader: the CSVPasswordSequence. This has an
additional benefit: CSVPasswordSequence both decodes CSV and
constructs a PasswordForm out of it, unlike CSVReader, which only does
the former. Therefore, the test must no longer include implementation
details of PasswordCSVWriter, and can instead just verify that
PasswordCSVWriter is the reverse operation of CSVPasswordSequence.

Bug: 934326
Change-Id: If010b42c7c46dd1ece8f6ef96e85eddbd49d09e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920122
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717641}

Using wpt-import in Chromium 678859e4.
With Chromium commits locally applied on WPT:
e83dd93c "Limit backtracking on regexp called from blink."
500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: Id4f0c44fce11b9547b5b9b601bf68eaee2ab4d1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929151Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#717640}

Bug: 1027074
Change-Id: I077c164aaa59ee6644f9f05ee61a26944d6a23c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928701
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717639}

1) Remove stale comments.
2) Remove an unnecessary implementation of GetType().
3) Add stub bodies for instances of Set() that should not be called.
   * Unfortunately I couldn't find a way to prevent calls to these
     functions at compile time.

R=haraken@chromium.org

Bug: chromium:1008840
Change-Id: Id54bf83656e846670a9c6b249fdf62d64733003e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928785Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717638}

... and rename it to RtcSessionDescriptionPlatform.

This is a preparation step to using RtcSessionDescriptionPlatform
instead of WebRtcSessionDescription throughout the code, and eliminate
the later altogether.

The object will back the modules/peerconnection counterpart
RtcSessionDescription.

BUG=787254
R=guidou@chromium.org, haraken@chromium.org

Change-Id: I8f1aaaeb01b12f2b4c65d98da0730b7e5be0868b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925068Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#717637}

Bug: 704136
Change-Id: I243aaaad02bf864251b036079ff85bce0a38b452
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911740
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717636}

googletest will no longer support empty prefix
for parameterized INSTANTIATE_TEST_SUITE_P.
Adding "All" prefix to existing empty prefix test suites.

This CL was uploaded by git cl split.

R=drott@chromium.org

Bug: 1023677
Change-Id: I6bd105c97a1d0a6e0c9071cd172d7fcf24073b68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926883
Auto-Submit: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717635}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7fa83680ccbb..c36744bff1ae

git log 7fa83680ccbb..c36744bff1ae --date=short --no-merges --format='%ad %ae %s'
2019-11-21 hablich@chromium.org [Docs] Add information on release management
2019-11-21 hablich@chromium.org [Docs] Add information on how to merge
2019-11-21 aerotwist@chromium.org Migrates coverage/ to esm

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@c36744bff1ae

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1021467,chromium:1021467,chromium:1006759
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I9bbf651b91f4744d8eb3a20899f86e82aee82951
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928169Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#717634}

This adds WARN_UNUSED_RESULT to some methods in //base/strings
whose primary purpose is to return something useful (e.g. StrCat).
When the results of these methods go unused, it's usually caller error
and will be found by the caller later (for instance, when their tests
fail). WARN_UNUSED_RESULT makes this fail earlier, at compile time.

Precedent: Abseil's StrCat, etc., all use ABSL_MUST_USE_RESULT.
Change-Id: I8262b03bd844118c7337861f323417c2bb92ddda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925251Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717633}

googletest will no longer support empty prefix
for parameterized INSTANTIATE_TEST_SUITE_P.
Adding "All" prefix to existing empty prefix test suites.

This CL was uploaded by git cl split.

R=kinuko@chromium.org

Bug: 1023677
Change-Id: I5402fab8e9fb1e50fa3f765f956f22feb57f62f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926802
Auto-Submit: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717632}

This change introduces RelaunchIgnoreUnloadHandlers and uses it in
RelaunchNotificationController when the deadline for a forced relaunch
is reached. This new function is to AttemptRelaunch as
ExitIgnoreUnloadHandlers is to AttemptExit.

This also introduces browser_shutdown::ShouldIgnoreUnloadHandlers(),
which is a convenience for code that needs to know whether or not an
in-progress shutdown should ignore unload handlers.

(cherry picked from commit 2c98cab9)

BUG=958865
TBR=treib@chromium.org

Change-Id: I291543b924d7b249093297a952ffa5c48f5343fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924197
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717631}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I9754ff5ac01931763d75e010459e6480f9d22e23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929133Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#717630}

Last usage of ui::Compositor::SetLatencyInfo() was removed in r564765.

Change-Id: I0f93e7bc5e5473040dc3e4c82dcf42cbded28daa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925817
Commit-Queue: kylechar <kylechar@chromium.org>
Auto-Submit: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717629}

https://dawn.googlesource.com/dawn.git/+log/4d15609d269e..0d4a7b0ba5b7

git log 4d15609d269e..0d4a7b0ba5b7 --date=short --no-merges --format='%ad %ae %s'
2019-11-21 cwallez@chromium.org Correctly reset mappedData in MapTwice buffer test

Created with:
  gclient setdep -r src/third_party/dawn@0d4a7b0ba5b7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Bug: None
Change-Id: I47b25a9ad7e72b89ce4afe64b1c000d905c1fc26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929131Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#717628}

https://webrtc.googlesource.com/src.git/+log/6dd488b2e551..e835fc01b1a9

git log 6dd488b2e551..e835fc01b1a9 --date=short --no-merges --format='%ad %ae %s'
2019-11-21 henrik.lundin@webrtc.org Add UMA counter for audio interruptions
2019-11-21 titovartem@google.com Fix writing into closed FrameWriter when dumping video in PC framework
2019-11-21 mbonadei@webrtc.org Remove dependencies on Chromium's webrtc_overrides.
2019-11-20 mbonadei@webrtc.org Preventively fix missing braces warnings.
2019-11-20 jonaso@webrtc.org Split P2PTransportChannel
2019-11-20 kuddai@webrtc.org Add absolute capture time property to rtp sources.
2019-11-20 henrika@webrtc.org Clarifies identification of default communication device in ADM2
2019-11-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8b5b046f..022da7ca (715044:716991)

Created with:
  gclient setdep -r src/third_party/webrtc@e835fc01b1a9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None,chromium:None
Change-Id: If0b5bf82f2aabf584ff25d8be29548f267373265
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929132Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#717627}

This is now enabled by default and can be removed.

TBR=jwd

Bug: 777774
Change-Id: I6a77e9c160553ea4361be7794ae5a09b7f8f83b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919931
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Monica Basta <msalama@chromium.org>
Auto-Submit: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717626}

By supporting the “publickey-credentials” feature policy[1][2],
registrations and assertions can now be obtained in cross-origin
iframes if the parent frame explicitly delegates that authority.

This is gated on a feature flag in order that the UX can be updated
prior to this being generally available.

[1] https://w3c.github.io/webauthn/#sctn-iframe-guidance
[2] https://w3c.github.io/webauthn/#sctn-feature-policy

Change-Id: I188731cdc65079ecf287fb62b264b69afe2f3229
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725211Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717625}

Updates the icon to the new one.

Fixed: 1026303
Change-Id: If0e16da06638b8e7d0504d513777c5d0b441303a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928783
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717624}

NDEFScanOptions dictionary spec was changed.
So we should follow new spec for it.
I updated the dictionary.

Bug: 520391,1001507
Change-Id: I427b572e597bd55c719c18922b92c6419b473a22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921930Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Cr-Commit-Position: refs/heads/master@{#717623}

CSVPasswordSequence is the new CSV parser for passwords, bound to
replace the old one, PasswordCSVReader. While their implementation is
different, their behaviour should remain the same. Currently, there is
a big difference: while both parsers report the overall status/error
of parsing the CSV, CSVPasswordSequence checks whether all data rows
are correct representations of passwords, while PasswordCSVReader does
not. PasswordCSVReader only checks that the CSV has a valid header row
with all necessary columns defined, and then only returns
PasswordForms from correctly parseable data rows (possibly none).
This is illustrated, e.g., by the test
DeserializePasswords_NonASCIIUrl.

To match this behaviour in CSVPasswordSequence, this CL removes the
data-rows-check from CSVPasswordSequence code for computing the
overall status/error. It also modifies the CSVPasswordIterator to skip
invalid data rows, similarly to how such rows are not represented
among the vector of PasswordForms returned by PasswordCSVReader.

The CL also adds appropriate tests and ensures that the remaining test
scenarios for PasswordCSVReader are reflected in the tests for
CSVPasswordSequence or its components.

Bug: 934326
Change-Id: I37d75c5e6ffbcfe3c66f6b3230e541b04093759d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920668
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717622}

Initializes DBusThreadManager and CommandLine needed as a part of a
policy_fuzzer setup.

Bug: 1015318
Change-Id: I76255d093420b0975d5adec2feb50826d6027242
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926492Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Olya Kalitova <okalitova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717621}

Use a raw string to define the pattern passed to re.compile when
defining ENV_VAR_PATTERN since it contains a '\\' that we do not
want to be interpreted as a C string interpolated sequence (code
currently works because \$ is not a valid C string interpolated
sequence).

Bug: none
Change-Id: Iebb3946522ce097813b8904e9dfa0b48bca5cc2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928782
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717620}

https://chromium.googlesource.com/catapult.git/+log/bb9ade82457a..536c641b7736

git log bb9ade82457a..536c641b7736 --date=short --no-merges --format='%ad %ae %s'
2019-11-21 mythria@chromium.org Update V8 runtime_stats to use different pattern for optimize background

Created with:
  gclient setdep -r src/third_party/catapult@536c641b7736

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC oysteine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=oysteine@google.com

Bug: None
Change-Id: Ic46c6cb5d9e8c687c141b10d7a6ce5567a4afbe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928021Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#717619}

This reverts commit 7a502f46.

Reason for revert: patch that caused the failures was reverted

Original change's description:
> Disable failing tests on android-go_webview-perf
> 
> Disabling the following tests on android-go_webview-perf:
> * system_health.common_mobile/browse:media:youtube:2019
> * system_health.common_mobile/browse:news:nytimes:2019
> * system_health.common_mobile/browse:news:cnn:2018
> 
> TBR=crouleau@chromium.org
> NOTRY=true
> 
> Bug: 1026822
> Change-Id: I2581e3c21158edff2563de628bfa41de7349271d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927216
> Reviewed-by: John Chen <johnchen@chromium.org>
> Commit-Queue: John Chen <johnchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#717272}

TBR=crouleau@chromium.org,johnchen@chromium.org

Change-Id: I0cf407e4ec8f3a44afa229c9fae82c064d9bb9a0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1026822
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928322Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717618}

A new login_screen_extension_ui namespace is added to replace the
LoginScreenExtensionUi prefix (i.e. LoginScreenExtensionUiFooBar is
converted to login_screen_extension_ui::FooBar). This namespace will
cover code specific to UI presented by login screen extensions on the
signin screen.

Bug: 988379
Change-Id: I3896b175e195da44703e11c5a824b79c2ab2c6a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919928
Commit-Queue: Jit Yao Yap <jityao@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717617}

The underlying metric is added in https://webrtc-review.googlesource.com/c/src/+/160045.

Bug: webrtc:10549
Change-Id: I8d4c9e14e4b73ede8021f286bc64c21c32cad120
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925066
Commit-Queue: Henrik Lundin <hlundin@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717616}

Before this patch we used the device/platform locale to set/get things
in autofill profiles. That locale is dropped in the autofill code and
not used at all. This patch removes the locale logic from two actions.

The consequence now is that the mock in tests does not set the full name
and that is used in the completeness comparison. The fix used here is to
always construct the FullName from the first,middle,last triplet when
needed.

R=arbesser@google.com, marianfe@google.com

Bug: 806868
Change-Id: I0835da87a07c409af8832cd052f6654372b8dcf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926487
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#717615}

Since we are moving away from good old base::Value in favour of
the new one which is not able to do the expansion, we should be
reading the data layer by layer, rather that simply concatenating
them by a period ".".

Bug: 1006230
Change-Id: Ica7298eb44f186adff00b2e565a8c85646806321
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926767
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717614}

* Reorder arguments in ScriptIterator's constructor that takes a
  v8::Isolate.
  In general, functions that take a v8::Isolate* have it as the first
  argument. Make ScriptIterator's constructor follow suit for
  consistency.
* Replace the ScriptIterator(nullptr_t) constructor with a default one.
  Taking a nullptr (as well as not making the constructor explicit)
  never made much sense in the first place.

Change-Id: I19873f5e6c1996279c76029aa3303fe50a890023
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928778Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#717613}

All private frameworks needs to be codesigned, so ensure they are
signed (this is useful when using binary framework pre-compiled).

Bug: 1012115
Change-Id: I9953c391bc3c203ce7b34055690a3cccd23d2acc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926485
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717612}

Adds round trip time for the user download access point, for each result
value and bytes/sec for successful results.

Bug: 1020267
Change-Id: I2eab7272afb71d3abf4a37e71da10bbdabcf5911
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917464
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717611}

This CL has no behavior changes.

Change-Id: If2317def8d94c339c3a3bb8d8c6518347a718da8
Bug: 988343
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928817
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717610}

* Rename IDLDate to IDLDateOrNull to reflect the reality
* Rename ToCoreDate to ToCoreNullableDate
* Change |double| argument of InputType::SetValueAsDate() to
  base::Optional<base::Time>
* Change |double| argument of |BaseTemporalInputType::
  SerializeWithMilliseconds| to base::Optional<base::Time>
* Rename SerializeWithMilliseconds to SerializeWithDate

This CL has no behavior changes.

Change-Id: I2d8476821317a4577ddcf26a2c88eb9809425ed9
Bug: 988343
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928512
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717609}

The Runtime exists in the Root namespace now. In an upcoming change in
the DevTools frontend [1], the Runtime.js is loaded as a proper ES module,
instead of injected into the build artifacts by the build system.

[1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1926503

Bug: 1006759
Change-Id: Ifdd4c7329163637bb461d5466ba3efdc38ebc532
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928705Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717608}

Search engine setting should have the same trailing inset for separators
as other settings.

Bug: 937015
Change-Id: Ie9f75ebcb06c9fe927901490d4cb3ec607eab013
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928776Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717607}