GitLab

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=sky@chromium.org

Review URL: https://codereview.chromium.org/683623002

Cr-Commit-Position: refs/heads/master@{#301511}

BUG=

Review URL: https://codereview.chromium.org/680643003

Cr-Commit-Position: refs/heads/master@{#301510}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/686543002

Cr-Commit-Position: refs/heads/master@{#301509}

for CVC and PAN fields.

BUG=427103,427012

Review URL: https://codereview.chromium.org/681843002

Cr-Commit-Position: refs/heads/master@{#301508}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=mdm@chromium.org

Review URL: https://codereview.chromium.org/682613003

Cr-Commit-Position: refs/heads/master@{#301507}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/681823004

Cr-Commit-Position: refs/heads/master@{#301506}

Review URL: https://codereview.chromium.org/673343003

Cr-Commit-Position: refs/heads/master@{#301505}

Mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after.
A number of similar CLs were landed, and none of them caused issues. They've helped to find and fix janky code. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers.
Landing as TBR since this is a mechanical, safe and temporary change.

This CL instruments code invoked from HttpStreamParser::OnIOComplete's callback, which is responsible for 16.2 jph

BUG=424359
TBR=mmenke@chromium.org

Review URL: https://codereview.chromium.org/675273004

Cr-Commit-Position: refs/heads/master@{#301504}

BUG=260879

Review URL: https://codereview.chromium.org/678073007

Cr-Commit-Position: refs/heads/master@{#301503}

The equivalent logs in SSLClientSocketNSS were never implemented here. This
will help in debugging problems which occur after the handshake.

BUG=425834

Review URL: https://codereview.chromium.org/651183004

Cr-Commit-Position: refs/heads/master@{#301502}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=varkha@chromium.org

Review URL: https://codereview.chromium.org/681913002

Cr-Commit-Position: refs/heads/master@{#301501}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/681883002

Cr-Commit-Position: refs/heads/master@{#301500}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/683553002

Cr-Commit-Position: refs/heads/master@{#301499}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/679273002

Cr-Commit-Position: refs/heads/master@{#301498}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=skuhne@chromium.org

Review URL: https://codereview.chromium.org/685483004

Cr-Commit-Position: refs/heads/master@{#301497}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=skuhne@chromium.org

Review URL: https://codereview.chromium.org/686593002

Cr-Commit-Position: refs/heads/master@{#301496}

Preserves the looping behavior for 200-type sources, while reverting
the disabling of seeks for "non-streaming" type sources which report
an infinite duration. This reverts the unintended behavior change
from http://crrev.com/298565

BUG=412562,427412
TEST=live player works again. LayoutTest forthcoming.

Review URL: https://codereview.chromium.org/684473002

Cr-Commit-Position: refs/heads/master@{#301495}

BUG=427729
TBR=lanwei@chromium.org

Review URL: https://codereview.chromium.org/680183003

Cr-Commit-Position: refs/heads/master@{#301494}

Remove v2.

R=sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/682713003

Cr-Commit-Position: refs/heads/master@{#301493}

This code was previously in
https://chrome-internal.googlesource.com/chrome-app-installer.git

We're moving it to chromium with the goal of having it
eventually built as part of Chrome releases.

The third_party code is used to extract the tags added
by dl.google.com. Omaha uses this mechanism to tag their
meta-installers.

BUG=341353

Review URL: https://codereview.chromium.org/423293004

Cr-Commit-Position: refs/heads/master@{#301492}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/679243002

Cr-Commit-Position: refs/heads/master@{#301491}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=derat@chromium.org

Review URL: https://codereview.chromium.org/680153002

Cr-Commit-Position: refs/heads/master@{#301490}

net: add a batch of HSTS preloads.
Cr-Commit-Position: refs/heads/master@{#301489}

MenuButton will now respond to TAP_DOWN gestures, entering the Hover state. It will return to a normal state if the gesture is cancelled. Tap gestures that activate the menu will still cause it to enter a Pressed state.

This experiment is behind the flag switches::kEnableTouchFeedback

TEST=MenuButtonTest.TouchFeedbackDuringTap, MenuButtonTest.TouchFeedbackDuringTapCancel
BUG=398404

Review URL: https://codereview.chromium.org/674163003

Cr-Commit-Position: refs/heads/master@{#301488}

BUG=418375

Review URL: https://codereview.chromium.org/650293007

Cr-Commit-Position: refs/heads/master@{#301487}

Review URL: https://codereview.chromium.org/674273002

Cr-Commit-Position: refs/heads/master@{#301486}

Facebook domains were added with pinning in
https://codereview.chromium.org/673313002/. However, I omitted to add a new
domain ID for it. This resulted in it having an ID of zero.

The generation script has been updated to catch this in the future[1].

[1] https://github.com/agl/transport-security-state-generate/commit/641c7af7cac98a96386cd3fb3c4444316f8ea967

BUG=none
R=palmer@chromium.org

Review URL: https://codereview.chromium.org/673843003

Cr-Commit-Position: refs/heads/master@{#301485}

I removed the metric "OSX.Fullscreen.Enter" because the confusion it was
causing outweighted the additional information it provided.

It has been replaced by 3 metrics:
  - OSX.Fullscreen.Enter.Style
  - OSX.Fullscreen.Enter.WindowLocation
  - OSX.Settings.ScreensHaveSeparateSpaces

BUG=414527

Review URL: https://codereview.chromium.org/640053007

Cr-Commit-Position: refs/heads/master@{#301484}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/684463003

Cr-Commit-Position: refs/heads/master@{#301483}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=benwells@chromium.org

Review URL: https://codereview.chromium.org/681053002

Cr-Commit-Position: refs/heads/master@{#301482}

Remove last_synced_time_ member variable from ProfileSyncService.  This
variable acted as a cache of the underlying pref.  However, it was not
properly cleared in ProfileSyncService::DisableForUser when the
associated pref was cleared.  This caused a bug where device info may
not have a backup timestamp.

BUG=427096

Review URL: https://codereview.chromium.org/660023003

Cr-Commit-Position: refs/heads/master@{#301481}

Mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after.
A number of similar CLs were landed, and none of them caused issues. They've helped to find and fix janky code. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers.
Landing as TBR since this is a mechanical, safe and temporary change.

This CL instruments code invoked from URLRequestFileJob::DidOpen, which is responsible for 15.3 jph.

BUG=423948
TBR=mmenke@chromium.org

Review URL: https://codereview.chromium.org/675303004

Cr-Commit-Position: refs/heads/master@{#301480}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/678803003

Cr-Commit-Position: refs/heads/master@{#301479}

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=vasilii@chromium.org

Review URL: https://codereview.chromium.org/681043002

Cr-Commit-Position: refs/heads/master@{#301478}

BUG=None
TEST=Run `gn gen` with 'os="chromeos" use_cras=true'.

Review URL: https://codereview.chromium.org/682743003

Cr-Commit-Position: refs/heads/master@{#301477}

The last change to the TestExpectations file was made in January 2013,
and nothing is referring to it (or this directory) anymore.

BUG=

Review URL: https://codereview.chromium.org/674193003

Cr-Commit-Position: refs/heads/master@{#301476}

Review URL: https://codereview.chromium.org/645343004

Cr-Commit-Position: refs/heads/master@{#301475}

This reverts commit e6e890a7.

Causes compile failures:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/5856/steps/compile/logs/stdio

TBR=spang
BUG=

Review URL: https://codereview.chromium.org/682753005

Cr-Commit-Position: refs/heads/master@{#301474}

Not used except for cloud print.

BUG=426573
TBR=rvargas

Review URL: https://codereview.chromium.org/681533002

Cr-Commit-Position: refs/heads/master@{#301473}

This fixes the failing CORS bypass telemetry test for the data reduction
proxy. The CORS bypass test doesn't need to care what kind of bypass
was caused, just that the CORS request was bypassed.

Also made VerifyProxyInfo resilient to the actual and expected proxy
lists being ordered differently.

BUG=423916

Review URL: https://codereview.chromium.org/663333004

Cr-Commit-Position: refs/heads/master@{#301472}