- 02 Oct, 2019 40 commits
-
-
Antonio Gomes authored
This CL prepares MediaStreamTrackMetrics to be Onion souped. BUG=787254 R=guidou@chromium.org Change-Id: I9c31edef1cc690afcbc08b0cde2b18faec866558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834363 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#702022}
-
Roman Sorokin authored
It fixes missing back button Bug: 1000606, 1009340 Change-Id: If7839758f51f39315317cb7d8c4616ef27736295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829199Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#702021}
-
Benedikt Meurer authored
The current popover feature is supposed to be able to handle property accesses (in the current scope) and show a preview of the value. This triggers when you hover an identifier with the mouse. DevTools will then try to find the full sequence of preceeding tokens for the property access and send that to debug-evaluate. However for template literals, this doesn't work properly, since a template literal is not necessarily a single token (in CodeMirror), but for example `a${x}b` is a sequence of three tokens. So instead of just assuming that looking at tokens is enough here, we search for the preceeding ` when we find a template literal and include everything in between. This is merely a work-around for the bigger issue that we should probably implement this feature via a dedicated parser (or ideally reusing V8's AST) to find the correct, innermost subexpression that forms the property access. Hence there's a TODO left in the code to eventually address the bigger issue. Bug: chromium:995036 Change-Id: I4191a54c7ec6ee768f213076c22d575e1ac8438b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835573Reviewed-by:Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#702020}
-
Philip Jägenstedt authored
It's the upstream CI configuration and we don't need it. Stop ignoring .travis.yml since that's gone upstream. Change-Id: I1c1fb6f4f7f6658082406fd3e19a4d0456d614f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835359Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#702019}
-
Robert Kaplow authored
This is reverting the disabling from here: https://chromium-review.googlesource.com/c/chromium/src/+/1278543 Bug: 838549 Change-Id: Ia354b294aee539ba59d6d4aa160c38f9de7773b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637051Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#702018}
-
Bret Sepulveda authored
This reverts commit e9e520a3. Reason for revert: Flakiness unlikely to be caused by the test itself. Original change's description: > sheriff: Disable BrowserNonClientFrameViewPopupTest.HitTestPopupTopChrome. > > Flaky on Linux ASAN and TSAN. > > TBR=bsep > > Bug: 998946 > Change-Id: Iead970e3ca6738c495a9b922c19f24294b9093e4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774006 > Reviewed-by: Darren Shen <shend@chromium.org> > Commit-Queue: Darren Shen <shend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691478} TBR=shend@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 998946 Change-Id: Id164a193c1182b71d002b66b4e8b328fddde7402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835619Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#702017}
-
sczs authored
Since Settings might embed 3rd party ViewControllers, the only interface we could expect from them in order to clean up or rubberband when swiping down to dismiss are the AdaptivePresentationControllerDelegate instance methods. For this reason SettingsRootTableVC now conforms to AdaptivePresentationControllerDelegate, and any subclass can override or implement any of the these methods. This CL also forwards all AdaptivePresentationControllerDelegate method calls into the currently presented Settings VC. Bug: 1006304 Change-Id: I0ff47d755e5c3e67029e210dfb94d21d700520cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832104Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#702016}
-
Alan Screen authored
The Windows VS_FIXEDFILEINFO structure includes fields to represent the version number of a file. Allow these to be provided as a standard base::Version object. Update base::FileVersionInfoWin to make use of this API update. Drop exposure of internal VS_FIXEDFILEINFO structure, and propagate cleanup to gpu/config to use cleaned up API. Bug: 1008222 Change-Id: I94beaf8f8d2d3d90ebb19c3c44acacf7027903f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828219 Commit-Queue: Alan Screen <awscreen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#702015}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id79e18139e4f6f2986b58a0ed9d290e8dbff8e30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835695Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702014}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f4e0c29ed1d7..f1e97b9ebd23 git log f4e0c29ed1d7..f1e97b9ebd23 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 sprang@webrtc.org Reland "Prepares RtpSenderVideo for batch forwarding of generated packets" 2019-10-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4ce9e096..1fdb019b (701829:701929) 2019-10-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 443491f4..4ce9e096 (701518:701829) Created with: gclient setdep -r src/third_party/webrtc@f1e97b9ebd23 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None Change-Id: If109a6b99f49b58eea78ebabf6199fd3b2b39ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835464Reviewed-by:
-
Arthur Hemery authored
Filter unit_tests crashing on android_bfcache_debug fyi bot. Bug: 1007276 Change-Id: I01720d8ed406d82e0e728ab5a8012a590676227c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835615Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#702012}
-
sczs authored
If a Message Banner is being presented and the user taps on its picture/ initial letter Disc, the settings screen wouldn't be presented. This happens because BVC is actually not the presenter VC and it can't dismiss the Banner. This CL uses the existent functionality for showGoogleServicesSettingsFromViewController where BVC is used instead of the parameter VC. This also takes us closer to not sending a VC through the dispatcher. It also removes a DCHECK since a presentedVC should leave that decision to the presenterVC. This is something we currently lack and I hope to work on this after Messages. I didn't add an integration test since we don't have a good way to trigger an Infobar on NTP in an integration test. Bug: 961343 Change-Id: I85ea8047f5b55abd6e5606b4046d7dd7ad158625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834206 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#702011}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010483 Change-Id: I095aedfdefe38c62cd3ba9fb8b4a49f1b7c65c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834875Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#702010}
-
Nico Weber authored
-Wpessimizing-move missed a few calls for a while. Now it finds them again, so clean them up. Bug: 1010458 Change-Id: I143cc6f1421f505aeb56858182860018a75051f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835672 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#702009}
-
Mikhail Khokhlov authored
Bug: 981349, 956308 Change-Id: I887cd6752df75d33babfb187d8da1ad78112f4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824088Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#702008}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5740a8e03413..dbfa96532ab0 git log 5740a8e03413..dbfa96532ab0 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 perezju@chromium.org [py_utils] Fix pylint errors Created with: gclient setdep -r src/third_party/catapult@dbfa96532ab0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:1010304 Change-Id: If4dbef916b2e69a3d11ab9085e60427c5969f156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834873Reviewed-by:
-
Geoff Lang authored
When running on top of ANGLE, ES2 contexts are often used because the exact context version requested is returned. BUG=989194 Change-Id: Iedd673a7c5bee7a291991145f3f7d30552b34d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727169Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#702006}
-
Annie Sullivan authored
This had been missed when updating FirstInputDelay over the summer. Change-Id: I9f635708265c009b4e89d1152c3388a499a78858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834116Reviewed-by:
-
Justin Cohen authored
This reverts commit ceff1a21. Reason for revert: Fixed. Original change's description: > Revert "[ios] Enable preload with slim-navigation-manager." > > This reverts commit 101b5ae0. > > Reason for revert: Needs some more work, some last minute > refactoring introduced some crashes. > > Original change's description: > > [ios] Enable preload with slim-navigation-manager. > > > > Previously, preload required CopyStateFromAndPrune and > > CanPruneAllButLastCommittedItem within NavigationManager, but those > > are not supported with SlimNav. Here, preload is implemented by > > creating a preload WebState with navigation history by restoring the > > current WebState. > > > > The performance of this implementation depends on Slim > > Navigation Manager's session restoration performance which can be > > measured with existing kRestoreNavigationTime metric. > > > > Original implementation of this CL was written by eugenebut@, > > simply updated in this resurrected CL. > > > > Bug: 834116 > > Change-Id: I86c9ecf7e3ed213ebaeddce6264dff3bbb8a8c94 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815702 > > Commit-Queue: Justin Cohen <justincohen@chromium.org> > > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#701228} > > TBR=rohitrao@chromium.org,justincohen@chromium.org,eugenebut@chromium.org,gambard@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 834116 > Change-Id: I16beb96bc2d1eab9a9c36a8e03728fd3cc23f035 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833743 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701746} Change-Id: I52889208ed3a84c08c66742e72b524adce0560af Bug: 834116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833706Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#702004}
-
Tim van der Lippe authored
This issue went unnoticed because of two different CLs touching the same kind of code in unrelated parts of DevTools. It is likely that no tests covered this codepath, blocking one of the CLs from being submitted. Bug: chromium:1006759 Tbr: yangguo@chromium.org Change-Id: If3ef1d86e3ab1d887ece3372649705c96e0b0ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834144Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8d2930613094..cf0a9a628490 git log 8d2930613094..cf0a9a628490 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@cf0a9a628490 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: Ic359821741312538e99e24d499d38f02f2556da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834670Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/17fcc592..3dc289df Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I990fa92ded61f5977b00d18392ca308dfe34acf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835293Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702001}
-
Geoff Lang authored
This reverts commit c8b3d68a. Reason for revert: <INSERT REASONING HERE> Original change's description: > When binding an image to a texture, make sure the texture is bound. > > The the passthrough command decoder did deferred image bindings, it didn't > ensure that the correct GL texture was bound first. This caused canvas -> > WebGL copies to fail when they are using IOSurface backed canvases. > > BUG=990368 > TBR=true > > Change-Id: I5d555c7a715d0f47382053840c3db78576dc4e82 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819520 > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701645} TBR=zmo@chromium.org,geofflang@chromium.org,khushalsagar@chromium.org Change-Id: I0b62b0c97243c76eec8364f2e5a2220466e999e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 990368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835193Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#702000}
-
Fredrik Söderquist authored
This test doesn't appear to be flaky any longer. Tbr: schenney@chromium.org Bug: 981522 Change-Id: I5d39dd67cec50c6e467417dca38d112660f1012d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834350Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#701999}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010472 Change-Id: Idd6a3e1a0c13241801d93cb8956aa406b4713fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835698Reviewed-by:
-
Arthur Hemery authored
Excluding a few extra tests that are currently failing on the android_bfcache_debug fyi bot. Bug: 1007276 Change-Id: I8f80af27b6f0deee4dff340d1e1befbdab68a315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835613 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
The eager evaluation when hovering expressions only works sort of reliably inside the innermost scope anyways (even there we have cases where we get it wrong), so in order to avoid confusing the developer, limit it to the innermost scope for now. Bug: chromium:995036 Change-Id: I6c44326ee5794df1ea6574cd6cf510419b6f4cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835357Reviewed-by:
-
Arthur Hemery authored
Excluding a few extra tests that are currently failing on the android_bfcache_debug/linux_bfcache_debug fyi bots. Bug: 1007276 Change-Id: Idc7a94f2fb67446537ea1d32f9fbe027519d903e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835364 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b4eef2d93601..9bdb26527d65 Created with: gclient setdep -r src-internal@9bdb26527d65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I46456857e4ef2cdebf1e898fa878cf5865b86883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835468Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701994}
-
Henrik Boström authored
See bug. TBR=dmurph@chromium.org, mpearson@chromium.org, rockot@chromium.org, mek@chromium.org, jam@chromium.org Bug: 1010414 Change-Id: I4a87b8873a878cedeaf5d87bc62474a2adaa1444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834088Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#701993}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d9682cc2dc22..2458b31208f8 git log d9682cc2dc22..2458b31208f8 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@2458b31208f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I7047f009b2e11ba115589d9095fd481495109026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835465Reviewed-by:
-
Henrik Boström authored
See bug. TBR=huangdarwin@chromium.org, sky@chromium.org, dcheng@chromium.org, staphany@chromium.org Bug: 1010415 Change-Id: I0d0ec9fbeac9af7e2f3cc60e723fffcd9ca83d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835501Reviewed-by:
-
Maksim Ivanov authored
Allow this API to be called by extensions/apps more frequently than it used to be, in order to not confuse the user with the sudden breakage of PIN requests in the legitimate scenarios (see the bug for the examples). The quota is still preserved in order to protect the user from being spammed by a misbehaving app/extension, but it's changed to the combination of these two restrictions: * no more than 10 calls per minute; * no more than 30 calls per 10 minutes. (Note that this does NOT count the cases when the extension makes a repeated call to re-request a PIN in the same dialog.) Bug: 1010459 Test: (1) repeat 10 times an attempt to log into Chrome OS via a smart card, check that the PIN request is shown each time, and abort it; (2) go into user session, repeat >10 times opening a website that uses client authentication via a smart card, abort each PIN request and check that eventually the PIN requests aren't shown anymore. Change-Id: I1c322e98c2c2578307f3372b07663a495f3e2a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835614Reviewed-by:
Igor <igorcov@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#701990}
-
Javier Ernesto Flores Robles authored
Adds a simple view controller and coordinator for the password breach screen. To be tweaked once UX is done with the details. Bug: 1008862 Change-Id: I3cc49d5de7f33e453a4a9504b7d976672427a71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832817 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/dc9f1e680699..867f72058a4f git log dc9f1e680699..867f72058a4f --date=short --no-merges --format='%ad %ae %s' 2019-10-02 enga@chromium.org Add missing "strlen" parameter for Device InjectError command. 2019-10-02 enga@chromium.org dawn_wire: Only generate has_member for optional members Created with: gclient setdep -r src/third_party/dawn@867f72058a4f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: chromium:1004368,chromium:1009166 Change-Id: Idf72b8fa81d01508217bd08fa25cbcd625f34dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835277Reviewed-by:
-
Philip Jägenstedt authored
Based on https://chromium-review.googlesource.com/c/chromium/src/+/1833804/: > Using wpt-import in Chromium 8c798c26. > With Chromium commits locally applied on WPT: > 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" > ab4b7009 "[Native File System] Aborting a directory iteration succeeds" > 8d24de75 "Port rotate-interpolation.html to wpt" > c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Bug: 1010422 Change-Id: If498cede6b6873bb5069d49c34610fedcbd6e1a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835611Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#701987}
-
Oleg Davydov authored
ContentHash::Status enum has three values assuming that having valid verified_contents.json is mandatory intermediate step on a way to get full ContentHash. We can simplify code a bit by removing this intermediate stage from enum (and replacing remaining two-values enum with just a bool). Also this will simply things a little for self-hosted extensions (which don't have verified_contents.json, but still have to be checked for corruptions). Bug: 796395 Bug: 958794 Change-Id: Iacbd7a90853b0e30d611c7f0e90eb2d53aea989d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810899Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#701986}
-
Gyuyoung Kim authored
To reduce pre-processed size of header files have been including find_in_page.mojom-blink.h, this CL replaces .mojom-blink.h with .mojom-blink-forward.h in find_task_controller.h, text_finder.h, and web_local_frame_impl.h. This CL has no behavior changes. Bug: 1001360 Change-Id: I276e5e9c286525a72f3a1998a181a4bcf45f96dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833373Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#701985}
-
Nico Weber authored
Bug: 1010458 Change-Id: Ie36ee1a87e7801fafdbfc2f38c0762ebbf7cace7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835155 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#701984}
-
BUG=762641 TBR=achuith@chromium.org Change-Id: I7eda207ef9e2e0145df4261ed7c87ec2f8934c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834832Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701983}
-
