- 23 Jun, 2020 40 commits
-
-
Jeffrey Cohen authored
Bug: 1093383 Change-Id: Ibf9e52d837b5de473944f38f513bd98860711830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258336Reviewed-by:
Travis Skare <skare@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#781166}
-
Yoshifumi Inoue authored
This patch changes |AXLayoutObject::GetNodeOrContainingBlockNode()| to return <li> element instead of :marker element for |LayoutNG{In,Out}sideListMarker| to |IsEditable()| and |IsRichlyEditable()| to return valid value. Note: This is a preparation of enabling EditingNG. Bug: 707656 Change-Id: I19fc7947566e9b4c0723dfd746101a4c92262f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253819 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781165}
-
Peter Kasting authored
Previously, this exposed several methods parallel to those in SimpleMenuModel::Delegate. Simply subclass that class instead. Eliminate a Mac-specific testing API by testing the menu contract rather than the implementation. This requires exposing TextServicesContextMenu's MenuCommands publicly. Cleans up the touched locations, including shortening code, changing DISALLOW_COPY_AND_ASSIGN, and removing disabled test code (which led to removing TextfieldTest.LookUpItemUpdate entirely since what remained did not test what the test purported to test). Also OOLed the ViewsTextServicesContextMenuMac implementation since it was hard to see which methods were overridden etc. Bug: none Change-Id: I338740ab6c17460e5fdc26b4b04e6ce5b8a71277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252635 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#781164}
-
Bartek Nowierski authored
https://google.github.io/styleguide/cppguide.html#0_and_nullptr/NULL says: "For pointers (address values), use nullptr, as this provides type-safety." Furthermore, NULL/0 won't compile if we change |SomeClass*| to |CheckedPtr<SomeClass>|. See go/miracleptr for more details. Bug: 1080832 Change-Id: I50f88059092300d67ced70751e611c346301b15a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255939 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#781163}
-
Tom Anderson authored
BUG=1066670 R=nickdiego,sky CC=msisov Change-Id: I23f36fd0fc3ac2522fdbd3de6b7b670e11352ca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252574 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#781162}
-
Hayato Ito authored
Bug: 1098067 Change-Id: Ic59d4a6fa6bec083362e535857449a1a5e2388d5 TBR: beverloo@google.com,csharp@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259533Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#781161}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/03a7835c..9ca5e5ee Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4c142884a7b24dc544fa0ca77c05311f141d1fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258753Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781160}
-
Sunny Sachanandani authored
Display draw time was being subtraced from display scheduler's deadline, but a similar adjustment was missing from cc scheduler's deadline. To fix this inconsistency, this CL applies the deadline adjustment at a single place, the begin frame source so that there's no mismatch. This makes cc scheduler have a later deadline and can cause it to wait longer for the main thread. Recent experimentation has shown improved latency in the absence of a scheduler deadline. It's hoped that some of the improvement can be achieved by just fixing the deadline. Bug: 1042584 Change-Id: Ia948b64c1dbba5239d1b97062224e73487e35fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045210 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#781159}
-
Jimmy Gong authored
- Change from "Print Jobs" to "Print jobs" Screenshot: https://screenshot.googleplex.com/ACk2LrowuFt Bug: 1053704 Change-Id: Ide0a1fc11d4d3edd09819f87c768d9234a224de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258458Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#781158}
-
Trent Apted authored
The behaviour is similar to the file pickers on other platforms. When clicking "OK", a file extension is only added if: - A FileType filter is active that has a default extension (i.e. not the all files filter, or an extensionless filter), and - The user-provided filename does not already have an extension. The file picker already has logic for adding extensions, but it's only applied when changing the currently active filter in the UI (and only when the filename already has an extension that isn't *any* of the possible extensions for the current filter). Repurpose it. The approach taken updates the UI field when clicking close, so the user briefly sees the extension being added before the dialog dismisses. To keep logic & tests simple/robust it was necessary to ensure filters are applied in the dialog correctly when there is only one filter available, which regressed recently (https://crbug.com/1097448). Bug: 1082624, 1097448, 1097633 Change-Id: I1488880be8c289853b864d4bea0e193beb5464ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255918 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#781157}
-
Chong Gu authored
Filters flaky/failing tests. Adds about an hour of bot time and 10 minutes of runtime per build. Bug: 1058255 Change-Id: I52ffcdbe9eeee067f3194109452ebe9b6a2a147a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255100 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#781156}
-
rbpotter authored
Remove use of keyCode in the PDF viewer, except where required for PDFium. Bug: 1093648 Change-Id: I4bb507b475f04e58f613337d89aefcf113718c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247212 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#781155}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592859555-f08c66ddf994e8777f6044c180c36d7bb50b914d.profdata to chrome-win64-master-1592870283-bd2e27d217e9cf585a262d4149273abf7da557f4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I0fbc6a233b890c2647c30066bd809d75b5aeece5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258967Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781154}
-
shrekshao authored
Remove suppression for [win nvidia passthrough] conformance/buffers/buffer-data-dynamic-delay.html Tbr: kbr@chromium.org Bug: 1082826 Change-Id: I9ec1ba97527a35fbd0f29601494cb8a98a433228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255223Reviewed-by:
Shrek Shao <shrekshao@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#781153}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9aba625ec30a..b444943db27d 2020-06-22 johnstiles@google.com Update SkString::resize to preserve string contents efficiently. 2020-06-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2020-06-22 jvanverth@google.com Reland "Fill in GrD3DGpu::onUpdateBackendTexture" 2020-06-22 fmalita@chromium.org [skottie] skottie_tool updates If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I55d88fe51e4d3cfb05435b0f2723bd36149af54e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258378Reviewed-by:
-
Li Lin authored
Based on UI review feedback, we want to expand the scope of related info setting toggle and remove the Quick Answers sub toggle. We are going to proceed with two steps: 1. Gate the sub toggle with feature flag that is disabled by default in case we want to turn it on. 2. Clean up the sub toggle code after launch and confirmed that it doesn't significantly impact related info opt in rate. This CL is the first step. Bug: b/159166868 Test: unit tests Change-Id: Ia0e87112c69251914b3bae9ae3f3a0c0d1bc96ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250475 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Reviewed-by:
-
Reilly Grant authored
This change removes the uninclusive term "master" from the name of this class. This is a better name anyways due to the symmetry with the DeclarativeUserScriptManager class. Bug: 1097189 Change-Id: Ie7bd46087103b30d52a32b397eda2a1097d99316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258357 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#781150}
-
Ian Kilpatrick authored
As per: https://github.com/w3c/csswg-drafts/issues/4645 This adds two different use-counters: 1) Determine how often we query a non-zero scroll offset. 2) Determine how often a dialog is larger than the viewport. Change-Id: I2a3532512ad29ad22e997073ae9eed80612bf4ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258213 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#781149}
-
David Jean authored
Change-Id: I86625fa583c7b21b665bc2e19fc0b9e4b18a282c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253745Reviewed-by:
David Jean <djean@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Auto-Submit: David Jean <djean@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#781148}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I7c64c8eef59adcc5906cbebc30e5c8035d07e1fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259572Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781147}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592852054-fc80552e8cd021ac422e9a90f3c3c2d4420e412e.profdata to chrome-win32-master-1592866776-599fc29ec545e33b0a3ff20f5395d165563a3711.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I7eee758f08144a94e29a4ce6c803b98febf2fc05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258671Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9d09e31e. With Chromium commits locally applied on WPT: ee0c101e "[COOP] access reporting toward the opener." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: Iea22c870455c36129b772ca7846e5b8ad4eb2951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257727Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781145}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cfbf769d5f63..7db2dceccdad 2020-06-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 04f0b691eb4c to 74ed6cfd05c1 (20 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: Ib2c0d1e3775b7e69b1638d3273602f22db2a20f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258377Reviewed-by:
-
Moe Ahmadi authored
Given the increase in the suggestion row heights of the Realbox in the WebUI NTP to match the Omnibox, suggestion header row height and font size should also be increased to match that of the Omnibox. Bug: 1098097 Change-Id: I31c5ccf6a98619dcbe867ef43dabaf643682087e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258858Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#781143}
-
Liviu Tinta authored
Bug: 1092550 Change-Id: Ib45946e26ec15d7f341c31d232cf9065dd64ac3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255426 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#781142}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4ac199dc2390d8240508c04d09ce838e134ec4aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258952Reviewed-by:
-
Kenneth Russell authored
These are converted to RGBA16F format, which WebGLImageConversion didn't handle, and the calling code didn't detect that failure. In WebGLImageConversion, handle unpacking half-float data to 32-bit floating-point, as well as all packing conversions to the supported texture upload formats. Expand comments describing the needed conversions and remove old incorrect FIXMEs. Tested thoroughly with the enhanced image_bitmap_from_blob WebGL conformance tests in https://github.com/KhronosGroup/WebGL/pull/3100 . All versions of the test (2D/3D, all texture upload formats) pass in Chromium with this fix. Bug: 1058160 Change-Id: I6bf4e5b9370cbd471e02030858ca1e93c7b88af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253372 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#781140}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3b5a5e5b9d33a8e360c0160a9d42a5806c412eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258962Reviewed-by:
-
Takashi Toyoshima authored
This change removes the last TODO in the cors-and-webview-api.md. file:///android_asset/ and file:///android_res/ are almost same with other usual file:// URLs, but still can be accessible even if AllowFileAccess is set to false. Test cases mentioned in the doc are also added to ensure legacy and current CORS behaviors. TEST=./out/a/bin/run_webview_instrumentation_test_apk -A Feature=CORS Bug: 1035366 Change-Id: I5bdb7c54e261136d099944ed3690e6892fe72c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253262 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#781138}
-
Brian Sheedy authored
Deduplicates the Skia Gold code used by the Android instrumentation tests and the GPU Telemetry-based pixel tests, as they were effectively identical with only a few differences. This is accomplished by moving the majority of the code to //testing/skia_gold_common and having each test harness extend the abstract classes as necessary. Bug: 1093994 Change-Id: Icef9f22d896a82672f3c64a26d38c026bf6bd02d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253147Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#781137}
-
danielng authored
Updating the port forwarding UI to guidelines suggested by UX. This includes updating the port forwarding dialog in regards to error handling, adding a toast when activating a port fails and also includes adding tests for the updated features and revamping some of the older tests to be async functions. Screenshots: https://drive.google.com/drive/folders/19BU8axWIax1f-8axva5L48jR0TRbgyXb?usp=sharing Some of the mocks: go/crostini-ports-design Test: Added browser tests, revamped others, and ran tests Bug: 848127 Change-Id: I4639df00a2e37b18a93a4436cc6636cee182c165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251617Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#781136}
-
Harry Cutts authored
This is a USB wireless gamepad in the PlayStation style, which seems to be mostly available in Japan. (Amazon: https://amzn.com/B01MXY05W0) It complies with XInput. Bug: b:159368181, chromium:1096754 Test: Connect the gamepad in "X" mode, load gamepadviewer.com, and check that pressing buttons and moving axes is correctly reflected on-screen. Change-Id: Ie0758fceb09ed6b3c701672e27a4c045a231dca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252469Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/master@{#781135}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/716bc4468192..3231e4267bf8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC caseq@google.com,hayato@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1025606,chromium:1057553,chromium:1059455,chromium:1080747,chromium:1095642,chromium:1096666 Tbr: caseq@google.com,hayato@google.com Change-Id: Ia52a3ed86e405d730315f3459faa205bd4225290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258662Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781134}
-
David Bokan authored
The text fragment highlighting can be distracting for many users and the click/tap to dismiss isn't very discoverable. To make this easier on the eyes, dismiss the highlight as soon as the user starts scrolling. Bug: 1096575 Change-Id: I42f0b12e50275e7325a3647ee7a2100527602507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255780 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#781133}
-
Xiaocheng Hu authored
The function currently uses the LayoutObject of the documentElement as the layout invalidation root, which is incorrect because there can be objects not in its subtree. For example, a modal dialog. This patch fixes it by using the LayoutView, the root of the layout tree, as the layout invalidation root. Bug: 1092411 Change-Id: Ic2475fe1fc9fd9029699a410b4f03a9f3812e240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255738Reviewed-by:
-
Hiroki Sato authored
CL:2222068 modified ARC++ focusability and accessibility name computation so that focusable views gets name from its non-focusable descendants. We should not apply this to virtual nodes like WebView. AX-Relnotes: n/a. Bug: b:152930082 Test: unit_tests --gtest_filter="AXTreeSourceArcTest.*" Test: manual. Open Gmail app. WebView nodes (leaf nodes) correctly gets focus from ChromeVox. Change-Id: I8bc7b46f1b557aa13b4953243ebbd53425f0052f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256922 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#781131}
-
Moe Ahmadi authored
Previously, the realbox input text would remain unchanged when the suggestion group header was being focused (say by tabbing into it) despite the selection being reset. This CL makes those behaviors consistent by clearing the realbox input in addition to resetting selection when the suggestion group header geet focused. Bug: 1095719 Change-Id: I5bcabb4c455731b0002357639555d3d1452697ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258466Reviewed-by:
-
Ian Kilpatrick authored
TBR=kojii@chromium.org Bug: 974666 Change-Id: If7e93264db3afdbeddcf4f39c427bd378bf83bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258471Reviewed-by:
-
Sadrul Habib Chowdhury authored
Create a trace-event at the point when UMA is reported, so that it is easier to associate the UMA with the associated frames. BUG=1095186 Change-Id: Id78695d21f3178e69c6025f580c2db49a67e3360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251300 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#781128}
-
Alexandre Courbot authored
When the decoder is reset, the frame splitter should be reset as well. BUG=b:158800859 TEST=VDAtest passes on Hana-kernelnext. Change-Id: I90cd638a4240a4f85b412f4046d8b92fd5241bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257121Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#781127}
-
