1. 12 Jan, 2007 23 commits
    • kdecker's avatar
      · 0bc2431e
      kdecker authored
              Reviewed by andersca.
      
              Fixed: <rdar://problem/4701326>21.2 ms launch time regression spent in +[WebPluginDatabase installedPlugins]
      
              * dom/DOMImplementation.cpp:
              (WebCore::DOMImplementation::createDocument): Added a guard clause for text/html which used to be in WebKit before a lot of the 
              loader plumbing was moved to WebCore.  Pinging the plug-in database to ask it if it supports a given mime type has the side 
              effect of reading from disk on first call, therefore such a check should be a last resort.  
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18813 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0bc2431e
    • ggaren's avatar
      RS by Brady Eidson. · c652a6b4
      ggaren authored
              
              Rolling back in r18786 with leaks fixed, and these renames slightly reworked:
      
              Because they can return 0:
              rootObjectForImp => findRootObject (overloaded for JSObject* and Interpreter*)
              rootObjectForInterpreter => findRootObject (ditto)
              findReferenceSet => findProtectCountSet
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18811 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c652a6b4
    • ddkilzer's avatar
      WebCore: · 0ae841b5
      ddkilzer authored
              Reviewed by Darin.  Patch by Mitz.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12223
                REGRESSION: Leaks under CSSStyleSelector::applyProperty
      
              No test possible (no change to functionality).
      
              * rendering/RenderObject.h: Removed unused forward declaration.
              * rendering/RenderStyle.cpp:
              (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData):
              Delete shadow data.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18810 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0ae841b5
    • andersca's avatar
      Build fix. · e4a9489f
      andersca authored
              
              * WebCore.xcodeproj/project.pbxproj:
              Remove SubresourceLoaderMac.mm.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18806 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e4a9489f
    • andersca's avatar
      Reviewed by Darin and Anders. · bb958eff
      andersca authored
              Make some more of the loader code platform independent.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::clear):
              (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
              (WebCore::FrameLoader::urlSelected):
              (WebCore::FrameLoader::createEmptyDocument):
              (WebCore::FrameLoader::setTitle):
              (WebCore::FrameLoader::originalRequestURL):
              (WebCore::FrameLoader::referrer):
              * loader/SubresourceLoader.cpp:
              (WebCore::SubresourceLoader::SubresourceLoader):
              (WebCore::SubresourceLoader::load):
              (WebCore::SubresourceLoader::create):
              (WebCore::SubresourceLoader::willSendRequest):
              (WebCore::SubresourceLoader::didReceiveResponse):
              (WebCore::SubresourceLoader::didReceiveData):
              (WebCore::SubresourceLoader::didFinishLoading):
              (WebCore::SubresourceLoader::didFail):
              (WebCore::SubresourceLoader::didCancel):
              (WebCore::SubresourceLoader::stopLoading):
              * loader/SubresourceLoader.h:
              * loader/mac/FrameLoaderMac.mm:
              * loader/mac/SubresourceLoaderMac.mm: Removed.
              * loader/qt/FrameLoaderQt.cpp:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18805 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      bb958eff
    • lars's avatar
      Reviewed by Zack · 2c0cce38
      lars authored
              Get DumpRenderTree to work again for the Qt build.
      
              Make run-webkit-tests a little less verbose when testing
              Qt, and add an option to run DumpRenderTree inside valgrind
              (useful for debugging)
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18804 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2c0cce38
    • lars's avatar
      Reviewed by Zack · 86f5ebbd
      lars authored
              Valgrind reported uninitialized variable.
      
              * platform/network/qt/ResourceHandleManagerQt.cpp:
              (WebCore::FileLoader::request):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18803 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      86f5ebbd
    • rwlbuis's avatar
      Reviewed by rwlbuis. · 9756cff4
      rwlbuis authored
              - add missing null check in new fixed table layout code
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18802 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9756cff4
    • zack's avatar
      Add WEBKIT_FULLBUILD to the qmake relevant build part to force · f79ce404
      zack authored
      make clean before make as they fix stale dependencies (for buildbot mainly)
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18801 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f79ce404
    • lars's avatar
      Fix the Qt build after the Authentication changes. · 7516e4aa
      lars authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18800 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7516e4aa
    • hyatt's avatar
      Fix for bug 9569. Make sure the selection offset for selection roots... · 3c22afc3
      hyatt authored
              Fix for bug 9569.  Make sure the selection offset for selection roots excludes border and padding.
      
              Reviewed by Eric
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::leftSelectionOffset):
              (WebCore::RenderBlock::rightSelectionOffset):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18799 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3c22afc3
    • hyatt's avatar
      Fix for bug 8705, readonly text fields should not get focus rings. ... · 85c21c11
      hyatt authored
              Fix for bug 8705, readonly text fields should not get focus rings.  Add a rule to that effect to
              html4.css and then also add readonly as a special case for style sharing so that we can retain the
              performance boost from sharing styles on inputs.
      
              Reviewed by bdash
      
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::canShareStyleWithElement):
              (WebCore::CSSStyleSelector::checkOneSelector):
              * css/html4.css:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18798 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      85c21c11
    • hyatt's avatar
      Update overflow layout test results after autoscroll fix. · f40f272b
      hyatt authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@18797 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f40f272b
    • hyatt's avatar
      Fix for bug 11595. Autoscrolling of layers didn't really work at all... · 0278dd62
      hyatt authored
              Fix for bug 11595.  Autoscrolling of layers didn't really work at all unless the layer was coincidentally
              in the root layer's coordinate space.  The event point was an absolute position within the document, but
              the layer's rect was only local coords.  This patch makes sure to use absolute bounds for the layer
              when comparing it with the point.
      
              This is covered by the scrollRevealButton test case already in the tree... the results change to be more
              correct.
      
              Reviewed by ggaren
      
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::scrollRectToVisible):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18796 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0278dd62
    • ggaren's avatar
      RS by Brady Eidson. · 078aa111
      ggaren authored
              
              Rolling out r18786 because it caused leaks.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18795 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      078aa111
    • beidson's avatar
      Reviewed by Oliver · acea542d
      beidson authored
              -Move more HTTP Auth handling towards ResourceHandle, away from ResourceHandleClient
              -Make more of ResourceLoader cross-platform
      
              * loader/ResourceLoader.cpp:
              (WebCore::ResourceLoader::ResourceLoader):
              (WebCore::ResourceLoader::releaseResources):
              (WebCore::ResourceLoader::didCancel):
              (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
              (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
              (WebCore::ResourceLoader::receivedCancellation):
              * loader/ResourceLoader.h:
              (WebCore::ResourceLoader::willStopBufferingData):
              (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
              (WebCore::ResourceLoader::willCacheResponse):
              * loader/mac/ResourceLoaderMac.mm:
              * platform/network/ResourceHandle.h:
              * platform/network/ResourceHandleClient.h:
              (WebCore::ResourceHandleClient::willStopBufferingData):
              * platform/network/ResourceHandleInternal.h:
              (WebCore::ResourceHandleInternal::ResourceHandleInternal):
              * platform/network/mac/ResourceHandleMac.mm:
              (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
              (WebCore::ResourceHandle::didCancelAuthenticationChallenge):
              (WebCore::ResourceHandle::receivedCredential):
              (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
              (WebCore::ResourceHandle::receivedCancellation):
              (WebCore::ResourceHandle::clearAuthentication):
              (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
              (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]):
              (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]):
              (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]):
              (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):
              
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18794 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      acea542d
    • hyatt's avatar
      A hit test is returning a null renderer. Make sure to null-check it... · 5793889b
      hyatt authored
              A hit test is returning a null renderer.  Make sure to null-check it in the autoscroll code.
              This really shouldn't happen, but I'm just going to bullet proof for now given that it's happening
              on the front page of yahoo.com!
      
              Reviewed by mark
      
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::autoscroll):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18793 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5793889b
    • hyatt's avatar
      LayoutTests: · 93767bcd
      hyatt authored
             Force column-width to parse in strict mode so that there is no confusion when it is used in the columns
             shorthand (it can be mistaken for column-count otherwise).
      
             Reviewed by Mark
             
              * fast/multicol/columns-shorthand-parsing-expected.checksum: Added.
              * fast/multicol/columns-shorthand-parsing-expected.png: Added.
              * fast/multicol/columns-shorthand-parsing-expected.txt: Added.
              * fast/multicol/columns-shorthand-parsing.html: Added.
      
      WebCore:
      
              Force column-width to parse in strict mode so that there is no confusion when it is used in the columns
              shorthand (it can be mistaken for column-count otherwise).
      
              Reviewed by Mark
      
              fast/multicol/columns-shorthand-parsing.html
      
              * css/cssparser.cpp:
              (WebCore::CSSParser::parseValue):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18792 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      93767bcd
    • bdash's avatar
      2007-01-11 Mitz Pettel <mitz@webkit.org> · bf3ddd59
      bdash authored
              Reviewed by Hyatt.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12124
                RenderTable::section{Above,Below}() can return the wrong answer for the {footer,header}
      
              * rendering/RenderTable.cpp:
              (WebCore::resetSectionPointerIfNotBefore): Added this function to help with
              checking if a section being inserted is the going to be the first of its kind.
              (WebCore::RenderTable::addChild): Changed to maintain the pointers to the
              header, the footer, the caption and the first table body properly when objects
              are inserted in the middle. Also changed to make the first caption win over
              any other captions. This matches Firefox and what already used to happen when a
              section recalc took place.
              (WebCore::RenderTable::layout): Changed to use sectionBelow() for iterating
              over the sections from top to bottom.
              (WebCore::RenderTable::calcBorderLeft): Changed to really find the section
              containing the first row.
              (WebCore::RenderTable::calcBorderRight): Ditto.
              (WebCore::RenderTable::sectionAbove): Fixed a bug when the last section was
              skipped if the input was the footer.
              (WebCore::RenderTable::sectionBelow): Ditto for "first" and "header"
              respectively.
      
      2007-01-11  Mitz Pettel  <mitz@webkit.org>
      
              Reviewed by Hyatt.
      
              - updated results for http://bugs.webkit.org/show_bug.cgi?id=12124
                RenderTable::section{Above,Below}() can return the wrong answer for the {footer,header}
      
              Collapsed borders changed in the "marvin" tests, as the footer cells now
              collapse correctly with the last row of the body. Visual differences not
              captured by the pixel results since they occurred below 600px.
      
              The "other" test has changed since in a table with multiple captions,
              now the first one wins. No visual difference in this case since both captions
              are the same.
      
              * tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
              * tables/mozilla/marvin/backgr_position-table-expected.txt:
              * tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
              * tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
              * tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
              * tables/mozilla/marvin/backgr_simple-table-expected.txt:
              * tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
              * tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
              * tables/mozilla_expected_failures/other/test4-expected.txt:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18791 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      bf3ddd59
    • bdash's avatar
      2007-01-11 Mitz Pettel <mitz@webkit.org> · 86d1fbd4
      bdash authored
              Reviewed by Hyatt.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12115
                RTL text is jumbled on display
      
              Fixed fixed table layout. Implemented an algorithm that matches the behavior
              of Firefox, up to rounding errors.
      
              Fixes three existing table tests.
      
              * rendering/FixedTableLayout.cpp:
              Undid accidental search-and-replace of "width" to "m_width" in the comments.
              Removed an outdated comment, since WebKit no longer honors table-layout:fixed
              for variable-width tables.
              (WebCore::FixedTableLayout::calcWidthArray): Fixed the logic that finds the
              first row. Changed to divide the width specified for a cell that spans multiple
              columns between the columns rather than assign its entire width to each column.
              (WebCore::FixedTableLayout::calcMinMaxWidth):
              (WebCore::FixedTableLayout::layout): Implemented the behavior observed in
              Firefox.
              * rendering/FixedTableLayout.h:
      
      2007-01-11  Mitz Pettel  <mitz@webkit.org>
      
              Reviewed by Hyatt.
      
              - updated results for http://bugs.webkit.org/show_bug.cgi?id=12115
                RTL text is jumbled on display
                (fixing fixed table layout)
      
              * tables/mozilla/bugs/bug157890-expected.checksum:
              * tables/mozilla/bugs/bug157890-expected.png:
              * tables/mozilla/bugs/bug157890-expected.txt:
              * tables/mozilla/bugs/bug44505-expected.checksum:
              * tables/mozilla/bugs/bug44505-expected.png:
              * tables/mozilla/bugs/bug44505-expected.txt:
              * tables/mozilla_expected_failures/bugs/bug7243-expected.checksum:
              * tables/mozilla_expected_failures/bugs/bug7243-expected.png:
              * tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18790 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      86d1fbd4
    • bdash's avatar
      2007-01-11 Mitz Pettel <mitz@webkit.org> · 659f1193
      bdash authored
              Reviewed by Hyatt.
      
              - http://bugs.webkit.org/show_bug.cgi?id=10249
                Temporarily disable tests that are causing kernel panics
      
              Changed the ImageDiff tool not to use CoreImage filters.
      
              * DumpRenderTree/ImageDiff.m:
              (main):
              (createImageFromStdin):
              (compareImages):
              (getDifferenceBitmap):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18789 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      659f1193
    • bdash's avatar
      2007-01-11 Mitz Pettel <mitz@webkit.org> · 600917c2
      bdash authored
              Reviewed by Hyatt.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=8438
                iExploder(#460): Assertion failure in RenderObject::drawBorder()
      
              Test: fast/block/basic/fieldset-stretch-to-legend.html
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::calcWidth): Stretch to the minimum intrinsic
              width if the object requires it.
              (WebCore::RenderBox::calcHorizontalMargins): Some style cleanup.
              (WebCore::RenderBox::calcAbsoluteHorizontal): Stretch to the minimum
              intrinsic width if the object requires it.
              * rendering/RenderBox.h:
              (WebCore::RenderBox::stretchesToMinIntrinsicWidth): Added. Returns false.
              * rendering/RenderFieldset.cpp:
              (WebCore::RenderFieldset::calcMinMaxWidth): Overloaded RenderBlock's
              implementation to ensure that the legend's will fit in the fieldset's
              minimum intrinsic width.
              (WebCore::RenderFieldset::findLegend): Made const.
              (WebCore::RenderFieldset::paintBoxDecorations):
              (WebCore::RenderFieldset::paintBorderMinusLegend): Fixed the behavior when
              the legend does overflow the fieldset. This is the part of the fix that
              prevents the assertion failure. If the legend intersects with a corner of
              the fieldset's border, that corner will not be painted, even if it is not
              completely occluded. This edge case can be improved with clipping in the
              future. Added FIXME to implement border-radius.
              * rendering/RenderFieldset.h:
              (WebCore::RenderFieldset::stretchesToMinIntrinsicWidth): Overloaded to
              return true.
      
      2007-01-11  Mitz Pettel  <mitz@webkit.org>
      
              Reviewed by Hyatt.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=8438
                iExploder(#460): Assertion failure in RenderObject::drawBorder()
      
              * fast/block/basic/fieldset-stretch-to-legend-expected.checksum: Added.
              * fast/block/basic/fieldset-stretch-to-legend-expected.png: Added.
              * fast/block/basic/fieldset-stretch-to-legend-expected.txt: Added.
              * fast/block/basic/fieldset-stretch-to-legend.html: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18788 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      600917c2
    • ggaren's avatar
      Reviewed by Anders Carlsson. · b86acb06
      ggaren authored
              Even more cleanup in preparation for fixing <rdar://problem/4608404> 
              WebScriptObject's _executionContext lack of ownership policy causes 
              crashes (e.g., in Dashcode)
              
              Layout tests pass.
              
              Renames:
                  ReferencesSet | ProtectCounts => ProtectCountSet (because it's a typename for a set of GC protect counts)
                  ReferencesByRootMap => RootObjectMap (because RootObjectToProtectCountSetMap would have been confusing)
                  pv => protectedValues
                  rootObjectForImp => getRootObject (overloaded for JSObject* and Interpreter*)
                  rootObjectForInterpreter => getRootObject (ditto)
                  findReferenceSet => getProtectCountSet
                  imp => jsObject
              
              (KJS::Bindings::getRootObjectMap): Changed to take advantage of built-in
              facility for initializing static variables.
      
              (KJS::Bindings::getProtectCountSet):
              (KJS::Bindings::destroyProtectCountSet): Added. Helps encapsulate the fact
              that getting a ProtectCountSet entails adding a RootObject to a hash table,
              and destroying one entails the reverse.
      
              (KJS::Bindings::getRootObject): Removed spurious NULL check.
              
              (KJS::Bindings::findReferenceSet): Renamed. Changed to use getRootObject()
              instead of iterating on its own.
      
              (KJS::Bindings::addNativeReference): Changed to use an early return instead
              of indenting the whole function.
              (KJS::Bindings::removeNativeReference): Ditto.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18786 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b86acb06
  2. 11 Jan, 2007 17 commits
    • beidson's avatar
      Reviewed by Build Fix Karma · 5b1f7042
      beidson authored
              I broke the release build (debug build passed)
      
              * platform/network/mac/AuthenticationMac.mm:
              (WebCore::core):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18785 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5b1f7042
    • beidson's avatar
      Blind build fix attempt · ebc1c084
      beidson authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18784 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ebc1c084
    • beidson's avatar
      WebCore: · 3104dbe5
      beidson authored
              Reviewed by Anders
      
              Rewrites HTTP Authentication setting up a more platform-independent structure
      
              * WebCore.exp:
              * WebCore.xcodeproj/project.pbxproj:
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
              (WebCore::FrameLoader::didCancelAuthenticationChallenge):
              * loader/FrameLoader.h:
              * loader/FrameLoaderClient.h:
              * loader/ResourceLoader.cpp:
              (WebCore::ResourceLoader::ResourceLoader):
              (WebCore::ResourceLoader::didCancel):
              * loader/ResourceLoader.h:
              (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
              (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
              (WebCore::ResourceLoader::receivedCredential):
              (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
              (WebCore::ResourceLoader::receivedCancellation):
              * loader/mac/FrameLoaderMac.mm:
              * loader/mac/ResourceLoaderMac.mm:
              (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
              (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
              (WebCore::ResourceLoader::receivedCredential):
              (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
              (WebCore::ResourceLoader::receivedCancellation):
              * platform/graphics/svg/SVGImageEmptyClients.h:
              (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
              (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
              * platform/network/ResourceHandleClient.h:
              (WebCore::ResourceHandleClient::willSendRequest):
              (WebCore::ResourceHandleClient::didReceiveAuthenticationChallenge):
              (WebCore::ResourceHandleClient::didCancelAuthenticationChallenge):
              (WebCore::ResourceHandleClient::receivedCredential):
              (WebCore::ResourceHandleClient::receivedRequestToContinueWithoutCredential):
              (WebCore::ResourceHandleClient::receivedCancellation):
              (WebCore::ResourceHandleClient::willCacheResponse):
              * platform/network/ResourceResponse.h:
              (WebCore::operator!=):
              * platform/network/URLAuthenticationChallenge.cpp: Added.
              (WebCore::URLAuthenticationChallenge::URLAuthenticationChallenge):
              (WebCore::URLAuthenticationChallenge::previousFailureCount):
              (WebCore::URLAuthenticationChallenge::proposedCredential):
              (WebCore::URLAuthenticationChallenge::protectionSpace):
              (WebCore::URLAuthenticationChallenge::failureResponse):
              (WebCore::URLAuthenticationChallenge::error):
              (WebCore::URLAuthenticationChallenge::isNull):
              (WebCore::URLAuthenticationChallenge::nullify):
              (WebCore::operator==):
              (WebCore::operator!=):
              * platform/network/URLAuthenticationChallenge.h: Added.
              (WebCore::URLAuthenticationChallenge::sender):
              (WebCore::URLAuthenticationChallenge::nsURLAuthenticationChallenge):
              * platform/network/URLCredential.cpp: Added.
              (WebCore::URLCredential::URLCredential):
              (WebCore::URLCredential::user):
              (WebCore::URLCredential::password):
              (WebCore::URLCredential::hasPassword):
              (WebCore::URLCredential::persistence):
              (WebCore::operator==):
              * platform/network/URLCredential.h: Added.
              (WebCore::):
              (WebCore::operator!=):
              * platform/network/URLProtectionSpace.cpp: Added.
              (WebCore::URLProtectionSpace::URLProtectionSpace):
              (WebCore::URLProtectionSpace::host):
              (WebCore::URLProtectionSpace::port):
              (WebCore::URLProtectionSpace::serverType):
              (WebCore::URLProtectionSpace::realm):
              (WebCore::URLProtectionSpace::authenticationScheme):
              (WebCore::operator==):
              * platform/network/URLProtectionSpace.h: Added.
              (WebCore::):
              (WebCore::operator!=):
              * platform/network/mac/AuthenticationMac.h: Added.
              * platform/network/mac/AuthenticationMac.mm: Added.
              (WebCore::URLAuthenticationChallenge::URLAuthenticationChallenge):
              (WebCore::mac):
              (WebCore::core):
              * platform/network/mac/ResourceHandleMac.mm:
              (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
              (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]):
              (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]):
              (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]):
              (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):
              * platform/network/mac/ResourceResponseMac.mm:
              (WebCore::operator==):
      
      WebKit:
      
              Reviewed by Anders
      
              Rewrites HTTP Authentication setting up a more platform-independent structure
      
              * WebCoreSupport/WebFrameLoaderClient.h:
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
              (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
              * WebKit.xcodeproj/project.pbxproj:
      
      WebKitQt:
      
              Keep the fancy new FrameLoaderClientQt building with a small api change in WebCore
              Yay for the loader on QT!
      
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::dispatchDidReceiveAuthenticationChallenge):
              (WebCore::FrameLoaderClientQt::dispatchDidCancelAuthenticationChallenge):
              * WebCoreSupport/FrameLoaderClientQt.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18783 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3104dbe5
    • ggaren's avatar
      JavaScriptCore: · 1c7f3ac2
      ggaren authored
              Reviewed by Anders Carlsson.
      
              Even more cleanup in preparation for fixing <rdar://problem/4608404> 
              WebScriptObject's _executionContext lack of ownership policy causes 
              crashes (e.g., in Dashcode)
              
              Layout tests pass.
              
              Renames:
                  findRootObjectForNativeHandleFunction => createRootObject
                  FindRootObjectForNativeHandleFunctionPtr => CreateRootObjectFunction
                  
              Also removed unnecessary use of "Bindings::" prefix.
      
              * JavaScriptCore.exp:
              * bindings/jni/jni_jsobject.cpp:
              (JavaJSObject::createNative):
              (JavaJSObject::convertValueToJObject):
              (JavaJSObject::convertJObjectToValue):
              * bindings/runtime_root.cpp:
              (KJS::Bindings::RootObject::setCreateRootObject):
              * bindings/runtime_root.h:
              (KJS::Bindings::RootObject::createRootObject):
      
      WebCore:
      
              Reviewed by Anders Carlsson.
              
              Even more cleanup in preparation for fixing <rdar://problem/4608404> 
              WebScriptObject's _executionContext lack of ownership policy causes 
              crashes (e.g., in Dashcode)
              
              Layout tests pass.
              
              Renames:
                  findRootObjectForNativeHandleFunction => createRootObject
                  FindRootObjectForNativeHandleFunctionPtr => createRootObjectFunction
                  rootForView => createRootObject
                  getInstanceForView => getPluginInstanceForWidget
      
              * page/mac/FrameMac.mm:
              (WebCore::FrameMac::getAppletInstanceForWidget): Put the NSView * in a void*
              variable named "nativeHandle" to be more explicit about the fact that JavaScript's
              "nativeHandle" is just an NSView *.
      
              (WebCore::getPluginInstanceForWidget): This function now does the NSView *
              fetching that its callers used to do.
              (WebCore::FrameMac::getEmbedInstanceForWidget): Updated for rename.
              (WebCore::FrameMac::getObjectInstanceForWidget): ditto
      
              * page/mac/WebCoreFrameBridge.mm: Killed the WebCoreBridgeInternal category,
              which was really more of a shmategory.
              (createRootObject): Removed rootObjectForView, folding it into its only
              caller, the similarly named rootForView. Renamed the pair to "createRootObject"
              because that's what they do.
      
              (-[WebCoreFrameBridge init]): Updated for renames
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18782 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1c7f3ac2
    • andersca's avatar
      Get rid of garbage · 51ba0231
      andersca authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18781 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      51ba0231
    • andersca's avatar
      Reviewed by Darin. · 86017599
      andersca authored
              Fix crash on platforms that don't use the new loader yet.
              
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::requestResource):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18780 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      86017599
    • weinig's avatar
      LayoutTests: · bda23728
      weinig authored
              Reviewed by Adam.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=11449
                Type-to-select in unopened popups doesn't work with Hebrew
      
              * fast/forms/select-type-ahead-non-latin-expected.txt: Added.
              * fast/forms/select-type-ahead-non-latin.html: Added.
      
      WebCore:
      
              Reviewed by Adam.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=11449
                Type-to-select in unopened popups doesn't work with Hebrew
      
              Test: fast/forms/select-type-ahead-non-latin.html
      
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::defaultEventHandler): Changed locale-specific
              isprint() condition to a Unicode isPrintableChar().
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18779 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      bda23728
    • justing's avatar
      LayoutTests: · e3b9b27d
      justing authored
              Reviewed by geoff
              
              <rdar://problem/4889140>
              GMail Editor: List creation fails in new message
      
              * editing/execCommand/insert-list-empty-div-expected.checksum: Added.
              * editing/execCommand/insert-list-empty-div-expected.png: Added.
              * editing/execCommand/insert-list-empty-div-expected.txt: Added.
              * editing/execCommand/insert-list-empty-div.html: Added.
      
      WebCore:
      
              Reviewed by geoff
              
              <rdar://problem/4889140>
              GMail Editor: List creation fails in new message
      
              * editing/InsertListCommand.cpp:
              (WebCore::InsertListCommand::doApply): Inserting the list
              into an empty paragraph not held open by a br or a '\n', 
              will invalidate start and end.  Insert a placeholder and 
              then recompute start and end.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18778 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e3b9b27d
    • lars's avatar
      This one is not needed any longer neither. · df82f4ec
      lars authored
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18777 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      df82f4ec
    • lars's avatar
      fix compilation of DumpRenderTree. Will hopefully · 8df627b0
      lars authored
      make the built bot happy :)
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18776 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8df627b0
    • lars's avatar
      remove now unused file. · f4c218a2
      lars authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18775 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f4c218a2
    • ddkilzer's avatar
      WebCore: · 5cbf1c99
      ddkilzer authored
              Reviewed by NOBODY (build fix).
      
              * loader/mac/FrameLoaderMac.mm:  Removed import of LoaderNSURLRequestExtras.h.
              * loader/mac/SubresourceLoaderMac.mm:  Ditto.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18774 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5cbf1c99
    • staikos's avatar
      Fix compile · 3e2667eb
      staikos authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18773 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3e2667eb
    • andersca's avatar
      Fix build. · 088a9065
      andersca authored
              
              * dom/XMLTokenizer.cpp:
              * loader/CachedCSSStyleSheet.cpp:
              * loader/CachedImage.cpp:
              * loader/DocLoader.cpp:
              * loader/loader.cpp:
              * xml/XSLTProcessor.cpp:
              * xml/xmlhttprequest.cpp:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18772 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      088a9065
    • andersca's avatar
      Reviewed by Adam. · 2b9c89e2
      andersca authored
              Loader cleanup, get rid of unused code.
              
              * WebCore.xcodeproj/project.pbxproj:
              * loader/CachedResource.h:
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::requestResource):
              (WebCore::DocLoader::checkCacheObjectStatus):
              * loader/DocLoader.h:
              * loader/LoaderFunctions.h: Removed.
              * loader/mac/CachedResourceMac.mm: Removed.
              * loader/mac/LoaderFunctionsMac.mm: Removed.
              * loader/mac/LoaderNSURLRequestExtras.h: Removed.
              * loader/mac/LoaderNSURLRequestExtras.m: Removed.
              * loader/mac/SubresourceLoaderMac.mm:
              * page/mac/WebCoreFrameBridge.mm:
              * platform/network/ResourceHandle.cpp:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18771 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2b9c89e2
    • bdakin's avatar
      Better Changelog. · 1678499a
      bdakin authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18770 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1678499a
    • bdakin's avatar
      Reviewed by Adam. · be0e2ee3
      bdakin authored
              Fix for http://bugs.webkit.org/show_bug.cgi?id=12135 REGRESSION: 
              <input> and <textarea> not focused on right click (4908884 in 
              Radar)
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::sendContextMenuEvent): Ask if we *have* 
              swallowed the event instead of if we *haven't* when deciding to 
              perform a selection.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@18769 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      be0e2ee3