- 13 Aug, 2020 40 commits
-
-
Saagar Sanghavi authored
Change-Id: I21d67ab0091a802eec16f675c1416865ffd6b143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354619Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Saagar Sanghavi <saagarsanghavi@google.com> Cr-Commit-Position: refs/heads/master@{#797808}
-
Yuke Liao authored
In order to promote views_unittests and browser_tests to be sheriffed to prevent regressions. Bug: 1111979 Change-Id: I5daca5b8e354f6d52bd43b948f9d5e9811b65d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353950Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#797807}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e1360ddcec9e..b19e07ebf92c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib961b539a90a82a61a1d8b00f0f96e5e11fce5e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354226Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797806}
-
Chris Blume authored
There is a C-style cast in gpu_raster_buffer_provider.cc which Tricium would prefer to be a C++-style cast. This CL changes it that cast. Change-Id: If4fe2d1d39153431a71f60f866ab928154d729d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354049Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Auto-Submit: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#797805}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/9f09e3fd0930..ffd805115ed6 2020-08-13 rharrison@google.com Add support for Dawn using deprecated Options constructor (#1130) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I08415b44b530c83eeda3481d44a556f57a53baed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354572Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797804}
-
Justin Cohen authored
This reverts commit 0ab91ac7. Reason for revert: Failures starting in: https://ci.chromium.org/p/chromium/builders/ci/ios14-sdk-simulator/2281 * ClipboardRecentContentIOSTest.AddingNonStringRemovesCachedString * ClipboardRecentContentIOSTest.PasteboardURLObsolescence * ClipboardRecentContentIOSTest.SchemeFiltering * ClipboardRecentContentIOSTest.SuppressedPasteboardImage * ClipboardRecentContentIOSTest.SuppressedPasteboardText https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8872067354517054672/+/steps/components_unittests_iPhone_6s_14.0_on_Mac-10.15/0/stdout Original change's description: > Fix iOS Omnibox Clipboard Suggestions to not immediately read clipboard > > The basic idea here is to factor out the match creation methods. On iOS > 14, if the clipboard contains content, we create a blank match of the > correct type (one without any destination_url). Then, when the match > is selected for opening, we can ask the clipboard_provider for a new > match using the proper text, and open that one instead. > > For other platforms, we can keep using the old method, where we access > the clipboard immediately and construct the destination_url at match > creation time. iOS 14 also uses this behavior if there is cached > clipboard content. > > Bug: 1105869 > Change-Id: I70d26f4bcc485e4dc9073db2257161355adc8a40 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346290 > Commit-Queue: Robbie Gibson <rkgibson@google.com> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Reviewed-by: manuk hovanesian <manukh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797671} TBR=jdonnelly@chromium.org,tedchoc@chromium.org,manukh@chromium.org,rkgibson@google.com Change-Id: I170940bf76f9e60ab0eb9d15e549fd4a62de45d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1105869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354524Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#797803}
-
Rouslan Solomakhin authored
This patch adds a helper for setting up the environment necessary to unit test communication with Android apps. At this time, only the Android subsystem on Chrome OS has a concrete implementation. Bug: 1061503 Change-Id: I6900aa13cd111d14adeaab6a0116a623c4ace817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250351 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#797802}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/3f2c3d7f4b2a..2c4978fa890c $ git log 3f2c3d7f4..2c4978fa8 --date=short --no-merges --format='%ad %ae %s' 2020-08-13 fayang In QUIC, do not test liveness if timeout is longer than half idle timeout. Client side only, not protected. 2020-08-12 renjietang Adding comments and DCHECKS in the validation logic of configuring QuicStream's flow controller. 2020-08-12 renjietang Remove an redundant if clause in QuicSession::OnNewStreamFlowControlWindow(). 2020-08-12 renjietang Add debug visitor call when transport parameters are resumed during 0-RTT. 2020-08-12 dschinazi Add QUIC+TLS key_update_not_yet_supported transport parameter 2020-08-12 renjietang Add client connection option to disable server push in gQUIC. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src flip flags R=dschinazi@chromium.org Change-Id: I22aea64c16a6924aa82459ab795819f78b077832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354604 Commit-Queue: Dan Zhang <danzh@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Dan Zhang <danzh@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#797801}
-
Nasko Oskov authored
This CL uses the newly added support for converting RenderFrameHost into a trace value and adds logging to more of the commit parameters. Bug: 993350, 1043616 Change-Id: Ic0a82617e452ab1bbcfe25654426b80c507c8474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353560 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#797800}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/78d7b4b8250e..8fa7957ea438 2020-08-13 fmayer@google.com Merge "Document standalone custom allocator client." 2020-08-13 treehugger-gerrit@google.com Merge "Simplify debobfuscation code." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9dfab6d0a0febcfc1f50d95772a8ec51d02eb95a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354749Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797799}
-
Weilun Shi authored
Add split histograms to the histograms_xml's so these histograms will also be included when sending to the server side. This cl also leaves a TODO to figure out a way to glob sources for histograms_xml instead of listing them all here. Bug: 1116096 Change-Id: Iee83efcb14fe643908b56d714e16accaed66bf28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354794 Commit-Queue: Weilun Shi <sweilun@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#797798}
-
Yao Xiao authored
Add use counter for when 1) phone & email field is detected by the autofill field type prediction. 2) email field is detected by regex matching with email patterns of the input value. Design Doc: https://docs.google.com/document/d/1oSVFfjB4WJkwSL9aP7kwQhevi9aovaMi19HgiYv1g0M This is achieved by plumbing the field type prediction from autofill::FormCache::ShowPredictions to the relevant blink::HTMLInputElement, and checking the conditions on every EndEditing event. Bug: 1110402 Change-Id: I86e51a35ed5c2a8a2fd1d0a3d2506459aa346831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324204 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#797797}
-
Yuly Novikov authored
Remove conformance/textures/misc/compressed-tex-image.html expectation Skip unsupported extensions expectations on SwiftShader Also skip unsupported extensions expectations on other platforms, to speed up test execution. This takes a different approach to handling conflicting expectations. SwiftShader expectations are duplicated for linux, mac, win. Other expectations are simplified to their original version. TBR=bsheedy Bug: 1099955 Change-Id: Ibfcc44b454a7cea94f3e629928d7f79f66d71c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353581 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#797796}
-
Sadrul Habib Chowdhury authored
When no frame is produced due to no damage on impl thread, and the main thread still has not responded to an earlier 'begin main frame', treat that as a 'dropped frame', rather than a 'no damage frame'. BUG=1102071 Change-Id: Icf06fb7e9e98531f87bcb3e0bf477af8eae52132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353831 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#797795}
-
Jeff Yoon authored
android debug static bot for lorenz-graph-dbg Bug: 1098864 Change-Id: Iae186de07a787c77b34d489dca8ab20a73db8145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353390 Auto-Submit: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#797794}
-
Xianzhu Wang authored
Tiles with different scale can't use LCD text because their pixels are not aligned with physical pixels. Once the flag is set on a tiling, it should keep unchanged and set the flag for all tiles of the tiling, to avoid mosaic effect caused by different LCD text settings of different tiles, and we accept the temporary imperfection of LCD-text. Also when a layer's LCD-text status changes, only invalidate the highres tiling in the same way as we invalidate the highres tiling when raster translation changes. This is a preparation CL for crbug.com/1111195. Bug: 1111195 Change-Id: I64ef167ac322ee94c96a82575e3f2448060fcda6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344809 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#797793}
-
Scott Violet authored
This adds NavigationHandle::SetReferer() and calls it from WebLayer's Navigation::SetRequestHeader(). BUG=1114870 TEST=covered by test Change-Id: I5154e477422cccebad2a2a9af734e5401ce66533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350384 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#797792}
-
Shimi Zhang authored
Currently there is only one ctor for SwapPromiseMonitor, which takes both SwapPromiseManager* and LayerTreeHostImpl*, however these two parameters should never used together. This CL changes the ctor to two separate ctors so we can distinguish each use case more clearly. Test: Should be covered by the current tests. Bug: 1104665 Change-Id: If9bad83cb151a51484ad9b87ab8a6d8ad3b04e47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350879Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#797791}
-
Wan-Teh Chang authored
https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/4cfee6282b97..fdc636b4ce09 $ git log 4cfee6282..fdc636b4c --date=short --no-merges --format='%ad %ae %s' 2020-08-12 wtc Use fullSize for alpha in avifImageAllocatePlanes 2020-08-12 wtc Check for grid images consistently 2020-08-12 wtc Clean up avifDecoderReset() 2020-08-12 wtc Fix avifDecoderDataFillImageGrid for alpha images 2020-08-12 wtc Change conditional expressions to prevalent style (#273) 2020-08-12 wtc Validate grid image size and tile size (#272) 2020-08-12 wtc Ignore clang -Wc11-extensions warnings on dav1d.h (#271) 2020-08-12 52529860+novomesk Disable Clang warning (drop const qualifier) (#270) 2020-08-12 wtc avifParseImageGridBox should consume all item data (#269) 2020-08-12 wtc Declare local variable 'alphaTile' in if statement (#268) 2020-08-11 wtc Use local var 'data' throughout avifDecoderReset (#266) 2020-08-11 wtc Disallow zero grid output_width or output_height (#265) Created with: roll-dep src/third_party/libavif/src R=dalecurtis@chromium.org Change-Id: I78507ef6bc038cdb7a96dad09cd5ae65e3a89c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354613Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#797790}
-
Gavin Williams authored
This changes adds metrics to record the printer status reasons returned by printer status queries. This metric coincides with the addition of printer availability icons to the Print Preview destination dropdown (go/printer-status-design-doc). Bug: 1059607 Change-Id: Ica85163a3dcc0ecdbe34370f14f998512aaa3a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347313Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#797789}
-
Jimmy Gong authored
- Search tag now includes both "Android settings" and "Android preferences" to link to the android settings subpage. - Set "Android preferences" as the primary search tag as it matches the text of the link to android preferences app. Bug: 1115330 Change-Id: Id0dd5b40c2fab9e4a9a41f1d67357475a0a78817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353675Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#797788}
-
Takumi Fujimoto authored
This reverts commit 01efb7a7. Reason for revert: Causing bot failures: https://ci.chromium.org/p/chromium/builders/ci/Win7%20%2832%29%20Tests Original change's description: > Implement initializer list support for containers > > Implement initializer list support for creating arrays and dictionaries > in TracedValue::Build. Thus speed up adding debugging tracing of > multiple parameters, including container types. > > Follow-up of: crrev.com/c/2263160 > > Bug: 1043616 > Change-Id: I2d3205d550e6ce6328ea253e6b94f9cc2cbe3098 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346286 > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Commit-Queue: Karel Král <karelkral@google.com> > Cr-Commit-Position: refs/heads/master@{#797706} TBR=altimin@chromium.org,eseckler@chromium.org,karelkral@google.com Change-Id: I7334c762ede0d06226398ee9ff7b38bf5a30e44e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1043616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354830Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#797787}
-
Sebastien Lalancette authored
With the flag on, articles context menus weren't working. Moving the flag check to the MostVisited flow instead of overall the long-press gesture recognizer fixes it. Bug: 1115970 Change-Id: Ic9945928c949cbef9ed874d5a381b071b18a54d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354272 Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#797786}
-
chrome://devicesrbpotter authored
Add the appropriate help link to chrome://devices Also fixing a typo in the link itself - should be support.google.com, not www.google.com. Note: String itself is not modified by this change, but is detected as a change due to adding the URL argument. Bug: 1114186 Change-Id: Ibb8583d419639da3b1ba13058060cf91298deeb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353406Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#797785}
-
Justin Cohen authored
Change-Id: I7b2aa098037f0bfd89b46b360493c6ec3fc24834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354515 Auto-Submit: Justin Cohen <justincohen@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#797784}
-
chrome://sandboxAlex Gough authored
This takes the values returned as base::Value from the sandbox policy and allows them to be expanded in the summary display of chrome://sandbox. Expansion is deferred as the page can become slow in debug builds if it is performed every time, and expanded values are not always required for debugging. Bug: 1115305 Change-Id: I96d71b21ccc28e678fdb3fb9714f30cf88b730ef Tests: manual testing on Win7 x86 and Win10 10.0.18362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350331Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#797783}
-
Wenyu Fu authored
Change the loading spinner to show when waiting time is longer than 500ms, and ensure the loading spinner is displayed for at least 500ms. For simplicity, we also change the name of CCT fragment and use original flow when the welcome page is going to be skipped. Bug: 1108558 Change-Id: If22d74f1afe5a88b1637d4db29be137173c58f6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338932 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#797782}
-
Owen Min authored
It will create an easy workaround for developers when testing policy on platforms that have need complicated policy management tools. Bug: 1113792 Change-Id: Ie0431022a3aba1d5356afb32a9987a91d6ba7929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353397 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#797781}
-
Liquan (Max) Gu authored
Change logic: * The untrusted PaymentRequest interface breaks apart from CPRImpl to become MojoPaymentRequestGateKeeper. The new class would be responsible for handling the untrusted mojo calls from the renderer. Doing that, it can ensure that CPRImpl receives no invalid calls from the renderer. * Establish the requirements for the users of CPRImpl that the CPRImpl instances should be set null after BPRImpl#close, CPRImpl#teardown and PRClient#close. For example, CPRImpl#OnClosedListener is provided for the callers to nullify the instances. Note that: * Although MPRGateKeeper and CPRImpl both have plumbings to pass PR calls, they are necessary, because going forwards, PRImpl will be diminished, and eventually the plumbings would only exist between MPRGateKeeper and CPRImpl. Code change highlights: * In CPRImpl#initAndValidate(), null-check the request's raw data before passing them into BPR, so that BPR doesn't need to add @Nullable for them. * In MPRGateKeeper#init, discards CPRImpl (and its PRClient, BPR) when the raw data are invalid. * MPRGateKeeper plumbs the PR calls to CPRImpl, so that the calls are only passed to the CPRImpl when the PaymentRequest data are valid. Acronym: CPRImpl = ComponentPaymentRequestImpl BPR = BrowserPaymentRequest PRClient = PaymentRequestClient MPRGateKeeper = MojoPaymentRequestGateKeeper Bug: 1102522 Change-Id: Iab160b2c3e74608b9b19ba17e454dedf32411193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346730 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#797780}
-
Andres Calderon Jaramillo authored
This CL fixes VaapiWrapper::FillProfileInfo_Locked() so that it doesn't return false when the profile is VAProfileVP9Profile2 and the driver does not advertise support for VA_RT_FORMAT_YUV420 (and instead only advertises support for VA_RT_FORMAT_YUV420_10 and VA_RT_FORMAT_YUV420_12). More context: The uprev to iHD 20.2.0 caused TGL to advertise only VA_RT_FORMAT_YUV420_10 and VA_RT_FORMAT_YUV420_12 for VAProfileVP9Profile2, probably because of [1]. This seems reasonable since VP9.2 is intended for high bit depth. Running vainfo -a shows the following for VP9.2: VAProfileVP9Profile2/VAEntrypointVLD VAConfigAttribRTFormat : VA_RT_FORMAT_YUV420_10 VA_RT_FORMAT_YUV420_12 VA_RT_FORMAT_YUV420_10BPP VAConfigAttribDecSliceMode : VA_DEC_SLICE_MODE_NORMAL VA_DEC_SLICE_MODE_BASE VAConfigAttribDecProcessing : VA_DEC_PROCESSING VAConfigAttribMaxPictureWidth : 16384 VAConfigAttribMaxPictureHeight : 16384 VAConfigAttribProcessingRate : VA_PROCESSING_RATE_DECODE The problem is that VaapiWrapper::FillProfileInfo_Locked() returns true only if one of {VA_RT_FORMAT_YUV420, VA_RT_FORMAT_YUV422, VA_RT_FORMAT_YUV444} is advertised. Therefore, for iHD 20.2.0, we would determine that VAProfileVP9Profile2 is unsupported and subsequently fall back to software. This CL ensures that we check for the presence of VA_RT_FORMAT_YUV420_10 (which is the non-deprecated version of VA_RT_FORMAT_YUV420_10BPP [2]). [1] https://github.com/intel/media-driver/commit/ca71e10f29ea3b232b883803b31724a8ee0d3e46 [2] https://github.com/intel/libva/blob/2.8.0/va/va.h#L821 Bug: b:161520834 Test: crosvideo.appspot.com w/ VP9.2; checked chrome://media-internals Change-Id: Id00a0150272cc11640bd21183ee739b005f9d2cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303682Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#797779}
-
Nick Diego Yamane authored
Wayland Ozone backend uses a platform drag-and-drop session to be able to support the capabilities required by Chrome's tab dragging. Particularly, keeping track of the focused window and the current mouse cursor position while the tab/window is dragged around. Further context can be found at the design doc [1]. So far, it has been relying only on {Run,End}MoveLoop API to trigger such DND session. It works, but, as it is called after the (dragged) windows creation and mapping, it is not possible to take the necessary actions upon window creation or mapping (e.g: issue some dnd/extension protocol request to the Wayland compositor), which makes it insufficient to achieve glitches-free tab/window detaching implementation. Which has been verified while addressing [2][3], and can be seen at video [4]. To fix it, this patch does: - Add WaylandExtension platform window extension, with a single method for now, that makes it possible for the upper layer components to start the window dragging session explicitly; - Plumbs up Chrome's Browser{Frame,DWTHLinux} such that it starts a Wayland drag-and-drop session when the tab drag starts. [1] https://docs.google.com/document/d/1s6OwTi_WC-pS21WLGQYI39yw2m42ZlVolUXBclljXB4/edit?usp=sharing [2] https://bugs.chromium.org/p/chromium/issues/detail?id=1099418 [3] https://chromium-review.googlesource.com/c/chromium/src/+/2307653 [4] https://www.youtube.com/watch?v=3sWVyA1OagA R=sky@chromium.org Bug: 896640 Test: Covered by ozone_unittests Change-Id: I5e902caa7b495ae585330bc3e3b431bacb139d1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346545 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#797778}
-
Mark Mentovai authored
Bug: 1113466 Change-Id: Idc85b749409055f0e9d5bbbc1d0fcb55a12d2df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343494 Auto-Submit: Mark Mentovai <mark@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#797777}
-
Robert Ogden authored
Also adds a test for documenting what happens when the limit is reached. Bug: 1115736 Change-Id: Ie488adb6b874ae47503670514bd7456bef8bfd6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354536Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#797776}
-
Matt Wolenetz authored
To ensure the MediaSourceRegistryImpl singleton is available and known to MediaSourceAttachments before they could possibly be created, moves the singleton construction to be done during modules initialization instead of lazily on-demand later. This ensures that the main thread will own the singleton, since later changes enable first real usage of the registry to be done from either the main thread or from a dedicated worker thread. BUG=878133 Change-Id: Ibc4e0b77ef840d76d6048a46614affae3227c07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353534Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#797775}
-
James Vecore authored
The active profile was not being cleared on the |NearbyProcessManager| singleton in the unit-test tear down which was causing unit-test failures. Change-Id: Iefe1b037beeb23924550c9ae6ccaf1ba0f111b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354616 Commit-Queue: James Vecore <vecore@google.com> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: James Vecore <vecore@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#797774}
-
Abigail Klein authored
disconnects. Add disconnect handlers to the speech service. If the UI in the browser disonnects from the service in the renderer, have the speech service stop transcribing captions. If the service in the renderer disconnects from the utility process which connects to SODA or the cloud, send a message to the UI that there was an error and have the UI display the error message. Bug: 1055150 Change-Id: I3940cae2cd12503353e105fd612b064908d9951c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353024Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Evan Liu <evliu@google.com> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#797773}
-
Nasko Oskov authored
Implementing AsValueInto method in NavigationRequest allows it to be used as input into tracing events macros. This CL adds this support and uses it to log the NavigationRequest in its constructor. Bug: 1043616 Change-Id: Iac28d6d52944064e448d99fe2734057ad0cf6ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353546 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797772}
-
Peter Kasting authored
This makes it easier to track down and/or change types. Also renames CallbackList -> RepeatingCallbackList. Bug: 1113007 Change-Id: I42357489f2c3e7a19b0f4909fe20ca7dc9ff4339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354225Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#797771}
-
Lan Wei authored
SerialTest.NavigateWithChooserCrossOrigin fails on Linux Ozone Tester (X11), https://ci.chromium.org/p/chromium/builders/ci/ Linux%20Ozone%20Tester%20%28X11%29/15780, disable it for now until it is fixed. TBR= reillyg@chromium.org Bug: 1116072 Change-Id: I01e63d9a87ed9e2995db21e158a9d964cf7cd5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354712Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Auto-Submit: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#797770}
-
Yu-Hsuan Hsu authored
We need to pass switch --use-cras to the audio service so that chrome will be able to use CRAS on linux. Bug: 151905045 Change-Id: I7c8acf0f3c976ba40bf492a85a53c56a3254fcfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332057Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#797769}
-