- 18 Oct, 2019 40 commits
-
-
Marc Treib authored
Bug: none Change-Id: I8c605899ca10c4482390f8250bc79de35501fc4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869224 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#707361}
-
Alex Turner authored
The not-site-per-process isolated-code-cache web tests currently assume that cross-origin resources are cached when code cache site isolation is not active. This causes them to fail when the HTTP Cache is partitioned by Network Isolation Key. We thus disable the partitioned HTTP Cache for those tests and add a new test for when site isolation is not active, but the HTTP Cache is still partitioned. Bug: 1009628 Change-Id: I0d5d438d9564d3f659b93484a5bcc8aa56d2cd26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865421Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#707360}
-
Vasilii Sukhanov authored
Bug: 1015447 Change-Id: I252d93ab9269b83402300d9835797d5399a40a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868995Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#707359}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/72d92573ab57..1f4ca326d0db Created with: gclient setdep -r src-internal@1f4ca326d0db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: If68a6c7964a868ca7c4516b4c2df9d7798bd6e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869070Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707358}
-
behdad authored
This is a reland of 2fcffb28 The cause of crashes on webview_instrumentation_test_apk was that reporter was terminated without a termination status (instance being destroyed) in TerminateReporter method of compositor_frame_reporter. Original change's description: > Record latency for Impl thread in case of no begin main frame. > > This CL reports the latency in case of no begin main frame. > This can happen in any of the scenarios below: > > 1) WillBeginImplFrame -> DidFinishImplFrame -> DidSubmitCompositorFrame > > 2) WillBeginImplFrame -> WillBeginMainFrame -> BeginMainFrameAborted -> > DidFinishImplFrame -> DidSubmitCompositorFrame > > 3) WillBeginImplFrame -> WillBeginMainFrame -> DidFinishImplFrame -> > BeginMainFrameAborted -> DidSubmitCompositorFrame > > In these cases there will be no latency to report for stages of: > - SendBeginMainFrameToCommit > - Commit > - EndCommitToActivation > But the latency will be reported for the remaining stages. > > Bug: chromium:1003038 > Change-Id: Id0d6a65603b2b15a0ee04a6974a4bd0b2a5a803b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799026 > Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705964} Bug: chromium:1003038 Change-Id: I95651557c6e50b9f2e8ee3ae1043616fff8c88ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865535 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#707357}
-
Vlad Tsyrklevich authored
Enable GWP-ASan for malloc and PartitionAlloc by default for Windows and macOS and delete the former field trial config used to launch GWP-ASan. Bug: 896019, 912286, 956824 Change-Id: Icd146bc63dd6e50e6c5319905ed2f761ebff1bb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866604 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
Several tests are crashing because FilterInterfacesImpl() is called when starting a dedicated worker in a process that was never initialized or is dead, and process->GetChildIdentity() has a DCHECK against that. There is already an early return for a null process, so also check if it's alive. Bug: 1010866 Change-Id: I397e493456f1d61abfe3e247d7bc7d4c29cc6954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868769Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#707355}
-
Parastoo Geranmayeh authored
I was on a long leave and would need to take care of this in the coming days. Meanwhile, extending the flags to avoid expiry. Change-Id: I06449f52c74f8d8d32d1f57bd1b2f302bb2b50ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866088 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#707354}
-
Stepan Khapugin authored
Creates a new protocol to expose MainController internals to SceneController. Makes a bunch of ivars in MainController properties. Bug: 1012697 Change-Id: Ia1607c7ed75cb0b2edf99252d9c0342237e92b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848695 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#707353}
-
Mihai Sardarescu authored
There was significant confusion about the name of the function AuthenticationService::HaveAccountsChanged as it was not clear that it was only tracking if the accounts changed while Chrome was in background. This CL attempts to rename the variable and all the corresponding functions to make more clear its semantics. Bug: None Change-Id: Ic5a609de5ab04e60e9acadedbf72c1b978125e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827157 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#707352}
-
Marc Treib authored
Bug: 1004777 Change-Id: I6d0afbdac381e3d1b02535a98205e740860af89d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865171Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#707351}
-
Colin Blundell authored
This CL adds a browsertest that a navigation to a URL of type HTTPS succeeds by default and fails if the site has a mismatched certificate. We're adding this test now in anticipation of implementing SSL interstitials, at which point we'll expand the test to test the interstitial behavior. This CL also adds necessary infrastructure to enable navigations to URLs supplied by embedded test servers of type HTTPS: - A ContentUtilityClient implementation whose registration of network binders can be overridden. - An installation of content::NetworkServiceTestHelper::RegisterNetworkBinders() for weblayer browsertests. Note that I first tried a simpler mechanism for the above: Invoking the relevant parts of the body of content::NetworkServiceTestHelper::RegisterNetworkBinders() directly from browsertests_main.cc:main() when in utility processes. However, this appears to be too early to invoke these functions, as it resulted in the following: [223377:223377:1015/171544.292381:ERROR:sandbox_linux.cc(367)] InitializeSandbox() called with multiple threads in process utility. Try waiting for /proc to be updated. [223377:223377:1015/171544.327809:FATAL:thread_helpers.cc(104)] Current process is not mono-threaded! (iterations: 25) 0 0x7ff318df263f base::debug::CollectStackTrace() 1 0x7ff318b217ed base::debug::StackTrace::StackTrace() 2 0x7ff318b217a8 base::debug::StackTrace::StackTrace() 3 0x7ff318b73559 logging::LogMessage::~LogMessage() 4 0x7ff2f3401232 sandbox::(anonymous namespace)::RunWhileTrue() 5 0x7ff2f3400f71 sandbox::ThreadHelpers::AssertSingleThreaded() 6 0x7ff2f34012d1 sandbox::ThreadHelpers::AssertSingleThreaded() 7 0x7ff3067300e4 service_manager::SandboxLinux::InitializeSandbox() 8 0x7ff30672929b service_manager::Sandbox::Initialize() 9 0x7ff313276abf content::UtilityMain() Change-Id: I1c89b7b77b028aca06c28d0b83ab1a7dbcf9f117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859993 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#707350}
-
Henrique Ferreiro authored
Convert the implementation and all users of the chrome_cleaner::mojom::Parser interface. Bug: 955171 Change-Id: I244eda469c157da15ea5015f3af5ac554ca48734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833463 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#707349}
-
Marc Treib authored
Bug: none Change-Id: I7202497b938141a0488d99329733e478e07a1b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869216Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#707348}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5c7866ef4586..87ede8895026 git log 5c7866ef4586..87ede8895026 --date=short --no-merges --format='%ad %ae %s' 2019-10-18 eseckler@google.com processor: Extract ftrace parsing into FtraceModule/Parser Created with: gclient setdep -r src/third_party/perfetto@87ede8895026 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:141459049 Change-Id: I8b3d6d3e175fb3063c9c48c5d0c74cd9bd39ad2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868506Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707347}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I11d12f24f9a10116755d66f1471aee5c69000cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869071Reviewed-by:
-
Bence Béky authored
No need to obsolete old histograms because they were never logged. These histograms are logged from third-party library QUICHE at https://quiche.googlesource.com/quiche/+/refs/heads/master/quic/core/http/quic_spdy_session.cc#1081 QUIC_HISTOGRAM_COUNTS is defined at https://quiche.googlesource.com/quiche/+/refs/heads/master/quic/platform/api/quic_exported_stats.h#86 QUIC_SERVER_HISTOGRAM_COUNTS_IMPL is a no-op in Chromium. QUIC_CLIENT_HISTOGRAM_COUNTS_IMPL is defined at https://cs.chromium.org/chromium/src/net/quic/platform/impl/quic_client_stats_impl.h?l=14 Note how "Net." is prepended to the histogram name. Change-Id: I0497dfac94c7ef1d18340de072c9a674abed2e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859894Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#707345}
-
Lowell Manners authored
TBR=alexmos@chromium.org Bug: 1015784 Change-Id: I37a127ef05490c1f847f0213eb1212dce87e0ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868874Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#707344}
-
Patrick Monette authored
Bug: 1013168 Change-Id: I47b8d316977615bf96637c60d2141aa0da9a3978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865606 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#707343}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3f949687. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" ba49a3d6 "autofocus: Change the timing of 'flush autofocus candidates'" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I35fa0e722f5b3a95923d129a53d96343aeee56bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868890Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#707342}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/119e2197b75e..c66e004edcf3 git log 119e2197b75e..c66e004edcf3 --date=short --no-merges --format='%ad %ae %s' 2019-10-18 mbonadei@webrtc.org Adding missing RTC_EXPORT for component build. 2019-10-18 danilchap@webrtc.org Rename PacketBuffer tests to follow conventions 2019-10-18 nisse@webrtc.org Avoid Realloc in LibvpxVp8Encoder Created with: gclient setdep -r src/third_party/webrtc@c66e004edcf3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:1012256 Change-Id: Ie468a68054c5b5ead0650fe866c9fe4ade6f3426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869249Reviewed-by:
-
Marc Treib authored
...and reenable FailedDeleteUndecryptableLogins, which was flaky due to a race condition in ScopedFeatureList destruction. Bug: 1011193 Change-Id: I8be204ee1b4897cd275a8e743a2a93988eb9cefe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866518 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#707340}
-
Antonio Gomes authored
This CL changes the ownership of PeerConnectionTracker, as a preparation to Onion souping it. Reason: when in Blink, there is not a class corresponding to RenderThreadImpl. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ieff1e622d0226547632a1616c3e6c088961d91fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845802Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#707339}
-
Ioana Pandele authored
This is fixed by making sure the change to ILLUSTRATION_VISIBLE happens outside of the layout pass. Bug: 1013141 Change-Id: I325e37a2ab137553ac511d4cbad77b643ca13471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862692 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#707338}
-
Monica Basta authored
Remove unecessary sorting for |sorted_keys_| as there is no need for the list of keys to be sorted. We use |ProfileAttributesStorage::GetAllProfilesAttributesSortedByName| to get the profiles sorted by name. Bug: 1012182 Change-Id: I95af76e69e9eee2ca1e0b6ae672cad562b7db859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868871Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#707337}
-
Joshua Peraza authored
I happened to notice this typo while investigating an unrelated error. Change-Id: Ic4148929b3654a76cfd78f86a61a559b6c36a100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866976 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
-
Mathias Bynens authored
This patch loosens up the timezone ID validation so the form accepts empty-string inputs. Bug: chromium:993628, chromium:1015770 Change-Id: I2c0d552dcbc2a3cdf2c31cc129a7ad43b7240955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868996Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#707335}
-
Marc Treib authored
Bug: none Change-Id: I93bab47f0dd609e8f71c9427f8ae2821e995193e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868953Reviewed-by:
-
Roman Sorokin authored
This is a follow-up of CL:1855939 Bug: 833348 Change-Id: Id43ac9e389d88571463dd02f53e602d053ccdd56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865224Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#707333}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c6db4a035a17..299bea643826 git log c6db4a035a17..299bea643826 --date=short --no-merges --format='%ad %ae %s' 2019-10-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src a959deb00750..834ee546f93d (1 commits) Created with: gclient setdep -r src/third_party/angle@299bea643826 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: chromium:None Change-Id: I84911c1413d43bcd9a33542136d4da8e0e8601e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868972Reviewed-by:
-
Fergal Daly authored
Change-Id: Ic4d131f984df10da974e123447434c761f967282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868353Reviewed-by:
-
Tim van der Lippe authored
* Rather than guiding devs to getting the code and preparing a CL, ask them to first obtain Chrome Eng Review. This will make sure devs consider the checkout size and build times up front * Add a section about adding new Node packages. This was previously undocumented and not clear for new contributors. Bug: 1012733 Change-Id: I07317d40adb1130b8a1acb6de8b7bd547a09e876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867149Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#707330}
-
Jan Wilken Dörrie authored
This is a reland of 9293d5c8 Original change's description: > GCC: Fix base::internal::InvokeFuncImpl > > GCC doesn't like that the Value data member has no out-of-line > definition. The problem is triggered specifically only when compiling > > components/services/leveldb/leveldb_database_impl.cc > > which has lambda functions returning locally-defined classes. > > The current code works as-is in C++17 mode which introduces the concept > of inline variables, but in C++14 we need either an explicit out-of-line > definition or a function member instead of a data member. > > Use std::integral_constant for defining the value. > > Bug: 819294 > Change-Id: I5c68e14ce3fa9d8b4d8a2cb42d7f9b53938aabf3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862451 > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Jüri Valdmann <juri.valdmann@qt.io> > Cr-Commit-Position: refs/heads/master@{#706384} Bug: 819294 Change-Id: I3d5a52ddc6815516e2239f9347c60de06bf765a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865212Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#707329}
-
Chris Dziemborowicz authored
GlibcGetSizeEstimate calls a function pointer whose value is obtained dynamically with a call to dlsym. When compiled with Clang's Control Flow Integrity (CFI) checks (in particular -fsanitize=cfi-icall), the compiler cannot reason about the contents of the function pointer, so it elects to emit a ud2 "Undefined Instruction" opcode to kill the process instead of calling the function: 00000000055eaa50 <_ZN12_GLOBAL__N_120GlibcGetSizeEstimateEPKN4base9allocator17AllocatorDispatchEPvS5_$bd8608a96952500691d600ccbd08bddd.cfi>: 55eaa50: 55 push %rbp 55eaa51: 48 89 e5 mov %rsp,%rbp 55eaa54: 8a 05 9e e9 dd 05 mov 0x5dde99e(%rip),%al # b3c93f8 <_ZGVZN12_GLOBAL__N_120GlibcGetSizeEstimateEPKN4base9allocator17AllocatorDispatchEPvS5_E6fn_ptr> 55eaa5a: 84 c0 test %al,%al 55eaa5c: 75 36 jne 55eaa94 <_ZN12_GLOBAL__N_120GlibcGetSizeEstimateEPKN4base9allocator17AllocatorDispatchEPvS5_$bd8608a96952500691d600ccbd08bddd.cfi+0x44> 55eaa5e: 48 8d 3d 93 e9 dd 05 lea 0x5dde993(%rip),%rdi # b3c93f8 <_ZGVZN12_GLOBAL__N_120GlibcGetSizeEstimateEPKN4base9allocator17AllocatorDispatchEPvS5_E6fn_ptr> 55eaa65: e8 56 39 d6 ff callq 534e3c0 <__cxa_guard_acquire> 55eaa6a: 85 c0 test %eax,%eax 55eaa6c: 74 26 je 55eaa94 <_ZN12_GLOBAL__N_120GlibcGetSizeEstimateEPKN4base9allocator17AllocatorDispatchEPvS5_$bd8608a96952500691d600ccbd08bddd.cfi+0x44> 55eaa6e: 48 8d 35 79 e9 95 fb lea -0x46a1687(%rip),%rsi # f493ee <_ZN5blinkL36kDefaultNativeMemorySamplingIntervalE+0x1d8c8e> 55eaa75: 48 c7 c7 ff ff ff ff mov $0xffffffffffffffff,%rdi 55eaa7c: e8 8f 9d 76 05 callq ad54810 <dlsym@plt> 55eaa81: 48 89 05 68 e9 dd 05 mov %rax,0x5dde968(%rip) # b3c93f0 <_ZZN12_GLOBAL__N_120GlibcGetSizeEstimateEPKN4base9allocator17AllocatorDispatchEPvS5_E6fn_ptr> 55eaa88: 48 8d 3d 69 e9 dd 05 lea 0x5dde969(%rip),%rdi # b3c93f8 <_ZGVZN12_GLOBAL__N_120GlibcGetSizeEstimateEPKN4base9allocator17AllocatorDispatchEPvS5_E6fn_ptr> 55eaa8f: e8 dc 39 d6 ff callq 534e470 <__cxa_guard_release> 55eaa94: 0f 0b ud2 55eaa96: cc int3 55eaa97: cc int3 55eaa98: cc int3 55eaa99: cc int3 55eaa9a: cc int3 55eaa9b: cc int3 55eaa9c: cc int3 55eaa9d: cc int3 55eaa9e: cc int3 55eaa9f: cc int3 This change uses the base::UnsanitizedCfiCall utility to bypass the cfi-icall check for this function call. This is necessary in cases where a dynamically loaded function needs to be called. This change also stores the function pointer in read-only memory using base::ProtectedMemory, which is the recommended pattern to prevent the pointer from being modified to hijack control flow. See, for example, the implementation of GetMonitors [1] and https://crbug.com/771365. [1] https://cs.chromium.org/chromium/src/ui/base/x/x11_display_util.cc?l=23-58&rcl=5cdcaedb360ea99534aed54eddd552275705f1b9 Note: The issue is reproducible in Chromium Linux x64 builds built with is_cfi=true (the default) and use_allocator=none (not the default). By default, Chromium Linux x64 builds use_allocator=tcmalloc instead. The issue was originally encountered in a build of Chromium Embedded Framework, which builds with is_cfi=true and use_allocator=none for Linux x64 builds. Change-Id: I286db32657b76d8dddd9b99902144cab584e3547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868513 Auto-Submit: Chris Dziemborowicz <chrisdz@google.com> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Chris Dziemborowicz <chrisdz@google.com> Cr-Commit-Position: refs/heads/master@{#707328}
-
Matt Menke authored
Also add a value to enable it for a particular NetworkSession, though currently nothing enables it. Followup CLs will add field trials and enterprise policies to do so, and also hook up Network Service APIs to correctly add entries to the cache for a particular NetworkIsolationKey. Bug: 993801 Change-Id: I37887a018d9462ecabb80b924b4c44d3ddbee270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863469Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#707327}
-
Peter Kasting authored
Bug: 82078 Change-Id: If21fe11af38287e0e61e19edb595411d96805e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867811 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/95524e4897be..5c7866ef4586 git log 95524e4897be..5c7866ef4586 --date=short --no-merges --format='%ad %ae %s' 2019-10-18 eseckler@google.com processor: Extract ftrace tokenization into FtraceModule/Tokenizer 2019-10-17 treehugger-gerrit@google.com Merge "trace_processor: add set bits iterator" Created with: gclient setdep -r src/third_party/perfetto@5c7866ef4586 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:141459049 Change-Id: I9097fc18183708cf28c158f5950f8609a9338744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868504Reviewed-by:
-
Wanming Lin authored
This CL enables SuspendNFCOperations/ResumeNFCOperations in mock NFC backend and handles NFC push operations and reading operations in suspended state. Bug: 996250, 520391 Change-Id: Id32f8b720cab8a2e80f20772a9c7d02578671206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864391 Commit-Queue: Wanming Lin <wanming.lin@intel.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#707324}
-
Noel Gordon authored
All directory items now derive from TreeItem: this constant is unused, and can be removed. Also use this.rowElement for the labelElement in class TreeItem, so it works in the FILE_NG_ENABLED case as well. Bug: 992819 Change-Id: I1997e7884adf3a956294acdcf043dec487160e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868355 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#707323}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e99b9182214f..3cdd6444cf91 git log e99b9182214f..3cdd6444cf91 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 rharrison@google.com Check text->str before destroying (#2981) 2019-10-17 kubak@google.com Disallow use of OpCompositeExtract/OpCompositeInsert with no indices (#2980) 2019-10-17 rharrison@google.com Add fuzzer for spirv-dis call path (#2977) 2019-10-17 rharrison@google.com Check binary->code existence before destroying (#2979) 2019-10-17 akb825@gmail.com Improved CMake install step. (#2963) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@3cdd6444cf91 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,jmadill@google.com Bug: None Change-Id: I94bcdd8a19fd9d1cf4e4f2b6a087adc88d272abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869009Reviewed-by:
-
