- 06 Aug, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/672c47689dc1..b72037527fd5 2020-08-05 herb@google.com Revert "Switch GN defs on Mac and iOS to use frameworks, take 2." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: I196ee68d138bdc3bcdb8df6e855795e2292d233d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339406Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795300}
-
Kuo Jen Wei authored
To avoid requiring to sort out js dependency for closure compiler check manually, this CL gather checked file into a single js_type_check and remove all 'deps' label. Bug: none Test: ninja -C out/Release chromeos/components/camera_app_ui/resources/src/js:closure_compile Change-Id: I2341609e243164ae640243642424739e2c5bd9b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336246 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#795299}
-
Brian Sheedy authored
Restricts the test disable for the Telemetry minidump symbolization tests to Windows 7, as the issue that caused it to be disabled in the first place only occurred on that version. These are important tests to prevent symbolization regressions from making it in, so they disable should be as strict as possible. Bug: 1084931 Change-Id: If77bccf48420564a1792b2dad64c95356bed53af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340293 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#795298}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9a43f48ed4cd..f52572f002a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7f61bb73ce89e8405cc27bf76000b88d1cd39dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340404Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6dacd170b8de..ded65da11a18 2020-08-06 dberris@chromium.org debt: Remove IP-based authorisation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1036507,chromium:1051243 Tbr: oysteine@google.com Change-Id: I67a38856cf39361c25c7df098f01ba6a3393e71d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340274Reviewed-by:
-
Ben Wagner authored
Bug: 1018739 Change-Id: I1a68eac36ec536522d87a78b112a42e4609bed17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339717Reviewed-by:
Mike Klein <mtklein@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#795295}
-
David Schinazi authored
This is a followup to https://crrev.com/c/2337542 which forgot to update the documentation. R=nharper@chromium.org Bug: 1112925 Change-Id: Id1ed5fe2421367a26828da85ebae257add8c3bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340424 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#795294}
-
Charlene Yan authored
This regression was caused by this refactor: https://chromium-review.googlesource.com/c/chromium/src/+/2324113 The original code for building the submenu would skip ID values for groups that would not appear in the submenu. (The Build() method would call GetOrderedTabGroups then skip over groups that should not show in the submenu.) Skipping ID values was not done after the refactor since the subclasses would call the base classes with a vector of MenuItemInfo to populate the submenu. Bug: 1112719, 1112721, 1108062 Change-Id: I4a3490d646c553d1c60dd548fa13f53df9183561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337547Reviewed-by:
Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#795293}
-
edchin authored
Previously, a nil destinationIndexPath would be interpreted as position zero. This interprets nil as the last position. Bug: 1102570 Change-Id: I030c32eaf1bf400b6b7d08bb9b0293c858cf6366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339405 Commit-Queue: edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#795292}
-
Stephen Martinis authored
The builder is actually in the chromium.mac builder group. Also adds GPU tests which are useful to be able to run. Bug: 1106083 Change-Id: I0367ad93e72b52c276fa9f4b5b844625e840d87a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339935 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Auto-Submit: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#795291}
-
James Hawkins authored
Added a unit test to help confirm success of the migration Bug: 1045266 Test: OSSettingsTimezoneSubpage* Change-Id: Ifd9d0f07dda4da83e19bab7b1d708bd61be5ad0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339279Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#795290}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/92e5a9299b38..dba1d65a1999 2020-08-05 saagarsanghavi@google.com [Fixed from older branch] Timing/RDB for lower-level checks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1106943 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I9f851c1e171b6c025c7d97c23ca729ac6e88cae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340272Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7ce4924a35ea..fa4b74d479aa 2020-08-05 rharrison@chromium.org Remove temporary disabling of validation check If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I4d013eebd52fe7a1f0326bd7c6e3e92d05f65908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340267Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9a43f48ed4cd..f52572f002a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I701c21e125fef52042f9270bc4dc8731030f08d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339225Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I8a88e482447e1cff087f95e0ed22c90b8fa7207e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339397Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795286}
-
Miriam Zimmerman authored
Further, use the empty string for the email rather than "anonymous_user", since the listnr UI treats an empty email field specially and recognizes the report as being anonymous, but does not do so for the string "anonymous_user". BUG=chromium:1112012 TEST=browser tests and component tests TEST=sent two feedback reports; one with email set and one without Change-Id: I3fa1341151a8daae82a39d8b47b1276d6a7c1721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335891 Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#795285}
-
Noah Rose Ledesma authored
The global media controls UI will now highlight the current audio device in its list of devices. Bug: 1096254 Change-Id: I4ad55992ac9455509eea3e59a83bdab269a5c3e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339381Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Cr-Commit-Position: refs/heads/master@{#795284}
-
Nate Chapin authored
Change-Id: I672c7d579d0d76ddbbabb60e99782cc286568959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339790 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#795283}
-
Xiaoqian Dai authored
Bug: 1113032 Change-Id: Ief8e2a14d2367ad1c8cc65aecd89aa29dcb4d81c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337634Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9a43f48ed4cd..f52572f002a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Idec160f3c108604a3a2c8c5d7e012d72df6964d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340323Reviewed-by:
-
Kristian H. Kristensen authored
The original CL didn't account for most clients passing modifier 0 to mean "don't know modifier". The 0 modifier is DRM_FORMAT_MOD_LINEAR, while DRM_FORMAT_MOD_INVALID is to be used to indicate that the client doesn't know the modifier and triggers the legacy implicit layout discovery: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/blob/master/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml#L133 Specifically, what broke was Intel GPUs using tiled buffers and importing those as EGLImages without specifying a modifier. Without a modifier, the GLES driver will get the tiling information from the kernel. One we started forwarding the DRM_FORMAT_MOD_LINEAR modifier coming from the clients, that would take precedence and the driver would view the buffer as linear, even though it was tiled. We'll have to fix the various clients, but in the interim, we can add support for non-linear modifiers by treating 0 as DRM_FORMAT_MOD_INVALID like before. This does the right thing for linear buffers for all GPUs and keeps the mismatch in the Intel case working. At the same time it allows modifier-aware clients to pass in explicit modifiers so that we can enable more efficient buffer layouts. BUG=b:145579089, b:79682290, b:162704898, chromium:1112017 TEST=wayland_rects_client --use-drm=msm and verify modifiers get passed Change-Id: Ib00d4d6fe96e957c1f66205f2f5f515c09f3aabd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340164 Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#795280}
-
Andreas Papacharalampous authored
when clicking the "Manage extensions" button in the context menu, we go to the chrome://extensions page for that extension instead of all the extensions. Bug: 986890 Change-Id: I1e17b4ad0ffebc5c38591cc3fae2953efd8aa0fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233303Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#795279}
-
Xiaohui Chen authored
* Unified the logic around when to turn ambient mode off around screen off. This replaces the lid state, suspend state handlers. * Fixed a crash during shutdown when image download is scheduled Bug: b:162597832 Change-Id: Ie64e5464c37acda3e0fa638c9343e78c4dc0c17d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333540Reviewed-by:
Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#795278}
-
Jimmy Gong authored
Adds new test suite for PrintingManager. Bug: 1111684 Test: PrintingManagerUnittest Change-Id: Iea7abbea125e78e8e204360cf8c9a6354dcd4dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332045Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#795277}
-
Luis G Garcia authored
Tests: - Camera image texture is not null after 10 frames. - Camera image texture is not null after multiple consecutive calls to getCameraImage(). - No exceptions occur if site deletes camera image texture before API does. Bug: 1112356 Change-Id: I0149f47f143f47945312b08164b2064c636c972b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333306Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Luis Garcia <luisggarcia@google.com> Cr-Commit-Position: refs/heads/master@{#795276}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f52572f002a6..dcb6f8084e45 2020-08-05 dproy@google.com Merge "[metrics] Change the example chrome metric to not clash with chromium" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1abc336eec43ebcd4ac01f9c862c25900a96c155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339832Reviewed-by:
-
Daniel Rubery authored
This CL replaces the existing metric, SBClientPhishing.PreClassificationCheckFail with the new histogram SBClientPhishing.PreClassificationCheckResult. The new histogram will also record how often pre classification checks all pass, giving us complete information about the result of pre classification checks. This makes it possible to easily answer questions like, "what proportion of the time do we skip classification due to the whitelist?", which previously required estimation combining multiple histograms. This CL also replaces the histogram macros in client_side_detection_host.cc with histogram functions, since they are not logged that frequently. Change-Id: Ia8ee8bcc212676a1fb7dafd57b9afb5ebb84e6ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337410Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#795274}
-
Alex Danilo authored
When users have no default app for a file type we choose the application task that appears as the default from a linearly ordered set that's constructed in (sort of) arbitrary order. Add an extra pass over candidate matches that checks if an installed application was included as a fallback before we check for any view-in-browser fallback. --gtest_filter="*ChooseAndSetDefaultTask_FallbackTextApp" Bug: 1111399, 1112406 Tests: unit_tests Change-Id: I328b79e3ababe2752bd7c1f8930568ea5f696d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332079Reviewed-by:Bugs Nash <bugsnash@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795273}
-
Christoph Schwering authored
This CL fixes that Password Manager interferes with Autofill's form structure cache by calling AutofillExternalDelegate::OnPopupShown(). Bug: 1108116,1113241 Change-Id: I547aef08f7b29dfce395fe483733c30a0621a7b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333203 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#795272}
-
Bettina authored
Client side detection will be made available on Android. This CL allows the needed files to be compiled on Android. additional compilation of CSD related files. They are needed to reduce phishing and improve telemetry on Android. Binary-Size: The increase in size is due to the Bug: 1108080 Change-Id: I002520d0ff8dbd58cb0c18df518049c35857a0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311898 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#795271}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2b8940ee5e08..672c47689dc1 2020-08-05 michaelludwig@google.com Replace 'master' with 'top-level' or 'gradient' If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: I7c7336868d9d9c968918faa74c6329696c1f7bea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340343Reviewed-by:
-
Etienne Bergeron authored
Bug: 1111044 Change-Id: I4772cf9f6246a498301cb9893caccddcd3c18f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332324 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#795269}
-
Zhuoyu Qian authored
Rename SignallingReceiver to SignalingReceiver to use the same naming as the spec. Bug: 1044584 Change-Id: I43465c08d073a61f87a659d791a814a41c4c8bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336343Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#795268}
-
Brian Malcolm authored
This is intended to replace the DeviceUserWhitelist policy. The old policy will still be used in the absence of the new one for at least a few releases of Chrome. BUG=chromium:1103816 Change-Id: Ie4cb3376ffb92c41bb7036f23e4ee9cb182c39b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339500Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Cr-Commit-Position: refs/heads/master@{#795267}
-
Thomas Lukaszewicz authored
This is a reland of 0f67189b Original change's description: > Add duration based performance metrics to Tab Search > > This CL introduces the following UMA histograms: > TabSearch.WebUI.InitialTabsRenderTime > TabSearch.WebUI.LoadCompletedTime > TabSearch.WebUI.LoadDocumentTime > TabSearch.WindowOpenDuration > > These histograms aim to measure various duration related metrics for > the Tab Search feature. See the spreadsheet below for more details: > > https://docs.google.com/spreadsheets/d/15ygVicrrbJUJOzTn6IlnogxktExXJQzZ2PCSGMQFpWg > > Bug: 1099917 > Change-Id: I9d9db7abe2554d682fb0211eceaa6a07a567ba24 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321232 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#793736} Bug: 1099917 Tbr: isherman@chromium.org Change-Id: Ibc45739ebe71dfbf73f0d9c4d40c367c89ab686b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334817 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#795266}
-
adamta authored
Modifies standard Discover feed header to match mockups. New Discover feed header UI for when feed is hidden. Animates transition between the two states. Bug: 1085419 Change-Id: Ib300b42fd0942759ec2aea2b0d3a027d1969423a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336293 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#795265}
-
David Grogan authored
The test is minimally altered from the repro in the bug. It fails when I disable FlexNG, but passes in Chrome 84 and Firefox. Fixed: 886592 Change-Id: Ieb7be3619c0095c185b405703c384864d9046cd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337416 Commit-Queue: David Grogan <dgrogan@chromium.org> Auto-Submit: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#795264}
-
chinsenj authored
Currently if a user is previewing a wallpaper and they enter overview mode it causes a visual glitch where the overview item for the wallpaper picker is transparent. This CL makes it so Ash can emit a new event through the chrome.wallpaper_private API, onClosePreviewWallpaper, to tell the app side of wallpaper preview to close its front-end. This CL also adds the necessary handling for the new event to the wallpaper manager. Bug: 895265 Change-Id: I127fcedcfbd8c19564043910b3eac793dac46995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329414Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#795263}
-
wutao authored
This patch will fix no albums shown when going to the ambientMode/photos page directly. This patch is also a preparation of new UX to show more info on the topic source radio button based on album numbers in Google Photos. There are two APIs to get all required info: GetSettings and FetchPersonalAlbums. Previously, the ambientMode page only needs data from GetSettings, but the new UX will need data from both APIs. Similarly, the ambientMode/photos page needs data retrieved from both APIs. This patch waits the data and then render the Settings UI. Bug: b/159747583, b/161928422 Test: new js unittest and new AmbientModeHandlerTest.* Change-Id: I88961ca94708563a3719f16c8745bf9cfbad489f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324180 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#795262}
-
Daniel Rubery authored
This CL profile-keys the URLLoaderContext used by the RealTimeURLLookupService so that we can use separate network contexts for these communications. Bug: 1049833 Change-Id: If6badd5b5cafd61994656f444401e73578697faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337291 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
-
