- 22 May, 2020 28 commits
-
-
Christian Biesinger authored
This makes it easier to use CalculateFixedCrossAxisSize, which will help in fixing bug 1083020. Change-Id: I1fba49f69d781633256d8244d3d502f297fe32f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212981 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#771287}
-
Nico Weber authored
buildbot was turned down a while ago, so this should no longer be needed. Bug: 986488 Change-Id: Ie7496a5647814f6d526bfe212a4637873c90a37b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212318 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#771286}
-
Eric Willigers authored
The Blink flag UnifiedPointerCaptureInBlink has been stable since 2019-03. Bug: 919908 Change-Id: I76d29ca50205a9cf9a3abe14a295f8040e4bd6ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208324 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#771285}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9f35145a1ed0..4ae21d7942e1 2020-05-21 thestig@chromium.org Add a pixel test to show incorrect pattern rendering. 2020-05-21 thestig@chromium.org Add a presubmit check for AUTHORS. 2020-05-21 thestig@chromium.org Make presubmit scripts more consistent with Chromium's. 2020-05-19 tsepez@chromium.org Give some members better names in fxcrt. 2020-05-19 thestig@chromium.org Sync AUTHORS file format with Chromium's. 2020-05-19 thestig@chromium.org Update third_party/base/numerics/ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1015233 Tbr: pdfium-deps-rolls@chromium.org Change-Id: Iad5406db413ecc1876ac93f48e078d01ddb1d3a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213019Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771284}
-
Matt Menke authored
It was doing host resolutions with an empty NIK using a deprecated API. Bug: 1082280 Change-Id: I872e4093a39ad521ca92d3cefce775c42b46d1b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210620Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#771283}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/10daf41d4115..8cce349b0a59 2020-05-22 jrw@google.com Added support for libprotobuf-mutator. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: If515d38b65aaca4a77dd2cf6411f6cc86b842f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213223Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/db1a7975aacc..74f67e29f7ee 2020-05-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I44c44a2214025013b1f2a98d24bf94af5b349f15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212764Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d1285b131bcf..317dce5c81c0 2020-05-21 herb@google.com Drop SkTextBlobs with > 2M glyphs. 2020-05-21 csmartdalton@google.com Add a tessellation mode that uses indirect draws 2020-05-21 csmartdalton@google.com Disable WebGL antialias in CanvasKit 2020-05-21 nifong@google.com Revert "Wide color gamut support and working example." 2020-05-21 nifong@google.com Wide color gamut support and working example. 2020-05-21 kjlubick@google.com Update infra deps 2020-05-21 herb@google.com Light cleanup of GrTextBlob cache 2020-05-21 nifong@google.com Upgrade to emscripten 1.39.16 2020-05-21 johnstiles@google.com Remove incorrect doc comment about constraint argument. 2020-05-21 michaelludwig@google.com Only use scissor state for native clears 2020-05-21 reed@google.com Revert "Revert "move onto new factories for SkMatrix"" 2020-05-21 jvanverth@google.com Add D3D draw support 2020-05-21 reed@google.com Revert "move onto new factories for SkMatrix" 2020-05-21 bungeman@google.com Remove OneLineShaper::increment. 2020-05-21 bungeman@google.com Iterate over unresolved instead of cycling. 2020-05-21 reed@google.com move onto new factories for SkMatrix 2020-05-21 kjlubick@google.com [canvaskit] Fix some other usages of .ready If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1080481 Tbr: lovisolo@google.com Change-Id: I8041eed02f76475e751a2a90d1ca4367f64eb0de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213020Reviewed-by:
-
Bartek Nowierski authored
We want to qualify everything with const and volatile "just in case", so that everything compiles if the underlying type T is also qualified. In practice it doesn't matter, because the qualifiers are dropped when casting to uintptr_t, and brought back when casting to T only if T has those qualifiers. Bug: 1073933 Change-Id: Ic054182924ce43f8e753390c0cbc7c225991eced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204001 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#771279}
-
Brian Sheedy authored
Enables info_collection, trace_test, and webgl_conformance_validating_tests on CrOS and suppresses found failures. TBR=ynovikov@chromium.org Bug: 1080424 Change-Id: I3f5c2545e36b437e67381942d3a38737b90dab00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211055Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#771278}
-
James Cook authored
SplitSettingsSync leaves sync disabled until the user completes the sync consent OOBE dialog. ExternalPrefLoader was incorrectly deciding that sync would never enable and starting default app loading before priority prefs are synced. This results in default apps loading too early, potentially before the user's language is synced. Add a pref for whether the sync consent screen is completed. If the user hasn't completed it, observe for that pref changing, then wait for OS priority pref sync to complete. Bug: 1078479 Test: added to unit_tests and browser_tests Change-Id: If633133acccfd43fe80b727b45080599ad569ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207967Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#771277}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/93fc7d718e4c..96a80283cc0f 2020-05-21 kbr@chromium.org Advertise filtering support for FP16 luminance/alpha formats on ES 3.0. 2020-05-21 cnorthrop@google.com Tests: Add trace of Egypt to TracePerfTest If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Test: Test: angle_perftest --gtest_filter="*Trace*egypt*" Change-Id: Ic65b729cad86bfa6036b25fa524a338dbdfe11eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213011Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/bd0ad7921d3d..65ee6497d620 2020-05-22 enga@chromium.org Fix VulkanImageWrappingUsageTests.ClearImageAcrossDevicesAliased If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I7d0ec72e5cf032466d04cfa3eb81e01666bc7c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213221Reviewed-by:
-
Erik Chen authored
If there's a custom lacros path, then this is probably a developer build and they probably want logging enabled. Logs are dumped in the lacros user-data-dir with name lacros.log. Change-Id: I9d23bcc3ed145e5e0cf9a11c3e1bd6c6b26332ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211126 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#771274}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590091165-6474854792ed84c3f97a488e2950f553c812b299.profdata to chrome-mac-master-1590105571-9ab15c0da41a7aac619a0ba03729f850a564de99.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie259f6cb32cc7070f0c1b2940eb019e76f70a7e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213224Reviewed-by:
-
Ilia Samsonov authored
Adding optional high dpi builder to help triage, and later rebaseline, high dpi blink web tests configuration. Requires https://chromium-review.googlesource.com/c/chromium/tools/build/+/2203463. Bug: 1068400 Change-Id: I6e0f1ab41c133bba312982d3b0e697c4c41f7369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2177372 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#771272}
-
Shawn Gallea authored
Only create media_overlay_ if ENABLE_MEDIA_OVERLAY is defined Bug: b/156276792 Test: Build cast_shell Change-Id: I490ab1ff2fe45ef516fa108b8e30389abb052fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212969 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#771271}
-
Kramer Ge authored
Software compositing is not supported on ChromeOS. Thus, GpuProcess_readback_webgl_gpu_process is marked permanently skipped. Bug: 1084796 Change-Id: I0b11acc5fa8ff22ed7df51868aedfc1eda35a6e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212549 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771270}
-
Scott Violet authored
This converts kHungRendererDelay to a base::TimeDelta and moves constants that are only used in a single place to where they are used. BUG=none TEST=none Change-Id: Ib163eb931406d252ba696d6f4a974e8ef997608e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209561 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#771269}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/942c97d6260f..db1a7975aacc 2020-05-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ic451fe7e9f2da7949a5d978173a7ccf518f5bdfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213016Reviewed-by:
-
Henrique Ferreiro authored
This CL moves cursor_factory_ozone.* to ui/base/cursor/cursor_factory.* to serve as a superclass for all platform cursor factories. Bug: 1029142, 1040499 Change-Id: I94370bfe98efd3af4c6596e2de652370d011ea7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188395 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#771267}
-
Andrey Kosyakov authored
This is a test for http://crrev.com/c/devtools/devtools-frontend/+/2200666 Bug: 10781354, 1081270 Change-Id: I63a1e77a1ac76184d664b4a29e67ba519c74a4ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200430 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#771266}
-
John Lee authored
Change-Id: I5923a4433bcbfd1a9538d533958b49beb1f17aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210910 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#771265}
-
Katie D authored
The DistillerRenderFrameObserver::SetIsDistillerPage was sometimes being called after DistillerRenderFrameObserver::DidCreateScriptContext, which caused the Distiller Javascript object never to be created and injected into the page. SetIsDistillerPage happened via a mojom call from the Browser process when WebContentsObserver::DidFinishNavigation occurred. It wasn't guaranteed to happen in any particular order. This was making a test flaky; relanding the test will happen in a separate change. It is cleaner to simply check if the page is distilled by checking that the URL is correctly formatted as a distilled page. AX-Relnotes: n/a Bug: 1016615, 1075439 Change-Id: I12cb5bb9e2975aca25a79333f251d1a28546f32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209281Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
-
Asanka Herath authored
>> [privacy_budget] Introduce identifiability study settings >> >> The study settings provides gating criteria for filtering reported UKM >> entries. >> >> Bug: 973801 >> Change-Id: I7369965e8476a2d119e7ac4feaa93215534a37f7 >> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036807 >> Commit-Queue: Asanka Herath <asanka@chromium.org> >> Reviewed-by: Caleb Raitto <caraitto@chromium.org> >> Reviewed-by: Nico Weber <thakis@chromium.org> >> Cr-Commit-Position: refs/heads/master@{#769198} > > Reverted-by: Peter Conn <peconn@chromium.org> > Cr-Revert-Position: refs/heads/master@{#769210} > Cr-Revert-Reason: Unlisted dependency Cq-Include-Trybots: luci.chromium.try:android_compile_x64_dbg Change-Id: I56fedbe940150742199c5b94bcaba2cf13c8dae6 Tbr: caraitto@chromium.org, thakis@chromium.org Bug: 973801, 1083161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204137 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#771263}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/9b28b9695df9..10daf41d4115 2020-05-21 vecore@google.com Fixed IPEndpoint::ToString() so it prints the port and ip 2020-05-21 jophba@chromium.org Update style guide 2020-05-21 jophba@chromium.org Add basic functional tests for the CastAgent If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I660e72c230ec455f5be4e3a540cc7c74cdd449f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213012Reviewed-by:
-
Xiaohan Wang authored
kLogJsConsoleMessages feature is used to control whether to log JS console messages, which provides developers a quick way to control whether to log JS messages. For example, some JS code uses a lot of log messages which can be noisy. Currently this feature only take effect on Android where it's disabled by default. This CL change the logic to check this feature on all platforms. On non-Android platforms the feature is enabled by default, which matches the existing behavior. To disable JS console messages in terminal, use --disable-features=LogJsConsoleMessages Change-Id: I0f42e71d63f55369d1d6721c2a1c5eb3b3ef4bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208352Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
-
John Lee authored
Fixed: 1072512 Change-Id: I3db9c6fd55dfc4620aa97dba6471719c6ba2b6ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210728 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#771260}
-
- 21 May, 2020 12 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a662485bdfb8..cd9e807ee9a7 2020-05-21 treehugger-gerrit@google.com Merge "Use stack_id instead of track_id for experimental_slice_layout_generator" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I68d400bd60c6029d84bee0d30d3674f85bc0c1c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213009Reviewed-by:
-
Peter Kasting authored
Not only is this shorter, it fixes a bug where operator=() failed to copy one of the members. Bug: none Change-Id: I778a093ac7e31e38319421b76a5c174cd8b7d5b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213023 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Peng Huang authored
This reverts commit aaa46efe. Reason for revert: the problem is fixed with https://crrev.com/c/2212811. This workaround is not necessary anymore. Original change's description: > skiarenderer: fixing flickering with skia renderer on Android > > The problem is because a recent CL https://crrev.com/c/2149640 which > implements ProduceOverlay() but doesn't provide gpu fence for the > overlay access. Workaround the problem by creating a gpu fence for the > primary plane in SkiaOutputDeviceBufferQueue when GL is used. > > Bug: 1082519,1085485 > Change-Id: I86431c866d94ee2f1e29a939aed11f6dab6a57b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212548 > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Auto-Submit: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771155} TBR=penghuang@chromium.org,vasilyt@chromium.org Change-Id: Ifa80a1fa5f89d69a9ffd9a3fb15b2e0820612535 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1082519, 1085485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213104Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#771257}
-
Jun Kokatsu authored
addHistograms can be called from either page load or refresh button. This change fixes a bug where refresh button would append new content instead of replacing them. Bug: 1084234 Change-Id: Ibf041f1c6c85535c88fae34bbb9ef75cdc44660e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207957Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Nate Fischer authored
No change to production logic. This disables a flaky WebsitePermissionsFetcherTest test case. TBR=finnur@chromium.org Bug: 1085592 Test: None Change-Id: Ide2fbb82f52aa6fcd77e2367f49ee8bdfc0d5547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212970Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771255}
-
Abigail Klein authored
The caption bubble controller receives a stream of transcriptions from the speech service to be set in the caption bubble. For long sessions, this text could be very long, which would slow down the rendering of the text in the caption bubble label. This CL removes characters from that string. We don't want to remove some arbitrary N characters, because then the user will be able to see the string re-wrap. We want to remove characters up to a line break. Suppose CaptionBubbleControllerViews::OnTranscription receives the string abcdefghijklmnopqrstuvwxyz. And suppose the caption bubble only shows 9 letters per line. The layout manager ensures that only the last two lines (starting at q) are visible. abcdefgh ijklmnop qrstuvwx yz In order for the user to not notice any line wrapping, we need to remove the characters a-p (index 0-17). To get the right number of characters, CaptionBubbleControllerViews gets the location of the line breaks from RenderText and cuts the stored text string up to the index where there is a line break that is not visible to the user. Bug: 1055150 Change-Id: Ifb59f5bcba39d0ce3de097a9f86bfbb11cbf16db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187137 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#771254}
-
Wenyu Fu authored
Bug: 1084756 Change-Id: Ife7f51c22c666d3bf087dba02706718177dc5c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212926 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#771253}
-
Ben Pastene authored
Moves all OOBE-related tests into another execution of browser_tests, and marks it experimental. Bug: 1071693 Change-Id: Ic790aa28c99486140195605ebad0956a14a0f8f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209557 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Chong Gu authored
Help debug issues specific to AEMU. Bug: 1084693 Change-Id: I106a1f03d9f81a183deb6c33afbc1abea51671a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212467Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#771251}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e5d042ae732b..5598ba3c0e6f 2020-05-21 mthiesse@chromium.org Bring back mkdir call in PushChangedFiles If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1076580 Tbr: skyostil@google.com Change-Id: Ic07b9510f9f350ea379df78af99c7deae4064994 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212723Reviewed-by:
-
David Bokan authored
This CL implements the compositor-thread<->main-thread routing and flow for cases that need to be main thread hit tested under scroll unification. Scroll unification is a project to remove all gesture scroll handling from Blink and rely solely on the compositor gesture handler. Design doc: https://docs.google.com/document/d/1smLAXs-DSLLmkEt4FIPP7PVglJXOcwRc7A5G0SEwxaY/edit Today, some scrollers cannot be scrolled on the compositor thread. There's a few primary reasons why this can happen: - The scroller is not backed by a cc::Layer so we can't hit test it. - Unreliable hit test in the presence of squashing layers - The scroller has a main thread scrolling reason. It has a cc::Layer and we can hit test it but, because of style reasons, scrolling it from the compositor would produce incorrect results. Under scroll unification, if the compositor can determine the correct ScrollNode to use, it can perform these kinds scrolls by mutating just the scroll node, then wait on a BeginMainFrame and commit to repaint the layers and update the property trees, just like today's main thread scrolling but without invoking the input handling code paths in Blink. In https://crrev.com/c/2089973 we made it so that the entire scroll tree is passed to the compositor. Thus, the first two cases above can be addressed by asking the main thread for the element_id of the ScrollNode to use. This CL implements the plumbing for this functionality. Background: When a gesture scroll begin (GSB) arrives, it first hits the WidgetInputHandlerManager. This will first dispatch to the compositor by passing it to InputHandlerProxy. In turn, InputHandlerProxy calls LayerTreeHostImpl::ScrollBegin. If LTHI determines it cannot handle the scroll, IHP returns into WIHM (via callback) which can queue events to the MainThreadEventQueue bound for Blink: DID_NOT_HANDLE v----------<---------+ | | GSB+-------------------v-------+ + -->+ WidgetInputHandlerManager +-->InputHandlerProxy<->LayerTreeHostImpl +---------------------------+ GSB | v +-------------+-------------+ | BLINK | +---------------------------+ Today, if the IHP returns event disposition DID_NOT_HANDLE to indicate that the compositor didn't consume the event, WIHM will forward the event and further events in the same sequence to Blink. The compositor will not be involved in handling these events. Changes in this CL: In this CL, we add a new compositor event disposition REQUIRES_MAIN_THREAD_HIT_TEST. This indicates to WidgetInputHandlerManager that the compositor can handle the scroll but it cannot resolve the ScrollNode and requests that the WIHM provide the element_id of the scroller at the event's position. Conceptually, a scroll has started as far as IHP is concerned; however, while we're waiting on the WIHM to provide an element_id, the compositor thread event queue is blocked. This ensures any incoming scrolls are queued and coalesced until the scrolling can truly begin. Note: Only gestures like Scroll and Pinch are processed in the queue; other events will be dispatched directly to the compositor as usual. When WIHM receives a REQUIRES_MAIN_THREAD_HIT_TEST disposition, it will post a task to Blink. However, unlike DID_NOT_HANDLE, the event isn't passed to Blink, WIHM will keep it and redispatch it to IHP when Blink replies. When Blink responds, WIHM passes the original event, as well as the Blink-provided element_id back to IHP. This once again calls LTHI::ScrollBegin, this time providing a ScrollNode element id so that hit testing isn't required. The queue is now unblocked and flushed. Subsequent scroll update events will be routed to the LTHI as if we are in a traditional compositor scroll: REQUEST_MAIN_THREAD_HIT_TEST v---------<---------+ | | GSB +-------------------v------+ + --->+ WidgetInputHandlerManager+-->InputHandlerProxy<->LayerTreeHostImpl +----+---+-----------------+ ^ | ^ | HitTest | +---------------------->InputHandlerProxy:: | | | ContinueScrollBegin+-----+ | | element_id +-----v---+-------+ | BLINK | +-----------------+ This CL doesn't yet implement the logic in LayerTreeHostImpl to return a REQUEST_MAIN_THREAD_HIT_TEST, hence this path isn't yet "live". Instead we leave some TODOs for a follow up CL. Bug: 1047182 Change-Id: I68a0ec3dddc23c7344ddbfc334f1e25618e43404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199610 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771249}
-
Khushal Sagar authored
Images that need to support scanout on Android require explicit fence synchronization which is not support by the GL backing. Ideally it shouldn't have to be because scanout should use the AHB backing which already has support for this. R=penghuang@chromium.org Bug: 1085485,1082519 Change-Id: Ib6bdd9f46ca31a81e764c9bd46693a6b5e302f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212811 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
-
