- 20 Jul, 2020 40 commits
-
-
Kyle Horimoto authored
A recent refactor [1] allowed KerberosCredentialsManager to be null for secondary users. This CL adds a missing null check which fixes a crash for multi-profile users. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2291317 Fixed: 1106721 Change-Id: Ib66eab34c84a6b0b6cce63b4d610af346dbfad77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306821 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#789984}
-
Sophie Chang authored
Bug: 1099371 Change-Id: If25b554b8316f64078325e1411872c33f7c2f5e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303861Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789983}
-
Omid Tourzan authored
There are 2 messages for time display as it may show time in 2 parts like '1 hour 2 min' or 1 part like '2 hours' or '3 min'. We already have Dismiss label but its ID and usage is for drive banner. Added this new one as a general one to prevent confusion when referencing in the code or changing the other one. Bug: 953308 Change-Id: I7b7a2603e81ab8aea36a518d334546e1c4b8c905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306112Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Omid Tourzan <oto@chromium.org> Cr-Commit-Position: refs/heads/master@{#789982}
-
Mugdha Lakhani authored
Delete prerender browsertests that verify referrer policy and add equivalent tests to NoStatePrefetch. Please see this spreadsheet for details: https://docs.google.com/spreadsheets/d/1LFPB4UhPWQkBRz481lz49zmS25znhjSDUtagtTTSPQo/edit?usp=sharing Bug: 898955 Change-Id: I33e5fb9738abee2d5103c26d9ea0c345e0aa1213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299231 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#789981}
-
Javier Fernandez authored
We still lack the layout logic to support the 'last baseline' keyword value, defined in the CSS Box Alignment specification [1]. This keyword must be implemented by Flexbox and Grid, at least, before we can enable the parse again. [1] https://drafts.csswg.org/css-align/#valdef-justify-self-last-baseline Bug: 1102665, 886585, 885175 Change-Id: I06d43185086404fe471a033fc084c950ef115f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300086 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#789980}
-
Andrew Grieve authored
Suppression was recently removed, but it looks to still by needed for chromecast targets: https://ci.chromium.org/p/chromium/builders/try/cast_shell_android/592386 Bug: 1017190 Change-Id: I42db833add3ce07718e3f7d5ebfa66ff153ccc43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306581 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789979}
-
Tim Volodine authored
Failing on L/M Tablet bots. BUG=1107395 TBR=dtrainor@chromium.org Change-Id: Icfc80b3973bb70bdb5eaedf93e4a784584170208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307223Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#789978}
-
Sebastien Marchand authored
This will make it possible to do page discarding from other policies. Change-Id: I0ddc0d5a2e60a873d8c295b76c0b482427967b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303774Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#789977}
-
David Bienvenu authored
GetChromiumModelIdForProfile passes the result of GetBrowserModelId to BuildAppModelId, but GetBrowserModelId calls BuildAppModelId. Conceptually, it's cleaner if BuildAppModelId is always the last step in computing an app model id. To do this, we have to extract out a method to shorten an app model id component, so that GetBrowserModelId can use it, instead of using BuildAppModelId. Change-Id: I633c41b83bfc14c52bb4b5e364bce8dfc68cdde2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304162 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#789976}
-
Chris Sharp authored
Bug: 1018157 Change-Id: Iedb5ab2a582c4c66b4a5f7b89109581c73f12e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296060 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789975}
-
Lei Zhang authored
OutOfProcessInstance requires PPAPI dependencies. So split it away from the "internal" target, which is migrating away from PPAPI. Bug: 1103478 Change-Id: Id17208b497b4f2e45c015fc702b82d1c16282771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293326 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#789974}
-
Darwin Huang authored
|plain_text| was added in https://crrev.com/c/2243532/. It was used in earlier patchsets of the CL, but not by the time it was submitted. Change-Id: Ica681acb88455d9c29f8e0189dd8c4c88569e058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296480 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#789973}
-
Dave Tapuska authored
- Move cc::BrowserControlParams into CC - Move definition of VisualProperties into blink and use a typemap - Add typemapping for LocalSurfaceIdAllocation for blink too. - Add mojom_traits for ScreenInfo and VisualProperties. BUG=1097816 Change-Id: I8e0742d74438ef489020aecbb03cb6b5bbb55763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299525Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#789972}
-
Kramer Ge authored
gl_tests_passthrough are failing on Linux FYI Release (AMD R7 240) because both use_virtualized_gl_contexts and use_passthrough_cmd_decoder are true. Bug: 41017049 Change-Id: I03ac645a90db613adb53b254fdf7729bcdeac30d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307171Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#789971}
-
Majid Valipour authored
Currently the sms_service_unittests only exercises the verification backend which is not actually active by default since we are currently using User Consent backend. More than half the tests (10 out of 10) seems to apply to both backends. This patch refactors the logic so that the backend specific part of sms service are well encapsulated. It then updates the test so these common tests are exercised with both backends. Changes: - Introduce UserConsentHandler with two specific implementation 1. Noop: which does not show any UI to user and is used with user consent backend. 2. PromptBased: which prompts user to give consent and is used with verification backend. This encapsulates previous OpenInfoBar, OnCancel, OnConfirm methods from sms service. - The consent handler is created on construction of the service and is used for its lifetime. This makes it possible to easily inject mock consent handlers for testing. - Update mock Service to use a simple Noop consent handler for common tests which don't involve consent. - Introduce a more specialized ServiceWithPrompt that uses a prompt based consent handler for tests specific to prompt based logic. - Add unit tests for consent handlers. - Minor renaming, comments to clarify the code further. There is not expected to be any functional changes in this CL. Change-Id: I411bf9d12cb7a2051e545ce6dd8a50fe37204326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254447Reviewed-by:
Sam Goto <goto@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#789970}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0b12cba1. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Id42e40844442630aa6da2992273855da753cb83a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305920Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789969}
-
Carlos Caballero authored
This will allow us to make sure that the frame is current before showing any UI prompt to users. E.g. we do not what to show prompts for pages that are in the bfcache. The actual checks will be added in https://crrev.com/c/2307212 Change-Id: I0ba28d8ef089e3deec0e89cc2239ee8bd1890a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236437 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#789968}
-
Jun Mukai authored
This CL introduces specific views_delegate implementation and screen, a window tree host, and some aura clients to make the views_examples working with target_os="chromeos". Bug: 1106480 Test: manually checking views_examples Change-Id: I25a8fc26d35e91452bd1bcee98f4b3bcecbd5021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304098 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#789967}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3ba1777cebcd..16fbc2477205 2020-07-20 jlavrova@google.com Reland "ICU API: only in SkParagraph, simplified (relanding reverted)." 2020-07-20 adlai@google.com Remove more GrContext imports & usage 2020-07-20 brianosman@google.com SkVertices: Fix calculation of size needed for attr marker names 2020-07-20 kjlubick@google.com [canvaskit] Make effect deserialization on for everything but npm. 2020-07-20 kjlubick@google.com [canvaskit] Enable some options on npm build 2020-07-20 egdaniel@google.com Fix vulkan unmapping of buffers during release. 2020-07-20 kjlubick@google.com [pathkit] Publish 0.7.0 to npm 2020-07-20 kjlubick@google.com [canvaskit] Publish 0.17.0 to npm 2020-07-20 johnstiles@google.com Move test code out of header into CPP file. 2020-07-20 kjlubick@google.com Fix more swiftshader links 2020-07-20 michaelludwig@google.com Respect SK_FORCE_8_BYTE_ALIGNMENT in GrBlockAllocator 2020-07-20 robertphillips@google.com Clean up some GrContext in tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1106889,chromium:1107173 Tbr: robertphillips@google.com Change-Id: I4277e2203f85140166cd06bea19cb3614987f9fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307510Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789966}
-
Jarryd authored
Bug: 1089336 Change-Id: I46edfeea4c7774ed73b7e1c78a394d0e906e8848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281204 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#789965}
-
Mugdha Lakhani authored
PrerenderHttpAuthentication has been deleted from Prerender browsertests, and an equivalent test added to NoStatePrefetch tests. Please see this spreadsheet for details: https://docs.google.com/spreadsheets/d/1LFPB4UhPWQkBRz481lz49zmS25znhjSDUtagtTTSPQo/edit?usp=sharing Bug: 898955 Change-Id: I539097682d2b842519538cb417c2e31ca1613f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297563 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#789964}
-
Gang Wu authored
This is a reland of 5d52e576 Original change's description: > Reland "Reland "[Omnibox] Use ActivityState to check if we are in browser mode"" > > This is a reland of 5ae112d1 > > Original change's description: > > Reland "[Omnibox] Use ActivityState to check if we are in browser mode" > > > > This is a reland of be1e9636 > > > > Update the test to run on UI thread. > > > > Original change's description: > > > [Omnibox] Use ActivityState to check if we are in browser mode > > > > > > > > > In multi windows mode, check if we are in browser mode by WindowAndroid > > > is not working, should check ActivityState instead. > > > > > > Bug: 1102640 > > > Change-Id: I35a720a2aa6f337cc9f9ae43e39d83c9368fcb5a > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286478 > > > Commit-Queue: Gang Wu <gangwu@chromium.org> > > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#786636} > > > > Bug: 1102640 > > Change-Id: Iefba5a5d0c181535bd7fb86cf0e073be2ebdbcdb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293074 > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > Commit-Queue: Gang Wu <gangwu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#788816} > > Bug: 1102640 > Change-Id: I6da3c7ad8402cef83083a53f7ffc517f975720f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301285 > Commit-Queue: Gang Wu <gangwu@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789727} Bug: 1102640 Change-Id: Ib1a0f38d107df76dd0b6e7f3595c57f3fb066a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306823Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#789963}
-
Maksim Moskvitin authored
The test is constantly failing on linux-chromeos builders. TBR=emaxx@chromium.org,cylai@google.com Bug: 1107426 Change-Id: I2ec9626bb2076d9382d8186578628a621b127bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307334Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#789962}
-
Michael Spang authored
This is necessary to remove uses of the deprecated TaskEnvironment::DeprecatedGetMockClock function in tests. Change-Id: I56425b2bcc81b21d93c69c683b4134ee389704cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306374Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789961}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/13480cb0ab94..6af6e625573f 2020-07-20 bclayton@google.com Update license-checker.cfg with simplified rules (#1107) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: Ieb80823dfd03930eb879d200914a8fe6b1e4eab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307473Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789960}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fd5df6887258..fa504e744f9b 2020-07-20 dminor@webrtc.org Check that capture time is valid before adjusting it. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5cdb06394e116ab0e81f8b08bb6c177d13e94524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307479Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789959}
-
Boris Sazonov authored
Replaces ChromeSigninController usage in AndroidSyncSettings ctor with IdentityManager. Bug: 1093998 Change-Id: I56fc23be5f2849288d2aa425ccb90a7a5a385263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289972 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#789958}
-
Meera Srinivasan authored
Change-Id: Ifb0e6255745bf0e25919e53c5c463ad30de9a4bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304964 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#789957}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 86-4181.3-1594638142-benchmark-86.0.4204.0-r1 to 86-4181.3-1594638142-benchmark-86.0.4205.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I7488e9f082f4da2c707f809575440885fe8d2e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307478Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789956}
-
chrome://flagsTommy Steimel authored
Bug: 1107363 Change-Id: Ie97662d5f9a81ce10ffb568a9ed573a75282d4b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307471Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#789955}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=wjmaclean@chromium.org Change-Id: I53ed23666357b69f6f5b071ccafba3fd9f35e35a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298763 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#789954}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/343030c9..562c3f95 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I29816df57a3d78f1753e5ac182d5c2838510376d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306580Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789953}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I08c4cf62e138007e8946196eeadf1bcb00b74e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307629Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789952}
-
bttk authored
Documentation of RuntimeEnvironment#application says: Deprecated. Please migrate to androidx.test.core.app.ApplicationProvider#getApplicationContext Change-Id: I5f5b71e29edf99f4b6ee692247ea6910a0eb692c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305369Reviewed-by:
Gang Wu <gangwu@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#789951}
-
Michael Ludwig authored
Bug: 1097104 Bug: 1098743 Change-Id: I71af4756efb3d3f030e3e61913e71a0b1c4f6148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303670 Commit-Queue: Florin Malita <fmalita@chromium.org> Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#789950}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I44f63e4c8913862c70b9817dac349751ad53d8b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307368Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789949}
-
Peng Huang authored
There are many errors like: Validation Error: [ UNASSIGNED-GeneralParameterError-ExtensionNotEnabled ] Object 0: handle = 0x395107e6050, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0xe92b452d | vkQueuePresentKHR() called even though the VK_KHR_incremental_present extension was not enabled. Suppose vulkan should ignore unsupported or not enabled structures in structures chain, but vulkan validation reports it. It is annoying. So fix it by not passing unsupported VkPresentRegionsKHR in VkPresentInfoKHR. Bug: None Change-Id: I7cfff50ccc3f42a08a5b0ade481e297f129f6e94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305512 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789948}
-
Alexander Dunaev authored
A recent improvement of memory usage in ozone/x11 clipboard [1] introduced a regression: copying the text stopped working because the standard MIME type for the UTF-8 encoding was not inserted into the map. This CL fixes that. [1] https://crrev.com.com/c/2292396 Change-Id: I5cedb36253a4f2be392e937f62781417eead8ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306252 Auto-Submit: Alexander Dunaev <adunaev@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#789947}
-
Sebastien Marchand authored
This NetworkServiceClient owns a MemoryPressureListener and it's necessary to ensure that this listener gets destructed at shutdown to avoid UAFs in tests (see crbug.com/1081151). Bug: 1081151 Change-Id: Ia72a4fd35e17effe00f71018f032f2bd62118182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293162Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#789946}
-
Yann Dago authored
Bug: 1095206 Change-Id: I12d69fa120c1114700e947c4f56e39c0e39c13c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300401Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#789945}
-