- 30 Aug, 2019 40 commits
-
-
Gyuyoung Kim authored
This CL converts below 3 mojo files to the new Mojo types. - geolocation_service.mojom. - public_ip_address_geolocation_provider.mojom. - geolocation_context.mojom. Major changes are as below, - Replace mojo::Binding with mojo::Receiver. - Replace GeolocationRequest with mojo::PendingReceiver<Geolocation>. - Apply pending_receiver into the request arguments in .mojom files. - Replace StrongBindingSet with UniqueReceiverSet - Replace BindingSet with ReceiverSet Bug: 955171 Change-Id: Idee7dfc51dd80bb0d536713155fe7bfc8e4018ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774419 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#691930}
-
chrome://flags/#omnibox-zero-suggestions-on-ntpMoe Ahmadi authored
- The new flag allows force enabling the NTP realbox zero suggest. - Removes the existing and unused chrome:/#ntp-zero-suggest. - Removes IsNtpRealboxEnabled() since chrome://flags/#ntp-realbox can be separately enabled in testing as well as its corresponding feature set in the same study group along with OmniboxZeroSuggestionsOnNTP. Bug: 996516 Change-Id: Iae611216b53d553cf916a974adb54283712a683a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775202 Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#691929}
-
Kunihiko Sakamoto authored
TBR=horo@chromium.org,kinuko@chromium.org Bug: 999419 No-Try: true Change-Id: I6e297e706ccd6a27102d51d12f989fd682b52a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775657Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#691928}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Ibac8768f6b7d7e66bdbabc6fc4d0adeb313c515d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776641Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691927}
-
Yue Zhang authored
* Add more UMAs for tab grid dialog and drag-and-drop related actions. * Fix the problem that MobileTabSwitcher.GridTabSwitcher is not correctly logged. Bug: 996514, 996527, 996510, 996524 Change-Id: Ib54f558783ec7e8ef18dceef4f38000fb40fb26e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764934Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#691926}
-
kylechar authored
Finish removing an unused parameter and the function to check if the surface sync was enabled. Only cleanup in cc/* remains at this point. Bug: 985009 Change-Id: Iea8755eb15c1521d1e9fea282cc7718cab5ea325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776783 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#691925}
-
Ionel Popescu authored
This is a reland of 5cb1eeb5 Original change's description: > Updated the in-page UI for date related types. > > This CL contains the following changes: > - removed the clear button and spinner buttons from the in-page UI for > date, datetime-local, month, week and time types > - updated the calendar-picker-indicator to use a calendar icon for > date related types > > For time the calendar-picker-indicator will be updated when popup > support will be introduced for this type. > > Bug: 987050 > Change-Id: Ic7849a323ebb3723c5b6a467463a8604058f72ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716161 > Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681392} Bug: 987050 Change-Id: Id5fecab7bc93c7cc0e6518de439d5558294aea01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722970Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#691924}
-
Miyoung Shin authored
This CL converts SpeechRecognizerPtr in blink and SpeechRecognizerRequest in content to the new Mojo types. Bug: 955171, 978694 Change-Id: I651a16c2d5982eb5a9f4004fa5b09d8be829ddd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775683Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#691923}
-
Miyoung Shin authored
This CL converts UnhandledTapNotifier{Ptr, Request} in blink and chrome to the new Mojo types. Bug: 955171, 978694 Change-Id: Iaa143579ff70902998ee1586744f82dc893f8808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775943Reviewed-by:Nico Weber <thakis@chromium.org> Reviewed-by:
-
Alison Maher authored
This change adds logic for painting a readability backplate behind text in forced colors mode for LayoutNG. Backplates are split by paragraph, as defined by two consecutive line breaks. A backplate is not drawn if forced-color-adjust is none. Non-LayoutNG backplate logic will be implemented in a separate change. Bug: 970285 Change-Id: Ic74809e8b3e003e80f35f8e0c243ee0bd73f4a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749299 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#691921}
-
Xing Liu authored
Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1772045 Revert CL: https://chromium-review.googlesource.com/c/chromium/src/+/1776407 Revert reason, NotificationData::Button ctor didn't initialize type. The reland includes the fix for that. TBR=dtrainor@chromium.org,mpearson@chromium.org Bug: 963298 Change-Id: Iaf94cd933fdefe7486d2c0ef579f60711f3e9586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777088Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#691920}
-
Nicholas Verne authored
Bug: 988981 Change-Id: I8649038c3d77fad3e9daa2be5273dbf50bd6ee82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768612Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Auto-Submit: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#691919}
-
Andrew Grieve authored
Messed up the math between testing & code review tweaks. :/ Bug: 981974 Change-Id: Iad2151405c539b52d39ba3c5ba9f78ac149aec7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777090 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#691918}
-
Brandon Wylie authored
Bug: 986585 Change-Id: Iabfdebc44bcad6a7008627ed4dab043618aea31d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766354 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#691917}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome BUG=762641 TBR=sammiequon@google.com Change-Id: Ifaf69120474e087826f47f1acf7456a0e4b7c928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777091Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691916}
-
rbpotter authored
Add a test for destination store that loads all destinations and selects one. Bug: 998103 Change-Id: I4de8fe6f2d8ad1fc0878962fd17fb392e474996a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776780Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#691915}
-
Hiroshige Hayashizaki authored
We'll name worker/worklet-related things across the tests consistently, with worker/worklet prefixes. This CL renames source context names. Bug: 906850 Change-Id: I0f31cd65c43e4a0bbb51efd4ead141e84ac5b1e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777110Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#691914}
-
Bill Budge authored
- Changes return type of bytes() getter to base::span<const uint8_t>. This makes it possible to construct uninitialized inline BigBuffers, avoiding an unnecessary zeroing. Bug: chromium:992991 Change-Id: I9a8d345fd85a1f3195adabb81073d2b54139b302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775726 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
-
Brandon Wylie authored
Bug: 997343 Change-Id: I409ad9cac4adcea324c7625f8a1123fd9afaf686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772063Reviewed-by:
-
Xiaohan Wang authored
This is to prevent abnormal cases from happening. Bug: 999311 Test: Tested w/ shaka player demo and existing unit tests pass Change-Id: Icef06d979351f16386cf3cbb177971a57a1e264c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777139 Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#691911}
-
Matthew Denton authored
Converts all usages of bare new that: (1) construct base::RefCounted objects, (2) use public constructors, (3) are in an extensions directory, and (4) wouldn't cause changes in non-extensions directory to use base::MakeRefCounted instead. Bug: 919580 Change-Id: Ia6def2e499e5195640695b577004df2cd6d95300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772133 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#691910}
-
Chisoon Jeong authored
This change performs bitmapDraw() only if dithering is necessary to avoid bitmapDraw() call that causes less responsiveness on low performance ARM devices. Canvas' bitmapDraw() was performed on a webOS ARM device on decoding image for images that don't need dithering when converting its color type. For example converting color type between RGBA8888 and BGRA8888, which is related endian, dithering is not necessary. Therefor these cases can be processed by SkPixmap's readPixels() that is more efficient than Canvas' bitmapDraw() for responsiveness of webpage. Change-Id: Ib33c062519b16429a83445bafa376f2540030425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763523Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Brian Osman <brianosman@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#691909}
-
Jinsuk Kim authored
https://crrev.com/c/1743432 didn't take care of BottomSheet in dark mode properly. This CL sets the sheet background color right, and also handles the navigation sheet in dark mode (arrow bubble color). Bug: 993498, 985644 Change-Id: I584438e89e04f1727123dc116f7278ca89d7cadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772944Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#691908}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fc8238875e84..ab1d1a8d60dd git log fc8238875e84..ab1d1a8d60dd --date=short --no-merges --format='%ad %ae %s' 2019-08-29 chrome-bot@chromium.org Update config settings by config-updater. 2019-08-29 saklein@chromium.org GetChromeVersion: Add endpoint for the chrome version. Created with: gclient setdep -r src/third_party/chromite@ab1d1a8d60dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I87c40ae81f04993e5b87b558c822fc2b1d5b941e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776683Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691907}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/aae21ef6adf6..120b61d34ba8 git log aae21ef6adf6..120b61d34ba8 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 lujc@google.com Use ShaderProgramID in place of GLuint handles Created with: gclient setdep -r src/third_party/angle@120b61d34ba8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: None Change-Id: I5b513c9cf5e9523788102e4cb657463ab55b7c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777080Reviewed-by:
-
Mike Wasserman authored
The list of blocked paths may include nested entries. Apply the child-blocking setting of the narrowest ancestor path. Eg. If /foo blocks children, but /foo/bar doesn't, allow foo/bar/baz. Bug: 996230 Test: Chrome OS allows Native FS access to files in Downloads, etc. Change-Id: I4a0132f30c85328f543c6758aa76e1625dd21515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777102 Commit-Queue: Michael Wasserman <msw@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Michael Wasserman <msw@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#691905}
-
Kuo Jen Wei authored
Bug: None Test: By instrumented test code. Change-Id: I7af7ada02e2a2bf09a7f174af03dd8c29e46c85e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775686 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#691904}
-
Keishi Hattori authored
When CooperativeScheduling runs a nested loop, it should not run any tasks from the yielded EventLoop, as this will change the order of task execution. To stop all task queues belonging to a EventLoop, this CL registers the frame schedulers to the EventLoop. Documents with ContextDocument should not register their schedulers as they share the context document's scheduler, and would cause duplicated registration. Bug: 804661 Change-Id: Iec2d772090c39740337400d7ff547465aeb582c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743290 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#691903}
-
Lily Chen authored
Previously CookieInclusionStatus was just an enum with one value for inclusion and a number of other values for exclusion due to different reasons. This changes CookieInclusionStatus to hold multiple exclusion reasons, with inclusion represented as a lack of any exclusion reasons. This is implemented as a bit vector with each exclusion reason represented as a single bit. This also adds warnings to CookieInclusionStatus, which indicate when warnings should be emitted about a cookie (regardless of inclusion or exclusion). This removes the need for the previous hack which indicated warnings by making a duplicate of the cookie with a different CookieInclusionStatus. Bug: 993843 Change-Id: I8f4f76ea5c7225cd01342786b20f9e0b05f582c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756157 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#691902}
-
Andrew Grieve authored
Bug: 999007 Change-Id: Iaef942233a4c34cd6740b1362ab7b798cfa95860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777087 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Matt Reynolds authored
In macOS 10.15, Game Controller API added support for Xbox Wireless Controller and Dualshock 4. In Chrome, these devices are already supported through XboxDataFetcher and GamepadPlatformDataFetcherMac. When GameControllerDataFetcherMac also enumerates them, a duplicate gamepad is added to the gamepad list. To prevent this, GameControllerDataFetcherMac will skip these devices during enumeration. 10.15 added a new productCategory property to GCController which allows applications to detect these newly-supported devices. This CL uses productCategory when available, and compares the device's vendorName against known values when it is not. BUG=971801 Change-Id: Ie937f341d1f3c3c1c3a81d6717da2f15d6f6b993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773708Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#691900}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b7449a2b. With Chromium commits locally applied on WPT: 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." 2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest" 90789f54 "Implement fallback to element anchor" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: meade@chromium.org: external/wpt/web-animations NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ia1d33b9e6d8378ff74b927351f2ad7cf0a9a61e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772646Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691899}
-
Leszek Swirski authored
Bug: 865098 Bug: 945321 Change-Id: I557f5b6a2d2ed8f3d24add92830120a6b294878b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774456 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#691898}
-
Kai Ninomiya authored
Bug: 475095, 478572, 479260, 606096, 610951 Bug: 772651, 792210, 798117, 844311 Bug: 857644, 903903, 906742, 945903, 949249 Bug: 951628, 951771, 957644, 974347, 979444 Bug: 979641, 981579, 983142, 986808 Bug: angleproject:1007, angleproject:2708 Bug: angleproject:2722, angleproject:2909, angleproject:2910 Bug: angleproject:2911, angleproject:2912, angleproject:2913 Bug: angleproject:2918, angleproject:2919, angleproject:2920 Bug: angleproject:2922, angleproject:2929, angleproject:2931 Bug: angleproject:2987, angleproject:3343 Change-Id: I7007f383bf625b2d67081d3428958cd187649ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773437Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#691897}
-
rbpotter authored
Bug: 721073 Change-Id: Iaef46bc33ba84563942b68d44a8684d8571914b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762544 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Robert Sesek authored
Using global defines pollutes the build. The preferred method for feature defines are to use buildflags, which are scoped to the targets and files that require them. Change-Id: Ib583735e21f83b5a0084e52282bfba0f06a4ec71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775876Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#691895}
-
K Moon authored
Drops PDFiumPage constructor arguments that are mutable after construction. Long lists of constructor arguments are less clear than named calls, and callers can avoid setting arguments they don't care about. For example, the page rectangle can be initialized by a layout calculation, rather than at construction time. In the same spirit of removing undesirable degrees of freedom, the set_available(boolean) method has been replaced with a one-way MarkAvailable() method. (It doesn't make sense for an available page to become unavailable.) Bug: 885110 Change-Id: I98cf558320b4b752d7d7b8da2144d70a36b80a54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771042 Commit-Queue: K Moon <kmoon@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |LayoutText::SetTextWithOffset()| to reduce text shaping by reusing |ShapeResult| of before and after replaced range for improving performance, 10% to 15% faster but 3 times slower than legacy layout. (Profile data: http://bit.ly/33B9rfg) From this patch, |SetTextWithOffset()| does: 1. Get offset mapping to map DOM offsets to text content offsets for replaced range. 2. Collect inlines into |text_content| and |NGInlineItem| to get newly inserted text. 3. Copy before and after |ShapeResult| from current data to |NGInlineItem| list in step 2. 4. Call |NGInlineNode::ShapeText()| with |NGInlineItem| list to reuse |ShapeResult|. This patch gets rid of NGInlineNodeTest.InvalidateSetTextWithOffset because new test case replaces this test and this test call |SetTextWithOffset()| with wrong parameter. It shoulbe |SetTextWithOffset("baftere", 1, 4)| as result of |"before".replaceData(1, 4, "after")|. Note: This is reland of http://crrev.com/c/1729330 TBR=yosin@chromium.org Bug: 707656, 998507,998683, 999005 Change-Id: I016180de37b7afcb71998658ad66c001482029fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775647Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#691893}
-
Joel Hockey authored
Supports only CLIPBOARD selection and not PRIMARY (for now) since ozone only supports a single clipboard. Regisers to receive XFixesSetSelectionOwnerNotify events and prefetches and caches supported mime types whenever ownership changes. Also prefetches clipboard contents as 'text/plain' since that is the most likely type to be requested. If clients request a different type, it will be fetched at the time of requesting. Converts text/plain[;charset=utf-8] <=> [UTF8_]STRING to allow interoperability with other applications which do not use the same mime types as chrome. This code can be patched into linux-chromeos (chrome os running on a linux desktop) by modifying the build file: sed -i s/is_desktop_linux/is_linux/ ui/base/clipboard/BUILD.gn Bug: 985187 Change-Id: I4277f903ab8f11e0f5ad14d095eb099cf775f771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736619Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#691892}
-
Nandhini authored
Bug: 999272 Change-Id: If23c397fc23a657e09b2291ab9ea1c12b319ee35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776609 Commit-Queue: Nandhini Raman <nraman@google.com> Reviewed-by:
-
