- 01 Oct, 2019 40 commits
-
-
Sven Zheng authored
Reset the test account is a required step for e2e test. With this change, we can have at least 21 e2e tests passing. Other tests have failed because my account is blocked by server(429 too many requests). Next steps will be: 1 Resolve the server issue. 2 Add passing tests to CI. Bug: 992143 Change-Id: I848ded79bd6f722fda42ccbdda7ee5b12f7042be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829469 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#701683}
-
Vladimir Levin authored
This patch cleans up the imperative version of the API by removing the idl and all other associated functionality that is no longer accessible. R=chrishtr@chromium.org, rakina@chromium.org Bug: 882663 Change-Id: Ib355eb79b4c68d56425132570ec84bd93ec5bae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832281 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#701682}
-
Maksim Sisov authored
FlashFrame method is meant for flashing a native window to draw attention to it. However, not all the platforms support that. Thus, there is a default no-op impl of that method in the PlatformWindowBase. As I know, currently X11 and Windows backends support that. No functional changes are done in this patch. Just moving the code to the "right" place. Bug: 990756 Change-Id: Ib463ba75b0cdf5e49e705f0425241e242759adcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831897 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#701681}
-
Etienne Pierre-Doray authored
To investigate BLOCK_SHUTDOWN tasks posted after shutdown (see bug). Bug: 997754 Change-Id: Ie939ee242f56ab4ba25e6a67d640ad7873d3ad4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827938Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#701680}
-
Raymond Toy authored
Add time histogram to measure the length of the impulse response for a ConvolverNode. Bug: 998154 Change-Id: I8167cbfe51edea0e072ad571095c6f11d5b12526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773418 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#701679}
-
Wei Li authored
Survey's overflow style was changed from 'hidden' to 'scroll' recently(https://critique.corp.google.com/#review/270089435). That causes the scroll bars always show up which is undesirable for us. This CL overrides the overflow style to be 'auto' so that scroll bars only show up when needed. BUG=1009757 Change-Id: I0b9edd27984bcdba8f4c9f1e27f4e4c26650ab57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832633 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#701678}
-
Mohamed Heikal authored
This adds some information about the currently in the works gerrit binary size plugin to the binary size README.md page. Bug: 921090 Change-Id: I6b700002260a1d0fa1c6545b80306540a3f6b04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829745 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#701677}
-
Vadym Doroshenko authored
The main motivation of introducing driver id is that driver is one-to-one to frames. And input element renederer ids are unique inside one frame. So a pair (driver_id, input_id) is uniquely identifies input element. Bug: 959776 Change-Id: Ic01b16f59f862fb215d8a68bec9b73ccd48a7191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833612Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#701676}
-
Rafał Godlewski authored
Adds method to PasswordStore which removes all credentials stored in the leak table that were created in the given time period. It will be used for removing stored leaked credentials along with the browsing data, but it is not wired there yet. Bug: 1005746 Change-Id: Ib91968460506320271110aebf155778c8486684d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833469 Commit-Queue: Rafał Godlewski <rgod@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#701675}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/65235d3ae771..64672dce4174 git log 65235d3ae771..64672dce4174 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 srte@webrtc.org Adds log output to peer connection level scenario framework. Created with: gclient setdep -r src/third_party/webrtc@64672dce4174 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I3fa18355dda9f9aaab008de1e57403f6d0418666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832994Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701674}
-
Ella Ge authored
This CL makes a GetPredictor helper function to avoid using map.find everywhere to find the predictor class. Also clean up some naming and comments around ApplyResampling(). Change-Id: I1cc5d3d2a469b1f9e93c2e655499b4312132e7d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826992Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#701673}
-
Xiaohui Chen authored
It's been default equivalent to |is_chromeos| for a few milestones already. And there is no plan to split it out from ChromeOS. Remove the flag to clean things up. Bug: b/136564463 Test: locally build and run Change-Id: I57b20ae88b47e062dc457c0f857452d4e04bfd59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829750Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#701672}
-
Xida Chen authored
TBR=jyasskin@chromium.org NOTRY=true Bug: 1010170 Change-Id: Ic3154468b30dab693e469e0c4ae866484d8c85f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834075Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701671}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2a412ea20590..8edf82c75009 git log 2a412ea20590..8edf82c75009 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 swiftshader.regress@gmail.com Regres: Update test lists @ 3044c241 Created with: gclient setdep -r src/third_party/swiftshader@8edf82c75009 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: Ia268aeea2d48abfea4e51be6a181711031aaaf18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832992Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701670}
-
Sergey Ulanov authored
Now ClientNativePixmapDmaBuf and ScenicClientNativePixmapFactory validate layout of the NativePixmapHandle to ensure that the buffer fits the image. Bug: 957314, 974375 Change-Id: I3a3a0c9a59ca2fd3658baed3d86c93a82c6bb54d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831085Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#701669}
-
liberato@chromium.org authored
Test is flaky. Bug: 1009587 Change-Id: Ic4c04980273e48b3802259d599407e46a1bda8e2 TBR: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832249Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#701668}
-
Zentaro Kavanagh authored
- Add final strings for mouse and touchpad acceleration BUG=chromium:589190 TEST=visual confirmation Change-Id: I009ad45a802e3717a0cf4c6ddc151b4191732f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831452Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#701667}
-
Abhijeet Kandalkar authored
This CL converts usage of 1. |ProducerHostRequest| to |mojo::PendingReceiver<mojom::ProducerHost>| 2. |StrongBindingSet| to |UniqueReceiverSet| Bug: 955171, 978694 Change-Id: I06953f0494b3504901faa5e6cc65c8b59fd30298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831921 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#701666}
-
Caleb Raitto authored
Change-Id: I2df10d1aefd0be2c9a740838426bf01c03f85f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829358Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#701665}
-
Michael Liao authored
Changes: - Placeholder view automatically gains focus - Each suggestion (Open File, Run Command, Drop in a folder...) is now functional and keyboard accessible Reasoning: When initially opening the "Quick Source" tool from the top right menu > More tools > Quick Source, the focus is set to the widget's contentElement. https://imgur.com/JUDmjDR This is mainly an issue when the placeholder view is up since the focus seemingly disappears and the user is required to click tab again to find their focus. This CL fixes this issue shifting focus into the suggestion elements themselves, and allows keyboard users to quickly access the suggested actions via Space/Enter. Change-Id: Ie937ebd79a00be5ef993de09a772e8b275ccc042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756851 Commit-Queue: Michael Liao <michael.liao@microsoft.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#701664}
-
Andrew Xu authored
The CL was reverted by an unrelated crash. Now reland it. The link to the original CL: crrev.com/c/1815723 Original description: Now scrollable shelf ensures that when two arrow buttons show, the right gradient zone always cuts the half of the rightmost icon. To implement this feature, some available space is wasted. As a result, there may be no sufficient space for scrollable shelf on small-screen devices. In this CL, the width of the gradient zone becomes a constant. Bug: 1005989 Change-Id: I29fcb766562860d9d4ca5d21a497b193300ddd47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832914Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#701663}
-
Mikhail Khokhlov authored
So far TBMv2 metrics have been computed on the Telemetry side and passed to Results Processor as a special artifact. This CL implements metric computation in RP. Metrics will be computed if this artifact is absent. Bug: 981349 Change-Id: I46803784bd75269e578e951f5dd2e5bfaa5cae68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821527 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#701662}
-
Daniel Nicoara authored
Responses need to be matched to their request. So add a unique identifier to ensure the client can match the response to the appropriate request. Bug: b/132811925 Test: Compiled Change-Id: I8358e5baed4922de2960a8eebd712443473bebdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833483Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#701661}
-
Michael Liao (WPT) authored
Problem: - NVDA does not currently support reading <optgroup> elements in Chromium - Optgroup labels are inaccessible in Network throttling select element in Network Conditions tab Changes: - Select options are given a new accessible name that prefaces the option title with the optgroup title. Bug: 963183 Change-Id: Id9a71997c96d3646c7cf35de94213bccf5e68912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730863Reviewed-by:
John Emau <johnemau@microsoft.com> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Michael Liao <michael.liao@microsoft.com> Cr-Commit-Position: refs/heads/master@{#701660}
-
Yasmin authored
Bug: 1005813 Change-Id: I4661aefa91ecc2d19a8057d1e0233fcebee2bc73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833824Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#701659}
-
David Tseng authored
Summary ChromeVox (Spoken Feedback) receives key events earlier than any other event handler or rewriter in Chrome today. This was done partly because ChromeVox requires the ability to override all system shortcuts including Search+l (lock), Search+f1-f12 (various functions), and many other combinations. However, as noted in the below bugs, users want the ability to remap some modifiers (e.g. Control as Search). This change: - does some light refactoring so all EventRewriter instances live within EventRewriterControllerImpl. - makes clear the ordering in which keys flow. - makes SpokenFeedbackEventRewriter hold a weak pointer to EventRewriterChromeOS in order to be able to rewrite modifiers and build key events. This is necessary because EventRewriterChromeOS::RewriteModifierKeys calls through and has hard dependencies on |dleegate_| an instance member. Bug: 821657, 822493 Test: manually with ChromeVox. Change-Id: I2d808e1ac640528fba2063afdb99fac0325c8106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822982Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#701658}
-
Daniel Rubery authored
This option is very confusing, compared to the "DoNotScan" option, and was added just to support a planned feature (scanning for Advanced Protection users). When scanning for Advanced Protection users actually launches, we can add a new policy to handle it. Bug: 980777 Change-Id: I9e2cdc08ee70eaf9c37bfa2eb59304d1eff0d8f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827465Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#701657}
-
Andrew Xu authored
Re-enable those tests which were disabled due to crbug.com/1008744. Bug: 1008744 Change-Id: Id67c436f50777631b855eb5c4405473dcadf14d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832708 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#701656}
-
Lindsay Pasricha authored
Bug: 137010 Change-Id: I3f8c1674e1ccfaa5edfd924c7044154d603738c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827952Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Cr-Commit-Position: refs/heads/master@{#701655}
-
Xida Chen authored
TBR=jyasskin@chromium.org NOTRY=true Bug: 1010145 Change-Id: Iadfef1df01f3b5d1c926aededd05cfb3cf8358b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833785Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701654}
-
Fredrik Söderquist authored
Notify once at the end up said functions - after all the conditions have been processed. Renames AddInstanceTime() to AddInstanceTimeAndUpdate(), and then splits out a new AddInstanceTime() which just adds the instance time to the selected instance list. Bug: 998526 Change-Id: I4d350c7752e95eb87923eab79ec1ad87b1d7f27e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831816 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#701653}
-
Robbie McElrath authored
This CL almost makes gn check happy for all webview build targets. I still need to move AwFeatureList to a common location since it's used from multiple places. Test: gn check out/aw '//android_webview/*' Bug: 934152 Change-Id: I3635f36db8015db342350b0a50f0787d8c936bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828346Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#701652}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. The member was already there. This CL simply exposes it and starts using it, rather than calling RenderWidget::compositor_deps(), since |render_widget_| may be nullptr in the future. Bug: 912193 Change-Id: Ib36ee51473100f2cee8fc685f6817647a1c6fc08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829675 Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701651}
-
Daniel Nicoara authored
Webview clients want to know the URL for the page event. Include it for convenience to reduce the number of IPCs. Bug: b/132811925 Test: Compiled Change-Id: I4d2b4fd7ead9002270f5008cb4bbfb5be57b3904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833117Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#701650}
-
Lucas Furukawa Gadani authored
Bug: 984550 Change-Id: Ic3c8f365886d98d8007a4eeb06c42522d00ce109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832441Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#701649}
-
Fabian Henneke authored
Since the U2F Zero authenticator cannot deal with check-only sign requests, exclude lists are probed with UP-requiring sign requests instead. Since these requests are indinstinguishable from actual sign requests, they are problematic for authenticators that want to show the request type to the user (e.g. soft tokens and authenticators with a display). This change aims to make these workaround sign requests stand out while preserving compatibility with authenticators behaving like the U2F Zero. This is achieved by setting the challenge of the sign requests sent while probing an exclude list to the same fixed bogus challenge used to collect a touch on certain errors. R=agl@chromium.org Bug: 1000641 Change-Id: I7ae43a0ecc2380714ce4752a84c7b6cd4572cdb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831857 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#701648}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 214 histograms that show frequent access in the past 90 days. These are the 80% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-03-29. Change-Id: I9d6a210147e8729a474786f021f153667f5749f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829679 Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#701647}
-
Morten Stenshorne authored
LayoutInline::ChildBecameNonInline() is called when a child of an inline becomes in-flow block-level (e.g. when its position changes from absolute to static) and we need to set up a continuation chain because of this. Part of this operation is to wrap the in-flow block-level child inside a new anonymous containing block. AddChildIgnoringContinuation(), which is what we call when inserting new children, did a few nice things to such anonymous containing blocks, which ChildBecameNonInline() didn't do, most crucially, setting the position of the anonymous containing block to relative if the inline is relatively positioned (to contain absolutely positioned descendants). So if the continuation was set up as a reaction to something becoming block-level, rather than being set up as part of inserting new children, the anonymous containing block of block-level children of the inline didn't get position:relative, which made any absolutely positioned children escape its relatively positioned inline parent, and find a containing block further up (the viewport, in the included testcase). To fix this, break out the code that sets up such an anonymous block into a separate method, and have ChildBecameNonInline() call it. Bug: 732397 Change-Id: I06b120c3173403ba6db3b93019e95a66575ba0e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833581Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#701646}
-
Geoff Lang authored
The the passthrough command decoder did deferred image bindings, it didn't ensure that the correct GL texture was bound first. This caused canvas -> WebGL copies to fail when they are using IOSurface backed canvases. BUG=990368 TBR=true Change-Id: I5d555c7a715d0f47382053840c3db78576dc4e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819520 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#701645}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/a7d9ac2af4684747c4524cbeba9737b04dce3e3e..bd522862a0b4c84a0ed8e37096d1c361dc6beaa9 Bug: none Change-Id: I38612b6cfdc378bbca6163f725445dae3d42eec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829582 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#701644}
-