GitLab

Bug: 646113
Change-Id: I4a6d0990d365e9b9279d5348154abb44e1f23a96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737438Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684383}

The finch release process says that the feature should be enabled in
Chrome ToT at the same time as it is launched so that a max_version can
be set.

BUG=882580

Change-Id: I4b3e3eb70236dab1f4269ef9f38073c89a93d8b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736798Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684382}

This change separates updating tree structure in AXTree::Unserialize
and AXTree::UpdateNode from notifying that the tree structure will
change or has changed.

---

Problem :
  AXTree notifies AXTreeObservers of node and subtree changes in the middle
  of a tree update, which means observers may be seeing a tree state that's
  incomplete. This can lead to subtle bugs when observers access nodes in the
  AXTree other than the node being updated.
  e.g. |GetUnignoredParent| may be invalid during a notification, but
  correct afterwards.

Proposed solution :
  Separate notifications from updates in AXTree::Unserialize.

  This requires the following steps :
    1. Record all operations that would be performed on the tree.
    2. Fire all on destroy and OnNodeDataWillChange callbacks.
    3. Apply all update operations.
    4. Fire all created and node data changed callbacks.


  For additional context, see these comments by Nektarios and Dominic :
  https://chromium-review.googlesource.com/c/chromium/src/+/1650222/20#message-ffe9bf96b616a915bebf2e69d7803bcae6a18b24
  https://chromium-review.googlesource.com/c/chromium/src/+/1535171/69#message-7b62970b193439a1878d7339cdc94d2556d0a416

  I  plan to submit approximately 3 CLs to resolve this :
    1. Handle Pre/Post Tree changes (create node / destroy subtree)
    2. Handle Pre/Post Node data changes (attributes will / have changes)
    3. Add DCHECKs to AXNode::*Unignored* accessors, along with any remaining
       work required to do so, to help harden these paths.

Bug: 974444
Change-Id: I6f9c20389da444d81a33b5c27774faf81a2f066c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703466
Commit-Queue: Adam Ettenberger <adettenb@microsoft.com>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#684381}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827
       to make thread affinity a build-time requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",                            "PostTask"],
         ["PostDelayedTaskWithTraits",                     "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",                    "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",                    "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",           "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",        "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",              "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=rayankans@chromium.org

Bug: 968047
Change-Id: Iac4a5f35210b2baf7280bc0d9be89b68183c2ba9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729257
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684380}

Adding:
 - NavigationControllerBrowserTest.HistoryBackTwiceFromRendererWithUserGesture
 - NavigationControllerBrowserTest.UtilizationOfSpareRenderProcessHost
 - WebContentsImplBrowserTest.SetPageFrozen

Bug: 990354, 991194
Change-Id: Ia3814961b4a33d871556a49da2b7b7caac38aebd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738452
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684379}

This feature was enabled by default in crrev.com/c/1736868.

Bug: 954442
Change-Id: I60b3c34aa1427a4e91230074d326d3ba5fa08d0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739528
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684378}

https://screenshot.googleplex.com/R2K3Ps4khBi.png

Bug: 990952
Change-Id: I1a5277a73a5a4e7c710529f66f1260dc900fae61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737162
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684377}

Bug: 646113
Change-Id: I3c6c52586080a053e390ca27b08d53fb777cd69f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737428
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684376}

... and remove it out of the Blink exposed API.

This change is a follow up of [1], where AecDumpAgentImpl::Delegate
was factored out into AecDumpAgentImplDelegate, and made temporarily
public.

[1] https://crrev.com/c/1710237

BUG=704136,919392
R=guidou@chromium.org

Change-Id: I130a45549b5866fd9235099ef4e1a4963f9eedf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739289
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684375}

Bug: 953822
Change-Id: Iee2efb5cad4fc37d11c97d56ec03eeb286969b20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737349
Auto-Submit: Kristi Park <kristipark@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684374}

Bug: 977430, 991220
Change-Id: Ic29ba69d4f896b99afd9ad174ea5187cb56cf892
TBR: sky@chromium.org
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739489Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684373}

This CL renamed GridTabSwitcher to TabSwitcher to generalize it
for creating carousel TabSwitcher.

It also renamed GridTabSwitcherCoordinator, GridTabSwitcherMediator
and TabGridContainerViewBinder accordingly.

Note that this CL didn't intend to rename all the files thoroughly at once.

We do not expect any functional changes in this CL.

Bug: 982018
Change-Id: I4595a0140cd27035f7b1dad30acdde91654fb86f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736178
Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
Reviewed-by: Pavel Shmakov <pshmakov@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Auto-Submit: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684372}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/af9ce667581c..77c12644ba94


Created with:
  gclient setdep -r src-internal@77c12644ba94

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I4b9adbae9e6e70f44113f9d554d70a5901fedd21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738328Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#684371}

This CL updates the Revamped context menu to use a video camera icon
in the place of a video thumbnail since we can't display the real video
thumbnail, yet.

Bug: 990035
Change-Id: Ib035329ed8fb3d12a98b50176b32fc214a11c005
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735518Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/heads/master@{#684370}

Bug: 990767
Change-Id: I7040082705506dda5acc5c27e80d8a25822b3e2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738548Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684369}

This change adds UMA tracking for SMSReceiver API to give us data on
the how long an SMS takes to be delievered and how long a developer expects
the sms to be delievered. Specifically it will track the following:

1. Duration from when the API is called to when an SMS is
   successfully received.

2. Timeout value specified when the API is called.

Bug: 976332
Change-Id: I05fea36e67c1b256bcb60dc0d0edca4207fd0149
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717429Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Jun Cai <juncai@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684368}

Bug: 990685
Change-Id: Ie639f3910a56cc6ec92551881312e5423586d0e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737429
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684367}

Removes DEV_SUFFIX from MULTI_PROCESS_QUERY in
SupportLibWebViewChromiumFactory.

Bug: 991148
Change-Id: Ieb910d8198cda014cdffde0b3bca89c4aaec9e13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738371Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Laís Minchillo <laisminchillo@chromium.org>
Auto-Submit: Laís Minchillo <laisminchillo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684366}

https://chromium.googlesource.com/angle/angle.git/+log/74ec0afe01ec..99f494e42246

git log 74ec0afe01ec..99f494e42246 --date=short --no-merges --format='%ad %ae %s'
2019-08-06 ianelliott@google.com Vulkan: Enable GL_NV_pixel_buffer_object extension

Created with:
  gclient setdep -r src/third_party/angle@99f494e42246

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Bug: None
Change-Id: Ie15f8733178cefbfae8bf507785fffe30e78dd8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739446Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#684365}

Updates the expires_after attribute for 250 histograms that show
frequent access in the past 90 days.  These are the 40% most
frequently used histograms over that time that do not already have a date later
than or within 60 days of 2020-02-02.

Change-Id: Ib261ee110b3c7b55b3cf2669e30d5bb0a976767d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738711Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684364}

Set the |from_dynamic_change_form| and |has_non_focusable_field| in SaveCreditCardOptions when Chrome shows local save prompt to user from a dynamic/accordion form so that sub-histogram can be logged correctly.

We add tests to ensure these two fields are correctly populated in SaveCreditCardOptions when a user was prompted local-save/upload from a dynamic/accordion form. The tests for the local save sub-histogram were already introduced in save_card_bubble_controller_impl_unittest.cc

Bug: 989771
Change-Id: I286416e2d8a4f90f2e5740658cf414531ba0a574
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730853
Commit-Queue: Sujie Zhu <sujiezhu@google.com>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#684363}

Bug: 934009
Change-Id: Ia6035a0bdcc0c9702d5758715ee27aec7ec7ce3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737671
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684362}

FragmentData::UniqueId is not intended to be relied upon as an
indicator. Instead, any call to the method should only happen if you
know there should be a UniqueId, and failures should be handled by
figuring out when a UniqueId should have been created (by paint
properties or otherwise). This CL adds a DCHECK to enforce this, and
fixes up two locations that were trying to rely on
FragmentData::UniqueId to check state.

Bug: None
Change-Id: I168ad2e91a3418e98d351df8fa3ad879ab2e3427
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730859Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684361}

Change-Id: I61cab72b4c197af008012fc73eedaae4cffaaf11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733579
Auto-Submit: Sam Maier <smaier@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684360}

Without a specific frame, we were using the local root of caller's
widget, which was showing wrong activation state in certain cases.

Bug: 981597
Change-Id: I45a5dd88ea4c487ff4bf3a722e72bb6923fb8319
TBR: dcheng@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721186
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684359}

These methods turned out to be unnecessary, as the autofill agent
communicates directly with the WebAXObject.

Bug: 865101
Change-Id: Id16a03b808f76b0f2fd5030f5ba9f7ffdd119565
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731290Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684358}

FloatingObjects has a method LowestFloatLogicalBottom(), which
calculates and caches the lowest FloatingObject if this information
isn't already calculated and cached.

Then there's the method LowestFloatingObject(), which would return that
FloatingObject, if it was cached, and nullptr otherwise.

So: One method that calculates it if needed, and one that relies on the
cache and otherwise returns something bogus.

The layout code is quite well peppered with calls to
LowestFloatLogicalBottom(), so it requires significant amounts of bad
luck to trigger a cache miss, and then another heap of bad luck to
actually cause a crash from that.

But it was NOT impossible.

The fix is to rebuild the cache if needed in LowestFloatingObject().
Letting it return nullptr if the cache was invalid caused us to fail to
propagate an overhanging float upon relayout, breaking some sort of link
to subsequent blocks, so that when the float later on was removed, we'd
fail to remove it from all the block flows that referred to it.

The test included in this CL is as minimal as I could get it, but still
not super-simple. Here's what went wrong:

There is a float somewhat nested inside a container. This container has
some siblings, one being an infinitely tall beast with a large negative
(also infinite) block-start margin. Another sibling is empty, so that we
can collapse through it. Then there's a last, pretty decent, sibling
container, except that it contains another float. Because we're dealing
with infinite LayoutUnit values, the engine cannot quite agree with
itself whether the first float intrudes into the last sibling or not,
and this is important when it comes to determining whether the float
intrudes into the last container or not. When we lay out initially, we
find it to intrude, and add it to the list.

We then change the first float ever so slightly, to trigger relayout.
This will break the magical chain of FloatingObject references to the
first float (because the cache was invalid, and therefore incorrectly
report that there's no float there). The last container (the one
previously referred to as "decent") has a reference to the float that
just got relaid out, because at some point it was thought to intrude. If
we had laid out this container again now, we'd clear the FloatingObject
list and the float would be gone from the list. But we don't lay it out
again, because the relevant part of the engine decides that the float
doesn't intrude, contrary to what the part of the engine that caused it
to be added in the first place concluded.

Then, we'll remove the float (display:none), and we'll fail to remove it
from all block flows that referenced it. The last container still has a
reference to the hungover (or actually now dead) float.

Bug: 989305
Change-Id: I498344fc5b6426cf8225441d2dab195659e31112
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738556
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684357}

This is a reland of cca6943d

The CL includes an additional update to MSANExpectations to account for
expected interfaces-sw.https.html timeouts in the virtual test suite.
These timeouts are expected as described in bug 856601.

Original change's description:
> CacheStorage: Allow reads to be executed in parallel.
>
> This CL adds the CacheStorageParallelOps feature with the associated
> "max_shared_ops" parameter.  Enabling the feature and setting the
> parameter to greater than one will allow read-only cache_storage
> operations to run in parallel.  By default parallel operation is
> disabled.
>
> The overall design is to treat each CacheStorageScheduler as if it
> has its own read-write-lock.  When an operation is scheduled it must
> be flagged as either "shared" or "exclusive".  Some number of shared
> operations (determined by the feature param) may run in parallel.
> Exclusive operations always run by themselves without parallelism.
>
> This CL also includes the ServiceWorkerCache.PeakParallelSharedOps
> histogram which will measure how much parallelism we actually see in
> practice.  The peak is measured across a small time period defined by
> when an idle scheduler begins running its first shared op to until it
> stops running all shared ops.
>
> Bug: 985379
> Change-Id: I4e318b719b51da079ff584acd1fb398d898660d7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709008
> Reviewed-by: Jesse Doherty <jwd@chromium.org>
> Reviewed-by: Daniel Murphy <dmurph@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Rayan Kanso <rayankans@chromium.org>
> Commit-Queue: Ben Kelly <wanderview@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#680986}

TBR=jwd@chromium.org,dmurph@chromium.org,jam@chromium.org,rayankans@chromium.org

Bug: 985379,856601
Change-Id: Ia0480844c141f5646edaea04a33557b4ecad2182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739310
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684356}

This CL has two goals,
1. Use To<HTMLDetailsElement> and DynamicTo<HTMLDetailsElement> as new
   downcast helper.
2. Use IsA<HTMLDetailsElement>(element) in place of
   IsHTMLDetailsElement(element)

Bug: 891908
Change-Id: Ib7d9bc62aced8df6158c3e04610e006996e9b28a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738456Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#684355}

BUG=None
TEST=Compile.

Change-Id: I35b315c6a72f4b3d2d8d6f23547e138d0c2abb20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738144
Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684354}

The test only checks the sensor pointer with EXPECT_TRUE() and then
dereferences the pointer. On failure, this will blow through the
EXPECT_TRUE() and crash the test program. Switch to ASSERT_TRUE() to
fail without crashing.

Change-Id: I18a8b9c2ea7e300b93a11cc6108f195a895bec04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733039Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684353}

memfd_create() avoids having to write relocations to disk. It is available on
recent-ish Android kernels (>= 3.17). Use it where possible in ModernLinker.

Bug: 979638
Change-Id: I6b52373490bec0c29b9028558d3926fff75d7a4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730893Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684352}

Bug: 990073, 989734
Change-Id: I35fd81bd4ed1426a0865a2820c818944c263de04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731755
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684351}

This CL adds TODO and replaces EARL_GREY_TEST_SKIPPED with
EARL_GREY_TEST_DISABLED.

Bug: 990947
Change-Id: Idfd04f691d2bff9a38f6332d9e18d25c9a765975
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736931
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684350}

Bug: 990550
Change-Id: I3224540c71a70ed175308b14927978b88b794a48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735048Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684349}

... down to renderer/platform/mediastream.

The .cc and test_.cc respective files also got moved from
renderer/platform/export/mediastream to renderer/platform/mediastrea/.

BUG=704136,919392
R=guidou@chromium.org

Change-Id: Ia981d447b28e2b7ad5bcadba3abb13ebc4111f2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739388
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#684348}

If the passthrough command decoder is default, it may get used when it is not
supported in compositor_unittests  and cc_unittests.

BUG=882580

Change-Id: I890315332e07bb61328fc9cb063f4abbdafa0194
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739308Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684347}

Added chrome_all_tast_tests, cros_browser_sanity_test and base_unittests
to chromeos-kevin-google-rel

R=bpastene@chromium.org

Bug: 988587
Change-Id: I2117296c33c99f72063d6ffac71e007b4c481710
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737100Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Anushruth  <anushruth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684346}

When VoiceOver uses an action to press a checkbox, it requests and
reports the new checked state immediately. However, because of Chrome's
cross process model, the checkbox/radio/switch checked state is still
the previous state, as the round trip has not yet updated the object.
This uses a hack to temporarily override these objects with what
the state is expected to become. Once the system catches up with itself,
it will update the object with the true checked state, which should be
the same.

Bug: 971429
Change-Id: Ifcc15b281413f02cecf951ac6e4e31890d4c05c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727210
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684345}

Show the cursor highlight accessibility feature only if one of the following conditions have meet :
-Its not being controlled by any policy
-Its being controlled by a policy and the value of the policy is force on

Bug: 552439
Change-Id: I48823a53cb0ebbaf2edc732de56452871ee08eba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725915
Commit-Queue: Amr Aboelkher <amraboelkher@google.com>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684344}