GitLab

This patch changes |StartOfSentence()| to utilize |TextSegments|
class to make it work with LayoutNG.

Bug: 778507
Change-Id: I462e99f3a3c5cf84dfeab67cc324d985478ed570
Reviewed-on: https://chromium-review.googlesource.com/c/1335959
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608422}

Bug: 902802
Change-Id: I4bdb916804f83f16eef10125d37c29fd1469566d
Reviewed-on: https://chromium-review.googlesource.com/c/1336552
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608421}

This makes blacklisting work even when the URL is well formed but not
canonical, for example if the trailing slash is missing.

Bug: 902626
Change-Id: Ibced76fd3ad19248d50fc088cc3e54f7ee5ef9af
Reviewed-on: https://chromium-review.googlesource.com/c/1336511Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608420}

This patch adds IsEmptyLineBox() function that returns
whethe the line box is "empty", or "certain zero-height
line box" as defined in CSS2[1] or not, and change where
we used to determine it by checking if the number of children
is 0.

[1] https://drafts.csswg.org/css2/visuren.html#phantom-line-box

Bug: 636993, 903578
Change-Id: I2b9961e1ecb743063238b39a3a5be53f15ffce8c
Reviewed-on: https://chromium-review.googlesource.com/c/1332972Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608419}

R=csharp@chromium.org

Bug: 830892
Change-Id: I13ef01f4194bc747b4c9ea28537a188aa9315c49
Reviewed-on: https://chromium-review.googlesource.com/c/1336067
Commit-Queue: Joe Mason <joenotcharles@google.com>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608418}

The transform-post-multiplication testis very sensitive to changes in 2D matrix interpolation. This patch addresses the following:

* Use a prefix that guarantees that matrix and pairwise interpolation product different transforms.
  Previously relying on subtle numerical precision discrepancies.
  With the new prefix, pairwise will scale and transform will rotate.
* Fix matrix comparison to consider the full floating point value and not just the mantissa.
  Previously small non-zero values would be perceived as a matrix mismatch.

Bug: 797472

Change-Id: I9120f2f92195cf2559ff2eb4294e1341195c277e
Reviewed-on: https://chromium-review.googlesource.com/c/1337639Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608417}

Flaky on linux bot

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29

TBR=sahel@chromium.org

Bug: 905694
Change-Id: I749d9795251c53c651b7000d0bedfa7d09d6e040
Reviewed-on: https://chromium-review.googlesource.com/c/1338164Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608416}

TBR=dtseng@chromium.org

Bug: 899777
Change-Id: Id56ad8bb68c95b4412fbc9ebacef7921216fe9ce
Reviewed-on: https://chromium-review.googlesource.com/c/1317924
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608415}

We cannot assume that when we push a line to the next fragmentainer
(because it doesn't fit in the current one), the line is going to fit
there. If the next fragmentainer has a float that nothing fits beside
and the float is too tall to fit the line below it, we need to jump to
yet another fragmentainer in order to find room for the line.

Bug: 902762
Change-Id: Ied14694ed1ad4fc25d28527edd1ca7389f00664c
Reviewed-on: https://chromium-review.googlesource.com/c/1335580
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608414}

LibFuzzer runtime on Windows was accidentally removed, add it back.

Bug: 905664,903078
Change-Id: Ie6343d02c6d13e18c71dee11b5219c0bb4e81dd0
Reviewed-on: https://chromium-review.googlesource.com/c/1337809
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608413}

On the current implementation, on a navigation error, the
error_retry_state_machine expect a second navigation after any error to
load the error page.
When displaying an offline page, this second navigation displayes a
native content and DidFinishNavigation is never called, so the
navigation is not cleaned.
On reload, this causes a DCHECK and a navigation failure.

This CL report a success on native navigation.

Note:
While this fix gives the expected result, there is still a bug in the
error_retry_state_maching as the state will be put in
kDisplayingWebErrorForFailedNavigation instead of success state.
Fixing this behavior is not in the scope of this CL and can be fixed in
the future by ErrorRetryStateMachine owners.

Bug: 904784
Change-Id: Ic4efe212f933e8631f1b97dbf1a5633dd8a8cc54
Reviewed-on: https://chromium-review.googlesource.com/c/1335932
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608412}

This re-adds the previously approved and committed browsertest, but this
time with a fix for the flakiness.

The body of the test remains the same, but with an extra call to:
PluginTestUtils::WaitForPlaceholderReady(GetActiveWebContents(),
                                         "pdf_embed");

There is also an update the command line flags and an extra include.

This is patch 3/3 for this objective.

Bug: 887752, 879149, 878871
Change-Id: Ie8c70d68fb3e3ebf9e70e5d9f2f1aa2f37b190f4
Reviewed-on: https://chromium-review.googlesource.com/c/1336086Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608411}

Bug: 807068
Change-Id: I00d910ee1fc84c08d1bbab4638d70dd2df7848e4
Reviewed-on: https://chromium-review.googlesource.com/c/1336131Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com>
Cr-Commit-Position: refs/heads/master@{#608410}

https://android.googlesource.com/platform/external/perfetto.git/+log/c17c1dc0e795..1ff7a8e7e55f


git log c17c1dc0e795..1ff7a8e7e55f --date=short --no-merges --format='%ad %ae %s'
2018-11-15 fmayer@google.com Merge "profiling: Do not install hook if Client init fails."


Created with:
  gclient setdep -r src/third_party/perfetto@1ff7a8e7e55f

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I6a28d820fa9bea095da70e4ad7c9e81e5db22373
Reviewed-on: https://chromium-review.googlesource.com/c/1337532Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608409}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/14d42672..144f1014

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: If404436bccc2f14ca6d015170f60342eff8d621e
Reviewed-on: https://chromium-review.googlesource.com/c/1337636Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608408}

The static method is only used in one special case for tests,
where it can be eliminated using a fake match instance.

Change-Id: Idb2d24ac0b457d7fcc13b519f78ed218bcd06d00
Reviewed-on: https://chromium-review.googlesource.com/c/1336849Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608407}

Bug: 902802
Change-Id: I6354768076f57e2c2678e3e051f8bb97c43b4b16
Reviewed-on: https://chromium-review.googlesource.com/c/1336441Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608406}

When the user has an actionable sync error, a button to resolve
the error is shown in the sync account control row on settings
pages.

Exception: The passphrase action button is not shown on the sync
page because this page has its customized passphrase UI.

Bug: 902949
Change-Id: I558a79be8cb75f2a9260bf8e3236e7ef956627db
Reviewed-on: https://chromium-review.googlesource.com/c/1333768
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608405}

For largest, last image paint timing, we have supported img tag, svg image,
and video image poster, but we haven't included background image. The purpose
of this CL is to include background-image in the image paint timing.

The background image that FCP++ cares about is contentful background image,
which are used as content by web pages, as opposed to "backgroundful"
background image, which are used for background purpose by web pages.

We have a few heuristics to rule out non-contentful background images:
* If a background image is attached to <body>, <html>, then it's less likely to
be contentful.
* If a background image does not have image resources, then it's not contentful.

Background image differs from other supported image in various aspects:
* Background images are attached to the style of objects.
* One object can have multiple background images.

Accordingly, we define "loaded" for an object attaching background-images as
all of its background images have been loaded.

These aspects are reflected in this implementation.

Bug: 869924
Change-Id: Icc4962420e7c8ba213c9f3f1124a413c4b545957
Reviewed-on: https://chromium-review.googlesource.com/c/1334332
Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608404}

Normally custom ErrorProne checks would catch this,
but they were inadvertently disabled.
In preparation for for re-enabling these custom ErrorProne checks
this CL removes redundant field initializations in GEN_JNI
(the generated java file that contains proxy native methods).

Bug: 904524
Change-Id: I2e7b2d93b4ed89d34b236ab9a64dc6c47dcdd17d
Reviewed-on: https://chromium-review.googlesource.com/c/1334093Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Aiden Benner <abenner@google.com>
Cr-Commit-Position: refs/heads/master@{#608403}

This is cleanup in preparation for
https://chromium-review.googlesource.com/c/chromium/src/+/1313556, but
is probably worth it on its own as it puts all of the logic for save/
restore into WebAppActivity instead of having dependent logic split
across SingleTab and WebApp Activity.

Change-Id: Ibdf372e6c3a6be3f7d546a071162ed7a11a5f613
Reviewed-on: https://chromium-review.googlesource.com/c/1329544
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608402}

Move the
LoadablePluginPlaceholder::DidFinishIconRepositionForTestingCallback
method to the PluginPlaceholderBase base class so that the
PDFPluginPlaceholder can also use it.

This is a followup to:
https://chromium-review.googlesource.com/c/chromium/src/+/1335781

This is patch 2/3 for this objective.

Bug: 887752, 879149, 878871
Change-Id: I14f2205d0d8d7c5fcd14fc2eac84e2b7fd1d52dc
Reviewed-on: https://chromium-review.googlesource.com/c/1335997
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608401}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a6150a3fe778..a29a9947ac96


git log a6150a3fe778..a29a9947ac96 --date=short --no-merges --format='%ad %ae %s'
2018-11-15 dneto@google.com UniformConstant variables can have RuntimeArray, TypeAccelerationStructureNV
2018-11-14 greg@lunarg.com Fix Instruction::IsFloatingPointFoldingAllowed()
2018-11-14 33432579+alan-baker@users.noreply.github.com Allow InstanceId for NV ray tracing (#2049)
2018-11-14 zoddicus@users.noreply.github.com Validate variable types for UniformConstant storage in Vulkan (#2008) (#2044)
2018-11-14 stevenperron@google.com Fix folding of volatile store. (#2048)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@a29a9947ac96

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ic750cb3e79d25e3ba35e8c5e015117d302831321
Reviewed-on: https://chromium-review.googlesource.com/c/1338120Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608400}

Previously, only PluginPowerSaverBrowserTest had access to the ability
to await the placeholder to be ready.

Now that we want to do this for a PDF placeholder browser test as well,
move this functionality to a test support class.

This is patch 1/3 for this objective.

Bug: 887752, 879149, 878871
Change-Id: Ib0bc70f21d25ec35874025c0952f7c42555fce5b
Reviewed-on: https://chromium-review.googlesource.com/c/1335781
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608399}

If the min/max parameters are really fubar, such as which might come
from a malicious IPC message, min & max can be limited only to then
be swapped and become invalid.  Do the swap first.

Also, remove duplicate bucket-limit condition and set the defined
maximum to be the lower of the two.

Bug: 905226
Change-Id: If73e97e43e93704f93456da6af0708422fa145a0
Reviewed-on: https://chromium-review.googlesource.com/c/1335731
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608398}

This CL puts all pieces together making sure that received messages
get persisted if Chrome is in the background, and replayed next
time it comes to the foreground.

Bug: 882887
Change-Id: I3dea0aa3ad9a01a7f4d59c5b798a018488980beb
Reviewed-on: https://chromium-review.googlesource.com/c/1276608
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608397}

Fixes the following two browser tests for UAv2:
- ExtensionBindingsApiTest.UserGestureFromExtensionMessageTest
- MessagingApiTest.MessagingUserGesture

Bug: 860509
Change-Id: I3a70c3d3fa7a6dd8351422399193e9b49c63bd0d
Reviewed-on: https://chromium-review.googlesource.com/c/1335782Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608396}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/a7e03047837c..d09518789d3f


git log a7e03047837c..d09518789d3f --date=short --no-merges --format='%ad %ae %s'
2018-11-15 manojgupta@chromium.org Revert "generic_stages: temporarily ignore all target prebuilts."


Created with:
  gclient setdep -r src/third_party/chromite@d09518789d3f

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I8036c02397e31dfef707f1ddb597d01d1f24bef6
Reviewed-on: https://chromium-review.googlesource.com/c/1337531Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608395}

This is possible now that Android P SDK is in Chromium.
The direct calls are placed in an ApiHelper class to avoid ART runtime
verification issues.

Change-Id: I88cf7788006aaa63b708a16f52aad00132e28c05
Reviewed-on: https://chromium-review.googlesource.com/c/1335874Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608394}

Test: Built and Run with Android N(on Cast Master) changes (Cast + setup) on the AT1
Bug: 118437285
Change-Id: Iff72a2a2d8eabda619940a256bab1b23daf00c26
Reviewed-on: https://chromium-review.googlesource.com/c/1331579
Commit-Queue: Elvin L <elvin@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608393}

This reverts commit bcc4146d.

Reason for revert: android.webkit.cts.WebViewStartupTest#testCookieManagerBlockingUiThread is consistently failing.

Bug: 905025

Original change's description:
> [TaskScheduler]: Migrate off of ScopedAllowWait in /android_webview
> 
> base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more
> explicit counterpart.
> 
> It should have been replaced by :
>  * base::ScopedAllowBaseSyncPrimitivesForTesting in test files.
>  * base::ScopedAllowBaseSyncPrimitives in non-test files
>  * base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope when it's used on threads
>    that don't allow blocking
> The last one is strongly frowned upon but this CL aims to document existing
> behavior rather than address it. Owners are encouraged to follow-up by fixing
> unnecessary waits and more particularly unnecessary waits
> outside-blocking-scope.
> 
> Note: The non-for-testing versions require friend'ing in thread_restrictions.h
> but care was taken to add these friends ahead of git cl split (since it wasn't
> possible to do a line-by-line associated CL split).
> Refer to the top-level CL if necessary :
> https://chromium-review.googlesource.com/c/chromium/src/+/1288533
> 
> Please CQ if LGTY!
> 
> This CL was uploaded by git cl split.
> 
> R=​torne@chromium.org
> 
> Bug: 766678
> Change-Id: I30e57cb0d9a0b1a449a4227561e97ea330ff6a12
> Reviewed-on: https://chromium-review.googlesource.com/c/1325195
> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607674}

TBR=gab@chromium.org,torne@chromium.org,etiennep@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 766678
Change-Id: If1ee0994f4387786662d7814617b297939b4dffb
Reviewed-on: https://chromium-review.googlesource.com/c/1337637Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608392}

This patch ensures that we don't early out under requires_clear when
doing OOP raster. If we early out, and we were doing a partial raster,
then we might end up with previous content on the texture.

R=enne@chromium.org, piman@chromium.org

Bug: 901897
Change-Id: I9e74e7f5b04d14385b733df50b08e027f5e6d1d3
Reviewed-on: https://chromium-review.googlesource.com/c/1335662
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608391}

Add implementation and test for PrimaryAccountMutatorImpl
methods {Set,Is}SettingPrimaryAccountAllowed.

Bug: 889902, 806778
Change-Id: Ibd75f2b3a988b4c403eab3b682a157e31e4b2e18
Reviewed-on: https://chromium-review.googlesource.com/c/1335937Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608390}

Make arrow key navigation through tiles not depend on the pixel width
of the dialog. When using the up and down keys first search for a tile
in the indicated direction that's in a different row ('top' is
different) then the tile that's in the same column ('left' is the same).

Bug: 896630
Change-Id: Ie5c9f7ebffba521dad1b8056626573c5015b3a36
Reviewed-on: https://chromium-review.googlesource.com/c/1335956Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608389}

Remove an unused constant that was moved to a test/ header
Fix copyright header format in cleaner dir
Fix comma in comments in constants dir

R=csharp@chromium.org

Bug: 830892
Change-Id: I8e91c4e320ceb3f8758d7182853dd46874968f6e
Reviewed-on: https://chromium-review.googlesource.com/c/1336048
Commit-Queue: Joe Mason <joenotcharles@google.com>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608388}

Essentially, this is accomplished by setting a TouchEventFilter with no touch-able area. This will gray out the entire view and look exactly like the overlay used to look.

Also, the unexpected tap counter is now reset each time a TouchEventFilter is disabled. This should result in more consistent and predictive behavior.

Bug: 806868
Change-Id: I308a3dc488e8d778245bfdc88714d1a9e621c8df
Reviewed-on: https://chromium-review.googlesource.com/c/1335940
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608387}

Bug: 866147
Change-Id: Ibdb5bf46ec67c139b18ee6ca2c5853cac6dd99d8
Reviewed-on: https://chromium-review.googlesource.com/c/1337810Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608386}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a59368241b0c..32a6bd7b54fd


Created with:
  gclient setdep -r src-internal@32a6bd7b54fd

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Id19178f2292e47a0e73124177b5907dda9f95051
Reviewed-on: https://chromium-review.googlesource.com/c/1337482Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608385}

Remove android_lint targets' dependency on the corresponding
compile_java target. This allows javac and lint to run concurrently.

Add srcjar_deps for android_lint target since R.java is necessary to
determine which resources are used. These are no longer transitively
depended upon through compile_java.

Bug: 856189
Change-Id: If8b8abb1796bd50eb602443a36e3a198c3d35160
Reviewed-on: https://chromium-review.googlesource.com/c/1308100
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608384}

Started failing, apparently, in:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/8903

TBR=nasko@chromium.org

Bug: 874782
Change-Id: I5c7746682a08fea050bfa711c3f052edf2f7de07
Reviewed-on: https://chromium-review.googlesource.com/c/1337348Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608383}