- 29 Jun, 2018 13 commits
-
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/35ab1bd0328a..5fbb98122c59 git log 35ab1bd0328a..5fbb98122c59 --date=short --no-merges --format='%ad %ae %s' 2018-06-28 tsepez@chromium.org Fix logic error in CJX_InstanceManager::count() 2018-06-28 thestig@chromium.org Remove redundant FPDF_PAGEOBJECT null-ness checks. Created with: gclient setdep -r src/third_party/pdfium@5fbb98122c59 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:353450 TBR=dsinclair@chromium.org Change-Id: I3a1d4240ed411c4dbd2801fb2ef7fae39307b8eb Reviewed-on: https://chromium-review.googlesource.com/1118814Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571346}
-
Aleks Totic authored
Rename NGLayoutInputObject::GetLayoutObject to GetLayoutBox() Bug: 728378 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ie4a1beed8aed3268ecfca4d62113490f393f01de Reviewed-on: https://chromium-review.googlesource.com/1119360 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#571345}
-
Joel Hockey authored
* Test verifies fake root is shown, then mounts container and verifies that correct volume and contents are displayed. Unmounts volume, and verifies that fake root is shown again. * Sets prefs / features for crostini and registers mount callback with FakeCrosDisksClient to simulate sshfs mounting. Bug: 845075 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ice3f96430ef063a9942fdd2c40e99b30b35b0c50 Reviewed-on: https://chromium-review.googlesource.com/1094574 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#571344}
-
chrome://settings/inputMethodsyusukes authored
ARC IMEs added via Play Store are not associated with any language by design. Instead, each IME supports only one fake language |kArcImeLanguage| defined in ui/base/ime/chromeos/. This CL allows chrome://settings/inputMethods to show such IMEs at the bottom of the list by doing the following: - Return |kArcImeLanguage| and its display name from the GetLanguageList() private API. - Do not show the fake language in add_languages_dialog.js since it's for internal use only. - Modify manage_input_methods_page.js to show ARC IMEs associated with |kArcImeLanguage|. - Handle ARC IMEs in the AddInputMethod() private API. Bug: b:74499980 Bug: 845079 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I28a1b01705387dc9cd87dd0b873dc3ca23087cbf Reviewed-on: https://chromium-review.googlesource.com/1114680Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#571343}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8bcc71ebebc5..cb0889ef01d0 git log 8bcc71ebebc5..cb0889ef01d0 --date=short --no-merges --format='%ad %ae %s' 2018-06-28 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@cb0889ef01d0 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If2cd6d518e32f8100714d2a92751ca90a93ce732 Reviewed-on: https://chromium-review.googlesource.com/1119331Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571342}
-
Steven Bennetts authored
GetProfileByUser() will return null for a non logged in user, so do not use IsOwnerProfile() to set is_owner. This also fixes behavior in ChromeUserManagerImpl where the active user was not correctly set as the owner when kStubCrosSettings is set because UserManagerBase::UserLoggedIn is calling RegularUserLoggedInAsEphemeral() instead of RegularUserLoggedIn() for non owners, and the logic to set the user as the owner was in RegularUserLoggedIn(). Bug: 856441 Change-Id: I085d46accb3c97c1b6ee5615b838a5de796e3f8b Reviewed-on: https://chromium-review.googlesource.com/1118921 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#571341}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b3853afe341f..ae1f03388f7a git log b3853afe341f..ae1f03388f7a --date=short --no-merges --format='%ad %ae %s' 2018-06-28 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-28 vadimsh@chromium.org [cipd] Bump cipd and vpython to versions that use v2 protocol by default. 2018-06-28 jbudorick@chromium.org gclient: escape cipd variables when flattening DEPS. 2018-06-28 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-28 ehmaldonado@chromium.org gclient: Don't include CIPD package name in hierarchy. Created with: gclient setdep -r src/third_party/depot_tools@ae1f03388f7a The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:801423,chromium:None TBR=agable@chromium.org Change-Id: I7b9f1d0635aeb8fec52b5bc1541c10001489df04 Reviewed-on: https://chromium-review.googlesource.com/1119329Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571340}
-
wutao authored
It was confusing about the display zoom and a11y feature magnifier zoom. Modify the descriptions to make it more clear. Bug: 854868 Test: manual Change-Id: I037e9990b2d6eb43b19e5151077032f3fb52818f Reviewed-on: https://chromium-review.googlesource.com/1115718 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#571339}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 23b63ae4. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20306 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=markdittmer No-Export: true Change-Id: Id87100dcd1a3710da9b9502de0240110a910484f Reviewed-on: https://chromium-review.googlesource.com/1119354 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#571338}
-
Khushal authored
The change in [1] inadvertantly caused us to allocate a temporary buffer for decoding an image and then copying into the target memory, if requested with kNone_SkFilterQuality. Fix it. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1106608 R=ericrk@chromium.org Bug: 855416 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I01d23176ae12808022f67286025243bcaab655ed Reviewed-on: https://chromium-review.googlesource.com/1119348Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#571337}
-
Bailey Forrest authored
The Bluetooth stack cannot handle certain BLE operations concurrently. Bug: internal b/109767461 Test: cast_bluetooth_unittests. Manual. Change-Id: Ia3b15c64fa553a8221aa995cbab42c15cc977f7a Reviewed-on: https://chromium-review.googlesource.com/1109580 Commit-Queue: Bailey Forrest <bcf@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#571336}
-
Theresa authored
This effectively removes the grey navigation bar divider line when the navigation bar color is black on Android P+. BUG=844173 Change-Id: I5147f63aadd9d79d084fa582284e46fb2c6b6fe9 Reviewed-on: https://chromium-review.googlesource.com/1119369 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#571335}
-
Cole Winstanley authored
Making CloseWindow W3C compliant by returning the result of GetWindowHandles. Modified testCloseWindow in run_py_tests.py to test this conformance. Bug: chromedriver:1990 Change-Id: I2e90e9e9ca16559ea3678846a7d605b402b4d431 Reviewed-on: https://chromium-review.googlesource.com/1115813Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Cole Winstanley <cwinstanley@google.com> Cr-Commit-Position: refs/heads/master@{#571334}
-
- 28 Jun, 2018 27 commits
-
-
Bret Sepulveda authored
When the avatar button is activated using the keyboard the first profile should be highlighted. But the new Refresh avatar button was using a code path that always indicated the keyboard was used. As a short-term fix, this patch avoids that code path entirely. Bug: 849810 Change-Id: I87c32cf76870d92911f227afd74a9dd1e201a4b2 Reviewed-on: https://chromium-review.googlesource.com/1119385Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#571333}
-
Dave Schuyler authored
This CL fabricates a rich suggestion/new answer layout for calculator responses by creating a mimicking a suggestiondetails entry. Change-Id: I5fdc83b2f31d703e0ed8421e9be65233c9be2cb1 Reviewed-on: https://chromium-review.googlesource.com/1111460 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO 6/27) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#571332}
-
Esmael El-Moslimany authored
Bug: 849857 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I2bdac0e55708bc7461041365ac736ad2c5bc7bc1 Reviewed-on: https://chromium-review.googlesource.com/1114204Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#571331}
-
Pedro Amaral authored
Custom tabs don't have an overflow menu or menu wrapper which was causing a null pointer exception. This CL adds a null check. Bug: 857416 Change-Id: Ic2604bb7545cb1e94df6c9a720da74e7171e11c0 Reviewed-on: https://chromium-review.googlesource.com/1119150Reviewed-by:
-
Ryan Sturm authored
This call clears persisted state that is tied to navigation history. Bug: 797981 Change-Id: Ie0e2224f673b07ef6edc80e30f0cbb518dea0029 Reviewed-on: https://chromium-review.googlesource.com/1119157Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#571329}
-
Yuly Novikov authored
Pixel_OffscreenCanvasTransferBeforeStyleResize on Mac Intel HighSierra TBR=kbr@chromium.org Bug: 857578 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie29b7978a7328bb3c47f722bd695839aa76c1eca Reviewed-on: https://chromium-review.googlesource.com/1119070 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#571328}
-
James Darpinian authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/5e83981..a5c263c Bug: 853978, 857303 Change-Id: I9cf554d30f5f51bcdca25f7fa6b1027312de0e77 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win_angle_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1117894Reviewed-by:
-
sczs authored
Previously history filtering was using selectRowAtIndexPath: to select the rows that were going to be filtered by the searchController. This caused that previously selected cells on edit mode were filtered out when searching. This CL introduces an Array to hold these indexes to filter out later. Also, when there're no results when search filtering, the emptyTableView shouldn't be displayed. Bug: 857088 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I40bd4e5181d84fc23edae1eeea64e899aa120d4f Reviewed-on: https://chromium-review.googlesource.com/1118909Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#571326}
-
Nico Weber authored
The leak is now fixed. Bug: 855583,843511 Change-Id: Id8367b404108467783ac5e2c8c186b7ba210df4f Reviewed-on: https://chromium-review.googlesource.com/1117611Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7ddf0ed7f771..e2d6bbca629c git log 7ddf0ed7f771..e2d6bbca629c --date=short --no-merges --format='%ad %ae %s' 2018-06-28 benjhayden@chromium.org Remove Test and TestMetadata indexes. Created with: gclient setdep -r src/third_party/catapult@e2d6bbca629c The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia282d1c275ce6114148b0ac6e303932141452161 Reviewed-on: https://chromium-review.googlesource.com/1119325Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571324}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/66c52be1969a..8bcc71ebebc5 git log 66c52be1969a..8bcc71ebebc5 --date=short --no-merges --format='%ad %ae %s' 2018-06-28 xixuan@chromium.org chromeos_config: Mark reef as experimental. 2018-06-28 yueherngl@google.com octopus: mark paladin as important (not experiment) 2018-06-28 dhanyaganesh@chromium.org CreateTarball: Adding psutil based listening on directories to be tarred Created with: gclient setdep -r src/third_party/chromite@8bcc71ebebc5 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:854862,chromium:547055 TBR=chrome-os-gardeners@chromium.org Change-Id: I41a1df6c6122c1eb6d6c66cc415ae2518ba3356b Reviewed-on: https://chromium-review.googlesource.com/1119326Reviewed-by:
-
Hitoshi Yoshida authored
This reverts commit aa1b9b70. Reason for revert: Just in case. There comes a concern from a reviewer. Original change's description: > bindings: Clear ScriptState self-reference at disposing worker global scope > > Each v8::Context is wired with a ScriptState, and it clears the > self-reference of ScriptState at its termination. > In worker threads, it means that ScriptState is kept alive until > terminating v8::Isolate, although ScriptState is not used after > disposing global scope. > > This CL explicitly does tasks in weak callback registered in v8::Context > at disposing global scope. Actual tasks are (1)to clear self-persistent > of ScriptState and (2)to drop a weak reference from ScriptState to > v8::Context. > This change makes it possible to release ScriptState at anytime before > v8::Isolate termination. > > > Bug: 773605 > Change-Id: I9da5052c035a0b56dd47a6305df89809b05408a7 > Reviewed-on: https://chromium-review.googlesource.com/1117976 > Commit-Queue: Hitoshi Yoshida <peria@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571107} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org Change-Id: Ibf5511ad731ec8c18ad2df32f24060e9be81ba86 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773605 Reviewed-on: https://chromium-review.googlesource.com/1119425Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#571322}
-
Ned Nguyen authored
This reverts commit f02c92e1. Reason for revert: still breaking perf waterfall https://ci.chromium.org/buildbot/chromium.perf/linux-perf/315 Original change's description: > Reland "gtest perf tests: Output well formed test results json" > > This reverts commit 9eeaba4e. > > Reason for revert: Will re-land with fix > > Original change's description: > > Revert "gtest perf tests: Output well formed test results json" > > > > This reverts commit 71b865f4. > > > > Reason for revert: break many perf tests (see https://ci.chromium.org/buildbot/chromium.perf/linux-perf/307) > > > > Original change's description: > > > gtest perf tests: Output well formed test results json > > > > > > This CL changes the run_gtest_perf_test.py script to output well formed > > > test results json. > > > > > > Bug: 855234 > > > Change-Id: Ia5ce6e258865e34a2aa37635c014cd54efa62796 > > > Reviewed-on: https://chromium-review.googlesource.com/1112635 > > > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#570943} > > > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org > > > > Change-Id: Ia0aaff923014438005ebc0a8677c3bbbebb808ac > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 855234 > > Reviewed-on: https://chromium-review.googlesource.com/1118238 > > Reviewed-by: Ned Nguyen <nednguyen@google.com> > > Commit-Queue: Ned Nguyen <nednguyen@google.com> > > Cr-Commit-Position: refs/heads/master@{#571083} > > TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org > > Change-Id: Idb255b1fafb7f254fd44d6554f93ff27608279f2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 855234 > Reviewed-on: https://chromium-review.googlesource.com/1118789 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571245} TBR=dpranke@chromium.org,nednguyen@google.com,martiniss@chromium.org,eyaich@chromium.org Change-Id: I6bc0869caa6a763dc8bb542fd5a1b3d25853ac86 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 855234 Reviewed-on: https://chromium-review.googlesource.com/1119445Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#571321}
-
Kurt Horimoto authored
This is the TableView equivalent of ReadingListCollectionViewItem. This CL also consolidates logic shared between the table and collection version of these items into helper functions called by the mediator. In addition, the shared logic calculating custom accessibility actions for cells has been moved to a helper object owned by the table/collection views. Bug: 805209 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If6aed9d4ead9b167c8700e0db0c6c4dac5b6f132 Reviewed-on: https://chromium-review.googlesource.com/1104892 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#571320}
-
Jacob Dufault authored
Bug: 854453 Change-Id: I7e1e187ce37a90036a4335ddd333f56b35bf1ac1 Reviewed-on: https://chromium-review.googlesource.com/1117709Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#571319}
-
Aleks Totic authored
Margins were being computed incorrectly in abspos_utils. Margins were not being copied to Legacy. The tricky part is that if node is using old block layout, strange margins get computed because of the way we enforce abspos child size: SetIsFixedSizeInline causes block layout to compute margins wrt that fixed size. The fix is to let Legacy block layout compute margins incorrectly, and set them to correct values afterwards. Bug: 740993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I6e9354fdcad0e0703bd35ad849300be9f223f618 Reviewed-on: https://chromium-review.googlesource.com/1119078Reviewed-by:
-
rbpotter authored
Fixing MaterialBookmarksDNDManagerTest.All and MaterialBookmarksStoreTest.All Bug: 738611 Change-Id: I651e9ad57dbd0bd6bf3b453ee2e5dc5a656773ec Reviewed-on: https://chromium-review.googlesource.com/1117891 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#571317}
-
Pedro Amaral authored
The ic_search image is gray so that is why there is the black tinting. Change-Id: I51c9c56cf001b2df9a896c3367b9d6c100137f0b Reviewed-on: https://chromium-review.googlesource.com/1117768 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Aldo Culquicondor authored
We want all our rendering paths to use the same ganesh (GPU) provider. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I77deca35580ce552deed6219a10eea7f00d9eed2 Reviewed-on: https://chromium-review.googlesource.com/1119120 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#571315}
-
Becca Hughes authored
Add UseCounter metrics for the Display Cutout pinch gesture and expose to UKM so we can cross reference events together. BUG=855739 Change-Id: I89da2effa938380fad5b065ede01e6b757ee17ca Reviewed-on: https://chromium-review.googlesource.com/1112724Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#571314}
-
Mike Wasserman authored
ShellDelegateMash does not create a valid keyboard ui instance. TBR=blakeo@chromium.org Bug: 856235, 646565 Test: No keyboard crash on --enable-features=OopAsh device startup. Change-Id: I26ac1c13f46b839a4b77c6aaf478abec745126f1 Reviewed-on: https://chromium-review.googlesource.com/1119088 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#571313}
-
Nico Weber authored
Bug: 857393 Change-Id: Ib852b5824b27443f7e1f5176646588fcbef195ed Reviewed-on: https://chromium-review.googlesource.com/1118857Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#571312}
-
Jian Li authored
Bug: 852577 Change-Id: Icf852d1a7f454e623368fae5ecfeb523ee835bee Reviewed-on: https://chromium-review.googlesource.com/1119061Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#571311}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: luci.chromium.try:closure_compilation;luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibc4b7b0fac1b5f321e362c86b59437d4a8869f53 Reviewed-on: https://chromium-review.googlesource.com/1119379Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#571310}
-
Donn Denman authored
Adds a new Feature to chrome://flags for Android to use to enable a modern version of the Full-roll animation. BUG=856792 Change-Id: I2b2369f509dd809e12c03bf4ac79c58e764799a4 Reviewed-on: https://chromium-review.googlesource.com/1116186 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#571309}
-
Scott Chen authored
This CL provides a more encapsulated way to focus and select the text within cr-input. Bug: 832177 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie1bf83d51fd706adc18b879251639c78381dc4fd Reviewed-on: https://chromium-review.googlesource.com/1114254 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#571308}
-
danakj authored
If LayerTreeHost is destroyed while TextureLayer has a resource, it should return that resource, not marking it as lost, and not crashing. R=piman@chromium.org Bug: 857262 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1e70dd4a17ca9e556d5332ee25d1fd567cb7dad7 Reviewed-on: https://chromium-review.googlesource.com/1119093Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#571307}
-
