GitLab

CryptAuth v2 Enrollment and v2 DeviceSync are separate
Cloud/Pantheon/Firebase projects that need separate authorization to
send push notifications to the client. The authorized entity values here
identify the v2 Enrollment and v2 DeviceSync Cloud/Pantheon/Firebase
projects.

While the user's Instance ID can be used across multiple CryptAuth
projects, the Instance ID *tokens* are project specific. The authorized
entity values are needed to generate Instance ID tokens. These tokens
are unique and immutable identifiers of the client's authorization of
the project to send the client push notifications.

Bug: 951969, 990430
Change-Id: Iad38286357f71054530a9afc05c5dc2382edcbae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735472
Commit-Queue: Josh Nohle <nohle@chromium.org>
Auto-Submit: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684451}

This change adds DCHECKs to AXNode::*Unignored* traversal methods to
guarantee they are not accessed in the middle of a tree update, which
can cause subtle bugs if the previously unignored parent becomes
ignored during the update.

---

Problem :
  AXTree notifies AXTreeObservers of node and subtree changes in the middle
  of a tree update, which means observers may be seeing a tree state that's
  incomplete. This can lead to subtle bugs when observers access nodes in the
  AXTree other than the node being updated.
  e.g. |GetUnignoredParent| may be invalid during a notification, but
  correct afterwards.

Proposed solution :
  Separate notifications from updates in AXTree::Unserialize.

  This requires the following steps :
    1. Record all operations that would be performed on the tree.
    2. Fire all on destroy and OnNodeDataWillChange callbacks.
    3. Apply all update operations.
    4. Fire all created and node data changed callbacks.


  For additional context, see these comments by Nektarios and Dominic :
  https://chromium-review.googlesource.com/c/chromium/src/+/1650222/20#message-ffe9bf96b616a915bebf2e69d7803bcae6a18b24
  https://chromium-review.googlesource.com/c/chromium/src/+/1535171/69#message-7b62970b193439a1878d7339cdc94d2556d0a416

  I  plan to submit approximately 3 CLs to resolve this :
    1. Handle Pre/Post Tree changes (create node / destroy subtree)
    2. Handle Pre/Post Node data changes (attributes will / have changes)
    3. Add DCHECKs to AXNode::*Unignored* accessors, along with any remaining
       work required to do so, to help harden these paths.

Bug: 974444
Change-Id: I40ce8a29b7faf2f1eeea513c37a19320062783f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710052
Commit-Queue: Adam Ettenberger <adettenb@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#684450}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time
       requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",
          "PostTask"],
         ["PostDelayedTaskWithTraits",
          "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",
          "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",
          "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",
          "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits",
          "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",
          "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",
          "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=simonhatch@chromium.org

Bug: 968047
Change-Id: I90e2499257ebe0b5914568b3f496d32c48b4f6e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739806
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Commit-Queue: Simon Hatch <simonhatch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684449}

Change-Id: I158bbc20c0b0eea748d1200b4709d48d1355fe80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739667Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684448}

Currently blocking the importer. Example:
https://test-results.appspot.com/data/layout_results/linux-rel/159555/not_site_per_process_webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html

No-Try because the change hasn't landed in Chromium yet.

TBR=flackr

No-Try: True
Bug: 991295
Change-Id: I599bd336d45df0ca928711657cb81cb838713990
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738335Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684447}

The mapping is defined by the spec at:
https://immersive-web.github.io/webxr/#xr-standard-gamepad-mapping
Now, only a primary trigger is required for a controller to claim
xr-standard mapping, and the order of some of the buttons has changed.

Centralize the logic of how to order buttons + input axes, as well as
where/when to add placeholder values in the XRStandardGamepadBuilder
class.

Bug: 979246
Change-Id: Iefb116ea603c0a7237575d189686fd2daee9de90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728345
Commit-Queue: Jacob DeWitt <jacde@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684446}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time
       requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",
          "PostTask"],
         ["PostDelayedTaskWithTraits",
          "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",
          "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",
          "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",
          "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits",
          "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",
          "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",
          "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=battre@chromium.org

Bug: 968047
Change-Id: I034c246f7d4dbfb87ad12731f35e47e8710ddd16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738600
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684445}

Change-Id: I9a6c3772e33e67cfe99f2d20da97c0f52aaa8fbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739543Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684444}

MessageLoopForIO will go away soon use ScopedTaskEnvironment instead.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you believe your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=rdevlin.cronin@chromium.org

Change-Id: I011ff9c037debc4092850caff94f52f4d7667ea0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733610Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684443}

Increases the swarming expiration and overall builder execution timeout
for Win10 FYI x64 Release (Intel UHD 630) since only having one device
is causing shard timeouts on heavily sharded tests and the builder is
getting dangerously close to its current 6 hour timeout.

Bug: 986939
Change-Id: I30f01c869b405cea3aae0e11b09f0d81769d62e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739590
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684442}

Due to the loose, asynchronous coupling between the C++ and JavaScript
portions of the layout code, we need to pass certain layout "options"
(such as the default page orientation) back and forth by value.

As a result, it makes sense to have a separate Options class to hold
these settings, which then can be used to recalculate the layout.

The expected layout lifecycle eventually should look like this:
1. Update desired layout options one or more times.
2. Estimate layout size with new layout options.
3. Send options and estimated size to JavaScript.
4. Receive updated options from JavaScript.
5. Apply final options to current layout.
6. Repaint using updated layout.

As a side effect of this change, I added the desired_layout_options_
field to PDFiumEngine. This new field holds the mutable state about
page orientation that was split off into DocumentLayout::Options.

Miscellaneous changes:
* Revised some of the API comments for DocumentLayout
* Eliminated need for unsigned math by replacing -1 with +3 (mod 4)
* DocumentLayout no longer needs to be copyable, so it isn't

Bug: 885110
Change-Id: I89714c4c2cba6c0ab354c0696ec3943327c979d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733795
Commit-Queue: K Moon <kmoon@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684441}

Bug: 934009
Change-Id: I859a008b9a68313d3d0479225d20b2b23acf4de4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738667
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684440}

https://android.googlesource.com/platform/external/perfetto.git/+log/600679a1c326..4ec51d883391

git log 600679a1c326..4ec51d883391 --date=short --no-merges --format='%ad %ae %s'
2019-08-06 fmayer@google.com Merge "Add nogncheck to conditional include."

Created with:
  gclient setdep -r src/third_party/perfetto@4ec51d883391

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I7eaa4ec19b4d18f4a3dc97c6ee813c9a9953c99d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738999Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#684439}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time
       requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",
          "PostTask"],
         ["PostDelayedTaskWithTraits",
          "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",
          "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",
          "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",
          "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits",
          "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",
          "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",
          "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=battre@chromium.org

Bug: 968047
Change-Id: Ia14e3392662a15f96dc0675265f93397cf5a22f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739813
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684438}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time
       requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",
          "PostTask"],
         ["PostDelayedTaskWithTraits",
          "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",
          "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",
          "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",
          "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits",
          "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",
          "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",
          "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=rbpotter@chromium.org

Bug: 968047
Change-Id: I5ec1af17a9d1408c6dc656abc9c44a5fcd47bb74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739866
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684437}

Whitespace is important for inline autocomplete, and possibly other fields.

Change-Id: I8dfcb1f2140e20b6d3365f72b9fd832b8eba9303
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739325Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684436}

https://chromium.googlesource.com/angle/angle.git/+log/99f494e42246..6201d134b3bb

git log 99f494e42246..6201d134b3bb --date=short --no-merges --format='%ad %ae %s'
2019-08-06 timvp@google.com Vulkan: Suppress KHR-GLES2 ASTC 3D Texture Tests

Created with:
  gclient setdep -r src/third_party/angle@6201d134b3bb

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Bug: None
Change-Id: I8fb2d5ea7dec802417c8968d3b8f971a6a5a82f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738997Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#684435}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fc9e4928e7c0..838e9713fa32


Created with:
  gclient setdep -r src-internal@838e9713fa32

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None,chromium:None
Change-Id: Ia2e0cb8a2f15aa728c6eb0a28232c634690c7d5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739002Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#684434}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time
       requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",
          "PostTask"],
         ["PostDelayedTaskWithTraits",
          "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",
          "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",
          "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",
          "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits",
          "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",
          "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",
          "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=tbansal@chromium.org

Bug: 968047
Change-Id: Ib877f88fa151617c51533a56adfa399706db5b0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739708
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684433}

1)Checks if there is any saved credit card with the same number.
2)If there is any, then update saved credit card object with the new data
update it in DB by PersonalDataManager.
3)Adds method for updating credit card properties.

Change-Id: Ife5efb47a0bee6439ae05981116bc891b7289f7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731839
Commit-Queue: Reda Tawfik <redatawfik@google.com>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684432}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time
       requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",
          "PostTask"],
         ["PostDelayedTaskWithTraits",
          "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",
          "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",
          "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",
          "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits",
          "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",
          "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",
          "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=tommycli@chromium.org

Bug: 968047
Change-Id: Id69af8c66a5b886be639f1f22c0dc027a49e7758
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738702
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684431}

Bug: 934009
Change-Id: If1af2ec4d66ead9c3fa2f7f36ccabfb726bbec7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739110
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684430}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time
       requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",
          "PostTask"],
         ["PostDelayedTaskWithTraits",
          "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",
          "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",
          "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",
          "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits",
          "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",
          "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",
          "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=rouslan@chromium.org

Bug: 968047
Change-Id: I695547fcd8f3859e16252bf24b8e78d6374ede4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739867
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684429}

The problem was here:

for (size_t i = children().size() - 1; i >= 0; --i) {

The loop variable |size_t i| was of an unsigned int type, so |i >= 0|
was always true.

Repro on Windows by exploring the tree with Inspect on the link provided
in the crbug description.

Bug: 988153
Change-Id: I1cae093da68f12ed1630a568ec7529703c73cf89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737870
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684428}

This is a speculative fix.

Bug: 979565
Change-Id: I140d9a3fa2334f7137e1491c40c61d96bcded8b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729922
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684427}

Patch:
https://chromium-review.googlesource.com/c/chromium/src/+/1692627

Made us consider inline-level OOF-positioned nodes as adjoining, as
their static-position depends on where other floats are placed.

During the first pass the BFC block-offset gets resolved here:
https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc?l=986&rcl=e6157bb7afb778d5c15bb2bb09a457d9632151da

This aborts as it has an adjoining inline-OOF, and *doesn't* resolve
the BFC block-offset at |child_bfc_offset_estimate| instead applying
clearance.

Upon the second pass we now hit the DCHECK as neither of the options
has clearance applied.

Bug: 987004
Change-Id: I2634d56726a4664c869b2ecfa1e7a8a13458e78f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731917
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684426}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time
       requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",
          "PostTask"],
         ["PostDelayedTaskWithTraits",
          "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",
          "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",
          "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",
          "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits",
          "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",
          "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",
          "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=zmin@chromium.org

Bug: 968047
Change-Id: I5af561f465c55acc9b49898abe8051f475f1f873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739826
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684425}

This is another manual update on the Chrome OS orderfile name,
to reflect the recent change on the orderfile name format. This is
another preparation for the autoroller.

BUG=chromium:950627
TEST=The orderfile is tested on Chrome OS. No code is using the orderfile for now

Change-Id: If2a88ec35d89e397c00904f8b5fc093cc7b77dfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739117
Auto-Submit: Tiancong Wang <tcwang@google.com>
Reviewed-by: Eric Boren <borenet@chromium.org>
Commit-Queue: Eric Boren <borenet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684424}

The primary goal of this CL is to use IsA<HTMLDirectoryElement>(element)
in place of IsHTMLDirectoryElement(element)

Bug: 891908
Change-Id: Iab622a1653b9b24d27894bf2ede0ba18a59daf61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739487Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#684423}

Bug: 982122
Change-Id: I9dbf678992caec7ac97ef028e9ec16c2da7db02c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735523Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684422}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time
       requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",
          "PostTask"],
         ["PostDelayedTaskWithTraits",
          "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",
          "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",
          "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",
          "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits",
          "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",
          "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",
          "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=rsesek@chromium.org

Bug: 968047
Change-Id: Ia108448a6cc6ffdcee488ef32c4d9fa77f3839a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739707
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684421}

Updates the expiry of these histograms, which are still
useful to keep around.
IOS.EnterTabSwitcherSnapshotResult
IOS.PageLoadedSnapshotResult

Bug: 974919
Change-Id: I2c5b8f20c02f89c76200a18e53f9c094dda3b81e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737898Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Auto-Submit: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684420}

A writer of a test will see a callstack anyway.

Bug: 877898
Change-Id: I0a77bf5374d59de3eb1249d89db0be8852b16fa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738366Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684419}

It should never be null.

BUG=None

Change-Id: Ic1e72b42e4664177cd42af61d38caa4930c5713c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737741
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Auto-Submit: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684418}

Bug: 967779
Change-Id: I456c2218ca23d9cd4878588f94a82410bfbf056e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692980
Auto-Submit: Mathieu Binette <mbinette@google.com>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684417}

r684202 set the wrong object member. (This fix is equally untested
because I have to wait for Canary in order to try it.)

BUG=990992

Change-Id: I140d081e53f2d10070a35cff8af312db7f3c77d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739395
Commit-Queue: Adam Langley <agl@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684416}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time
       requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",
          "PostTask"],
         ["PostDelayedTaskWithTraits",
          "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",
          "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",
          "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",
          "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits",
          "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",
          "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",
          "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=thestig@chromium.org

Bug: 968047
Change-Id: Ie4c905f2e8a679550fe00953a010c62ceaa9b806
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739709
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684415}

R=drubery
TBR=holte (since http://cl/261944627)

Bug: 965587
Change-Id: Ic8a8c8a05be012bae3bf375d511399eba47c1ed5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739588
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Auto-Submit: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684414}

Set picker value to the exact value that user selected instead of the
darkest of the calculated colors. These 2 colors are similar but not
always the same. Therefor picker value to the exact value so that selected color doesn't jump
after OnThemeUpdate.

Bug: 990379
Change-Id: Iac9ddae122be5daf01ec95bca571ec832aa5a981
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737330
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684413}

With flag kConsolidatedMovementXY enabled, we compare the incoming event's
coordinates with the |synthetic_move_position_| to tell if the event is a
synthetized move that comes from |MoveCursorTo| call.
The check didn't consider the error introduced by converting from pixel to
dip, which causes a failure when there is a fractional device_scale_factor.

This CL makes the check use the same logic as w/o kConsolidatedMovementXY.
This also removes |synthetic_move_sent_| boolean and use
|synthetic_move_position_| for both the flag enabled/disabled.


Bug: 802067
Change-Id: I4847397e317d29b62328d02910b7cb3e8de13759
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704743Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#684412}