- 30 Oct, 2018 40 commits
-
-
Miguel Casas authored
crrev.com/c/1099564 disabled the Pixel_OffscreenCanvasAccelerated2D* tests, correctly increasing the version in pixel_test_pages.py. These tests seem to be passing according to [1], so let's try and reenable them. [1] http://chromium-browser-gpu-tests.commondatastorage.googleapis.com/view_test_results.html?868948046954e7d06d97eb10544ea3b27b320953_android_marshmallow_arm64_rel_telemetry CQ-DEPEND=CL:1303097 Bug: 805031 Change-Id: Ie6b48fde0a03fefbbff185de1818e3105192f5f3 Reviewed-on: https://chromium-review.googlesource.com/c/1303097Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#603959}
-
Francois Doray authored
This is a folow-up for the rename of TaskPriority::BACKGROUND to TaskPriority::BEST_EFFORT in https://chromium-review.googlesource.com/1153461. Bug: 831835 Change-Id: Ia99f3a923622de37cb92490879d2a7b9b6b4f153 Reviewed-on: https://chromium-review.googlesource.com/c/1307673Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#603958}
-
Daniel Rubery authored
Currently, temporary files in the FileAnalyzer unit tests are written wherever the tests were invoked from. This CL writes them to a temporary directory so that 1) we have write permission, and 2) we clean up after ourselves. Bug: 900021 Change-Id: Ia5390c6444c96a70e736f33b3091c73e3ad97516 Reviewed-on: https://chromium-review.googlesource.com/c/1306661Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#603957}
-
James Hawkins authored
Bug: 899324 Test: none Change-Id: I9f632473636f6a6df3e2528a957adadda006a176 Reviewed-on: https://chromium-review.googlesource.com/c/1307236Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#603956}
-
Nico Weber authored
Bug: none Change-Id: Ie647879a8dbd6d7b0f90f71234488ae36d133e4f Reviewed-on: https://chromium-review.googlesource.com/c/1307936Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#603955}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d15a3be3ab45..5e1c1c293b07 git log d15a3be3ab45..5e1c1c293b07 --date=short --no-merges --format='%ad %ae %s' 2018-10-30 erikchen@chromium.org ADB commands should only retry errors, not exceptions. Created with: gclient setdep -r src/third_party/catapult@5e1c1c293b07 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:895027 TBR=sullivan@chromium.org Change-Id: Ifa4ab1888a5a3fd36652fbda11af4e269463b18c Reviewed-on: https://chromium-review.googlesource.com/c/1307753Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603954}
-
David Roger authored
Change-Id: Id19d1e7c7dc9caebad2ba25d8c4bd653e5828757 Reviewed-on: https://chromium-review.googlesource.com/c/1301518Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#603953}
-
Becca Hughes authored
The active media controller follows the last played media session. This changes the logic to ignore temporary media sessions by only following kGain sessions. BUG=893296 Change-Id: I6f7fbdbc52d9c6120888501060dce94befaaacbe Reviewed-on: https://chromium-review.googlesource.com/c/1306784Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#603952}
-
Friedrich Horschig authored
The padding in divider elements hasn't had any effect which is fixed by using the margin instead which shows the desired spacing. Additionally, the line height wouldn't affect the height of the title label and negate any existing padding which is fixed by using the correct lineSpacingMultiplier. Bug: 856180, 900178 Change-Id: Ie4e9e1df1081da9fa5dc5e6aeb1bcb578f22d7d0 Reviewed-on: https://chromium-review.googlesource.com/c/1307399Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Friedrich Horschig [EDT] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#603951}
-
Victor Costan authored
This CL is inspired by https://crrev.com/c/1299235 and also aims to make the BUILD.gn file pass GN's checks. This is accomplished by correctly layering the targets to reflect include dependencies. A side benefit of this CL is that the crc32c target now only exposes the library's public header. TESTED=gn check out/Default/ "//third_party/crc32c/*" Change-Id: Ie0bde3d4c1ae55a6323e0184fcbcf0c01fe0cbb3 Reviewed-on: https://chromium-review.googlesource.com/c/1301557Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#603950}
-
Jonathan Ross authored
We'd like to eventually remove the caching of LocalSurfaceIds everywhere. As a step along the way, this updates ParentLocalSurfaceIdAllocator::GenerateId to be a void method. The rest is a mechanical refactor of the callsites, switching them to the pre-existing ParentLocalSurfaceIdAllocator::GetCurrentLocalSurfaceId to cache. We'll update each area separately in follow ups to remove the caches. TBR=sky@chromium.org TBR=yfriedman@chromium.org TBR=boliu@chromium.org Bug: 655231 Change-Id: I706e66b9d4a9a594f9a61eb15d2a1505fc0e9ead Reviewed-on: https://chromium-review.googlesource.com/c/1307693 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#603949}
-
phweiss authored
If VpnConfigAllowed is false, it should not be possible to disconnect VPN connections. We need to modify the "Connect" and "Disconnect" button that appears on the network settings page, but only for VPNs. For this, the |controlled-button| element gets modified such that it can accept a null pref, which indicates that it should not be controlled. BUG=b:72861260 BUG=873123 TEST=browser_tests --gtest_filter=*CrControlledButtonTest* TEST=browser_tests --gtest_filter=*CrSettingsInternetDetailPageTest* Change-Id: I199e56b0eb21f926389192e9150912c2990d4a9b Reviewed-on: https://chromium-review.googlesource.com/c/1278215Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Philipp Weiß <phweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#603948}
-
Owen Min authored
Disable the following test on Linux and Win virtual/scroll_customization/fast/events/touch/gesture/gesture-scrollbar-touchscreen-fling.html virtual/user-activation-v2/fast/events/touch/gesture/gesture-scrollbar-touchscreen-fling.html Bug: 899222 Change-Id: I03e67f08807a04ad364ed3ba7657a88d9514590e Tbr: sahel@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1307583 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603947}
-
Ioana Pandele authored
TBR=mastiz@chromium.org Bug: 899989 Change-Id: Ic839d6c9e02caf9f7d74cfd9fadedb7f144d2901 Reviewed-on: https://chromium-review.googlesource.com/c/1307446Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#603946}
-
Corentin Wallez authored
Also changes existing test targets to use base::BindOnce instead of the deprecated base::Bind, and removes some unused includes. R=kbr@chromium.org BUG=chromium:870747 Change-Id: Ib94ffd228a6057a7010e8581ccb3392ae700c357 Reviewed-on: https://chromium-review.googlesource.com/c/1307510Reviewed-by:
-
Andres Calderon Jaramillo authored
This CL creates a new GPU channel IPC message type, GpuChannelMsg_ScheduleImageDecode, which a renderer will eventually be able to use to request hardware-accelerated image decodes. Two classes are added and plumbed into the existing GPU channel architecture to help deal with this new message: 1) On the service side (GPU process), an ImageDecodeAcceleratorStub processes incoming messages. There is one such stub per GpuChannel, although it is owned by the GpuChannelMessageFilter because it expects to receive messages on the IO thread. 2) On the client side (renderer), an ImageDecodeAcceleratorProxy is associated with a GpuChannelHost. It's a thread-safe helper that allows components in the renderer to schedule image decodes and get back a SyncToken to synchronize on the completion of the decode. The processing of the new IPC message is guarded by the kVaapiJpegImageDecodeAcceleration feature flag: the stub refuses to handle that message if the feature is disabled. Bug: 868400 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5d24e661341b5744b30306aca22903f28a52d695 Reviewed-on: https://chromium-review.googlesource.com/c/1285610Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#603944}
-
Liquan(Max) Gu authored
Last Image Paint and Largest Image Paint concern about the load time of images because they are highly relevant to user experiences. Initially, the metrics only take <image> into account. As video image and svg image are equally important, we should consider video poster image and SVG image as well. Video image example: <video poster="http://example.com/nonexistant.gif"></video> SVG image example: <svg id='svg'> <image xlink:href="http://example.com/nonexistant.jpg"/> </svg> Bug: 869924 Change-Id: Id414d236296829c4423e1f69dc140f54cb91444f Reviewed-on: https://chromium-review.googlesource.com/c/1305753 Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#603943}
-
Justin Cohen authored
This is a reland of 7b97163e, which was reverted because it still referenced some device builders still compiling 32-bit arm. Bug: 894099 Change-Id: Ib1dbcb172aa26c9b0fb2d8af7655971f6f549578 Reviewed-on: https://chromium-review.googlesource.com/c/1307587Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#603942}
-
Lukasz Anforowicz authored
Why remove DoesSiteRequireDedicatedProcess ========================================== This CL removes HeadlessContentBrowserClient::DoesSiteRequireDedicatedProcess. We plan to remove 2 other overrides of this ContentBrowserClient method in follow-up CLs. We want to remove this ContentBrowserClient method altogether, because 1) it is currently the only reason SiteInstanceImpl::GetSiteForURL needs to take BrowserContext* as an argument (and therefore is problematic on threads other than UI thread) 2) the method was initially introduced to support --isolate-extensions which has been obsolete since shipping --site-per-process in M67. Additionally, site-per-process mode was always set globally (i.e. see ContentBrowserClient::ShouldEnableStrictSiteIsolation) and therefore controlling this mode via HeadlessContentBrowserClient::ShouldEnableStrictSiteIsolation is more consistent with how the rest of the code is structured. Removal mechanics ================= Removal of HeadlessContentBrowserClient::DoesSiteRequireDedicatedProcess means that HeadlessBrowserContextOptions::site_per_process() doesn't have any callers and therefore it can be removed (together with HeadlessBrowserContext::Builder::SetSitePerProcess). HeadlessProtocolBrowserTest needs to force site-per-process mode. Before this CL this was done via HeadlessBrowserContext::Builder::SetSitePerProcess. After this CL this is done by having the test inject --site-per-process into the cmdline. Bug: 898281 Change-Id: I2cccd896eb6ac70a97ceae293aa4450a0f005d51 Reviewed-on: https://chromium-review.googlesource.com/c/1306842Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#603941}
-
Xianda Sun authored
The finch result of VizHitTest v2 shows that we have 1% of possible incorrect hit test targets. The data may be noisy because the async verification may get answer after the page layout changes. This CL added a new bucket for unreliable result, it counts in that bucket when the results do not match and another synchronous hit test finds a different target. Bug: 896786 Change-Id: I287359251670d4d33297dced42014d03271424d3 Reviewed-on: https://chromium-review.googlesource.com/c/1289163Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#603940}
-
Ioana Pandele authored
This reverts commit 3b214250. Reason for revert: components_unittests/PaymentsClientTest.* failing on Linux ChromiumOS MSan Tests. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests Original change's description: > Reland "[base] Harden base::JSONWriter::BuildJSONString" > > This is a reland of bbe71c7f > > Original change's description: > > [base] Harden base::JSONWriter::BuildJSONString > > > > This change simplifies and hardens base::JSONWriter::BuildJSONString(). > > It replaces the old base::Value API with the new one, thus implicitly > > replacing DCHECKs with CHECKs. > > > > Bug: 859477 > > Change-Id: I5aa68cbc1e5e241d7b7061da2fe7078ac2904ec8 > > Reviewed-on: https://chromium-review.googlesource.com/c/1304477 > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#603508} > > Bug: 859477, 900041 > Change-Id: I0111b5ac553736cdec5b7a163527bf3bb7cb9233 > Reviewed-on: https://chromium-review.googlesource.com/c/1306356 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603889} TBR=rsesek@chromium.org,jdoerrie@chromium.org Change-Id: I9db48180d39e9aa4cfd7cb11af1df331d10df39d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 859477, 900041 Reviewed-on: https://chromium-review.googlesource.com/c/1308153Reviewed-by:
-
Mohamed Heikal authored
Resource names are being stripped from the apk. Output the R.txt files to the apks directory for archiving during official builds. Bug: 894208 Change-Id: Iba0499fb2ac6dccc22a8997b546955733d4e5e23 Reviewed-on: https://chromium-review.googlesource.com/c/1305813Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#603938}
-
Daniele Castagna authored
The original CL crrev.com/c/1300235 got reverted since we were not initializing the new added member EffectNode::backdrop_filter_quality. This CL initializes it and additionally fixes EffectNode::operator==. Origianl CL description: Computing background blur at full resolution as a backdrop filter turned out not to be cheap. This patch adds a backdrop_filter_quality float to cc::Layer that can be used to reduce the size of the offscreen canvas used to compute the blur. Currently this float is not exposed on the web and can be used only from Chrome UI. TBR=enne@chromium.org, ccameron@chromium.org, rsesek@chromium.org, oshima@chromium.org Bug: 897369 Change-Id: Ibf7594b7a97d8e752890c691ed14dff12266013d Reviewed-on: https://chromium-review.googlesource.com/c/1307591 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#603937}
-
Becky Zhou authored
Bug: 900030 Change-Id: I361f4c7f61fcf86521815cc8ef4129edecbdc442 Reviewed-on: https://chromium-review.googlesource.com/c/1307839Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6aa2ff97..600998aa Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idca869549bbe54f7201f8197c7e83658aeff9838 Reviewed-on: https://chromium-review.googlesource.com/c/1307835Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603935}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3420dcb0cff1..7cba6be85a14 git log 3420dcb0cff1..7cba6be85a14 --date=short --no-merges --format='%ad %ae %s' 2018-10-30 ynovikov@chromium.org Revert "Vulkan: Roll VK deps forward" Created with: gclient setdep -r src/third_party/angle@7cba6be85a14 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:845519 TBR=ynovikov@chromium.org Change-Id: I8968557636a6c70cf7cda4ecc30d3f1df8ae7a37 Reviewed-on: https://chromium-review.googlesource.com/c/1307814Reviewed-by:
-
Charlie Harrison authored
This saves space in the indexed ruleset if: 1. Multiple rules share a pattern 2. Patterns are shared with domain specifiers In practice this doesn't shave off that much space but will be more impactful with different ruleset formats (like Disconnect, for instance). Bug: None Change-Id: I34d221ce52eb9aabaa1e57978860de62142b81d4 Reviewed-on: https://chromium-review.googlesource.com/c/1307586Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#603933}
-
manuk authored
- OmniboxInputs to displatch events with details containing display and query inputs when they change - OutputController to handle those events, cache display and query inputs, and invoke OmniboxOutputs.refresh - OmniboxOutputs.refresh to manage updating the HTML from inputs Bug: 891303 Change-Id: Ice63b04f4eafea5d98e8dddd1f16b17618f2652e Reviewed-on: https://chromium-review.googlesource.com/c/1299534 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#603932}
-
Oystein Eftevaag authored
This reverts commit f36de8b1. Perf regressions addressed by: https://chromium-review.googlesource.com/c/chromium/src/+/1263354 https://android-review.googlesource.com/c/platform/external/perfetto/+/799400 Original change's description: > Revert "Reland "Enable Perfetto by default for all telemetry tests"" > > This reverts commit 0f374eff. > > Reason for revert: http://crbug.com/886918 > > Original change's description: > > Reland "Enable Perfetto by default for all telemetry tests" > > > > This is a reland of 32c8ebbe > > > > Relanding after https://chromium-review.googlesource.com/c/chromium/src/+/1225306 > > > > Original change's description: > > > Enable Perfetto by default for all telemetry tests > > > > > > This will use Perfetto instead of TraceLog for all > > > trace-based Telemetry tests running on Mac/Windows/Android. > > > > > > R=nednguyen@google.com > > > > > > Bug: 839084 > > > Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi > > > Change-Id: I570060cd7f53ea0310f67370b4abec132c8a1a01 > > > Reviewed-on: https://chromium-review.googlesource.com/1176119 > > > Commit-Queue: oysteine <oysteine@chromium.org> > > > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > > > Reviewed-by: Ned Nguyen <nednguyen@google.com> > > > Cr-Commit-Position: refs/heads/master@{#585368} > > > > TBR=nednguyen@google.com > > > > Change-Id: I31b69483281f9fb34c5083888b8f45f00ca95e6e > > Reviewed-on: https://chromium-review.googlesource.com/1208955 > > Reviewed-by: oysteine <oysteine@chromium.org> > > Reviewed-by: Annie Sullivan <sullivan@chromium.org> > > Commit-Queue: oysteine <oysteine@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#592127} > > TBR=sullivan@chromium.org,oysteine@chromium.org,nednguyen@google.com > > Change-Id: I7e3984b90f8f53d1dface9459ea07d7383e7c6d1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/1233717 > Reviewed-by: Egor Pasko <pasko@chromium.org> > Commit-Queue: Egor Pasko <pasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592400} TBR=pasko@chromium.org,sullivan@chromium.org,oysteine@chromium.org,nednguyen@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ic2b034d7d40ee65d14dab9ecfac914b744cd057d Reviewed-on: https://chromium-review.googlesource.com/c/1307793Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#603931}
-
Tommy Steimel authored
This CL adds event handling to allow users to click anywhere on a video to toggle play or pause. Pausing happens immediately, while playing happens after waiting for the double-tap delay. If we pause and then the double-tap happens, we resume playback. Bug: 895636 Change-Id: Idf161767900b3dc03501f8034f0c589c4e5d5800 Reviewed-on: https://chromium-review.googlesource.com/c/1286870Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#603930}
-
kylechar authored
The flag was added for experimenting with power usage and doesn't appear used anymore. It's also broken with OOP-D enabled. Bug: 899300 Change-Id: Id255ce74d252f15346affb34417b883b37fe5987 Reviewed-on: https://chromium-review.googlesource.com/c/1305244Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#603929}
-
Owen Min authored
Disable SpellingMenuObserverTest.NoSpellingServiceWhenOffTheRecord SpellingMenuObserverTest.SuggestionsForceTopSeparator Bug: 899935 Change-Id: Ib5f1089e3be0e9c89805debc064435c0a70a7c17 Tbr: lazyboy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1307894Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a3993dd6c128..15a8883b4d7d Created with: gclient setdep -r src-internal@15a8883b4d7d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:790153,chromium:790158,chromium:790159,chromium:790163 TBR=mmoss@chromium.org Change-Id: I4823352c12685ad95a19a6221992053e5eb75f72 Reviewed-on: https://chromium-review.googlesource.com/c/1307813Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603927}
-
Theresa authored
Adds histogram for the suggestions global position and cluster position when a contextual suggestion is clicked. BUG=899354 Change-Id: Iaf8c136ced97c15a28c5eeafaea71b9f4ed18e1c Reviewed-on: https://chromium-review.googlesource.com/c/1302872Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#603926}
-
Lukasz Anforowicz authored
Change-Id: I6a2e8b08eb2e8045c6e73fef4398524cc6de6211 Reviewed-on: https://chromium-review.googlesource.com/c/1305196Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#603925}
-
Sky Malice authored
Bug: 899330 Change-Id: I652572fc0799ba0b649eada69b5d335f6b77e6cd Reviewed-on: https://chromium-review.googlesource.com/c/1289697Reviewed-by:
-
Lei Zhang authored
- Use more range-based for-loops. - Use more nullptrs. - No else after return. Change-Id: I3291628fe4ebf9f8e9be536ecc46738785d068cf Reviewed-on: https://chromium-review.googlesource.com/c/1306411Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#603923}
-
Ria Jiang authored
gpu_tests.depth_capture_integration_test.DepthCaptureIntegrationTest.DepthCapture_depthStreamToRGBAFloatTexture and gpu_tests.depth_capture_integration_test.DepthCaptureIntegrationTest.DepthCapture_depthStreamToRGBAUint8Texture are flaky on win10. They are already marked as flaky on android, linux and highsierra. TBR=kbr@chromium.org Bug: 737410 Change-Id: I6efac3a17ad1192408b08a4f0294db14b9de31ce Reviewed-on: https://chromium-review.googlesource.com/c/1307554Reviewed-by:
Ria Jiang <riajiang@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#603922}
-
Jonathan Backer authored
crrev.com/c/1284435 introduced a bug where if we flushed due to deadline but had potentially evictable resources for the future, we would not ScheduleEvictExpiredResourcesIn Also added a micro-optimization where if we evict all resources OnMemoryPressure, we also flush to reclaim it immediately. Added unittests to cover flushing logic. Dependency injected fake clock to make test robust. Bug: 899002 Change-Id: I50ca934170ebe76e7f48326e53e60df14c32c078 Reviewed-on: https://chromium-review.googlesource.com/c/1299601 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
-
Nate Fischer authored
No change to production logic. This adds tests for AwContentsStatics.setCheckClearTextPermitted(). This changes AwContentsStaticsTest to not start the browser process by default, because the cleartext tests need to call setCheckClearTextPermitted() before AwURLRequestContextGetter is initialized. This modifies testClearClientCertPreferences() only to restore the previous behavior of that test. R=torne@chromium.org Bug: 899012 Test: run_webview_instrumentation_test_apk --gtest_filter=AwContentsStaticsTest#* Change-Id: I2142ac56370edc4912ec5344ec3ddac86d214b2d Reviewed-on: https://chromium-review.googlesource.com/c/1299148Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#603920}
-
