- 10 Jul, 2019 40 commits
-
-
Gabriel Charette authored
As a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1686776/14/base/test/scoped_task_environment.cc#366 Doing so I realized that a thread_annotations bug I'd also hit in TaskTracker is OS_NACL specific. Fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1695681 and re-enabling proper safety checks in TaskTracker here. R=alexclarke@chromium.org Bug: 946657, 982423 Change-Id: Ibbee23cd855f9c124bb41dfd8d2381b03a020132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692826 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#676063}
-
Jeremy Roman authored
Bug: 982211 Change-Id: I5334461f171986da8e23fe88af21abefe13599a3 Tbr: eae@chromium.org No-Try: true No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696162Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#676062}
-
Robbie McElrath authored
This reverts commit b050ee2d. Reason for revert: The test still fails. Original change's description: > Re-enable VariationsHttpHeadersBrowserTest tests on ChromeOS. > > I can't reproduce flakes locally, so I'm going to re-enable them and see > if we've fixed them in the last couple months. I also added additional > assertions to the test so we'll get more information about why they fail > if they do. > > Bug: 964338 > Change-Id: I4a864101de6cfb1b434c3b2157d2323d8e6e522a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693704 > Reviewed-by: Eric Roman <eroman@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#675871} TBR=eroman@chromium.org,rmcelrath@chromium.org Change-Id: I22e9da1c789c903fe895cfbf45e47a4971b48c83 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 964338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696084Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#676061}
-
Friedrich Horschig authored
Most integration tests don't work well on kitkat since they rely on native code which might not be held in the main DEX file, so this CL disables them. It also makes waiting functions return more specific errors which helps to identify the actual failing conditions from trybot logs. Last but not least, it resolves two common timing issues: 1. Setting a fixed viewport prevents the zoom-on-focus animation which delays UI stability until the animation ends. 2. Autofill chips might be slightly delayed compared to other filling UI elements. Therefore, added and used an option to wait for these chips. Bug: 979182 Change-Id: I1dd08123a08f985c9464e781d12b6f7f2bb77314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695548 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#676060}
-
Guido Urdaneta authored
This CL makes addIceCandidate() return a resolved promise when an empty candidate is given instead of rejecting the promise (which occurred due to a parsing failure). This does not implement proper handling of such candidates, but avoids the rejected promise. Bug: 978582 Change-Id: I78249d471e3b4417b00eeb430951dbf8ab63769d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692176Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#676059}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ef089bcde1e6..9b7fc04d3edb Created with: gclient setdep -r src-internal@9b7fc04d3edb The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=hcarmona@google.com,hajimehoshi@google.com,jbroman@google.com Change-Id: Ifb504402bfc285a351715adfc0c3f21c65d13dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695827Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676058}
-
Liquan(Max) Gu authored
Currently, LargestTextPaint and LargestImagePaint uses node_id as the secondary ranking key. This means when two records have the same size, the node_id will be used to decide which one is the largest. However, the order of node_id can be affected by factors out of LCP. So it's potentially indeterministic. To make the result more deterministic, we can use the insertion order as the secondary ranking key. This CL reflects the above change. Bug: 959984 Change-Id: Id42a32f05593f649f59fcb74fd3c57fa0e2f5fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693036 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#676057}
-
Eric Stevenson authored
This reverts commit bfaee63b. Changes: * Move ContentShell changes to application class for consistency * Support Chrome browser tests (from http://crrev.com/c/1680511) * Remove //ui dep from //testing (which breaks repos that only depend on //testing) Original change's description: Trichrome Proguard: Fix locale pak selection. This CL moves the arrays of locale pak files out of BuildConfig.java into a new file, LocaleConfig.java. This file is generated with a unique package which allows Chrome and Webview to have different versions in Trichrome. TBR=dtrainor@chromium.org,torne@chromium.org,agrieve@chromium.org,estevenson@chromium.org,tedchoc@chromium.org Change-Id: I11281fafc3ae6db9260722e95f9c0c81a2ae20c1 Bug: 960025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682047Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#676056}
-
Andrew Grieve authored
Before: E 153.473s Main Unrecognized error occurred. Traceback (most recent call last): File "bin/../../../build/android/test_runner.py", line 952, in main return RunTestsCommand(args) ... File "/usr/local/google/code/clankium1/src/build/android/pylib/instrumentation/instrumentation_test_instance.py", line 262, in FilterTests raise MissingSizeAnnotationError(GetTestName(t)) MissingSizeAnnotationError: org.chromium.net.smoke.MissingNativeLibraryTest#initializationError: Test method is missing required size annotation. Add one of: @LargeTest, @Manual, @FlakyTest, @DisabledTest, @MediumTest, @SmallTest, @IntegrationTest, @EnormousTest E 4.321s list_tests(86TX00E9L) Unexpected output while listing tests: E 4.322s list_tests(86TX00E9L) Fatal exception when running tests E 4.322s list_tests(86TX00E9L) java.lang.RuntimeException: Failed on initializationError(org.chromium.net.smoke.MissingNativeLibraryTest) E 4.322s list_tests(86TX00E9L) at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.listTests(BaseChromiumAndroidJUnitRunner.java:208) E 4.322s list_tests(86TX00E9L) at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:150) E 4.322s list_tests(86TX00E9L) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:2189) E 4.322s list_tests(86TX00E9L) Caused by: java.lang.Exception: Custom runner class AndroidJUnit4ClassRunner should have a public constructor with signature AndroidJUnit4ClassRunner(Class testClass) E 4.322s list_tests(86TX00E9L) at org.junit.internal.builders.AnnotatedBuilder.buildRunner(AnnotatedBuilder.java:111) ... After: Change-Id: Ib6b304fbf675c205ca2d0e23bace17b81f2e18a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691081Reviewed-by:John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#676055}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4876cb21c82f..41300af8768c git log 4876cb21c82f..41300af8768c --date=short --no-merges --format='%ad %ae %s' 2019-07-10 danilchap@webrtc.org Poison default task queue factory 2019-07-10 jonasolsson@webrtc.org Remove the injectable bitrate allocation strategy API. 2019-07-10 julien.isorce@chromium.org Do not use hungarian notation for DwmGetWindowAttribute's params 2019-07-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 58be81bf..34d38f69 (675720:675873) 2019-07-09 sprang@webrtc.org Reland "Add ability to set RTCP sender ssrc at construction time" Created with: gclient setdep -r src/third_party/webrtc@41300af8768c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:978885,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I94e43ee31da802420fd09cff7e63276d74570f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695845Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676054}
-
Ben Kelly authored
When a service worker executes code like `evt.respondWith(fetch(r))` we should be able to directly pass the fetch's resulting mojo::DataPipe through without any data copying. This previously did not work, however, since the BufferingBytesConsumer would immediately start buffering the Response body data. This CL fixes this issue by delaying the start of the buffering by a short amount of time. This gives the service worker time to drain the pipe. The delay is currently disabled by default behind the "BufferingBytesConsumerDelay" feature. Based on yhirano's draft CL at crrev.com/c/1383755. Bug: 911036 Change-Id: I65675ce62a7ce593c8994b3e1258634840ba6c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679669 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#676053}
-
Piotr Bialecki authored
This CL adds files necessary to start consuming incognito mode APIs from ARCore. The .aar file mentioned by BUILD.gn is *not* yet uploaded to CIPD - that will happen once this CL gets all the required approvals. Change-Id: Ibc408f62aebba003522f381cda0fd526ea66559a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684493 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#676052}
-
Jenny Blessing authored
Bug: 970173 Change-Id: I93cf31b480675cedeeab8f2f2b8117a575a33274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692982Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Jenny Blessing <jblessing@google.com> Cr-Commit-Position: refs/heads/master@{#676051}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios/+log/179cd3396152..2801e6969bfd git log 179cd3396152..2801e6969bfd --date=short --no-merges --format='%ad %ae %s' 2019-07-10 andrewoverton@google.com Merge branch 'release-candidate' into stable Created with: gclient setdep -r src/ios/third_party/material_components_ios/src@2801e6969bfd The AutoRoll server is located here: https://autoroll.skia.org/r/material-components-ios-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:ios-internal-mdc TBR=bling-p10-rolls@google.com Change-Id: I8c8d9da08795bc825a2b6d3e87ab53ae2949b022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695843Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4e71b2bc2546..69e46a186bb7 git log 4e71b2bc2546..69e46a186bb7 --date=short --no-merges --format='%ad %ae %s' 2019-07-10 geofflang@chromium.org GL: Implement EGL_ANDROID_native_fence_sync Created with: gclient setdep -r src/third_party/angle@69e46a186bb7 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I53b084ead55e68a0bc24f7fd03fb48fac61210a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695844Reviewed-by:
-
Kristyn Hamasaki authored
Bug: 982469 Change-Id: I7370d32d01e52e93814771666cab5c3500d809ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693904 Commit-Queue: Kristyn Hamasaki <khamasaki@google.com> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#676048}
-
Yuke Liao authored
All of the coverage bots use non-component build, so it's better to make the Clang Tot coverage bots test the exact same build config. Change-Id: Ib4f3f09a31e1f8ac91d7cd46092b34ffc47ec7d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691095Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Auto-Submit: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#676047}
-
Anton Bikineev authored
Synchronization is required in CompleteSweep and PerformIdleLazySweep calls to ensure that no concurrent sweepers are in progress. Bug: 967258 Change-Id: I3fe74f03d5a94bc96fa7b37e18b251a6b7d6196e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692759 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#676046}
-
Sahel Sharify authored
Bug: 927793 Change-Id: I57ca3806130a93cc244a75fd0af2dfb6066039b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690394Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#676045}
-
Alex Gough authored
Change-Id: Id8958297186f7e004bd9d915001005b5a61c9548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693583 Auto-Submit: Alex Gough <ajgo@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#676044}
-
Jack Steinberg authored
BUG=972945 Change-Id: Iaa37efa03ee6de2c5a31d7bff533601348eb3e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685530 Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#676043}
-
Majid Valipour authored
Flow relative longhands have been added to overscroll-behavior specification [1]. This CL implements the relevant css parsing and matching tests. minor change: collapse all overscrollBehavior related case statements in parser fast path. intent-to-ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/V86fOkIaEQA/JydSaafqBwAJ [1] https://drafts.csswg.org/css-overscroll-behavior-1/#overscroll-behavior-longhands-logical TESTS: wpt/css/css-overscroll-behavior/ovescroll-behavior-logical.html, wpt/css/css-overscroll-behavior/parsing/* Bug: 833953 Change-Id: I5ceefa0afb1913472c0e134b2ec07405154abfae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614026Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Auto-Submit: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#676042}
-
Jordan Demeulenaere authored
Bug: b/133725664 Change-Id: Ie09b88fe2ef3b87f3611a2ba92e2f4196a36b69a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687410Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#676041}
-
Stephen McGruer authored
This CL switches raster from using the synchronous PaintWorklet path, to using the existing results from the asynchronous path that is driven by LayerTreeHostImpl. This allows us to avoid synchronously blocking on a thread-hop in raster, and simplifies the PaintWorklet flow on the compositor. Bug: 907897 Change-Id: I7e9090f936e9bc8f3e318931f4252b57bea33dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678382Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#676040}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8c4c9e37bf96..28ae0a4b2810 git log 8c4c9e37bf96..28ae0a4b2810 --date=short --no-merges --format='%ad %ae %s' 2019-07-10 bclayton@google.com Reactor: Add new 'EarlyCSEPass' optimization pass. 2019-07-10 bclayton@google.com Use Nucleus::adjustDefaultConfig for Vulkan's default reactor config. 2019-07-10 bclayton@google.com Reactor: Add support for specifying and modifying default configuration settings. Created with: gclient setdep -r src/third_party/swiftshader@28ae0a4b2810 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/135609394,chromium:b/137167988,chromium:b/137167988 TBR=swiftshader-team+autoroll@google.com Change-Id: Ieac85c92ed78b5e510b52ddd7f3753037ed14e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695723Reviewed-by:
-
Nicolás Peña Moreno authored
Bug: 879270 Change-Id: I7de3f75d2d27fd960b6e1fb6785f8269a56f1401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689785 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#676038}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/579543531e4b..be75ef60754c git log 579543531e4b..be75ef60754c --date=short --no-merges --format='%ad %ae %s' 2019-07-10 khokhlov@google.com Merge "Trace_processor: fix compile-time errors on bots" 2019-07-10 treehugger-gerrit@google.com Merge "Roll libunwindstack. Re-enable unwinding unittest." 2019-07-10 primiano@google.com Merge "CI: Periodically delete stale jobs" 2019-07-10 eseckler@google.com Merge "Make page size configurable when connecting a producer" 2019-07-10 khokhlov@google.com Merge "Trace processor: export args in json format" 2019-07-10 skyostil@google.com Merge "client api: Add StartBlocking/StopBlocking" 2019-07-10 taylori@google.com Merge "perfetto-ui: Fix gpu frequency track duplication" 2019-07-10 primiano@google.com CI: minimal update to the post-submit UI 2019-07-10 primiano@google.com Demote Travis CI and make the new CI the default Created with: gclient setdep -r src/third_party/perfetto@be75ef60754c The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:136726545,chromium:136726545 TBR=perfetto-bugs@google.com Change-Id: I6c2850ba42c586b53b125efb83ea90355f38d230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695725Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iab73f67cb4b7c9700ce824fddd88bb8e3706d2c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695841Reviewed-by:
-
arthursonzogni authored
There are two code paths for loading about:srcdoc: 1) browser-initiated: It happens during history navigations to about:srcdoc. This is the same code path used by every other "normal" navigation. 2) renderer-initiated: Used whenever the iframe.srcdoc attribute is set or modified. The new document is loaded without going through the browser process. The browser process receives DidCommitProvisionalLoad for a navigation is has never seen before. The two code paths are not necessary equivalent. The implementations can differ a bit and leads to bug. See https://crbug.com/949510. It is hard to test for both code path every time. All navigations should uses (1). This CL removes the about:srcdoc edge case (2). Bug: 936696 Change-Id: Ia14f4bf572af976356e8c21665dac70dd612f603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547522 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#676035}
-
Jared Saul authored
Also removes 5 tests that only have relevance as long as the checkbox exists (which it no longer does) Bug: 941664 Change-Id: If61fb91ed2c9b8b8d2e15f2d60733f4195845b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682429Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Anne Lim <annelim@google.com> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#676034}
-
Lan Wei authored
MouseEventManager::RecomputeMouseHoverState may change the hover dirty flag because it sends mouse boundary events such as mouseover, mouseout, mouseenter and mouseleave, which may change the layout. We need to reset |hover_state_dirty_| before we call RecomputeMouseHoverState, so that we make sure that the hover is updated for all the layout change. Bug: 877132 Change-Id: Id6ec90e8f6ced06a68dffa1a31cd34b92294af37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689959 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#676033}
-
Rouslan Solomakhin authored
Before this patch, 41 error strings were auto-generated for Java, but only 14 of them were used on Android. This patch separates the strings that are used only from native C++ code into their own native_error_strings.h/cc files, which are not auto-generated into ErrorStrings.java. After this patch, only the 14 error strings referenced from Java are generated into ErrorStrings.java. Bug: 977145 Change-Id: Id3652179c124ba1742b52aa2beaaca3d499d5d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692113Reviewed-by:
-
Jan Wilken Dörrie authored
This change implements TouchToFillController::Show() and hooks it up with AutofillPopupController::OnSuggestionAccepted(). In particular, TouchToFillController::Show() will construct a AccessorySheet from the passed in autofill suggestions, ignoring suggestions that do not directly correspond to usernames and passwords. TBR=ftirelo@chromium.org Bug: 957532 Change-Id: I6c27d9841bd173ae59f81ea92f019703f050eb80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674158 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#676031}
-
Clemens Arbesser authored
Bug: b/133725664 Change-Id: Ifc03bfc11dec8f6cc24456a4fca71b89d8471acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687398 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#676030}
-
Hector Carmona authored
Tests that were disabled: WebRtcAudioBrowserTest.CanMakeVideoCallAndThenRenegotiateToAudio WebRtcAudioBrowserTest.EnsureLocalVideoMuteDoesntMuteAudio WebRtcAudioBrowserTest.EnsureRemoteVideoMuteDoesntMuteAudio WebRtcAudioBrowserTest.EstablishAudioOnlyCallAndEnsureAudioIsPlaying WebRtcAudioBrowserTest.EstablishAudioVideoCallAndEnsureAudioIsPlaying WebRtcAudioBrowserTest.EstablishAudioVideoCallAndVerifyUnmutingWorks WebRtcAudioBrowserTest.EstablishIsac16KCallAndEnsureAudioIsPlaying Bug: 982421 Change-Id: Idfc98ac075aa33436e4d2a8db47b62049162648f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694242Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#676029}
-
Javier Ernesto Flores Robles authored
Bug: 974255 Change-Id: I8da5bed54634cefe5df41f22fa6abdc9a0916094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695365Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#676028}
-
Ruslan Burakov authored
Modify Size method so it accounts only for whitelisted stats in RTCStatsReport. This is not an issue currently but may become one once if more unwhitelisted stats are added. Bug: 908072 Change-Id: Ie9ec6bd815b8d8c5556b36b1c96bae247bb52e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692180 Commit-Queue: Ruslan Burakov <kuddai@google.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#676027}
-
Andrew Grieve authored
Script can be used with .csv files downloaded from telemetry in order to identify commits that grew/shrank by significant amounts. Change-Id: I719b4edf06a1982890b1410b5211b79cf35e710e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694095Reviewed-by:
-
Sylvain Defresne authored
Change the sign-in workflow on iOS to 1. load all accounts from the SSO library, 2. set the primary account. With this change, semantic of sign-in is similar between iOS and desktop as the account infos are available when PrimaryAccountMutator::SetPrimaryAccount() is called. This required removing the DCHECK in ReloadAccountsFromSystem() as the primary account is not set when invoked as part of the sign-in. This is safe as all the caller of ReloadAccountsFromSystem() either correspond to sign-in workflow or check that the primary account is set before calling the method. With https://crrev.com/c/1687254, the hosted_domain that has been fetched before invoking AuthenticationService::SignIn() is returned by DeviceAccountsProvider. Thus CHECK that the primary account has the expected value after calling LegacyReloadAccountsFromSystem(). Bug: 926940 Change-Id: I98e4a02b6b077c41d8f51e19a5536d4661d9396f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667346 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#676025}
-
Alexei Svitkine authored
Removes some metrics that are not needed and also revamps Variations.SeedStore metrics to log the two things we really care about: - Breakdown of payload types - Total size The detailed ratio metrics are not really needed. These can be computed server-side when issuing the response if needed. Other updates: - Ensures at least two owners set on all current Variations.* histograms. - Sets expiry to M90 for variations histograms without expiry and those expiring in M77 that should be kept. Bug: 975515, 975466, 975546, 975655, 975694 Change-Id: I35c38cce390c4bdf05b2459e272ac1df32448703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692763Reviewed-by:
-
