- 05 Sep, 2019 40 commits
-
-
Maksim Moskvitin authored
USS implementation of Nigori isn't compatible with Directory implementations of other datatypes, because Directory requires USS unfriendly logic for reencryption. This change should allow passing Directory-specific integration tests, while USS implementation of Nigori is enabled and prevent browser misbehaviour for users, who plays with experimental flags. Bug: 922900 Change-Id: I4dd4e5251d2496b5221afb5ee7f8f38112e078f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784604 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#693922}
-
Sammie Quon authored
- Do not update scroll if the delta is too small, this matches what drags on overview items do. - Pause occlusion tracker on scroll. - When scrolling, do not call SetBounds unless the item is leaving or entering the view of the grid. Tested locally with OverviewScrollTest.Basic. Not the greatest gains when only 12 windows, but scales much better with larger number of windows. Presentation time: Before 12 windows: 55ms Before 42 windows: 180ms After 12 windows: 53ms After 42 windows: 88ms Also renamed a overview_grid_pre_event_handler -> overview_grid_event_handler as it handles regular events now. Test: manual Bug: 978112, 993615 Change-Id: I28bcbb8ce3291f975df9f1033961fbe176052fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784349 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#693921}
-
John Budorick authored
Tbr: martiniss@chromium.org,sque@chromium.org Bug: 1001231,950413 Change-Id: Ic49b1ca112bc81e444aa5fe8c8787f9ab28c2616 No-Try: true No-Presubmit: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786872Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#693920}
-
Ted Choc authored
This allows the code to distinguish a tab created on startup from tab created FROM_CHROME_UI. We animate tabs created that use FROM_CHROME_UI, but we do not want to do that for tabs created on startup. The aim is that this will fix the flakiness of the MainIntentBehaviorMetrics. BUG=980587 Change-Id: Id00df9944c30a2b7b120ecb29b268af8ea3618c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786672Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#693919}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /mojo. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=sky@chromium.org Bug: 891670 Change-Id: If1ba8688539709b8e28ce009e3483a1aac36fc4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786977 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#693918}
-
rbpotter authored
- Autogenerate Polymer 3 version of cr-search-field and its automated tests - Add to Polymer 3 demo page Bug: 965770 Change-Id: I6901db78e71767f757642aa89dae43be4473dd33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786177Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#693917}
-
Ryan Sturm authored
Currently, we are using 0-based indexing for anchor metrics, but 1-based indexing for click metrics. This is addressable in UKM queries right now, but a better long term fix is to match the metrics on the client. Change-Id: I1c615971af7cd4f05c37c384d25673cc9efa09ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788217 Auto-Submit: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#693916}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /base. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=thestig@chromium.org Bug: 891670 Change-Id: I42c94d5ab362b96a3cd427d3a5f0341ba10e6ae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786961 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#693915}
-
Sharon Yang authored
* Add the AccessibilityBridge class skeleton, which will eventually handle the logic for conversion between Chromium and Fuchsia accessibility data structures. * Register a ViewRef to the Fuchsia SemanticsManager. Test: Added AccessibilityBridgeUnitTest.* Bug: 973095 Change-Id: Ie8eb6a8cdd68e0082d3479b9b1288f8aaa68a600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708043 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#693914}
-
Tim Song authored
Currently, ARC pop-ups stay around forever because the dismiss timer is paused when hovering on the notification, but mouse exit events are not properly dispatched to the widget, so the timer is never restarted. TEST=manual BUG=995567 Change-Id: Id2892fda60f2c170abddf5c812e23150c61c3d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783701Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#693913}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/feature_engagement. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=dtrainor@chromium.org Bug: 891670 Change-Id: If11be97315fc4857d0e04f8c18ef4d901b543ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787207 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
chrome://tab-stripCollin Baker authored
This connects the WebUI at chrome://tab-strip to the ThumbnailImage infrastructure through an intermediate class ThumbnailTracker. Bug: 991393 Change-Id: I7a730dea9f90db420c32b7cc4871b0608f447c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758920 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#693911}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/history. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=sky@chromium.org Bug: 891670 Change-Id: Idebd69dabf7ccb6a2d9b58575620cb10f265398e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787239 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Manu Cornet authored
The test starts dragging an app out of the main shelf, drags it into the overflow shelf, and while the drag is still in progress, takes a screenshot. This is part of trying to reproduce the linked bug and add test coverage. This test passes, so I'll need to look into what other conditions are required, or maybe this bug doesn't happen any longer. Regardless, it doesn't hurt to have this test. Bug: 997612 Change-Id: I5bbaca6add0c13fa9df6fa04ede43d1b8519c10e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785679Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#693909}
-
Staphany Park authored
Bug: 1000932 Change-Id: I1c5286092a79e9a5014c77d3a3ba0526280add0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786923 Commit-Queue: Staphany Park <staphany@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Auto-Submit: Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#693908}
-
Brian Sheedy authored
Switches the perf tests in gpu_perftests to use PerfResultReporter instead of PrintResult and whitelists the target for conversion to histograms before uploading to the perf dashboard. Bug: 923564 Change-Id: I1af7b843c71e66205f05955c230a6ae3013f8ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785677Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#693907}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/76500e5d0a62..6d1c0d4196f1 git log 76500e5d0a62..6d1c0d4196f1 --date=short --no-merges --format='%ad %ae %s' 2019-09-05 michaelludwig@google.com Avoid use of SkMatrixImageFilter to handle CTM for backdrop filtering 2019-09-05 csmartdalton@google.com Rename GrGLIRect to GrNativeRect Created with: gclient setdep -r src/third_party/skia@6d1c0d4196f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@google.com Bug: None Change-Id: I26af2651e1f91914a6cf035eb4876a1d11686471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787852Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693906}
-
Ted Meyer authored
Previously, we checked only the finch flag for swap chain support, in order to turn off resource sharing. This was intended to avoid a bug on intel platforms. This CL replaces the finch check with a more robust one, to match what dxva does. Bug: 998901 Change-Id: I377e8e01169c927dd4431e8f22729d0d9c3fa7e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775264Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Auto-Submit: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#693905}
-
Eric Roman authored
This mostly affects consumers of SimpleURLLoader, which would previously see ERR_FAILED and now see ERR_HTTP_RESPONSE_CODE_FAILURE. This error winds up in logs and UMA histograms. The new error code is more understandable than ERR_FAILED which encompasses a variety of other errors. TBR: parastoog@google.com,dimich@chromium.org,seantopping@chromium.org Change-Id: I69878cee31c6063fc1b2d0fb2723d9017d55db3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766621 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#693904}
-
Jimmy Gong authored
- This bug occurs when there are saved printers and the users inputs a search term. This resulted in an unintended "no search found" message. - A future CL will update the no search found message accordingly to saved printers and nearby printers. Bug: 997116 Test: end to end manual Change-Id: Ic008af47aeac0f401c81f8a6cd1ea99834e49e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769217 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#693903}
-
Manas Verma authored
Creating a new endpoint for CreditCardFIDOAuthenticator that directly returns a boolean for whether or not a user has a platform authenticator. This is intended to be used on settings page load. Bug: 949269 Change-Id: Ifbe6ae377ae5a640d5af0a01157aacee728c5e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764184Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#693902}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chrome/test/chromedriver. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=crouleau@chromium.org Bug: 891670 Change-Id: I0fddfbb329cafecad414c46b39f0d34ff0e88122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786979 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#693901}
-
Aran Gilman authored
Bug: 982354 Change-Id: I2dd337472ee4c65b5cd39a0dfc3a166b84e3dd7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774308 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#693900}
-
Eugene But authored
This key will allow to split crash signature for UIFreeze crashes. Bug: 1000861 Change-Id: Ia9e0fcd14096c5d15630a777137f4b3dd07f1bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764903 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#693899}
-
David Bienvenu authored
This reverts commit 4105186f. Reason for revert: <crbug.com/999467> Original change's description: > Migrate pinned icons in ImplicitApp subdirs. > > Chrome migrates pinned icons in UserPinned/Taskbar dir, but not the > subdirectories of UserPinned/ImplicitAppShortcuts. It's unclear to me why > Windows puts some pinned icons in the ImplicitAppShortcuts subdirectories, > but we should handle them. > > Bug: 980239 > Change-Id: Ia41c3853b2a4bb78781a39733f388915f58c02eb > TBR: > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710722 > Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681035} TBR=msarda@chromium.org,grt@chromium.org,davidbienvenu@chromium.org Bug: 980239 Change-Id: I2b19e825ccd0f1bd2975678d9acb1ad7ff90cc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787560Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#693898}
-
Miyoung Shin authored
This CL converts UkmRecorderInterface{Ptr, Request} in services, blink and content to the new Mojo types. Bug: 955171, 978694 Change-Id: Icb32c106509d909113c522f1ed363460ac5f6179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787023 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#693897}
-
John Chen authored
Remove reference to field trial SiteIsolationExtensions/Control, no longer exists. However, have to keep force-fieldtrials switch due to https://crbug.com/996865. Change-Id: If6b644d0cb6d6c6e860a1be22b33a37ec6a3b4ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787989 Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by:
Rohan Pavone <rohpavone@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#693896}
-
Staphany Park authored
Bug: 1000932 Change-Id: Iec2b4ffc50d8688b3727da7d4cfb8a4a1b22c63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787340 Commit-Queue: Staphany Park <staphany@chromium.org> Auto-Submit: Staphany Park <staphany@chromium.org> Reviewed-by:
-
Ella Ge authored
This CL makes the pointer lock request also pass the PointerLockOption.unadjustedMovement (added in crrev.com/c/1764943) to browser with the pointerlock request IPC. It stores the boolean mouse_lock_raw_movement_ in RWHI whenever receive the OnLockMouse IPC, and use on GotResponseToLockMouseRequest. Storing the value because passing the boolean to RequestToLockMouse will get into too many code path. RWHI.GotResponseToLockMouseRequest() is the only caller to RWHV.LockMouse(), and RWHV.LockMouse is the only place that locks mouse. Bug: 982379 Change-Id: Ia930960bb3c16e249e26e154430c62a9bf06b8eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767098 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#693894}
-
yilkal authored
This CL hides virtual keyboard when parent access widget is being shown. It achieves this by doing the following: 1. Hide virtual keyboard when parent access widget is shown. 2. Prevent views::Textfield from calling views::Textfield:: ShowVirtualKeyboardIfEnabled() by making changes in ParentAccessView::AccessCodeInput and AccessibleInputField. Bug: 938705 Change-Id: I5199a8a6290e2cf47602b0ef130b4aa5c05b7ad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784337Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#693893}
-
Miyoung Shin authored
This CL converts PreviewsResourceLoadingHintsReceiver{AssociatedPtr, Ptr, AssociatedRequest, Request} in content to the new Mojo types. Bug: 955171, 978694 Change-Id: I9a2634259b9a737d775922bd0c8202914ea171e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783686 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#693892}
-
Dave Tapuska authored
value is usually defined as a variable on the json class so it causes a shadowed variable. Rename the variable on the stack to to_value_result this name is unique enough it doesn't cause shadowed variables. BUG=794619 Change-Id: I43bb753d1fdec6871386881641a3d59ab010d475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786582Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#693891}
-
Weiliang Chen authored
Add implementation to SharedImageRepresentationFactory to actually call into the SharedImageManager to produce overlay representation. R=rjkroege Bug: 979795 Change-Id: I43ab5fc2d9c9b8db1e90b24cfe33edbd10381c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786300Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#693890}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ui/gfx. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=msw@chromium.org Bug: 891670 Change-Id: Icf52c4d2d4b586cdec910c16988661fb2f2a0058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787240 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#693889}
-
Ahmed Fakhry authored
This CL fixes the overlap between the desks bar, and the splitview drag indicators when in portrait tablet mode. The desks bar is now shifted down when necessary to make room for the indicators. BUG=998239 TEST=Manually, Added new tests. Change-Id: Ic890a8d344a93551c617cb3f2212f19f869ab611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787158 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
ckitagawa authored
AFAICT this behavior was only necessary due to the upstream print caller not setting flags correctly. The upstream print code now uses the correct flags so modifying the GlobalPaintFlags in FramePainter is no longer required. Also manually tested printing on Linux Desktop. Bug: 510280 Change-Id: I4400b361fe5c389a60f0d758555360ca14b52a2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783357 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#693887}
-
Alison Maher authored
Video controls were broken in forced colors mode because default_forced_color_style_ was not set in the case of media conrols. Bug: 970285 Change-Id: I9e05335a893dbf8856c3093bcafa5d76beef268d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778651Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#693886}
-
Xiaocheng Hu authored
This reverts commit 0a8524d2. Reason for revert: Reverting CHECKs back to DCHECKs in the next version Original change's description: > Verify if crbug.com/996037 has been fixed > > This patch turns a DCHECK into CHECK to verify if the DCHECK is still > hit on production builds. > > This patch will be landed into version 3903, and will be reverted in > the next version. > > Bug: 996037 > Change-Id: Ice5237e9a0761b991425b1dbe402350a6ddd9b86 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784161 > Reviewed-by: Emil A Eklund <eae@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#693371} TBR=eae@chromium.org,xiaochengh@chromium.org,srinivassista@chromium.org Change-Id: I46ca89b68b901d0d86cc03a61ea851e2bdc8fdae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 996037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787031Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#693885}
-
Robert Liao authored
This allows subclasses of TypographyProvider to delegate to DefaultTypographyProvider for styles already provided by the TypographyProvider. BUG=865318 Change-Id: Id2a8d8a6e08157198c98920c4ed9438170baec5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779536Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#693884}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b6f7d201f629..e2f7ff015b5e Created with: gclient setdep -r src-internal@e2f7ff015b5e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I1b168f18fb5a49c48cd1c589ad17744d654c1aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787853Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693883}
-
