GitLab

These tests fail when Schemeful Same-Site is active due to them
using an HTTP top-level with HTTPS subresources.
Because none of the tests appear to require an insecure top-level site
to test their assumptions, change them to use HTTPS instead which
avoids the issue.

Bug: 1127348
Change-Id: Ic3d7f7c87b683ab4506203e679a6bb6ba3d0e1f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404805Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Steven Bingler <bingler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806643}

Adds a per-scene incognito blocker. Removes the old blocker.
The new blocker is implemented as a scene agent that monitors the scene
for state changes and checks a new SceneState flag
|incognitoContentVisible| that was previously owned by SceneController.
Removes old tests and adds new ones.
Uses window ordering by windowLevel instead of keyWindow, which is
actually possible even before scene startup.

especially with full-screen video in an incognito tab.

Fixed: 1125969
Test: on iOS 12, 13, 14 devices test that the incognito blocker works,
Change-Id: I3192908c61fecc7d548383dab4d068a05f4c3ef3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404855
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806642}

This reverts commit 8668ae66.

Reason for revert: Fixing build error on Android builder starting on https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/221587.

!!!! Skipping CQ because Android build on perf waterfall has been failing for 2 days.

Original change's description:
> Revert "Roll src-internal from 4bb03bb4b22d to 44c9ca6a2c0e (1 revision)"
> 
> This reverts commit 608a0e43.
> 
> Reason for revert: Android builders on perf waterfall start failing since https://chromium-review.googlesource.com/c/chromium/src/+/2404674. Reverting the CLs after that.
> 
> Original change's description:
> > Roll src-internal from 4bb03bb4b22d to 44c9ca6a2c0e (1 revision)
> > 
> > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4bb03bb4b22d..44c9ca6a2c0e
> > 
> > If this roll has caused a breakage, revert this CL and stop the roller
> > using the controls here:
> > https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
> > Please CC orphis@google.com on the revert to ensure that a human
> > is aware of the problem.
> > 
> > To report a problem with the AutoRoller itself, please file a bug:
> > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
> > 
> > Documentation for the AutoRoller is here:
> > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
> > 
> > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
> > Bug: chromium:1040645
> > Tbr: orphis@google.com
> > Change-Id: I586d0a124bb943405b379d527767540d5730141e
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405975
> > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
> > Cr-Commit-Position: refs/heads/master@{#806112}
> 
> TBR=orphis@google.com,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com
> 
> Change-Id: I55721462acc6cdeb5da2584ae493d1e119072c3c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1040645
> Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406521
> Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
> Auto-Submit: Wenbin Zhang <wenbinzhang@google.com>
> Cr-Commit-Position: refs/heads/master@{#806329}

TBR=orphis@google.com,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com,wenbinzhang@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:1040645
Change-Id: I00393b7a94df4eae2c5e31ee5f74979785deaf41
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410438Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#806641}

This test still fails on Fuchsia, but this should produce better errors.

Bug: 1127298
Change-Id: I9c6d18ad1ce863814628d052031b932c53fb9ec2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408399Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tamir Duberstein <tamird@google.com>
Cr-Commit-Position: refs/heads/master@{#806640}

This reverts commit 407e6843.

Reason for revert: Fixing build error on Android builder starting on https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/221587.

Original change's description:
> Revert "Roll src-internal from 7214110d995d to 4bb03bb4b22d (2 revisions)"
> 
> This reverts commit c8b2d7b0.
> 
> Reason for revert: Android builders on perf waterfall started failing from this CL.
> 
> Original change's description:
> > Roll src-internal from 7214110d995d to 4bb03bb4b22d (2 revisions)
> > 
> > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7214110d995d..4bb03bb4b22d
> > 
> > If this roll has caused a breakage, revert this CL and stop the roller
> > using the controls here:
> > https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
> > Please CC rakina@google.com on the revert to ensure that a human
> > is aware of the problem.
> > 
> > To report a problem with the AutoRoller itself, please file a bug:
> > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
> > 
> > Documentation for the AutoRoller is here:
> > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
> > 
> > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
> > Bug: chromium:816629
> > Tbr: rakina@google.com
> > Change-Id: I39fc271d42e249d7084a884043433b66ee355278
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404674
> > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
> > Cr-Commit-Position: refs/heads/master@{#806087}
> 
> TBR=rakina@google.com,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com
> 
> Change-Id: Icb635758b167278d7bf04255d693f1de619d3f84
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:816629
> Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405946
> Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
> Auto-Submit: Wenbin Zhang <wenbinzhang@google.com>
> Cr-Commit-Position: refs/heads/master@{#806332}

TBR=chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com,wenbinzhang@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:816629
Change-Id: Ia641881803779597e9a66721e0182901a206a1c6
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410418Reviewed-by: Wenbin Zhang <wenbinzhang@google.com>
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#806639}

Change:
* For close() and closeUIAndDestroyNativeObjects() called together,
remove closeUIAndDestroyNativeObjects() because close() already has it.
* Move PR UI (non-minimal UI)'s complete handling (#onComplete in
particular) out of closeUIAndDestroyNativeObjects(), because
#onComplete is supposed to be called only in response to PR#complete().

Bug: 1102522

Change-Id: I68c1e7027219790f105fe5c46deee2168a2a674a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404397
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806638}

TBR=govind@chromium.org

Change-Id: Icfd2199eddc1966d0cd88cdfb129e62686521e9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408886Reviewed-by: Ben Mason <benmason@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806637}

https://crrev.com/c/2315695 added `is_apple` variable defined as
`is_ios || is_mac` and converted usages of this pattern, but the
conversion missed the negative form.

Convert `!is_ios && !is_mac` to `!is_apple` as a followup.

Bug: 1105907
Change-Id: Iae063a2cbb89a7d545958b5bbeebac48bac9ec0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410021
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806636}

This change replaces existing usages of std::{all,any,none}_of in
password manager and autofill code with their base::ranges equivalents.

Change-Id: If2ff0b71f00bdced18d0354baa5bafdf49eb2452
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404347Reviewed-by: Vadym Doroshenko  <dvadym@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806635}

Change-Id: I6a9c8debc188d8bdde097cc2515a25eef6992dc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405415
Commit-Queue: Alexander Surkov <asurkov@igalia.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806634}

This CL adds the ability to override the target language used by the
translate feature on a per-Tab basis. This is analogous to the
functionality of CCT's TRANSLATE_LANGUAGE intent extra. Once the
override is set, all translate infobars in the given Tab will appear
with the specified language as the target language. Calling
Tab#setTranslateTargetLanguage() with an empty string clears the
override and causes behavior to revert to normal.

Note that even with the override set the translate infobar will not
appear for pages that are in the user's locale. This is internal
behavior of Chromium's translate component and is common to CCT and
WebLayer.

I marked the added method as since 86 as this CL will be targeted for
cherrypicking to 86.

Bug: 1116394
Change-Id: Ic4f08c16a64a3f0ceebed5feab7cdc9401001279
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397716Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806633}

Now that it's deprecated in v8.

Bug: 1114823
Change-Id: Id184f3c100a1b5d02e9ce31e3164de71eefd94d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405569Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806632}

Change-Id: I0f72337a6007260044e443ef2b4e4a90a0947b6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395737Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Clovis PJ <clovispj@google.com>
Cr-Commit-Position: refs/heads/master@{#806631}

Weblayer resize may be caused by client in which case keeping the page
interactive is more important than showing gutters. This CL adds a
heuristic to detect surface resize due to a rotation. Then add plumbing
for a surface resize to supply a deadline override, and override the
deadline to 0 for non-rotation resizes.

There are two resize heuristics:

If activity is recreated, we already have code to detect this case in
BrowserImpl, and just pass it into ContentViewRenderView when it's
recreated.

If activity handles rotation, it's detected by the
DisplayAndroidObserver which appears to always happens before the
resize.

This CL does not change non-weblayer products.

Bug: 1126706
Change-Id: Iac6cd90f159765fc8a56a9a766130851bd6177b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402289
Auto-Submit: Bo <boliu@chromium.org>
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806630}

Bug: None
Change-Id: Id47626c66cd4f1f2ac37cea3c273eebb303b5bfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403880Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806629}

As part of
https://chromium-review.googlesource.com/c/chromium/src/+/2225548
I removed an override of onScrollOffsetOrExtentChanged. It turns out
the code was relying on this to be called when the scale factor
changed so that the zoom-controls could be updated.

The fix is to update the zoom-controls when the scale factor
changes.

BUG=1116921
TEST=see bug

Change-Id: Iea87c23e9ea0e6b5934ee568f668388dde489ed6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405645Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806628}

This reverts commit 0f8373b2.

Reason for revert: The cause of the regression is:
https://chromium-review.googlesource.com/c/chromium/src/+/2385929

The test was working correctly, it detected regressions.

Original change's description:
> sheriff: Disable AwContentsTest#testCreateLoadDestroyManyAtOnce
> 
> The test causes webview to crash. It has to be disable until the cause
> off the crash is found.
> 
> TBR=timvolodine@chromium.org
> 
> Bug: 1073077
> Change-Id: I66fb484ad23d33754b5ab841abd4826d3a289b07
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409977
> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#806609}

TBR=timvolodine@chromium.org,arthursonzogni@chromium.org

Change-Id: If94228d7e8cd44da735a16385a83f78659590ef4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1073077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409961Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806627}

Roll Chrome Linux PGO profile from chrome-linux-master-1600062449-3179a4da9bad3e513a066b6120519028fcbec2a4.profdata to chrome-linux-master-1600084447-654ce493c2d2b8d13e6243ff3cb852a603e3ef72.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com
Change-Id: I975e40916af0ccad4f64920ba824ccb679437907
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410013Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806626}

Clear CoopAccessMonitor when their reporter are gone. This avoids
accumulating them.
Similarly, because we don't have RenderDocument, the accessing
LocalFrame might host new documents. A new CoopAccessMonitor will be
sent after the commit. The new one must
replace the old one. This will allow the new set or reported URLs to be
reported.

This is a positive change, but still not perfect at all. Ideally, the
CoopAccessMonitor(s) passed into process of the new Document should be
passed along the CommitNavigation IPC.

Bug: 1090273
Change-Id: Ib444e760175207702867f47012fa05bd5e051576
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408752Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806625}

This patch fixes the following points.
- Use info.Holder() instead of info.This() because the callbacks
  must take v8::PropertyCallbackInfo in case of exposed constructs.
- Use V8DOMConfiguration::kReplaceWithDataProperty so that the
  exposed interface objects are cached.

Bug: 1127756
Change-Id: I8da221eaa4d0888658fd9fc6cddccd111114a2d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409732Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806624}

Change Log:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/3c8b5d7587..6af91b3510
Full diff:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/3c8b5d7587..6af91b3510

No changes required to .def files.

Bug: None
Change-Id: Ieb71bd9b716a1d2644e554566766ab83a39871f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408753Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Danil Chapovalov <danilchap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806623}

If a navigation entry is marked as skippable once then it should retain
that flag until user activation even if that entry is reused (due to
back/forward navigations). This is a fix for the intervention
workaround where the following happens without the fix:
1. The initial navigation entries are:
a, b1(skip), b2*
b1 is marked skippable since b2 was added without user activation

2. Once on b2, it immediately calls history.back(). The back() causes a
navigation to b1 which resets its skippable flag to false (This was
being done for all navigations).
a, b1*, b2

3. history.forward() is then immediately called, but b1 doesn't get
marked as skippable because there is no skippable marking logic in
navigating to existing entries. It is also tricky to set because
is_renderer_initiated is not set for history navigations.
a, b1, b2*

4. Now, whenever user presses the back button, it goes to b1 and the
onpopstate handler calls history.forward() to land it on b2, thus making
the user stuck in a loop on b2.

The fix removes the resetting of skippable flag being done in step (2).
This will not cause any issue because if the page gets a user activation
it will be reset anyways.


The reset logic was introduced in the initial CL for the history
intervention:
https://chromium-review.googlesource.com/c/chromium/src/+/1344199
But after that
https://chromium-review.googlesource.com/c/chromium/src/+/1499834 added
the change to reset skippable on user gesture, making the former
redundant.

Bug: 1121293
Change-Id: I291b29d7e4c2adf855c12dc2159f44b9a68af5a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391654Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806622}

Ran `./tools/clang/scripts/upload_revision.py f086e85eea94a51eb42115496ac5d24f07bc8791`.

Bug: 1126953
Change-Id: I5448a7bb6b4a17a8e45da1ab51f53f8dd0122830
Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel
Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel
Cq-Include-Trybots: chromium/try:linux-chromeos-dbg
Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng
Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng
Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng
Cq-Include-Trybots: chromium/try:mac-arm64-rel,mac_chromium_asan_rel_ng
Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64
Cq-Include-Trybots: chromium/try:win-asan,win7-rel,win-angle-deqp-rel-32
Cq-Include-Trybots: chrome/try:iphone-device,ipad-device
Cq-Include-Trybots: chrome/try:linux-chromeos-chrome
Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407433Reviewed-by: Hans Wennborg <hans@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806621}

Added generated preference for the notification content setting
and quieter UI preference.

Bug: 1113642
Change-Id: Ifda4dffc809f5bdcf33ac06b22c8ca2ab54d15df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334953Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com>
Reviewed-by: Sean Harrison <harrisonsean@chromium.org>
Commit-Queue: Tymofii Chudakov <tchudakov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806620}

This CL re-enables `testCredentialsChangedByModel` as the problem is
fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2405581

Bug: 1127200, 1127433
Change-Id: I058480287e78b378de023dfe4ca066a944ad26ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408756Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Reda Tawfik <redatawfik@google.com>
Cr-Commit-Position: refs/heads/master@{#806619}

Now the ABNF based checks are fully enabled on the stable.
This is the clean-up change to remove a feature flag.

Bug: 1114019
Change-Id: Id8fde776ed7ae5e6fa0d4d1afc55e20695bfabf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387461
Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806618}

Bug: 1024092
Change-Id: If4adc02e604805b8cf9f312d0c7c931fa0126fa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404934Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806617}

The new page info UI should not show a details string if the connection
is secure. The information will be shown in a subpage instead.

Bug: 1077766
Change-Id: Iee7ef8041ff056d5274f24f5f14901146ba2b754
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400500Reviewed-by: Ehimare Okoyomon <eokoyomon@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806616}

Following https://crrev.com/c/2404988, this patch cleans up
named properties' setter implementation.  While the patch
2404988 focused on fixing the issue in M86, this patch is
focusing on a cleaner long-term fix including refactoring.

Bug: 839389, 1126888
Change-Id: Ieae456e342a4fa9b3ac1149210c39c87d81dfca9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404280
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806615}

Bug: 1116418
Change-Id: If435e43ced3287398982aa2bc9719bc5498a40ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401162
Commit-Queue: Yifan Luo <lyf@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806614}

The SignOut operation with Chrome data clearing does not have the
proper conditionals in place to ensure that a subsequent operation
cannot occur while sign-out is in progress.

We suspect this causes a crash on sign-out / sign-in to switch accounts
since the navigation controller that AccountsTableViewController
attempts to perform an operation on may no longer exist.

https://crash.corp.google.com/browse?q=product_name%3D%27Chrome_iOS%27+AND+expanded_custom_data.ChromeCrashProto.channel%3D%27%27+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BHang%5Dweb%3A%3AWebSubThread%3A%3AIOThreadRun%27+AND+%28EXISTS+%28SELECT+1+FROM+UNNEST%28productdata%29+WHERE+key%3D%27breadcrumbs0%27%29+OR+EXISTS+%28SELECT+1+FROM+UNNEST%28productdata%29+WHERE+key%3D%27breadcrumbs%27%29%29&stbtiq=&reportid=&index=0

Bug: 1108310
Change-Id: I66d1852d1071d7acea243005bfabc7797af14dd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408754Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806613}

Updates the color picker border color to Google grey 700.

Bug: 1108289
Change-Id: I596bfa0c914c57fb6807d0e0b76bf8cbbb7a541a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409435
Auto-Submit: Alex Ilin <alexilin@chromium.org>
Reviewed-by: Monica Basta <msalama@chromium.org>
Commit-Queue: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806612}

Replace register and unregister with onAttached and onDetached methods
in SyncPromoPreference

Bug: 1109713
Change-Id: I1bf58fc31e74798a614afdb57179726545ed249d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401522Reviewed-by: Alice Wang <aliceywang@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806611}

The class is called PlatformSensor, not Sensor. No functional changes.

TBR=reillyg

Change-Id: I6cffc3b41190a34aab8fa0b56d79d101851f0c8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409281Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#806610}

The test causes webview to crash. It has to be disable until the cause
off the crash is found.

TBR=timvolodine@chromium.org

Bug: 1073077
Change-Id: I66fb484ad23d33754b5ab841abd4826d3a289b07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409977
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806609}

This is a reland of 45e983ef

Original change's description:
> [Nearby] Use common default device name creation for Windows
> 
> We previously handled default device name creation for Windows
> differently than we did for other non-Chrome OS platforms. The
> underlying reason appears to be that the Nearby Share service unit tests
> were using base::RunLoop().RunUntilIdle() instead of
> task_environment_.RunUntilIdle(). Because the hardware info fetch takes
> longer on Windows than other platforms, I suspect that was the reason
> only Windows was having issues. The correct run loop behavior was fixed
> in a previous CL.
> 
> Fixed: 1127603
> Change-Id: I1f10027696fb47d30ccfe0aa7b2ceb7c85de1393
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407856
> Auto-Submit: Josh Nohle <nohle@chromium.org>
> Commit-Queue: James Vecore <vecore@google.com>
> Reviewed-by: James Vecore <vecore@google.com>
> Cr-Commit-Position: refs/heads/master@{#806466}

Change-Id: I67038737e9d80c557e12fde6dbc567b06c6abe20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408214
Auto-Submit: Josh Nohle <nohle@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806608}

The test was failing with the following error:
```
../../content/browser/back_forward_cache_browsertest.cc:5429: Failure
Expected: (0.01) > (duration2 - duration1), actual: 0.01 vs 0.011018
```

TBR=altimin@chromium.org,hajimehoshi@chromium.org

BUG=1127833

Fixed: 1127833
Change-Id: Ic0a5c531ab1b9aaa6e9ddac0b009b9add5c72966
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409898Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806607}

This currently asserts the erroneous behavior documented in crbug.com/1124346.
It will serve as proof that the bug is indeed fixed once the code under test is
amended.

Bug: chromium:1124346
Change-Id: Ic8cf6d0ac81e8ae1732981c5a020a6499ad5da47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395779Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Auto-Submit: Titouan Rigoudy <titouan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806606}

SignInPreference class shows the signin promo when there is no primary
syncing account present in chrome. Because the user can now be in
signed in state this can show sync promos and signin promos at the same
time.
SigninInPreference class should instead check for if there is signed in
account in chrome.

Bug: 1126008
Change-Id: I45cd4a80b1206171d1634346865502fc1c94c1cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398542
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806605}

Roll Chrome Win32 PGO profile from chrome-win32-master-1600019602-32c2a84e23bf8e92bb08ca2c2b541f0b03d0321b.profdata to chrome-win32-master-1600062449-2fe327552dcb0c48f221a41ff1f1e25d4acb9926.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: I233bcc6044b31c1a97eb5fc7c9132b13923403b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409377Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#806604}