GitLab

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/cd523eb..0f7197b

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=borenet@google.com

Review URL: https://codereview.chromium.org/600933002

Cr-Commit-Position: refs/heads/master@{#296536}

Review URL: https://codereview.chromium.org/596123002

Cr-Commit-Position: refs/heads/master@{#296535}

BUG=416722
R=rtenneti@chromium.org

Review URL: https://codereview.chromium.org/594973002

Cr-Commit-Position: refs/heads/master@{#296534}

The test is flaky. Disabling it while investigating the cause.

BUG=417439
R=jam@chromium.org

Review URL: https://codereview.chromium.org/597003006

Cr-Commit-Position: refs/heads/master@{#296533}

This pixel test is now passing on the bots, after a hardware change
to use the same GPU on all systems.

BUG=416719

Review URL: https://codereview.chromium.org/595323002

Cr-Commit-Position: refs/heads/master@{#296532}

UIAccountTweaks disables the "manage protected content exceptions"
button in guest mode, but the ContentSettingsHandler re-enables it.

BUG=417103
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/601633002

Cr-Commit-Position: refs/heads/master@{#296531}

This CL breaks chrome://inducebrowsercrashforrealz

I don't know exactly why the behavior is broken, but it appears that setting a
signal handler for SIGTRAP interferes with breakpad exception handling. See bug
for more details.

Original CL: https://codereview.chromium.org/329423003
Original Commit: d81d222c

TBR=cpu@chromium.org
BUG=402337

Review URL: https://codereview.chromium.org/602793002

Cr-Commit-Position: refs/heads/master@{#296530}

BUG=20997,22923,30703,68069,81796,88640,89942,90057,90496,90671,92741
TBR=ericwilligers@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/598203002

Cr-Commit-Position: refs/heads/master@{#296529}

Simple crash fix.

BUG=417381

Review URL: https://codereview.chromium.org/601893002

Cr-Commit-Position: refs/heads/master@{#296528}

Excluding USE_OPENSSL is no longer appropriate now that Mac is on OpenSSL/BoringSSL.
(It should have been USE_OPENSSL_CERTS.) Switch them to condition on OS instead to
match the condition in browser_options.js.

BUG=417241
TEST=Manage certificates button in Settings opens Keychain on Mac

Review URL: https://codereview.chromium.org/597913004

Cr-Commit-Position: refs/heads/master@{#296527}

window.onpopstate used to be called with a null state when a page was
loaded for the first time. This was a bug, and inconsistent with other
browsers, but we relied on it in the PNaCl demo page.

Without it, direct links to a demo page were not working properly. Even
after fixing this, I ran into issues with history when creating/destroying
a new iframe element whenever the page switched. Using
iframe.contentDocument.location.replace seems to have fixed these issues.

No trybots because this only affects the AppEngine demo page.

BUG=none
R=sbc@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/600653002

Cr-Commit-Position: refs/heads/master@{#296526}

In case this header is included without sdk_util headers
being available (as can happen in naclports).

Review URL: https://codereview.chromium.org/596133002

Cr-Commit-Position: refs/heads/master@{#296525}

 * Instead, show it explicitly on caller side. This is necessary as the extensions system controls the app window's visibility.

Remove ActivityViewManager
 Instead of keeping activity -> widget map, use views::Widget::GetWidgetForNativeWindow

BUG=417017
TEST=ActivityManagerTest.Basic

Review URL: https://codereview.chromium.org/596623005

Cr-Commit-Position: refs/heads/master@{#296524}

std::{min,max} requires the algorithm.h header.

BUG=none
R=bradnelson@google.com, bradnelson@chromium.org

Review URL: https://codereview.chromium.org/597283002

Cr-Commit-Position: refs/heads/master@{#296523}

The algorithm is first trying to find an image to fit exactly the
required size in the device scale factor and default scale factor.
If it can't it will try to find the closest but preferrable largest
image. Note that the algorithm completely ignore an entry with no 'sizes'.

Fetching the image happens as soon as the Manifest is loaded and can be
done before or after the call to ShortcutHelper::AddShortcut().

BUG=366145
TEST=ShortcutHelperTest

Review URL: https://codereview.chromium.org/601433002

Cr-Commit-Position: refs/heads/master@{#296522}

This is blink side patch for this CL https://codereview.chromium.org/588653003/

BUG=385070

Review URL: https://codereview.chromium.org/592683002

Cr-Commit-Position: refs/heads/master@{#296521}

Answer contents and type must always be copied to the highest-scoring
suggestion, to ensure answers are not lost due to suggestion
deduplication.

BUG=415836
R=mpearson

Review URL: https://codereview.chromium.org/584653004

Cr-Commit-Position: refs/heads/master@{#296520}

BUG=401634
TEST=Easy unlock works
Easy signin works (woth some changes to the unlock app)

Review URL: https://codereview.chromium.org/585213002

Cr-Commit-Position: refs/heads/master@{#296519}

This test is flaky on the x86 Linux bots too.

BUG=236936

Review URL: https://codereview.chromium.org/604533002

Cr-Commit-Position: refs/heads/master@{#296518}

This is also fixing the chrome/OWNERS android related rules
to apply on chrome_android*.gypi files instead of *android*.

BUG=None

Review URL: https://codereview.chromium.org/604503002

Cr-Commit-Position: refs/heads/master@{#296517}

Program the NIC to wake-on-packet for packets arriving from
the GCM server.  Chrome notifies the connection manager (shill)
by calling D-Bus methods.  The return status indicates if the
operation succeeded or not (depending on hardware support and
the type of connection).

This is a resubmission of a previous patch with the same title
and functionality containing fixes and a workaround for a problem
that is independent of this patch.  Bug 415821 remains open
for that problem.

Keywords: wowlan, wake-on-lan, wake-on-wlan

BUG=360295
TEST=verified dbus methods are called, and packets are sent on the
TEST=connection passed to the methods.  Also verified that shill
TEST=programs the NIC correctly, and packets wake up the device.

Review URL: https://codereview.chromium.org/597683005

Cr-Commit-Position: refs/heads/master@{#296516}

BUG=404661, 179713
TEST=Manual, see bug
R=flackr, oshima, derat
TBR=stevenjb

Review URL: https://codereview.chromium.org/585623003

Cr-Commit-Position: refs/heads/master@{#296515}

The previous CL (https://codereview.chromium.org/540673002) was not fully
correct.  It used a path based on <nacl_arch>, but the path can be arbitrary
based on entries in the extension's manifest.

If the extension used non-nacl_arch paths, it would continually download and
install the same copy of the extension, eventually filling up the user's disk if
left long enough without restarting Chrome.

BUG=414156

Review URL: https://codereview.chromium.org/596193002

Cr-Commit-Position: refs/heads/master@{#296514}

BUG=265583

Review URL: https://codereview.chromium.org/598533004

Cr-Commit-Position: refs/heads/master@{#296513}

When verifying that the cached doodle is still valid, we load the doodle
URL and append the query param "async=es_dfp:<fingerprint>". Previously,
the ":" was being escape to "%3A", causing the server to respond with a
400 error. This mollifies the server by keeping the colon unescaped.

BUG=413845

Review URL: https://codereview.chromium.org/587943003

Cr-Commit-Position: refs/heads/master@{#296512}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3bcf32e..a8890fa

TBR=pdr@chromium.org,wjmaclean@chromium.org,ager@chromium.org

Review URL: https://codereview.chromium.org/604493002

Cr-Commit-Position: refs/heads/master@{#296511}

When creating a MediaPlayer, pass the initial CDM value, if there
is one. This may happen if setMediaKeys() has been called before
the MediaPlayer object is needed. The initial CDM value may be null.

BUG=358271
TEST=existing EME tests still pass

Review URL: https://codereview.chromium.org/594713002

Cr-Commit-Position: refs/heads/master@{#296510}

NOTRY=true

Review URL: https://codereview.chromium.org/600953002

Cr-Commit-Position: refs/heads/master@{#296509}

This moves SafeManifestParser to extensions_browser.
Also creates a new ExtensionUtility IPC message class in which
to define extensions utility process messages. The relevant
manifest parsing messages have been moved into this class.

BUG=398671

Review URL: https://codereview.chromium.org/464613002

Cr-Commit-Position: refs/heads/master@{#296508}

Tighten the directional comparison for fling accumulation, preventing
perfectly orthogonal flings from accumulating. Also adjust Android's
ContentViewScrollingTest#testFling integration test to scale the
fling by the device scale factor, ensuring consistent results all
all displays.

BUG=406848

Review URL: https://codereview.chromium.org/602873002

Cr-Commit-Position: refs/heads/master@{#296507}

Ozone compiles with USE_AURA=1 TOOLKIT_VIEWS=0 which cases compile
errors due to missing member functions ShowDisambiguationPopup
and HideDisambiguationPopup.

BUG=none
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/596373002

Cr-Commit-Position: refs/heads/master@{#296506}

Added checks for missing arguments in event_sender.cc. Also simplified the uses of x & y in EventSender::GestureEvent.

BUG=415970

Review URL: https://codereview.chromium.org/584203003

Cr-Commit-Position: refs/heads/master@{#296505}

When bookmarks experiment is enabled existing code will add a command line flag that will allow opt-out to be shown on a chrome:flags page.
On Chrome OS at time of login if they see command line flag from any experiment they restart browser. It creates delay and user will see a black screen for a couple seconds. It happens on every login, not only the first one.
I talked to CrOS devs and they strongly discourage from using command line flags.
So for Chrome OS only do not add flag to command line but still keep it in a flag_storage. Use flag storage when need to check if flag is set.

BUG=

Review URL: https://codereview.chromium.org/578333003

Cr-Commit-Position: refs/heads/master@{#296504}

Keeps the fetcher functionality as ImageFetcherImpl in chrome/browser/search/suggestions.

BUG=387751
TBR=blundell
TEST=ImageManagerTest,ImageFetcherBrowserTest

Review URL: https://codereview.chromium.org/543753002

Cr-Commit-Position: refs/heads/master@{#296503}

BUG=363590

Review URL: https://codereview.chromium.org/595423002

Cr-Commit-Position: refs/heads/master@{#296502}

BUG=416701

Review URL: https://codereview.chromium.org/602863002

Cr-Commit-Position: refs/heads/master@{#296501}

BUG=412126

Committed: https://crrev.com/01c68e8765254d9971296b291ff718b4f6af3004
Cr-Commit-Position: refs/heads/master@{#295591}

Committed: https://crrev.com/74c6ef17a08754abadb6fb64da14249898285fa8
Cr-Commit-Position: refs/heads/master@{#296107}

Review URL: https://codereview.chromium.org/565803002

Cr-Commit-Position: refs/heads/master@{#296500}

BUG=414808
TBR=maruel@chromium.org
NOTRY=true

Committed: https://chromium.googlesource.com/chromium/src/+/01b2eb0b5e291faa238d6a21def3e62056bc1fdd

Review URL: https://codereview.chromium.org/598053002

Cr-Commit-Position: refs/heads/master@{#296499}

This is a step toward to killing FileDescriptor.
This change lets FiileDescriptorSet have both Files (for owning fds)
and PlatformFiles (for non-owning fds). Doing this, we no longer
need FileDescriptor which provides |auto_close| flag.

BUG=415294
TEST=ipc_tests, ipc_mojo_unittests
R=agl@chromium.org, jam@hcromium.org, viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/583473002

Cr-Commit-Position: refs/heads/master@{#296498}

r1385: Linux: Call memset() in a couple places in ExceptionHandler.
r1386: IWYU in minidump_writer.cc to fix building with libc++.
r1387: Fix some nits raised by Timur for r1385.

Also remove Valgrind suppression Breakpad r1385 fixed.

BUG=332335

Review URL: https://codereview.chromium.org/601823003

Cr-Commit-Position: refs/heads/master@{#296497}