- 10 Jan, 2020 40 commits
-
-
Maksim Ivanov authored
Add a browser test for the scenario when the sign-in screen extension is first installed at some version, and then the server starts announcing a newer version, so that Chrome eventually fetches, installs and runs it. Bug: 1012892 Change-Id: Iad3537236d56d7c86e02478bd2ff46fea6c0d112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992420 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#730201}
-
Scott Violet authored
And puts the implementation in the single place that needs it. SessionTabHelper is really intended to forward WebContentsObserver related calls to SessionService. SetTabExtensionAppID() isn't that. As SetTabExtensionAppID() was called in a single place, I moved the implementation there. This is part of a larger refactoring I'm doing in hopes of moving SessionTabHelper to a shared location. BUG=1033924 TEST=none Change-Id: Ia70af33908593839d4a22b4ebbc5f9f48c8abc30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994527 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#730200}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6ddbe2c5b003..4b0705913917 git log 6ddbe2c5b003..4b0705913917 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 yura.yaroshevich@gmail.com [iOS] Reset VT session when H264 encoder malfunction error happen Created with: gclient setdep -r src/third_party/webrtc@4b0705913917 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id53429d1e8752b1c9904bb5c61485a22c35acee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995231Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730199}
-
Patrick Monette authored
Bug: 1040794 Change-Id: Iaeffc745b01009500352d2b4be1a907cbbf10a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990211Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#730198}
-
Lei Zhang authored
In browser_prefs.cc, both RegisterLocalState() and RegisterProfilePrefs() have lists of registration functions to call. Over time, these pile up so there are now repeated #if cond blocks. Consolidate those and also alphabetize some of the lists that are clearly unsorted. Fix a lint error as well. Change-Id: Ifef2f127fe59e9571bf693efa0421789b0a2cfb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994670Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#730197}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c80b27e14b36..d911a9f90cdf git log c80b27e14b36..d911a9f90cdf --date=short --first-parent --format='%ad %ae %s' 2020-01-10 moragues@google.com mushu: disable hw tests 2020-01-09 saklein@chromium.org Packages controller: Add logging to version endpoint 2020-01-09 jacobraz@google.com flash_ap: add support for Zork and Volteer. 2020-01-09 chrome-bot@chromium.org Update config settings by config-updater. 2020-01-09 mmortensen@google.com Set default field_limit for query_build_logs to show relevant result. 2020-01-09 engeg@google.com paygen: delta_generator runs inside squawking thread 2020-01-09 cjmcdonald@chromium.org Build API: Add GetToolchainPaths endpoint 2020-01-09 cjmcdonald@chromium.org yapf formatting 2020-01-09 cjmcdonald@chromium.org portage_util: Add equery output parser 2020-01-09 cjmcdonald@chromium.org Update generated proto files to ToT Created with: gclient setdep -r src/third_party/chromite@d911a9f90cdf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I8114e4f33ac05cf3f3ec27a456b87732b9503d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995236Reviewed-by:
-
Eric Stevenson authored
This is a reland of 77bc3255. The original CL had issues for both Chrome and WebView; bundle status wasn't being set early enough. Original change's description: > Android: Make BundleUtils bundle status work with Trichrome. > > This is necessary for Trichrome synchronized ProGuard where we need to > support different values for Chrome and WebView (so we can't use the > same class). > > Right now, BuildConfig.java isn't generated by TrichromeLibrary and so > the version from the main APK will be used. > > Bug: 901465 > Change-Id: I40a4d31b545bdb564a90babf4e49f3df0a597090 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954934 > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Auto-Submit: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#724341} Tbr: agrieve@chromium.org Bug: 901465 Change-Id: Ifcc652c6064052b3c7241c27f43c0bd1dd027b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989243Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#730195}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7ba39a0c2e40..920683437e19 git log 7ba39a0c2e40..920683437e19 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 primiano@google.com Merge "Limit the number of sessions per uid to 5" 2020-01-10 fmayer@google.com Merge "Do not use uninitialized Variadic." Created with: gclient setdep -r src/third_party/perfetto@920683437e19 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I911bafd66d18acdeb3418b5da95195f90041bb57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995234Reviewed-by:
-
Christian Dullweber authored
Bug: 1027931 Change-Id: Ib3f19724c4241c8f80db4b917c9f510a4ad5534b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993809 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#730193}
-
Vladimir Levin authored
This patch only affects the CSS version of render-subtree. Right now, we keep size containment if the invisible token is present, even if the lock is activated. I don't think this was ever the intent, although the spec language suggests that if 'invisible' is present, we should have size containment. The language is speaking about the attribute version though, so I think we should reword that for CSS. See https://github.com/WICG/display-locking/issues/104 for more discussion. R=chrishtr@chromium.org, rakina@chromium.org Change-Id: Iaf03c234aa27024a76908ef2e14b11a17426703e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993389Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#730192}
-
Stephen Chenney authored
The previous code disabled the shader fast path whenever respecting image orientation, even when the orientation would not make any different (i.e. for non bitmaps or the default orientation). Fix this by adding Image::HasDefaultOrientation and using it where possible. Bug: 1036181 Change-Id: Ifb8f9163caf6a4352b0c1516664427c5b49d48a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993840 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#730191}
-
Chase Phillips authored
Bug: 999001 Change-Id: If3ec271dcec5b479a183c8a3a1da822e86f4e976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994415 Auto-Submit: Chase Phillips <cmp@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#730190}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/0b9a2992c73d..3f24b6829b3e git log 0b9a2992c73d..3f24b6829b3e --date=short --first-parent --format='%ad %ae %s' 2020-01-10 rharrison@google.com Add reference to Go bindings in README.md (#949) 2020-01-10 dneto@google.com Fix spelling of -finvert-y in doc (#947) Created with: gclient setdep -r src/third_party/shaderc/src@3f24b6829b3e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: Ibdceaac0814ef138ce828b50d6d6788ef3f4a53f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995232Reviewed-by:
-
Torne (Richard Coles) authored
This was removed from the declare_args section some time ago, but for AOSP system implementors it may be desirable to manually control it. Re-add it as an argument, and document how to use it in the WebView AOSP build guide. Fixed: 1034192 Change-Id: Ic5f890f2ad3677bb76ce87951ee0d7d3f20551b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976331Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#730188}
-
Christian Dullweber authored
Test that deleting cache data with a whitelist does not remove TransportSecurityState. Bug: 1040065 Change-Id: I41763b4d9034b8fe4eba7e37e9b03cfe575b2fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992083 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
Olivier Li authored
Set browser state builder dir to avoid file leaks in ios tests in /ios/chrome/browser/ui/activity_services This cl is generated with 'git cl split' This CL was uploaded by git cl split. R=pkl@chromium.org Bug: 546640 Change-Id: I4569f1f4ba2fb24928c14b8640cf97123bff8129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991755Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Auto-Submit: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#730186}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ef05f96d6de1..eaacb72383ba git log ef05f96d6de1..eaacb72383ba --date=short --first-parent --format='%ad %ae %s' 2020-01-10 tvanderlippe@chromium.org Migrate console/ to ESM internally 2020-01-10 tvanderlippe@chromium.org Migrate formatter_worker/ to ESM internally 2020-01-10 tvanderlippe@chromium.org Migrate extensions/ to ESM internally 2020-01-10 tvanderlippe@chromium.org Migrate event_listeners/ to ESM internally 2020-01-10 tvanderlippe@chromium.org Migrate components/ to ESM internally 2020-01-10 tvanderlippe@chromium.org Migrate har_importer/ to ESM internally 2020-01-10 aerotwist@chromium.org Migrates changes/ to ESM internally 2020-01-10 aerotwist@chromium.org Migrates browser_sdk/ to ESM internally Created with: gclient setdep -r src/third_party/devtools-frontend/src@eaacb72383ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I84e03b639da6c344f596f824cf9d2279f2f7a3eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994644Reviewed-by:
-
Charlie Reis authored
Filtering IPCs from swapped out RenderViewHosts is no longer necessary now that we have fully shifted to RenderFrameProxyHosts and cleaned up the old dependencies. This CL removes the old filtering logic, along with the RenderViewHostImpl::is_swapped_out_ state, which was only being used for filtering decisions. Bug: 1015882, 745091 Change-Id: I7f30139812684b0ade80d05923f8f237d5454151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989701Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#730184}
-
Vincent Boisselle authored
This is a reland of 34d462f6 Original change's description: > Add end-to-end tests for demographic metrics in UMA and UKM > > Bug: 992573 > Change-Id: I5a27682828538c72fbe8fc71c78cbadc8fdef23e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872643 > Commit-Queue: Roger McFarlane <rogerm@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728621} Bug: 992573 Change-Id: Ib6cf80256a8adbcb15a23814f6431d7ea600a1b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994003Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#730183}
-
Sylvain Defresne authored
The target //third_party/test_fonts copy the files to the same location for all toolchains, so when using multiple toolchains (which is common when targeting iOS) and multiple toolchains depends on that target (it can happen when building cronet), ninja presents a warning because some files are copied to the same location. Change the target to copy the files to $root_out_dir instead of $root_build_dir which correspond to the same directory for the default toolchain but to a toolchain specific directory for the secondary toolchains (this is consistent with the other target that copy fonts defined in //skia). Also fix iOS build to also use a bundle for the fonts (since iOS apps cannot access file outside of the application bundle). Bug: none Change-Id: Ic5e3290a495f67744f9d676800e16612ffefcbc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992428Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Stephen White <senorblanco@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#730182}
-
Luke Zielinski authored
TBR=robertma Change-Id: Ie2e46a32932b19544eb15d1b2f8080c75aab3e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994602Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#730181}
-
Manuel Rego Casasnovas authored
In r729750 we added a regression test as an internal test but it's better to move the test into WPT. BUG=1036644 Change-Id: I16bcfc99ef2faff90bd03020a8cc4809689d2d5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994299Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#730180}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f72e48dd2ff0..2076b04d153f git log f72e48dd2ff0..2076b04d153f --date=short --first-parent --format='%ad %ae %s' 2020-01-10 reed@google.com new virtuals for canvas ctm Created with: gclient setdep -r src/third_party/skia@2076b04d153f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: I4b3c5bd602e00fcbe3d5fc8cb3b760c8ae464ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995303Reviewed-by:
-
Eric Seckler authored
Previously, we were writing individual packet headers + payloads one by one onto the mojo pipe. Internally, each write causes a memcpy into a shmem buffer and a mojo notification to be sent to the Consumer to read the data from the buffer. This was probably not a big problem when a trace packet contained many trace events, but now that each packet is only a single event (and especially now that each COMPLETE event is split into separate begin/end events, i.e. separate packets), this causes a lot of overhead. Instead, this patch modifies ConsumerHost to write a single slice per ReadBuffer callback to the mojo pipe, which makes proto trace collection significantly faster. Bug: 1039726 Change-Id: I057c68ffafb99cbd2b41d6c6308391cc11cf1883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991448 Auto-Submit: Eric Seckler <eseckler@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#730178}
-
Omer Katz authored
Some of the scopes were not reporting any data to GC metrics. This CL replaces Scope with EnabledScope to fix these issues. Bug: 986235 Change-Id: I21a8884faa491aa21b8d6a88e716c870f911da1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995320Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#730177}
-
Henrique Nakashima authored
Register them in ChromePreferenceKeys and use SharedPreferencesManager consistently instead of SharedPreferences directly. Bug: 1022108 Change-Id: I706ca75c671bed29af42f3420ea613f28d4f12a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993650Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#730176}
-
Allen Bauer authored
Bug: 648382 Change-Id: I323176de4bb64747b5b6a0989ad559da2edaea15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993147 Auto-Submit: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#730175}
-
Jit Yao Yap authored
This CL adds 2 new chrome.login API methods, |lock| and |unlock|, and adds an additional optional parameter to the |launchManagedGuestSession| method. These changes are to support locking/unlocking of Managed Guest Sessions (MGS). An MGS launched using |launchManagedGuestSession| with a password will be lockable, and will support locking from the system tray lock icon, lock accelerator, lid closing and idle actions. In addition, the |lock| method can be called to lock an MGS. The corresponding session can only be unlocked using the |unlock| method. |ExistingUserController| and |UserContext| are updated to set the MGS as lockable when launched with a password, and |ChromeUserManagerImpl| is updated to support locking of MGS. UI changes will be done in a separate CL. Design doc: go/lock-mgs Bug: 1032065 Change-Id: Ifd88e20d2908d8a11ff20c3325cd002d6b005d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958049 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#730174}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dcc57015f892..c792a6bacf68 git log dcc57015f892..c792a6bacf68 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src ac72777ef763..c17344df6cca (2 commits) Created with: gclient setdep -r src/third_party/angle@c792a6bacf68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I4816d7e695e9580c1ec474350301cef1e734add7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995145Reviewed-by:
-
manukh authored
*The issue* When the input contains symbols not adjacent to alphanumeric characters, the HistoryQuick provider returns no suggestions. E.g., as the user types the input 'george washington - wikipedia', the corresponding HistoryQuick suggestion for 'en.wikipedia.org/wiki/George_Washington' will disappear once the user types the '-'. *Why the issue occurred* The history quick provider splits the user input into terms by whitespace and identifies word start offsets for each term. E.g., the input 'george washington - .wikipedia' is split into 4 terms: 1) 'george' with word start offset 0, 2) 'washington' with word start offset 0, 3) '-' with word start offset 1, and 4) '.wikipedia' with word start offset 1 When scoring, it ensures each term is present in either the suggestion title or URL beginning at a word break (with some exceptions) accounting for word start offsets. E.g, given the suggestion title: 'George Washington - wikipedia .someText' ^ ^ ^ ^ 0 7 20 31 Then the terms 'wiki', 'some', and '.some' will all match the title; but neither '.wiki' nor 'text' will match. The previous implementation accounts for word start offsets by checking if the sum of the match index and word start offset is a word start in the suggestion text. E.g., the input '.some' will match at index 30 and has word start offset 1, summing to 31 which is a word start. An unintended side affect of the previous implementation was that terms containing no words, (e.g. '-') would be incorrectly classified as matching at a non-word-start, and would therefore disqualify the suggestion. E.g, the input '-' will match at index 18 and has a word start offset of 1, summing to 19, which is not a word start. *The fix* We can't simply ignore such terms, since then inputs such as 'george ----' would match. This CL adds an explicit allowance for terms containing no words to match at non word starts. Bug: 1003010 Change-Id: Id8f755cf0fb4f5536ec21f23bcd79994b9011642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990449 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#730172}
-
Elly Fong-Jones authored
Bug: 1011446 Change-Id: I8ad4f0f0c0765a53f5ff618842c147da9284d70d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993902Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#730171}
-
Colin Blundell authored
This CL integrates a check for whether to display the bad clock interstitial into WebLayer's SSLErrorHandler. The check is modeled on that in //chrome's SSLErrorHandler. However, we did not port the fetch of NetworkTimeTracker's time into //weblayer: this fetch introduces a fair degree of complexity into the flow by making it asynchronous, and it is not relevant on Android, where such fetches are not supported. This fetch will be incorporated when WebLayer shares //chrome's SSLErrorHandler implementation as part of crbug.com/1026547. Just like in Chrome, the bad clock interstitial is shown when there is an expired certificate and the network time is reported as being ahead or behind of the actual time. The network time is not always seeded, in which case the application defaults to showing the generic SSL interstitial. In particular, for Chrome on Android the network time is seeded either via sync or via the Variations Service. The latter will apply in WebLayer once variations is integrated. This CL adds a browsertest of the relevant functionality; the browsertest is adapted from one in //chrome and manually sets the network time in order to trigger the bad clock interstitial showing. (I did a similar exercise in the shell locally on Android and Linux to verify the showing of the interstitial). Note that opening the date/time from the interstitial is not yet supported; a followup CL will bring up that support by sharing the relevant implementation from //chrome. Change-Id: I176a342c5de328441d26a22f28742dba6793a1ed Bug: 1025059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983170 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#730170}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e6441b604f58..5fc2c82c11e0 git log e6441b604f58..5fc2c82c11e0 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 cwallez@chromium.org Add Instance and CreateInstance to webgpu.h Created with: gclient setdep -r src/third_party/dawn@5fc2c82c11e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I972527c3f14b2ac557bd50cba7f11f8c9670fd78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995300Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e195519d..a19e6092 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id7345200bd931424f19ee808ed2fd79d6310ef7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995207Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730168}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f9f51f7a. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Iacad3ed2778e2c8f9f6bad3f25f695f41f3ea3f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993764Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730167}
-
Oleh Lamzin authored
Change wilco dtc supportd host origin extension id to the new one. BUG=b:147478977 TEST=none Change-Id: Id529c232f3ac86fb31231d36bafd73eb871a5a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993814Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#730166}
-
sandromaggi authored
Previously the source for contacts and shipping addresses was the same sorted list of profiles. There may be cases where we want to sort them differently, which is enabled by splitting the list in two. This CL also moves the transformation logic from CreditCard / Profile to their destination objects (AutofillContact, AutofillAddress, AutofillPaymentInstrument) from the DataBinder to native/model directly. Bug: b/144005336 Change-Id: I644d4b52f962582a87b8aabce5e55066e3356481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992082 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Auto-Submit: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#730165}
-
Olivier Li authored
This cl is generated with 'git cl split' This CL was uploaded by git cl split. R=sczs@chromium.org Bug: 546640 Change-Id: I8ea59ea0816ab8f2cee1eb5a377d8b16ce41a220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991757 Commit-Queue: Oliver Li <olivierli@chromium.org> Auto-Submit: Oliver Li <olivierli@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#730164}
-
Luke Zielinski authored
Stop setting flag --no-fail-on-unexpected, which causes wptrunner to always exit with code 0. Omitting this flag makes the exit code equal the number of failed tests. The CQ needs the exit code in order to determine which shards to retry. Bug: 937369 Change-Id: I150321a7783948724be0d622646108e5df6249eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992911Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/033f08c5a865..7ba39a0c2e40 git log 033f08c5a865..7ba39a0c2e40 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 eseckler@google.com Merge "gen_merged_protos: Fix return value calculation" Created with: gclient setdep -r src/third_party/perfetto@7ba39a0c2e40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ib7df1b00628657297ce3f9a175a59039ecfc2917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995039Reviewed-by:
-
