GitLab

(1) Both the MultiDevice and Internet pages had some loadTimeData added
    within os_settings_ui.cc, so this CL moves them to their per-page
    provider instead.
(2) Adds explicit dependencies to OsSettingsLocalizedStringsProvider by
    adding relevant KeyedServices to its constructor. As more are added
    in subsequent pages, this will make it easier to track which
    services are used.
(3) Minor changes in tests and const getters.

Bug: 1069849
Change-Id: I49debfaa32375a585c7003932c8d2daa745168eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153700Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759844}

The TabState databases persists tab metadata across restarts. The
TabState database needs to be per profile. This is achieved using
KeyedService.

Bug: 1061258
Change-Id: If9841b8a815483f8e3cc5bc088136d64da001856
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138496
Commit-Queue: David Maunder <davidjm@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759843}

Reverting previous change to allow compressing this file, since
failures on ASAN and Win10 are apparently still happening, when
attempting to compress this file.

This is one of many CLs, in preparation of compressing all HTML, JS,
CSS, SVG files by default (meaning without requiring compress="gzip"
to be specified).

Bug: 1068407
Change-Id: I91fe5e5444f3b6cbe170f83b0fef8f8a0d29886b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153749Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759842}

This change adds the WebApp.Launcher.LaunchResult metric, which will
report the result of a Progressive Web App (PWA) launcher's attempt to
launch chrome.exe.

On Windows, each PWA has a separate launcher executable in its web-app
data directory (located at
<User Data dir>/<profile>/Web Applications/_crx_<app ID>/). The
launcher's purpose is to locate chrome.exe and launch it with the
--app-id flag corresponding to the PWA it represents.

There may be multiple copies of the launcher executable (one per PWA)
on the system, so keeping the binary size small is important. To that
end, the launcher does not have Crashpad integration - instead, it
writes the result of its launch attempt (started, error, or success)
to the registry at HKCU/Software/Chromium:PWALauncherResult.

This change reads the launch result logged at that registry key and
emits it to the WebApp.Launcher.LaunchResult histogram if it is valid.
The emitted value is then deleted from the registry to ensure it is
not emitted more than once.

Note: because the path to chrome.exe is needed to log to the correct
registry key, and because finding chrome.exe comprises most of the
work done by the launcher, the types of errors that can be logged are
limited to launch errors. Any errors encountered while trying to find
chrome.exe are not logged, because the registry key for chrome.exe is
not yet known (it is set via
install_static::MakeProductDetails(chrome_path).

Bug: 960245
Change-Id: I96ca5c797caf1b87e65ed25a1aacb9e081f16307
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151684Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Cr-Commit-Position: refs/heads/master@{#759841}

Verified fix and test case works fine again now.

Bug: 1069615
Change-Id: I3ce9b1419d765bcb71210b2453df63b2d913b81f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152994
Auto-Submit: Ian Struiksma <ianstruiksma@google.com>
Reviewed-by: Sven Zheng <svenzheng@chromium.org>
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759840}

This CL adds several logs when setting DSP hotword locale, so we can
have more information, i.e. the model name, when debugging DSP related
issues.

Bug: b/153679889.
Test: manually.
Change-Id: I9ee2193dea42a3bea221ff20eb824ad373a0fe8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152990
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759839}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome

BUG=762641
TBR=chrome-os-gardeners@google.com

Change-Id: I1b376d9903a9dcdba5521a4281e34e9c392afe57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153690Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759838}

The above capability allows creating shared images for scanout using the
GL backing factory. This was needed to support images with concurrent
read/write usage which is currently not supported by the AHB backing
factory.

R=vikassoni@chromium.org

Bug: 1019751
Change-Id: Iaf0300e049ac65fbe839b5fdf6d22db7a81d44f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147353
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759837}

It appears that on Windows, Bluetooth hardware does not generally
support the BLE peripheral role (i.e. BLE advertisements). Add a method
to BluetoothAdapter that returns the
BluetoothAdapter.IsPeripheralRoleSupported property [0] on WinRT and
true everywhere else, so that client code can detect these cases.

[0]
https://docs.microsoft.com/en-us/uwp/api/windows.devices.bluetooth.bluetoothadapter.isperipheralrolesupported

Bug: 1069140
Change-Id: If8f2f448f30db6aaf720c10e00391dea3f65944e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152892
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759836}

https://pdfium.googlesource.com/pdfium.git/+log/2dd3f0f2c0f7..a8817db1767d

git log 2dd3f0f2c0f7..a8817db1767d --date=short --first-parent --format='%ad %ae %s'
2020-04-16 thestig@chromium.org Use more spans in CBC_PDF417HighLevelEncoder.
2020-04-16 dhoss@chromium.org Restyle listbox_form.pdf and rename multiselect form field
2020-04-16 tsepez@chromium.org Move scalar vectors to data partition in fxbarcode/
2020-04-16 tsepez@chromium.org Move scalar vectors to data partition in fxge/win32

Created with:
  gclient setdep -r src/third_party/pdfium@a8817db1767d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I40c40db0630e5fb5f83643021405d171729c968c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153637Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#759835}

This was causing a null read on testing.

Bug: 1068640
Change-Id: I88f1e60284484b9f88adf87302deda4e86b594cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152886
Auto-Submit: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759834}

Currently when a user is attempting to use the (Chrome) AR Permission,
a default message pops up indicating that the (OS) Camera Permission is
also required. However, these strings may be confusing to the users as
they simply indicate that the requested setting is turned off in Android
Settings, and there is no corresponding AR session.  These strings help
inform the user that AR requires access to the Camera.

Fixed: 1059328
Change-Id: Ia228e97bb4553dad4dfe5ba85f74fe16fdf76a39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146083Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759833}

BitmapImage caches the last generated PaintImage which is updated only
if more data for the image is loaded. The PaintImage stores the alpha
state for the image which may change once it has been decoded. Ensure
that this cached PaintImage is invalidated if there is an alpha change.

R=wangxianzhu@chromium.org

Bug: 1063679,739339
Change-Id: Icbe2eda8861d71b6cf200e939982293635e520a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114582
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759832}

This CL expands on the work to include an AccessibilityEventDispatcher
on Android, relevant CL:
https://chromium-review.googlesource.com/c/chromium/src/+/2139905

Here we include a simple set of tests to check our queueing logic
and throttling of specific event types. We test for both events that
are and are not throttled, with cases of the first event, an event
after some time with no events, and events in quick succession.

We also slightly modified the AccessibilityEventDispatcher with this
CL to fix a dependency injection issue to make the testing easier.

Change-Id: I13aed5541eba0feaf1b250bf15cae9809efe54b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151851Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Mark Schillaci <mschillaci@google.com>
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Cr-Commit-Position: refs/heads/master@{#759831}

RecordHistogram no longer causes crashes when used without native.

Bug: 1069294
Change-Id: Ifd4661fe19af22584718b7edabe4d7cf53d280f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145255Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: bttk <bttk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759830}

The Tab to Focus Suggestion Removal button was regressed in this CL, which
I reviewed:
https://chromium-review.googlesource.com/c/chromium/src/+/2131021

The above CL is a great refactoring CL, which we don't want to revert.
It just broke a piece of functionality.

This CL fixes the functionality and adds a test to prevent regressions.

We will need to backmerge this into M83.

Bug: 1071542
Change-Id: Ib458c1404deccfb85f06015ccb2cae751db9744f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153323
Auto-Submit: Tommy Li <tommycli@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759829}

Isolated runners are requesting the VULKAN feature by default which
causes the following failure during the test:

[ERROR:vulkan_instance.cc(139)] Required extension VK_KHR_get_physical_device_properties2 missing from enumerated Vulkan extensions. vkCreateInstance will likely fail.
[ERROR:vulkan_instance.cc(202)] vkCreateInstance() failed: -7
[ERROR:gpu_init.cc(698)] Failed to create and initialize Vulkan implementation.
[ERROR:GrGLInterfaceAutogen.cpp(132)] ../../third_party/skia/src/gpu/gl/GrGLInterfaceAutogen.cpp:132 GrGLInterface::validate() failed.
[ERROR:shared_context_state.cc(234)] OOP raster support disabled: GrContext creation failed.

The test currently passes anyway, because (1) GPU process falls silently
back to GL composition and (2) we have enabled mock GL prior to enabling
ANGLE. Once ANGLE is enabled, initializing GL fails which can make the
test crash (although not reliably, these small tests often pass before
the crash occurs).

Don't add feature flags that weren't requested originally. This leaves a
whitelist in place instead.

Bug: 1059497
Change-Id: I03760f857308b1791445301f03011c0b6b982339
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152207Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759828}

Implements that select local image file as NTP background feature in the
customize dialog. In the UI it says "Upload from device" which seems
fine since it matches chrome-search://local-ntp.

Bug: 1032328
Change-Id: Ib211b74769e86da5566787b601830b12c8fbfa41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152001
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759827}

This starts with just a few variants of the weblayer skew test:
* client and tests from master vs M81 implementation
* client and tests from master vs M83 implementation

All running on Pie x86 emulator bots.

Bug: 1058966
Change-Id: Ia919698c3f666fcfbf679c17fe0aa0adfc209d4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150240Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759826}

Bug: 852061
Change-Id: Id5b3aa5a7d0b2e7e676b1ac09c96cf27550d9794
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148827
Commit-Queue: Hongbo Song <hbsong@google.com>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759825}

Make displaying phonetics for the dictionary use-case within Quick
Answers optional to handle the scenario when one is unavailable or
multiple are present, parsing failure ends up leading to not displaying
the definition as well.

Bug: b:152110565
Test: Tested on Chrome OS VM.
Change-Id: Ice5a4ed4ee2fd86aaa2c1baeae36c26c2be3262c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151931Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Abhijeet Singh <siabhijeet@google.com>
Cr-Commit-Position: refs/heads/master@{#759824}

As discussed in the spec,
(https://html.spec.whatwg.org/#the-fieldset-and-legend-elements),
the display property for fieldsets should be applied to the
anonymous fieldset content box, specifically for flex and grid
display types. This change implements this functionality, as well as
adds the missing properties inherited by the anonymous content box.

virtual/layout_ng_fieldset/external/wpt/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/fieldset-flexbox.html
is now failing due to the fact that the expectation for this test was
based on the legacy layout functionality. However, this test still
isn't passing as expected. The spec indicates that a legend cannot be
treated as a rendered legend if it is floating. In this test, the
legend is styled as a float, but we are still treating it as a
rendered legend, which doesn't match the expected behavior.

virtual/layout_ng_fieldset/external/wpt/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/fieldset-multicol.html
is still failing because the way the layout tree is built for multi-
columns, the legend ends up being a grandchild of the anonymous content
box instead of a direct child. This will be addressed in a follow-up
change.

Bug: 875235,874051,375693
Change-Id: Ie467853a380de7163937d527748bb761d37b8692
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150810Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#759823}

The flag is no longer respected. Delete the flag and all references to
it.

Bug: 1069258
Change-Id: I0d5040eef178ab5d93cd45d244374f17a424f264
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150277
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759822}

Since crrev.com/c/1979258, we have been painting view backgrounds
differently when the root element adds/removes paint properties.
We should invalidate view background.

Bug: 1070952
Change-Id: If263f32bb80b7654a9f4e01f3fd41ff28e4a848d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152992Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759821}

Bug: 1071090
Change-Id: Ife9302216120de63a59614427e88e786426131d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152890Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759820}

A future CL will use those IDs without their associated worker
service.

Bug: 993029
Change-Id: I40391971b8ee673e00b8865a82bc6ce9b8d8f162
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148681
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759819}

What:This CL adds per-top-level-page metrics for the number of conversions
that took place over the course of the page load.

Why: To measure potential abuse in conversion registration, and guide
any limits we might put on the feature.

How: via a new per-page scoped class ConversionPageMetrics that
aggregates this data.

Bug: 1044099
Change-Id: I41f7910a6f07cbe0d00a7445a2bb48c77fd25c0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145254
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759818}

This both simplifies the code and allows us to make changes to explore
fixes to the two bugs below.

It should not change any existing behavior, as this change just moves
the existing code to a new private implementation class.

Bug: 1057713, 1059862, 1068459
Change-Id: I0d7868aadcd4a5adf29b2dc670f7a7d523da24b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141041
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759817}

This patch converts the ReaderModeManager to be a tab helper, replacing
access of the TabModelSelector with a single tab.

Bug: 1069815, 1051184
Change-Id: I3f16a4b053aed006ed8b232393d12396ad7e24fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151469Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759816}

Assistant should only contribute search results iff:
- Assistant is allowed, and
- Assistant is enabled

Bug: b:146673437
Change-Id: Ic37968c0cd7264290d9ac391d6377a63ea48250d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146172
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759815}

Retains refs to the store when using callbacks
and also change the fatal -> error for sql
errors since it is making bots crash.

Change-Id: Ie27d43f2044700e1b299d2a34406b1eb2fc9412b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149405Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759814}

https://skia.googlesource.com/skia.git/+log/efebaa2a1152..4e3ceb96b8a1

git log efebaa2a1152..4e3ceb96b8a1 --date=short --first-parent --format='%ad %ae %s'
2020-04-16 robertphillips@google.com Fix up GPUDDLSink for Vulkan
2020-04-16 mtklein@google.com GP64 Operand conversion
2020-04-16 senorblanco@chromium.org Reland "Refactor GL and Metal FinishCallback into a helper object."
2020-04-16 bsalomon@google.com Revert "GrDisplacementEffect uses GrTextureEffect."
2020-04-16 reed@google.com change Overdraw colorfilter to be pure sksl
2020-04-16 jlavrova@google.com getRectForRange with HeightStyle == kTight should ignore strut metrics
2020-04-16 westont@google.com Remove Debian10 Flutter_Android, change BuildStats to use Debian9 Docker
2020-04-16 bsalomon@google.com GrDisplacementEffect uses GrTextureEffect.
2020-04-16 michaelludwig@google.com Rename GrShape to GrStyledShape
2020-04-16 michaelludwig@google.com Respect wrap mode when decimating for blur
2020-04-16 mtklein@google.com lots more refactoring
2020-04-16 westont@google.com Dockerize Flutter Android job.

Created with:
  gclient setdep -r src/third_party/skia@4e3ceb96b8a1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: kjlubick@google.com
Change-Id: I4c42256bef5a52f46303e43ecf99e5bc7ae3ca5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153633Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#759813}

This patch replaces most usages of the TabModelSelector with Tab to
facilitate the transition of the ReaderModeManager to be a per-tab
object. The patch also includes a few other mechanical changes around
accessing the web contents and removes some now unnecessary null
checks.

Bug: 1069815, 1051184
Change-Id: Ica37a9781fd299494403174f46aa5b3a9c27939e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147675
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759812}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7339a08855d5..a0145e0512c2


Created with:
  gclient setdep -r src-internal@a0145e0512c2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC ricea@google.com,nektar@google.com,guidou@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1049042
Tbr: ricea@google.com,nektar@google.com,guidou@google.com
Change-Id: Ie3ffb2ac99d0b3c14ee82f5fa413025efdde26a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153484Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#759811}

These are trace categories used by internal Cast code.

Merge-With: team/719699

Bug: internal b/135325494
Test: CQ
Change-Id: I87f4c35200e7f2b5f54b9d70b38bce3c370dae48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153322Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Sean Topping <seantopping@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759810}

Bug: 1065338
Change-Id: I95826e4c124f312411284a44b49b6f2fe2c32ebe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153685
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759809}

https://chromium.googlesource.com/angle/angle.git/+log/cbdc14be1be4..8116c488ae96

git log cbdc14be1be4..8116c488ae96 --date=short --first-parent --format='%ad %ae %s'
2020-04-16 geofflang@chromium.org Remove the merge command from roll_aosp.sh
2020-04-16 geofflang@chromium.org Remove some bad files when generating an ANGLE roll into Android
2020-04-16 jian.li@arm.com Vulkan: Fix transform feedback on AMD platform
2020-04-16 geofflang@chromium.org Remove --preserve-root from roll_aosp.sh
2020-04-16 geofflang@chromium.org Roll VulkanMemoryAllocator into Android

Created with:
  gclient setdep -r src/third_party/angle@8116c488ae96

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: timvp@google.com
Change-Id: I90fbc48daf87fcdd6cda091776033712f5ef5fc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153477Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#759808}

This commit spins some test cases out of JSONParserTest.ErrorMessages
and adds some more.

Line and column counting is buggy, both before and after this commit
(which just adds tests). Future commits will fix the bugs, but the first
step (this commit) is to add test coverage.

Also remove two FRIEND_TEST_ALL_PREFIXES lines that should have been
part of crrev.com/c/2150527 "Move some JSONParser tests to JSONReader
tests".

Bug: 1069271
Change-Id: I333da3462a7ec75f58550594f9148be8f89a9321
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152334Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759807}

https://chromium.googlesource.com/openscreen.git/+log/f4308e08dc82..c117a70b3913

git log f4308e08dc82..c117a70b3913 --date=short --first-parent --format='%ad %ae %s'
2020-04-16 btolsch@chromium.org Rename CastSocket::SendMessage to Send

Created with:
  gclient setdep -r src/third_party/openscreen/src@c117a70b3913

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1050913
Tbr: jophba@chromium.org
Change-Id: I7f55b5ff8b00bd4de182eaef042e0ed0088425b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153481Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#759806}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I6cd016d2d0e0ccfc743ec4ebdc47936d31767532
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153635Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#759805}