- 25 Jan, 2018 40 commits
-
-
Kush Sinha authored
Child accounts on Chrome OS will be forcibly logged out if account reconciliation timeout is reached without a successful reconciliation. Other accounts will maintain their existing behavior. Bug: 795808 Change-Id: If7dc163e2d0921a7e360aed9673b235d1a2d9c7c Reviewed-on: https://chromium-review.googlesource.com/883285 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#531866}
-
src-internal-roller@chromium.org authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8af6931d8777..9c4fd243124b $ git log 8af6931d8..9c4fd2431 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: Iace4719648870ad5951663e0da058714afba8ed9 Reviewed-on: https://chromium-review.googlesource.com/885911 Commit-Queue: src-internal-roller . <src-internal-roller@chromium.org> Reviewed-by:
src-internal-roller . <src-internal-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531865}
-
Gauthier Ambard authored
This CL changes the OmniboxPopup such as it doesn't need access to the toolbar view to be presented. Instead it only needs a pointer to its superview. The pointer to the view was used to present the popup above or below it to show the shadow between the omnibox and the popup or not. This CL changes it by adding the shadow if needed in the popup. It also removes the white rectangle recovering the place normally occupied by the toolbar during NTP animation (to avoid seeing the google logo moving up as the toolbar is hidden). To do that, the toolbar is directly shown if there are results to be displayed. Bug: 786940 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6a8dea25702b4644f0f0c76fc34b01c1deaf6a88 Reviewed-on: https://chromium-review.googlesource.com/881182 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#531864}
-
Andreas Haas authored
It can happen that WebAssembly.compileStreaming gets aborted when we are not allowed to execute JavaScript code, and therefore are also not allowed to reject the promise returned by WebAssembly.compileStreaming. This can happen e.g. when the Chrome tab gets refreshed, which aborts all downloads. With this CL we do not pass a reason to Abort if we are not allowed to execute JavaScript code. On the V8 side we can check the reason passed to Abort and do not reject the promise if there is no reason passed. The V8 side change is at crrev.com/c/876091 R=mtrofin@chromium.org Bug: chromium:803838 Change-Id: I55727f97fac38790cadc34ec5284131e13642f20 Reviewed-on: https://chromium-review.googlesource.com/876103Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#531863}
-
Juan Antonio Navarro Perez authored
These do no longer work. Bug: 804863 Change-Id: Id0bfff21aa9d7fc4338a37bdfcdf9d820ce32ea5 Reviewed-on: https://chromium-review.googlesource.com/881321Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#531862}
-
Yoshifumi Inoue authored
This patch changes how editing forces legacy layout to the one added for form controls[1] to use legacy layout tree for nested editable, e.g. <div contenteditable> legacy layout tree <div contenteditable=false> non-editable block in editable block should be legacy </div> </div> This patch continues http://crrev.com/c/880542 [1] http://crrev.com/c/875511 Change form controls not to use LayoutNG Bug: 714962 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I78d44fc82b3de5e647b67ee6aa7733db62e344b8 Reviewed-on: https://chromium-review.googlesource.com/880530 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#531861}
-
Yuta Kitamura authored
This patch adds a new function to WebScheduler so that Timer can obtain the current virtual time without using WebTaskRunner::Monotonically- IncreasingVirtualTimeSeconds(). WebTaskRunner::MonotonicallyIncreasingVirtualTimeSeconds() is not deleted in this patch, though, because there are some tests using it and they deserve a separate patch. Bug: 794845 Change-Id: I21c2f7accc86c7216ee917e5c29bc0ad3ec44b07 Reviewed-on: https://chromium-review.googlesource.com/882703 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#531860}
-
Harald Alvestrand authored
Bug: 801642 Change-Id: Ib92b6d857d5add650a757618adb38d7c7ed5c8f7 Reviewed-on: https://chromium-review.googlesource.com/885801Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#531859}
-
Benoit L authored
This reverts commit ef6f0fb3. Reason for revert: Regressed startup performance. See https://chromeperf.appspot.com/report?sid=9df0ec76b0fffc74931cc7bdcf44cd4d540f81bb34ccde3571c2211ec8360ee6&start_rev=531281&end_rev=531574 Original change's description: > android: Don't parse /proc/self/maps to prefetch the library. > > This commit changes the behavior of the native library prefetcher to > rely on sentinel symbols rather than parsing /proc/self/maps. > > Behavior changes: > 1. This will make the code no longer prefetch .data (because we don't > look for it in the mappings), neither the sections that are part of > the same mapping as .text (for instance, .rodata when using > ld.gold). This is intended. > 2. As a consequence, the UMA metric > LibraryLoader.PercentageOfResidentCodeBeforePrefetch will move, as > both sides of the ratio will change, and the population will change > slightly as well (since code is currently not correctly ordered on > ARM64 and x86_64) > > - Removes the reliance on a somewhat brittle parsing of a file > - Parsing /proc/self/maps costs ~50ms of CPU on a Nexus 5X (on a little > core, as this is triggered from an AsyncTask) > - Allows to only fetch part of the native library (in a forthcoming CL) > > Rationale: > Change-Id: I0bb7b28af3c3bd4af5745e2ebcc1fbf283bcc0c1 > Reviewed-on: https://chromium-review.googlesource.com/874470 > Commit-Queue: Benoit L <lizeb@chromium.org> > Reviewed-by: Egor Pasko <pasko@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Matthew Cary <mattcary@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531515} TBR=pasko@chromium.org,agrieve@chromium.org,lizeb@chromium.org,mattcary@chromium.org Change-Id: I11d7cd7898d5f8d8fbebf391eba5fdaca154c08a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/886321Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#531858}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/50c5a55c..a9bb5cf9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ifcb97dcfbe3b4eabb6c8a061ab4d6fa0abde46c8 Reviewed-on: https://chromium-review.googlesource.com/886061Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#531857}
-
Sheng-Hao Tsao authored
This CL adds some command line parameters to jpeg_encode_accelerator_unittest to enable JEAPerf autotest. BUG=b:67488323 TEST=Verified that JEAPerf collects metrics successfully on eve. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie369b17302e6f6587e81126ed35d577e71e00d68 Reviewed-on: https://chromium-review.googlesource.com/874493Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Wu-Cheng Li <wuchengli@chromium.org> Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Cr-Commit-Position: refs/heads/master@{#531856}
-
dpapad authored
Also removing paper-material, since the previous paper-fab version was the last usage of it. Bug: 738611 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic1ec8e70d5c5189ead7cb62c9e25f8f8dde5afee Reviewed-on: https://chromium-review.googlesource.com/883565Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#531855}
-
Yoshifumi Inoue authored
This patch changes |LayoutObject::EnclosingBlockFlowFragment()| to strict by using |ChildrenInline()| instead of |HasNGInlineNodeData()| for detecting failures of layout operation which doesn't compute inline node data. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Bug: 714962 Change-Id: I14e724e06247c59e2f80a8a4db7dc1ef6e5433c7 Reviewed-on: https://chromium-review.googlesource.com/885542Reviewed-by:
-
Andrey Lushnikov authored
This patch introduces AutomappingBinding, that has additional information related to the automapping process. For now, the automappingBinding has only "exact" boolean flag. In future, AutomappingBinding will be created for both successful and failed bindings, surfacing binding errors. R=dgozman Bug=805740 Change-Id: I6245a8b26ae278635add9ef7a46e60886d59bd29 Reviewed-on: https://chromium-review.googlesource.com/884989 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531853}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/e99797e78121..62619cb4a9ae $ git log e99797e78..62619cb4a --date=short --no-merges --format='%ad %ae %s' 2018-01-23 sadrul tabs: Add a TBM metric for tab_switching. Created with: roll-dep src/third_party/catapult BUG=802104 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I0fc3060a5238dcb88de1069b738a0b58a70ceb5c Reviewed-on: https://chromium-review.googlesource.com/886181 Commit-Queue: <catapult-deps-roller@chromium.org> Reviewed-by: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531852}
-
dpapad authored
Also had to update paper-styles version 1.1.4 -> 1.3.1, and removed the deprecated and unused shadow-layout.html. Bug: 738611 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I43fc909502ac321e3a6a512ca6b00c93a98abab2 Reviewed-on: https://chromium-review.googlesource.com/882446Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#531851}
-
Takashi Sakamoto authored
This reverts commit 1f1519bd. Because this causes Mac Retina Debug bot failure, e.g. https://ci.chromium.org/buildbot/chromium.gpu/Mac%20Retina%20Debug%20%28AMD%29/18470 [18936:47619:0124/230505.322884:FATAL:feature_list.cc(328)] Check failed: CheckFeatureIdentity(feature). NetworkService 0 libbase.dylib 0x00000001029659be base::debug::StackTrace::StackTrace(unsigned long) + 174 1 libbase.dylib 0x0000000102965a7d base::debug::StackTrace::StackTrace(unsigned long) + 29 2 libbase.dylib 0x0000000102963efc base::debug::StackTrace::StackTrace() + 28 3 libbase.dylib 0x00000001029fd0ef logging::LogMessage::~LogMessage() + 479 4 libbase.dylib 0x00000001029fae25 logging::LogMessage::~LogMessage() + 21 5 libbase.dylib 0x000000010297598c base::FeatureList::IsFeatureEnabled(base::Feature const&) + 748 6 libbase.dylib 0x0000000102975687 base::FeatureList::IsEnabled(base::Feature const&) + 71 7 libcontent.dylib 0x000000011fb99e44 content::GetNetworkServiceImpl() + 180 8 libchrome_dll.dylib 0x0000000106dd0831 IOThread::ConstructSystemRequestContext() + 8257 9 libchrome_dll.dylib 0x0000000106dcce1a IOThread::Init() + 10666 10 libcontent.dylib 0x000000011ef901e6 content::BrowserThreadImpl::Init() + 854 11 libcontent.dylib 0x000000011ef8cfd7 content::BrowserProcessSubThread::Init() + 231 12 libbase.dylib 0x0000000102c5daa3 base::Thread::ThreadMain() + 2419 13 libbase.dylib 0x0000000102c350da base::(anonymous namespace)::ThreadFunc(void*) + 682 14 libsystem_pthread.dylib 0x00007fff924ed93b _pthread_body + 180 Change-Id: I72025f9801ac640627a4098073b448657f2deca2 Reviewed-on: https://chromium-review.googlesource.com/886163Reviewed-by:
Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#531850}
-
Max Morin authored
They will be moved to media in a future CL since they need to be used from the audio service. A side-effect of this CL is that logs from the SyncReader/Writer are prefixed with the stream_id, like other logs are. Bug: 803102 Change-Id: Iae2876033e4172066d5a0a3b1322092f870dc32d Reviewed-on: https://chromium-review.googlesource.com/878627Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#531849}
-
Naina Raisinghani authored
Bug: Change-Id: I5857b11ae92b7dabc24fce281d19c2a40854fe2c Reviewed-on: https://chromium-review.googlesource.com/885685 Commit-Queue: nainar <nainar@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#531848}
-
Keishi Hattori authored
This reverts commit 62bb75d3. Reason for revert: Decided we don't need this change Original change's description: > Oilpan: Rename to CrossThreadPersistentRegions > > Rename CrossThreadPersistentRegion to CrossThreadPersistentRegions as we will be adding a second PersistentRegion for weak persistents: > > BUG=757440 > > Change-Id: I751747470c5ddc1481270e181cdd1edcf9ae5291 > Reviewed-on: https://chromium-review.googlesource.com/882626 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531830} TBR=haraken@chromium.org,keishi@chromium.org,hpayer@chromium.org,mlippautz@chromium.org Change-Id: Ia1ac956e678dab92d6daab0852d0d9eafc3aa08a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 757440 Reviewed-on: https://chromium-review.googlesource.com/886162Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#531847}
-
Victor Costan authored
The interaction between ThreadCondition (condition variables) and recursive (a.k.a. re-entrant) mutexes is difficult to reason about. Details in the "Why can the holder of a Lock not reacquire it?" section of https://www.chromium.org/developers/lock-and-condition-variable Bug: 805814 Change-Id: Ie0b5e026a43768108011ca8f2f6fd3fe0e1f4b03 Reviewed-on: https://chromium-review.googlesource.com/885862 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/b6f7025955d6..be84b720c778 $ git log b6f702595..be84b720c --date=short --no-merges --format='%ad %ae %s' 2018-01-25 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 68981eb56..2e551f6bc (1 commit) 2018-01-24 reed compose and combine maskfilters 2018-01-24 scroggo Remove unused field/methods 2018-01-24 fmalita [skottie] Cache the last keyframe 2018-01-24 stani Revert "Increase depth threshold for SkClipStack::isRRect." 2018-01-24 fmalita [skottie] Animator scrubbing 2018-01-24 benjaminwagner [bazel] Add third_party to skia_all_hdrs 2018-01-24 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 01b21b194..68981eb56 (2 commits) 2018-01-09 mtklein Start of cross process SkScalerContext. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I838b444c69bf53a668abe9cf1fb54b2e79ef7256 Reviewed-on: https://chromium-review.googlesource.com/885861Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531845}
-
Takuto Ikuta authored
This is follow up of pool support in action https://codereview.chromium.org/2926013002 Using action pool can remove some overhead of many running process. Pool support of action_foreach gives better control for some python generator step when using goma. e.g. https://codereview.chromium.org/2726103005 Bug: 695864 Change-Id: Ibd0bbaffc59513db42119138520aee3505762eee Reviewed-on: https://chromium-review.googlesource.com/882625Reviewed-by:
-
Matt Falkenhagen authored
The non-PlzNavigate code path is no longer supported. R=shimazu Bug: 789577 Change-Id: Id0b61bd9042769d3afdcb78df6913632d833d831 Reviewed-on: https://chromium-review.googlesource.com/885687Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#531843}
-
Han Leon authored
BUG= Change-Id: I6b5b28230390de1f3b8a105c1f750fc394dfe923 Reviewed-on: https://chromium-review.googlesource.com/886004Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Yuta Kitamura authored
As of crrev.com/531516, all of the WTF counterparts of those base classes are now simple aliases to the base ones. Now, we can start using the base classes in Blink. Bug: 763980, 794845 Change-Id: Ica8d81549ed6d7fd4f56ed03d22562c973e8a00e Reviewed-on: https://chromium-review.googlesource.com/886041Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#531841}
-
Takuto Ikuta authored
rebase_path("//.") is resolved to the path like "$HOME/chromium/src". But it is necessary to be like "$HOME/chromium/src/out/Release" for higher cache hit rate when using goma. This patch allows us to share goma backend cache where we build in different out directory like out/feature_a and out/feature_b if compile requests has only difference of cwd and -fdebug-prefix-map flag. If we use same args.gn with linux_chromium_rel_ng, this patch allows us to use cached result generated by buildbot even if we do not clone chromium to path like '/b/c/b/linux/src/' and 'out/Release'. Note that some generated files having directive like `#include "out/Release/..."` is not normalized, but there is a few such tasks. Change-Id: I1232415aeedc98dc203e9d7582839bcc1cdbefc6 Reviewed-on: https://chromium-review.googlesource.com/882712 Commit-Queue: Takuto Ikuta <tikuta@google.com> Reviewed-by:Nico Weber <thakis@chromium.org> Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Cr-Commit-Position: refs/heads/master@{#531840}
-
Rakina Zata Amni authored
crrev.com/c/808446 is reverted because of failure in ASAN Buildbot Revert CL Link: crrev.com/c/880264 Failure link: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20ASAN/builds/8618 The failure is accessing *target_ancestor_iterator when it is out of bounds. Link: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/dom/TreeScope.cpp?q=Treescope.cpp&sq=package:chromium&rcl=dd944882a245a5117b50cb417138d92f32d931d6&l=393 as there were no bound checks for target_ancestor_iterator. It wasn't caught by layout tests because it's still returning the correct results, because it doesn't crash when getting *target_ancestor_iterator when it's out of bound. It just stops the while-loop and returned at https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/dom/TreeScope.cpp?q=Treescope.cpp&sq=package:chromium&rcl=dd944882a245a5117b50cb417138d92f32d931d6&l=398 Also, since the ASAN buildbot is not done before the CL is merged, this wasn't caught by trybots prior to committing. The fix is just adding a bound check for target_ancestor_riterator here: https://chromium-review.googlesource.com/c/chromium/src/+/880741/2..3/third_party/WebKit/Source/core/dom/TreeScope.cpp I have confirmed by using ASAN locally that it is fixed now. Before the fix, running the failing tests with ASAN build fails. Bug: 759947,805039 Change-Id: I9934af8131f285045e0eb80923f190b6d88cef7d Reviewed-on: https://chromium-review.googlesource.com/880741 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/adcf0ae6162d..2e551f6bc5f2 $ git log adcf0ae61..2e551f6bc --date=short --no-merges --format='%ad %ae %s' 2018-01-24 ynovikov Vulkan: Fix DebugReportCallback definition 2018-01-23 oetuaho Track parameter qualifiers of functions in call nodes 2018-01-23 ynovikov Vulkan: use supported composite alpha 2018-01-23 ynovikov Vulkan: get render target format from config 2018-01-24 lucferron Revert 3 files from previous merge 2018-01-23 lucferron Support correct validation for samplerParameterf with GL_TEXTURE_MAX_ANISOTROPY_EXT 2018-01-23 jmadill Vulkan: De-couple Program from VertexArrayVk dirtyiness. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I88519d7de8f6b8e9a4a8b4429db4363f676f5a99 Reviewed-on: https://chromium-review.googlesource.com/886002 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531838}
-
Xianzhu Wang authored
Setting descendants MayNeedPaintInvalidation() is not enough for invalidation of objects with fixed attachment background because they can't figure out the requirement during paint invalidation. We must invalidate them explicitly. The test (paint/overflow/fixed-background-scroll-in-frame.html) happened to succeed in SPv1 and fail in SPv175 because LocationInBacking of the target object changed in SPv1 but SPv175 doesn't use that. Bug: 805049 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9726715fc0e9ebb30b53ac59b7bad299a273d598 Reviewed-on: https://chromium-review.googlesource.com/884831Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#531837}
-
Megumi Hattori authored
This CL adds the paper plane icon as the reply button. The icon is placed to the right of the text field in the inline reply. In this CL, the name of NotificationInputMD is changed to NotificationInputTextfieldMD, and another container view, NotificationInputMD is added on top of NotificationInputTextfieldMD and NotificationInputReplyButtonMD. This CL does not include the following features. - Change the icon color when the textfield is clicked - Send message when the icon is clicked Bug: 803759 Change-Id: I20fe6455a8f3184d188d93892b1fc7c03764b1f4 Reviewed-on: https://chromium-review.googlesource.com/876182Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Megumi Hattori <megumihattori@google.com> Cr-Commit-Position: refs/heads/master@{#531836}
-
Takashi SAKAMOTO authored
- virtual/android/rootscroller/nested-rootscroller-browser-controls-bounds-shown.html, - virtual/android/url-bar/bottom-fixed-adjusted-when-showing-url-bar.html, and - virtual/threaded/animations/responsive/viewport-unit-translate-responsive.html TBR=joedow NOTRY=true Bug: 805794 Change-Id: Id7710e3d04f23d84ab289669c588f6c486803b71 Reviewed-on: https://chromium-review.googlesource.com/885667 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
-
Olga Sharonova authored
There is no need in a extra jump to IO thread, since AudioSystem can handle requests on UI one. Change-Id: Icb0413f1ec7af23254303824fe2da28734a79b1d Reviewed-on: https://chromium-review.googlesource.com/883128 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#531834}
-
Olga Sharonova authored
This is a spin-off from a WIP https://chromium-review.googlesource.com/c/chromium/src/+/875927 Bug: 792441 Change-Id: I1d6e256653fa7fa81dd6c6b23edd9be9446b0640 Reviewed-on: https://chromium-review.googlesource.com/883203Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#531833}
-
Koji Ishii authored
This patch rebaselines 23 image failures due to only text rendering differences in editing/selection and editing/unsupported-content. Tests to rebaseline are picked up by manual review. TBR=yosin@chromium.org, yoichio@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ib981d1312a1fed8274351daa74c6a5043046461f Reviewed-on: https://chromium-review.googlesource.com/885662Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Christian Fremerey authored
This reverts commit 2e8b1501. Reason for revert: Failing tests on webrtc bots, e.g. https://ci.chromium.org/buildbot/chromium.webrtc/Win10%20Tester/24669 Original change's description: > Reland: Win video capture: use IMFCaptureEngine for Media Foundation > > Fixes for reland number 5: > - "Win10 Tester" browser_tests_functional failure > - "Win8 Tester" browser_tests_functional failure > > Fixes for reland number 4: > - "Win10 Tester" browser_tests_functional failure > - "Win8 Tester" browser_tests_functional failure > - "Win8 Tester" capture_unittests failure > > Fixes for reland number 3: > - "Win10 Tester" browser_tests_functional failure > - "Win10 Tester" capture_unittests failure > - "Win8 Tester" browser_tests_functional failure > - "Win8 Tester" capture_unittests failure > > Fixes for reland number 2: > - "Win10 Tester" browser_tests_functional failure > - "Win10 Tester" capture_unittests failure > - "Win8 Tester" browser_tests_functional failure > - "Win8 Tester" capture_unittests failure > > Fixes for reland number 1: > - "Win8 Tester" browser_tests_functional failure > - "Win8 Tester" capture_unittests failure > > Original description: > - Full rewrite of the MediaFoundation implementation video part to use > IMFCaptureEngine > - Implementation of takePhoto, setPhotoOptions and getPhotoCapabilities > - takePhoto triggers a still image capture with the highest available > resolution without stopping the video stream thanks to IMFCaptureEngine > > TEST=adapted video_capture_device_unittest.cc and > webrtc_image_capture_browsertest.cc; launch Chrome with > --force-mediafoundation on Win8+ and capture video using > e.g. https://webrtc.github.io/samples/src/content/getusermedia/gum/ > > TBR=mcasas@chromium.org > > Bug: 730068 > Change-Id: If081d29402e9f595a3fd1906e45a3bec1d712b3a > Reviewed-on: https://chromium-review.googlesource.com/734042 > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Christian Fremerey <chfremer@chromium.org> > Cr-Original-Original-Original-Original-Original-Commit-Position: refs/heads/master@{#521435} > Reviewed-on: https://chromium-review.googlesource.com/810766 > Cr-Original-Original-Original-Original-Commit-Position: refs/heads/master@{#524417} > Reviewed-on: https://chromium-review.googlesource.com/843974 > Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#527139} > Reviewed-on: https://chromium-review.googlesource.com/852455 > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Original-Original-Commit-Position: refs/heads/master@{#528005} > Reviewed-on: https://chromium-review.googlesource.com/858138 > Cr-Original-Commit-Position: refs/heads/master@{#531109} > Reviewed-on: https://chromium-review.googlesource.com/880944 > Cr-Commit-Position: refs/heads/master@{#531791} TBR=mcasas@chromium.org,chfremer@chromium.org,alaoui.rda@gmail.com Change-Id: Idae6023d22c51e2df66687729ea0df5232c67fc6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 730068 Reviewed-on: https://chromium-review.googlesource.com/886081Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#531831}
-
Keishi Hattori authored
Rename CrossThreadPersistentRegion to CrossThreadPersistentRegions as we will be adding a second PersistentRegion for weak persistents: BUG=757440 Change-Id: I751747470c5ddc1481270e181cdd1edcf9ae5291 Reviewed-on: https://chromium-review.googlesource.com/882626Reviewed-by:
-
Yutaka Hirano authored
Some features defined in content/public/common/content_features.h prevented us moving files from content/network to services/network. This CL unblocks that by defining such features in services/network. Bug: 754918, 804769 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I378bef8d314003530019c9e4aab01bdb2f91a2b7 Reviewed-on: https://chromium-review.googlesource.com/874980 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Scott Violet authored
Classic ash doesn't do grabs when in unified mode. For compatibility this patch makes the window-service not execute a grab when in unified mode. To execute a grab leads to ash doing the wrong event conversion. BUG=804460,773348 TEST=covered by test Change-Id: I6d402ec4eb5d68946f98757cc4a56e850bd1e8b0 Reviewed-on: https://chromium-review.googlesource.com/884569 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#531828}
-
Yoshifumi Inoue authored
This patch expands |FindRightNonPseudoNodeInlineBox()| into the call site since it is used once to reduce source code size for improving code health. This patch is a follow-up of the patch[1]. The patch[2] does same thing for |FindLeftNonPseudoNodeInlineBox()| [1] http://crrev.com/c/882791 LineEndpointComputationMode to template parameter in StartPositionForLine() [2] http://crrev.com/c/885683 Expand FindLeftNonPseudoNodeInlineBox() into the call site in VisibleUnit.cpp Change-Id: I57ae8c462a3b76ee07f41f3cabd6579765ee1a20 Reviewed-on: https://chromium-review.googlesource.com/885663 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#531827}
-
