GitLab

This CL adds the MustRemainDisabled function to the ManagementPolicy::Provider
interface and calls it in appropriate places.

BUG=314276

Review URL: https://codereview.chromium.org/54903011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232976 0039d316-1c4b-4281-b951-d872f2087c98

to not set any of the output parameters unless all of them are valid.
Before we could set e.g. the session_id but return false.

BUG=315051
R=xians@chromium.org

Review URL: https://codereview.chromium.org/59763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232975 0039d316-1c4b-4281-b951-d872f2087c98

The mostly_smooth metric doesn't show up on the dashboard,
because it is a boolean value (False/True). Switch to float (0.0/1.0).

R=dtu@chromium.org
BUG=

Review URL: https://codereview.chromium.org/54793006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232974 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313168
TEST=RemoteDebuggingTest.RemoteDebugger

Review URL: https://codereview.chromium.org/54333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232973 0039d316-1c4b-4281-b951-d872f2087c98

This simplifies the compositor rate limiting code to only rate limit the
shared main thread context, which as it happens is the only context that uses
this feature at all.

BUG=181120

Review URL: https://codereview.chromium.org/53153006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232972 0039d316-1c4b-4281-b951-d872f2087c98

R=thakis@chromium.org
BUG=302284

Review URL: https://codereview.chromium.org/52823006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232971 0039d316-1c4b-4281-b951-d872f2087c98

Desired behavior: Clicking on a field or giving it focus via tab should
result in the validation error message coming up, if any.
Clicking on an already focused field should toggle autofill suggestions
with validation messages.
Leaving an input field with either a validation message or an autofill
suggestion should hide both.

The tricky part: distinguishing mouse clicks that would give focus, and
mouse clicks that are on a focused field. Since mouseDown: messages in
OSX are only sent to fields that already have firstResponder status,
this requires a bit of trickery - this CL exploits the fact that for an
NSTextField, the first click goes to the NSTextField, and subsequent
ones go to the field editor.

Bonus trickery: Rapid clicking on an NSTextField prevents the field
editor from taking over until the user has calmed down, so the code
filters only the first click after becomeFirstResponder.

R=rsesek@chromium.org
BUG=308156

Review URL: https://codereview.chromium.org/51933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232970 0039d316-1c4b-4281-b951-d872f2087c98

We're getting close to actually swapping RenderFrameHosts instead.

BUG=99379, 314791
TEST=none

Review URL: https://codereview.chromium.org/53153008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232969 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a bug where incognito split mode extensions were getting clicks from incognito browsers sent to the regular profile.

BUG=314142

Review URL: https://codereview.chromium.org/50433008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232968 0039d316-1c4b-4281-b951-d872f2087c98

R=arv@chromium.org
BUG=305742

Review URL: https://codereview.chromium.org/49903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232966 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232964 0039d316-1c4b-4281-b951-d872f2087c98

R=rmistry@google.com

Review URL: https://codereview.chromium.org/57433013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232963 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313848
TEST=views_examples_with_content_exe runs in Win Aura.
R=ben@chromium.org

Review URL: https://codereview.chromium.org/49533005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232962 0039d316-1c4b-4281-b951-d872f2087c98

In the guest mode, thumbnails were not loaded, because the token was unavailable, since Drive is disabled for the guest mode. Actually, the token is not necessary at all for local resources, therefore it should not be used.

This patch avoids fetching the token for local resources, what solves the problem.

TEST=Tested manually. Thumbnails work in the guest mode.
BUG=311212

Review URL: https://codereview.chromium.org/48553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232961 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a basic implementation of NativeViewport for X11. It puts a window
on screen and initializes GL for that window.

One disadvantage of this CL is that it requires use_aura to be set to 1 in
GYP_DEFINES.

R=ben@chromium.org

Review URL: https://codereview.chromium.org/48323005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232960 0039d316-1c4b-4281-b951-d872f2087c98

util.WaitFor polls which is not appropriate for PerformActionAndWaitForNavigate.

Since DispatchNotifications blocks in recv until it gets some data, there is no
need to poll at an interval. Instead, we should call recv again as soon as
possible after dispatching a notification.

In the case of the image decoding measurement, it runs timeline recording. There
were so many timeline messages to receive that we were not always getting to the
important Page.navigate message before timing out.

Example:
http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%281%29/builds/27098

BUG=314375

Review URL: https://codereview.chromium.org/47013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232959 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/46973005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232958 0039d316-1c4b-4281-b951-d872f2087c98

BUG=308535

Review URL: https://codereview.chromium.org/43793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232957 0039d316-1c4b-4281-b951-d872f2087c98

WebRTC is running the content_browsertests test
for ToT WebRTC revisions to track regressions on an
early stage. In order to save compile time and
build artifacts, we want to build only what's needed
(i.e. not the All target).
In https://codereview.chromium.org/27622005/ an
attempt was made to make content_browsertests_apk
to be enough of target to build (that CL made it also
build android_tools). Since that approach was having
bad sideffects, this helper target should give us
everything needed for our build.

NOTRY=True
TEST=local compile, verifying the apk and host_forwarder is built.
BUG=305749

Review URL: https://codereview.chromium.org/43463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232956 0039d316-1c4b-4281-b951-d872f2087c98

Reusing the details of the GetNumDisplays() implementation for returning
a vector of available displays. Reusing the existing code for actually
generating gfx::Display objects by converting to NSScreen and then
calling GetDisplayForScreen to be consistent with the behavior in other
parts of this file.

BUG=311132
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/40163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232955 0039d316-1c4b-4281-b951-d872f2087c98

There's a size regression for the Linux bot in
http://build.chromium.org/p/chromium/builders/Linux/builds/44555

PERF_REGRESS: nacl_helper/nacl_helper (0.29%), nacl_helper/nacl_helper (0.29%)

Details:
https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux&tests=sizes%2Fnacl_helper&rev=232942&checked=core
(requires google.com signin).

TEST=none
BUG=315063
R=phoglund@chromium.org, phoglund@google.com

Review URL: https://codereview.chromium.org/59723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232954 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314848

Review URL: https://codereview.chromium.org/54993008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232951 0039d316-1c4b-4281-b951-d872f2087c98

Removed unused enum value.

BUG=314284
NOTRY=true
TBR=noamsml

Review URL: https://codereview.chromium.org/59083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232950 0039d316-1c4b-4281-b951-d872f2087c98

This has some performance optimzations, and adds some new functionality. It
also adds some function documentation.

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/58573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232949 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=314627

Review URL: https://codereview.chromium.org/58593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232948 0039d316-1c4b-4281-b951-d872f2087c98

BUG=298967

Review URL: https://codereview.chromium.org/58583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232947 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313301
TEST=WindowTest.StackWindowAtBottomBelowWindowWhoseLayerHasNoDelegate

Review URL: https://codereview.chromium.org/58343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232946 0039d316-1c4b-4281-b951-d872f2087c98

When SafeBrowsing detects that a download is malicious, the user is only
presented with a 'Dismiss' option. Additional options ('Learn more' and
optionally 'Report', if applicable) are available from a context menu.

This behavior has been available on the Windows build. This change
brings the Mac UI up to parity.

XIB Changes (DownloadItem.xib):
* Add new controls for malicious downloads:
  * New GTMWidthBasedTweaker for managing the size of 'Dismiss' button
    connected to maliciousButtonTweaker: IBOutlet.
  * New 'Dismiss' push button connected to dismissMaliciousDownload:
    IBAction.
  * New disclosure button connected to showContextMenu: IBAction.
* Change connection for GTMWidthBasedTweaker containing 'Discard' button
  to dangerousButtonTweaker: IBOutlet.
* Anchor WidthBasedTweakers on the left instead of the right since the
  code assumes that the tweakers don't shift horizontally when the
  embedded buttons change size.
* Change height of Insecure Download NSBox to match the height of the
  DownloadItemButton.
* Adjust position of buttons for both dangerous and malicious downloads
  so that they are centered in the download shelf.

BUG=235931
TEST=(1) Download something from a URL that is identified by SafeBrowsing
         as malicious.
     (2) Check that the download shelf displays a warning indicating that
         the download was malicious and that it was blocked. There should
         only be a "Dismiss" button and a disclosure button.
     (3) Click on the disclosure button. It should display a menu with a
         'Learn more' item. Clicking on that item should open the
         SafeBrowsing help center article.
     (4) Click on the 'Dismiss' button. The warning should go away. If it
         was the only download, the shelf should also disappear.
     (5) Open chrome://downloads. The download should still be here with
         a 'Recover' option and a 'Remove' option.

Original Review URL: https://codereview.chromium.org/40733005/

Review URL: https://codereview.chromium.org/57963005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232945 0039d316-1c4b-4281-b951-d872f2087c98

command_buffer was historically included in nacl-compiled things, and base
wasn't.  These days, base is included in nacl-compiled things too, so the
duplication can be removed.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/57583008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232944 0039d316-1c4b-4281-b951-d872f2087c98

There was a change in BubbleBorder (https://codereview.chromium.org/53703002) that removed the 10px insets on the border, so we no longer need to compensate for them.

BUG=NONE
TEST=With --new-profile-management enabled, click on the avatar button.
The bubble should show up just below it.

Review URL: https://codereview.chromium.org/57513004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232943 0039d316-1c4b-4281-b951-d872f2087c98

The use of gfx::TextStyle enum is deprecated, thus we should use the constant
from gfx::Font::FontStyle.

BUG=None
TEST=None
R=pkasting@chromium.org,msw@chromium.org

Review URL: https://codereview.chromium.org/57373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232942 0039d316-1c4b-4281-b951-d872f2087c98

BUG=277149

Review URL: https://codereview.chromium.org/57103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232941 0039d316-1c4b-4281-b951-d872f2087c98

TBR=finnur

BUG=307651

Review URL: https://codereview.chromium.org/56973008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232940 0039d316-1c4b-4281-b951-d872f2087c98

BUG=308153

Review URL: https://codereview.chromium.org/56143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232939 0039d316-1c4b-4281-b951-d872f2087c98

File name the same as in chrome/common/cloud_print/ failed some VS builds.

NOTRY=true

Review URL: https://codereview.chromium.org/55143012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232937 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/53313005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232936 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232935 0039d316-1c4b-4281-b951-d872f2087c98

gesture.config_is_truthworthy is a temporary pref used to do a one-time
wipe of gesture prefs. Now, in order to remove it, we first need to
clear it from users' Preferences file. Next step would be to remove it
completely from code.

BUG=269292

Review URL: https://codereview.chromium.org/52363006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232934 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r12322: (dschuff) Build binutils with toolchain_build.py infrastructure
r12323: (stichnot) Add a --retries=<N> flag, for flaky test environments.
r12324: (dschuff) Add gyp_nacl.py to make gyp_nacl importable on python 2.6
r12325: (bradnelson) Incorporate gcc version string into toolchain_build platform string.
r12326: (mseaborn) PNaCl: Update LLVM revision in pnacl/DEPS for SJLJ EH change
r12327: (dschuff) Revert "Build binutils with toolchain_build.py infrastructure"
r12328: (mseaborn) PNaCl: Update GCC revision in pnacl/DEPS for SJLJ EH change
r12329: (bsy) hook up pwrite/pread syscalls.  untrusted pwrite/pread test.
r12330: (sehr) Remove combreloc from configuration, to avoid an assertion failure in the dynamic loader
r12331: (jfb) Allow SPEC2k to be run unsandboxed with LLVM.
r12332: (stichnot) Update llvm_test_suite DEPS to get improved testsuite.
r12333: (sehr) Change build to use new binutils
r12334: (dschuff) Port PNaCl x86 main waterfall buildbots to buildbot_lib
r12335: (dschuff) Fix bot breakage in r12334 and remove obsolete PNaCl bots from buildbot_selector.py
r12336: (dschuff) Build binutils with toolchain_build.py infrastructure
r12337: (dschuff) Set some default configuration values in buildbot_lib's Context ctor
r12338: (dschuff) Use new format for PNaCl component revisions.
r12339: (dschuff) PNaCl FYI bot script: explicitly setup newlib nacl headers
r12340: (dschuff) Update TOOL_REVISIONS for PNaCl 12274->12331
r12341: (stichnot) Remove two ARM known failures.
r12342: (mark) Run strip via xcrun.
r12343: (mseaborn) pnacl-translate: Remove "-shared" and "-static" options
r12344: (dschuff) Remove obsolete bots from buildbot_selector.py
r12345: (dschuff) Fix buildbot_selector.py's disabling of gyp builds on some bots
r12346: (mseaborn) PNaCl: Add script for updating the Git revisions in pnacl/COMPONENT_REVISIONS
r12347: (dschuff) Fix pnacl COMPONENT_REVISIONS to match what was in DEPS in r12337
r12348: (mseaborn) PNaCl: Remove some tests' uses of "-nostdlib" in TRANSLATEFLAGS
r12349: (mcgrathr) Update binutils revision in tools/REVISIONS
r12350: (mseaborn) pnacl-ld: Remove "-shared" option and make "-rpath-link" a no-op
r12351: (mseaborn) PNaCl: Remove unused file, pnacl/scripts/libgcc-glibc.mvars
r12352: (mseaborn) pnacl-clang: Remove "-shared" and "-dynamic" options

BUG=none
TEST=browser_tests and nacl_integration

Review URL: https://codereview.chromium.org/45763005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232933 0039d316-1c4b-4281-b951-d872f2087c98

This improves decode performance of VP9 input encoded with tiling enabled.  Each 
tile must be at least 256 pixels wide. The number of tile columns are log2. So encoded
files can have 1, 2, 4, 8, 16 tile columns. E.g. 1920x1080 files can have up to 4
encoded tile columns. Tile rows do not matter for decode performance.

Specifically, any system with multiple cores and/or hyper threading will
benefit from this change.

On desktop 1080p decode speed is roughly 1.5-2x with this change. For example, 
on the low end of the results from the test set used to produce these numbers 
an average increase is from 82 frames/second to 163 frames/second.

This holds on Android devices as well, with the same clip on a Nexus 7 going
from 14 frames/second to 25. Chrome OS shows similar gains. This puts some 1080p 
in the playable range and gives 720p more clearance.

Review URL: https://codereview.chromium.org/55213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232932 0039d316-1c4b-4281-b951-d872f2087c98