- 18 Mar, 2020 40 commits
-
-
Lukasz Anforowicz authored
This CL makes sure that reports of bad mojo messages are preserving the callstack and the crash keys. This is done by making sure that DumpWithoutCrashing is called synchronously from BrowserChildProcessHostImpl::OnMojoError. The CL also opportunitically reduces code duplication related to actually terminating a child process. The duplicated code is extracted into a new TerminateProcessForBadMessage private method and reused both from OnMojoError and from TerminateOnBadMessageReceived. Bug: 1062418 Change-Id: I8f5bf802e9aabec4d92ee9fd37c1c55012f1250f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106806Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#751478}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/38a7906eeb00..855b1a3f2a02 Created with: gclient setdep -r src-internal@855b1a3f2a02 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1062609 Tbr: jbudorick@google.com Change-Id: If0e8c741c8cb11d78a9a184765d8ab1d70e76b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108676Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751477}
-
Siddharth Sharma authored
Issue: The base::SplitStringUsingSubstr does not handle the case when the delimiter is empty. The code goes into an infinite loop in that case as begin_index and end_index always stay 0 and we keep on adding empty string pieces to the result. This causes a memory overflow. Fix: This change adds a check for the delimiter size and returns the original input string if the size is 0. Bug: 1062612 Change-Id: I29c184bf18df1bcc50fdb6205a7ff5fa6920148b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108213 Commit-Queue: Siddharth Sharma <siddhash@microsoft.com> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#751476}
-
yilkal authored
This Cl corrects an issue where WebTimeLimitEnforcer is not notified when time limit is reached. This happens at the beginning of the session. Bug: 1062012 Change-Id: I7a14e618dbd5b74b5adcaa1c588d64aea088533c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105619 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#751475}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0609f5a4e533..3b0c540211ca git log 0609f5a4e533..3b0c540211ca --date=short --first-parent --format='%ad %ae %s' 2020-03-18 szuend@chromium.org Rename front_end/protocol to front_end/protocol_client 2020-03-18 tvanderlippe@chromium.org Add filesystem TypeScript types 2020-03-18 kahinds@microsoft.com High contrast support for Animation Panel 2020-03-18 szuend@chromium.org Enable asynchronous rawLocationToUILocation mapping Created with: gclient setdep -r src/third_party/devtools-frontend/src@3b0c540211ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1032016,chromium:1048378 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6469f3339aee3b5f6d069c0f01e351126a53a941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108882Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751474}
-
Reilly Grant authored
This change fixes all of the wake lock tests in WPT by making two major changes. 1) Grant wake lock permission at the beginning of the test using the new set_permission method on test_runner. 2) Hook up the Mojo interface binder for the wake lock service in dedicated worker contexts. Bug: 257511 Change-Id: I136a2f90bc0c595a35ba707b5ab5200b4c42281a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089966 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#751473}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I1deeceaaeb1013d42504fe7054143ff044fce4ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108618 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#751472}
-
David Roger authored
This CL introduces new metrics about profile representation state that get recorded on session start: - Profile.State.Avatar - Profile.State.LastUsed - Profile.State.Name - Profile.State.UnconsentedPrimaryAccountType all with 6 suffixes that zoom into particular subpopulations of users. TBR=alexilin Bug: 1060113 Change-Id: Id428015fbed9cb473822a4b19fbd7710bd5707ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102656Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#751471}
-
Lukasz Anforowicz authored
This reverts commit 0724e945. Reason for revert: https://crbug.com/1056949 (RBS) and https://crbug.com/1059218 Original change's description: > |request_initiator_site_lock| enforcement - attempt #2. > > This CL starts treating |request_initiator| that doesn't match > |request_initiator_site_lock| as a bad IPC message and ignoring such > malformed resource requests. > > NetworkService.URLLoader.RequestInitiatorOriginLockCompatibility UMA is > non-zero in recent Canary releases. Therefore it is possible > that this CL will get reverted after gathering sufficient number of > DumpWithoutCrashing reports to understand why the lock doesn't match the > initiator in some real world scenarios. > > Bug: 920634 > Change-Id: If4fbdb6336703f53784c036ca5d9e408ff223d78 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006113 > Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#739359} TBR=yhirano@chromium.org,lukasza@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 920634 Change-Id: Ief1019a74abf8e70364ad2f6aadc2d2216488910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108783Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#751470}
-
Ben Joyce authored
Build.gn file was locally modified. This restores cursoradapter, customview, coordinatorlayout, swiperefreshlayout, viewpager, gridlayout, transition, leanback, and preference_leanback Bug: 1052460 Change-Id: Ibe8b1612b1d1b3af83784ff49cbacbbccc811e5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108900 Commit-Queue: benjamin joyce <bjoyce@google.com> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: benjamin joyce <bjoyce@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#751469}
-
Toni Barzic authored
This is a reland of 57098dce Original change was crashing asan tests because drag handle was trying to remove itself from overview controller observers in it's destructor during shell shutdown, and it was getting destructed after the overview controller. This adds a shell observer, and resets the overview observer sooner, when the shell destruction begins. Original change's description: > Better coordinate swipe to home gesture and drag handle nudge > > Manages the drag handle nudge during window drag from shelf to home or > overview (which may end up in a gesture the nudge is describing). > > If the contextual nudge is shown when the window drag starts, the nudge > will not be hidden until the gesture completes (end it will get hidden > when the gesture completes, even if the user does not end up going > home). > > If the contextual nudge is scheduled to be shown when the gesture > starts, the show request will be canceled. > > Adds logic that prevents drag handle nudge from showing up, unless it's > a result of an explicit user action - tapping the drag handle. > > BUG=1058617 > > Change-Id: I96fa2748308143ec42295dbfb472dc564da5bd03 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107135 > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Reviewed-by: Manu Cornet <manucornet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751200} Bug: 1058617 Change-Id: I80222105bda946113248f17a93758cec20387ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108629 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#751468}
-
Andrew Grieve authored
This reverts commit 55ab173a. Reason for revert: Suspect breaking coverage bots: https://bugs.chromium.org/p/chromium/issues/detail?id=1062704 Original change's description: > Android: Use turbine to generate java headers > > See go/faster-javac for a detailed analysis of why turbine was chosen to > speed up our java builds. The current implementation is an initial > implementation that can be further optimized. It already gives savings > of 10-30% of our java incremental builds depending on the target in > question (see go/project-turbo for timing details). > > This implementation does remove some of the benefits of the previous way > that java_library_impl was implemented, namely when a target's > .interface.jar file changes, it no longer short-circuits dependent > targets from being built since we now use group(target_name). This is > arguably more correct as prebuilts depend on javac jars directly. In the > future (after the androidx migration and other build improvements) this > can be improved by having prebuilts depend on the interface jars > instead. > > Bug: 1056299 > Change-Id: I49d18604203749cf447ce77c54a8f8469c83eae1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105415 > Commit-Queue: Peter Wen <wnwen@chromium.org> > Auto-Submit: Peter Wen <wnwen@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750651} TBR=wnwen@chromium.org,agrieve@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1056299, 1062704 Change-Id: Ib3ad0b0a40a25c949775fdef786ad6d776c2c684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108791Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6325afac..e14702b1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iad718f62c6a0416131aa8eaafb497f05e7e6b5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108840Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751466}
-
Scott Violet authored
This fixs a number of cases and enables strict mode in tests. Hopefully that helps prevent any other access from being added. The trickier cases are jacoco injects code that accesses the disk, and LayoutInflater may trigger loading classes, which triggers disk access. The addition since first patch is SelectFileDialog may trigger reading from disk. That file has been updated. BUG=1059770,1062561 TEST=covered by tests now Change-Id: Ie8262ae4e018055049115fcefc6a29bf97acbe9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108603Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#751465}
-
Mark Brand authored
This is a reland of 96b8d308 Original change's description: > Adding mojolpm fuzzer. > > This adds code that generates libprotobuf-mutator based > structure-aware fuzzers as part of the mojom compilation process. > (changes in //mojo). > > It also adds a fuzzer for CodeCacheHost using this framework to demonstrate > how it will be used, and documentation explaining that fuzzer and how to use > this generator to write new fuzzers. (changes in //content/test). > > It finally includes a few changes to typemap and traits files that > were necessary to smooth over some inconsistencies in existing code > using mojo. > > Bug: 941849 > Change-Id: I660a57bd90c0963bd9a0b8608c746cdb767edc98 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978739 > Commit-Queue: Mark Brand <markbrand@google.com> > Auto-Submit: Mark Brand <markbrand@google.com> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Ted Meyer <tmathmeyer@chromium.org> > Reviewed-by: Oliver Chang <ochang@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#746827} Bug: 941849 Change-Id: I01feb96401e1c9cbd3bbb2bf2a22ecc253d36b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087408 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#751464}
-
Saurabh Nijhara authored
This CL adds the following network handling for the update required screen :- 1) Metered(cellular) network at the start - Show dialog to connect to a non metered network or accept update over metered. If good network is connected, update starts. If accepted to update, update starts. 2) No network at the start - User is prompted to connect to a network. When connected to a good network, update starts. 3) Good connection is lost and metered connected while updating - User prompted to accept update over metered. If accepted, update starts. We register for the network updates only up to starting the update process. Post that, the network changes are reflected in the update engine result and thus, handled for there. Bug: 1048607 Change-Id: I50d939c0152f76f4456830cdd5e07136819b91a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091534 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#751463}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/95185d920a0b..1ccecb74b36f git log 95185d920a0b..1ccecb74b36f --date=short --first-parent --format='%ad %ae %s' 2020-03-18 dgkoch@users.noreply.github.com Remove NV_EXTENSIONS conditionals (#1003) Created with: gclient setdep -r src/third_party/shaderc/src@1ccecb74b36f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I72a25171087b1a6198f7fdaecbfe878aff428536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108673Reviewed-by:
-
Andrew Grieve authored
This fixes java_deobfuscate.py not working when run under swarming. Bug: 995290 Change-Id: I29a30852f7d5e0f0039b61707dc5995edd076d09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107063 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#751461}
-
Mustaq Ahmed authored
We are no longer pursuing the activation transfer idea. Bug: 928838, 951453 Change-Id: I81844e1fdda740414c7252ef50619fcf1ab15450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106966 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#751460}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1850bf6d1781..5a644f827636 git log 1850bf6d1781..5a644f827636 --date=short --first-parent --format='%ad %ae %s' 2020-03-18 ehmaldonado@google.com Reland "git-cl: Refactor CMDUploadChange" Created with: gclient setdep -r src/third_party/depot_tools@5a644f827636 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I523622e87432335587f4a3c141104add877dae14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108677Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f368dcbb7d8a..3bf1dab23d9a git log f368dcbb7d8a..3bf1dab23d9a --date=short --first-parent --format='%ad %ae %s' 2020-03-18 johnkslang@users.noreply.github.com Merge pull request #2135 from alelenv/rt_shaderlang_enums 2020-03-18 cepheus@frii.com Fix #2132: constant matrix constructor from single non-scalar argument 2020-03-18 cepheus@frii.com Bump version (also fix line endings the grammar). 2020-03-18 johnkslang@users.noreply.github.com Merge pull request #2130 from dgkoch/EXT_ray_tracing Created with: gclient setdep -r src/third_party/glslang/src@3bf1dab23d9a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: Ie078a26e5a316baba33bce13b7817ed20cdecf07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108674Reviewed-by:
-
Travis Skare authored
No functional changes. Added some if-change-then-change in another location. Change-Id: I4a116bb506f5f8830905381e3b687b9d6ed13456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108637Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#751457}
-
Theresa Wellington authored
Move favicons/ out of //chrome/android/ to its own build target. BUG=1060030 Change-Id: Ic09f5ef6ee9450212b2a2196927c2f472fa25b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096101 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#751456}
-
Richard Townsend authored
Our Windows on Arm testing setup relies on using GN to extract the runtime_deps of each test suite. Adding testdata ensures that it's appropriately packaged. All tests pass once this is added. Change-Id: I239fd4b3ec4c044cdc7f40070d45e5155e278217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107554Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#751455}
-
Danyao Wang authored
InstallablePaymentAppCrawler stores a RenderFrameHost raw pointer and uses it in asynchronously when DownloadAndDecodeWebAppIcon() is run as a callback for downloading the web app manifest. This creates a possible use-after-free situation. This CL applies a limited fix: the RenderFrameHost* is converted to its GlobalFrameRoutingId to be stored inside InstallablePaymentAppCrawler. A better fix is to use WeakPtr<RenderFrameHost> everywhere in payments code. However, this requires changing the content public API to expose a RenderFrameHost::GetWeakPtr() method. Since this CL is intended to be merged to M82, this more risky work is left as a followup for crbug.com/1058840. The instantiation of InstallablePaymentAppCrawler happens synchronously with the instantiation of PaymentRequest, the risk of use-after-free as a result of PaymentRequest's storage of RenderFrameHost* is small. Bug: 1061110 Change-Id: I1428c6006201834ee341dd4546bd297116a5f380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106387Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#751454}
-
Ken Rockot authored
Bug: 1059389 Change-Id: I8989970d5f39444a615bd84267aea7e8641caa65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108607Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#751453}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6798043d95ac..ebf739be7bab git log 6798043d95ac..ebf739be7bab --date=short --first-parent --format='%ad %ae %s' 2020-03-18 yura.yaroshevich@gmail.com Reland "Leverage dispatch_queue_create_with_target when possible." 2020-03-18 eshr@google.com NiceMock MockFecController in VideoStreamEncoderUnittests Created with: gclient setdep -r src/third_party/webrtc@ebf739be7bab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibb4072d61e15cb56d7600258eac58a2a8d7afb88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108670Reviewed-by:
-
Ken Rockot authored
Bug: 1059389 Change-Id: If88f7f5463389791c162801d10944f61a10c70b3 Test: Build compiles with no source changes, so same typemap config as before Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108123Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#751451}
-
Matt Jones authored
This patch fixes a subtle bug in the BottomSheetController where a custom scrim lifecycle inadvertently blocked high priority content from suppressing low priority content. The block of code no longer returns early, each scrim and sheet check are now gated on BottomSheetContent's #hasCustomScrimLifecycle and #hasCustomLifecycle respectively. Bug: 986310 Change-Id: I506874b0f8d63e5d00177b409a71b92a51cfb454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779103 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#751450}
-
Ken Rockot authored
This removes the recently introduced `mojom_cpp_typemap` GN template in favor of simply inlining typemap configs directly within the `mojom` target they affect. A few motivations here: - The separate target approach required traits sources to always belong to a different target than the mojom variant's own sources. This has insurmountable dependency issues in some corner cases like //content/common. - A typemap can only realistically affect a single mojom target in the build under most circumstances. - A significant portion of the variables within a typemap target were only used by forwarding them to the affected mojom target. Inlining everything makes the direct impact on the mojom target more clear. - This approach is exactly as powerful (from the perspective of build expressiveness) as typemap files, but without the typemap files. Bug: 1059389 Change-Id: I8218312374e86a0c02dcaea630b05f61c7aa6d61 Tbr: changwan@chromium.org Tbr: haraken@chromium.org Tbr: dcheng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106887 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#751449}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6dc9227c44d95547703233a276b507bb26affdff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108675Reviewed-by:
-
Matt Menard authored
Bug: 1058453 Change-Id: I7b3a610777ac70a7136045585036e4f714217cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085874 Commit-Queue: Matt Menard <mattme@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#751447}
-
Becca Hughes authored
Store the protobuf fields from the design doc in the Media History database and convert them to/from mojo. BUG=1057765 Binary-Size: Increase is unavoidable Change-Id: Ic909459ce13aaa3ca2ebc8b9c17e837c105170f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106351 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
-
Mitsuru Oshima authored
Handle the edge case correctly to match ppi spec. Added test to verify. Bug: none Change-Id: Ia32dc88d535446a593131a6237b6bbd47ed6edd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107237Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#751445}
-
Ian Kilpatrick authored
This is in preparation of moving the caching of intrinsic logical widths instead of preferred logical widths. There should be no other behaviour changes. Bug: 845235 Change-Id: Ib065f5e01a2ef81d5c3d0a15f2112b5cb5217811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104429Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#751444}
-
Mustafa Emre Acer authored
This is the markdown version of https://www.chromium.org/developers/design-documents/idn-in-google-chrome with cleanups and "Other Browsers" section removed. That section will need to be rewritten. Change-Id: Ib7079412a6fcad91bfe963147e113788570e3265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108084 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#751443}
-
Xiaocheng Hu authored
This patch introduces a new Font constructor, so that Font can set its FontSelector during construction, instead of setting it later with the deprecated Update() function. Bug: 1049295 Change-Id: I6255ec14da7c3822ecfc9decd0fbf92322f2ccbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107687 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#751442}
-
manuk authored
*Rich autocompletion background* Currently, autocompletion is limited to when the user types a prefix of the URL; if the user omits the beginning of the URL or includes parts from the title, then the suggestion won’t be autocompleted. This is problematic because hindering the user when they recall some part other than the the exact URL prefix conflicts with the omnibox’s goal of helping users navigate to desired destinations. This feature will allow autocompletion even when the input is from the suggestion title or not a hostname prefix. Design doc with further details: go/richomniboxautocompletion *This CL* Adds a flag & 4 params which are unused at the moment, but will be used by follow up CL's. The work is being split up for easier review. The intention of the params are: 1. Autocomplete titles. Currently, suggestions can only be autocompleted if the inputs match the URLs. With this param, suggestions will also be autocompleted if their title matches input. In this case, the suggestion URL will also be shown in order to differentiate them from search suggestions. Typically, the URL will shown surrounded with `()` following the title; i.e. `title (URL)`. If the 'two line omnibox' param is also enabled, the URL will be displayed below the title. 2. Autocomplete non-prefixes. Currently, suggestions can only be autocompleted if the input is a prefix of the URL. With this param, suggestions will be autocmopleted if the input matches anywhere in the URL (or title if 'autocomplete titles' is also enabled). 3. Show titles. Currently, navigation suggestions display only their URLs in the omnibox. With this param, the titles will also be displayed. This helps add parity to the UI regardless of whether the input matches a title or URL since, otherwise, a URL matching input would display only the URL, while a title matching input would display both. For URL matching inputs, titles will be displayed surrounded with `()` following the URL; i.e. `URL (title)`. If the 'two line omnibox' param is also enabled, the title will be displayed below the URL. 4. Two line omnibox. Currently, the omnibox displays 1 line; this is sufficient for displaying the URL. With this param, the omnibox incresaes its height to fit 2 lines. This helps when displaying both the title and URL of a suggestion. If the 'show titles' param is disabled and the input does not match a title, the 2nd line will be unused since only the URL will be displayed. I plan to avoid this combination in finch experiments. Change-Id: If3b0acd403acd72986a929506ba5b7253a991396 Bug: 1062446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107796 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
-
Abigail Klein authored
This reverts commit 9bd21621. Reason for revert: Caused fuzzer bugs crbug.com/1061370 and crbug.com/1061332 which are not trivial to fix. This patch landed in M82 and so the revert will need to be cherry-picked into that build. Original change's description: > [Live Caption] Introduce a new elide behavior TRUNCATE_HEAD. > > Introduce a new elide behavior TRUNCATE_HEAD in which multiline text in > a label is truncated at the beginning of the string. This will be used > to display the last two lines of captions for the live caption feature. > Captions received from the captioning service may be longer than two > lines. So, the determination of what the last two lines to be shown > should happen during the displaying of the text in the label. > > Bug: 1055150 > Change-Id: If3c447ac50c29a3e2f7467af9ceeb668fcd01ebf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090501 > Commit-Queue: Abigail Klein <abigailbklein@google.com> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749542} TBR=ellyjones@chromium.org,avi@chromium.org,robliao@chromium.org,etienneb@google.com,abigailbklein@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1055150 Change-Id: I816ce786b95f24f586c0032c508559d588994687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106313Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#751440}
-
Aaron Leventhal authored
Accessible objects styled with display:none are supposed to be exposed when they have an id. However, this currently only works if the display:none style targets the element directly. It also needs to work if the display:none targets an ancestor. This is also a necessary precursor to https://chromium-review.googlesource.com/c/chromium/src/+/2090736 Bug: 651614 Change-Id: I789cda53f303ddfc3304f6109102b71090619aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095880 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Cr-Commit-Position: refs/heads/master@{#751439}
-
