- 20 Jun, 2018 40 commits
-
-
Theresa authored
Move most code controlling the search provider logo, fake search box, bookmarks/downloads shortcuts, and most likely tiles from NewTabPageView to NewTabPageLayout. These views are all children of NewTabPageLayout, so organizationally it makes more sense for NewTabPageLayout to own and control them. This is a step toward making NewTabPageLayout re-usable for the FeedNewTabPage. There will be additional work to finish cleaning up and refactoring NewTabPageView and NewTabPageLayout to bring them closer to the new MVC architecture. BUG=827334 Change-Id: Ia08a0f9636ee7919fea2582c7b15fb9a57ed28bf Reviewed-on: https://chromium-review.googlesource.com/1103388Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#568855}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1cabdc464313..49083eaa9300 git log 1cabdc464313..49083eaa9300 --date=short --no-merges --format='%ad %ae %s' 2018-06-20 vapier@chromium.org pylint: update to 1.4.5 Created with: gclient setdep -r src/third_party/depot_tools@49083eaa9300 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=agable@chromium.org Change-Id: I25691eba67aba0610b1fbf02545bc3b4cba06881 Reviewed-on: https://chromium-review.googlesource.com/1108017Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568854}
-
David Roger authored
IsAccountConsistencyMirrorEnabled is deprecated, because Mirror can now be enabled on a per-profile bases. This CL replaces the calls by the new API (AccountConsistencyModeManager) and cleans up unnecessary calls. TBR=sky Bug: 777774 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I19e9ecc779b90911f6e4e63a11850417c9eddbdf Reviewed-on: https://chromium-review.googlesource.com/1104682 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#568853}
-
Gauthier Ambard authored
This CL changes the toolbar so when the location bar is focused in iPhone landscape, the cancel button is shown, as it is done in portrait. Bug: 847847 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I351d166e52d80975579bf6c74fd44230543b4ce1 Reviewed-on: https://chromium-review.googlesource.com/1107634 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568852}
-
Makoto Shimazu authored
PaintTiming.NavigationToFirstPaint is one of key loading metrics, and we'd add it before starting ServceWorkerServicification (a.k.a NetS13nServiceWorker) experiement. Bug: 852698 Change-Id: I2d7b7ad9ef3df94d428e1fbcbc1148de27e45c6a Reviewed-on: https://chromium-review.googlesource.com/1107418Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#568851}
-
Alexander Hendrich authored
This CL adds a list attribute 'BlacklistedHexSSIDs' to ONC's global configuration. This attribute can be used to block connections to certain WiFi SSIDs. Current connections to blacklisted networks are disconnected, once the policy is applied. This policy is only enforced in Chrome. However, by disabling auto-connect for all blacklisted networks, we can prevent Shill from re-connecting to those networks while searching for the best network to connect. DesignDoc: http://go/cros-blacklist-ssids Bug: 837205 Change-Id: I1d80929a00dd042db7aef877d663febc3f170d05 Reviewed-on: https://chromium-review.googlesource.com/1091053 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#568850}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e005dc33c31a..b6e0117285a9 git log e005dc33c31a..b6e0117285a9 --date=short --no-merges --format='%ad %ae %s' 2018-06-20 rharrison@chromium.org Add in a size guard to JPX fuzzer Created with: gclient setdep -r src/third_party/pdfium@b6e0117285a9 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:834561 TBR=dsinclair@chromium.org Change-Id: I4ac1250c2e205994b6594b5a06bb34e6bd07e7fc Reviewed-on: https://chromium-review.googlesource.com/1107938Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568849}
-
Peng Huang authored
Bug: 848388, 850745 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I6bacef1ca791ff7e00769258f3bce99ef4954b59 Reviewed-on: https://chromium-review.googlesource.com/1106614Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#568848}
-
Matt Menke authored
Accidentally left in a line of the old setup in https://chromium-review.googlesource.com/1089661. It's harmless, but not needed any more. Bug: 837354 Change-Id: Ic7a01e407d8666b2eede34d65a7186f212d1fddb Reviewed-on: https://chromium-review.googlesource.com/1106008Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#568847}
-
anthonyvd authored
This reverts commit d201cbeb. Reason for revert: FindIt identified this CL as the culprit for several failures: crbug.com/854600 Original change's description: > Run some file manager browsertests with DriveFS enabled. > > Bug: 848126 > Change-Id: Ifd3cf1996fdb33f5d0d93f5c5cf721abd5440d29 > Reviewed-on: https://chromium-review.googlesource.com/1102279 > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Sam McNally <sammc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568339} TBR=noel@chromium.org,sammc@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 848126 Change-Id: Ifc9b0a77c76ba647bd5a85102b286fd5b2d1073f Reviewed-on: https://chromium-review.googlesource.com/1107998Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#568846}
-
Fabio Tirelo authored
This reverts commit dbbd9b76. Reason for revert: contrast ratio for links is below 4.5:1 threshold Original change's description: > [Views] Adjust secondary info and link style colors for MD2 > > Source: https://docs.google.com/presentation/d/1EO7TOpIMJ7QHjaTVw9St-q6naKwtXX2TwzMirG5EsKY/edit#slide=id.g399d5e0d81_22_0 > > Bug: 852094 > Change-Id: I0bbfc28d214bed310fdb4a23cd804442d5751590 > Reviewed-on: https://chromium-review.googlesource.com/1099560 > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567152} TBR=msw@chromium.org,estade@chromium.org,ftirelo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 852094, 853637 Change-Id: I169e1f39d120c714e37c0534115d692a499c591f Reviewed-on: https://chromium-review.googlesource.com/1106457 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#568845}
-
mrefaat authored
Rename to AppLauncherAbuseDetector because the PolicyDecider is going to be used for the webstate policydecider in the AppLauncherTabHelper Bug: 850760 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0b39ca366d1e34a9b6db8217a89a1d5b68405ecb Reviewed-on: https://chromium-review.googlesource.com/1107038Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#568844}
-
Jérôme Lebel authored
Disabling EarlGrey tests from SigninInteractionControllerTestCase: + testSignInSwitchAccountsAndKeepDataSeparate + testSignInSwitchAccountsAndImportData + testSignInSwitchManagedAccount Those tests seem to trigger an issue in the sync code when doing enable disable enable too fast. Bug: 854446 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I76d10d272297e91650dbe91ef7acee500eac6c75 Reviewed-on: https://chromium-review.googlesource.com/1107881Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#568843}
-
Devlin Cronin authored
https://crrev.com/c008bf657dbc01fadc4ff1ea3df21f9cf237569a added support for IPv6 patterns with URLPattern and activeTab, so we can now enable the tests for captureVisibleTab using IPv6 URLs. Bug: 839857 Change-Id: I29eec17b176c54a312cfdf5dc7d11c50b7b245f9 Reviewed-on: https://chromium-review.googlesource.com/1107243Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568842}
-
Peng Huang authored
Implement SkiaRenderer::CopyDrawnRenderPass() by posting a task to GPU main thread to copy output from offscreen SkSurface for render passes or the framebuffer SkSurface for the frame. This CL also enable all existing pixel tests with SkaRenderer + SkDDL code path. Bug: 824382 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I707d555c2973eb81294b29b813d4538ab671a3c0 Reviewed-on: https://chromium-review.googlesource.com/1089451Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#568841}
-
Peter Wen authored
Add convenience link for sheriffs to easily access size bugs. Bug: None Change-Id: I04e9ad3041c49cdfa0e0d0e78ca1f5cd0e7cab66 Reviewed-on: https://chromium-review.googlesource.com/1107848Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568840}
-
Martin Šrámek authored
...as it's currently failing on the Linux MSan bot. Bug: 854599 Change-Id: I36a19408db4bb37ed667ac67f62e05fbf404eb60 TBR: hajimehoshi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1107923Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#568839}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a914f7ff310d..66c2f4afe3c2 git log a914f7ff310d..66c2f4afe3c2 --date=short --no-merges --format='%ad %ae %s' 2018-06-20 lucferron@chromium.org Vulkan: Add test and fix clear on RGB8 with color masks Created with: gclient setdep -r src/third_party/angle@66c2f4afe3c2 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I954361c5a4d73f55d6f9fce7f2706fe5c2f3305e Reviewed-on: https://chromium-review.googlesource.com/1107817Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568838}
-
Justin Cohen authored
TBR=eugenebut@chromium.org Bug: 854615 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7cc280c03203696c0fa00081b15736d6245d4ba5 Reviewed-on: https://chromium-review.googlesource.com/1107880Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568837}
-
Takuto Ikuta authored
When building chrome on windows, tool-wrapper for linking is called 794 times. And I found that calling python wrapper is relatively slow than calling link via ninja. This CL replaces python wrapper to ninja wrapper to remove such overhead when we use lld. I compared time of wrapper invocation using following powershell script. for ($i = 0; $i -lt 100; $i++) { # ninja -t msvc -e environment.x64 -- C:/src/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe -c ' ' # python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False C:/src/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe -c ' ' # code for FlushFileBuffers is commented out. } * ninja wrapper, 7.451s for 100 invocation * python wrapper, 17.803s for 100 invocation Using ninja as env wrapper is more than 2 times faster. Bug: 787903 Change-Id: I6531b59a6c43085782b0138a264ecfc9a6f65833 Reviewed-on: https://chromium-review.googlesource.com/1107678 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#568836}
-
Koji Ishii authored
This patch rebaselines 1px differences in the baseline positioning when the 'vertical-aling' property is used. Legacy computes the baseline position in multiple steps, while NG computes in single function. This difference causes slight rounding differences. TBR=atoti@chromium.org NOTRY=true Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia2adec046f2ac13dfb4d479e8ffa56cb4a3bd040 Reviewed-on: https://chromium-review.googlesource.com/1107860 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#568835}
-
jonross authored
For a while there was work looking into getting telemetry_perf_unittests and telemetry_unittests up and running on linux-chromiumos. However instead there is now a desire to just get an actual ChromeOS device on the CQ. This will resolve our coverage needs. We've been using the Mojo Chromiumos FYI bot to investigate this. But the tests have been broken there for a while. This change removes those configs. TEST=telemetry_perf_unittests, telemetry_unittests Bug: 836447 Change-Id: I8870c69dae811101d4869e3c7ede28771ecbf905 Reviewed-on: https://chromium-review.googlesource.com/1107838Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#568834}
-
Koji Ishii authored
This test has a failing baseline baked in the legacy, but passes in NG. Edge and Gecko pass (the same as this rebaseline.) TBR=atotic@chromium.org NOTRY=true Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I77f850b929af26a7e7eec9c3fff851476957985a Reviewed-on: https://chromium-review.googlesource.com/1107859 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#568833}
-
Michał Pichliński authored
Bug: 854179 Change-Id: Icee4af543850a30116e811f32a16c38b3498bcf2 Reviewed-on: https://chromium-review.googlesource.com/1106145Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Michal Pichlinski <mpichlinski@opera.com> Cr-Commit-Position: refs/heads/master@{#568832}
-
manuk authored
Previously, if navigating a link did not cause a url change (e.g. clicking on the `stackoverflow` logo on the `stackoverflow.com` homepage reloads the same page), then the display url remained unchanged. If the user had deleted or edited the url, his changes would remain. Now, the url is reset. Bug: 830491 Change-Id: If1aa07715175d7d5bd5b12a65d9e1d9529aca3b5 Reviewed-on: https://chromium-review.googlesource.com/1103233 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#568831}
-
Roger Tawa authored
Bug: 853848 Change-Id: I82630378262adfdc8ed7f6fafbf56266aa50d15c Reviewed-on: https://chromium-review.googlesource.com/1104961Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#568830}
-
Charlie Harrison authored
Bug: 793053 Change-Id: I0d39cd8e6695b18da47549e632f10abd9919c83e Reviewed-on: https://chromium-review.googlesource.com/1106519Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#568829}
-
Jeremy Roman authored
For consistency and efficiency. While here, move the StringBuilder::ReserveCapacity call at the use before the actual usage of the StringBuilder (presently it has no effect). Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I197140cc0b77d12bd236e908e844eacf39fa6697 Reviewed-on: https://chromium-review.googlesource.com/1106605Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#568828}
-
Mounir Lamouri authored
Bug: 854349 Change-Id: Iba9fa4ccb6001455f9fd925d2d871e591097251f TBR: apacible@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1107840 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#568827}
-
Mikel Astiz authored
The patch inlines the content of the former RegisterAndroidDataTypes() and RegisterDesktopDataTypes() as per TODO promised in earlier code reviews. No behavioral changes. Bug: None Change-Id: I899db974c7782e0bc31fd743702fe41e8293d561 Reviewed-on: https://chromium-review.googlesource.com/1105044 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#568826}
-
Martin Šrámek authored
This reverts commit e4f3ef2e. Reason for revert: Seems to be causing test crashes, and timeouts of entire test suites. See crbug.com/854611 for more details. Bug: 598880,854611 Original change's description: > Android: Delete native ContentViewCore > > The only thing the native CVC does now is (as an WebContentsObserver) > adjust renderer view focus/screen info when renderer is updated. > This CL moves that reponsibility to WebContentsAndroid, and deletes > the entire class. There is no functional change. > > Bug: 598880 > Change-Id: I9a1f3a2e0df5457439a27675d3786aa6703e06ac > Reviewed-on: https://chromium-review.googlesource.com/1083911 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568499} TBR=boliu@chromium.org,tedchoc@chromium.org,jinsukkim@chromium.org Change-Id: I039091e040d468669bd4c5f5b1b42aef9f272d0e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 598880 Reviewed-on: https://chromium-review.googlesource.com/1107958Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#568825}
-
Vasilii Sukhanov authored
Bug: 854562 Change-Id: Id61eee835d304369c9efb19dafbcb29b3b6f4195 Reviewed-on: https://chromium-review.googlesource.com/1107814Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#568824}
-
Florian Mayer authored
This includes a rename perfetto::Service to perfetto::TracingService. Do the corresponding changes in Chrome. Bug: 74331089 Change-Id: I73bb3a15a66ad494a3796cdf9f5e4fd275d8c57d Reviewed-on: https://chromium-review.googlesource.com/1107698 Commit-Queue: Florian Mayer <fmayer@google.com> Commit-Queue: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Hector Dearman <hjd@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#568823}
-
Olga Sharonova authored
This reverts commit ec3716fd. Reason for revert: It broke WebRTC performance tests which capture system audio loopback. The reason is unclear, but looks like tests-specific: audio works with manual testing; and the test only changed event timing at the process startup. Reverting for now to have WebRTC audio quality test coverage. Bug:850936 Original change's description: > Changing AudioService experiment field trial to test service launch on startup > > [1] introduced AudioServiceLaunchOnStartup feature which we want to roll out > with a new experiment group. Updating field trial to run the config on bots > first. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/1104681 > > Bug: 851611,853781 > Change-Id: I3796a8ac205a6d37706a86e8647c933ee510f41a > Reviewed-on: https://chromium-review.googlesource.com/1105957 > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Commit-Queue: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568485} TBR=rkaplow@chromium.org,olka@chromium.org Change-Id: Ic50b37d434bc75fca78585ead8c964815bcd2cf0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851611, 853781 Reviewed-on: https://chromium-review.googlesource.com/1107957Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#568822}
-
Oskar Sundbom authored
Renaming it to ExperimentalHardwareEchoCancellation2, so that new tokens don't trigger the old behaviour in older versions of Chrome. The runtime flag retains its name, since that's user controlled. Bug: 854577, 846270 Change-Id: I577e37082ed4cd84d4e77dc6f13155a4eba49131 Reviewed-on: https://chromium-review.googlesource.com/1106338Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#568821}
-
Scott Violet authored
Into HostContextFactoryPrivate. This also adds a ui::ContextFactory implementation that uses it to services/ui/ws2. I could move the ContextFactory implementation to ui/compositor/host as well, but I kept it where it is used. BUG=837686 TEST=covered by tests Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I95f89f9c14ac93560805bf47a9fe074d1ab1c58d Reviewed-on: https://chromium-review.googlesource.com/1105307Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#568820}
-
Sylvain Defresne authored
The overload of PrepareMailtoHandling is no longer overridden in the downstream implementation and not called from upstream code so it can be safely removed. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5bde07b17f1c5293488b0d65d284fa0e0ecea5f6 Reviewed-on: https://chromium-review.googlesource.com/1106164 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568819}
-
Koji Ishii authored
Blink is the only engine that truncates text inside of an inline block for 'text-overflow: ellipsis', and these two tests are for the behavior. The spec says atomic inline is truncated as a whole or not, and all other 3 impls follow that. LayoutNG matches to it. TBR=atotic@chromium.org NOTRY=true Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iae29eaf66f23d3eb120b215606a5b1e5e020bfbf Reviewed-on: https://chromium-review.googlesource.com/1107529 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#568818}
-
Marc Treib authored
Turns out the test was completely out of date and only passing by accident. While we're here, also replace a few EXPECT_CALLs with ON_CALLs. Bug: none Change-Id: Ie2250a7ea58332e6bf08b6df80e33b72eb5a0018 Reviewed-on: https://chromium-review.googlesource.com/1107811Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#568817}
-
clamy authored
This CL is part of a serie of CL to remove usage of the deprecated method NavigationController::GetActiveEntry. Bug: 273710 Change-Id: I3c2aefded05884333fd3e20830cf4abfabebbdc1 Reviewed-on: https://chromium-review.googlesource.com/1102458Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#568816}
-