- 22 Sep, 2020 40 commits
-
-
Thomas Lukaszewicz authored
This CL creates a new file for TabSearchButton browser tests. These tests run for both the fixed and regular entrypoints. Existing tests for the TabSearchButton have been moved from the tab strip into the TabSearchButton browser tests. Bug: 1099917 Change-Id: I0b1d57826768705316b9bed814dac7af96ce52e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422730 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#809376}
-
Xiaodan Zhu authored
This CL change the reverse scroll gestures including - Swipe up with three fingers to enter overview and down to exit overview. In M87, the old gestures also work and a notification shows up. In M88, the old gestures fail. In M89, remove notification. -For each user, the notification will only show 3 times - Swipe right to switch to the next desk and left to switch to the previous desk. The old gestures fail immediately. Bug: 1107183 Change-Id: I815c308c1fee4cf5152227064c5f8fec61f67b06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418015 Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#809375}
-
Roman Sorokin authored
go/coil Bug: none Change-Id: I1e67b34b177affa44a753500a56ca114bbcf34ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424343Reviewed-by:
Renato Silva <rrsilva@google.com> Commit-Queue: Renato Silva <rrsilva@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#809374}
-
Egor Pasko authored
This is often necessary on Android to read /proc/self/pagemap. Without prctl(PR_SET_DUMPABLE) opening this file fails in 94% of cases on Canary. This potentially leads to bias in reporting MappedAndResidentMemoryFootprint2. What happened since it last landed as http://crrev.com/808298: * Setting the process back to non-dumpable was often returning an error and hitting a (P)CHECK * In crash dumps logcat started right at the failure, so it is not possible to see whether prctl(PR_SET_DUMPABLE, 1) succeeded prior to the failure, my guess is that it failed too * In the reland, avoid prctl(SET_DUMPABLE, 0) if prctl(SET_DUMPABLE, 1) failed before that Bug: 1070618 Change-Id: Ic9bfbdad6c72a1388eb80c3b6c9e6c772c8e431c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421730Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#809373}
-
Tim van der Lippe authored
This requires https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2422960 to land in Chromium first. R=szuend@chromium.org Bug: 1011811 Change-Id: Ib2488a082456ad1cb4a0f7e77ec4a14a5a410ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423846Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#809372}
-
Nick Harper authored
Removal was requested via email to hstspreload@chromium.org and domain control was verified via DNS challenge. Change-Id: I32776a8f1b61c9d3dd19c7d1af6f83f6484f19ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421636 Auto-Submit: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#809371}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9cf7a56afbcf..ada5d5129f48 2020-09-22 taylori@google.com Merge "ui: Don't show reload toast" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie0095286c821cfb6f255e8423214c6715986059d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423975Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#809370}
-
Peter Wen authored
Add ignores for EditText elements that do not need autofillHints. Remove ButtonOrder suppression as it's no longer needed. Bug: 1073966,1116130 Fixed: 1073966 Change-Id: I80c97528c3558379d43677b78bbbc2f290d5105e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419593 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#809369}
-
Colin Blundell authored
When BrowserViewController sets/clears its active Tab, it notifies the Tab in question. This is currently done via TabImpl#onDid{Gain, Lose}Active callbacks. As boliu@ pointed out on the bug linked below, this is confusing as there would be a natural expectation that these callbacks are invoked when the *BrowserImpl* is setting and clearing its active Tab. These flows are not identical; for example, when the BrowserImpl is moved between Activities BrowserViewController clears its active Tab as part of its destruction but the actual active Tab in the BrowserImpl doesn't change. This CL updates the relevant method names for clarity. Bug: 1129077 Change-Id: I04fd58d6bcd69abfdc7cdde3a3c0186d83d67b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421309Reviewed-by:Bo <boliu@chromium.org> Reviewed-by:
-
Christian Dullweber authored
Hide strings for zero blocked cookies. Always show cookie section. Remove "cookies in use" on main page. Some code cleanup. Bug: 1077766 Change-Id: I892373fdbd62a6a95c253a293ac125dd7bf3a1cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416068Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#809367}
-
Mark Yacoub authored
1. |should_modeset| should never be true when committing using legacy API. 2. Use emplace_back instead of push_back (modernize-use-emplace) BUG=987274 TEST=enable and page flip legacy devices. Change-Id: I78615163191a5ba537d4136702fc50452fc503d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418617Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#809366}
-
Collin Baker authored
Creating a new window for a tab playing media shows the medial toolbar button immediately. With a recent change, it would then attempt to get the window's BrowserView. But BrowserView::GetBrowserViewForBrowser() returns nullptr when called during BrowserView construction resulting in a crash. This CL changes MediaToolbarButtonView to take the BrowserView on construction instead. Fixed: 1130921, 1130897 Change-Id: Ica879fe9825c4ef1af2789169bffb49da28370b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423551Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#809365}
-
Olya Kalitova authored
Changes description of the NewTabPageLocation policy. Bug: 1097727 Test: None Change-Id: I53e58906a54adeb0280b9a5b2c43bc9deb7ad916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421745Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#809364}
-
Shakti Sahu authored
This CL adds the JNI glue for all the public methods from Java to all the way till native TutorialServiceImpl. Also glued TutorialManager and TutorialFetcher to the service. Bug: 1130460 Change-Id: I1e62d419b0883b2d02c4da9a83fc2c8c8abc3f12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421248 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#809363}
-
Erik Chen authored
This CL adds a stub for Profile::IsDefaultProfile. This is required for Lacros since exactly 1 browser profile will be associated with the chromeOS device's signed in profile. Bug: 1129543 Change-Id: I74566593fc60d887a20c7f10974687619588e3cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416816Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#809362}
-
Mohamed Adel authored
This CL creates a base class for notification builder mac and extends it to build UNNotifications. It also groups shared methods between the NPBs for macOS platforms together to avoid redundancy. Bug: 1129987, 1129988 Change-Id: I41ef920aafed94a0ac8e9851c5884112f0a30aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418446Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Mohamed Adel <adelm@google.com> Cr-Commit-Position: refs/heads/master@{#809361}
-
Mohsen Izadi authored
As of r783010, this method is only there to be used in tests. Renaming to make this explicitly clear. Bug: 1079116 Change-Id: I655950e6c9c7a9b2834f1500eaa6754c8a373a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420532Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#809360}
-
Xiaoqian Dai authored
It looks like CursorManager::GetDisplay() can return an invalid display, which then cause Shell::GetRootWindowControllerWithDisplayId(display_id) to be a nullptr, when then cause ash::SetBoundsInScreen() crash. Bug: 1068018 Change-Id: I8d590e146755330c94cb0934ccb57085af135e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422731Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7a1f241c0134..77960d9addc8 2020-09-22 egdaniel@google.com Revert "include freetype in wasm build, see cl/332073924 for complete change" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: csmartdalton@google.com Change-Id: Iad6f9a01a1507b9679a6ca3c48f23ed12b17f7b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423971Reviewed-by:
-
Clemens Arbesser authored
The crash seems to happen because the delegate is deleted potentially while a call to Java is still pending. I assume (but am not sure) that JNI calls are put into the message queue and not executed immediately. The workaround for now is to use callbacks instead of a dedicated delegate, thereby circumventing lifecycle issues of the delegate. Bug: b/169129405 Change-Id: I6e34874141792df47a117cd1f7f045759f852254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423885 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#809357}
-
Benoit Lize authored
4.19 and 5.4 are Android kernel versions, visible in reported metrics, but not in enums.xml. Change-Id: Ib09ded38501345c2df17743c4da5c4eb741f0aa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424244Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#809356}
-
Dave Tapuska authored
Allow the ability to restrict same origin documents. Approved intent to ship https://groups.google.com/a/chromium.org/g/blink-dev/c/TzuPAx9ZOk0/m/5num2KNACAAJ https://chromestatus.com/feature/5648946183536640 BUG=961448 Change-Id: Ic3996eb5015484fd3d3220b357d5b17d50413d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417099Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#809355}
-
Michael Checo authored
Description: This change allows users to tab to the first printer in the saved and nearby printer lists and use the arrow keys to navigate the remaining printers. Users can also use the arrow keys to navigate through a printer entry's associated buttons/icons. Lastly, the printer entry row will be highlighted (blue background) if it is being focused. Screenshots: - http://shortn/_Fqf1Nn9qjF nearby printers - http://shortn/_BSspETkjzV saved printers Bug: 987422 Test: gtest_filter=OSSettingsCupsPrinterLandingPageV3Test.All Change-Id: I68fc5fc3ff2ceec88ce81f95da5b451a6ad3beb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399601Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#809354}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If797353b430652a00e6fe43caf7d394685c291ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423974Reviewed-by:
-
Reda Tawfik authored
This Cl handles the case when the password data is empty. In the case of the focused field is a password field, the credentials have an empty password will not be added to the model so will not appears in the bottom sheet. In the case of the focused field is a username field, the empty password will be replaced with a placeholder `No password` and it is disabled by default. Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=1104132#c21 Bug: 1104132 Change-Id: I158b3eb43856a827cdca2fd563afd4129d32ebc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424123Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Reda Tawfik <redatawfik@google.com> Cr-Commit-Position: refs/heads/master@{#809352}
-
Sylvain Defresne authored
Change all files that depends on the existence of the deprecated global sources assignment filter to explicitly configure it by importing the deprecated_default_sources_assignment_filter.gni and calling set_sources_assignment_filter(). This is a preliminary step before removing the global assignment in //build/config/BUILDCONFIG.gn and incremental migration of those files from the deprecated feature. To verify, used a patched version of gn: https://gn-review.googlesource.com/c/gn/+/6401 And then ran: gn gen out/xxx | grep Filtering: | sort with and without the patch for all configuration (cross-compiling Windows on Linux). Bug: 1018739 AX-Relnotes: n/a Change-Id: I06be60303e52558e5339c1bf3bea95b94f86b732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418443 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#809351}
-
Thomas Lukaszewicz authored
Bug: 1099917 Change-Id: If1ccecfb3f379133b24ce68d916c5cedb90fc521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421840Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#809350}
-
Matthias Körber authored
This CL adds support for using the structured addresses in the AutofillComparator. This CL aims to reproduce the behavior of all existing test cases but it does not add testing for the value of the new tokens. Change-Id: I2586e1fee51ffd5057f2867fa0d7fdae72a4ff50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421376 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#809349}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/dcc28c9f5a3d..9f82884d032c 2020-09-22 alexrudenko@chromium.org Fix the color of selected breadcrumbs in Elements panel 2020-09-22 tvanderlippe@chromium.org Add isRequestFilteredOut function for layout tests 2020-09-22 liviurau@chromium.org Whitespace to trigger builders 2020-09-22 alexrudenko@chromium.org Add focus outline to checkboxes in Layout panel If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9af8eb7d56eb7db961bac29015738a18cab35190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423972Reviewed-by:
-
Raymond Toy authored
The debugging in https://chromium-review.googlesource.com/c/chromium/src/+/2411424 doesn't provide any new information. Thus, change the DCHECKs into CHECKs to see if something is out-of-bounds. Only do this for a short time and revert if nothing is found since this has performance implications. Bug: 1116104 Change-Id: I89c385c24694de5c01edd6a3856743a658282d20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422890 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#809347}
-
Anupam Snigdha authored
This change added width and height of the virtual keyboard rectangle to the CSS environment variables reported in the geometrychange event defined for VK. This was a feedback from TAG review as well as from web devs who are experimenting with VK APIs. https://github.com/w3ctag/design-reviews/issues/507 Bug:1127746 Change-Id: Ib3eaefa4f92b5e7482f30c0c6643ccd470728a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422701Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#809346}
-
Viktor Semeniuk authored
This change adds string for timestamp with the last time issues were found. Bug: 1075494 Change-Id: Iedc0afa38bb690d44bc937d6c43e1a552c7f6a0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362752 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#809345}
-
Dominique Fauteux-Chapleau authored
This should not change deep scanning behaviour with Connectors. Bug: 1103390 Change-Id: Ie96093e3eb654f8b68d20d287d7786b73641a6ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410538Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#809344}
-
Olivier Yiptong authored
Small code cleanup: the temporary structure declared in the base FontEnumerationCache class is moved to the Windows implementing class, FontEnumerationCacheWin, because it's the only class that uses it. Bug: 1043306 Change-Id: Ia6145f26a223d64a79920042c57e231eca575fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422470 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#809343}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1600689096-6bb040ccfec21a14348d3421fe3415a00ad5226f.profdata to chrome-win64-master-1600754349-e20db2f8d281c7f1a24165725105bb03ea6ece36.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ia548b30b8ce73c6ea1f075f3e2d61a67aa7873d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423532Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1600678560-73f022cb15ffdf2af0536df3a108de473267405b.profdata to chrome-win32-master-1600754349-faa1edece0f28695a43c5cb3d7e6ca8a741e4346.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic8cf5a8265865527b1c67bcec43bc5d296f91f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423529Reviewed-by:
-
Jonathan Ross authored
This reverts commit ff8d2bea. Reason for revert: This change was temporary to unblock https://chromium-review.googlesource.com/c/chromium/src/+/2422181 which has now landed. Original change's description: > Temporarily re-add content/renderer/input/OWNERS > > When content/renderer/input was moved[1] it removed the OWNERS file. However > content/renderer/android/OWNERS lists it as a dependency. > > This leads to any changes to content/renderer/android to fail presubmit, due to > the missing file. This includes changes to remove that dependency in the OWNERS. > > This change temporarily re-adds the file so that the dependency can be removed. > > Removing the dependency will be done in a follow-up[2]. After which this change will be reverted. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/2411941 > [2] https://chromium-review.googlesource.com/c/chromium/src/+/2422181/ > > Bug: 1097816 > Change-Id: Ic318ebdd5c9e845afb6047776a2b9ebb0b5d746a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422141 > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Commit-Queue: Jonathan Ross <jonross@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809307} TBR=danakj@chromium.org,jonross@chromium.org,dtapuska@chromium.org Change-Id: Ia0354dc195f82ecde02548b31194e2d64bab7e5c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1097816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424384Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#809340}
-
Palak Agarwal authored
WebRtcVideoCaptureServiceEnumerationBrowserTest. AddingAndRemovingVirtualDeviceTriggersMediaElementOnDeviceChange is flaky on ChromeOS. Bug: 1126373 Change-Id: I60a41db047d73d45cc3075130fda47ff9977fb8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421499 Commit-Queue: Palak Agarwal <agpalak@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#809339}
-
Clemens Arbesser authored
Instead, users will be able to swipe down the sheet to dismiss the lite script entirely. Example video is in the linked bug. Bug: b/168706237 Change-Id: Ib0e584bd4186a861cde045aa3a9e8938858009b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421892 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
Leonard Grey authored
This reverts commit 28310fb5. Reason for revert: [Sheriff] Failing deterministically on ios-simulator-noncq Example: https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/12130 Original change's description: > Remove updatesCollectionView from grid view controller. > > In order to allow the tab thumbnails to be up to date when the thumb > strip is visible, the grid's collection view needs to be updated even > when other view controllers are obscuring it. When selecting a new item > from the collection view (blue highlight around the thumbnail), the item > that is currently selected needs to be deselected to prevent multiple > simultaneous selection. > > Bug: 1127604 > Change-Id: Ic1e4a2dd4d0f2c269031b9d27b47b38c56b07a40 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410494 > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Commit-Queue: Roberto Moura <mouraroberto@google.com> > Auto-Submit: Roberto Moura <mouraroberto@google.com> > Cr-Commit-Position: refs/heads/master@{#809263} TBR=gambard@chromium.org,mouraroberto@google.com Change-Id: Ia7c8b2a2946424754838f5d2fdcd76d203745e59 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423170Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#809337}
-
