- 12 Jun, 2019 40 commits
-
-
Kyle Horimoto authored
Previously, when users who navigated the dialog via the keyboard (i.e., using the Tab key) pressed Enter on the connect and/or disconnect button, focus would be lost. This was due to the fact that the UI actually had 2 buttons (connect and disconnect), and one is hidden when the other is visible. Thus, when users would click one button, it would immediately become hidden and its focus would be lost. This CL fixes this issue by having both connect and disconnect share a single button which remains visible and retains focus after the Enter key is pressed. Bug: 971213 Change-Id: Ifd5c29946ab86ce95548fe6d95e5c3c6738f4976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655977 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#668537}
-
John Chen authored
NOTRY=true Change-Id: I74bbe79587c3fada031bc3f645a6169b73cbb948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656113 Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#668536}
-
Yuke Liao authored
This CL does two things: 1. Replace the SI count check with a whitelist check. 2. Add InstrProfilingRuntime.cc to the whitelist because coverage build needs it and it is ONLY used on coverage build. This change only applies to Linux platform, and in order to make Mac platform work, a separate CL is required to change //tools/mac/dump-static-initializers.py to have the same output format as //tools/linux/dump-static-initializers.py. Bug: 956591 Change-Id: I54119676bea59a8f1e6fdba470bbeac32b121c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653319Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#668535}
-
Alex Newcomer authored
It has very low usage, and can result in a lot of bad system UI. It is hypothesized that the shortcut is mainly executed by accident (based on UMA). If we get complaints, we will return the shortcut. Bug: 939570 Change-Id: I2940f60053cfb531ffe67654df17f1407beb8c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610752 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#668534}
-
Joshua Pawlicki authored
Bug: 926234 Change-Id: Ifcd0a9148f9488f57cde0e24acbcd46b3728eb20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656348 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#668533}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7d984193c8c4..2fcee1474c0d Created with: gclient setdep -r src-internal@2fcee1474c0d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=haraken@google.com,tangltom@google.com,flackr@google.com Change-Id: Ia77bd40f6b460c9396005990cd808101f028dfa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655897Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#668532}
-
Jacques Chen authored
-Non Gzipped IDR_SECURITY_INTERSTITIAL_HTML was very large and took up lots of space -Previously,there was no easily accessible function to decompress resources -Gzip Compressed IDR_SECURITY_INTERSTITIAL_HTML -Gzip Compressed IDR_SECURITY_INTERSTITIAL_QUIET_HTML -GetResourceFromIdAsString() in dom_distiller/core/resource_utils.cc was modified -Modified function moved to ui::resource_bundle. -Code that previously used GetResourceFromIdAsString() was modified to use new function -Code that loaded compressed resources was modified to use new function -Added overloaded version of the function that accepted a scaling factor -dom_distiller/core/resource_utils.cc was deleted -47kB of space reduced TBR: small unittest Bug: 872568, 973417 Change-Id: I79c4275fdc98af1bcb6ac3e3053961a3662342de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632733 Commit-Queue: Sam Maier <smaier@chromium.org> Commit-Queue: Jacques Chen <jacqueschen@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#668531}
-
Kyle Milka authored
Log links opened from the Most Visited iframe (shortcuts) in MostVisited_Clicked. Log links open from elsewhere on the local NTP in NTP_LinkOpenedFromContextMenu. Bug: 951892, 961477 Change-Id: I961963c3f97d830dbe4ed3e6eaeb1459337bc3af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640608 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#668530}
-
Mehran Mahmoudi authored
Mock: https://docs.google.com/presentation/d/1X29NR8smO_P3cNJCGHpASPOOyj20IpR4ztHPNGWFtFo/edit?hl=en#slide=id.g5b4b9a286c_0_24 Implementation: https://drive.google.com/file/d/1lDS_tUembnk8qIu0VpJhLui_rO5ujFep/view?usp=sharing Bug: 957992 Change-Id: I7764694b60ba15adcdf4f023a9c4d14f825423af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647686Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#668529}
-
Allen Bauer authored
Bug: 945335 Change-Id: Iafd00edba2f2e68baf9d76a51cc29429a2a522cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652103 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#668528}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b536588c0c07..3512b96da35d git log b536588c0c07..3512b96da35d --date=short --no-merges --format='%ad %ae %s' 2019-06-12 tsepez@chromium.org Introduce ref-counted CFX_Face class. 2019-06-12 thestig@chromium.org Do IWYU for pdf_fuzzer_init_public.cc. 2019-06-12 thestig@chromium.org Rename CCodec_ScanlineDecoder to fxcodec::ScanlineDecoder. 2019-06-12 thestig@chromium.org Rename CCodec_BasicModule to fxcodec::BasicModule. Created with: gclient setdep -r src/third_party/pdfium@3512b96da35d The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: I995136b6244136cd29713dace95f8fc6c1dfe1f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655894Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#668527}
-
Saman Sami authored
vkGetPhysicalDeviceXlibPresentationSupportKHR is now supported. Bug: swiftshader:129 Change-Id: Id7eaee8fd695cd1cb5875b8c524e9152bea2a461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656062 Auto-Submit: Saman Sami <samans@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#668526}
-
Robert Sesek authored
The calculation did not include the uint64_t for the payload's size when sending messages inline. If a message's msgh_size == 0xFD0, which maps to a Message::payload_size in the range of [0xF99,0xF9C], then the receiving Channel would fail to dequeue the message with MACH_RCV_TOO_LARGE. Bug: 973506 Change-Id: If0321cd4a4c396ac40401ba10c011df3f06803b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656089Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#668525}
-
Gil Dekel authored
This CL fixes a bug in which, in some cases, empty vectors of type VASurfaceID were passed to vaDestroySurfaces. Bug: 973235 Test: jpeg_decode_accelerator_unittest Change-Id: Ic285a71134e6030210ad794e4f74992ffb1965b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655991 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#668524}
-
chrome-bot authored
New bots were added in https://crrev.com/i/1369990. Created the test pools with: python <celab>/scripts/tests/create_test_pool.py --project celab-chromium-[ci|try] --size=10 --service_accounts="chromium-[ci|try]-builder@chops-<...>.com" We're still missing the tests entry point in chrome/browser/policy/e2e_test/, but we can start verifying our scenarios with this. Bug: 973284 Change-Id: I73be82aeed37d5e6a2f96f4c944b120531635c35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649302Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Mathieu Binette <mbinette@google.com> Auto-Submit: Mathieu Binette <mbinette@google.com> Cr-Commit-Position: refs/heads/master@{#668523}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/072e6fc374db..d3cc16c8bbec git log 072e6fc374db..d3cc16c8bbec --date=short --no-merges --format='%ad %ae %s' 2019-06-12 mtklein@google.com eliminate the need for a tmp ymm register Created with: gclient setdep -r src/third_party/skia@d3cc16c8bbec The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@google.com Change-Id: I815e8f0f928d620372045d5d41a46933fda18020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656020Reviewed-by:
-
Scott Violet authored
It's no longer needed. BUG=964460 TEST=test only changes Change-Id: I195636d1c27be3170fdecc7df9ebeef7fbeb5dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656064Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#668521}
-
Anton Bikineev authored
This is needed for concurrent sweeper, which manages per-page freelists. Bug: 967258 Change-Id: Iae8d6b5baee1e5c4c5410987679bb5668e4294c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649784 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#668520}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6dd5f3358713..85035be3e2bb git log 6dd5f3358713..85035be3e2bb --date=short --no-merges --format='%ad %ae %s' 2019-06-12 capn@google.com Use VK_TRUE/VK_FALSE consistently 2019-06-12 srisser@google.com Don't let shaders negate samplers Created with: gclient setdep -r src/third_party/swiftshader@85035be3e2bb The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/134584057 TBR=swiftshader-team+autoroll@google.com Change-Id: I80d0cfa596f9ceb797e4b7a3b9ebb721f9952f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655896Reviewed-by:
-
Xiaohan Wang authored
We still depend on //third_party/skia but we don't really depend on //skia now. Change-Id: Ibac00d3fe370f22009b9ab70ab5ec449eab94a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655346 Commit-Queue: Miguel Casas <mcasas@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#668518}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/53cfcd3219c1..d04981cdea4b git log 53cfcd3219c1..d04981cdea4b --date=short --no-merges --format='%ad %ae %s' 2019-06-12 jackneus@google.com Fix cros branch sync to file fails Created with: gclient setdep -r src/third_party/chromite@d04981cdea4b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I1e62dd211343664ca6e89675e73a045f06b5eb6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656023Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ece78714..92219cfc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5170d28297618fd814b107789df4f9d4959d0eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656016Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#668516}
-
Mitsuru Oshima authored
Bug: 969829 Test: no functional change. all test should passes. Change-Id: I51ae9d1fc03b15f20a004d63c4e4c214d18d2652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656054 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#668515}
-
Kehuang Li authored
It was hard coded to level kHigh. This cl is to add the configure to the json configure string used in MediaStreamAudioProcessor. Bug: internal: 131692686 Test: Passed unit tests that check configuration. Change-Id: I690b65bcf9d0cffafc42b564546f51a3296ffb37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650300Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Kehuang Li <kehuangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#668514}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b64faff265e8..86a9e51b7ad8 git log b64faff265e8..86a9e51b7ad8 --date=short --no-merges --format='%ad %ae %s' 2019-06-12 crouleau@chromium.org [telemetry] Update Chrome reference builds. Created with: gclient setdep -r src/third_party/catapult@86a9e51b7ad8 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:973179,chromium:867592 TBR=simonhatch@google.com Change-Id: I8eac729aa1b2a46ff16e29fe642684300d881537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656021Reviewed-by:
-
Tommy Steimel authored
This CL removes the declaration for the web runtime feature for enabling modern media controls. The old controls have been removed and so has the feature flag backing this runtime feature, so it's no longer needed. Bug: 884215 Change-Id: If5de46241e43380919397d4059246e594644b354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656156 Commit-Queue: Tommy Steimel <steimel@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#668512}
-
John Delaney authored
Currently, ad frames are never removed from storage when render frames are destroyed. This is a potential memory leak on pages that create large amounts of frames over the lifetime of the page. Each FrameData is ~328 bytes. This CL changes the behavior of the PageLoad.Clients.Ads.Cpu.AdFrames.PerFrame.PercentUsage histograms. However the new behavior is somewhat warranted. Previously we used the entire page lifetime as the denominator. We shouldn't be calculating PercentUsage using time with which the ad frame was already removed from the document. These metrics are versioned to account for this. For all other metrics this change is purely structural, and should not affect behavior. Bug: 971866 Change-Id: I3d94e769d166b4ba59455ec31d4d25903d60e7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649077Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#668511}
-
Esmael El-Moslimany authored
Bug: 972489 Change-Id: I3394786fd64493443e270194012f2a9089783544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654228Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#668510}
-
Anders Hartvoll Ruud authored
Bug: 972388 Change-Id: Iab62b344387060eac5b44dcaf8d0c47c3e8a22fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653019 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#668509}
-
Pedro Amaral authored
I'm leaving Chrome so I am reassigning metric and flag ownership to mdjones. Change-Id: I72a7ef7e371bf2415c0a1f0b9fe6f98d7eae3f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647148Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#668508}
-
Clark DuVall authored
Nobody has used this for years, so it should be safe to remove. Change-Id: I59d361640801e2677a16f0b80be21b41296d2c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655979 Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#668507}
-
Marina Ciocea authored
Change confirm button to Stop instead of Share, because "stop" should be the default action for the infobar. Bug: 927949 Change-Id: I9cbcfe6ab2ccd6e365148c250019259dd72e6762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645299 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#668506}
-
Nate Chapin authored
Bug: 749492 Change-Id: I93c8a22383b4c33a52003c453912e139e34baa81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655895 Commit-Queue: Nate Chapin <japhet@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#668505}
-
Lucas Furukawa Gadani authored
Bug: 973542 Change-Id: Ib0b4768644c8c2ca2f3c42626a797a1203b6b55a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650530 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#668504}
-
Devlin Cronin authored
Enable gn check for all targets under //extensions/renderer. Correct previous failures by properly depending on targets. Bug: None Change-Id: I9a075fdcdd82cba8e934889abd395f7bb1794fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626663Reviewed-by:
-
Mohammad Refaat authored
This test was not possible in EG1 as EG1 can't detect system views (in this case the activity view). - Test that open in bar appears when a PDF is opened and test that interacting with it will show the activityView. Also test that after dismiss the activity view tapping on the web view will bring back the open in bar. - This CL also include a fix for the path problem where the default EmbededTestServer uses the Runner.app directory as the root directory. Instead change that to use the bundle path in the server initialization inside ChromeTestCase (This is a variation of Eugenebut@ solution created on https://chromium-review.googlesource.com/c/chromium/src/+/1650271 ) Bug: 945461 Change-Id: Ie8b53a7b662412b6516d8f2c654a19ac657416da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650613 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#668502}
-
Tommy Steimel authored
This CL takes layout tests out of media/controls/modern and puts them directly into media/controls. We no longer support legacy controls so there's no need to differentiate between the two. Bug: 884215 Change-Id: I5eb8f5e4db9c5a5db675703c153fefdc34d7b145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655982Reviewed-by:
Becca Hughes <beccahughes@google.com> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#668501}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/08fa95371129..51db421682d6 git log 08fa95371129..51db421682d6 --date=short --no-merges --format='%ad %ae %s' 2019-06-12 noahric@chromium.org Skip cropping for frames that can't be converted to i420. 2019-06-12 nisse@webrtc.org Delete TestAudioDeviceModule methods using rtc::PlatformFile Created with: gclient setdep -r src/third_party/webrtc@51db421682d6 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I536d8fadf99f8cc0ddc40374b5ea3c6c97c0ea39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655893Reviewed-by:
-
Erik Chen authored
The script was previously implicitly relying on the location of a hermetic Xcode checkout. Bug: 965663 Change-Id: If911d17f278646e17efc87550833665baa40b917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652010Reviewed-by:
-
Jeffrey Cohen authored
Bug: 970284 Change-Id: I2375285647ee5fdabba32aaf936d4f0c70eec353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653653 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#668498}
-
