- 27 Feb, 2020 19 commits
-
-
Clark DuVall authored
Previously, ResourceMapper::MapFromChromiumId has to be called on native resource IDs, which generated an intermediate ID mapping, which then was resolved to a drawable ID when ResourceId.mapToDrawableId() was called on it. This was confusing as the intermediate ID was not a valid native or drawable ID. Now ResourceMapper::MapToJavaDrawableId() returns the drawable ID that can be used directly in java code, eliminating the intermediate mapping. This will also help when componentizing code that depends on ResourceMapper, since we will not need to use ResourceId.mapToDrawableId() on the java side anymore. Bug: 1025609 Change-Id: Ia19a8b915880d974f4d2d6fff87aac9640976656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067656 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#744869}
-
Ella Ge authored
This CL replaces fetching the badge icon with fetching splash icon in WebApk update. With This CL, webapk will request update if the splash icon is changed. Bug: 1043271 Change-Id: Ia297e7cc20fdacd652262fdb9101717526e1a341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037819 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#744868}
-
Joel Hockey authored
Add docs for [Export|Import]Container and make functions consistent with ContainerId as first param. Change-Id: I6cc9e4eaf7543050d4a144c61ea9b411d4610c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073917 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#744867}
-
Ahmed Fakhry authored
A layout of the desks bar must be guaranteed even if we think that a bounds change would trigger one implicitly. Otherwise, mini views may not show up at all. See bug for detailed explanation of why this is needed. BUG=1056371 TEST=Manual Change-Id: I0a8464ed1b78f83504924993b9437c25113003d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076659Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#744866}
-
Forest Fraser authored
Bug: b/149108108 Test: Build Change-Id: I59f91b0d042f4d74f16192cd1d693ddcdec53426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076700Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Forest Fraser <ffraser@google.com> Cr-Commit-Position: refs/heads/master@{#744865}
-
Rahul Arakeri authored
This CL fixes an issue where clicking on a faded out scrollbar on Mac caused a gesture scroll. This is fixed by querying the opacity of the PaintedScrollbarLayerImpl and returning a zero delta if the scrollbar opacity is 0. Bug: 1054155 Change-Id: I9ae3b8284b1843b99f15e70a66f7336d956aa810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068204 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#744864}
-
Tomasz Wiszkowski authored
This change adds two new flags to control and modify the Omnibox suggestions behavior: - compact suggestions, aiming at conserving the screen real estate and shrinking suggestions size (allowing more suggestions to be shown by the AdaptiveSuggestions feature), - deferred keyboard popup, that will prevent keyboard from automatically appearing on screen when we have suggestions that we can present to the user. Change-Id: I0965b069048e4a48d013882974668930c790ea13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070604Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#744863}
-
Min Qin authored
BUG=1055425 Change-Id: I25152dd3fbba463d54e0f784359ee335f810e9a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073122Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#744862}
-
James Darpinian authored
Change-Id: Ifbef2fe8be8ac43a82dccb0151f77048fc7ec664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073063 Auto-Submit: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#744861}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9bda3eea9509..ccb3a54defb5 git log 9bda3eea9509..ccb3a54defb5 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 rsavitski@google.com Merge "traced_perf: enable the static libunwindstack cache" Created with: gclient setdep -r src/third_party/perfetto@ccb3a54defb5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7faa07ec00be207dfc46ffd1054d757bd9df43af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076317Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744860}
-
Sean Gilhuly authored
ui::Compositor now interacts with DisplayPrivate directly instead of going through ContextFactoryPrivate. Remove these outdated comments. Bug: 1042259 Change-Id: Ie6ffe831e5cad188a415156feae9eeadde83d055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074816Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#744859}
-
Wez authored
ComponentContextForCurrentProcess() returns a sys::ComponentContext connected to the process' incoming service directory, outgoing directory for services & debugging APIs, etc. Provide a TestComponentContextForProcess, which overrides the process' ComponentContext with one which by default has no services available, and which allows services to be provided by the test itself, and for services available in the test process environment to be exposed to the test. Bug: 1038786 Change-Id: I0d754a1629ab25527dce377d6ffaa039791ef3e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064908Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#744858}
-
Peng Huang authored
The device level layers are depercated, and there is no device level layers for now, so remove it. https://www.khronos.org/registry/vulkan/specs/1.2-extensions/html/vkspec.html#extendingvulkan-layers-devicelayerdeprecation Bug: None Change-Id: I9507191ca515876a8d97140261bd4099f284dfe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075965Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
-
Ahmed Fakhry authored
The windows of removed desks should be demoted to be LRU across all desks. That's why they're appended at the end of the overview grid list. However, their relative order should be maintained. This CL makes sure the MRU order is updated to match the above expectation, as well as the windows' stacking order (that is windows of the removed desk should be stacked at the bottom of the target desk's container's children). BUG=1048271 TEST=Expanded existing tests. Change-Id: I06bc69e068e3ffc29bccf7a5983ed6d56fc04830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073366Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#744856}
-
Stefan Zager authored
BUG=1040262 R=pdr@chromium.org Change-Id: I57a115724aac7060de00ece59b8a7da8ca2c347f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076181 Auto-Submit: Stefan Zager <szager@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#744855}
-
Kent Tamura authored
Fold ControlClipRect implementations into LayoutBox::OverflowClipRect(). De-virtualize LayoutBox::HasControlClip(). As for LayoutFileUploadControl, fold ControlClipRect() into OverflowClipRect(). This CL is a preparation to remove LayoutMenuList. This CL has no behavior changes. Bug: 1040828 Change-Id: I7b68b0498e1554e44bf48de2778631859be2d1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073177Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#744854}
-
Jun Mukai authored
Bug: 1053039, 1053040 Test: none Change-Id: I422c5e2cb1a9511a55cb77c3c75c5fbc712ca792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071254 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#744853}
-
Mike Wittman authored
Requests that the sampling profiler apply metadata to samples between navigation start and first contentful paint, at the time when first contentful paint is sent to the browser process. This metadata will support analysis of execution during page load. This change introduces monotonic time interfaces for the required metrics because the existing interfaces are limited to 1ms resolution. If used they would result in up to 2% of samples being misidentified as occurring during loading when they weren't, or vice versa. This is a reland of http://crrev.com/742717 and adds logic to avoid applying metadata on time ranges that don't make sense but are occasionally seen in practice. TBR=npm@chromium.org,schenney@chromium.org Bug: 1034756, 1054357 Change-Id: Ie7e7a26b4e2c86219eb30dd678e5de296d2f59be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067287Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#744852}
-
Etienne Pierre-doray authored
Android doesn't support shared_library (see native_library_unittest.cc). base_profiler_test_support_library is defined as a loadable_module for upcoming support for android in stack_sampling_profiler_test https://chromium-review.googlesource.com/c/chromium/src/+/2055743/20 Bug: 989102 Change-Id: Iac0f2764f5177820436db93cc4966782a879308d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075158Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
-
- 26 Feb, 2020 21 commits
-
-
Pete Williamson authored
Feedback was being discarded at the server because the contextTag was of the wrong format. Bug: 1054987 Change-Id: I50032b571937a29e2ae63ce550efd25fda004ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076397Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#744850}
-
Alex Gough authored
Change-Id: Ie2c42ef76f31cfc3b0e3c7f2a720efb61c50e5cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072129Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#744849}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6422722cbaf6..31a7b072ddf4 git log 6422722cbaf6..31a7b072ddf4 --date=short --first-parent --format='%ad %ae %s' 2020-02-26 egdaniel@google.com Add stubbed out GrD3DOpsRenderPass class. 2020-02-26 brianosman@google.com Add most important intrinsics to the interpreter 2020-02-26 csmartdalton@google.com Remove GrMesh::SendToGpuImpl Created with: gclient setdep -r src/third_party/skia@31a7b072ddf4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I5eaaf6fff34d28b742b9dd1bfb4db488d0bb9aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076320Reviewed-by:
-
kylechar authored
This reverts commit 985a1f41. Reason for revert: https://crbug.com/1055738 Original change's description: > Don't disable draw during resize > > https://crrev.com/c/2011130 changed Display::DisableSwapUntilResize() to > also block draw instead of just swap. This had the side of effect of > blocking draw when the browser window is minimized, which means we stop > casting tab/window contents. Switch DisableSwapUntilResize() back to > just block swap instead of draw+swap. > > Bug: 1054239, b/149923568 > Change-Id: I66a10dc1e801c56783107ce4412ab557f70da9f8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068642 > Commit-Queue: kylechar <kylechar@chromium.org> > Reviewed-by: Saman Sami <samans@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744018} TBR=kylechar@chromium.org,samans@chromium.org,vasilyt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1054239, 1055738, b/149923568 Change-Id: I43a2f985c36fbc4f38e143beb650981acd1a3d7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076518Reviewed-by:
-
Mason Freed authored
The [1] CL enabled the FormControlsRefresh feature by default for Mac. (The [2] CL enabled it earlier for Windows, Linux, and ChromeOS.) In the process, many layout tests were disabled, because the form controls have a different appearance with the feature enabled. This is one of several patches rebaselining those disabled tests. [1] http://crrev.com/c/2063530 [2] http://crrev.com/c/1967608 Bug: 1053725 Change-Id: I8a95a67dbcd3cf8b3ddce9a6c8fe37f4ed498bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071386 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#744846}
-
Josip authored
Bug: 994805 Change-Id: I367fe4c751d494fff091860eca4329659a72a05b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062798 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#744845}
-
Alexey Baskakov authored
Given that: 1) ManifestUpdateManager is disabled for SystemWebApps. 2) SystemWebApps use their own update mechanism: force_reinstall. we should fix WebAppInstallFinalizer::FinalizeInstall() to always overwrite the app data. With this fix, all PendingAppManagerImplBrowserTest pass in both modes. Bug: 1053858 Change-Id: Ifdf0c45984769ce32bedcd5de42b872ba147fb9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071184 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#744844}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/d8d0c66b9c07..36f7f246a827 $ git log d8d0c66b9..36f7f246a --date=short --no-merges --format='%ad %ae %s' 2020-02-26 junyer Revert "Refuse to rewrite when MaxSubmatch() is too large." 2020-02-25 junyer Fall back to NFA execution when compiling the reverse Prog failed. 2020-02-25 junyer Refuse to rewrite when MaxSubmatch() is too large. 2020-02-20 junyer Tweak the comment on RE2::QuoteMeta(). 2020-02-17 junyer Move DeBruijnString() alongside StringGenerator. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Change-Id: Ie381fa483f9ef21d1cbc508934182617fa9334c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076159Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#744843}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/97edc4e61387..694f0d3726a4 Created with: gclient setdep -r src-internal@694f0d3726a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I24be036f095c5a2c679a507aa336b3ecd0c151fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076243Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744842}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 02b48dd0. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 8907cc01 "Update wpt NFC tests to use mojo mocks for unavailable impl" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I3e39f80718c480aa769c9f327abf11d608e9d28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075099Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744841}
-
David Maunder authored
This is so we are not bombarding the user with suggestions if they have given us a hint they are not interested in the feature. Bug: 1049801 Change-Id: Ifa0233b23c7c044113a65360f235ec61d9017aa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042145 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#744840}
-
Sophie Chang authored
This is a reland of 9a31f5ab Original change's description: > Reland "Add support for loading predictor to use hints from optimization guide" > > This is a reland of eed7024d > TBR=tbansal@chromium.org for chrome/browser/predictors/... > > Original change's description: > > Add support for loading predictor to use hints from optimization guide > > > > Will add metrics in a subsequent CL. This shouldn't affect any current > > metrics since the support is all behind a feature flag. > > > > Bug: 1050101 > > Change-Id: If6f98dbae86bb5842803cdb3c1b052d99711e62f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067241 > > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#743767} > > Bug: 1050101 > Change-Id: I796d2bbd322fee835bfc42f3f3bc903b65554291 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068313 > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744088} Bug: 1050101 Change-Id: I3450fa6cab159b22d0659532ea8f2524bf4944fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071380 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#744839}
-
Navid Zolghadr authored
Bug: 1045954 Change-Id: I1a52383a4b3240fdb87d93e07dd312385bca0156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071285Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#744838}
-
Steven Bennetts authored
* cr_elements/OWNERS would be left with one owner (michaelpg@), which we try to avoid, and who is not actively working on the webui platform at this time. Therefore the file was just removed. * webui/resources/OWNERS had some stale rules and a similar problem so was also removed. OWNERS for these directories will now resolve to ui/webui/PLATFORM_OWNERS. Bug: 1055481 Change-Id: I48d68399f2b97a9bc3e5ee5ea98c7b6fc6fee5d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074814Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#744837}
-
evliu authored
This CL updates CSS properties of the caption settings preview text box so that the height of the box increases with the font size, preventing the text from overflowing outside the div container and overlapping with elements before and after the container. Before & after screenshots: https://x20.corp.google.com/users/ev/evliu/Bug1055734 Bug: 1055734 Change-Id: Ia7e764503b82a9eab27b3beff98ba3774c5fcb2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073141Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#744836}
-
Gabriel Charette authored
Split chrome/ from https://chromium-review.googlesource.com/c/chromium/src/+/2026350 as it had trouble landing in one go. The following script was used to generate this CL (run on every C++ file in the codebase; processing .h before matching .cc/.mm): https://bugs.chromium.org/p/chromium/issues/detail?id=1026641#c22 (intentionally ignores cleaning post_task.h for now). TBR=fdoray@chromium.org Bug: 1026641 Change-Id: I3236dcea6d072ecb395c39983b29cee61f15ede3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075077Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#744835}
-
Karan Bhatia authored
This CL removes a failing DCHECK in ActionTracker destructor. The DCHECK probably fails because it seems we might not receive tab close notifications on shutdown. BUG=1055034 Change-Id: Ic597adb39fa37038e4349741e66eae62341cc0bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076520 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#744834}
-
Chris Cunningham authored
Bug: 1056300 Change-Id: I92957de2d72ac409e8e3bf23626baf3e4afcc28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075958 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#744833}
-
Ryan Harrison authored
BUG=dawn:345,dawn:354 Change-Id: I0ef71cc18397aa4854e8dc3e310e4031ab7be731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075044 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Auto-Submit: Ryan Harrison <rharrison@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#744832}
-
Collin Baker authored
Bug: 1055100 Change-Id: Ifd93d22fa73036fef81396db2b82ccc2bc73ca37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069020 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e93f058d4492..9abfc467c79f git log e93f058d4492..9abfc467c79f --date=short --first-parent --format='%ad %ae %s' 2020-02-26 bsheedy@chromium.org [Telemetry] Fix shlex.split on Windows Created with: gclient setdep -r src/third_party/catapult@9abfc467c79f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1056281 Tbr: sadrul@google.com Change-Id: Ic37f70e3c56506d55292b73de426a41324877d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075961Reviewed-by:
-
